Re: [Qemu-block] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-19 Thread Paolo Bonzini
On 19/09/2017 13:03, Vladimir Sementsov-Ogievskiy wrote: >>> >> I disagree that it is easier to extend it in the future. If some >> commands in the future need a different "how do we read it" (e.g. for >> structured reply), nbd_read_reply_entry may not have all the information >> it needs anymore.

Re: [Qemu-block] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2017 13:01, Paolo Bonzini wrote: On 19/09/2017 11:25, Vladimir Sementsov-Ogievskiy wrote: 18.09.2017 18:43, Paolo Bonzini wrote: On 18/09/2017 15:59, Vladimir Sementsov-Ogievskiy wrote: Read the whole reply in one place - in nbd_read_reply_entry. Signed-off-by: Vladimir Sementsov-Ogievs

Re: [Qemu-block] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-19 Thread Paolo Bonzini
On 19/09/2017 11:25, Vladimir Sementsov-Ogievskiy wrote: > 18.09.2017 18:43, Paolo Bonzini wrote: >> On 18/09/2017 15:59, Vladimir Sementsov-Ogievskiy wrote: >>> Read the whole reply in one place - in nbd_read_reply_entry. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> block/nbd

Re: [Qemu-block] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2017 18:43, Paolo Bonzini wrote: On 18/09/2017 15:59, Vladimir Sementsov-Ogievskiy wrote: Read the whole reply in one place - in nbd_read_reply_entry. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.h | 1 + block/nbd-client.c | 42 ---

Re: [Qemu-block] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-18 Thread Eric Blake
On 09/18/2017 10:43 AM, Paolo Bonzini wrote: > On 18/09/2017 15:59, Vladimir Sementsov-Ogievskiy wrote: >> Read the whole reply in one place - in nbd_read_reply_entry. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> block/nbd-client.h | 1 + >> block/nbd-client.c | 42 +++

Re: [Qemu-block] [PATCH v2 3/7] block/nbd-client: refactor reading reply

2017-09-18 Thread Paolo Bonzini
On 18/09/2017 15:59, Vladimir Sementsov-Ogievskiy wrote: > Read the whole reply in one place - in nbd_read_reply_entry. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd-client.h | 1 + > block/nbd-client.c | 42 -- > 2 files changed, 25 i