Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-11-05 Thread Peter Maydell
On 4 November 2018 at 22:03, Paolo Bonzini wrote: > On 02/11/2018 14:33, Peter Maydell wrote: >> On 9 October 2018 at 12:16, Paolo Bonzini wrote: >>> Yup, we have to stop using pthread_key_create. Luckily, these days >>> there is always qemu_thread_start that wraps the thread, so we can call >>>

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-11-04 Thread Paolo Bonzini
On 02/11/2018 14:33, Peter Maydell wrote: > On 9 October 2018 at 12:16, Paolo Bonzini wrote: >> On 08/10/2018 18:40, Kevin Wolf wrote: I'm pretty confident this analysis of the problem is correct: unfortunately I have no idea what the right way to fix it is... >>> Yes, I agree with

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-11-02 Thread Peter Maydell
On 9 October 2018 at 12:16, Paolo Bonzini wrote: > On 08/10/2018 18:40, Kevin Wolf wrote: >>> >>> I'm pretty confident this analysis of the problem is correct: >>> unfortunately I have no idea what the right way to fix it is... >> Yes, I agree with your analysis. If __thread variables can be destr

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-09 Thread Paolo Bonzini
On 08/10/2018 18:40, Kevin Wolf wrote: >> >> I'm pretty confident this analysis of the problem is correct: >> unfortunately I have no idea what the right way to fix it is... > Yes, I agree with your analysis. If __thread variables can be destructed > before pthread_key_create() destructors are call

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-09 Thread Kevin Wolf
Am 08.10.2018 um 21:53 hat Eric Blake geschrieben: > On 10/8/18 11:40 AM, Kevin Wolf wrote: > > Am 08.10.2018 um 17:43 hat Peter Maydell geschrieben: > > > Looking at the backtraces I'm wondering if this is the result of > > > an implicit reliance on the order in which per-thread destructors > > >

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-08 Thread Eric Blake
On 10/8/18 11:40 AM, Kevin Wolf wrote: Am 08.10.2018 um 17:43 hat Peter Maydell geschrieben: Looking at the backtraces I'm wondering if this is the result of an implicit reliance on the order in which per-thread destructors are called (which is left unspecified by POSIX) -- the destructor functi

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-08 Thread Peter Maydell
On 8 October 2018 at 17:40, Kevin Wolf wrote: > By the way, can you reproduce this with virtio-blk/scsi and an iothread > in a real QEMU or is it only the test case that fails? In theory, I > don't see what would prevent QEMU from hanging at shutdown. I haven't tested, but I suspect this is less

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-08 Thread Kevin Wolf
Am 08.10.2018 um 17:43 hat Peter Maydell geschrieben: > Looking at the backtraces I'm wondering if this is the result of > an implicit reliance on the order in which per-thread destructors > are called (which is left unspecified by POSIX) -- the destructor > function qemu_thread_atexit_run() is cal

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-08 Thread Peter Maydell
On 8 October 2018 at 10:12, Peter Maydell wrote: > I looked back at the backtrace/etc that I posted earlier in this > thread, and it looked to me like maybe a memory corruption issue. > So I tried running the test under valgrind on Linux, and: ...which goes away if I do a complete build from clea

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-08 Thread Peter Maydell
On 5 October 2018 at 19:09, Kevin Wolf wrote: > And if we disable it wholesale, then nobody has any incentive to fix any > bug that the test case could have uncovered. Yes, that's fair. I'm sorry; I was a bit grumpy when I wrote that email because my test runs had been bumping into it all day. >

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-05 Thread Kevin Wolf
Am 05.10.2018 um 18:54 hat Peter Maydell geschrieben: > On 5 October 2018 at 17:17, Kevin Wolf wrote: > > Am 05.10.2018 um 16:41 hat Peter Maydell geschrieben: > >> On 5 October 2018 at 15:38, Peter Maydell wrote: > >> > The test-bdrv-drain test fails at least 50% of the time > >> > on my OS buil

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-05 Thread Peter Maydell
On 5 October 2018 at 17:17, Kevin Wolf wrote: > Am 05.10.2018 um 16:41 hat Peter Maydell geschrieben: >> On 5 October 2018 at 15:38, Peter Maydell wrote: >> > The test-bdrv-drain test fails at least 50% of the time >> > on my OS build system. Disable the test until we can figure >> >> This is a t

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-05 Thread Kevin Wolf
Am 05.10.2018 um 16:41 hat Peter Maydell geschrieben: > On 5 October 2018 at 15:38, Peter Maydell wrote: > > The test-bdrv-drain test fails at least 50% of the time > > on my OS build system. Disable the test until we can figure > > This is a typo: I meant "OSX build system". > > > out what's go

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-10-05 Thread Peter Maydell
On 5 October 2018 at 15:38, Peter Maydell wrote: > The test-bdrv-drain test fails at least 50% of the time > on my OS build system. Disable the test until we can figure This is a typo: I meant "OSX build system". > out what's going on, as this makes pull request processing > very difficult. > >