Re: What is bs->reqs_lock for?

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
18.08.2020 09:16, Paolo Bonzini wrote: On 13/08/20 18:34, Vladimir Sementsov-Ogievskiy wrote: I thought bs is attached to one aio context and aio context attached to one iothread. For now yes, but with multiqueue there would be many iothreads sending requests to the AioContext. The BDS would

Re: What is bs->reqs_lock for?

2020-08-18 Thread Paolo Bonzini
On 13/08/20 18:34, Vladimir Sementsov-Ogievskiy wrote: > I thought bs is attached to one aio context and aio context attached to > one iothread. For now yes, but with multiqueue there would be many iothreads sending requests to the AioContext. The BDS would still have a "home" aiocontext to

Re: What is bs->reqs_lock for?

2020-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2020 18:54, Paolo Bonzini wrote: On 13/08/20 16:57, Vladimir Sementsov-Ogievskiy wrote: Hi! Sorry my stupid question, but which kind of concurrent access bs->reqs_lock prevents? In my understanding the whole logic of request tracking for the bs is going in the coroutine, so, we don't

Re: What is bs->reqs_lock for?

2020-08-13 Thread Paolo Bonzini
On 13/08/20 16:57, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > Sorry my stupid question, but which kind of concurrent access > bs->reqs_lock prevents? > > In my understanding the whole logic of request tracking for the bs is > going in the coroutine, so, we don't have parallel access anyway?

What is bs->reqs_lock for?

2020-08-13 Thread Vladimir Sementsov-Ogievskiy
Hi! Sorry my stupid question, but which kind of concurrent access bs->reqs_lock prevents? In my understanding the whole logic of request tracking for the bs is going in the coroutine, so, we don't have parallel access anyway? How can parallel access to bs->tracked_requests happen? -- Best