Re: [PATCH 08/23] iotests/143: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/143 | 6 +++--- tests/qemu-iotests/143.out | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [PATCH 20/23] iotests/223: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/223 | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization:

Re: [PATCH 19/23] iotests/222: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/222 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222 index 0ead56d574..3f9f934ad8 100644 ---

Re: [PATCH 18/23] iotests/209: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/209 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/209 b/tests/qemu-iotests/209 index 259e991ec6..e0f464bcbe 100755 ---

[PATCH v2 1/2] nbd: Don't send oversize strings

Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere near the NBD spec maximum of a 4k limit per string. However, we weren't actually enforcing

[PATCH v2 0/2] Better NBD string length handling

Patch 1 is a revised version after Maxim's comments - it moves the length checks earlier into the system (for cleaner error messages as soon as possible) and adds asserts at the later points that are now guaranteed by the earlier checks. It also covers more string handling, both in the client and

Re: [PATCH 01/23] iotests: Introduce $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Unix sockets generally have a maximum path length. Depending on your $TEST_DIR, it may be exceeded and then all tests that create and use Unix sockets there may fail. Circumvent this by adding a new scratch directory specifically for Unix socket files.

Re: [PATCH 17/23] iotests/208: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/208 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/208 b/tests/qemu-iotests/208 index 1e202388dc..546eb1de3e 100755 ---

Re: [PATCH 16/23] iotests/205: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/205 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205 index 76f6c5fa2b..4bb2c21e8b 100755 ---

Re: [PATCH 23/23] iotests: Drop TEST_DIR filter from _filter_nbd

On 10/10/19 10:24 AM, Max Reitz wrote: Sockets should be placed into $SOCK_DIR instead of $TEST_DIR, so remove the $TEST_DIR filter from _filter_nbd. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.filter | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 21/23] iotests/240: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/240 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/240 b/tests/qemu-iotests/240 index f73bc07d80..8b4337b58d 100755 ---

Re: [PATCH 04/23] iotests: Filter $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/common.filter | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) @@ -218,7 +221,8 @@ _filter_nbd() # Filter out the TCP port number since this changes between runs. $SED -e

Re: [PATCH 04/23] iotests: Filter $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/common.filter | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 9f418b4881..cd42f5e7e3 100644 ---

Re: [PATCH 07/23] iotests/140: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/140 | 8 tests/qemu-iotests/140.out | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [PATCH 14/23] iotests/194: Create sockets in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/194 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194 index d746ab1e21..72e47e8833 100755 ---

[PATCH v2 2/2] nbd: Allow description when creating NBD blockdev

Allow blockdevs to match the feature already present in qemu-nbd -D. Enhance iotest 223 to cover it. Signed-off-by: Eric Blake --- qapi/block.json| 8 +--- blockdev-nbd.c | 9 - monitor/hmp-cmds.c | 4 ++-- tests/qemu-iotests/223 | 2 +-

Re: [PATCH 03/23] iotests.py: Add @base_dir to FilePaths etc.

On 10/10/19 10:24 AM, Max Reitz wrote: Specifying this optional parameter allows creating temporary files in other directories than the test_dir; for example in sock_dir. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [PATCH 10/23] iotests/181: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/181 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181 index e317e63422..378c2899d1 100755 ---

Re: [PATCH 09/23] iotests/147: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/147 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147 index ab8480b9a4..03fc2fabcf 100755 ---

Re: [PATCH 11/23] iotests/182: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/182 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/182 b/tests/qemu-iotests/182 index 7f494eb9bb..1ccb850055 100755 ---

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

On 10/10/19 7:54 AM, Peter Krempa wrote: > On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote: >> On 10/10/19 1:26 PM, Peter Krempa wrote: >>> On Thu, Oct 10, 2019 at 13:22:37 +0200, Philippe Mathieu-Daudé wrote: On 10/10/19 12:43 AM, John Snow wrote: > It's an old

Re: [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

On 10/10/19 11:39 AM, Eric Blake wrote: > On 6/7/19 1:53 PM, Vladimir Sementsov-Ogievskiy wrote: >> 07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote: >>> qcow2_can_store_new_dirty_bitmap works wrong, as it considers only >>> bitmaps already stored in the qcow2 image and ignores persistent

Re: [PATCH 05/23] iotests: Let common.nbd create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: In addition, drop the nbd_unix_socket assignment in 241 because it does not really do anything. Agreed, it duplicates the setting inherited by sourcing common.nbd. Signed-off-by: Max Reitz --- tests/qemu-iotests/241| 2 --

Re: [PATCH 06/23] iotests/083: Create socket in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/083 | 6 +++--- tests/qemu-iotests/083.out | 34 +- 2 files changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software

Re: [PATCH 14/23] iotests/194: Create sockets in $SOCK_DIR

On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/194 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194 index d746ab1e21..72e47e8833 100755 --- a/tests/qemu-iotests/194 +++

Re: [PATCH v3 0/8] hw: Convert various reset() handler to DeviceReset

Queueing on machine-next. Thanks! On Thu, Oct 10, 2019 at 03:15:19PM +0200, Philippe Mathieu-Daudé wrote: > Only patch 3/8 is missing review: > - hw/ide/piix: Convert reset handler to DeviceReset > > Since v2: > - Fixed PIIX_IDE conversion (Li) > - Added more R-b tag. > > Since v1: > - Removed

<    1   2