Re: [RFC v3 0/6] virtio,vhost: Add VIRTIO_F_IN_ORDER support

2024-04-15 Thread Lei Yang
QE tested this series with packed=on/off, in_order=true and vhost=off under regression tests, everything are works fine. Tested-by: Lei Yang On Mon, Apr 8, 2024 at 11:34 PM Jonah Palmer wrote: > > The goal of these patches is to add support to a variety of virtio and > vhost devices for the

[RFC 1/1] hw/nvme: add atomic write support

2024-04-15 Thread Alan Adamson
Forces writes to be atomic based on new atomic write parameters. New NVMe QEMU Parameters (See NVMe Specification for details): atomic.dn (default off) - Set the value of Disable Normal. atomic.awun=UINT16 (default: 0) atomic.awupf=UINT16 (default: 0)

[RFC 0/1] hw/nvme: add atomic write support

2024-04-15 Thread Alan Adamson
Since there is discussion in the Linux NVMe Driver community to add NVMe Atomic Write support, it would be desirable to test it with qemu nvme emulation. Initially, this RFC will focus on supporting NVMe controller atomic write parameters(AWUN, AWUPF, and ACWU) but will be extended to support

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 09:40:11AM -0500, Eric Blake wrote: > On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: > > Since version 2.66, glib has useful URI parsing functions, too. > > Use those instead of the QEMU-internal ones to be finally able > > to get rid of the latter. > > > >

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. > > Signed-off-by: Thomas Huth > --- > block/gluster.c | 71

Re: [PATCH v2 08/13] Remove glib compatibility code that is not required anymore

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:10PM +0200, Thomas Huth wrote: > Now that we bumped the minumum glib version to 2.66, we can drop > the old code. > > Suggested-by: Paolo Bonzini > Signed-off-by: Thomas Huth > --- > qga/commands-posix-ssh.c | 8 > util/error-report.c | 10

Re: [PATCH v2 07/13] Bump minimum glib version to v2.66

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:09PM +0200, Thomas Huth wrote: > Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can > look into bumping the glib version to a new minimum for further > clean-ups. According to repology.org, available versions are: > > CentOS Stream 9: 2.66.7 >

Re: [PATCH v2 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:08PM +0200, Thomas Huth wrote: > From: Paolo Bonzini > > RHEL 9 (and thus also the derivatives) are available since two years > now, so according to QEMU's support policy, we can drop the active > support for the previous major version 8 now. > > Thus upgrade our

Re: [PATCH v2 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:07PM +0200, Thomas Huth wrote: > According to our support policy, we'll soon drop our official support > for Ubuntu 20.04 ("Focal Fossa") in QEMU. Thus we should update the > Travis jobs now to a newer release (Ubuntu 22.04 - "Jammy Jellyfish") > for future testing.

Re: [PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote: > RHEL 9 (and thus also the derivatives) are available since two years > now, so according to QEMU's support policy, we can drop the active > support for the previous major version 8 now. > Thus upgrade our CentOS Stream container to

Re: [PATCH v2 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:05PM +0200, Thomas Huth wrote: > This update adds the removing of the EXTERNALLY-MANAGED marker files > that has been added to the lcitool recently. For those who don't know, python now commonly blocks the ability to run 'pip install' outside of a venv. This

Re: [PATCH v2 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:04PM +0200, Thomas Huth wrote: > We need the latest fixes for the lcitool to be able to properly > update our CentOS docker file to CentOS Stream 9. > > Signed-off-by: Thomas Huth > --- > tests/lcitool/libvirt-ci | 2 +- > 1 file changed, 1 insertion(+), 1

MAINTAINERS tweak [was: [PATCH for-9.1 0/9] Switch to glib URI parsing code]

2024-04-15 Thread Eric Blake
[Trying Peter Lieven's alternate address...] On Thu, Mar 28, 2024 at 03:05:57PM +0100, Thomas Huth wrote: > In the QEMU 9.1 development cycle, we can drop the support for > Ubuntu 20.04 and CentOS 8 since the following major versions of > these distributions are available since 2 years already.

Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()

2024-04-15 Thread Cédric Le Goater
On 4/12/24 17:25, Alex Williamson wrote: On Wed, 10 Apr 2024 18:06:03 +0200 Philippe Mathieu-Daudé wrote: sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, resulting in painful developper experience. Use g_strdup_printf() instead. Isn't this code only compiled for Linux

Re: [PATCH v2 11/15] hw/southbridge/ich9: Add a AHCI function

2024-04-15 Thread Bernhard Beschow
Am 26. Februar 2024 11:14:10 UTC schrieb "Philippe Mathieu-Daudé" : >Instantiate TYPE_ICH9_AHCI in TYPE_ICH9_SOUTHBRIDGE. > >Since the PC machines can disable SATA (see the >PC_MACHINE_SATA dynamic property), add the 'sata-enabled' >property to disable it. > >Signed-off-by: Philippe

Re: [PATCH v2] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint`

2024-04-15 Thread Philippe Mathieu-Daudé
On 14/4/24 19:28, Inès Varhol wrote: The messages for assertions using hexadecimal numbers will be easier to understand with `g_assert_cmphex`. Cases changed : "cmpuint.*0x", "cmpuint.*<<" Signed-off-by: Inès Varhol --- tests/qtest/aspeed_fsi-test.c | 20 ++--

Re: [PATCH v2 03/13] hw/ppc/spapr: Replace sprintf() by snprintf()

2024-04-15 Thread Harsh Prateek Bora
On 4/11/24 15:45, Philippe Mathieu-Daudé wrote: sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, resulting in painful developper experience. s/developper/developer ? Replace sprintf() by snprintf() in order to avoid: hw/ppc/spapr.c:385:5: warning: 'sprintf' is