Re: [PULL 00/33] Block patches

2020-11-04 Thread Peter Maydell
On Wed, 4 Nov 2020 at 15:18, Stefan Hajnoczi wrote: > > The following changes since commit 8507c9d5c9a62de2a0e281b640f995e26eac46af: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2020-11-03 15:59:44 +) > > are available in the Git repository at: > > ht

[PATCH for-5.2] block/export/vhost-user-blk-server.c: Avoid potential integer overflow

2020-11-09 Thread Peter Maydell
1435956 Signed-off-by: Peter Maydell --- Tested with 'make check' and 'make check-acceptance' only. --- block/export/vhost-user-blk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-use

Re: [PULL v2 00/15] Block patches for 5.2.0-rc1

2020-11-09 Thread Peter Maydell
On Mon, 9 Nov 2020 at 17:50, Max Reitz wrote: > > The following changes since commit 2a190a7256a3e0563b29ffd67e0164097b4a6dac: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/renesas-fixes-20201109' into staging (2020-11-09 > 11:20:25 +) > > are available in the Git reposito

Re: [PULL for-5.2 0/2] Tracing patches

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 15:57, Stefan Hajnoczi wrote: > > The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c: > > Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +) > > are available in the Git repository at: > > https://gitlab.com/stefanha/qemu.git tags/

iotest 030 still occasionally intermittently failing

2020-11-16 Thread Peter Maydell
Just saw this on a test run on the OpenBSD VM build-and-test, so this test is still intermittently failing... TESTiotest-qcow2: 030 [fail] QEMU -- "/home/qemu/qemu-test.h37iBt/build/tests/qemu-iotests/../../qemu-system-aarch64" -nodefaults -display none -accel qtest -machine virt Q

Re: iotest 030 still occasionally intermittently failing

2020-11-16 Thread Peter Maydell
On Mon, 16 Nov 2020 at 17:34, Alberto Garcia wrote: > Do you know if there is a core dump or stack trace available ? Nope, sorry. What you get is what the 'vm-build-netbsd' etc targets produce, so if you want more diagnostics on failures you have to arrange for the test harness to produce them...

Re: [PULL 0/1] SD/MMC patches for 2020-11-17

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 10:54, Philippe Mathieu-Daudé wrote: > > The following changes since commit cb5ed407a1ddadf788fd373fed41c87c9e81e5b0: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2020-11-15' into staging (2020-11-16 > 17:00:36 +) > > are available in the

Re: [PULL 0/7] Patches for 5.2.0-rc2

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 12:16, Kevin Wolf wrote: > > The following changes since commit bce36c6c5436c0c2679b42c6de54de5393dfcf59: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2020-11-16 22:29:51 +) > > are available in the Git repository at: > >

Re: [PULL for-5.2 0/1] Tracing patches

2020-11-19 Thread Peter Maydell
On Thu, 19 Nov 2020 at 16:48, Stefan Hajnoczi wrote: > > The following changes since commit ff85db769ffd431f86d263d5e954e809a83be92f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201119' into > staging (2020-11-19 10:36:53 +) > > are available in the Git repository at: > >

Re: [PULL 00/33] Block patches

2020-11-23 Thread Peter Maydell
On Mon, 23 Nov 2020 at 12:55, Philippe Mathieu-Daudé wrote: > > On 11/4/20 9:59 PM, Peter Maydell wrote: > > On Wed, 4 Nov 2020 at 15:18, Stefan Hajnoczi wrote: > >> > >> The following changes since commit > >> 8507c9d5c9a62de2a0e281b640f995e26eac46af: &

Re: [PULL 0/1] Block layer patches for 5.2.0-rc3

2020-11-24 Thread Peter Maydell
On Tue, 24 Nov 2020 at 14:25, Kevin Wolf wrote: > > The following changes since commit 23895cbd82be95428e90168b12e925d0d3ca2f06: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201123.0' > into staging (2020-11-23 18:51:13 +) > > are available in the Git repository at:

Re: [PULL 1/1] hw/sd: Fix 2 GiB card CSD register values

2020-11-30 Thread Peter Maydell
On Mon, 30 Nov 2020 at 12:53, Bin Meng wrote: > > +Peter, > > On Tue, Nov 17, 2020 at 6:52 PM Philippe Mathieu-Daudé > wrote: > > > > From: Bin Meng > > > > Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 > > bytes, hence the READ_BL_LEN field in the CSD register shall be 10

Re: [PULL 00/34] Block layer patches

2020-12-12 Thread Peter Maydell
On Fri, 11 Dec 2020 at 17:08, Kevin Wolf wrote: > > The following changes since commit b785d25e91718a660546a6550f64b3c543af7754: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2020-12-11 13:50:35 +) > > are available in the Git repository at: > >

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Peter Maydell
On Sun, 13 Dec 2020 at 17:21, Laurent Vivier wrote: > > Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit : > > Cc'ing qemu-trivial@ since this patch is reviewed. > > > > On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote: > >> ping^2... > >> > >> On 10/1/20 7:31 PM, Philippe Mathieu-Daudé wrot

Re: [PATCH v3] hw/block/nand: Decommission the NAND museum

2020-12-14 Thread Peter Maydell
-dev88 > - tosa (via tc6393xb_init) > - spitz based (akita, borzoi, terrier) > > Reviewed-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > v3: Do not manually convert tabs to space to avoid mistakes... Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 0/4] hw/block/m25p80: Numonyx: Fix dummy cycles and check for SPI mode on cmds

2020-12-15 Thread Peter Maydell
On Mon, 16 Nov 2020 at 23:13, Joe Komlodi wrote: > > Changelog: > v4 -> v5 > - 3/4: Simplify logic when changing state and checking mode. > - 3/4: numonyx_get_mode -> numonyx_mode > - 4/4: Reword commit message to include QIO mode. > > v3 -> v4 > - 1/4: Patch changed to change names of registe

Re: [PATCH v3 1/3] docs: generate qemu-storage-daemon-qmp-ref(7) man page

2020-12-16 Thread Peter Maydell
On Wed, 16 Dec 2020 at 16:21, Stefan Hajnoczi wrote: > > On Tue, Dec 15, 2020 at 05:11:06PM +0100, Kevin Wolf wrote: > > > diff --git a/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > b/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > new file mode 100644 > > > index 00..caf9dad23a >

Re: [Qemu-block] [Qemu-devel] [PULL 00/14] Block layer patches

2017-09-07 Thread Peter Maydell
On 6 September 2017 at 15:02, Kevin Wolf wrote: > The following changes since commit 98bfaac788be0ca63d7d010c8d4ba100ff1d8278: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-09-01-v3' > into staging (2017-09-04 13:28:09 +0100) > > are available in the git repository at: >

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu.py: Fix syntax error

2017-09-18 Thread Peter Maydell
On 18 September 2017 at 06:25, Kevin Wolf wrote: > Python requires parentheses around multiline expression. This fixes the > breakage of all Python-based qemu-iotests cases that was introduced in > commit dab91d9aa0. > > Signed-off-by: Kevin Wolf > --- > > Eduardo, I think I'm going to include th

Re: [Qemu-block] [PATCH 03/34] block: remove "qemu/osdep.h" from header file

2017-09-22 Thread Peter Maydell
..2ecf239ba5 100644 > --- a/block/dmg.h > +++ b/block/dmg.h > @@ -26,7 +26,6 @@ > #ifndef BLOCK_DMG_H > #define BLOCK_DMG_H > > -#include "qemu/osdep.h" > #include "qemu-common.h" > #include "block/block_int.h" > #include > -- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-block] [PULL 00/24] Block layer patches

2017-09-27 Thread Peter Maydell
On 26 September 2017 at 07:21, Kevin Wolf wrote: > The following changes since commit 1e3ee834083227f552179f6e43902cba5a866e6b: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2017-09-25 20:31:24 +0100) > > are available in the git repository at: > > g

Re: [Qemu-block] [Qemu-arm] [Qemu-devel] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__

2017-09-27 Thread Peter Maydell
On 26 September 2017 at 06:32, Eric Blake wrote: > On 09/25/2017 07:08 PM, Alistair Francis wrote: >> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c >> index 58005b6619..32687afced 100644 >> --- a/hw/arm/nseries.c >> +++ b/hw/arm/nseries.c >> @@ -463,7 +463,7 @@ static uint32_t mipid_txrx(void *

Re: [Qemu-block] [Qemu-devel] [PULL 00/54] Block layer patches

2017-10-06 Thread Peter Maydell
On 6 October 2017 at 16:53, Kevin Wolf wrote: > The following changes since commit a26a98dfb9d448d7234d931ae3720feddf6f0651: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20171006' into > staging (2017-10-06 13:19:03 +0100) > > are available in the git repository at: > > git://r

Re: [Qemu-block] [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-11 Thread Peter Maydell
On 10 October 2017 at 09:02, Kevin Wolf wrote: > Assertions are for checking that assumptions in qemu code hold true. > Here it's about bad guest code, and you can't let qemu abort for that. > > Tracing is the right tool to detect bad guest code, and I think it makes > sense to mark conditions tha

Re: [Qemu-block] [Qemu-devel] [PULL 00/35] Block layer patches

2017-10-27 Thread Peter Maydell
On 26 October 2017 at 14:17, Kevin Wolf wrote: > The following changes since commit ae49fbbcd8e4e9d8bf7131add34773f579e1aff7: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171025' into > staging (2017-10-25 16:38:57 +0100) > > are available in the git repository at: > > git://

Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] Add 8-byte wide AMD flash support, partial interleaving

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 15:44, Mike Nawrocki wrote: > This patch set does a few things. First, it switches the AMD CFI flash MMIO > operations from the old MMIO API to the new one. Second, it enables 8-byte > wide flash arrays. Finally, it supports rudimentary interleaving of notional > flash "chips

Re: [Qemu-block] [Qemu-devel] [PULL 33/54] block: Introduce BdrvChildRole.update_filename

2017-11-03 Thread Peter Maydell
On 6 October 2017 at 16:54, Kevin Wolf wrote: > There is no good reason for bdrv_drop_intermediate() to know the active > layer above the subchain it is operating on - even more so, because > the assumption that there is a single active layer above it is not > generally true. > > In order to prepa

[Qemu-block] using "qemu-img convert -O qcow2" to convert qcow v1 to v2 creates a qcow v3 file?

2017-11-13 Thread Peter Maydell
I have a qcow v1 file which I created by mistake (forgetting that you need to tell qemu-img create 'qcow2' and not just 'qcow'), which I want to convert to a v2 file so I can put snapshots into it. But when I try to do this with qemu-img convert it creates a v3 file instead: $ file hda-old.qcow hd

Re: [Qemu-block] using "qemu-img convert -O qcow2" to convert qcow v1 to v2 creates a qcow v3 file?

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 17:14, Peter Maydell wrote: > I have a qcow v1 file which I created by mistake (forgetting that > you need to tell qemu-img create 'qcow2' and not just 'qcow'), > which I want to convert to a v2 file so I can put snapshots into > it. But whe

Re: [Qemu-block] [PULL 00/20] Block patches for 2.11.0-rc1

2017-11-14 Thread Peter Maydell
On 14 November 2017 at 17:23, Max Reitz wrote: > The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-11-14 16:11:19 +) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL 00/20] Block patches for 2.11.0-rc1

2017-11-14 Thread Peter Maydell
On 14 November 2017 at 17:23, Max Reitz wrote: > The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-11-14 16:11:19 +) > > are available in the git repository at: > >

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()

2017-11-15 Thread Peter Maydell
On 6 November 2017 at 16:55, Kevin Wolf wrote: > error_setg_errno() takes a positive errno code. > > Signed-off-by: Kevin Wolf > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index 684cb018da..f6415547fe 100644 > --- a/block.c > +++ b/

Re: [Qemu-block] [Qemu-devel] [PULL 00/25] Block layer patches for 2.11.0-rc2

2017-11-20 Thread Peter Maydell
On 17 November 2017 at 18:16, Kevin Wolf wrote: > The following changes since commit fec035a53fa15c4c8c4e62bfef56a35df4161e38: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20171117-pull-request' > into staging (2017-11-17 10:18:41 +) > > are available in the git repository at: >

Re: [Qemu-block] [Qemu-devel] [PULL 00/25] Block layer patches for 2.11.0-rc2

2017-11-20 Thread Peter Maydell
On 20 November 2017 at 15:24, Kevin Wolf wrote: > Am 20.11.2017 um 15:53 hat Peter Maydell geschrieben: >> GTESTER tests/test-replication >> ** >> ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:117:test_blk_write: >> assertion failed: (async

Re: [PULL 00/25] python-next patches for 2020-05-31

2020-06-01 Thread Peter Maydell
On Sun, 31 May 2020 at 17:40, Philippe Mathieu-Daudé wrote: > > The following changes since commit c86274bc2e34295764fb44c2aef3cf29623f9b4b: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-tcg-plugins= > -270520-1' into staging (2020-05-29 17:41:45 +0100) > > are available in

Re: [PATCH] hw/block/pflash_cfi01: Limit maximum flash size to 256 MiB

2020-06-04 Thread Peter Maydell
On Thu, 4 Jun 2020 at 16:16, Philippe Mathieu-Daudé wrote: > On 5/25/20 10:59 PM, Peter Maydell wrote: > > What problem is this check solving? Is there some implementation > > imposed limitation or a limit within the flash header format > > that means larger sizes don'

Re: [PATCH] hw/block/pflash_cfi01: Limit maximum flash size to 256 MiB

2020-06-04 Thread Peter Maydell
On Thu, 4 Jun 2020 at 16:55, Philippe Mathieu-Daudé wrote: > > On 6/4/20 5:30 PM, Peter Maydell wrote: > > Not really; I think we should know what we're limiting against. > > Currently you're checking total_len, but this is just sector_len * nb_blocs, > > so if

Re: [PULL 00/11] Block patches

2020-06-05 Thread Peter Maydell
On Fri, 5 Jun 2020 at 10:48, Stefan Hajnoczi wrote: > > The following changes since commit 66234fee9c2d37bfbc523aa8d0ae5300a14cc10e: > > Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-202= > 00603' into staging (2020-06-04 11:38:48 +0100) > > are available in the Git rep

Re: [PATCH v3 04/11] hw/sd/sdcard: Restrict Class 6 commands to SCSD cards

2020-06-15 Thread Peter Maydell
Command Functional Difference in Card Capacity Types > > * Write Protected Group > > SDHC and SDXC do not support write-protected groups. Issuing > CMD28, CMD29 and CMD30 generates the ILLEGAL_COMMAND error. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 02/11] hw/sd/sdcard: Update coding style to make checkpatch.pl happy

2020-06-15 Thread Peter Maydell
On Fri, 5 Jun 2020 at 11:24, Philippe Mathieu-Daudé wrote: > > To make the next commit easier to review, clean this code first. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-

Re: [PATCH v3 03/11] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-06-15 Thread Peter Maydell
On Fri, 5 Jun 2020 at 11:25, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Only move the state machine to ReceivingData if there is no > pending error. This avoids later OOB access while processing > commands queued. > > "SD Specifications Part 1 Physical Layer Simplified

Re: [PATCH v3 05/11] hw/sd/sdcard: Update the SDState documentation

2020-06-15 Thread Peter Maydell
On Fri, 5 Jun 2020 at 11:22, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Add more descriptive comments to keep a clear separation > between static property vs runtime changeable. > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Da

Re: [PATCH v3 06/11] hw/sd/sdcard: Simplify cmd_valid_while_locked()

2020-06-15 Thread Peter Maydell
+++-- > 1 file changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 08/11] hw/sd/sdcard: Make iolen unsigned

2020-06-15 Thread Peter Maydell
On Fri, 5 Jun 2020 at 11:27, Philippe Mathieu-Daudé wrote: > > I/O request length can not be negative. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 2 +- > hw/sd/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/

Re: [PATCH v3 10/11] hw/sd/sdcard: Display offset in read/write_data() trace events

2020-06-15 Thread Peter Maydell
On Fri, 5 Jun 2020 at 11:32, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Having 'base address' and 'relative offset' displayed > separately is more helpful than the absolute address. > > Signed-off-by: Philippe Mathieu-Daudé &

Re: [PATCH v3 09/11] hw/sd/sdcard: Correctly display the command name in trace events

2020-06-15 Thread Peter Maydell
On Fri, 5 Jun 2020 at 11:25, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Some ACMD were incorrectly displayed. Fix by remembering if we > are processing a ACMD (with current_cmd_is_acmd) and add the > sd_current_cmd_name() helper, which display to correct name > regardless

Re: [PATCH v3 11/11] hw/sd/sdcard: Simplify realize() a bit

2020-06-15 Thread Peter Maydell
ot;Cannot use read-only drive as SD card"); > +return; > +} > + > ret = blk_set_perm(sd->blk, BLK_PERM_CONSISTENT_READ | > BLK_PERM_WRITE, > BLK_PERM_ALL, errp); > if (ret < 0) { Originally written with the pattern of "check all the error cases first; then do actual work". But if you prefer this way around Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 00/43] Block layer patches

2020-06-18 Thread Peter Maydell
On Wed, 17 Jun 2020 at 15:49, Kevin Wolf wrote: > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > (2020-06-16 14:57:15 +0100) > > are available in the Git re

Re: [PULL 00/18] Block patches

2020-06-23 Thread Peter Maydell
On Mon, 22 Jun 2020 at 16:11, Max Reitz wrote: > > The following changes since commit bae31bfa48b9caecee25da3d5333901a126a06b4: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20200619-pull-request' into staging (2020-06-19 > 22:56:59 +0100) > > are available in the Git repositor

Re: [PULL 00/12] Block patches

2020-06-25 Thread Peter Maydell
On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > The following changes since commit 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > (2020-06-22 14:45:25 +0100) > > are available in the Gi

Re: [PULL 00/12] Block patches

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > > > > > The following changes since commit > > > 171199f56f5f9bdf1e5d67

Re: [PULL 00/12] Block patches

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 14:01, Stefan Hajnoczi wrote: > > On Fri, Jun 26, 2020 at 11:49 AM Peter Maydell > wrote: > > > > On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > > > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: >

Re: [PULL v2 0/2] Block patches

2020-07-03 Thread Peter Maydell
On Fri, 3 Jul 2020 at 10:52, Max Reitz wrote: > > On 24.06.20 10:13, Max Reitz wrote: > > The following changes since commit d88d5a3806d78dcfca648c62dae9d88d3e803bd2: > > > > Merge remote-tracking branch > > 'remotes/philmd-gitlab/tags/renesas-hw-20200622' into staging (2020-06-23 > > 13:55:52

Re: [PATCH v7 03/17] hw/sd/sdcard: Move some definitions to use them earlier

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > Move some definitions to use them earlier. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 04/17] hw/sd/sdcard: Use the HWBLOCK_SIZE definition

2020-07-03 Thread Peter Maydell
hieu-Daudé > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-03 Thread Peter Maydell
> Fixes: CVE-2020-13253 > Cc: Prasad J Pandit > Reported-by: Alexander Bulekov > Buglink: https://bugs.launchpad.net/qemu/+bug/1880822 > Signed-off-by: Philippe Mathieu-Daudé > --- > v4: Only modify ADDRESS_ERROR, not WP_VIOLATION (pm215) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 07/17] hw/sd/sdcard: Move sd->size initialization

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > Move sd->size initialization earlier to make the following > patches easier to review. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 4 ++-- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 08/17] hw/sd/sdcard: Call sd_addr_to_wpnum where it is used, consider zero size

2020-07-03 Thread Peter Maydell
> sd->wp_switch = sd->blk ? blk_is_read_only(sd->blk) : false; > -sd->wpgrps_size = sect; > +if (sd->size) { > +sd->wpgrps_size = sd_addr_to_wpnum(sd, sd->size) + 1; > +} else { > +sd->wpgrps_size = 1; > +} Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 10/17] hw/sd/sdcard: Check address is in range

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > As a defense, assert if the requested address is out of the card area. > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > -- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > As we have no interest in the underlying block geometry, > directly call blk_getlength(). We have to care about machines > creating SD card with not drive attached (probably incorrect > API use). Simply emit a warning when such Franke

Re: [PATCH v7 13/17] hw/sd/sdcard: Constify sd_crc*()'s message argument

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > CRC functions don't modify the buffer argument, > make it const. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 14/17] hw/sd/sdcard: Make iolen unsigned

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > I/O request length can not be negative. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in trace events

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > Some ACMD were incorrectly displayed. Fix by remembering if we > are processing a ACMD (with current_cmd_is_acmd) and add the > sd_current_cmd_name() helper, which display to correct name > regardless it is a CMD or ACMD. > > Signed-o

Re: [PATCH v7 01/17] MAINTAINERS: Cc qemu-block mailing list

2020-07-03 Thread Peter Maydell
: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL v2 0/2] Block patches

2020-07-03 Thread Peter Maydell
On Fri, 3 Jul 2020 at 12:14, Max Reitz wrote: > > On 03.07.20 12:47, Peter Maydell wrote: > > On Fri, 3 Jul 2020 at 10:52, Max Reitz wrote: > >> > >> On 24.06.20 10:13, Max Reitz wrote: > >>> The following changes since commit > >>> d88d5a3

Re: [PULL 0/7] Block layer patches

2020-07-04 Thread Peter Maydell
On Fri, 3 Jul 2020 at 10:21, Kevin Wolf wrote: > > The following changes since commit 64f0ad8ad8e13257e7c912df470d46784b55c3fd: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-02' > into staging (2020-07-02 15:54:09 +0100) > > are available in the Git repository at: > >

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-06 Thread Peter Maydell
On Mon, 6 Jul 2020 at 06:52, Markus Armbruster wrote: > This is TYPE_SD_CARD's ("sd-card"). What exactly does that device > model? It is I think supposed to be an SD card. The modelling may well be odd -- it's a qomification of a pre-existing abstraction layer that predates QOM and qbus. > If i

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-07 Thread Peter Maydell
On Tue, 7 Jul 2020 at 17:04, Alistair Francis wrote: > > On Tue, Jul 7, 2020 at 6:22 AM Philippe Mathieu-Daudé wrote: > > > > QEMU allows to create SD card with unrealistic sizes. This could work, > > but some guests (at least Linux) consider sizes that are not a power > > of 2 as a firmware bug

Re: [PULL 00/31] Block patches

2020-07-07 Thread Peter Maydell
On Mon, 6 Jul 2020 at 11:04, Max Reitz wrote: > > The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200703' into staging (2020-07-04 > 16:08:41 +0100) > > are available in the Git repository

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 14:56, Philippe Mathieu-Daudé wrote: > > On 7/7/20 10:29 PM, Niek Linnenbank wrote: > > So I manually copy & pasted the change into hw/sd/sd.c to test it. > > It looks like the check works, but my concern is that with this change, > > we will be getting this error on 'off-the

Re: [PULL 18/31] block/core: add generic infrastructure for x-blockdev-amend qmp command

2020-07-09 Thread Peter Maydell
On Mon, 6 Jul 2020 at 11:05, Max Reitz wrote: > > From: Maxim Levitsky > > blockdev-amend will be used similiar to blockdev-create > to allow on the fly changes of the structure of the format based block > devices. > > Current plan is to first support encryption keyslot management for luks > bas

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Peter Maydell
On Thu, 9 Jul 2020 at 17:27, Alistair Francis wrote: > > On Thu, Jul 9, 2020 at 7:35 AM Philippe Mathieu-Daudé wrote: > > > > On 7/9/20 4:15 PM, Peter Maydell wrote: > > > The only chance you have of something that's actually > > > generic would probably

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 10:58, Kevin Wolf wrote: > > Am 09.07.2020 um 16:15 hat Peter Maydell geschrieben: > > dd/truncate etc won't work if the image file is not raw (eg if > > it's qcow2). The only chance you have of something that's actually > > generic

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 13:07, Kevin Wolf wrote: > > Am 10.07.2020 um 11:59 hat Peter Maydell geschrieben: > > On Fri, 10 Jul 2020 at 10:58, Kevin Wolf wrote: > > > > > > Am 09.07.2020 um 16:15 hat Peter Maydell geschrieben: > > > > dd/truncate etc won&

Re: [PATCH for-5.1] qemu-img resize: Require --shrink for shrinking all image formats

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 13:17, Kevin Wolf wrote: > > QEMU 2.11 introduced the --shrink option for qemu-img resize to avoid > accidentally shrinking images (commit 4ffca8904a3). However, for > compatibility reasons, it was not enforced for raw images yet, but only > a deprecation warning was printed

Re: [PULL v2] Block layer patches

2020-07-10 Thread Peter Maydell
On Thu, 9 Jul 2020 at 13:17, Kevin Wolf wrote: > > The following changes since commit 8796c64ecdfd34be394ea277a53df0c76996: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20200706-pull-request' into staging (2020-07-08 > 16:33:59 +0100) > > are available in the Git repositor

Re: [PATCH v2 7/9] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-13 Thread Peter Maydell
ght be accumulating an array of strings, or requiring multiline strings to be multiple calls so we could have the argument not need to be \n-terminated, to match error_setg(), but both those assumptions are obviously wrong.) Anyway, I guess this multiline-message usage is something we do already and it will DTRT, so Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL v3] Block layer patches

2020-07-14 Thread Peter Maydell
On Mon, 13 Jul 2020 at 15:33, Kevin Wolf wrote: > > The following changes since commit 6c87d9f311dba0641bdc2df556056938a8bf2a12: > > Merge remote-tracking branch 'remotes/elmarco/tags/chardev-pull-request' > into staging (2020-07-13 09:34:24 +0100) > > are available in the Git repository at: >

Re: [PULL v3] Block layer patches

2020-07-14 Thread Peter Maydell
On Mon, 13 Jul 2020 at 15:33, Kevin Wolf wrote: > > The following changes since commit 6c87d9f311dba0641bdc2df556056938a8bf2a12: > > Merge remote-tracking branch 'remotes/elmarco/tags/chardev-pull-request' > into staging (2020-07-13 09:34:24 +0100) > > are available in the Git repository at: >

Re: [PULL 0/9] sdcard: Fix CVE-2020-13253

2020-07-15 Thread Peter Maydell
On Tue, 14 Jul 2020 at 15:00, Philippe Mathieu-Daudé wrote: > > The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: > > Merge remote-tracking branch 'remotes/kraxel/tags/fixes-20200713-pull-reque= > st' into staging (2020-07-13 16:58:44 +0100) > > are available in the Gi

Re: [PULL 00/12] Block patches

2020-07-16 Thread Peter Maydell
On Thu, 9 Jul 2020 at 16:02, Kevin Wolf wrote: > > We can "fix" it for probably all realistic cases by lowering the speed > of the block job significantly. It's still not fully fixed for all > theoretical cases, but the pattern of starting a block job that is > throttled to a low speed so it will

Re: [PULL 00/12] Block layer patches for 5.1.0-rc1

2020-07-18 Thread Peter Maydell
On Fri, 17 Jul 2020 at 13:55, Kevin Wolf wrote: > > The following changes since commit 151f76c689b1ff4c2c59e6d8469a0d4fe5346f55: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2020-07-16 21:46:18 +0100) > > are available in the Git repository at:

various iotests failures apparently due to overly optimistic timeout settings

2020-07-19 Thread Peter Maydell
I just had a bunch of iotests fail on a freebsd VM test run. I think the machine the VM runs on is sometimes a bit heavily loaded for I/O, which means the VM can run slowly. This causes various over-optimistic timeouts in the iotest testsuite to spuriously fail. I also saw the 030 failure on the ne

Re: various iotests failures apparently due to overly optimistic timeout settings

2020-07-20 Thread Peter Maydell
On Mon, 20 Jul 2020 at 15:12, John Snow wrote: > > On 7/20/20 6:46 AM, Kevin Wolf wrote: > > John, I think this is a result of your recent python/qemu/ changes that > > make failure of graceful shutdown an error rather than just silently > > falling back to SIGKILL. > > > > Should the default time

Re: various iotests failures apparently due to overly optimistic timeout settings

2020-07-20 Thread Peter Maydell
On Mon, 20 Jul 2020 at 15:18, John Snow wrote: > > On 7/20/20 10:15 AM, Peter Maydell wrote: > > On Mon, 20 Jul 2020 at 15:12, John Snow wrote: > >> > >> On 7/20/20 6:46 AM, Kevin Wolf wrote: > >>> John, I think this is a result of your recent pytho

Re: [PULL 0/3] Block patches for 5.1

2020-07-21 Thread Peter Maydell
On Tue, 21 Jul 2020 at 12:49, Max Reitz wrote: > > The following changes since commit af3d69058e09bede9900f266a618ed11f76f49f3: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200720' into staging (2020-07-20 > 15:58:07 +0100) > > are available in the Git repository

Re: [PULL 0/3] Block layer patches for 5.1.0-rc1

2020-07-21 Thread Peter Maydell
On Tue, 21 Jul 2020 at 16:46, Kevin Wolf wrote: > > The following changes since commit 90218a9a393c7925f330e7dcc08658e2a01d3bd4: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2020-07-21' into staging (2020-07-21 > 10:24:38 +0100) > > are available in the Git reposit

Re: [PATCH] block/amend: Check whether the node exists

2020-07-23 Thread Peter Maydell
On Fri, 10 Jul 2020 at 10:51, Max Reitz wrote: > > We should check whether the user-specified node-name actually refers to > a node. The simplest way to do that is to use bdrv_lookup_bs() instead > of bdrv_find_node() (the former wraps the latter, and produces an error > message if necessary). >

Re: [PULL 0/3] Block patches for 5.1

2020-07-28 Thread Peter Maydell
On Mon, 27 Jul 2020 at 15:38, Max Reitz wrote: > > The following changes since commit 4215d3413272ad6d1c6c9d0234450b602e46a74c: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.1-20200727' > into staging (2020-07-27 09:33:04 +0100) > > are available in the Git repository at: > >

Re: [PULL 0/3] Block patches for 5.1

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 11:19, Peter Maydell wrote: > > On Mon, 27 Jul 2020 at 15:38, Max Reitz wrote: > > > > Block patches for 5.1: > > - Coverity fix > > - iotests fix for rx and avr > > -

Re: [PULL 0/3] Block patches for 5.1.0-rc2?

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 14:48, Max Reitz wrote: > > Hi, > > Sorry for the very late pull request. The iotest issue only appeared > today, and the I/O path issue was only tracked down today. We need the > fixes for the latter in 5.1, so if they do not make it into rc2, we will > need them in rc3.

Re: [PULL 05/12] iotests/030: Reduce job speed to make race less likely

2020-08-03 Thread Peter Maydell
ain. > > Reported-by: Peter Maydell > Signed-off-by: Kevin Wolf > Message-Id: <20200716132829.20127-1-kw...@redhat.com> > Reviewed-by: Max Reitz > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/030 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] qcow2-cluster: Fix integer left shift error in qcow2_alloc_cluster_link_l2()

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 10:24, Tuguoyi wrote: > > When calculating the offset, the result of left shift operation will be > promoted > to type int64 automatically because the left operand of + operator is > uint64_t. > but the result after integer promotion may be produce an error value for us >

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > > The struct had a single field (IDEDevice dev), and is only used > in the QOM type declarations and property lists. We can simply > use the IDEDevice struct directly instead. > > Signed-off-by: Eduardo Habkost > @@ -327,7 +323,6 @@ static vo

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-06 Thread Peter Maydell
On Wed, 5 Aug 2020 at 23:14, Eduardo Habkost wrote: > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > > This is one of those areas where this change works and reduces > > amount of code, but on the other hand it means the QOM type > > doesn't follow the

Re: [PULL 0/2] Block patches for 5.1.0-rc4

2020-08-11 Thread Peter Maydell
On Tue, 11 Aug 2020 at 10:35, Max Reitz wrote: > > Hi, > > There is a bug in the backup job that breaks backups from images whose > size is not aligned to the job's cluster size (i.e., qemu crashes > because of a failed assertion). If this bug makes it into the release, > it would be a regression

Re: [PULL 0/2] Block patches for 5.1.0-rc4

2020-08-20 Thread Peter Maydell
On Tue, 11 Aug 2020 at 10:35, Max Reitz wrote: > > Hi, > > There is a bug in the backup job that breaks backups from images whose > size is not aligned to the job's cluster size (i.e., qemu crashes > because of a failed assertion). If this bug makes it into the release, > it would be a regression

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Peter Maydell
On Thu, 20 Aug 2020 at 22:55, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. > > The

Re: [PULL 0/9] Tracing patches

2020-08-21 Thread Peter Maydell
On Thu, 13 Aug 2020 at 08:44, Stefan Hajnoczi wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/trac

Re: [PULL 0/3] Block patches

2020-08-21 Thread Peter Maydell
On Mon, 17 Aug 2020 at 16:16, Stefan Hajnoczi wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/bloc

<    5   6   7   8   9   10   11   12   13   14   >