Re: [Qemu-block] [PATCH v3 28/33] qdev: Remove unused deprecated reset functions

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > Remove the functions now they are unused: > + device_legacy_reset > + qdev_reset_all[_fn] > + qbus_reset_all[_fn] > > Signed-off-by: Damien Hedde > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-block] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-07 Thread Peter Maydell
On Wed, 7 Aug 2019 at 16:23, Damien Hedde wrote: > On 8/7/19 4:41 PM, Peter Maydell wrote: > > On Mon, 29 Jul 2019 at 15:58, Damien Hedde > > wrote: > >> legacy resets are called in the "post" order (ie: children then parent) > >> in hierarchi

Re: [Qemu-block] [PATCH v3 09/33] add doc about Resettable interface

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > Signed-off-by: Damien Hedde > --- > docs/devel/reset.txt | 165 +++ > 1 file changed, 165 insertions(+) > create mode 100644 docs/devel/reset.txt > > diff --git a/docs/devel/reset.txt

Re: [Qemu-block] [PATCH v3 29/33] hw/misc/zynq_slcr: use standard register definition

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > Replace the zynq_slcr registers enum and macros using the > hw/registerfields.h macros. > > Signed-off-by: Damien Hedde > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis > --- > hw/misc/zynq_slcr.c | 472

Re: [Qemu-block] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: > > Deprecate old reset apis and make them use the new one while they > are still used somewhere. > > Signed-off-by: Damien Hedde > --- > hw/core/qdev.c | 22 +++--- > include/hw/qdev-core.h | 28

Re: [Qemu-block] [PATCH v3 10/33] vl.c: remove qbus_reset_all registration

2019-08-07 Thread Peter Maydell
if (rom_check_and_register_reset() != 0) { > -- > 2.22.0 Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-block] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: > > This add Resettable interface implementation for both Bus and Device. > > *resetting* counter and *reset_is_cold* flag are added in DeviceState > and BusState. > > Compatibility with existing code base is ensured. > The legacy bus or device

Re: [Qemu-block] [PATCH v3 09/33] add doc about Resettable interface

2019-08-07 Thread Peter Maydell
On Wed, 31 Jul 2019 at 07:33, David Gibson wrote: > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > Signed-off-by: Damien Hedde > > +For Devices and Buses there is also the corresponding helpers: > > +void device_reset(Device *dev, bool cold) > > +void bus_reset(Device *dev,

Re: [Qemu-block] [PATCH v3 06/33] add the vmstate description for device reset state

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: > > It contains the resetting counter and cold flag status. > > At this point, migration of bus reset related state (counter and cold/warm > flag) is handled by parent device. This done using the post_load > function in the vmsd subsection. > >

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > This add the reset related sections for every QOM > device. A bit more detail in the commit message would help, I think -- this is adding extra machinery which has to copy and modify the VMStateDescription passed in by the device in order to

Re: [Qemu-block] [PATCH v3 11/33] hw/s390x/ipl.c: remove qbus_reset_all registration

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > Replace deprecated qbus_reset_all by resettable_reset_cold_fn for > the ipl registration in the main reset handlers. > > This does not impact the behavior. > > Signed-off-by: Damien Hedde > --- > hw/s390x/ipl.c | 6 +- > 1 file changed,

Re: [Qemu-block] [PULL 2/5] block/nvme: support larger that 512 bytes sector devices

2019-07-29 Thread Peter Maydell
On Mon, 22 Jul 2019 at 18:26, Max Reitz wrote: > > From: Maxim Levitsky > > Currently the driver hardcodes the sector size to 512, > and doesn't check the underlying device. Fix that. > > Also fail if underlying nvme device is formatted with metadata > as this needs special support. > >

Re: [Qemu-block] [PULL v2 0/7] Block patches for 4.1.0-rc4

2019-08-06 Thread Peter Maydell
On Tue, 6 Aug 2019 at 12:59, Max Reitz wrote: > > The following changes since commit 9bb68d34dda9be60335e73e65c8fb61bca035362: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/edk2-next-20190803' into staging (2019-08-05 > 11:05:36 +0100) > > are available in the Git repository

Re: [Qemu-block] [PULL 0/7] Block patches for 4.1.0-rc4

2019-08-05 Thread Peter Maydell
On Mon, 5 Aug 2019 at 19:05, Peter Maydell wrote: > This is quite a lot of changes for rc4 -- how confident are > you about them ? I suppose 3 out of 4 commits are updating > the test suite... 3 out of 7, I meant :-) thanks -- PMM

Re: [Qemu-block] [PULL 0/7] Block patches for 4.1.0-rc4

2019-08-05 Thread Peter Maydell
On Mon, 5 Aug 2019 at 19:21, Max Reitz wrote: > Would dropping the test patches make it better? :-) > > I am reasonably (i.e., rc4-levels of) confident that the patches don’t > break anything that wasn’t broken before. > > (I’m least confident about the test patches working for everyone and >

Re: [Qemu-block] [PULL 0/7] Block patches for 4.1.0-rc4

2019-08-05 Thread Peter Maydell
On Mon, 5 Aug 2019 at 17:37, Max Reitz wrote: > > The following changes since commit 9bb68d34dda9be60335e73e65c8fb61bca035362: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/edk2-next-20190803' into staging (2019-08-05 > 11:05:36 +0100) > > are available in the Git repository

Re: [Qemu-block] [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-09 Thread Peter Maydell
On Fri, 9 Aug 2019 at 01:10, David Gibson wrote: > > On Wed, Jul 31, 2019 at 01:31:28PM +0200, Philippe Mathieu-Daudé wrote: > > On 7/31/19 11:29 AM, Damien Hedde wrote: > > > On 7/31/19 8:05 AM, David Gibson wrote: > > >> On Mon, Jul 29, 2019 at 04:56:26PM +0200, Damien Hedde wrote: > > >>> @@

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Peter Maydell
On Thu, 8 Aug 2019 at 16:42, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Mon, 29 Jul 2019 at 15:59, Damien Hedde > > wrote: > > > > > > This add the reset related sections for every QOM > > > device. &g

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Peter Maydell
On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: > > One way to keep the feature without copy-pasting vmsd would be to add > a new vmstate_register with an additional argument to pass the base > class vmsd section and handle the whole thing there. If we have a vmstate section which contains no

Re: [Qemu-block] [Qemu-devel] [PATCH v7 7/9] qemu/units: add SI decimal units

2019-08-09 Thread Peter Maydell
On Fri, 9 Aug 2019 at 16:39, Eric Blake wrote: > Also, would it be worth swapping out existing constants in the code base > that should instead be using these macros, so that they actually have a > use and so that we can see whether using them adds legibility? > > For example, block/nvme.c,

Re: [Qemu-block] [Qemu-devel] [PULL 0/7] Block patches for 4.1.0-rc4

2019-08-06 Thread Peter Maydell
On Tue, 6 Aug 2019 at 12:12, Max Reitz wrote: > > On 06.08.19 12:12, Peter Maydell wrote: > > On Mon, 5 Aug 2019 at 18:01, Max Reitz wrote: > >> > >> On 05.08.19 18:59, Vladimir Sementsov-Ogievskiy wrote: > >>> 05.08.2019 19:37, Max Reitz wrote:

Re: [Qemu-block] [Qemu-devel] [PULL 0/7] Block patches for 4.1.0-rc4

2019-08-06 Thread Peter Maydell
On Mon, 5 Aug 2019 at 18:01, Max Reitz wrote: > > On 05.08.19 18:59, Vladimir Sementsov-Ogievskiy wrote: > > 05.08.2019 19:37, Max Reitz wrote: > >> The following changes since commit > >> 9bb68d34dda9be60335e73e65c8fb61bca035362: > >> > >>Merge remote-tracking branch > >>

Re: [Qemu-block] [PULL 0/5] Block patches for 4.1.0-rc2

2019-07-23 Thread Peter Maydell
On Mon, 22 Jul 2019 at 18:26, Max Reitz wrote: > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 > 15:16:48 +0100) > > are available in the Git

Re: [Qemu-block] [Qemu-devel] [PULL v2 0/2] pflash-next patches for v4.1.0-rc2

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 10:36, Philippe Mathieu-Daudé wrote: > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 > 15:16:48 +0100) > > are available in the

Re: [Qemu-block] [PATCH-for-4.1? 2/7] hw/dma/omap_dma: Move switch 'fall through' comment to correct place

2019-07-19 Thread Peter Maydell
ugh */ > case 0x400: > -/* Fall through. */ > if (omap_dma_sys_write(s, addr, value)) > break; > return; > - Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-block] [PATCH-for-4.1 3/7] hw/block/pflash_cfi02: Rewrite a fall through comment

2019-07-19 Thread Peter Maydell
pfl->cmd = 0x98; > return; > } > -/* No break here */ > +/* fall through */ > default: > DPRINTF("%s: invalid write for command %02x\n", > __func__, pfl->cmd); > -- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-block] [PULL 00/11] Block patches for rc1

2019-07-15 Thread Peter Maydell
On Mon, 15 Jul 2019 at 15:29, Max Reitz wrote: > > The following changes since commit b9404bf592e7ba74180e1a54ed7a266ec6ee67f2: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20190715' into > staging (2019-07-15 12:22:07 +0100) > > are available in the Git repository at: > >

Re: [Qemu-block] [PULL 00/13] Block layer patches

2019-07-22 Thread Peter Maydell
On Fri, 19 Jul 2019 at 14:43, Kevin Wolf wrote: > > The following changes since commit 0274f45bdef73283f2c213610f11d4e5dcba43b6: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging > (2019-07-19 09:44:43 +0100) > > are available in the Git

Re: [Qemu-block] [PATCH-for-4.1 v7 1/1] hw/block/pflash_cfi01: Add missing DeviceReset() handler

2019-07-22 Thread Peter Maydell
On Mon, 22 Jul 2019 at 17:51, Laszlo Ersek wrote: > > On 07/19/19 18:19, Philippe Mathieu-Daudé wrote: > > Hi Laszlo, > > > > On 7/18/19 9:35 PM, Philippe Mathieu-Daudé wrote: > >> On 7/18/19 8:38 PM, Laszlo Ersek wrote: > >>> Regression-tested-by: Laszlo Ersek > > > > Patchwork doesn't

Re: [Qemu-block] [PULL 0/3] Tracing patches

2019-09-19 Thread Peter Maydell
On Wed, 18 Sep 2019 at 14:21, Stefan Hajnoczi wrote: > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are available in the Git repository at: > >

Re: [PULL 0/2] Block patches

2019-09-26 Thread Peter Maydell
On Wed, 25 Sep 2019 at 18:44, Stefan Hajnoczi wrote: > > The following changes since commit 240ab11fb72049d6373cbbec8d788f8e411a00bc: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190924' into > staging (2019-09-24 15:36:31 +0100) > > are available in the Git repository at:

iotest failure -- test possibly not using sufficiently unique temp filename?

2019-09-27 Thread Peter Maydell
Hi; I just saw this iotest failure (on an s390x box, as it happens): TESTiotest-qcow2: 130 [fail] QEMU -- "/home/linux1/qemu/build/all/tests/qemu-iotests/../../s390x-softmmu/qemu-system-s390x" -nodefaults -display none -machine accel=qtest QEMU_IMG --

Re: [PULL 0/4] Block layer patches

2019-09-23 Thread Peter Maydell
On Fri, 20 Sep 2019 at 17:21, Kevin Wolf wrote: > > The following changes since commit 521db80318d6c749a6f6c5a65a68397af9e3ef16: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-09-16' > into staging (2019-09-16 15:25:55 +0100) > > are available in the Git repository at:

Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] configure: Try to fix --static linking

2019-06-14 Thread Peter Maydell
On Fri, 14 Jun 2019 at 08:27, Philippe Mathieu-Daudé wrote: > Apparently QEMU static linking is slowly bitroting. Obviously it > depends the libraries an user has installed, anyway it seems there > are not much testing done. The main reason for supporting static linking is so we can build the

Re: [PULL 0/5] Block patches for 4.2-rc0

2019-11-06 Thread Peter Maydell
On Mon, 4 Nov 2019 at 09:03, Max Reitz wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git repository

Re: [PULL 0/3] Block patches for 4.2.0-rc0/4.1.1

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 14:34, Max Reitz wrote: > > The following changes since commit d0f90e1423b4f412adc620eee93e8bfef8af4117: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191106-pull-request' into staging (2019-11-07 > 09:21:52 +) > > are available in the Git

Re: [PULL 00/11] Block patches

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 15:43, Stefan Hajnoczi wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL 0/9] Ide patches

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 10:59, John Snow wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 > 14:10:32 +) > > are available in the Git

Re: [PULL v2 0/9] Ide patches

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 15:57, John Snow wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 > 14:10:32 +) > > are available in the Git

Re: [PULL 0/4] Block layer patches for 4.2.0-rc2

2019-11-18 Thread Peter Maydell
On Mon, 18 Nov 2019 at 17:03, Kevin Wolf wrote: > > The following changes since commit bbe165740a96f67f48ecd3029dc26bdd7fd5192c: > > Merge remote-tracking branch > 'remotes/vivier2/tags/ppc-for-4.2-pull-request' into staging (2019-11-18 > 11:09:06 +) > > are available in the Git

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

2019-11-22 Thread Peter Maydell
On Fri, 22 Nov 2019 at 16:08, Kevin Wolf wrote: > > See patch 4 for the description of the bug fixed. I guess my questions for trying to answer the "for-4.2?" question in the subject are: 1) is this a security (leaking data into the guest) bug ? 2) is this a regression? 3) is this something a

Re: [PULL 0/2] Block patches

2019-12-13 Thread Peter Maydell
On Fri, 13 Dec 2019 at 14:33, Stefan Hajnoczi wrote: > > The following changes since commit b0ca999a43a22b38158a33d3f5881648bb4f: > > Update version for v4.2.0 release (2019-12-12 16:45:57 +) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git

Re: [PATCH] doc: Describe missing generic -blockdev options

2019-10-15 Thread Peter Maydell
On Tue, 15 Oct 2019 at 13:40, Kevin Wolf wrote: > > We added more generic options after introducing -blockdev and forgot to > update the documentation (man page and --help output) accordingly. Do > that now. > > Signed-off-by: Kevin Wolf > --- > qemu-options.hx | 19 ++- > 1

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 11:09, Max Reitz wrote: > > Hi, > > It seems to me that there is a bug in Linux’s XFS kernel driver, as > I’ve explained here: > > https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html > > In combination with our commit c8bb23cbdbe32f, this may lead to

Re: [PULL 00/19] Trivial branch patches

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 09:35, Laurent Vivier wrote: > > The following changes since commit 58560ad254fbda71d4daa6622d71683190070ee2: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20191024' > into staging (2019-10-24 16:22:58 +0100) > > are available in the Git repository

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 15:16, Max Reitz wrote: > > On 25.10.19 15:46, Peter Maydell wrote: > > On Fri, 25 Oct 2019 at 11:09, Max Reitz wrote: > >> > >> Hi, > >> > >> It seems to me that there is a bug in Linux’s XFS kernel driver, as > >>

Re: [PATCH v2] doc: Describe missing generic -blockdev options

2019-10-18 Thread Peter Maydell
" should be all-upper-case. > +instance), both instances must permit shared access for the second instance > to > +succeed at opening the file. > + > +Enabling @option{force-share=on} requires @option{read-only=on}. > @item cache.direct > The host page cache can be avoided with @option{cache.direct=on}. This will > attempt to do disk IO directly to the guest's memory. QEMU may still perform > an > -- > 2.20.1 Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL v3 00/19] Bitmaps patches

2019-10-18 Thread Peter Maydell
On Thu, 17 Oct 2019 at 22:54, John Snow wrote: > > The following changes since commit f22f553efffd083ff624be116726f843a39f1148: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20191013' into > staging (2019-10-17 16:48:56 +0100) > > are available in the Git repository at: > >

Re: [PULL 0/2] Tracing patches

2019-10-15 Thread Peter Maydell
On Tue, 15 Oct 2019 at 16:38, Philippe Mathieu-Daudé wrote: > > On 10/15/19 2:24 PM, Peter Maydell wrote: > > On Mon, 14 Oct 2019 at 09:57, Stefan Hajnoczi wrote: > >> > >> The following changes since commit > >> 98b2e3c9ab3abfe476a2b02f8f51813edb90e

Re: [PULL 00/15] Block layer patches

2019-10-15 Thread Peter Maydell
On Mon, 14 Oct 2019 at 17:03, Kevin Wolf wrote: > > The following changes since commit 22dbfdecc3c52228d3489da3fe81da92b21197bf: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20191010.0' > into staging (2019-10-14 15:09:08 +0100) > > are available in the Git repository

Re: [PULL 0/1] Block patches

2019-10-15 Thread Peter Maydell
On Mon, 14 Oct 2019 at 09:52, Stefan Hajnoczi wrote: > > The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-10-08 16:08:35 +0100) > > are available in the Git repository

Re: [PULL 00/69] Block patches for softfreeze

2019-10-28 Thread Peter Maydell
On Mon, 28 Oct 2019 at 12:15, Max Reitz wrote: > > The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 > 10:13:48 +0100) > > are available in the Git

Re: [PULL 00/11] Q800 branch patches

2019-10-29 Thread Peter Maydell
On Mon, 28 Oct 2019 at 18:48, Laurent Vivier wrote: > > The following changes since commit 7bc8f9734213b76e76631a483be13d6737c2adbc: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20191025' into staging (2019-10-25 > 13:12:16 +0100) > > are available in the Git

Re: iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 11:20, Max Reitz wrote: > > On 17.10.19 12:04, Peter Maydell wrote: > > On Thu, 17 Oct 2019 at 10:53, Max Reitz wrote: > >> > >> On 17.10.19 11:51, Peter Maydell wrote: > >>> I just got this iotest 260 failure processing an > &

Re: [PULL v2 00/19] Bitmaps patches

2019-10-17 Thread Peter Maydell
On Mon, 14 Oct 2019 at 20:29, John Snow wrote: > > The following changes since commit c760cb77e511eb05094df67c1b30029a952efa35: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20191011a' into staging (2019-10-14 > 16:09:52 +0100) > > are available in the Git

Re: [PULL 33/36] block/backup: use backup-top instead of write notifiers

2019-10-17 Thread Peter Maydell
On Thu, 10 Oct 2019 at 12:44, Max Reitz wrote: > > From: Vladimir Sementsov-Ogievskiy > > Drop write notifiers and use filter node instead. Hi; after this change Coverity complains about dead code in backup_job_create() (CID 1406402): > @@ -382,6 +353,8 @@ BlockJob *backup_job_create(const

iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Peter Maydell
I just got this iotest 260 failure processing an unrelated merge on my x86-64 Ubuntu box. I assume it's an intermittent (have just kicked off a retry) but post the backtrace in case it's of interest: TESTiotest-qcow2: 260 [fail] QEMU --

Re: iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 10:53, Max Reitz wrote: > > On 17.10.19 11:51, Peter Maydell wrote: > > I just got this iotest 260 failure processing an > > unrelated merge on my x86-64 Ubuntu box. I assume > > it's an intermittent (have just kicked off a retry) but > > p

Re: iotest failure -- test possibly not using sufficiently unique temp filename?

2019-10-17 Thread Peter Maydell
On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote: > > On 27.09.19 18:39, Peter Maydell wrote: > > Hi; I just saw this iotest failure (on an s390x box, as it happens): > > > > TESTiotest-qcow2: 130 [fail] > > QEMU -- > > "/home/linux1/qemu

Re: [PULL 0/2] Tracing patches

2019-10-15 Thread Peter Maydell
On Mon, 14 Oct 2019 at 09:57, Stefan Hajnoczi wrote: > > The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-10-08 16:08:35 +0100) > > are available in the Git repository

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 15:21, Max Reitz wrote: > > On 25.10.19 16:17, Peter Maydell wrote: > > On Fri, 25 Oct 2019 at 15:16, Max Reitz wrote: > >> I’ve created an RH BZ here: > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=1765547 > > > &

Re: [PULL 0/7] Block layer patches

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 14:46, Kevin Wolf wrote: > > The following changes since commit 7bc8f9734213b76e76631a483be13d6737c2adbc: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20191025' into staging (2019-10-25 > 13:12:16 +0100) > > are available in the Git

Re: [PULL 0/2] Block patches

2019-10-26 Thread Peter Maydell
On Fri, 25 Oct 2019 at 20:18, Stefan Hajnoczi wrote: > > The following changes since commit 58560ad254fbda71d4daa6622d71683190070ee2: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20191024' > into staging (2019-10-24 16:22:58 +0100) > > are available in the Git repository

Re: [PULL 0/2] mips-next patches for 4.2-rc2

2019-11-19 Thread Peter Maydell
On Tue, 19 Nov 2019 at 14:02, Philippe Mathieu-Daudé wrote: > > This pull fixes a regression with the SystemTap trace backend, > see https://bugs.launchpad.net/qemu/+bug/1844817 > > The following changes since commit 385e43e6638464009e09cfaec254012e531f6342: > > Merge remote-tracking branch

Re: [PULL 0/2] Block patches for 4.2.0-rc3

2019-11-26 Thread Peter Maydell
On Tue, 26 Nov 2019 at 13:29, Max Reitz wrote: > > The following changes since commit 4ecc984210ca1bf508a96a550ec8a93a5f833f6c: > > Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.2-rc3' > into staging (2019-11-26 12:36:40 +) > > are available in the Git repository at:

Re: [PATCH] iotests: Remove 130 from the "auto" group

2019-10-31 Thread Peter Maydell
On Tue, 29 Oct 2019 at 14:05, Max Reitz wrote: > > On 18.10.19 18:10, Thomas Huth wrote: > > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > > 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" > > error with 130 already twice. Looks like this test is

Re: [PULL v2 0/8] Ide patches

2019-10-07 Thread Peter Maydell
On Thu, 3 Oct 2019 at 20:33, John Snow wrote: > > The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 > 13:13:38 +0100) > > are available in the Git

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-07 Thread Peter Maydell
On Mon, 7 Oct 2019 at 13:32, Thomas Huth wrote: > On 04/10/2019 14.44, Max Reitz wrote: > > Whenever make check fails, it’s urgent. Without iotests running in make > > check, we had some time to sort the situation out. That’s no longer the > > case. > > > > That means we need to take care of

Re: [PULL v3 0/4] Block layer patches

2019-10-07 Thread Peter Maydell
On Fri, 4 Oct 2019 at 11:00, Kevin Wolf wrote: > > The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01 > 16:21:42 +0100) > > are available in the Git repository

Re: [PATCH 00/11] hw: Convert various reset() handler to DeviceReset

2019-10-08 Thread Peter Maydell
On Mon, 7 Oct 2019 at 22:24, Eduardo Habkost wrote: > > On Mon, Oct 07, 2019 at 12:01:54PM +0200, Philippe Mathieu-Daudé wrote: > > Hi Michael, > > > > On 10/5/19 11:46 PM, Michael S. Tsirkin wrote: > > > On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote: > > > > Hi. > > > >

Re: [PULL 0/4] Block patches

2019-10-08 Thread Peter Maydell
On Tue, 8 Oct 2019 at 15:55, Stefan Hajnoczi wrote: > > The following changes since commit 560009f2c8b57b7cdd31a5693ea86ab369382f49: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-10-07 15:40:53 +0100) > > are available in the Git repository at: > >

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-04 Thread Peter Maydell
On Fri, 4 Oct 2019 at 14:50, Max Reitz wrote: > On 04.10.19 15:16, Peter Maydell wrote: > > 'make check' does have the restriction > > that we don't want the tests to take too long to run, but in > > general the block layer should be running some reasonable subset > >

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-04 Thread Peter Maydell
On Fri, 4 Oct 2019 at 13:45, Max Reitz wrote: > > In the end, I don't care what code these patches touched. I do an > > innocent git pull, and when I finally see that it's master that breaks > > iotests and not my patches on top of it, I'm annoyed. > > Hm. Part of my point was that this still

Re: [PULL 0/8] Ide patches

2019-10-03 Thread Peter Maydell
On Wed, 2 Oct 2019 at 00:56, John Snow wrote: > > The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 > 13:13:38 +0100) > > are available in the Git

Re: [PULL v2 0/4] Block layer patches

2019-10-03 Thread Peter Maydell
On Wed, 2 Oct 2019 at 17:18, Kevin Wolf wrote: > > The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 > 13:13:38 +0100) > > are available in the Git

Re: [PULL 00/36] Block patches

2019-10-14 Thread Peter Maydell
On Thu, 10 Oct 2019 at 12:43, Max Reitz wrote: > > The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-10-08 16:08:35 +0100) > > are available in the Git repository at: > >

Re: [PULL 00/19] Bitmaps patches

2019-10-14 Thread Peter Maydell
On Fri, 11 Oct 2019 at 22:26, John Snow wrote: > > The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-10-08 16:08:35 +0100) > > are available in the Git repository at: > >

Re: Question about (and problem with) pflash data access

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 14:26, Guenter Roeck wrote: > What really puzzles me is that there is no trace output for > flash data accesses (trace_pflash_data_read and trace_pflash_data_write), > meaning the actual flash data access must be handled elsewhere. > Can someone give me a hint where that

Re: [PULL 00/15] Pull migration patches

2020-02-28 Thread Peter Maydell
On Fri, 28 Feb 2020 at 09:25, Juan Quintela wrote: > > The following changes since commit 8b6b68e05b43f976714ca1d2afe01a64e1d82cba: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-02-27 19:15:15 +) > > are available in the Git repository at: > >

Re: [PULL 0/3] Block patches

2020-03-06 Thread Peter Maydell
On Fri, 6 Mar 2020 at 14:23, Stefan Hajnoczi wrote: > > The following changes since commit ef9f8fcbec6276414921dcd042575129a6331a2d: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2020-03-04-2' into staging (2020-03-05 > 19:39:47 +) > > are available in the Git

Re: [PULL 11/18] block: Generic file creation fallback

2020-02-25 Thread Peter Maydell
On Thu, 20 Feb 2020 at 16:11, Max Reitz wrote: > > If a protocol driver does not support image creation, we can see whether > maybe the file exists already. If so, just truncating it will be > sufficient. > > Signed-off-by: Max Reitz > Message-Id: <20200122164532.178040-3-mre...@redhat.com> >

Re: [PULL 00/31] Block patches

2020-02-24 Thread Peter Maydell
On Sat, 22 Feb 2020 at 08:50, Stefan Hajnoczi wrote: > > The following changes since commit 9ac5df20f51fabcba0d902025df4bd7ea987c158: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200221-1' into staging (2020-02-21 > 16:18:38 +) > > are available in the Git

Re: [PATCH 2/3] docs: Create stub system manual

2020-01-23 Thread Peter Maydell
On Wed, 22 Jan 2020 at 18:58, Alex Bennée wrote: > Peter Maydell writes: > > diff --git a/docs/index.html.in b/docs/index.html.in > > index 94eb782cf7e..573c543c02b 100644 > > --- a/docs/index.html.in > > +++ b/docs/index.html.in > > @@ -11,6 +11,7 @@ >

Re: [PULL 00/13] Block layer patches

2020-01-28 Thread Peter Maydell
On Mon, 27 Jan 2020 at 17:56, Kevin Wolf wrote: > > The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into > staging (2020-01-27 13:02:36 +) > > are available in the Git repository at: > >

Re: [PATCH v2 2/2] doc: Use @code rather than @var for options

2020-01-28 Thread Peter Maydell
On Tue, 28 Jan 2020 at 07:39, David Edmondson wrote: > > Eric Blake writes: > > > On 1/24/20 4:34 AM, David Edmondson wrote: > >> Texinfo defines @var for metasyntactic variables and such terms are > >> shown in upper-case or italics in the output of makeinfo. When > >> considering an option to

Re: [PULL 0/2] Ide patches

2020-01-30 Thread Peter Maydell
On Tue, 28 Jan 2020 at 01:07, John Snow wrote: > > The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into > staging (2020-01-27 13:02:36 +) > > are available in the Git repository at: > >

Re: [PULL 00/12] Trivial branch patches

2020-02-06 Thread Peter Maydell
On Thu, 6 Feb 2020 at 12:50, Laurent Vivier wrote: > > The following changes since commit 7bd9d0a9e26c7a3c67c0f174f0009ba19969b158: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2020-02-04' into staging (2020-02-04 > 16:12:31 +) > > are available in the Git

Re: [PULL 00/17] Block patches

2020-02-06 Thread Peter Maydell
On Thu, 6 Feb 2020 at 12:51, Max Reitz wrote: > > The following changes since commit 418fa86dd465b4fd8394373cf83db8fa65d7611c: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-040220-1' > into staging (2020-02-04 18:55:06 +) > > are available in the Git repository at: >

Re: [PATCH v2 0/8] qemu-img, qemu-trace-stap, virtfs-proxy-helper: convert to rST

2020-01-31 Thread Peter Maydell
ld be nice to put it into the tree sooner rather than later. Still in need of review: patches 1 (makefile magic), 5 (the qemu-img conversion itself), 7 (qemu-trace-stap). thanks -- PMM On Fri, 24 Jan 2020 at 16:26, Peter Maydell wrote: > > This patchset converts the following documentati

Re: [PULL 00/18] Block patches

2020-01-31 Thread Peter Maydell
On Thu, 30 Jan 2020 at 21:31, Stefan Hajnoczi wrote: > > The following changes since commit 928173659d6e5dc368284f73f90ea1d129e1f57d: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200130' into staging (2020-01-30 > 16:19:04 +) > > are available in the Git

Re: [PULL 15/18] qemu-img: adds option to use aio engine for benchmarking

2020-02-03 Thread Peter Maydell
On Thu, 30 Jan 2020 at 21:32, Stefan Hajnoczi wrote: > > From: Aarushi Mehta > > Signed-off-by: Aarushi Mehta > Acked-by: Stefano Garzarella > Signed-off-by: Stefan Hajnoczi > Message-id: 20200120141858.587874-13-stefa...@redhat.com > Message-Id: <20200120141858.587874-13-stefa...@redhat.com>

Re: [PATCH v2 0/8] qemu-img, qemu-trace-stap, virtfs-proxy-helper: convert to rST

2020-02-03 Thread Peter Maydell
On Fri, 24 Jan 2020 at 16:26, Peter Maydell wrote: > > This patchset converts the following documentation to rST format: > * qemu-img > * qemu-trace-stap > * virtfs-proxy-helper > > (That means everything in step 3 in the plan: > https://wiki.qemu.org/

Re: [PATCH 1/3] qemu-nbd: Convert invocation documentation to rST

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 12:43, Eric Blake wrote: > > On 1/16/20 8:15 AM, Peter Maydell wrote: > > The qemu-nbd documentation is currently in qemu-nbd.texi in Texinfo > > format, which we present to the user as: > > * a qemu-nbd manpage > > * a section of the ma

[PATCH v2 6/8] qemu-img-cmds.hx: Remove texinfo document fragments

2020-01-24 Thread Peter Maydell
Now the qemu-img documentation has been converted to rST, we can remove the texinfo document fragments from qemu-img-cmds.hx, as they are no longer used. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- qemu-img-cmds.hx | 56 +++- 1

[PATCH v2 8/8] virtfs-proxy-helper: Convert documentation to rST

2020-01-24 Thread Peter Maydell
, and present it to the user as: * a virtfs-proxy-helper manpage * part of the interop/ Sphinx manual There are minor formatting changes to suit Sphinx, but no content changes. In particular I've split the -u and -g options into each having their own description text. Signed-off-by: Peter Maydell

[PATCH v2 4/8] qemu-img-cmds.hx: Add rST documentation fragments

2020-01-24 Thread Peter Maydell
Add the rST versions of the documentation fragments. Once we've converted qemu-img.texi to rST we can delete the texi fragments; for the moment we leave them in place. (Commit created with the aid of emacs query-replace-regexp from "@var{\([^}]*\)}" to "\,(upcase \1))".)

[PATCH v2 7/8] scripts/qemu-trace-stap: Convert documentation to rST

2020-01-24 Thread Peter Maydell
, and present it to the user as: * a qemu-trace-stap manpage * part of the interop/ Sphinx manual There are minor formatting changes to suit Sphinx, but no content changes. Signed-off-by: Peter Maydell --- Makefile | 9 +- MAINTAINERS | 1 + docs

[PATCH v2 5/8] qemu-img: Convert invocation documentation to rST

2020-01-24 Thread Peter Maydell
structure into rST. As usual, there are some minor formatting changes but no textual changes, except that as with one or two other conversions I have dropped the 'see also' section since it's not very informative and looks odd in the HTML. Signed-off-by: Peter Maydell --- The eagle-eyed will notice

[PATCH v2 0/8] qemu-img, qemu-trace-stap, virtfs-proxy-helper: convert to rST

2020-01-24 Thread Peter Maydell
ot totally trivial and the odd minor missed hyperlink doesn't seem to me to be a deal-breaker. Sorry about the size of the main 'convert qemu-img' patch, but it's unavoidable when converting a big document between formats. thanks -- PMM Peter Maydell (8): Makefile: Ensure we don't run Sphinx i

[PATCH v2 1/8] Makefile: Ensure we don't run Sphinx in parallel for manpages

2020-01-24 Thread Peter Maydell
ltiple output files" machinery is provided as a macro named 'atomic' in rules.mak; we then wrap this in a more specific macro for defining the rule and dependencies for the manpages in a Sphinx manual, to avoid excessive repetition. Signed-off-by: Peter Maydell --- Makefile | 17 +

<    2   3   4   5   6   7   8   9   10   11   >