Re: [PATCH 2/2] tests/qtest/ide-test: Verify READ NATIVE MAX ADDRESS is not limited

2022-10-12 Thread Thomas Huth
qtest_add_func("/ide/diagnostic", test_diagnostic); Acked-by: Thomas Huth

[PATCH] tests/unit/test-image-locking: Fix handling of temporary files

2022-10-12 Thread Thomas Huth
test-image-locking leaves some temporary files around - clean them up. While we're at it, test-image-locking is a unit test, so it should not use "qtest.*" for temporary file names. Give them better names instead, so that it clear where the temporary files come from. Signed-off-by: T

[PATCH] tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

2022-08-02 Thread Thomas Huth
It is possible to hit the assertTrue(delta_t < 2.0) on very loaded systems. Increase the value to 5.0 to ease the situation a little bit. Signed-off-by: Thomas Huth --- See also https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg03936.html tests/qemu-iotests/264 | 2 +- 1 file chan

Re: [PATCH 4/6] util/error: add G_GNUC_PRINTF for various functions

2022-12-29 Thread Thomas Huth
, const char *src, int line, const char *func, ErrorClass err_class, const char *fmt, va_list ap, Reviewed-by: Thomas Huth

Re: [PATCH 5/6] tests: add G_GNUC_PRINTF for various functions

2022-12-29 Thread Thomas Huth
On 19/12/2022 14.02, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- tests/qtest/ahci-test.c | 3 +++ tests/qtest/arm-cpu-features.c| 1 + tests/qtest/erst-test.c | 2 +- tests/qtest/ide-test.c| 3 ++- tests/qtest/ivshmem-test.c

Re: [PATCH v4 08/30] hw/i386/pc: Create RTC controllers in south bridges

2023-01-02 Thread Thomas Huth
On 21/12/2022 17.59, Bernhard Beschow wrote: Just like in the real hardware (and in PIIX4), create the RTC controllers in the south bridges. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Message-Id: <20221022150508.26830-11-shen...@gmail.com> --- hw/i386/pc.c

Re: [PATCH v4 09/30] hw/i386/pc: No need for rtc_state to be an out-parameter

2023-01-03 Thread Thomas Huth
hen...@gmail.com> --- hw/i386/pc.c | 12 ++-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v4 08/30] hw/i386/pc: Create RTC controllers in south bridges

2023-01-03 Thread Thomas Huth
On 02/01/2023 19.25, Bernhard Beschow wrote: Am 2. Januar 2023 17:03:29 UTC schrieb Thomas Huth : On 21/12/2022 17.59, Bernhard Beschow wrote: Just like in the real hardware (and in PIIX4), create the RTC controllers in the south bridges. Signed-off-by: Bernhard Beschow Reviewed

[PATCH v2] hw/misc/sifive_u_otp: Remove the deprecated OTP config with '-drive if=none'

2023-01-12 Thread Thomas Huth
'-drive if=none' is meant for configuring back-end devices only, so this got marked as deprecated in QEMU 6.2. Users should now only use the new way with '-drive if=pflash' instead. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 7

Re: [PATCH] hw/misc/sifive_u_otp: Remove the deprecated OTP config with '-drive if=none'

2023-01-12 Thread Thomas Huth
On 12/01/2023 09.29, Thomas Huth wrote: '-drive if=none' is meant for configuring back-end devices only, so this got marked as deprecated in QEMU 6.2. Users should now only use the new way with '-drive if=pflash' instead. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6

[PATCH] hw/misc/sifive_u_otp: Remove the deprecated OTP config with '-drive if=none'

2023-01-12 Thread Thomas Huth
'-drive if=none' is meant for configuring back-end devices only, so this got marked as deprecated in QEMU 6.2. Users should now only use the new way with '-drive if=pflash' instead. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 7

Re: [PATCH 1/1] qemu-iotests/stream-under-throttle: do not shutdown QEMU

2023-01-04 Thread Thomas Huth
On 12/12/2022 11.13, Christian Borntraeger wrote: Am 07.12.22 um 14:14 schrieb Christian Borntraeger: Without a kernel or boot disk a QEMU on s390 will exit (usually with a disabled wait state). This breaks the stream-under-throttle test case. Do not exit qemu if on s390. Signed-off-by:

Re: [PATCH 1/1] qemu-iotests/stream-under-throttle: do not shutdown QEMU

2022-12-07 Thread Thomas Huth
') +if iotests.qemu_default_machine == 's390-ccw-virtio': +self.vm.add_args('-no-shutdown') self.vm.launch() I guess you could even add that unconditionally for all architectures? Anyway: Reviewed-by: Thomas Huth

Re: [RFC PATCH-for-8.0 06/10] hw/virtio: Cache access_is_big_endian value in VirtIODevice state

2022-12-13 Thread Thomas Huth
On 13/12/2022 08.30, Philippe Mathieu-Daudé wrote: On 13/12/22 01:14, Richard Henderson wrote: On 12/12/22 17:05, Philippe Mathieu-Daudé wrote: The device endianness doesn't change during runtime. What are you talking about?  Of course it does. The host CPU certainly does, but the virtio

Re: [RFC PATCH-for-8.0 06/10] hw/virtio: Cache access_is_big_endian value in VirtIODevice state

2022-12-13 Thread Thomas Huth
On 13/12/2022 09.32, Philippe Mathieu-Daudé wrote: On 13/12/22 09:03, Thomas Huth wrote: On 13/12/2022 08.30, Philippe Mathieu-Daudé wrote: On 13/12/22 01:14, Richard Henderson wrote: On 12/12/22 17:05, Philippe Mathieu-Daudé wrote: The device endianness doesn't change during runtime. What

Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci

2022-11-21 Thread Thomas Huth
On 21/11/2022 17.32, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 21/11/22 15:36, Peter Maydell wrote: On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrote: Tweak the semantic patch to drop redundant parenthesis around the return expression. Coccinelle drops comments in

Re: [PATCH v2 2/4] bulk: Coding style fixes

2023-01-18 Thread Thomas Huth
On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote: Fix the following checkpatch.pl violation on lines using the TARGET_FMT_plx definition to avoid: WARNING: line over 80 characters It's just a warning... @@ -420,8 +421,9 @@ static int get_segment_6xx_tlb(CPUPPCState *env, mmu_ctx_t

Re: QEMU iotest 267 failure / assertion in migration code

2023-01-20 Thread Thomas Huth
On 18/01/2023 19.02, Dr. David Alan Gilbert wrote: * Thomas Huth (th...@redhat.com) wrote: Hi! I just ran "make check" in a build directory where I did not compile qemu-system-x86_64, and got a failure with iotest 267. Re-running the "check" script directly got me s

Re: [PATCH 6/6] gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job

2023-01-30 Thread Thomas Huth
On 30/01/2023 11.58, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:44:46AM +0100, Thomas Huth wrote: We can get rid of the build-coroutine-sigaltstack job by moving the configure flags that should be tested here to other jobs: Move --with-coroutine=sigaltstack to the build-without

QEMU iotest 267 failure / assertion in migration code

2023-01-18 Thread Thomas Huth
Hi! I just ran "make check" in a build directory where I did not compile qemu-system-x86_64, and got a failure with iotest 267. Re-running the "check" script directly got me some more information: $ ./check -qcow2 267 QEMU -- "/tmp/qemu/tests/qemu-iotests/../../qemu-system-alpha"

[PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first

2023-01-04 Thread Thomas Huth
In downstream RHEL builds, we do not have "blkverify" enabled, so iotest 262 is currently failing there. Thus let's list "blkverify" as required item so that the test properly gets skipped instead if "blkverify" is missing. Signed-off-by: Thomas Huth --- tests/qe

[PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver

2023-01-04 Thread Thomas Huth
"quorum" is required by iotest 312 - if it is not compiled into the QEMU binary, the test fails. Thus list "quorum" as required driver so that the test gets skipped in case it is not available. Signed-off-by: Thomas Huth --- tests/qemu-iotests/312 | 1 + 1 file changed,

Re: [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx

2023-01-19 Thread Thomas Huth
On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote: Since v1: - Fix checkpatch style violations - Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan) Supersedes: <20230110212947.34557-1-phi...@linaro.org> "bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx" Philippe Mathieu-Daudé (4):

Re: [PATCH 3/4] qemu-img: remove unused variable

2022-11-10 Thread Thomas Huth
uf = g_new(uint8_t, in.bsz); -for (out_pos = 0; in_pos < size; block_count++) { +for (out_pos = 0; in_pos < size; ) { int bytes = (in_pos + in.bsz > size) ? size - in_pos : in.bsz; ret = blk_pread(blk1, in_pos, bytes, in.buf, 0); Reviewed-by: Thomas Huth

Re: [PATCH v6 4/4] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-10 Thread Thomas Huth
On 05/02/2023 05.07, Alexander Bulekov wrote: This protects devices from bh->mmio reentrancy issues. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Signed-off-by: Alexander Bulekov --- ... diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 65c4979c3c..f077c1b255

Re: [PATCH v2 05/32] gitlab: update centos-8-stream job

2023-03-17 Thread Thomas Huth
comments to the top about setup Signed-off-by: Alex Bennée --- .../custom-runners/centos-stream-8-x86_64.yml | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 31/32] contrib/gitdm: add more individual contributors

2023-03-17 Thread Thomas Huth
up-map-individuals @@ -38,3 +38,4 @@ p...@nowt.org g...@xen0n.name si...@simonsafar.com research_tra...@irq.a4lg.com +shen...@gmail.com FWIW: Reviewed-by: Thomas Huth

Re: [PATCH v2 02/32] tests/docker: all add DOCKER_BUILDKIT to RUNC environment

2023-03-17 Thread Thomas Huth
),--no-cache, \ $(if $(DOCKER_REGISTRY),--cache-from $(DOCKER_REGISTRY)/qemu/$*)) \ Reviewed-by: Thomas Huth

Re: test-blockjob: intermittent CI failures in msys2-64bit job

2023-03-17 Thread Thomas Huth
On 17/03/2023 11.17, Peter Maydell wrote: On Mon, 6 Mar 2023 at 11:16, Peter Maydell wrote: On Fri, 3 Mar 2023 at 18:36, Peter Maydell wrote: I've noticed that test-blockjob seems to fail intermittently on the msys2-64bit job: https://gitlab.com/qemu-project/qemu/-/jobs/3872508803

Re: [PATCH v2 07/32] tests/tcg: add some help output for running individual tests

2023-03-17 Thread Thomas Huth
: help +help: + @echo "TCG tests help $(TARGET_NAME)" + @echo "Built with $(CC)" + @echo "Available tests:" + @$(foreach t,$(RUN_TESTS),echo " $t";) Reviewed-by: Thomas Huth

Re: [PATCH v2 06/32] include/qemu: add documentation for memory callbacks

2023-03-17 Thread Thomas Huth
deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v7 4/6] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-13 Thread Thomas Huth
On 13/03/2023 09.24, Alexander Bulekov wrote: This protects devices from bh->mmio reentrancy issues. Thanks: Thomas Huth for diagnosing OS X test failure. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Paul Durrant Signed-

Re: [PATCH v3] hw/block: replace TABs with space

2023-03-24 Thread Thomas Huth
+- hw/block/nand.c | 222 +++ hw/block/onenand.c | 128 +++--- hw/block/tc58128.c | 136 include/hw/block/flash.h | 20 ++-- 5 files changed, 255 insertions(+), 255 deletions(-) Reviewed-by: Thomas

Re: [PATCH v2] hw/ide: replace TABs with space

2023-03-24 Thread Thomas Huth
+-- hw/ide/core.c | 84 - hw/ide/microdrive.c | 360 +++--- include/hw/ide/internal.h | 248 +- 4 files changed, 360 insertions(+), 360 deletions(-) Reviewed-by: Thomas Huth PS: Please make sure to always CC: qemu

Re: [PATCH 3/5] bulk: Replace [g_]assert(0) -> g_assert_not_reached()

2023-02-22 Thread Thomas Huth
On 22/02/2023 00.25, Philippe Mathieu-Daudé wrote: In order to avoid warnings such commit c0a6665c3c ("target/i386: Remove compilation errors when -Werror=maybe-uninitialized"), replace all assert(0) and g_assert(0) by g_assert_not_reached(). Remove any code following g_assert_not_reached().

Re: [PULL 00/29] Block layer patches

2023-02-27 Thread Thomas Huth
On 24/02/2023 22.35, Philippe Mathieu-Daudé wrote: Hi, On 24/2/23 19:50, Peter Maydell wrote: On Thu, 23 Feb 2023 at 18:51, Kevin Wolf wrote: The following changes since commit 79b677d658d3d35e1e776826ac4abb28cdce69b8:    Merge tag 'net-pull-request' of https://github.com/jasowang/qemu

Re: Proposed way forward Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-17 Thread Thomas Huth
On 17/02/2023 12.37, Daniel P. Berrangé wrote: ... The long life enterprise distros are the pain point in unlocking the new of python features. So the proposal is that, at a minimum, we augment the current policy with words to the effect that: * For long life cycle distributions, QEMU will

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-19 Thread Thomas Huth
On 17/02/2023 21.46, John Snow wrote: On Thu, Feb 16, 2023 at 5:58 AM Thomas Huth wrote: On 15/02/2023 20.05, Markus Armbruster wrote: The discussion under PATCH 6 makes me think there's a bit of confusion about the actual impact of dropping support for Python 3.6. Possibly because it's

Re: [PATCH 5/5] iotests: register each I/O test separately with meson

2023-03-03 Thread Thomas Huth
On 02/03/2023 19.46, Daniel P. Berrangé wrote: Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson. There are various downsides of doing this * You cannot ask 'meson test' to invoke a single I/O test * The meson test

Re: [PATCH 4/5] iotests: print TAP protocol version when reporting tests

2023-03-03 Thread Thomas Huth
13') self.env.print_env('# ') print('1..%d' % len(tests)) else: Reviewed-by: Thomas Huth

Re: [PATCH 2/5] iotests: allow test discovery before building

2023-03-03 Thread Thomas Huth
way: Reviewed-by: Thomas Huth

Re: [PATCH 0/5] iotests: make meson aware of individual I/O tests

2023-03-03 Thread Thomas Huth
On 02/03/2023 19.46, Daniel P. Berrangé wrote: To just repeat the patch 5 description... Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson. There are various downsides of doing this * You cannot ask 'meson test' to

Re: [PATCH 0/5] iotests: make meson aware of individual I/O tests

2023-03-03 Thread Thomas Huth
On 03/03/2023 09.53, Daniel P. Berrangé wrote: On Fri, Mar 03, 2023 at 09:30:39AM +0100, Thomas Huth wrote: On 02/03/2023 19.46, Daniel P. Berrangé wrote: To just repeat the patch 5 description... Currently meson registers a single test that invokes an entire group of I/O tests, hiding

Re: [PATCH 0/5] iotests: make meson aware of individual I/O tests

2023-03-03 Thread Thomas Huth
On 03/03/2023 14.06, Daniel P. Berrangé wrote: On Fri, Mar 03, 2023 at 10:45:40AM +, Daniel P. Berrangé wrote: On Fri, Mar 03, 2023 at 09:30:39AM +0100, Thomas Huth wrote: On 02/03/2023 19.46, Daniel P. Berrangé wrote: 3) When I tried this last year, I had a weird problem

Re: [PATCH v2 8/8] iotests: remove the check-block.sh script

2023-03-03 Thread Thomas Huth
deletions(-) delete mode 100755 tests/check-block.sh Reviewed-by: Thomas Huth

Re: [PATCH v2 0/8] iotests: make meson aware of individual I/O tests

2023-03-03 Thread Thomas Huth
execution remains disabled since the I/O tests do not use self contained execution environments and thus conflict with each other. Series Tested-by: Thomas Huth

Re: [PATCH v2 5/8] iotests: connect stdin to /dev/null when running tests

2023-03-03 Thread Thomas Huth
this while TTY save/restore complexity we can connect the test stdin to /dev/null instead. Signed-off-by: Daniel P. Berrangé --- tests/qemu-iotests/testrunner.py | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 6/8] iotests: always use a unique sub-directory per test

2023-03-03 Thread Thomas Huth
, 10 insertions(+), 10 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 7/8] iotests: register each I/O test separately with meson

2023-03-03 Thread Thomas Huth
/qemu-iotests/meson.build | 35 -- 1 file changed, 29 insertions(+), 6 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 1/8] iotests: explicitly pass source/build dir to 'check' command

2023-03-03 Thread Thomas Huth
- 2 files changed, 27 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth

migrate-bitmaps-postcopy-test failure

2023-03-06 Thread Thomas Huth
Hi, I've just seen this migrate-bitmaps-postcopy-test failure while running "make check -j5 SPEED=slow" on my laptop: @@ -1,5 +1,13 @@ -... +..F +== +FAIL: test_postcopy_success (__main__.TestDirtyBitmapPostcopyMigration)

Re: [PATCH v3 01/14] hw/char/serial-pci: Replace DO_UPCAST(PCISerialState) by PCI_SERIAL()

2023-02-16 Thread Thomas Huth
On 13/02/2023 19.43, Philippe Mathieu-Daudé wrote: Use the PCI_SERIAL() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial-pci.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/char/serial-pci.c

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-16 Thread Thomas Huth
On 15/02/2023 20.05, Markus Armbruster wrote: The discussion under PATCH 6 makes me think there's a bit of confusion about the actual impact of dropping support for Python 3.6. Possibly because it's spelled out in the commit message of PATCH 7. Let me summarize it in one sentence: ***

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-17 Thread Thomas Huth
On 17/02/2023 10.06, Markus Armbruster wrote: Thomas Huth writes: ... My view on all this is a bit more pragmatic. For a human developer, the difference between "dnf install python-sphinx" and "pip install sphinx" is, in my opinion, close to negligible. Really no comp

Re: [PATCH v2 02/18] hw/isa: Factor isa_bus_get_irq() out of isa_get_irq()

2023-02-24 Thread Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH v2 03/18] hw: Replace isa_get_irq() by isa_bus_get_irq() when ISABus is available

2023-02-24 Thread Thomas Huth
, 15 insertions(+), 10 deletions(-) Makes perfectly sense! Reviewed-by: Thomas Huth

Re: [PATCH v2 01/18] hw/isa: Rename isa_get_dma() -> isa_bus_get_dma()

2023-02-24 Thread Thomas Huth
-by: Thomas Huth

[PATCH] configure: Disable thread-safety warnings on macOS

2023-03-01 Thread Thomas Huth
The enablement of -Wthread-safety broke compilation on macOS (if -Werror is enabled, like in our CI). Disable it there by default until the problems are resolved. Signed-off-by: Thomas Huth --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b

Re: [PATCH v2 05/14] tests: make fp-test less chatty when running from test suite

2023-02-21 Thread Thomas Huth
counterpart can be seen here: https://gitlab.com/qemu-project/berkeley-testfloat-3/-/commit/40619cbb3bf32872df8c53cc457039229428a263 Thanks for tackling this! Reviewed-by: Thomas Huth

Re: [PATCH v2 04/14] tests: be a bit more strict cleaning up fifos

2023-02-21 Thread Thomas Huth
g_assert(err == 0); +err = g_rmdir(tmpdir); +g_assert(err == 0); } static void test_io_channel_command_fifo_async(void) Reviewed-by: Thomas Huth

Re: [PATCH v2 13/14] tests: ensure we export job results for some cross builds

2023-02-21 Thread Thomas Huth
On 21/02/2023 10.45, Alex Bennée wrote: We do run tests on some cross builds. Provide a template to ensure we export the testlog to the build artefacts and report the test results via the junit. Signed-off-by: Alex Bennée Reported-by: Peter Maydell Reviewed-by: Thomas Huth

Re: [PATCH v2 09/14] testing: update ubuntu2004 to ubuntu2204

2023-02-21 Thread Thomas Huth
to test builds on the currently still supported baseline. Signed-off-by: Alex Bennée Reviewed-by: John Snow Reviewed-by: Thomas Huth

Re: [PATCH v2 07/14] gitlab: extend custom runners with base_job_template

2023-02-21 Thread Thomas Huth
v1: Reviewed-by: Thomas Huth

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-21 Thread Thomas Huth
On 20/02/2023 20.56, John Snow wrote: On Mon, Feb 20, 2023 at 1:16 AM Thomas Huth wrote: On 17/02/2023 21.46, John Snow wrote: On Thu, Feb 16, 2023 at 5:58 AM Thomas Huth wrote: On 15/02/2023 20.05, Markus Armbruster wrote: The discussion under PATCH 6 makes me think there's a bit

Re: [PATCH v2 11/14] tests: add tuxrun baseline test to avocado

2023-02-21 Thread Thomas Huth
ts): lines..: 16.1% (126894 of 789848 lines) functions..: 20.6% (15954 of 77489 functions) branches...: 9.3% (40727 of 439365 branches) Acked-by: Thomas Huth

Re: [PATCH v2 08/14] tests: don't run benchmarks for the tsan build

2023-02-21 Thread Thomas Huth
-fdt=system --disable-slirp TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user -MAKE_CHECK_ARGS: bench V=1 # gcov is a GCC features gcov: Reviewed-by: Thomas Huth

Re: [PATCH 2/5] scripts/checkpatch.pl: Do not allow assert(0)

2023-02-21 Thread Thomas Huth
On 22/02/2023 00.25, Philippe Mathieu-Daudé wrote: Since commit 262a69f428 ("osdep.h: Prohibit disabling assert() in supported builds") we can not build QEMU with NDEBUG (or G_DISABLE_ASSERT) defined, thus 'assert(0)' always aborts QEMU. However some static analyzers / compilers doesn't notice

Re: [PATCH 3/5] bulk: Replace [g_]assert(0) -> g_assert_not_reached()

2023-02-21 Thread Thomas Huth
On 22/02/2023 00.25, Philippe Mathieu-Daudé wrote: In order to avoid warnings such commit c0a6665c3c ("target/i386: Remove compilation errors when -Werror=maybe-uninitialized"), replace all assert(0) and g_assert(0) by g_assert_not_reached(). Remove any code following g_assert_not_reached().

Re: [PATCH v3 24/24] tests/avocado: disable BootLinuxPPC64 test in CI

2023-02-28 Thread Thomas Huth
On 28/02/2023 20.06, Alex Bennée wrote: This test is exceptionally heavyweight (nearly 330s) compared to the two (both endians) TuxRun baseline tests which complete in under 160s. The coverage is slightly reduced but a more directed test could make up the difference.

Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

2023-02-28 Thread Thomas Huth
On 28/02/2023 22.41, Philippe Mathieu-Daudé wrote: On 28/2/23 20:06, Alex Bennée wrote: To avoid lots of copy and paste lets deal with artefacts in a template. This way we can filter out most of the pre-binary object and library files we no longer need as we have the final binaries.

Re: [PATCH v9 7/8] memory: abort on re-entrancy in debug builds

2023-04-27 Thread Thomas Huth
On 27/04/2023 16.44, Alexander Bulekov wrote: On 230426 1219, Alexander Bulekov wrote: This is useful for using unit-tests/fuzzing to detect bugs introduced by the re-entrancy guard mechanism into devices that are intentionally re-entrant. Signed-off-by: Alexander Bulekov Reviewed-by: Thomas

Re: [PATCH v8 8/8] memory: abort on re-entrancy in debug builds

2023-04-25 Thread Thomas Huth
_io; if (bh->reentrancy_guard->engaged_in_io) { trace_reentrant_aio(bh->ctx, bh->name); +#ifdef DEBUG +abort(); +#endif } bh->reentrancy_guard->engaged_in_io = true; } Reviewed-by: Thomas Huth

Re: [PATCH] async: avoid use-after-free on re-entrancy guard

2023-05-02 Thread Thomas Huth
{ +reentrancy_guard->engaged_in_io = last_engaged_in_io; } } Reviewed-by: Thomas Huth I'll assemble a pull request with this later today, to avoid that people run into this regression. Thomas

Re: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-24 Thread Thomas Huth
On 24/04/2023 07.58, Juan Quintela wrote: "Zhang, Chen" wrote: -Original Message- From: Daniel P. Berrangé Sent: Saturday, April 22, 2023 1:14 AM To: qemu-de...@nongnu.org Cc: qemu-block@nongnu.org; Paolo Bonzini ; Thomas Huth ; John Snow ; Li Zhijian ; Juan Quintela ; Stefa

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the same as the one being passed to it by the avocado user (i.e. the avocado_qemu python module). In the

Re: [PATCH 01/11] scripts/coverage: initial coverage comparison script

2023-03-30 Thread Thomas Huth
providing additional coverage or just burning our precious CI time. Signed-off-by: Alex Bennée FWIW: Acked-by: Thomas Huth

Re: [PATCH 05/11] metadata: add .git-blame-ignore-revs

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: Someone mentioned this on IRC so I thought I would try it out with a few commits that are pure code style fixes. Signed-off-by: Alex Bennée Message-Id: <20230318115657.1345921-1-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by:

Re: [PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

2023-03-30 Thread Thomas Huth
+which is useful in the majority of cases. Older options like ``-hda`` +bake in a lot of assumptions from the days when QEMU was emulating a +legacy PC, they are not recommended for modern configurations. Reviewed-by: Thomas Huth

Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Thomas Huth
Bennée Cc: Thomas Huth Cc: Daniel P. Berrangé Cc: Markus Armbruster Cc: Kashyap Chamarthy Cc: Paolo Bonzini Cc: Peter Maydell Cc: Philippe Mathieu-Daudé Cc: Bernhard Beschow --- v2 - s/your/you are/ - add some willing victims --- MAINTAINERS | 13 + 1 file changed, 13

Re: [PATCH 08/11] tests/vm: use the default system python for NetBSD

2023-03-30 Thread Thomas Huth
ar -xf /dev/rld1a; cd ../build -../src/configure --python=python3.7 --disable-opengl {configure_opts}; +../src/configure --disable-opengl {configure_opts}; gmake --output-sync -j{jobs} {target} {verbose}; """ poweroff = "/sbin/poweroff" Reviewed-by: Thomas Huth

Re: [PATCH 10/11] gitlab: fix typo

2023-03-30 Thread Thomas Huth
/base.yml @@ -75,5 +75,5 @@ - if: '$QEMU_CI != "2" && $CI_PROJECT_NAMESPACE != "qemu-project"' when: manual -# Jobs can run if any jobs they depend on were successfull +# Jobs can run if any jobs they depend on were successful - when: on_s

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Thomas Huth
On 30/03/2023 14.12, Alex Bennée wrote: Thomas Huth writes: On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the same as the one being passed

Re: [PATCH 11/11] tests/gitlab: use kaniko to build images

2023-03-30 Thread Thomas Huth
quot;." -- docker push "$TAG" - after_script: -- docker logout +- /kaniko/executor + --reproducible + --context "${CI_PROJECT_DIR}" + --cache=true + --cache-repo "${COMMON_TAG}" + --dockerfile "${CI_PROJECT_DIR}/tests/docker/dockerfiles/$NAME.docker" + --destination "${TAG}" Acked-by: Thomas Huth

Re: [PATCH 07/11] tests/qemu-iotests: explicitly invoke 'check' via 'python'

2023-03-30 Thread Thomas Huth
purious failures test('io-' + format + '-' + item, - qemu_iotests_check_cmd, + python, args: args, depends: qemu_iotests_binaries, env: qemu_iotests_env, Reviewed-by: Thomas Huth

Re: [PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

2023-04-03 Thread Thomas Huth
On 03/04/2023 16.55, Markus Armbruster wrote: Alex Bennée writes: Markus Armbruster writes: Alex Bennée writes: ... I was under the impression things like -hda wouldn't work say on an Arm machine because you don't know what sort of interface you might be using and -hda implies IDE.

Re: [PATCH v2 7/8] iotests: register each I/O test separately with meson

2023-03-29 Thread Thomas Huth
On 29/03/2023 13.18, Daniel P. Berrangé wrote: On Wed, Mar 29, 2023 at 12:47:51PM +0200, Thomas Huth wrote: On 03/03/2023 17.07, Daniel P. Berrangé wrote: Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson

Re: [PATCH v2 7/8] iotests: register each I/O test separately with meson

2023-03-29 Thread Thomas Huth
On 03/03/2023 17.07, Daniel P. Berrangé wrote: Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson. There are various downsides of doing this * You cannot ask 'meson test' to invoke a single I/O test * The meson test

Re: s390x TCG migration failure

2023-03-29 Thread Thomas Huth
On 29/03/2023 00.21, Nina Schoetterl-Glausch wrote: On Tue, 2023-03-28 at 15:01 +0200, Thomas Huth wrote: On 24/03/2023 19.41, Nina Schoetterl-Glausch wrote: Hi, We're seeing failures running s390x migration kvm-unit-tests tests with TCG. Some initial findings: What seems to be happening

Re: s390x TCG migration failure

2023-04-04 Thread Thomas Huth
On 29/03/2023 08.36, Thomas Huth wrote: On 29/03/2023 00.21, Nina Schoetterl-Glausch wrote: On Tue, 2023-03-28 at 15:01 +0200, Thomas Huth wrote: On 24/03/2023 19.41, Nina Schoetterl-Glausch wrote: Hi, We're seeing failures running s390x migration kvm-unit-tests tests with TCG. Some

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-31 Thread Thomas Huth
On 30/03/2023 14.21, Thomas Huth wrote: On 30/03/2023 14.12, Alex Bennée wrote: Thomas Huth writes: On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't

Re: s390x TCG migration failure

2023-03-28 Thread Thomas Huth
On 24/03/2023 19.41, Nina Schoetterl-Glausch wrote: Hi, We're seeing failures running s390x migration kvm-unit-tests tests with TCG. Some initial findings: What seems to be happening is that after migration a control block header accessed by the test code is all zeros which causes an

Re: [PATCH 6/6] gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job

2023-02-03 Thread Thomas Huth
On 30/01/2023 11.58, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:44:46AM +0100, Thomas Huth wrote: We can get rid of the build-coroutine-sigaltstack job by moving the configure flags that should be tested here to other jobs: Move --with-coroutine=sigaltstack to the build-without

Re: [PATCH 6/6] gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job

2023-02-05 Thread Thomas Huth
On 03/02/2023 22.14, Juan Quintela wrote: Peter Maydell wrote: On Fri, 3 Feb 2023 at 15:44, Thomas Huth wrote: On 03/02/2023 13.08, Kevin Wolf wrote: Am 03.02.2023 um 12:23 hat Thomas Huth geschrieben: On 30/01/2023 11.58, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:44:46AM

Re: [PATCH 6/6] gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job

2023-02-03 Thread Thomas Huth
On 03/02/2023 13.08, Kevin Wolf wrote: Am 03.02.2023 um 12:23 hat Thomas Huth geschrieben: On 30/01/2023 11.58, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:44:46AM +0100, Thomas Huth wrote: We can get rid of the build-coroutine-sigaltstack job by moving the configure flags

Re: [RFC PATCH v2 19/19] hw/usb: Inline usb_bus_from_device()

2023-02-13 Thread Thomas Huth
On 13/02/2023 08.08, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC Other devices don't use such helper. Maybe it should be the other way around, introduce more bus_from_device() helpers? --- hw/usb/bus.c| 10 +- hw/usb/core.c | 6

Re: [RFC PATCH v2 19/19] hw/usb: Inline usb_bus_from_device()

2023-02-13 Thread Thomas Huth
On 13/02/2023 09.44, Philippe Mathieu-Daudé wrote: On 13/2/23 09:11, Thomas Huth wrote: On 13/02/2023 08.08, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC Other devices don't use such helper. Maybe it should be the other way around, introduce more

Re: [PATCH 15/19] hw/s390x/event-facility: Replace DO_UPCAST(SCLPEvent) by SCLP_EVENT()

2023-02-13 Thread Thomas Huth
ing) { -DeviceState *qdev = kid->child; -event = DO_UPCAST(SCLPEvent, qdev, qdev); +event = SCLP_EVENT(kid->child); event_class = SCLP_EVENT_GET_CLASS(event); if (event->event_pending && event_class->get_send_mask() & ef->receive_mask) { Reviewed-by: Thomas Huth

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

2023-02-14 Thread Thomas Huth
On 14/02/2023 08.40, Markus Armbruster wrote: Daniel P. Berrangé writes: [...] We don't have to drop python 3.6. It is a choice because of a desire to be able to use some shiny new python features without caring about back compat. I read this on Friday, and decided to let it sit until

Re: [PATCH 10/12] tests/qemu-iotests: Require virtio-scsi-pci

2023-02-07 Thread Thomas Huth
MACHINE" != "pc" ]; then _notrun "Requires a PC machine" Reviewed-by: Thomas Huth

Re: [PATCH 5/7] testing: Add Python >= 3.7 to Centos, OpenSuSE

2023-02-09 Thread Thomas Huth
On 09/02/2023 16.40, John Snow wrote: This is just a proof-of-concept patch, as these files are lcitool generated. The real fix will involve updating the lcitool configuration and updating these files that way. I think it would be good to have a RFC or DONOTMERGE in the patch title, so that

<    6   7   8   9   10   11   12   13   >