. By switching to
these parsing functions, we can finally drop our own URI parsing
code in util/uri.c.
NB: We also need to update some of the custom runners in our CI
environment first (since they still use Ubuntu 20.04).
Thomas Huth (9):
tests: Remove Ubuntu 20.04 container
tests/lcitool
which will
allow further clean-ups in the following patches.
Signed-off-by: Thomas Huth
---
meson.build | 16 +---
include/glib-compat.h| 27 ++-
qga/commands-posix-ssh.c | 4 ++--
3 files changed, 5 insertions(+), 42 deletions(-)
diff --git a
We need the latest fixes for the lcitool to be able to properly
update our CentOS docker file to CentOS Stream 9.
Signed-off-by: Thomas Huth
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
index
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Cc: integrat...@gluster.org
Signed-off-by: Thomas Huth
---
block/gluster.c | 63 +
1 file
RHEL 9 (and thus also the derivatives) are available since two years
now, so according to QEMU's support policy, we can drop the active
support for the previous major version 8 now.
Thus upgrade our CentOS Stream container to major version 9 now.
Signed-off-by: Thomas Huth
---
.gitlab
.
Signed-off-by: Thomas Huth
---
block/nbd.c | 66 ++---
1 file changed, 38 insertions(+), 28 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index ef05f7cdfd..95b507f872 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -31,7 +31,6 @@
#include "
Since Ubuntu 22.04 is now available since two years, we can stop
actively supporting the previous LTS version of Ubuntu now.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/ubuntu2004.docker | 157 -
tests/lcitool/refresh | 1 -
2 files changed
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/nfs.c | 102 ++--
1 file changed, 52 insertions(+), 50
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/ssh.c | 69 +++--
1 file changed, 40 insertions(+), 29
On 28/03/2024 16.01, Peter Xu wrote:
On Thu, Mar 28, 2024 at 11:18:04AM -0300, Fabiano Rosas wrote:
Philippe Mathieu-Daudé writes:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2.
Remove:
- RDMA h
On 28/03/2024 15.59, Daniel P. Berrangé wrote:
On Thu, Mar 28, 2024 at 09:54:49AM -0500, Eric Blake wrote:
On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote:
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
m-mux tool from contrib/
Cc: Yuval Shaia
Cc: Marcel Apfelbaum
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Thomas Huth
docs/system/qemu-block-drivers.rst.inc | 1 -
block/gluster.c| 39 --
3 files changed, 2 insertions(+), 42 deletions(-)
Reviewed-by: Thomas Huth
rintf(&enc[i * 2], "%02x", data[i]);
^
1 warning generated.
Signed-off-by: Philippe Mathieu-Daudé
---
system/qtest.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth
On 12/04/2024 12.16, Paolo Bonzini wrote:
On Thu, Mar 28, 2024 at 3:06 PM Thomas Huth wrote:
Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can
look into bumping the glib version to a new minimum for further
clean-ups. According to repology.org, available versions are
Since Ubuntu 22.04 is now available since two years, we can stop
actively supporting the previous LTS version of Ubuntu now.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/ubuntu2004.docker | 157 -
tests/lcitool/refresh | 1 -
2 files changed
which will
allow further clean-ups in the following patches.
Signed-off-by: Thomas Huth
---
meson.build | 16 +---
include/glib-compat.h| 27 ++-
qga/commands-posix-ssh.c | 4 ++--
3 files changed, 5 insertions(+), 42 deletions(-)
diff --git a
We need the latest fixes for the lcitool to be able to properly
update our CentOS docker file to CentOS Stream 9.
Signed-off-by: Thomas Huth
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
index
ch to drop more glib compatibility hunks
- Use g_autoptr() in the URI patches for simplification
- Don't allow port 0 in the URIs
Paolo Bonzini (1):
ci: move external build environment setups to CentOS Stream 9
Thomas Huth (12):
tests: Remove Ubuntu 20.04 container
tests/lcitool/libvirt-ci:
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/gluster.c | 71 -
1 file changed, 35 insertions(+), 36
This update adds the removing of the EXTERNALLY-MANAGED marker files
that has been added to the lcitool recently.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/alpine.docker| 3 ++-
tests/docker/dockerfiles/centos8.docker | 1 +
tests/docker/dockerfiles
RHEL 9 (and thus also the derivatives) are available since two years
now, so according to QEMU's support policy, we can drop the active
support for the previous major version 8 now.
Thus upgrade our CentOS Stream container to major version 9 now.
Signed-off-by: Thomas Huth
---
.gitlab
Now that we switched all consumers of the URI code to use the URI
parsing functions from glib instead, we can remove our internal
URI parsing code since it is not used anymore.
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 99 ---
util/uri.c | 1466
, we
can drop the entries from the individual jobs and use the global
setting again.
Signed-off-by: Thomas Huth
---
.travis.yml | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 8a3ae76a7c..56a2a01e14 100644
--- a/.travis.yml
+++ b
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/nfs.c | 110 ++--
1 file changed, 54 insertions(+), 56
igned-off-by: Paolo Bonzini
Reviewed-by: Thomas Huth
Message-ID: <20240412103708.27650-1-pbonz...@redhat.com>
Signed-off-by: Thomas Huth
---
.../stream/{8 => 9}/build-environment.yml | 31 ++---
.../stream/{8 => 9}/x86_64/configure | 4 +-
.../stream/{8 => 9}
Now that we bumped the minumum glib version to 2.66, we can drop
the old code.
Suggested-by: Paolo Bonzini
Signed-off-by: Thomas Huth
---
qga/commands-posix-ssh.c | 8
util/error-report.c | 10 --
2 files changed, 18 deletions(-)
diff --git a/qga/commands-posix-ssh.c b
.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Thomas Huth
---
block/nbd.c | 76 ++---
1 file changed, 37 insertions(+), 39 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index ef05f7cdfd..589d28af83 100644
--- a/block/nbd.c
+++ b/block/nbd.c
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Thomas Huth
---
block/ssh.c | 75 -
1 file
On 12/04/2024 16.40, Eric Blake wrote:
On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote:
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block
On 17/04/2024 18.15, Daniel P. Berrangé wrote:
On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote:
RHEL 9 (and thus also the derivatives) are available since two years
now, so according to QEMU's support policy, we can drop the active
support for the previous major version 8 now.
Since Ubuntu 22.04 is now available since two years, we can stop
actively supporting the previous LTS version of Ubuntu now.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/ubuntu2004.docker | 157 -
tests/lcitool/refresh
es for simplification
- Don't allow port 0 in the URIs
Paolo Bonzini (1):
ci: move external build environment setups to CentOS Stream 9
Thomas Huth (12):
tests: Remove Ubuntu 20.04 container
tests/lcitool/libvirt-ci: Update to the latest master branch
tests/docker/dockerfiles: Run
g_uri_get_path() as input).
Reviewed-by: Eric Blake
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
block/gluster.c | 71 -
1 file changed, 35 insertions(+), 36 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index cc74af06dc
which will
allow further clean-ups in the following patches.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
meson.build | 16 +---
include/glib-compat.h| 27 ++-
qga/commands-posix-ssh.c | 4 ++--
3 files changed, 5 insertions
, we
can drop the entries from the individual jobs and use the global
setting again.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
.travis.yml | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 8a3ae76a7c..56a2a01e14
recious installation environment. Our containers are disposable
though, so a venv has no benefit. Removing the 'EXTERNALLY-MANAGED'
allows the historical arbitrary use of 'pip' outside a venv.
lcitool just does this unconditionally given the containers are
not precious."
Reviewed-
Now that we switched all consumers of the URI code to use the URI
parsing functions from glib instead, we can remove our internal
URI parsing code since it is not used anymore.
Reviewed-by: Eric Blake
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 99 ---
util/uri.c | 1466
We need the latest fixes for the lcitool to be able to properly
update our CentOS docker file to CentOS Stream 9.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci
; since the
latter rather sounds like the users were breaking a law here.
Reviewed-by: Eric Blake
Signed-off-by: Thomas Huth
---
block/nfs.c | 110 ++--
1 file changed, 54 insertions(+), 56 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
ind
.
Reviewed-by: Richard W.M. Jones
Reviewed-by: Eric Blake
Signed-off-by: Thomas Huth
---
block/nbd.c | 76 ++---
1 file changed, 37 insertions(+), 39 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index ef05f7cdfd..589d28af83 100644
--- a/block
dates-are-coming-for-centos-stream-8-and-centos-linux-7/
"After May 31, 2024, CentOS Stream 8 will be archived
and no further updates will be provided."
Thus upgrade our CentOS Stream container to major version 9 now.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
--
os or other mistakes.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Thomas Huth
---
block/ssh.c | 75 -
1 file changed, 40 insertions(+), 35 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 2748253d4a..a88171d4b5 100644
--- a/block/
Now that we bumped the minumum glib version to 2.66, we can drop
the old code.
Suggested-by: Paolo Bonzini
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
qga/commands-posix-ssh.c | 8
util/error-report.c | 10 --
2 files changed, 18 deletions(-)
diff
igned-off-by: Paolo Bonzini
Reviewed-by: Thomas Huth
Message-ID: <20240412103708.27650-1-pbonz...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
.../stream/{8 => 9}/build-environment.yml | 31 ++---
.../stream/{8 => 9}/x86_64/config
On 30/04/2024 02.17, Richard Henderson wrote:
On 4/28/24 20:25, Jeuk Kim wrote:
From: Jeuk Kim
It fixes the buffer overflow vulnerability in the ufs device.
The bug was detected by sanitizers.
You can reproduce it by:
cat << EOF |\
qemu-system-x86_64 \
-display none -machine accel=qtest -m 5
On 30/04/2024 06.32, Thomas Huth wrote:
On 30/04/2024 02.17, Richard Henderson wrote:
On 4/28/24 20:25, Jeuk Kim wrote:
From: Jeuk Kim
It fixes the buffer overflow vulnerability in the ufs device.
The bug was detected by sanitizers.
You can reproduce it by:
cat << EOF |\
qemu-system-
shm,id=mem,size=256M,share=on "
" -M memory-backend=mem -m 256M ");
for (i = 0; i < vus_instances; i++) {
Acked-by: Thomas Huth
test_read_guest_mem, &opts);
+opts.before = vhost_user_test_setup_shm;
+qos_add_test("vhost-user/read-guest-mem/shm",
+ "virtio-net",
+ test_read_guest_mem, &opts);
+
if (qemu_memfd_check(MFD_ALLOW_SEALING)) {
opts.before = vhost_user_test_setup_memfd;
qos_add_test("vhost-user/read-guest-mem/memfd",
Acked-by: Thomas Huth
Could you maybe use "qtest-ufs.XX" or something more prominent instead?
... in case the files don't get deleted correctly, it's easier to know at
which test to look at later.
With that change:
Acked-by: Thomas Huth
On 26/07/2023 15.00, Peter Maydell wrote:
On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote:
To make things easier, this is the part that show how it breaks (this is
the gcov test):
357/423 qemu:block / io-qcow2-copy-before-write
ERROR 6.38s exit status
looking for "-j..." in the MAKEFLAGS environment variable.
Signed-off-by: Thomas Huth
---
PS: Yeah, I know, this is a little bit ugly ... if someone has a better
idea how to fix this, please let me know.
tests/qemu-iotests/183 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
On 24/08/2023 15.38, Fiona Ebner wrote:
Fails without the previous commit "hw/ide: reset: cancel async DMA
operation before reseting state".
I haven't ever written such a test before, but I wanted something to
expose the problem more easily. It hardcodes the behavior that the
pending write actua
mit 1",
"migrate_set_parameter max-bandwidth 1",
"netdev_add user,id=net1",
Reviewed-by: Thomas Huth
uster
---
Reviewed-by: Thomas Huth
The current description says that these options will create a device
on the IDE bus, which is only true on x86. So rephrase these sentences
a little bit to speak of "default bus" instead.
Signed-off-by: Thomas Huth
---
qemu-options.hx | 20
1 file changed, 12
On 29/08/2023 18.39, Alex Bennée wrote:
Thomas Huth writes:
The current description says that these options will create a device
on the IDE bus, which is only true on x86. So rephrase these sentences
a little bit to speak of "default bus" instead.
Signed-off-by: Thomas Huth
int i; \
^
hw/m68k/virt.c:130:9: note: previous declaration is here
int i;
^
Signed-off-by: Philippe Mathieu-Daudé
---
hw/m68k/bootinfo.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
On 04/10/2023 14.16, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
Fix:
semihosting/config.c:134:49: error: declaration shadows a variable in the
global scope [-Werror,-Wshadow]
int qemu_semihosting_config_options(const char *optarg)
ot;, "dict");
+error_setg(errp,
+ "Invalid parameter type for 'props', expected: dict");
return;
}
}
Acked-by: Thomas Huth
+++---
2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Thomas Huth
parse(QemuOptsList *opts_list, const char *optarg)
+void net_client_parse(QemuOptsList *opts_list, const char *optstr)
{
-if (!qemu_opts_parse_noisily(opts_list, optarg, true)) {
+ if (!qemu_opts_parse_noisily(opts_list, optstr, true)) {
exit(1);
}
}
Reviewed-by: Thomas Huth
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote:
Add a method to return the architecture bits (currently 8/32/64).
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/libqtest.h | 8
tests/qtest/libqtest.c | 21 +
2 files changed, 29 insertions(+)
diff --g
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote:
Some short patch description, please! Why is this necessary/useful?
(I think I know, but other might not, and it is also important for the history)
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/arm-cpu-features.c | 49 +++
On 10/10/2023 10.42, Philippe Mathieu-Daudé wrote:
On 10/10/23 09:49, Philippe Mathieu-Daudé wrote:
While qtest_get_arch() returns the target architecture name,
such "i386" or "x86_64", qtest_get_base_arch() return the
"base" (or real underlying) architecture, in this example
that is "x86".
Sig
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote:
Additionally use qtest_get_arch_bits() when relevant.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/ahci-test.c | 5 ++---
tests/qtest/am53c974-test.c | 4 +---
tests/qtest/bios-tables-test.c| 6 +++---
tests
object_unparent(qobj);
}
object_unref(OBJECT(chr));
-object_unref(qtest);
+object_unref(qobj);
}
Reviewed-by: Thomas Huth
6,7 +156,7 @@ static QVirtioSCSIQueues *qvirtio_scsi_init(QVirtioDevice
*dev)
return vs;
}
-static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
+static void hotplug(void *obj, void *data, QGuestAllocator *t_alloc)
{
QTestState *qts = global_qtest;
Reviewed-by: Thomas Huth
: Philippe Mathieu-Daudé
---
tests/qtest/rtl8139-test.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
est.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Thomas Huth
(EventNotifier *n)
Reviewed-by: Thomas Huth
On 09/10/2023 12.02, Philippe Mathieu-Daudé wrote:
Rename the argument to avoid:
tests/unit/test-aio-multithread.c:226:37: error: declaration shadows a
variable in the global scope [-Werror,-Wshadow]
static void test_multi_co_mutex(int threads, int seconds)
++--
1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
On 17/10/2023 09.24, Juan Quintela wrote:
Stefan Hajnoczi wrote:
On Mon, 16 Oct 2023 at 06:11, Juan Quintela wrote:
The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56:
Merge tag 'pull-riscv-to-apply-20231012-1' of
https://github.com/alistair23/qemu into staging
On 19/10/2023 23.15, Cédric Le Goater wrote:
On 10/19/23 22:49, Greg Kurz wrote:
Hi Juan,
On Thu, 19 Oct 2023 21:08:25 +0200
Juan Quintela wrote:
Current code does:
- register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
dependinfg on cpu number
- for newer machines, it regis
On 20/10/2023 10.06, Greg Kurz wrote:
On Fri, 20 Oct 2023 09:30:44 +0200
Juan Quintela wrote:
Greg Kurz wrote:
On Thu, 19 Oct 2023 21:08:25 +0200
Juan Quintela wrote:
Current code does:
- register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
dependinfg on cpu number
- for
On 20/10/2023 11.54, Juan Quintela wrote:
Christian Borntraeger wrote:
Am 20.10.23 um 11:07 schrieb Juan Quintela:
Just with make check I can see that we can have more than one of this
devices, so use ANY.
ok 5 /s390x/device/introspect/abstract-interfaces
...
Broken pipe
../../../../../mnt/cod
On 20/10/2023 11.07, Juan Quintela wrote:
Otherwise device-introspection-test fails.
$ ./tests/qtest/device-introspect-test
...
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEMU process but encountered exit status 1 (expected 0)
Aborte
On 20/10/2023 11.07, Juan Quintela wrote:
Otherwise qom-test fails.
ok 4 /i386/qom/x-remote
qemu-system-i386: savevm_state_handler_insert: Detected duplicate
SaveStateEntry: id=isa-ide, instance_id=0x0
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
vga_init(&s->vga, OBJECT(dev), address_space, io, true);
-vmstate_register(NULL, 0, &vmstate_vga_common, &s->vga);
+vmstate_register_any(NULL, &vmstate_vga_common, &s->vga);
s->new_depth = 32;
}
Reviewed-by: Thomas Huth
On 20/10/2023 11.07, Juan Quintela wrote:
Otherwise device-introspection-test fails.
$ ./tests/qtest/device-introspect-test
...
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEMU process but encountered exit status 1 (expected 0)
Aborte
On 20/10/2023 11.07, Juan Quintela wrote:
Just with make check I can see that we can have more than one of this
devices, so use ANY.
ok 5 /s390x/device/introspect/abstract-interfaces
...
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEM
On 20/10/2023 21.42, Juan Quintela wrote:
Thomas Huth wrote:
On 20/10/2023 11.07, Juan Quintela wrote:
Otherwise qom-test fails.
ok 4 /i386/qom/x-remote
qemu-system-i386: savevm_state_handler_insert: Detected duplicate
SaveStateEntry: id=isa-ide, instance_id=0x0
Broken pipe
apshot_fallback() and callers GRAPH_RDLOCK")
Signed-off-by: Thomas Huth
---
block/snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/snapshot.c b/block/snapshot.c
index 6e16eb803a..50adf5381e 100644
--- a/block/snapshot.c
+++ b/block/snapshot.c
@@
On 23/10/2023 17.26, Markus Armbruster wrote:
Thomas Huth writes:
No need to declare a new variable in the the inner code block
here, we can re-use the "ret" variable that has been declared
at the beginning of the function. With this change, the code
can now be successfully com
apshot_fallback() and callers GRAPH_RDLOCK")
Signed-off-by: Thomas Huth
---
v2: Assign "ret" only in one spot
block/snapshot.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block/snapshot.c b/block/snapshot.c
index 6e16eb803a..55974273ae 100644
---
On 24/10/2023 12.37, Markus Armbruster wrote:
Markus Armbruster writes:
Thomas Huth writes:
No need to declare a new variable in the the inner code block
here, we can re-use the "ret" variable that has been declared
at the beginning of the function. With this change, the code
On 24/10/2023 15.12, Juan Quintela wrote:
From: Thomas Huth
Since the instance_init() function immediately tries to set the
property to "true", the s390_skeys_set_migration_enabled() tries
to register a savevm handler during instance_init(). However,
instance_init() functions can
On 24/10/2023 15.12, Juan Quintela wrote:
From: Thomas Huth
There's no need for dedicated handlers here if they don't do anything
special.
Acked-by: David Hildenbrand
Reviewed-by: Eric Farman
Acked-by: Juan Quintela
Signed-off-by: Thomas Huth
Signed-off-by: Juan Quintela
On 09/10/2023 12.02, Philippe Mathieu-Daudé wrote:
Clean up global variables shadowing in tests/
in order to be able to use -Wshadow with Clang.
Philippe Mathieu-Daudé (10):
system/qtest: Clean up global variable shadowing in
qtest_server_init()
tests/throttle: Clean up global variabl
On 26/09/2024 12.24, Michael Tokarev wrote:
25.09.2024 10:24, Thomas Huth wrote:
Commit 0ea0538fae516f9b4 removed the default machine of the sh4
binaries, so a lot of iotests are failing now without such a default
machine. Teach the iotest harness to use the "r2d" machine instead
t
| 7 ---
migration/ram.c | 2 --
3 files changed, 10 deletions(-)
Reviewed-by: Thomas Huth
On 23/09/2024 18.03, Eric Blake wrote:
On Sun, Sep 22, 2024 at 08:51:22PM GMT, Richard W.M. Jones wrote:
On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote:
On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote:
Since version 2.66, glib has useful URI parsing functions
According to https://marc.info/?l=fedora-devel-list&m=171934833215726
the GlusterFS development effectively ended. Thus mark it as deprecated
in QEMU, so we can remove it in a future release if the project does
not gain momentum again.
Signed-off-by: Thomas Huth
---
docs/about/deprecated
Commit 0ea0538fae516f9b4 removed the default machine of the sh4
binaries, so a lot of iotests are failing now without such a default
machine. Teach the iotest harness to use the "r2d" machine instead
to fix this problem.
Signed-off-by: Thomas Huth
---
v2: "r2d" only works
According to https://marc.info/?l=fedora-devel-list&m=171934833215726
the GlusterFS development effectively ended. Thus mark it as deprecated
in QEMU, so we can remove it in a future release if the project does
not gain momentum again.
Acked-by: Niels de Vos
Signed-off-by: Thomas Huth
---
On 20/09/2024 10.06, Yoshinori Sato wrote:
On Wed, 18 Sep 2024 04:43:50 +0900,
Thomas Huth wrote:
Commit 0ea0538fae516f9b4 removed the default machine of the sh4
binaries, so a lot of iotests are failing now without such a default
machine. Teach the iotest harness to use the "r2d&quo
On 24/09/2024 16.12, Peter Krempa wrote:
On Tue, Sep 24, 2024 at 15:24:51 +0200, Thomas Huth wrote:
According to https://marc.info/?l=fedora-devel-list&m=171934833215726
the GlusterFS development effectively ended. Thus mark it as deprecated
in QEMU, so we can remove it in a future releas
;
void blk_update_root_state(BlockBackend *blk);
bool blk_get_detect_zeroes_from_root_state(BlockBackend *blk);
Reviewed-by: Thomas Huth
gned-off-by: Thomas Huth
---
v3: Some rewordings according to Markus' and Daniel's suggestions
docs/about/deprecated.rst | 9 +
qapi/block-core.json | 8 +++-
block/gluster.c | 2 ++
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/docs/about/de
1201 - 1300 of 1302 matches
Mail list logo
