On 16/07/2019 17.26, Max Reitz wrote:
> On 16.07.19 14:28, Thomas Huth wrote:
>> Remove some more tests from the "auto" group that either have issues
>> in certain environments (like macOS or FreeBSD, or on certain file systems
>> like ZFS or tmpfs), do
On 8/13/19 5:20 PM, Eric Blake wrote:
> On 8/13/19 4:30 AM, Thomas Huth wrote:
>> No test is using hmp() anymore, and since this function uses the disliked
>> global_qtest variable, we should also make sure that nobody adds new code
>> with this function again. qtest_hmp() s
Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 246 instead.
Message-Id: <20190717111947.30356-5-th...@redhat.com>
Signed-
pen_common and raw_normalize_devicepath; in fact, we can even
use error_setg_file_open to make sure the error message is the same as in
the rest of QEMU.
Message-Id: <20190725095920.28419-1-pbonz...@redhat.com>
Tested-by: Thomas Huth
Signed-off-by: Paolo Bonzini
Reviewed-by: Philippe Mathi
quot;make check"
Paolo Bonzini (1):
block: fix NetBSD qemu-iotests failure
Thomas Huth (2):
tests: Run the iotests during "make check" again
gitlab-ci: Remove qcow2 tests that are handled by "m
script since we do not need that anymore
(and having two shell wrapper scripts around the block tests seems rather
confusing than helpful).
Message-Id: <20190717111947.30356-4-th...@redhat.com>
Signed-off-by: Thomas Huth
[AJB: -makecheck to check-block.sh, move check-block to start and g
tain drivers first,
and marks the test as "not run" if one of the drivers is missing.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/071 | 1 +
tests/qemu-iotests/081 | 1 +
tests/qemu-iotests/099 | 1 +
tests/qemu-iotests/184 | 1 +
tests/qemu-iotests/
On 8/12/19 9:16 PM, John Snow wrote:
>
>
> On 7/25/19 4:34 AM, Thomas Huth wrote:
>> On 24/07/2019 18.29, Paolo Bonzini wrote:
>>> On 24/07/19 11:34, Thomas Huth wrote:
>>>> In case somebody is interested, two of the "auto" iotests are fai
On 8/12/19 9:20 PM, Max Reitz wrote:
> On 12.08.19 21:14, John Snow wrote:
>>
>>
>> On 7/22/19 8:58 AM, Thomas Huth wrote:
>>> Not sure if it has been reported before, but test 059 currently fails:
>>>
>>> 059 fail [14:55:21] [14:55:26]
On 7/30/19 3:23 PM, Andrey Shinkevich wrote:
>
>
> On 30/07/2019 15:59, Thomas Huth wrote:
>> On 30/07/2019 14.52, Thomas Huth wrote:
>>> On 29/07/2019 14.46, Andrey Shinkevich wrote:
>>>> This patch is to reduce the number of Valgrind report messages a
The libqos library functions should never depend on global_qtest,
since these functions might be used in tests that track multiple
test states. So let's use the test state of the QPCIDevice instead.
Signed-off-by: Thomas Huth
---
tests/libqos/virtio-pci.c | 8
1 file changed, 4
not
depend on global_qtest or functions that rely on this variable.
This patch series gets rid of these dependencies in most of the libqtest
and libqos code.
Thomas Huth (6):
tests/libqos: Make generic virtio code independent from global_qtest
tests/libqos: Make virtio-pci code independent from
The libqos library functions should never depend on global_qtest,
since these functions might be used in tests that track multiple
test states. Pass around a pointer to the QTestState instead.
Signed-off-by: Thomas Huth
---
tests/libqos/virtio.c| 74 ++-
tests/libqos
The generic libqtest library functions should not use functions that
require the global_qtest variable.
Signed-off-by: Thomas Huth
---
tests/libqtest.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3e9245d4c9..d1aead30ed
The normal libqtest library functions should never depend on global_qtest.
Pass in the test state via parameter instead. And while we're at it,
also rename this function to qtest_qmp_assert_success() to make it clear
that it is part of libqtest.
Signed-off-by: Thomas Huth
---
tests/libqtest.c
No test is using hmp() anymore, and since this function uses the disliked
global_qtest variable, we should also make sure that nobody adds new code
with this function again. qtest_hmp() should be used instead.
Signed-off-by: Thomas Huth
---
tests/libqtest.c | 11 ---
tests/libqtest.h
Generic library functions like qtest_qmp_device_add() and _del()
should not depend on the global_qtest variable. Pass the test
state via parameter instead.
Signed-off-by: Thomas Huth
---
tests/cpu-plug-test.c | 15 +--
tests/e1000e-test.c| 2 +-
tests/ivshmem-test.c
t; index bc1ceb9792..ae169778b0 100644
> --- a/tests/qemu-iotests/245
> +++ b/tests/qemu-iotests/245
> @@ -598,7 +598,7 @@ class TestBlockdevReopen(iotests.QMPTestCase):
> ##
> ## null ##
> ##
> - opts = {'driver': 'null-aio', 'node-name': 'root', 'size': 1024}
> +opts = {'driver': 'null-co', 'node-name': 'root', 'size': 1024}
>
> result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
> self.assert_qmp(result, 'return', {})
>
Reviewed-by: Thomas Huth
On 8/19/19 10:18 PM, Max Reitz wrote:
> null-aio may not be whitelisted. Skip all test cases that require it.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/093 | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/093
"-nodefaults -machine
> tricore_testboard,accel=qtest"
> +export QEMU_OPTIONS="-nodefaults -display none -machine
> tricore_testboard,accel=qtest"
> ;;
> *)
> -export QEMU_OPTIONS="-nodefaults -machine accel=qtest"
> +export QEMU_OPTIONS="-nodefaults -display none -machine accel=qtest"
> ;;
> esac
Reviewed-by: Thomas Huth
On 8/19/19 9:13 PM, Max Reitz wrote:
> On 19.08.19 11:21, Thomas Huth wrote:
>> The python code already contains a possibility to skip tests if the
>> corresponding driver is not available in the qemu binary - use it
>> in more spots to avoid that the tests are failing if t
On 8/16/19 9:37 AM, tony.ngu...@bt.com wrote:
> Simplify endianness comparisons with consistent use of the more
> expressive MemOp.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Tony Nguyen
> Reviewed-by: Richard Henderson
> Acked-by: David Gibson
This patch is *huge*, more than
The python code already contains a possibility to skip tests if the
corresponding driver is not available in the qemu binary - use it
in more spots to avoid that the tests are failing if the driver has
been disabled.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/030 | 3 +++
tests/qemu
On 8/20/19 8:48 PM, Max Reitz wrote:
> On 20.08.19 18:01, Thomas Huth wrote:
[...]
>> Well, we disable blkverify in our downstream RHEL version of QEMU - so
>> it would be great if the iotests could at least adapt to that missing
>> driver.
>
> I would like to say that
On 8/20/19 5:01 PM, Max Reitz wrote:
> On 19.08.19 09:53, Thomas Huth wrote:
>> It is possible to enable only a subset of the block drivers with the
>> "--block-drv-rw-whitelist" option of the "configure" script. All other
>> drivers are marked a
s->buf_align = (align != 1) ? align :
> bs->bl.request_alignment;
> break;
> }
>
Reviewed-by: Thomas Huth
On 03/09/2019 14.55, Max Reitz wrote:
> On 23.08.19 15:35, Thomas Huth wrote:
>> It is possible to enable only a subset of the block drivers with the
>> "--block-drv-rw-whitelist" option of the "configure" script. All other
>> drivers are marked a
mu-kvm" in RHEL), so
providing more flexibility here would also be good. Thus let's define
some variables for the names of the QEMU command and use those in the
documentation instead: @value{qemu_system} for generic examples, and
@value{qemu_system_x86} for examples that only work with the x
On 28/08/2019 21.18, John Snow wrote:
>
>
> On 8/28/19 5:34 AM, Thomas Huth wrote:
>> In our documentation, we use a mix of "$QEMU", "qemu-system-i386" and
>> "qemu-system-x86_64" when we give examples to the users how to run
>>
On 8/23/19 12:34 AM, Paolo Bonzini wrote:
> On 17/08/19 10:54, Thomas Huth wrote:
>> People often forget to run the iotests before submitting patches or pull
>> requests - this is likely due to the fact that we do not run the tests
>> during our mandatory "make check"
h --enable-sanitizers.
Signed-off-by: Thomas Huth
---
tests/check-block.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block.sh
index c8b6cec3f6..679aedec50 100755
--- a/tests/check-block.sh
+++ b/tests/check-block.sh
@@ -21,6 +21,11 @@ if grep -q "
On 8/23/19 9:12 AM, Thomas Huth wrote:
> On 8/23/19 12:34 AM, Paolo Bonzini wrote:
>> On 17/08/19 10:54, Thomas Huth wrote:
>>> People often forget to run the iotests before submitting patches or pull
>>> requests - this is likely due to the fact that we do not r
On 8/23/19 11:04 AM, Peter Maydell wrote:
> On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote:
>>
>> The sanitizers (especially the address sanitizer from Clang) are
>> sometimes printing out warnings or false positives - this spoils
>> the output of the iotests, causin
On 8/23/19 11:53 AM, Peter Maydell wrote:
> On Fri, 23 Aug 2019 at 10:35, Thomas Huth wrote:
>>
>> On 8/23/19 11:04 AM, Peter Maydell wrote:
>>> On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote:
>>>>
>>>> The sanitizers (especially the address sanit
qcow2" and "file"
drivers are always available - otherwise it does not make sense to
run "make check-block" at all (which only tests with qcow2 by default).
Signed-off-by: Thomas Huth
---
v2:
- Update the check in _require_drivers() according to Max' suggestion
- Remove su
nce the output might be mixed with the other tests. Thus change the
word "tests" here to "iotests" instead to avoid confusion.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/check | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotest
On 11/09/2019 08.58, Kevin Wolf wrote:
> Am 10.09.2019 um 21:07 hat Eric Blake geschrieben:
>> On 9/10/19 1:58 PM, Thomas Huth wrote:
>>> Our "tests" directory is very overcrowded - we store the qtests,
>>> unit test and other files there. That makes it
On 10/09/2019 12.53, Max Reitz wrote:
> On 06.09.19 13:35, Thomas Huth wrote:
>> The check script is already printing out which iotest is currently
>> running, so printing out the name of the check-block.sh shell script
>> looks superfluous here.
>>
>> Signed-off-
On 11/09/2019 10.54, Kevin Wolf wrote:
> Am 11.09.2019 um 10:01 hat Thomas Huth geschrieben:
>> On 11/09/2019 08.58, Kevin Wolf wrote:
>>> Am 10.09.2019 um 21:07 hat Eric Blake geschrieben:
>>>> On 9/10/19 1:58 PM, Thomas Huth wrote:
>>>>> Our &qu
The check script is already printing out which iotest is currently
running, so printing out the name of the check-block.sh shell script
looks superfluous here.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
t;$source_iotests/$seq")" == "#!/usr/bin/env
> python" ]; then
> -run_command="$PYTHON $seq"
> +if $python_usable; then
> +run_command="$PYTHON $seq"
> +else
> + run_command="false"
> +echo "Unsupported Python version" > $seq.notrun
> +fi
> else
> run_command="./$seq"
> fi
>
Reviewed-by: Thomas Huth
On 18/09/2019 00.29, John Snow wrote:
>
>
> On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote:
[...]
>> Finally do we support something except linux for iotests?
>> for bash tests _supported_os also used only with "Linux" in 87 tests..
The iotests in the "auto" group are supposed to work
On 30/07/2019 14.52, Thomas Huth wrote:
> On 29/07/2019 14.46, Andrey Shinkevich wrote:
>> This patch is to reduce the number of Valgrind report messages about
>> using uninitialized memory with the null-co driver. It helps to filter
>> real memory issues and is the same work
On 29/07/2019 14.46, Andrey Shinkevich wrote:
> This patch is to reduce the number of Valgrind report messages about
> using uninitialized memory with the null-co driver. It helps to filter
> real memory issues and is the same work done for the iotests with the
> commit ID a6862418fec4072.
>
>
the built-in double parentheses for the for-loops
instead.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/007| 2 +-
tests/qemu-iotests/011| 2 +-
tests/qemu-iotests/032| 2 +-
tests/qemu-iotests/035| 2 +-
tests/qemu-iotests/037| 2
On 16/07/2019 17.41, Max Reitz wrote:
> On 16.07.19 14:28, Thomas Huth wrote:
>> Since most iotests are now run during "make check" already, we do not
>> need to test them explicitly from the gitlab-ci.yml script anymore.
>> And while we're at it, add some of the ne
On 16/07/2019 18.12, Max Reitz wrote:
> On 16.07.19 18:09, Eric Blake wrote:
>> On 7/16/19 10:58 AM, Max Reitz wrote:
[...]
Is there any way to create our sockets somewhere under /tmp instead of
inside tests/qemu-iotests, so that we have a shorter filename for
sockets no matter how
In case somebody is interested, two of the "auto" iotests are failing
on NetBSD due to non-matching output:
TESTiotest-qcow2: 069 [fail]
--- /var/tmp/qemu-test.1BMupF/tests/qemu-iotests/069.out2019-07-24
09:19:22.0 +
+++
On 16/07/2019 17.37, Max Reitz wrote:
> On 16.07.19 14:28, Thomas Huth wrote:
>> People often forget to run the iotests before submitting patches or pull
>> requests - this is likely due to the fact that we do not run the tests
>> during our mandatory "make check"
FWIW, I've got a new iotest failure with current master branch:
$ ./check -qed 141
QEMU --
"/tmp/qemu/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64"
-nodefaults -machine accel=qtest
QEMU_IMG -- "/tmp/qemu/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
ove spaces
at the end of lines automatically.
Thus let's fix the regular expressions so that it is also possible to
have lines with one test number only in the group file.
Suggested-by: Max Reitz
Reviewed-by: Alex Bennée
Reviewed-by: Max Reitz
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/check |
Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 246 instead.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 13 -
1 fi
Remove some more tests from the "auto" group that either have issues
in certain environments (like macOS or FreeBSD, or on certain file systems
like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
taking too much time.
Reviewed-by: Max Reitz
Signed-off-by: T
pport migration)
v2:
- Added new patch to allow tests without groups, removed the "o_direct"
group again.
- Removed some more tests from the "auto" group, like 197 and 215 which
were sometimes causing the CI pipelines to fail on gitlab
- Added a patch to remove the "
script since we do not need that anymore
(and having two shell wrapper scripts around the block tests seems rather
confusing than helpful).
Signed-off-by: Thomas Huth
[AJB: -makecheck to check-block.sh, move check-block to start and gate it]
Signed-off-by: Alex Bennée
---
tests/Makefile.include
On 24/07/2019 18.29, Paolo Bonzini wrote:
> On 24/07/19 11:34, Thomas Huth wrote:
>> In case somebody is interested, two of the "auto" iotests are failing
>> on NetBSD due to non-matching output:
>>
>> TESTiotest-qcow2: 069 [fail]
>> --- /var/tmp/
Not sure if it has been reported before, but test 059 currently fails:
059 fail [14:55:21] [14:55:26]output
mismatch (see 059.out.bad)
--- /home/thuth/devel/qemu/tests/qemu-iotests/059.out 2019-07-19
10:19:18.0 +0200
+++
t-injector.py
> @@ -48,10 +48,9 @@ import sys
> import socket
> import struct
> import collections
> -if sys.version_info.major >= 3:
> -import configparser
> -else:
> -import ConfigParser as configparser
> +import configparser
> +
> +assert sys.version_info >= (3,6)
>
> FAKE_DISK_SIZE = 8 * 1024 * 1024 * 1024 # 8 GB
>
Reviewed-by: Thomas Huth
if $python_usable; then
> +run_command="$PYTHON $seq"
> +else
> + run_command="false"
> +echo "Unsupported Python version" > $seq.notrun
> +fi
> else
> run_command="./$seq"
> fi
>
Reviewed-by: Thomas Huth
On 01/10/2019 20.44, Max Reitz wrote:
[...]
> As I have said, the conceptual problem is that the iotests now run as
> part of make check. As such, allowing auto tests to run on non-Linux
> platforms may introduce build failures that I cannot do anything about.
Well, simply run "make
On 02/10/2019 13.57, Max Reitz wrote:
> On 02.10.19 06:46, Thomas Huth wrote:
>> [...]
>> Max, I can understand that you are a little bit annoyed that this "make
>> check with iotests" caused some extra hurdles for you. But honestly,
>> removing that agai
On 02/10/2019 15.36, Max Reitz wrote:
[...]
> Or can we have some middle ground? Something that runs on some CI
> systems (and notifies me and others) but won’t result in pull requests
> being rejected or cause make check failures?
Yes, I think that might be an option... Since many developers
On 02/10/2019 17.03, Daniel P. Berrangé wrote:
> On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote:
>> Running the iotests during "make check" is causing more headaches than
>> benefits for the block layer maintainers, so let's disable the iotests
>
Running the iotests during "make check" is causing more headaches than
benefits for the block layer maintainers, so let's disable the iotests
during "make check" again.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 2 +-
tests/qemu-iotests/group | 2 +-
2 files c
On 02/10/2019 19.32, Alex Bennée wrote:
>
> Daniel P. Berrangé writes:
>
>> On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote:
>>> Running the iotests during "make check" is causing more headaches than
>>> benefits for the block laye
On 02/10/2019 18.44, Kevin Wolf wrote:
> Not sure where in this thread to reply, but since my name is mentioned
> in this mail, it might at least be not the worst one.
>
> Am 02.10.2019 um 13:57 hat Max Reitz geschrieben:
>> On 02.10.19 06:46, Thomas Huth wrote:
>>> On
On 30/10/2019 12.21, Max Reitz wrote:
> On 22.10.19 09:21, Thomas Huth wrote:
>> The next patch is going to add some python-based tests to the "auto"
>> group, and these tests require virtio-blk to work properly. Running
>> iotests without virtio-blk likely does
On 27/11/2019 09.50, Thomas Huth wrote:
> On 25/11/2019 11.28, Alex Bennée wrote:
>>
>> Alex Bennée writes:
>>
>>> Thomas Huth writes:
>>>
>>>> Travis recently added build hosts for arm64, ppc64le and s390x, so
>>>> this is a welcome
e crashing on bionic on these hosts.
- Dropped "libcap-dev" from the package list since it will be replaced
by libcapng-dev soon.
Alex Bennée (1):
configure: allow disable of cross compilation containers
Thomas Huth (6):
iotests: Provide a function for checking the creation of huge
Reviewed-by: Alex Bennée
Signed-off-by: Thomas Huth
---
tests/hd-geo-test.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 7e86c5416c..a249800544 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -34,8 +34,13
/ fixed.
Signed-off-by: Thomas Huth
---
.travis.yml | 86 +
1 file changed, 86 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index 445b0646c1..0e6458b0af 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -354,6 +354,92 @@ matrix:
- TEST
and skip the test if that's not the case.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/060 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060
index b91d8321bb..d96f17a484 100755
--- a/tests/qemu-iotests/060
+++ b/tests/qemu-iotests/060
On 04/12/2019 14.28, Kevin Wolf wrote:
> Am 04.12.2019 um 09:17 hat Gerd Hoffmann geschrieben:
>> Hi,
>>
| ...
+- qemu-edid
>>>
>>> Has its own MAINTAINERS section, together with hw/display/edit* and
>>> include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good
checks in the iotests 005 and 220 with this function.
Reviewed-by: Alex Bennée
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/005 | 5 +
tests/qemu-iotests/220 | 6 ++
tests/qemu-iotests/common.rc | 10 ++
3 files changed, 13 insertions(+), 8 deletions(-)
diff --git
first whether we can really create such files before
executing the test.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/079 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/079 b/tests/qemu-iotests/079
index 81f0c21f53..78536d3bbf 100755
--- a/tests/qemu-iotests/079
From: Alex Bennée
Our docker infrastructure isn't quite as multiarch as we would wish so
let's allow the user to disable it if they want. This will allow us to
use still run check-tcg on non-x86 CI setups.
Signed-off-by: Alex Bennée
Reviewed-by: Stefan Weil
Signed-off-by: Thomas Huth
test-util-filemonitor fails in restricted non-x86 Travis containers
since they apparently blacklisted some required system calls there.
Let's simply skip the test if we detect such an environment.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
Signed-off-by: Thomas Huth
virtio-scsi device was introduced for
> +full SCSI support. Use virtio-scsi instead when SCSI passthrough is
> required.
> +
> +Note this also applies to ``-device virtio-blk-pci,scsi=on|off'', which is an
> +alias.
... and "-device virtio-blk-ccw,scsi=on|off". With that added:
Reviewed-by: Thomas Huth
On 11/12/2019 15.24, Paolo Bonzini wrote:
> From: Marc-André Lureau
>
> The block tests, as well as ahci-test needs qemu-img. Do not run
> them if it wasn't built.
>
> Signed-off-by: Marc-André Lureau
> Signed-off-by: Paolo Bonzini
> ---
> tests/Makefile.include | 4
> 1 file changed,
On 04/12/2019 16.46, Thomas Huth wrote:
> Test 079 fails in the arm64, s390x and ppc64le LXD containers on Travis
For the record: It's working on s390x as noticed by Cleber. It's only
failing on arm64 and ppc64le. After fixing the problem with 060 which
fails on all three architectures, I
On 18/10/2019 10.42, Max Reitz wrote:
> On 18.10.19 08:20, Thomas Huth wrote:
>> On 17/10/2019 18.41, Peter Maydell wrote:
>>> On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote:
>>>>
>>>> On 27.09.19 18:39, Peter Maydell wrote:
>>>>> Hi; I jus
On 17/10/2019 18.41, Peter Maydell wrote:
> On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote:
>>
>> On 27.09.19 18:39, Peter Maydell wrote:
>>> Hi; I just saw this iotest failure (on an s390x box, as it happens):
>>>
>>> TESTiotest-qcow2: 130 [fail]
>>> QEMU --
>>>
roup so
that it does not gate the pull requests.
Reviewed-by: John Snow
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/group | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index 2dd671b82e..9f99f8623f 100644
--- a/tests/qemu
every test (which does not sound very appealing), let's rather add
a check for this at the top level in the check-block.sh script instead
(so that it is possible to run "make check" without the "check-block"
part for qemu-system-tricore for example).
Reviewed-by: Max Reitz
Signed-o
When running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd
target, it fails with an "Timeout waiting for return on handle 0" error.
Let's mark it as supported only on systems where the test is working
fine (i.e. Linux, FreeBSD and NetBSD).
Signed-off-by: Thomas Huth
---
TIO 1.0 support.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> tests/virtio-blk-test.c | 33 -
> 1 file changed, 20 insertions(+), 13 deletions(-)
Reviewed-by: Thomas Huth
'grep -q' instead of 'grep' for grep'ing silently
- Added the patch to disable 130 from the "auto" group
John Snow (1):
iotests: remove 'linux' from default supported platforms
Thomas Huth (5):
iotests: Test 041 only works on certain systems
iotests: Test 183 does not work on macOS
g on the version.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> tests/libqos/virtio-mmio.h | 1 +
> tests/libqos/virtio-mmio.c | 3 +++
> 2 files changed, 4 insertions(+)
Reviewed-by: Thomas Huth
2 ++--
> tests/libqos/virtio.c | 4 ++--
> tests/virtio-blk-test.c| 8
> 6 files changed, 43 insertions(+), 27 deletions(-)
Reviewed-by: Thomas Huth
On 19/10/2019 08.38, Stefan Hajnoczi wrote:
> According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device
> Initialization", configuration space and virtqueues cannot be accessed
> before features have been negotiated. Enforce this requirement.
>
> Signed-off-by: Stefan Hajnoczi
> ---
>
On 19/10/2019 08.38, Stefan Hajnoczi wrote:
> VIRTIO Device Initialization requires feature negotiation. The libqos
> virtio-9p driver lacks feature negotiation and is therefore
> non-compliant.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> tests/libqos/virtio-9p.c | 6 ++
> 1 file changed, 6
lloc, 0);
> -
> -test_basic(dev, t_alloc, vq);
> +vq = test_basic(dev, t_alloc);
>
> qmp_discard_response("{ 'execute': 'block_resize', "
> " 'arguments': { 'device': 'drive0', "
>
Reviewed-by: Thomas Huth
-
> tests/libqos/virtio-pci.h | 2 ++
> tests/libqos/virtio-pci.c | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Thomas Huth
On 19/10/2019 08.37, Stefan Hajnoczi wrote:
> VIRTIO Device Initialization requires feature negotiation. Currently
> virtio-scsi-test.c is non-compliant.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> tests/virtio-scsi-test.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git
On 19/10/2019 08.38, Stefan Hajnoczi wrote:
> Device initialization has an extra step in VIRTIO 1.0. The FEATURES_OK
> status bit is set to indicate that feature negotiation has completed.
> The driver then reads the status register again to check that the device
> agrees with the final features.
;used, 0);
> +qvirtio_writew(vq->vdev, qts, vq->used, 0);
> /* vq->used->avail_event */
> -qtest_writew(qts, vq->used + 2 + sizeof(struct vring_used_elem) *
> vq->size,
> - 0);
> +qvirtio_writew(vq->vdev, qts, vq->used + 2 +
> +sizeof(struct vring_used_elem) * vq->size, 0);
Fix indentation in the above line?
Apart from that, patch looks fine to me.
Reviewed-by: Thomas Huth
On 21/10/2019 15.09, no-re...@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20191021105350.1710-1-th...@redhat.com/
>
>
>
> Hi,
>
> This series failed the docker-quick@centos7 build test. Please find the
> testing commands and
> their output below. If you have Docker installed,
On 18/10/2019 18.51, Bruce Rogers wrote:
> On Fri, 2019-10-18 at 18:10 +0200, Thomas Huth wrote:
>> Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared
>> 'write' lock - Is another process using the image
>> [TEST_DIR/t.IMGFMT]?"
>> err
ent qpci_find_capability()
> ---
> tests/libqos/pci.h | 2 +-
> tests/libqos/pci.c | 30 --
> 2 files changed, 25 insertions(+), 7 deletions(-)
Reviewed-by: Thomas Huth
On 18/10/2019 18.19, Max Reitz wrote:
> On 11.10.19 16:50, Thomas Huth wrote:
>> 041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as
>> only supported on these systems.
>>
>> Signed-off-by: Thomas Huth
>> ---
>> tests/qemu-iotests/041 | 3 ++-
401 - 500 of 1260 matches
Mail list logo
