On 07/01/2020 13.54, Daniel P. Berrangé wrote:
> On Tue, Jan 07, 2020 at 01:23:18PM +0100, Paolo Bonzini wrote:
>> On 07/01/20 13:18, Thomas Huth wrote:
>>> I don't think we need a separate priority parameter here. But IMHO it's
>>> really rather common practice to pri
On 08/01/2020 11.39, Alex Bennée wrote:
>
> Thomas Huth writes:
>
>> On 07/01/2020 13.54, Daniel P. Berrangé wrote:
>>> On Tue, Jan 07, 2020 at 01:23:18PM +0100, Paolo Bonzini wrote:
>>>> On 07/01/20 13:18, Thomas Huth wrote:
>>>>> I don
On 13/05/2020 22.43, John Snow wrote:
>
>
> On 5/7/20 10:05 AM, Philippe Mathieu-Daudé wrote:
>> +Hervé
>>
>> On 5/7/20 3:16 PM, Gerd Hoffmann wrote:
>>> Signed-off-by: Gerd Hoffmann
>>> Reviewed-by: Igor Mammedov
>>> ---
>>> hw/block/fdc.c | 83
On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
> Rename bitmaps migration tests and move them to tests subdirectory to
> demonstrate new human-friendly test naming.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}
CC: NFS maintainer + qemu-block
On 03/09/2020 10.31, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo
> ---
> block/nfs.c | 26 +-
> 1 file changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/block/nfs.c b/block/nfs.c
> index 61a249a9fc..34b2cd5708 100644
>
t; int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive);
> bool qemu_has_ofd_lock(void);
> +#endif
>
> #if defined(__HAIKU__) && defined(__i386__)
> #define FMT_pid "%ld"
>
Reviewed-by: Thomas Huth
On 05/09/2020 08.23, Yonggang Luo wrote:
> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41.
>
> Signed-off-by: Yonggang Luo
> ---
> configure | 16 +---
> 1 file changed, 1 insertion(+), 15 deletions(-)
Please be a little bit more descriptive in the patch description:
On 05/09/2020 08.23, Yonggang Luo wrote:
> The error are:
> +@end table
> +
> +@end deftypefn
> +
> make: *** [Makefile.mtest:63: check-qapi-schema] Error 1
>
> Signed-off-by: Yonggang Luo
> ---
> tests/qapi-schema/meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff
The test_stream_parallel test still occasionally fails in the CI.
Thus let's disable it during "make check" for now so that it does
not cause trouble during merge tests. We can enable it again once
the problem has been resolved.
Signed-off-by: Thomas Huth
---
See e.g. these URLs for t
On 04/09/2020 00.53, 罗勇刚(Yonggang Luo) wrote:
>
>
> On Thu, Sep 3, 2020 at 10:33 PM Thomas Huth <mailto:th...@redhat.com>> wrote:
>
> On 03/09/2020 11.18, 罗勇刚(Yonggang Luo) wrote:
> [...]
> > TEST check-unit: tests/test-replication.exe
>
Test 030 is still occasionally failing in the CI ... so for the
time being, let's disable it in the "auto" group. We can add it
back once it got more stable.
Signed-off-by: Thomas Huth
---
I just saw the problem here:
https://cirrus-ci.com/task/5449330930745344?command=main#L6482
**name)
> ssize_t ret;
> int fd = mkstemp(cdrom_path);
>
> +g_assert(fd != -1);
Should be good enough for a qtest.
Reviewed-by: Thomas Huth
On 02/09/2020 10.37, Paolo Bonzini wrote:
> On 02/09/20 10:19, Daniel P. Berrangé wrote:
>> On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote:
>>> check-block has its own test harness, unlike every other test. If
>>> we capture its output, as is in general nicer to do without V=1,
>>>
.
>
> Fixes build with --disable-qcow1.
>
> Reported-by: Thomas Huth
> Cc: qemu-block@nongnu.org
> Signed-off-by: Paolo Bonzini
> ---
> block/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/meson.build b/block/meso
plit())
> endif
> -gio = not_found
> -if 'CONFIG_GIO' in config_host
> - gio = declare_dependency(compile_args: config_host['GIO_CFLAGS'].split(),
> - link_args: config_host['GIO_LIBS'].split())
> -endif
> vnc = not_found
> png = not_found
> jpeg = not_found
>
Reviewed-by: Thomas Huth
=]
if (l2_entry & QCOW_OFLAG_COPIED) {
^
../../devel/qemu/block/qcow2-cluster.c:1323:5: note: here
case QCOW2_CLUSTER_UNALLOCATED:
^~~~
It's quite obvious that the fallthrough is intended here, so let's add
a comment to silence the compiler warning.
Signed-off-by: Thomas
On 09/09/2020 20.42, Yonggang Luo wrote:
> These tests are blocking test-char to be finished.
> Disable them by using variable is_win32, so we doesn't
> need macro to open it. and easy recover those function
> latter.
>
> Signed-off-by: Yonggang Luo
> ---
> tests/test-char.c | 26
On 08/09/2020 10.43, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
>
> On 9/8/20 9:00 AM, Thomas Huth wrote:
>> When compiling with -Werror=implicit-fallthrough, the compiler currently
>> complains:
>
> Do you know what is missing to add this in configure::warn_flags?
The test_stream_parallel test still occasionally fails in the CI.
Thus let's disable it during "make check" for now so that it does
not cause trouble during merge tests. We can enable it again once
the problem has been resolved.
Signed-off-by: Thomas Huth
---
v2: Use @unitt
On 10/09/2020 00.09, Eric Blake wrote:
> On 9/9/20 4:55 PM, Peter Maydell wrote:
>
>>
>> This fails 'make check' on NetBSD and OpenBSD:
>>
>> ./check: line 47: realpath: command not found
>> ./check: line 60: /common.env: No such file or directory
>> check: failed to source common.env (make sure
-by: Thomas Huth
---
tests/check-block.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block.sh
index 8e29c868e5..bfe1630c1e 100755
--- a/tests/check-block.sh
+++ b/tests/check-block.sh
@@ -46,6 +46,11 @@ if ! command -v bash >/dev/null 2
On 13/09/2020 16.08, Paolo Bonzini wrote:
> On 13/09/20 00:44, Yonggang Luo wrote:
>> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41.
>>
>> The --ninja option doesn't need anymore because of upgrade meson to 0.55.2
>> At that version we can use ninjatool
>
> We might actually get
On 13/09/2020 00.44, Yonggang Luo wrote:
> The currently random version capstone have the following compiling issue:
> CC /c/work/xemu/qemu/build/slirp/src/arp_table.o
> make[1]: *** No rule to make target
> “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop.
>
> Subproject commit
people agree that we should
revert the patch now, that's ok for me now, too.
Tested-by: Thomas Huth
On 14/09/2020 11.19, Max Reitz wrote:
> On 12.09.20 14:14, Thomas Huth wrote:
>> macOS is shipped with a very old version of the bash (3.2), which
>> is currently not suitable for running the iotests anymore. Add
>> a check to skip the iotests in this case - if someone
On 13/09/2020 00.44, Yonggang Luo wrote:
> Install msys2 in a proper way refer to
> https://github.com/cirruslabs/cirrus-ci-docs/issues/699
> The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be
> updated.
I don't think that a request to update the wiki should be part of the
On 14/09/2020 12.35, Stefan Hajnoczi wrote:
> On Mon, Sep 07, 2020 at 04:04:21PM +0100, Stefan Hajnoczi wrote:
>> I want to kick of a series of posts about storage. The first post covers
>> high-level concepts, features, and utilities in QEMU. Later posts will
>> discuss configuration details,
On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote:
>
>
> On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth <mailto:th...@redhat.com>> wrote:
>>
>> On 13/09/2020 00.44, Yonggang Luo wrote:
>> > Fixes following tests on msys2/mingw
>> > 'test-c
On 13/09/2020 00.44, Yonggang Luo wrote:
> Fixes following tests on msys2/mingw
> 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c',
> 'pkix_asn1_tab.c',
>tasn1, crypto],
> 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c',
>
On 14/09/2020 10.50, Philippe Mathieu-Daudé wrote:
> On 9/14/20 9:27 AM, Thomas Huth wrote:
>> On 13/09/2020 00.44, Yonggang Luo wrote:
>>> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba
>>> ("cirrus.yml: Split FreeBSD job into two parts").
On 14/09/2020 11.36, 罗勇刚(Yonggang Luo) wrote:
>
>
> On Sat, Sep 12, 2020 at 8:16 PM Thomas Huth <mailto:th...@redhat.com>> wrote:
>>
>> macOS is shipped with a very old version of the bash (3.2), which
>> is currently not suitable for running the iot
On 14/09/2020 13.13, Max Reitz wrote:
> On 14.09.20 12:50, Thomas Huth wrote:
>> On 14/09/2020 11.19, Max Reitz wrote:
>>> On 12.09.20 14:14, Thomas Huth wrote:
>>>> macOS is shipped with a very old version of the bash (3.2), which
>>>> is currently no
de0f
>("iotests: Allow running from different directory")
> Reported-by: Claudio Fontana
> Reported-by: Thomas Huth
> Signed-off-by: Max Reitz
> ---
> Hi Thomas,
>
> I thought this would be quicker than writing a witty response on whether
> you or me s
bsolute path.
>
> Instead of using either, just use "cd; pwd" like is done for
> $source_iotests.
>
> Fixes: b1cbc33a3971b6bb005d5ac3569feae35a71de0f
>("iotests: Allow running from different directory")
> Suggested-by: Peter Maydell
> Reported-b
On 14/09/2020 17.03, Eric Blake wrote:
> On 9/12/20 7:14 AM, Thomas Huth wrote:
>> macOS is shipped with a very old version of the bash (3.2), which
>> is currently not suitable for running the iotests anymore. Add
>> a check to skip the iotests in this case - if someone
On 04/09/2020 10.25, Kevin Wolf wrote:
> Am 04.09.2020 um 07:57 hat Thomas Huth geschrieben:
>> Test 030 is still occasionally failing in the CI ... so for the
>> time being, let's disable it in the "auto" group. We can add it
>> back once it got more stable.
&
On 04/09/2020 12.38, Max Reitz wrote:
> On 04.09.20 12:14, Thomas Huth wrote:
>> On 04/09/2020 10.25, Kevin Wolf wrote:
>>> Am 04.09.2020 um 07:57 hat Thomas Huth geschrieben:
>>>> Test 030 is still occasionally failing in the CI ... so for the
>>>> time b
On 08/09/2020 20.56, Eric Blake wrote:
> On 9/8/20 1:49 PM, Yonggang Luo wrote:
>> The following changes since commit
>> 6779038537360e957dbded830f76b08ef5070161:
>>
>> Merge remote-tracking branch
>> 'remotes/armbru/tags/pull-qapi-2020-09-08' int=
>> o staging (2020-09-08 17:23:31 +0100)
>>
>>
On 08/09/2020 21.48, Yonggang Luo wrote:
> These tests are blocking test-char to be finished.
>
> Signed-off-by: Yonggang Luo
> ---
> tests/test-char.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/test-char.c b/tests/test-char.c
> index d35cc839bc..80e5bac61a 100644
> ---
On 08/09/2020 21.48, Yonggang Luo wrote:
> freebsd 1 hour limit not hit anymore
Why is this faster again? How long did the build take for you? If it's
still close to 1h, I think we should keep the two jobs, to avoid that it
is occasionally failing when the builder machines are a little bit
On 12/09/2020 20.38, Peter Maydell wrote:
> On Sat, 12 Sep 2020 at 13:27, Thomas Huth wrote:
>> Peter, why did this slip through your merge tests, do you still skip the
>> iotests there?
>
> I forget what the reason for them being skipped is, maybe
> it's becau
On 10/09/2020 12.37, Yonggang Luo wrote:
> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba
> ("cirrus.yml: Split FreeBSD job into two parts").
>
> freebsd 1 hour limit not hit anymore
>
> I think we going to a wrong direction, I think there is some tests a stall
> the test runner,
On 13/09/2020 00.44, Yonggang Luo wrote:
> It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and
> disable partial test-char tests.
> And then fixes all unit tests failure on msys2/mingw
> This fixes the reviews suggested in the mailling list
> All cirrus CI are passed
Hi,
On 12/10/2020 15.47, Paolo Bonzini wrote:
> On 12/10/20 13:14, Thomas Huth wrote:
>>> +/**
>>> + * qtest_qmp_receive:
>>> + * @s: #QTestState instance to operate on.
>>> + *
>>> + * Reads a QMP message from QEMU and returns the response.
>>
On 06/10/2020 14.38, Maxim Levitsky wrote:
> The new qtest_qmp_receive buffers all the received qmp events, allowing
> qtest_qmp_eventwait_ref to return them.
>
> This is intended to solve the race in regard to ordering of qmp events
> vs qmp responses, as soon as the callers start using the new
sts/qtest/pvpanic-test.c | 2 +-
> tests/qtest/qmp-test.c | 18 +-
> 7 files changed, 24 insertions(+), 24 deletions(-)
Acked-by: Thomas Huth
On 19/10/2020 03.39, Joelle van Dyne wrote:
> From: osy
That "From:" line looks wrong ... could you please fix the "Author" of your
patches / your git config?
> macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure
> will succeed with CONFIG_PREADV even when targeting a
genisoimage is needed for running the tests/qtest/cdrom-test qtest.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/centos8.docker | 1 +
tests/docker/dockerfiles/debian-amd64.docker | 1 +
tests/docker/dockerfiles/fedora.docker | 1 +
tests/docker/dockerfiles/ubuntu2004
On 24/08/2020 19.02, Daniel P. Berrangé wrote:
Disabling these parts are sufficient to get the qemu-nbd program
compiling in a Windows build.
Maybe add:
"This also enables compilation of qemu-nbd on macOS again (which got
disabled by accident during the conversion to the meson build system)"
Hi,
if I run "configure" with --disable-qcow1, I currently get a build error:
Linking target qemu-nbd
libblock.fa(block_qcow2-threads.c.o): In function `qcow2_zlib_compress':
/tmp/qemu-test/../../home/thuth/devel/qemu/block/qcow2-threads.c:101:
undefined reference to `deflateInit2_'
On 06/08/2020 15.27, Janosch Frank wrote:
> On 8/6/20 12:53 PM, Thomas Huth wrote:
>> Remove the "#ifndef E..." guards from the defines here - the header
>> guard S390_CCW_H at the top of the file should avoid double definition,
>> and if the error code is defi
On 22/09/2020 12.49, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> configure | 34 ++
> meson.build | 6 ++
> 2 files changed, 40 insertions(+)
>
> diff --git a/configure b/configure
> index ce27eafb0a..21c31e4694 100755
> --- a/configure
> +++
F: block/rbd.c
> Sheepdog
> M: Liu Yuan
> L: qemu-block@nongnu.org
> -L: sheep...@lists.wpkg.org
> S: Odd Fixes
> F: block/sheepdog.c
Reviewed-by: Thomas Huth
e configure default
> is changed to disable it, requiring users to pass --enable-sheepdog to
> build the driver.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> block/sheepdog.c | 15 +++
> configure | 5 +++--
> docs/system/deprecated.rst | 9 +
> 3 files changed, 27 insertions(+), 2 deletions(-)
Reviewed-by: Thomas Huth
.
Signed-off-by: Thomas Huth
---
v2:
- Bump the version in docs/conf.py, too
- Remove the now unnecessary check in tests/qemu-iotests/iotests.py
configure | 4 ++--
docs/conf.py | 4 ++--
tests/qemu-iotests/iotests.py | 2 --
3 files changed, 4 insertions(+), 6
On 23/09/2020 18.34, 罗勇刚(Yonggang Luo) wrote:
> Should we also warning it in meson.build, cause configure finally shoud
> be removed.
Sounds like a good idea for a separate patch (let's do one issue at a
time...).
Thomas
e it got more stable.
>>>
>>> Signed-off-by: Thomas Huth
>>
>> I would rather just disable this one test function as 030 is a pretty
>> important one that tends to catch bugs.
>>
>>> I just saw the problem here:
>>> https://cirrus-ci.c
On 22/09/2020 11.01, Daniel P. Berrangé wrote:
[...]
> Does someone have a compelling reason for QEMU to keep supporting
> this driver, other than the fact that it already exists ?
>
> If not, it looks like a candidate for deprecating in QEMU with a
> view to later removing it.
I think you gave
UPPERCASE);
>
> Signed-off-by: Eduardo Habkost
> ---
Acked-by: Thomas Huth
On 25/09/2020 17.11, Vladimir Sementsov-Ogievskiy wrote:
> 25.09.2020 12:11, Max Reitz wrote:
>> On 25.09.20 10:49, Vladimir Sementsov-Ogievskiy wrote:
>>> 25.09.2020 11:26, Max Reitz wrote:
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir
hould rather fix these tests in the long run - they
should really only enable the bits that they support...
> bits and we don't want packed virtqueues to
> be enabled.
>
> Later patches will enable VIRTIO_F_RING_PACKED so prepare libqos now.
>
> Cc: Thomas Huth
> Signed-off-by: Stef
On 15/09/2020 19.12, Yonggang Luo wrote:
[...]
> It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and
> disable partial test-char tests.
> And then fixes all unit tests failure on msys2/mingw
> This fixes the reviews suggested in the mailling list
> All cirrus CI are passed
till wants to run the iotests on macOS,
they can install a newer version from homebrew, for example.
Signed-off-by: Thomas Huth
---
v2: Use LANG=C and "-q"
tests/check-block.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block
On 19/10/2020 18.37, Maxim Levitsky wrote:
> The g_list_remove_link doesn't free the link element,
> opposed to what I thought.
> Switch to g_list_delete_link that does free it.
>
> Also refactor the code a bit.
> Thanks for Max Reitz for helping me with this.
>
> Signed-off-by: Maxim Levitsky
with
> - *atomic_load_acquire()
> + *When accessed outside big qemu lock, must be accessed with
> + *qatomic_load_acquire()
> * @reset: ResettableState for the device; handled by Resettable interface.
> *
> * This structure should not be accessed directly. We declare it here
>
Reviewed-by: Thomas Huth
On 27/10/2020 06.05, Eric Blake wrote:
> Anywhere we create a list of just one item or by prepending items
> (typically because order doesn't matter), we can use the now-public
> macro. But places where we must keep the list in order by appending
> remain open-coded.
>
> Signed-off-by: Eric
On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote:
> +Thomas
> On 7/16/20 10:56 PM, Havard Skinnemoen wrote:
>> On Wed, Jul 15, 2020 at 1:54 PM Havard Skinnemoen
>> wrote:
>>>
>>> On Wed, Jul 15, 2020 at 3:57 AM Philippe Mathieu-Daudé
>>> wrote:
On 7/15/20 11:00 AM, Markus Armbruster
test-image-locking.c uses the qemu_lock_fd_test() function which is
only available on Posix-like systems.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 5ff731be2b..430119db74
in this case, so we should do the same in the s390-ccw
bios, too.
Reviewed-by: Cornelia Huck
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw/bootmap.c | 34 +++---
pc-bios/s390-ccw/main.c| 2 +-
2 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/pc
enable_subchannel() is already done during is_dev_possibly_bootable()
(which is called from find_boot_device() -> find_subch()), so there
is no need to do this again in the main() function.
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw/main.c | 1 -
1 file changed, 1 deletion(-)
diff --
the bootable device (without "bootindex"). Now
that the s390-ccw bios is a little bit smarter here, we should test
this scenario, too, to avoid regressions.
Signed-off-by: Thomas Huth
---
tests/qtest/cdrom-test.c | 12
1 file changed, 12 insertions(+)
diff --git a/te
..." is clearly the preferred way of booting
on s390x, we still can make the life for the users at least a little
bit easier if we look at all available devices to find a bootable one.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1846975
Reviewed-by: Cornelia Huck
Signed-off-by: Thoma
In case the user did not specify a boot device, we want to continue
looking for other devices if there are no valid SCSI disks on a virtio-
scsi controller. As a first step, do not panic in this case and let
the control flow carry the error to the upper functions instead.
Signed-off-by: Thomas
Let's move this part of the code into a separate function to be able
to use it from multiple spots later.
Reviewed-by: Claudio Imbrenda
Reviewed-by: Cornelia Huck
Reviewed-by: Janosch Frank
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw/main.c | 20
1 file changed, 12
Move the code to a separate function to be able to re-use it from a
different spot later.
Reviewed-by: Claudio Imbrenda
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw/main.c | 99 -
1 file changed, 57 insertions(+), 42 deletions(-)
diff --git a/pc-bios
ch Frank
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw/Makefile | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
index 50bc880272..9abb0ea4c0 100644
--- a/pc-bios/s390-ccw/Makefile
+++ b/pc-bios/s390-ccw/Makefile
@@ -13,
it wants to.
Thomas
v2:
- Add patch to remove superfluous call to enable_subchannel()
- Add patch to test the new behavior in the tests/qtest/cdrom-test
- Added Reviewed-bys from v1
- Renamed check_sch_no() to is_dev_possibly_bootable()
- Reworked the return codes to use 0/-ENODEV instead o
of hunting weird behavior during runtime later.
Also define ENODEV - we will use this in a later patch.
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw/s390-ccw.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/pc-bios/s390-ccw/s390-ccw.h b/pc-bios/s390-ccw/s390-c
On 06/08/2020 13.23, Cornelia Huck wrote:
> On Thu, 6 Aug 2020 12:53:49 +0200
> Thomas Huth wrote:
>
>> Let's add two new tests:
>>
>> 1) Booting with "bootindex" is the architected default behavior on the
>> s390x target, so we should have at lea
error_setg(errp, "Image not in VMDK format");
> return -EINVAL;
> -break;
> }
> }
>
>
Reviewed-by: Thomas Huth
On 17/06/2020 09.11, Gerd Hoffmann wrote:
> DSDT change: isa device order changes in case MI1 (ipmi) is present.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Igor Mammedov
> ---
> hw/block/fdc.c | 83
> hw/i386/acpi-build.c| 83
Hi!
I just noticed that iotest 041 is failing with -qed:
$ ./check -qed 041
QEMU --
"tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults
-display none -accel qtest
QEMU_IMG -- "tests/qemu-iotests/../../qemu-img"
QEMU_IO --
elf.image_len // 2)
Great, now "check -qed 041" works fine for me again! Thanks!
Tested-by: Thomas Huth
gt; 2 files changed, 16 insertions(+), 4 deletions(-)
Tested with:
for i in raw bochs cloop parallels qcow qcow2 qed vdi vpc vhdx \
vmdk luks dmg ; do ./check -makecheck -$i 118 ; done
Works fine for me, so:
Tested-by: Thomas Huth
On 17/06/2020 13.31, Gerd Hoffmann wrote:
> On Wed, Jun 17, 2020 at 10:40:24AM +0200, Thomas Huth wrote:
>> On 17/06/2020 09.11, Gerd Hoffmann wrote:
>>> DSDT change: isa device order changes in case MI1 (ipmi) is present.
>>>
>>> Signed-off-by: Gerd Hoff
On 24/06/2020 09.27, Max Reitz wrote:
On 23.06.20 14:55, Peter Maydell wrote:
On Mon, 22 Jun 2020 at 16:11, Max Reitz wrote:
The following changes since commit bae31bfa48b9caecee25da3d5333901a126a06b4:
Merge remote-tracking branch
'remotes/kraxel/tags/audio-20200619-pull-request' into
On 16/06/2020 14.26, Peter Maydell wrote:
> On Mon, 15 Jun 2020 at 21:43, Markus Armbruster wrote:
>>
>> The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb:
>>
>> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
>> staging (2020-06-12 23:06:22
, but the problem should be fixed anyway with a proper check.
Buglink: https://bugs.launchpad.net/qemu/+bug/1882065
Signed-off-by: Thomas Huth
---
hw/scsi/megasas.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi
/qemu-project/qemu/-/jobs/597414772#L4375
>
> Reported-by: Thomas Huth
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/051.pc.out | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Thomas Huth
On 07/03/2020 10.48, Mark Cave-Ayland wrote:
> Hi all,
>
> After a recent rebase I've started seeing iotest 267 after running "make
> check" on
> qemu-system-sparc64. The diff output looks similar to this:
>
> --- /home/build/src/qemu/git/qemu/tests/qemu-iotests/267.out2020-01-22
>
On 22/05/2020 00.06, Vladimir Sementsov-Ogievskiy wrote:
> Test that dirty bitmap migration works when we deal with mirror.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Eric Blake
> ---
> tests/qemu-iotests/194 | 14 ++
> tests/qemu-iotests/194.out | 6 ++
On 03/06/2020 10.06, Vladimir Sementsov-Ogievskiy wrote:
> 03.06.2020 10:52, Thomas Huth wrote:
>> On 22/05/2020 00.06, Vladimir Sementsov-Ogievskiy wrote:
>>> Test that dirty bitmap migration works when we deal with mirror.
>>>
>>> Signed-off-by: Vladim
ed dirty
> bitmaps here. So, Fixes: tag won't hurt.
>
> Fixes: ae00aa2398476824f0eca80461da215e7cdc1c3b
> Reported-by: Thomas Huth
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/194 | 10 ++
> tests/qemu-iotests/194.out | 5 +
> 2 files changed, 15 ins
On 04/06/2020 09.51, Vladimir Sementsov-Ogievskiy wrote:
> 04.06.2020 10:21, Thomas Huth wrote:
>> On 03/06/2020 10.06, Vladimir Sementsov-Ogievskiy wrote:
>>> 03.06.2020 10:52, Thomas Huth wrote:
>>>> On 22/05/2020 00.06, Vladimir Sementsov-Ogievskiy wrote:
>>
ow2 and IMGPROTO=file, as done in
> other places in this test.
>
> Fixes: 1855536256eb0a5708b04b85f744de69559ea323
> Reported-by: Thomas Huth
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/197 | 8 +---
> tests/qemu-iotests/197.out | 2 +-
> 2 files changed, 6 in
On 28/07/2020 18.12, Peter Maydell wrote:
> On Tue, 28 Jul 2020 at 11:19, Peter Maydell wrote:
>>
>> On Mon, 27 Jul 2020 at 15:38, Max Reitz wrote:
>>>
>>> Block patches for 5.1:
>>> - Coverity fix
>>> - iotests fix for rx and avr
On 27/07/2020 22.07, Vladimir Sementsov-Ogievskiy wrote:
> 27.07.2020 22:51, Eric Blake wrote:
>> A quick run of './check -qcow2 -g migration' shows that test 169 is
>> NOT quick, but meanwhile several other tests ARE quick. Let's adjust
>> the test designations accordingly.
>>
>> Signed-off-by:
the arm- and
tricore-softmmu targets.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/check | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index e0d8049012..0657f7286c 100755
--- a/tests/qemu-iotests/check
+++
used\n",
+ __func__, tag);
return;
}
Reviewed-by: Thomas Huth
59,6 +76,8 @@ int main(int argc, char **argv)
> test_lp1878263_megasas_zero_iov_cnt);
> qtest_add_func("fuzz/test_lp1878642_pci_bus_get_irq_level_assert",
> test_lp1878642_pci_bus_get_irq_level_assert);
> +qtest_add_func("fuzz/test_megasas_cdb_len_zero",
> + test_megasas_cdb_len_zero);
> }
>
> return g_test_run();
>
Acked-by: Thomas Huth
601 - 700 of 1258 matches
Mail list logo
