[Qemu-devel] (no subject)

2009-10-30 Thread Jason McMullan
>From cc0481503722124f085d785637aeea9ea51fab9b Mon Sep 17 00:00:00 2001 From: Jason S. McMullan Date: Wed, 28 Oct 2009 00:56:00 -0400 Subject: [PATCH] hw/sd: Support SDHC size cards Signed-off-by: Jason S. McMullan --- hw/sd.c | 153 ++---

[Qemu-devel] [PATCH] Unbreak tap compilation on OS X

2009-10-30 Thread Alexander Graf
Currently compiling the tap sources breaks on Mac OS X. This is because of: 1) tap-linux.h requiring Linux includes 2) typos 3) missing #includes This patch adds what's necessary to compile tap happily on Mac OS X. I haven't tested if using tap actually works, but I don't think that's a maj

Re: [Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Alexander Graf
On 30.10.2009, at 21:11, Anthony Liguori wrote: Jan Kiszka wrote: Anthony Liguori wrote: Jan Kiszka wrote: OK, thanks. Still one complaint: gPXE comes with an annoying boot delay even if you can boot from disk or have _explicitly_ specified this. I'm not familiar with it, but I bet ther

[Qemu-devel] Re: [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...]

2009-10-30 Thread Dustin Kirkland
On Thu, Oct 29, 2009 at 10:34 AM, Dustin Kirkland wrote: > whitelist host virtio networking features > > This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb, > fixing crashes when guests with 2.6.25 virtio drivers have saturated > virtio network connections. > > https://bugs.edge.

Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO

2009-10-30 Thread Alexander Graf
On 30.10.2009, at 17:59, Mark McLoughlin wrote: Hi, On Fri, 2009-10-30 at 11:04 +0100, juha.riihim...@nokia.com wrote: On Oct 22, 2009, at 19:43, ext Mark McLoughlin wrote: Hey, Over a year ago we added some code to qemu-kvm.git which takes advantage of the recent tun/tap IFF_VNET_HDR

Ubuntu Patches [was Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network]

2009-10-30 Thread Dustin Kirkland
On Thu, Oct 29, 2009 at 6:22 PM, Scott Tsai wrote: > What's the easiest way to see the patches to qemu that Canonical > carries for the different Ubuntu releases? > (I think http://patches.ubuntu.com/ only diffs against Debian for the > last stable Ubuntu release?) Correct. That site is sort of

[Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Anthony Liguori
Jan Kiszka wrote: It's tunable: Customize -> Console Options -> BANNER_TIMEOUT Ah, I missed that. Maybe we could wait until 0.13 and then introduce the FW cfg interface to gpxe? I've already talked to some of the gpxe devs about it and they seem pretty receptive. That would let us define

[Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Jan Kiszka
Anthony Liguori wrote: > Jan Kiszka wrote: >> Anthony Liguori wrote: >> >>> Jan Kiszka wrote: >>> OK, thanks. Still one complaint: gPXE comes with an annoying boot delay even if you can boot from disk or have _explicitly_ specified this. I'm not familiar with it, but I bet ther

[Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Anthony Liguori
Jan Kiszka wrote: Anthony Liguori wrote: Jan Kiszka wrote: OK, thanks. Still one complaint: gPXE comes with an annoying boot delay even if you can boot from disk or have _explicitly_ specified this. I'm not familiar with it, but I bet there is some magic config switch to disable this...

[Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Jan Kiszka
Anthony Liguori wrote: > Jan Kiszka wrote: >> OK, thanks. Still one complaint: gPXE comes with an annoying boot delay >> even if you can boot from disk or have _explicitly_ specified this. I'm >> not familiar with it, but I bet there is some magic config switch to >> disable this... >> > > Noth

[Qemu-devel] Re: PC machine types switched to SeaBIOS/gPXE

2009-10-30 Thread Anthony Liguori
Jan Kiszka wrote: Anthony Liguori wrote: Hi, I just wanted to let everyone know that I've switched the PC machine type to SeaBIOS and gPXE. SeaBIOS is a port of the Bochs BIOS to GCC, by Kevin O'Conner, along with quite a lot of clean up and new feature work. gPXE is the new development tr

[Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Anthony Liguori
Jan Kiszka wrote: OK, thanks. Still one complaint: gPXE comes with an annoying boot delay even if you can boot from disk or have _explicitly_ specified this. I'm not familiar with it, but I bet there is some magic config switch to disable this... Nothing seemed obvious to me. If anyone has

[Qemu-devel] Re: PC machine types switched to SeaBIOS/gPXE

2009-10-30 Thread Jan Kiszka
Anthony Liguori wrote: > Hi, > > I just wanted to let everyone know that I've switched the PC machine > type to SeaBIOS and gPXE. SeaBIOS is a port of the Bochs BIOS to GCC, > by Kevin O'Conner, along with quite a lot of clean up and new feature work. > > gPXE is the new development tree of ethe

[Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Jan Kiszka
Anthony Liguori wrote: > Jan Kiszka wrote: >> [ What happened to the scm commit list, btw?] >> > > I need to move it to qemu.org. > >> Hi Anthony, >> >> your patch 94ca5a9859 prevents booting PCs unless some boot order of >> less than 4 devices is explicitly specified. The reason is >> >> #def

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Anthony Liguori
Jamie Lokier wrote: Anthony Liguori wrote: Jamie Lokier wrote: Anthony Liguori wrote: Okay, let's get more clever then and do: #define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" By the way, since you've already invented a non-standard JSON extension, which is

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Paolo Bonzini
On 10/30/2009 07:09 PM, Jamie Lokier wrote: Anthony Liguori wrote: Jamie Lokier wrote: Anthony Liguori wrote: Okay, let's get more clever then and do: #define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" By the way, since you've already invented a non-standard JSON extension, which is the

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Jamie Lokier
Anthony Liguori wrote: > Jamie Lokier wrote: > >Anthony Liguori wrote: > > > >>Okay, let's get more clever then and do: > >> > >>#define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" > >> > > > >By the way, since you've already invented a non-standard JSON > >extension, which is the single quo

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Anthony Liguori
Paolo Bonzini wrote: On 10/30/2009 06:15 PM, Daniel P. Berrange wrote: If we're going to use JSON we should be 100% compliant with the JSON spec, not extend it. By adding custom QEMU extensions, we loose the ability for programming language to trivially talk to QEMU using a standard JSON parser,

Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()

2009-10-30 Thread Anthony Liguori
Mark McLoughlin wrote: On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: Okay, let's try re-enabling the drain-entire-queue behaviour, with a difference - before each subsequent packet, use qemu_can_send_packet() to check that we can send it. This is simil

[Qemu-devel] Re: Regression due to "Fall back to network boot..."

2009-10-30 Thread Anthony Liguori
Jan Kiszka wrote: [ What happened to the scm commit list, btw?] I need to move it to qemu.org. Hi Anthony, your patch 94ca5a9859 prevents booting PCs unless some boot order of less than 4 devices is explicitly specified. The reason is #define PC_MAX_BOOT_DEVICES 3 and the CMOS-based int

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Anthony Liguori
Jamie Lokier wrote: Anthony Liguori wrote: Okay, let's get more clever then and do: #define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" By the way, since you've already invented a non-standard JSON extension, which is the single quotes, why not go a step further and permit the quotes

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Paolo Bonzini
On 10/30/2009 06:15 PM, Daniel P. Berrange wrote: If we're going to use JSON we should be 100% compliant with the JSON spec, not extend it. By adding custom QEMU extensions, we loose the ability for programming language to trivially talk to QEMU using a standard JSON parser, and instead everyone

[Qemu-devel] Regression due to "Fall back to network boot..."

2009-10-30 Thread Jan Kiszka
[ What happened to the scm commit list, btw?] Hi Anthony, your patch 94ca5a9859 prevents booting PCs unless some boot order of less than 4 devices is explicitly specified. The reason is #define PC_MAX_BOOT_DEVICES 3 and the CMOS-based interface to the BIOS. Maybe the latter can be enhanced so t

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2009 at 04:28:49PM +, Jamie Lokier wrote: > Anthony Liguori wrote: > > Okay, let's get more clever then and do: > > > > #define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" > > By the way, since you've already invented a non-standard JSON > extension, which is the single quote

Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO

2009-10-30 Thread Mark McLoughlin
Hi, On Fri, 2009-10-30 at 11:04 +0100, juha.riihim...@nokia.com wrote: > On Oct 22, 2009, at 19:43, ext Mark McLoughlin wrote: > > > Hey, > >Over a year ago we added some code to qemu-kvm.git which takes > > advantage of the recent tun/tap IFF_VNET_HDR feature in order to allow > > virtio

[Qemu-devel] QJSON status?

2009-10-30 Thread Paolo Bonzini
I'm a bit lost on the QJSON patches that were posted and what's missing yet... Anthony, can you place them in your queue or in a separate branch? Thanks! Paolo

Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()

2009-10-30 Thread Mark McLoughlin
On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > Okay, let's try re-enabling the drain-entire-queue behaviour, with a > > difference - before each subsequent packet, use qemu_can_send_packet() > > to check that we can send it. This is similar to how we check be

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Paolo Bonzini
On 10/30/2009 05:28 PM, Jamie Lokier wrote: By the way, since you've already invented a non-standard JSON extension, which is the single quotes, why not go a step further and permit the quotes to be omitted for simple tokens? #define QERR_DEV_NFOUND "{ code: 404, name: %s}" Much neater, IMHO.

Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Jamie Lokier
Anthony Liguori wrote: > Okay, let's get more clever then and do: > > #define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" By the way, since you've already invented a non-standard JSON extension, which is the single quotes, why not go a step further and permit the quotes to be omitted for simple

Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()

2009-10-30 Thread Anthony Liguori
Mark McLoughlin wrote: Okay, let's try re-enabling the drain-entire-queue behaviour, with a difference - before each subsequent packet, use qemu_can_send_packet() to check that we can send it. This is similar to how we check before polling the tap fd and avoids having to drop a packet if the rece

Re: [Qemu-devel] [PATCH] hw/sd: Support SDHC size cards

2009-10-30 Thread Anthony Liguori
Jason McMullan wrote: This patch add SHDC support (-sd sd.img, where sd.img is larger than 1GB) to qemu. Comments welcome. Signed-off-by: Jason S. McMullan --- hw/sd.c | 153 ++- 1 files changed, 93 insertions(+), 60 deletions(-)

Re: [Qemu-devel] [PATCH v3 1/25] Makefile.target: add pc98 objects

2009-10-30 Thread Anthony Liguori
TAKEDA, toshiya wrote: diff --git a/qemu/Makefile.target b/qemu/Makefile.target I'm not sure what these patches are against but they do not seem to be against our qemu tree. Regards, Anthony Liguori

[Qemu-devel] PC machine types switched to SeaBIOS/gPXE

2009-10-30 Thread Anthony Liguori
Hi, I just wanted to let everyone know that I've switched the PC machine type to SeaBIOS and gPXE. SeaBIOS is a port of the Bochs BIOS to GCC, by Kevin O'Conner, along with quite a lot of clean up and new feature work. gPXE is the new development tree of etherboot which is now deprecated.

[Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Luiz Capitulino
On Fri, 30 Oct 2009 08:59:43 -0500 Anthony Liguori wrote: > Luiz Capitulino wrote: > > Seems ok to me, but to make it harder to reuse existing error > > codes we'd have to: > > > > 1. Make mandatory the use of a macro in the qemu_error_structed() > >call > > 2. All macros would have to be de

[Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Anthony Liguori
Luiz Capitulino wrote: Seems ok to me, but to make it harder to reuse existing error codes we'd have to: 1. Make mandatory the use of a macro in the qemu_error_structed() call 2. All macros would have to be defined in qerror.h Not really. All you need is to switch code to something tha

[Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-30 Thread Luiz Capitulino
On Fri, 30 Oct 2009 08:05:57 -0500 Anthony Liguori wrote: > Paolo Bonzini wrote: > > On 10/29/2009 09:48 PM, Luiz Capitulino wrote: > >> > va_list doesn't need to be a pointer. > >> > >> Ok, but if this is going to be a public interface, I think it's > >> better to va_copy() before passing it

[Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Luiz Capitulino
(Added Daniel Berrange to the CC list) On Fri, 30 Oct 2009 08:09:02 -0500 Anthony Liguori wrote: > Gerd Hoffmann wrote: > > On 10/30/09 13:28, Luiz Capitulino wrote: > -qemu_error("Device \"%s\" not found. Try -device '?' for > a list.\n", > - driver)

[Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Paolo Bonzini
On 10/30/2009 02:09 PM, Anthony Liguori wrote: Okay, let's get more clever then and do: #define QERR_DEV_NFOUND "{ 'code': 404, 'name': %s}" So we can do: qemu_error_structured(QERR_DEV_NFOUND, driver); Such that we still get printf style parameter checking. That's clever indeed. :-) But

[Qemu-devel] [PATCH] Documentation: Add documentation for -chardev

2009-10-30 Thread Matthew Booth
Adds documentation for all -chardev backends. Signed-off-by: Matthew Booth --- qemu-options.hx | 234 ++- 1 files changed, 230 insertions(+), 4 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index d78b738..7922191 100644 --- a/qe

[Qemu-devel] Documentation: Add documentation for -chardev

2009-10-30 Thread Matthew Booth
Matt

[Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Anthony Liguori
Gerd Hoffmann wrote: On 10/30/09 13:28, Luiz Capitulino wrote: -qemu_error("Device \"%s\" not found. Try -device '?' for a list.\n", - driver); +qemu_error_structed(QERR_DEV_NFOUND, "{ 'name': %s }", driver); why not store the "{ 'name': %s }" in the qerror

[Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-30 Thread Anthony Liguori
Paolo Bonzini wrote: On 10/29/2009 09:48 PM, Luiz Capitulino wrote: > va_list doesn't need to be a pointer. Ok, but if this is going to be a public interface, I think it's better to va_copy() before passing it to qobject_from_json_va() then. It is standard to pass a va_list by value withou

[Qemu-devel] [PATCH V6 19/32] pci: make pci configuration transaction more accurate.

2009-10-30 Thread Isaku Yamahata
This patch sorts out/enhances pci code to track pci bus topology more accurately. - Track host bus bridge with pci domain number. Although the current qemu implementation supports only pci domian 0 yet. - Track pci bridge parent-child relationship. When looking down from pci host bus for pci sub

[Qemu-devel] [PATCH V6 30/32] pci: factor out pci_for_each_device().

2009-10-30 Thread Isaku Yamahata
split out device iteration logic from pci_for_each_device(). factored out function, pci_for_each_device_under_bus() will be used later. Signed-off-by: Isaku Yamahata --- hw/pci.c | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/pci.c b/hw/pci.c ind

[Qemu-devel] [PATCH V6 20/32] pci: factor out the conversion logic from io port address into pci device.

2009-10-30 Thread Isaku Yamahata
factor out the logic which converts io port address into pci device and offset in PCI configuration space. Signed-off-by: Isaku Yamahata --- hw/pci.c | 32 ++-- 1 files changed, 18 insertions(+), 14 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 3e5780a..d0a96

[Qemu-devel] [PATCH V6 32/32] pci/monitor: print out bridge's filtering values and so on.

2009-10-30 Thread Isaku Yamahata
make pci_info_device() print out bridge's filtering value like io base/limit, subbus and subordinate bus. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c

[Qemu-devel] [PATCH V6 28/32] pci: initialize pci config headers depending it pci header type.

2009-10-30 Thread Isaku Yamahata
- Only sets default subsystem id for header type 00.(normal header type) because header type 01 doesn't have subsystem id, and uses the register for other purpose. So setting default subsystem id doesn't make sense. - initialize wmask more for header type 01.(bridge header type) Without thos

[Qemu-devel] [PATCH V6 08/32] pci: clean up pci_init_wmask()

2009-10-30 Thread Isaku Yamahata
use pci_set_word() for pci command register. Signed-off-by: Isaku Yamahata --- hw/pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6abb0e2..84c7611 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -352,8 +352,8 @@ static void pci_init_wmask(PCIDe

[Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Gerd Hoffmann
On 10/30/09 13:28, Luiz Capitulino wrote: -qemu_error("Device \"%s\" not found. Try -device '?' for a list.\n", - driver); +qemu_error_structed(QERR_DEV_NFOUND, "{ 'name': %s }", driver); why not store the "{ 'name': %s }" in the qerror_table? I guess you pla

[Qemu-devel] [PATCH] eepro100: Improve support for different devices

2009-10-30 Thread Stefan Weil
* Add device properties (size of statistical data, extended tcb support) to EEPRO100State and set these values for the different devices. * Fix PCI configuration for existing devices. * Add initialisation code for missing devices. * Remove function device_supports_eTxCB. It is no longer ne

[Qemu-devel] Re: [RFC 0/7] QError v1

2009-10-30 Thread Luiz Capitulino
On Thu, 29 Oct 2009 23:12:10 +0100 Paolo Bonzini wrote: > > A last note: this series is on top of the (to be merged) QJSon module, > > that's why it's a RFC and.. I didn't test it too much. :) > > I have just two comments: > > 1) you do > > > -qemu_error("Device \"%s\" not found. Tr

[Qemu-devel] [PATCH V6 25/32] pci: add helper functions to check ranges overlap.

2009-10-30 Thread Isaku Yamahata
add helper function to check ranges overlap suggested by Michael S. Tsirkin . His original suggestion was to use [first, last], however I chosen to use offset, length pair, i.e. [offset, offset + length) because pci configuration space related functions all uses offset and length pair, so it helps

[Qemu-devel] [PATCH V6 31/32] pci: implement pci bridge filtering.

2009-10-30 Thread Isaku Yamahata
This patch implements pci bridge filtering. TODO: currently almost all the map funcions assumes filtered_size == size and addr & ~(size - 1) == addr. However with bridge filtering, they aren't always true. Teach them such cases, such that filtered_size < size and addr & (size - 1) != 0. Signed-of

[Qemu-devel] [PATCH V6 07/32] pci/bridge: clean up of pci_bridge_initfn()

2009-10-30 Thread Isaku Yamahata
- use symbolic constant - use helper function pci_set_xxx() - removed lines which initializes to 0. It is unnecessary because it is already zeroed. - add some comments on command registers. Some initial values are suspicious because they seems to be specific to apb_pci.c which is the only user o

[Qemu-devel] [PATCH V6 24/32] pci: pcie host and mmcfg support.

2009-10-30 Thread Isaku Yamahata
This patch adds common routines for pcie host bridge and pcie mmcfg. This will be used by q35 based chipset emulation. Signed-off-by: Isaku Yamahata --- Makefile.target |2 +- hw/hw.h | 11 +++ hw/pci.c| 86 + hw/pci.h| 27 +++- hw/pc

[Qemu-devel] [PATCH V6 23/32] vmstate: introduce VMSTATE_BUFFER_UNSAFE_INFO.

2009-10-30 Thread Isaku Yamahata
VMSTATE_BUFFER_UNSAFE_INFO for as a buffer with specified VMStateInfo. It will be used later. Signed-off-by: Isaku Yamahata --- hw/hw.h |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index eb5c639..cf8c304 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -4

[Qemu-devel] [PATCH V6 13/32] pci_host: consolidate pci config address access.

2009-10-30 Thread Isaku Yamahata
consolidate pci_config address access into pci_host.c Signed-off-by: Isaku Yamahata --- hw/apb_pci.c | 43 +- hw/grackle_pci.c | 45 +- hw/pci_host.c| 108 ++ hw/pci_host.h|3 + hw/pi

[Qemu-devel] [PATCH V6 22/32] pci_host: change the signature of pci_data_{read, write}.

2009-10-30 Thread Isaku Yamahata
change the first argument, void *opaque to PCIBus *s of the pci_data_{read, write}. They aren't used as direct callback so the argument type don't have to be void*. So change it to the right type. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.h |4 ++-- hw/pci_h

[Qemu-devel] [PATCH V6 29/32] pci: cosmetic on pci_upadte_mappings()

2009-10-30 Thread Isaku Yamahata
Remove one indentation of pci_update_mappings. Just for cosmetics, no logic change. Signed-off-by: Isaku Yamahata --- hw/pci.c | 146 -- 1 files changed, 76 insertions(+), 70 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index beefae3

[Qemu-devel] [PATCH V6 04/32] pci: define a constant to represent a unmapped bar and use it.

2009-10-30 Thread Isaku Yamahata
define a constant to represent a unmapped bar instead of -1 and use it. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/cirrus_vga.c |2 +- hw/pci.c| 18 +- hw/pci.h|1 + 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a

[Qemu-devel] [PATCH V6 12/32] pci_host.h: move functions in pci_host.h into .c file.

2009-10-30 Thread Isaku Yamahata
split static functions in pci_host.h into pci_host.c and pci_host_template.h. Later a structures declared in pci_host.h, PCIHostState, will be used. However pci_host.h doesn't allow to include itself easily. This patches addresses it. pci_host.h includes functions which are instantiated in .c by i

[Qemu-devel] [PATCH V6 26/32] pci: use range helper functions.

2009-10-30 Thread Isaku Yamahata
clean up pci_default_write_config() by the range helper functions. Suggested by Michael S. Tsirkin Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/pci.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 67133b6..d9fd564 100644

[Qemu-devel] [PATCH V6 09/32] pci: s/PCI_ADDRESS_SPACE_/PCI_BASE_ADDRESS_SPACE_/ to match pci_regs.h

2009-10-30 Thread Isaku Yamahata
make constants for pci base address match pci_regs.h by renaming PCI_ADDRESS_SPACE_xxx to PCI_BASE_ADDRESS_SPACE_xxx. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/ac97.c |5 +++-- hw/cirrus_vga.c |4 ++-- hw/e1000.c|4 ++-- hw/eepro100.c |

[Qemu-devel] [PATCH V6 03/32] pci: use PCI_SLOT() and PCI_FUNC().

2009-10-30 Thread Isaku Yamahata
use PCI_SLOT() and PCI_FUNC() where appropriate instead of direct use of bit operation. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/apb_pci.c | 10 ++ hw/pci.c |4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/apb_pci.c b/hw/apb_p

[Qemu-devel] [PATCH V6 27/32] pci: teach pci_default_config_write() ROM bar for normal/bridge device .

2009-10-30 Thread Isaku Yamahata
When updated ROM expantion address of header type 0, it missed to update mappings. Add PCI_ROM_ADDRESS check whether to call pci_update_mappings() Also update pci mapping when PCI_ROM_ADDRESS1 is written for header type 1. pci_update_mapping() path isn't performance critical, so call it even indep

[Qemu-devel] [PATCH V6 21/32] pci: move pci host stuff from pci.c to pci_host.c

2009-10-30 Thread Isaku Yamahata
Move pci host stuff from pci.c to pci_host.c. And add some comments. Later pcie host bridge functions will be defined in pcie_host.c not to bloat pci.c. Signed-off-by: Isaku Yamahata --- hw/pci.c | 67 - hw/pci_host.c | 63

[Qemu-devel] [PATCH V6 18/32] pci: remove bus_num member from struct PCIBus.

2009-10-30 Thread Isaku Yamahata
Since It can be retrieved from pci configuration space, the member is unnecessary. Signed-off-by: Isaku Yamahata --- hw/pci.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 7da3db9..a75d981 100644 --- a/hw/pci.c +++ b/hw/p

[Qemu-devel] [PATCH V6 15/32] pci: introduce FMT_PCIBUS for printf format for pcibus_t.

2009-10-30 Thread Isaku Yamahata
This patch is preliminary for 64bit BAR. Later pcibus_t will be changed from uint32_t to uint64_t. Introduce FMT_PCIBUS for printf format for pcibus_t. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/e1000.c|6 -- hw/eepro100.c |6 -- hw/pci.c

[Qemu-devel] [PATCH V6 01/32] pci: fix PCI_DPRINTF() wrt variadic macro.

2009-10-30 Thread Isaku Yamahata
add missing ## in PCI_DPRINTF() to compile. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index ef134f7..1c95f88 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -29,7 +29,7 @@ //#d

[Qemu-devel] [PATCH V6 05/32] pci: helper functions to access PCIDevice::config

2009-10-30 Thread Isaku Yamahata
add helper functions to get/set PCIDevice::config Those will be used later. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index bab9cab..157995c 100644 --- a/hw/pci

[Qemu-devel] [PATCH V6 14/32] pci: introduce pcibus_t to represent pci bus address/size instead of uint32_t

2009-10-30 Thread Isaku Yamahata
This patch is preliminary for 64 bit BAR support. Introduce dedicated type, pcibus_t, to represent pci bus address/size instead of uint32_t. Later this type will be changed to uint64_t. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/ac97.c |2 +- hw/cirrus_vga.c

[Qemu-devel] [PATCH V6 02/32] pci: introduce constant PCI_NUM_PINS for the number of interrupt pins, 4.

2009-10-30 Thread Isaku Yamahata
introduce constant PCI_NUM_PINS for the number of interrupt pins, 4. and use it. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c |4 ++-- hw/pci.h |4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 1c95f88..e21098b 1

[Qemu-devel] [PATCH V6 16/32] pci: typedef pcibus_t as uint64_t instead of uint32_t.

2009-10-30 Thread Isaku Yamahata
This patch is preliminary for 64bit bar. For 64bit bar support, change pcibus_t which represents pci bus addr/size from uint32_t to uint64_t. And also change FMT_pcibus for printf. In pci_update_mapping() checks 32bit overflow. So the check must be updated too. Signed-off-by: Isaku Yamahata ---

[Qemu-devel] [PATCH V6 17/32] pci: 64bit bar support.

2009-10-30 Thread Isaku Yamahata
implemented pci 64bit bar support. The tricky bit is pci_update_mapping(). An OS is allowed to set the BAR such that OS can't address the area pointed by BAR. It doesn't make sense, though. In that case, don't map the BAR. Signed-off-by: Isaku Yamahata --- hw/pci.c | 35 +++

[Qemu-devel] [PATCH V6 11/32] pci: make pci_bar() aware of header type 1.

2009-10-30 Thread Isaku Yamahata
make pci_bar() aware of header type 1. When PCI_ROM_SLOT it should return PCI_ROM_ADDRESS1 (!= PCI_ROM_ADDRESS) Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c | 18 -- hw/pci.h |1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/h

[Qemu-devel] [PATCH V6 06/32] pci: use helper functions to access pci config space.

2009-10-30 Thread Isaku Yamahata
use pci_[gs]et_{byte, word, long}() to access pci configuration space. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 00d407d..ab5eff8 10064

[Qemu-devel] [PATCH V6 00/32] pci: various pci clean up and pci express support.

2009-10-30 Thread Isaku Yamahata
This patch set is preliminary for q35 based chipset support. This patch sets does various pci related clean ups and 64bit bar, pciemmconfig and pci bridge support. Now I updated the patches following Michael's comment and implemented PCI bridge filtering. Windows xp 32bit installs and boots. I d

[Qemu-devel] [PATCH V6 10/32] pci: clean up of pci_default_read_config.

2009-10-30 Thread Isaku Yamahata
This patch cleans up pci_default_read_config() removing ugly length and range check. Suggested by "Michael S. Tsirkin" Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c | 26 +- 1 files changed, 5 insertions(+), 21 deletions(-) diff --git a/hw/p

[Qemu-devel] Re: [PATCH] Documentation: Add documentation for -chardev

2009-10-30 Thread Gerd Hoffmann
Hi, New patch attached. Looks good now. thanks, Gerd

[Qemu-devel] Re: [PATCH] Documentation: Add documentation for -chardev

2009-10-30 Thread Matthew Booth
On 30/10/09 09:17, Gerd Hoffmann wrote: On 10/29/09 17:56, Matthew Booth wrote: +DEFHEADING() + +DEFHEADING(Character device options:) + +DEF("chardev", HAS_ARG, QEMU_OPTION_chardev, + "-chardev null[,id=id]\n" + " A void device. This device will not emit any data, and will\n" + " drop any data

Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO

2009-10-30 Thread Juha.Riihimaki
On Oct 22, 2009, at 19:43, ext Mark McLoughlin wrote: > Hey, >Over a year ago we added some code to qemu-kvm.git which takes > advantage of the recent tun/tap IFF_VNET_HDR feature in order to allow > virtio-net to send and receive packets with partial checksums and > segmentation offloaded

[Qemu-devel] Re: [PATCH] Documentation: Add documentation for -chardev

2009-10-30 Thread Gerd Hoffmann
On 10/29/09 17:56, Matthew Booth wrote: +DEFHEADING() + +DEFHEADING(Character device options:) + +DEF("chardev", HAS_ARG, QEMU_OPTION_chardev, +"-chardev null[,id=id]\n" +"A void device. This device will not emit any data, and will\n" +"drop any data i

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-30 Thread Gerd Hoffmann
Hi, When they do, poke me and I'll make sure to process them quickly. Just sent. One of my short term goals is to get better at handling easy patches more quickly. Great. /me tests the new process ;) cheers, Gerd

[Qemu-devel] [PATCH 0/2] scsi: rename header files.

2009-10-30 Thread Gerd Hoffmann
Hi, First two patches of the upcoming scsi cleanup series for a quick merge ;) cheers, Gerd

[Qemu-devel] [PATCH 2/2] scsi: move scsi-disk.h -> scsi.h

2009-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/cdrom.c|2 +- hw/esp.c |2 +- hw/ide/core.c |2 +- hw/lsi53c895a.c |2 +- hw/pci-hotplug.c |2 +- hw/scsi-bus.c |2 +- hw/scsi-disk.c|2 +- hw/scsi-disk.h| 67 ---

[Qemu-devel] [PATCH 1/2] scsi: move scsi.h -> esp.h

2009-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/esp.c|2 +- hw/esp.h|7 +++ hw/lsi53c895a.c |1 - hw/mips_jazz.c |2 +- hw/scsi.h |7 --- hw/sun4m.c |2 +- 6 files changed, 10 insertions(+), 11 deletions(-) create mode 100644 hw/esp.h delete mode

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-30 Thread Hannes Reinecke
Gerd Hoffmann wrote: > On 10/29/09 05:37, Christoph Hellwig wrote: >>> So something like >>> - Get next request >>> - Attach iovec/bounc-buffer >>> - handle request (command/write/read) >>> - complete request (callback) >> >> Btw, from some previuous attempts to sort out this code here are some >>