Re: [Qemu-devel] Re: [RFC 0/7] QError v1

2009-11-01 Thread Vincent Hanquez
On Fri, Oct 30, 2009 at 06:33:15PM +0100, Paolo Bonzini wrote: On 10/30/2009 06:15 PM, Daniel P. Berrange wrote: If we're going to use JSON we should be 100% compliant with the JSON spec, not extend it. By adding custom QEMU extensions, we loose the ability for programming language to

Re: [Qemu-devel] QJSON status?

2009-11-01 Thread Vincent Hanquez
On Fri, Oct 30, 2009 at 05:51:20PM +0100, Paolo Bonzini wrote: I'm a bit lost on the QJSON patches that were posted and what's missing yet... Anthony, can you place them in your queue or in a separate branch? a bit OOT by now, but my libjson parser/printer is available at

Re: [Qemu-devel] [PATCH] e1000 fix: read access to some registers is missing.

2009-11-01 Thread Avi Kivity
On 10/31/2009 07:29 PM, Kay Ackermann wrote: While writing working on an e1000 driver for my university's OS I noticed that some registers aren't readable in QEMU, but they should be readable as stated in Intels Driver Developer Manual (and also verified on real hardware). diff --git

[Qemu-devel] [RFC 0/8]: Some 'info' handlers conversions

2009-11-01 Thread Luiz Capitulino
Hi, I'm sending in this series some info handlers conversions I have in my queue, as they depend on the QJSON module this submission is for review-only. The only issue I have here is error handling on calls to qobject_from_jsonf(), I'm calling assert() but we should have a wrapper for this.

[Qemu-devel] [PATCH 1/8] Introduce qemu-objects.h header file

2009-11-01 Thread Luiz Capitulino
An easy way to include all QEMU objects. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-objects.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 qemu-objects.h diff --git a/qemu-objects.h b/qemu-objects.h new file mode

[Qemu-devel] [PATCH 2/8] Makefile: move QObject objs to their own entry

2009-11-01 Thread Luiz Capitulino
Other subsystems will need to link against them. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 6fcbcaa..56f0301 100644 --- a/Makefile +++ b/Makefile @@ -70,6 +70,10 @@

[Qemu-devel] [PATCH 3/8] QDict: Introduce qdict_get_qbool()

2009-11-01 Thread Luiz Capitulino
This is a helper function that does type checking before retrieving a QBool from the dictionary. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile |2 +- qdict.c | 15 +++ qdict.h |1 + 3 files changed, 17 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 4/8] monitor: Convert do_info_migrate() to QObject

2009-11-01 Thread Luiz Capitulino
Return a QDict, which may contain another QDict if the migration process is active. The main QDict contains the following: - status: migration status - ram: only present if status is active, it is a QDict with the following information (in bytes): - transferred: amount of RAM

[Qemu-devel] [PATCH 5/8] monitor: Convert bdrv_info() to QObject

2009-11-01 Thread Luiz Capitulino
Each block device information is stored in a QDict and the returned QObject is a QList of all devices. The QDict contains the following: - device: device name - type: device type - removable: 1 if the device is removable 0 otherwise - locked: 1 if the device is locked 0 otherwise - inserted:

[Qemu-devel] [PATCH 6/8] monitor: Convert qemu_chr_info() to QObject

2009-11-01 Thread Luiz Capitulino
Each device is represented by a QDict. The returned QObject is a QList of all devices. The QDict contains the following: - label: device's label - filename: device's file This commit should not change user output, the following is an example of the returned QList: [ { label: monitor, filename,

[Qemu-devel] [PATCH 7/8] monitor: Convert pci_device_hot_add() to QObject

2009-11-01 Thread Luiz Capitulino
Return a QDict with the following device information: - domain: domain number - bus: bus number - slot: slot number - function: function number This commit should not change user output, the following is an example of the returned QDict: { domain: 0, bus: 0, slot: 5, function: 0 } Please, note

[Qemu-devel] [PATCH 8/8] monitor: Convert do_info_status() to QObject

2009-11-01 Thread Luiz Capitulino
Return a QString with status information. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 35 +-- 1 files changed, 29 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 4e19fdf..78a2df5 100644 --- a/monitor.c +++

[Qemu-devel] Re: [PATCH V6 17/32] pci: 64bit bar support.

2009-11-01 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:11PM +0900, Isaku Yamahata wrote: implemented pci 64bit bar support. The tricky bit is pci_update_mapping(). An OS is allowed to set the BAR such that OS can't address the area pointed by BAR. It doesn't make sense, though. It might make sense. 32 bit guest can

[Qemu-devel] [PATCH] qdev: Check if unplug handler exists before calling it

2009-11-01 Thread Amit Shah
A bus may have hotplugging enabled but not have the 'unplug' callback defined, which would lead to a crash on trying to unplug a device on the bus. Fix by checking if the callback is valid Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/qdev.c |5 + 1 files changed, 5