Am 17.11.2009 00:26, schrieb Anthony Liguori:
Kevin Wolf wrote:
We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
descriptors that don't need to be passed to children to stop this
misbehaviour.
Signed-off-by: Kevin Wolf kw...@redhat.com
pid = fork();
Am 17.11.2009 00:05, schrieb Jamie Lokier:
Blue Swirl wrote:
On Mon, Nov 16, 2009 at 2:47 PM, Kevin Wolf kw...@redhat.com wrote:
Am 13.11.2009 22:05, schrieb Blue Swirl:
On Fri, Nov 13, 2009 at 5:17 PM, Kevin Wolf kw...@redhat.com wrote:
We're leaking file descriptors to child processes. Set
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Jamie Lokier wrote:
Ian Molton wrote:
With VMs, in some circumstances it might be preferable to trust the
host when it says it's providing already-tested entropy. After all
the host has total control over the guest anyway, and the host entropy
On (Mon) Nov 16 2009 [17:58:22], Ian Molton wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Gerd Hoffmann wrote:
Maybe ...
-chardev socket,id=egd,host=egd.domain.tld,port=whatever
-device virtio-rng,chardev=egd
I've had a go at modifying virtio-console.c to use these
Interesting, I have been working on AT91SAM7X implementation. Most of
the stuff is in the GIT repository at
http://repo.or.cz/w/qemu/navara.git
Any way to merge the efforts? I'd love to merge both mine and your
patches to the mainline (minus the overlapping parts of the system
controller). In
Qemu creates a default serial line for you in case you didn't specify
one on the command line. Right now this is tied to the '-serial
chardev' command line switch, which in turn causes trouble if you are
creating your serial line via '-device isa-serial,props'.
This patch adds a variable
Hi,
qemu silently creates default devices for you if you didn't specify one
on the command line, i.e. you'll get a vga, a serial port, a nic, ...
created by default. Right now this doesn't integrate with qdev at all,
i.e. if you try to add -- for example -- a serial line the new qdev way
using
Switch over parallel ports to the new default device system.
Disable default parallel port for both '-parallel' and '-device
isa-parallel' cases.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
vl.c | 68 +-
1 files changed,
Add a greeting string to CharDriverState which is printed after
initialization. Used to have the qemu vc consoles labeled. This
way we can avoid walking all the chardevs a second time after
initialization just to print the greeting.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
Switch over monitor to the new defaults system.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
vl.c | 90 +
1 files changed, 46 insertions(+), 44 deletions(-)
diff --git a/vl.c b/vl.c
index 739c3a7..4edc4a3 100644
--- a/vl.c
Add defaults variable for drives.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
vl.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index 23afcc9..eb07a5b 100644
--- a/vl.c
+++ b/vl.c
@@ -275,6 +275,7 @@ static int default_serial = 1;
Switch over network to the new defaults system.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
net.c |5 -
net.h |1 +
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/net.c b/net.c
index 9ea66e3..9375351 100644
--- a/net.c
+++ b/net.c
@@ -112,6 +112,8 @@
static
Add global switch to turn off all default devices.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
qemu-options.hx |5 +
vl.c|8
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index b65fd74..70929fa 100644
---
Switch over vga to the new default device system.
Disable default vga for both '-vga' and
'-device VGA|Cirrus VGA|QEMUware SVGA)' cases.
'-device VGA' still doesn't work though due to a initialization order
issue (vga must init before calling i440fx_init_memory_mappings).
Signed-off-by: Gerd
I'd say it is preferable to split the individual devices and model
them using the QDEV infrastructure instead of putting it all together
into one system controller device.
I've QDEV-based implementation of these devices already: PMC, DBGU,
PIO, PITC, AIC. That leaves the bus matrix, SDRAM
Hi,
First batch of scsi patches. They bring some data structure unification
and a bunch of fixes and cleanups. In preparation for the other scsi
patches, but also useful on its own IMHO, so I'm hoping for a quick and
painless merge.
The major rewrite which needs more discussion and
Helper function to init SCSIRequest, so scsi-disk and scsi-generic
don't duplicate init code for the common bits.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-bus.c |9 +
hw/scsi-disk.c|9 +++--
hw/scsi-generic.c |9 +++--
hw/scsi.h |
Also delete the leftover and unused scsi-disk.h file.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/esp.h |5
hw/scsi-disk.h | 67
hw/scsi.h |4 +-
3 files changed, 7 insertions(+), 69 deletions(-)
delete
Changes:
* Move from open-coded lists to QTAILQ macros.
* Move the struct elements to the common data structures
(SCSIDevice + SCSIRequest).
* Fix request cleanup in the destroy callback.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-bus.c |1 +
hw/scsi-disk.c|
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-disk.c|1 +
hw/scsi-generic.c | 23 +++
hw/scsi.h |1 +
3 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index bb2d68c..00d2944 100644
---
Rename the SCSIRequest structs in scsi-disk.c and scsi-generic.c to
SCSIDiskReq and SCSIGenericReq. Create a SCSIRequest struct and move
the common elements over.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-disk.c| 109 ++---
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-disk.c|1 +
hw/scsi-generic.c | 13 ++---
hw/scsi.h |1 +
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index a01a786..25f8eaa 100644
--- a/hw/scsi-disk.c
+++
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-bus.c |1 +
hw/scsi-generic.c | 17 ++---
hw/scsi.h |6 ++
3 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index c74d085..73cfe58 100644
---
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-bus.c | 164 +
hw/scsi-generic.c | 156 --
hw/scsi.h |3 +
3 files changed, 191 insertions(+), 132 deletions(-)
diff
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-disk.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 25f8eaa..2068187 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -398,16
Handy for debugging.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-bus.c | 114 +
hw/scsi.h |1 +
2 files changed, 115 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index edfe099..50fc03a
Largely based on scsi/scsi.h from linux. Added into the tree so we
can use the defines everywhere, not just in scsi-generic.c (which is
linux-specific).
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-defs.h| 156 +
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-bus.c | 46 ++
hw/scsi-generic.c | 40 ++--
hw/scsi.h |7 +++
3 files changed, 59 insertions(+), 34 deletions(-)
diff --git
On 11/12/09 12:48, Hannes Reinecke wrote:
This patch adds an emulation for the LSI MegaRAID SAS HBA.
It is build on top of kraxel's scsi.v7 tree.
This is just a rough implementation, many of the more
advanced topics (like Windows booting :-) are missing.
Signed-off-by: Hannes
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-net.c | 78 +++--
hw/usb.h |3 --
vl.c | 18 -
3 files changed, 48 insertions(+), 51 deletions(-)
diff --git a/hw/usb-net.c b/hw/usb-net.c
index
This patch adds a 'index' property to the isa-parallel and isa-serial
devices. This can be used to create devices with the default isa irqs
and ioports by simply specifying the index, i.e.
-device isa-serial,index=1
instead of
-device isa-serial,iobase=0x2f8,irq=3
for ttyS1 aka com2.
Gerd Hoffmann wrote:
On 11/12/09 12:48, Hannes Reinecke wrote:
This patch adds an emulation for the LSI MegaRAID SAS HBA.
It is build on top of kraxel's scsi.v7 tree.
This is just a rough implementation, many of the more
advanced topics (like Windows booting :-) are missing.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Amit Shah wrote:
(Any reason to take this off-list?)
None other than hitting reply rather than reply-all. CCing list once
more :-)
Either way, you still need to specify the properties - they've just
moved into the console driver in your patch by
On Tue, Nov 17, 2009 at 11:17:37AM +0100, Gerd Hoffmann wrote:
Also delete the leftover and unused scsi-disk.h file.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Tue, Nov 17, 2009 at 11:17:38AM +0100, Gerd Hoffmann wrote:
Rename the SCSIRequest structs in scsi-disk.c and scsi-generic.c to
SCSIDiskReq and SCSIGenericReq. Create a SCSIRequest struct and move
the common elements over.
Nice, have been waiting for this for a long time.
Reviewed-by:
On Tue, Nov 17, 2009 at 11:17:39AM +0100, Gerd Hoffmann wrote:
Changes:
* Move from open-coded lists to QTAILQ macros.
* Move the struct elements to the common data structures
(SCSIDevice + SCSIRequest).
* Fix request cleanup in the destroy callback.
Perfect, the old, duplicated list
On Tue, Nov 17, 2009 at 11:17:40AM +0100, Gerd Hoffmann wrote:
Helper function to init SCSIRequest, so scsi-disk and scsi-generic
don't duplicate init code for the common bits.
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Tue, Nov 17, 2009 at 11:17:41AM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann kra...@redhat.com
A little description of why you can it would be good. I will
defintively help with my SBC thin provisioning implementation later, so
no complaints from me :)
Reviewed-by: Christoph
On (Tue) Nov 17 2009 [11:10:32], Ian Molton wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Amit Shah wrote:
(Any reason to take this off-list?)
None other than hitting reply rather than reply-all. CCing list once
more :-)
Either way, you still need to specify the properties -
On Tue, Nov 17, 2009 at 11:17:42AM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Tue, Nov 17, 2009 at 11:17:43AM +0100, Gerd Hoffmann wrote:
Largely based on scsi/scsi.h from linux. Added into the tree so we
can use the defines everywhere, not just in scsi-generic.c (which is
linux-specific).
Btw, I'm not sure having the name clash with the Linux header is a good
idea
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
It would require a mechanism to do enumeration and identification
though.
Huh? Do you want export *all* block devices via extboot? Will IDE
drives show up twice then?
No, because SeaBIOS already has an ATA driver so we wouldn't want to
expose IDE on the extboot bus.
SeaBIOS
The subject is a bit confusing - it's not the full request parsing but
just some helpers.
+static int scsi_req_length(SCSIRequest *req, uint8_t *cmd)
+{
+switch (cmd[0] 5) {
I know qemu code tends to be very uncommented and the code this is
lifted from too, but some comments on how
On Tue, Nov 17, 2009 at 11:17:46AM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Tue, Nov 17, 2009 at 11:17:47AM +0100, Gerd Hoffmann wrote:
+static void scsi_req_xfer_mode(SCSIRequest *req)
+{
+switch (req-cmd.buf[0]) {
Having this as a void seem a bit odd to me. I'd make it return the
mode, and maybe just pass the cmd to it to make it more clear.
+static int
Looks good. Long term we might want to make this a pointer to be able
to deal with block format sense descriptors more nicely.
move scsi command from SCSIGenericReq to SCSIRequest.
Why? AFAICS This has precisely one user, and more importantly it is not
populated by scsi-disk.c.
Sharing common code is good. Implementing shared fields inconsistently or
putting implementation specific fields in common structures.
Paul
add xfer mode
This should also be used by scsi-disc.c
Paul
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
Changes:
* Move from open-coded lists to QTAILQ macros.
* Move the struct elements to the common data structures
(SCSIDevice + SCSIRequest).
* Fix request cleanup in the destroy callback.
This feels like the abstraction boundaries
On Tue, Nov 17, 2009 at 11:17:49AM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Tue, Nov 17, 2009 at 11:17:50AM +0100, Gerd Hoffmann wrote:
Also add and use the scsi_req_complete() helper function for calling the
completion callback.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Look good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Tue, Nov 17, 2009 at 11:17:51AM +0100, Gerd Hoffmann wrote:
Handy for debugging.
Yes, nice one, but what about getting rid of the ad-hoc printfs in
scsi-disk, too?
On 11/17/2009 01:04 PM, Yoshiaki Tamura wrote:
What I mean is:
- choose synchronization point A
- start copying memory for synchronization point A
- output is delayed
- choose synchronization point B
- copy memory for A and B
if guest touches memory not yet copied for A, COW it
- once A
The practical example below will explain it completely:
1) we take 4 common modern computers - CoreQuad + 8 GB Memory.
2) we assemble a standard Linux cluster with 16 cores and 32G memory.
3) and now - we run the only one virtual guest system, but give it ALL
available resources.
If
On 11/17/09 12:36, Paul Brook wrote:
It would require a mechanism to do enumeration and identification
though.
Huh? Do you want export *all* block devices via extboot? Will IDE
drives show up twice then?
No, because SeaBIOS already has an ATA driver so we wouldn't want to
expose IDE on the
On Tuesday 17 November 2009, Christoph Hellwig wrote:
The subject is a bit confusing - it's not the full request parsing but
just some helpers.
This is a good example of a patch with an insufficient commit message.
Given the way GIT treats the first line of the commit mesaage, my advice is to
In fact I'd much prefer to see extboot rewritten to just virtio-block.
Hmm, I'd prefer something which is *not* used by the guest OS, so it is
a pure bootloader thing. When using it to boot from scsi you don't want
to have the disk show up twice (as virtio and scsi) in the guest.
You're
Hi,
Qemu currently is making a bit of a hash of parsing suffixes,
Right now, it has:
T, G, M, and K which are multiples of 1024 bytes - fair enough
but it also has:
k - 1024 (should be 1000)
and b:
Byte (also wrong)
since its only using a single character, with b taken, theres no way to
On 11/17/09 12:59, Paul Brook wrote:
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
Changes:
* Move from open-coded lists to QTAILQ macros.
* Move the struct elements to the common data structures
(SCSIDevice + SCSIRequest).
* Fix request cleanup in the destroy callback.
This
On 11/17/09 12:55, Paul Brook wrote:
move scsi command from SCSIGenericReq to SCSIRequest.
Why? AFAICS This has precisely one user, and more importantly it is not
populated by scsi-disk.c.
Next patch of scsi patches will make scsi-disk use it too.
(in the git tree: a bunch of patches
On 11/17/09 13:27, Paul Brook wrote:
On Tuesday 17 November 2009, Christoph Hellwig wrote:
The subject is a bit confusing - it's not the full request parsing but
just some helpers.
This is a good example of a patch with an insufficient commit message.
Given the way GIT treats the first line
On 11/17/09 12:54, Christoph Hellwig wrote:
Looks good. Long term we might want to make this a pointer to be able
to deal with block format sense descriptors more nicely.
Did already happen ;)
I just can't move up that patch easily without causing massive churn in
the patch series ...
On 11/17/09 13:02, Christoph Hellwig wrote:
On Tue, Nov 17, 2009 at 11:17:51AM +0100, Gerd Hoffmann wrote:
Handy for debugging.
Yes, nice one, but what about getting rid of the ad-hoc printfs in
scsi-disk, too?
Will be part of the next scsi patch series which reworks scsi-disk.c
cheers,
On 11/17/09 13:36, Paul Brook wrote:
In fact I'd much prefer to see extboot rewritten to just virtio-block.
Hmm, I'd prefer something which is *not* used by the guest OS, so it is
a pure bootloader thing. When using it to boot from scsi you don't want
to have the disk show up twice (as virtio
On 11/17/09 11:17, Gerd Hoffmann wrote:
Hi,
First batch of scsi patches. They bring some data structure unification
and a bunch of fixes and cleanups. In preparation for the other scsi
patches, but also useful on its own IMHO, so I'm hoping for a quick and
painless merge.
The major
qemu-kvm's switch to seabios uncovered a regression with cdrom
handling. Vista x64 no longer recognizes the cdrom, while pc-bios still
works. Installing works, but that uses int 13, not the native driver.
Haven't investigated further yet.
Command line:
qemu -drive
On Tuesday 17 November 2009, Ian Molton wrote:
Hi,
Qemu currently is making a bit of a hash of parsing suffixes,
Right now, it has:
T, G, M, and K which are multiples of 1024 bytes - fair enough
but it also has:
k - 1024 (should be 1000)
and b:
Byte (also wrong)
since
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
On 11/17/09 13:36, Paul Brook wrote:
In fact I'd much prefer to see extboot rewritten to just virtio-block.
Hmm, I'd prefer something which is *not* used by the guest OS, so it is
a pure bootloader thing. When using it to boot from scsi
On 11/17/2009 02:20 PM, Paul Brook wrote:
What you're describing is commonly referred to as a Single System
Image. It's been around for a while and can be found in software-only
verses (pre-Xen VirtualIron, ScaleMP) and hardware-assisted (IBM, 3leaf).
Or better still do it at the OS
Why aren't you also using this function in scsi- disc.c? Surely that's the
whole point of moving it into common code.
Same as with the command move: next patch series will rework scsi-disk
to put the new fields and functions into use.
Hmm, maybe you need to rethink your patch sequencing
2009/11/17 Avi Kivity a...@redhat.com:
On 11/17/2009 01:04 PM, Yoshiaki Tamura wrote:
What I mean is:
- choose synchronization point A
- start copying memory for synchronization point A
- output is delayed
- choose synchronization point B
- copy memory for A and B
if guest touches
Paul Brook wrote:
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
On 11/17/09 13:36, Paul Brook wrote:
In fact I'd much prefer to see extboot rewritten to just virtio-block.
Hmm, I'd prefer something which is *not* used by the guest OS, so it is
a pure bootloader
Paul Brook wrote:
On Tuesday 17 November 2009, Ian Molton wrote:
When do we ever have a value that can be specified as both bits and bytes? I
don't think it makes sense to specify this. The fact that we accept a b
suffix at all is suspicious.
Well, entropy is often measured in 'bits' and
Alexander Graf wrote:
Because that's not what you'd use it for. That's what -kernel and
-initrd are there for.
IMHO having a BIOS backdoor is a good thing in general. If anyone wants
to destroy their user experience by writing a driver for that in their
OS, I'm good with that, but let's not
On 11/17/09 11:51, Hannes Reinecke wrote:
Grand. Meanwhile I've dug up some more register definitions,
so I'll doing some more updates to the driver.
Feel free to send updates (both incremental and replacement are fine).
Meanwhile I've stumbled across another issue:
The megasas HBA insists
While trying to run -kernel with -bios pc-bios/pcbios.bin, I realized
that I was actually writing data to %es, but only set up %ds to a 32-bit
segment we want to write to.
So at the end of the day the data hasn't actually been copied. Oops.
So here's a fix to set ES instead of DS, which makes
On 11/17/09 15:23, Ian Molton wrote:
I've cooked up this patch (attached) to add a SIZE property to qdevs.
I've kept the same semantics as the OPT_SIZE parser for now.
The error message should be adapted (s/Option/Property/ at least).
Maybe also create a common function for parsing called by
Avi Kivity schrieb:
qemu-kvm's switch to seabios uncovered a regression with cdrom
handling. Vista x64 no longer recognizes the cdrom, while pc-bios
still works. Installing works, but that uses int 13, not the native
driver. Haven't investigated further yet.
Command line:
qemu -drive
Gerd Hoffmann wrote:
On 11/17/09 15:23, Ian Molton wrote:
I've cooked up this patch (attached) to add a SIZE property to qdevs.
I've kept the same semantics as the OPT_SIZE parser for now.
The error message should be adapted (s/Option/Property/ at least).
Fixed locally.
Maybe also create
On Tuesday 17 November 2009 12:11:58 am Luiz Felipe wrote:
Hi, i tried to use kqemu in ubuntu to start Windows XP SP3. I used the
command line: qemu -kernel-kqemu and the system started to run windows on
qemu. Although, i observed the following message on my shell:
QEMU acceleration layer
On Tue, Nov 17, 2009 at 10:28:25AM +0100, Filip Navara wrote:
Interesting, I have been working on AT91SAM7X implementation. Most of
the stuff is in the GIT repository at
http://repo.or.cz/w/qemu/navara.git
Any way to merge the efforts? I'd love to merge both mine and your
patches to the
On 11/17/09 19:11, Ian Molton wrote:
Gerd Hoffmann wrote:
Maybe also create a common function for parsing called by both
parse_size() and parse_option_size() to make sure OPT_SIZE and the new
size property accept the same syntax?
The thought crossed my mind, but then I thought that as none of
On Tue, Nov 17, 2009 at 10:39:27AM +0100, Filip Navara wrote:
I'd say it is preferable to split the individual devices and model
them using the QDEV infrastructure instead of putting it all together
into one system controller device.
I've QDEV-based implementation of these devices already:
Saul Tamari wrote:
This patch reduces the size of memory being cleared on every virtio-blk IO.
Improve number of IOPS when using avirtio-blk device.
On every virtio-blk IO command passed to QEMU, virtio_blk_alloc_request()
allocates and clears (with qemu_mallocz()) a VirtIOBlockReq object.
The
Hi,
This new QError version has some small improvements and is a candidate
for merging, as qjson is already on master.
Just to remind you that it implements what was suggested by Anthony
in this email:
http://lists.gnu.org/archive/html/qemu-devel/2009-11/msg00601.html
Basically, the error
It accepts a va_list and will be used by QError. Also simplifies
the code a little, as the other qobject_from_() functions can
use it.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qjson.c | 21 +++--
qjson.h |2 ++
2 files changed, 13 insertions(+), 10
It appends a C char to a QString.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qstring.c | 24 +++-
qstring.h |1 +
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/qstring.c b/qstring.c
index 441a9e6..e422bd9 100644
--- a/qstring.c
+++
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qstring.c |8
qstring.h |2 ++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/qstring.c b/qstring.c
index e422bd9..ad17769 100644
--- a/qstring.c
+++ b/qstring.c
@@ -75,6 +75,14 @@ void
Note that we can now write qstring_from_str() as a wrapper.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qstring.c | 20 +++-
qstring.h |1 +
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/qstring.c b/qstring.c
index ad17769..740a106 100644
---
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qstring.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/check-qstring.c b/check-qstring.c
index ea4dfd0..412038a 100644
--- a/check-qstring.c
+++ b/check-qstring.c
@@ -55,6 +55,22 @@
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qstring.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/check-qstring.c b/check-qstring.c
index 412038a..c308a63 100644
--- a/check-qstring.c
+++ b/check-qstring.c
@@ -71,6 +71,19 @@
QError is a high-level data type which represents an exception
in QEMU, it stores the following error information:
- class Error class name (eg. ServiceUnavailable)
- descriptionA detailed error description, which can contain
references to run-time error data
-
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 74abef9..e42434f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1722,10 +1722,11 @@ static void do_info_balloon(Monitor *mon,
This commit adds QError support in the Monitor.
A QError member is added to the Monitor struct. This new member
stores error information and is also used to check if an error
has occurred when the called handler returns.
Additionally, a new macro called qemu_error_new() is introduced.
It builds
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hw/qdev.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index d19d531..875ca50 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -29,6 +29,7 @@
#include qdev.h
#include sysemu.h
#include
virtio: Report new guest memory statistics pertinent to memory ballooning (V3)
Changes since V2:
- Use a virtqueue for communication instead of the device config space
Changes since V1:
- In the monitor, print all stats on one line with less abbreviated names
- Coding style changes
When
On Tue, Nov 17, 2009 at 11:12 AM, Kevin Wolf kw...@redhat.com wrote:
Am 17.11.2009 00:05, schrieb Jamie Lokier:
Blue Swirl wrote:
On Mon, Nov 16, 2009 at 2:47 PM, Kevin Wolf kw...@redhat.com wrote:
Am 13.11.2009 22:05, schrieb Blue Swirl:
On Fri, Nov 13, 2009 at 5:17 PM, Kevin Wolf
Hi people,
I would like to tank you for your attention and patience. I don't understand
many things about emulators, nor linux. I started using Ubuntu-Linux this
year, and since then, i started to discover a new world. But sometimes i
have some problems and it's not so easy to a newbie to solve
Hi,
Now that qjson has been merged, it's time to flush my queues..
This series covers almost half of the info handlers conversions to the
QObject style, the other half is a bit more complicated as some handlers
can be defined by different machine types.
Detailed conversion status can be
1 - 100 of 127 matches
Mail list logo
