Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak

2009-11-20 Thread Amit Shah
On (Wed) Nov 18 2009 [10:42:59], Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > qemu-io.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/qemu-io.c b/qemu-io.c > index cac72e9..c84b361 100644 > --- a/qemu-io.c > +++ b/qemu-io.c > @@ -129,7 +129,8 @@

Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak

2009-11-20 Thread Kevin Wolf
Am 20.11.2009 09:05, schrieb Amit Shah: > On (Wed) Nov 18 2009 [10:42:59], Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf >> --- >> qemu-io.c | 10 ++ >> 1 files changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/qemu-io.c b/qemu-io.c >> index cac72e9..c84b361 100644 >> --- a/q

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-20 Thread Christoph Hellwig
On Wed, Nov 18, 2009 at 04:06:34PM -0600, Anthony Liguori wrote: > I assume you set prefix with your configure as opposed to make install > DESTDIR? Yes. It's configured the following way: ./configure \ --target-list=x86_64-softmmu \ --kerneldir=/home/hch/work/linux-2.6 \

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-20 Thread Alexander Graf
On 20.11.2009, at 10:12, Christoph Hellwig wrote: On Wed, Nov 18, 2009 at 04:06:34PM -0600, Anthony Liguori wrote: I assume you set prefix with your configure as opposed to make install DESTDIR? Yes. It's configured the following way: ./configure \ --target-list=x86_64-softmmu \

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-20 Thread Christoph Hellwig
On Fri, Nov 20, 2009 at 11:53:41AM +0100, Alexander Graf wrote: > Works great here: > > ./x86_64-softmmu/qemu-system-x86_64 -nographic -kernel ../bzImage - > append console=ttyS0 -L pc-bios > > Are you sure you also have the follow-up linuxboot patch applied? The > one "fixing BOCHS bios suppo

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-20 Thread Alexander Graf
On 20.11.2009, at 12:31, Christoph Hellwig wrote: On Fri, Nov 20, 2009 at 11:53:41AM +0100, Alexander Graf wrote: Works great here: ./x86_64-softmmu/qemu-system-x86_64 -nographic -kernel ../bzImage - append console=ttyS0 -L pc-bios Are you sure you also have the follow-up linuxboot patch app

Re: [Qemu-devel] [PATCH 09/17] monitor: Convert do_info_uuid() to QObject

2009-11-20 Thread Markus Armbruster
Luiz Capitulino writes: > The returned QObject is a QString, snprintf() is used because the > UUID_FMT is too complex for qobject_from_jsonf(). If this turns out to be a common problem, we should consider fixing it at the source: qobject_from_jsonf().

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-20 Thread Anthony Liguori
Alexander Graf wrote: Btw, it seems like seabios takes quite a bit longer than pc bios to load the kernel, mostly while the gPXE line is displayed. Yeah, I really wish we could disable gPXE for default boots. Usually nobody wants to -boot n anyways, and if they do they can specify that IMHO.

Re: [Qemu-devel] [PATCH 11/17] block: Convert bdrv_info() to QObject

2009-11-20 Thread Markus Armbruster
Luiz Capitulino writes: > Each block device information is stored in a QDict and the > returned QObject is a QList of all devices. > > This commit should not change user output. > > Signed-off-by: Luiz Capitulino > --- > Makefile |2 +- > block.c | 123 > +++

Re: [Qemu-devel] [PATCH 12/17] char: Convert qemu_chr_info() to QObject

2009-11-20 Thread Markus Armbruster
Luiz Capitulino writes: > Each device is represented by a QDict. The returned QObject is a QList > of all devices. > > This commit should not change user output. > > Signed-off-by: Luiz Capitulino > --- > monitor.c |3 ++- > qemu-char.c | 43 +-- >

Re: [Qemu-devel] [PATCH 13/17] PCI: Convert pci_device_hot_add() to QObject

2009-11-20 Thread Markus Armbruster
Luiz Capitulino writes: > Return a QDict with information about the just added device. > > This commit should not change user output. > > Please, note that this patch does not do error handling > conversion. In error conditions the handler still calls > monitor_printf(). > > Signed-off-by: Luiz C

[Qemu-devel] Re: [PATCH 5/7] qdev: add qdev_foreach()

2009-11-20 Thread Mark McLoughlin
Hi Gerd, Thanks for looking, you're absolutely right that this approach just isn't right with e.g. -device On Mon, 2009-11-16 at 10:28 +0100, Gerd Hoffmann wrote: > On 11/12/09 21:29, Mark McLoughlin wrote: > > No doubt this is the worst idea ever, but the requirement is simple - > > some way to

Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro)

2009-11-20 Thread Jamie Lokier
Stefan Weil wrote: > Jamie Lokier schrieb: > > Stefan Weil wrote: > > > >> Make using mingw32 on windows does not preserve $@ in macros > >> when they are modified using this pattern: > >> target: macro += something > >> > > > > Is it not using GNU Make, or is it some ancient version? > > (

Re: [Qemu-devel] [PATCH] isa: configure serial+parallel by index.

2009-11-20 Thread Markus Armbruster
Gerd Hoffmann writes: > This patch adds a 'index' property to the isa-parallel and isa-serial > devices. This can be used to create devices with the default isa irqs > and ioports by simply specifying the index, i.e. > >-device isa-serial,index=1 > > instead of > >-device isa-serial,ioba

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Anthony Liguori
Jamie Lokier wrote: Anthony Liguori wrote: Markus Armbruster wrote: 3. It falls short of the requirement that clients can easily present a human-readable error description to their human users, regardless of whether they know the error or not. That's just incorrect. We pro

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Anthony Liguori
Markus Armbruster wrote: It's highly likely that for this last case, you'd want generic code to generate this error. Further more, in order to generate the error message for a user, you need to know what device does not have a functioning driver. You may say it's obvious for something like info

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Luiz Capitulino
On Fri, 20 Nov 2009 09:56:46 -0600 Anthony Liguori wrote: > Jamie Lokier wrote: > > Anthony Liguori wrote: > > > >> Markus Armbruster wrote: > >> > >>> 3. It falls short of the requirement that clients can easily present a > >>> human-readable error description to their human users, reg

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Anthony Liguori
Luiz Capitulino wrote: On Fri, 20 Nov 2009 09:56:46 -0600 Anthony Liguori wrote: Jamie Lokier wrote: Anthony Liguori wrote: Markus Armbruster wrote: 3. It falls short of the requirement that clients can easily present a human-readable error description to t

Re: [Qemu-devel] [PATCH 2/9] default devices: core code & serial lines.

2009-11-20 Thread Markus Armbruster
Gerd Hoffmann writes: > Qemu creates a default serial line for you in case you didn't specify > one on the command line. Right now this is tied to the '-serial > ' command line switch, which in turn causes trouble if you are > creating your serial line via '-device isa-serial,'. > > This patch a

Re: [Qemu-devel] [PATCH 3/9] default devices: parallel port

2009-11-20 Thread Markus Armbruster
Gerd Hoffmann writes: > Switch over parallel ports to the new default device system. > > Disable default parallel port for both '-parallel' and '-device > isa-parallel' cases. This feels a bit terse to me. What about a suitably edited copy of PATCH 2/9's message? > > Signed-off-by: Gerd Hoffma

Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro)

2009-11-20 Thread Sebastian Herbszt
Jamie Lokier wrote: Stefan Weil wrote: Make using mingw32 on windows does not preserve $@ in macros when they are modified using this pattern: target: macro += something Is it not using GNU Make, or is it some ancient version? ("make --version" shows the version, if it's GNU Make). -- Jamie

Re: [Qemu-devel] [PATCH 4/9] default devices: monitor

2009-11-20 Thread Markus Armbruster
Gerd Hoffmann writes: > Switch over monitor to the new defaults system. Even terser. > > Signed-off-by: Gerd Hoffmann > --- > vl.c | 90 + > 1 files changed, 46 insertions(+), 44 deletions(-) > > diff --git a/vl.c b/vl.c > inde

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-20 Thread Markus Armbruster
Gerd Hoffmann writes: > Add a greeting string to CharDriverState which is printed after > initialization. Used to have the qemu vc consoles labeled. This > way we can avoid walking all the chardevs a second time after > initialization just to print the greeting. I doubt this would be worthwhil

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Markus Armbruster
Anthony Liguori writes: > Jamie Lokier wrote: >> Anthony Liguori wrote: >> >>> Markus Armbruster wrote: >>> 3. It falls short of the requirement that clients can easily present a human-readable error description to their human users, regardless of whether they know the

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Anthony Liguori
Markus Armbruster wrote: Any particular reason not put it into the error object and be done with it? As long as it's generated and not supplied by the caller of qemu_error_new, I really don't mind. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-20 Thread Paul Brook
On Tuesday 17 November 2009, Gerd Hoffmann wrote: > Add a greeting string to CharDriverState which is printed after > initialization. Used to have the qemu vc consoles labeled. This > way we can avoid walking all the chardevs a second time after > initialization just to print the greeting. I thi

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Markus Armbruster
Anthony Liguori writes: > Luiz Capitulino wrote: >> On Fri, 20 Nov 2009 09:56:46 -0600 >> Anthony Liguori wrote: >> >> >>> Jamie Lokier wrote: >>> Anthony Liguori wrote: > Markus Armbruster wrote: > >> 3. It falls short of the requirement that

[Qemu-devel] Re: SeaBIOS cdrom regression with Vista

2009-11-20 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 12:19:20AM -0500, Kevin O'Connor wrote: > On Tue, Nov 17, 2009 at 03:21:31PM +0200, Avi Kivity wrote: > > qemu-kvm's switch to seabios uncovered a regression with cdrom handling. > > Vista x64 no longer recognizes the cdrom, while pc-bios still works. > > Installing work

[Qemu-devel] [PATCH] slirp: fix use-after-free

2009-11-20 Thread Mark McLoughlin
460fec67ee introduced a use-after free in slirp. Cc: Jan Kiszka Signed-off-by: Mark McLoughlin --- Untested fix, but it's obvious. Also, this is needed on stable-0.11. slirp/mbuf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/slirp/mbuf.c b/slirp/mbuf.c index 765

Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro)

2009-11-20 Thread Stefan Weil
Jamie Lokier schrieb: > Stefan Weil wrote: >> Jamie Lokier schrieb: >>> Stefan Weil wrote: >>> Make using mingw32 on windows does not preserve $@ in macros when they are modified using this pattern: target: macro += something >>> Is it not using GNU Make, or is it some ancient v

Re: [Qemu-devel] Networking hangs

2009-11-20 Thread Scott Tsai
On Fri, Nov 20, 2009 at 6:48 AM, Christoffer Dall wrote: > When I copy files into the guest using SCP, after an undeterministic number > of megabytes have been copied, the network crashes. At this point not even > pings to localhost works inside the guest. I cannot reproduce this with v0.11.0 emu

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster wrote: >>> It's highly likely that for this last case, you'd want generic code to >>> generate this error. Further more, in order to generate the error >>> message for a user, you need to know what device does not have a >>> functioning driver. You ma

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-20 Thread Anthony Liguori
Markus Armbruster wrote: We have: (1) machine-readable error code (2) human-readable error message (3) machine-readable additional error data The old monitor prints just (3). s:(3):(2): You propose to have QMP send (1) and (3). This forces all clients to come up with (2) themselves.

[Qemu-devel] Re: SeaBIOS cdrom regression with Vista

2009-11-20 Thread Kevin O'Connor
On Fri, Nov 20, 2009 at 01:03:51PM -0500, Kevin O'Connor wrote: > I've looked into this, and it looks like the cdrom is left in an odd > state. At this point, I think SeaBIOS is tickling a bug outside of > seabios (eg, in Vista or qemu). I would appreciate it someone with > cdrom knowledge of qem

[Qemu-devel] [PATCH] Fix compile error when LSI_DEBUG is defined

2009-11-20 Thread Ryan Harper
This patch fixes the follow error when LSI_DEBUG is set. CClibhw64/lsi53c895a.o cc1: warnings being treated as errors qemu/hw/lsi53c895a.c: In function 'lsi_io_mapfunc': qemu/hw/lsi53c895a.c:1932: error: format '%08x' expects type 'unsigned int', but argument 2 has type 'pcibus_t' qemu/hw/

Re: [Qemu-devel] Networking hangs

2009-11-20 Thread Christoffer Dall
Thanks for responding. I have made a tar file available with the scripts and images and qemu binary to run my setup: http://www.chazy.dk/downloads/qemu-network-test.tar.gz To produce the error I simply do: # scp r...@192.168.7.2:/root/. The file is approx. 32M large and the network usually cr

[Qemu-devel] [BUG] Displaying VGA framebuffer on SDL does not work correctly

2009-11-20 Thread Stefan Weil
VGA framebuffer shows very strange behaviour with QEMU's SDL display: I run qemu with my harddisk which contains a debian grub2 bootloader. grub2 is configured to display a 1280x1024 png background image (moreblue-orbit-grub.png resized to my monitor resolution). i386-softmmu/qemu /dev/sda -enabl

[Qemu-devel] Re: Issues building seabios

2009-11-20 Thread Kevin O'Connor
On Thu, Nov 19, 2009 at 04:02:06PM +0200, Avi Kivity wrote: > On 11/19/2009 03:39 PM, Kevin O'Connor wrote: >> Long story short - this is the result of gcc's "-combine" being >> fragile. It's possible to avoid by compiling seabios with "make >> COMPSTRAT=1". We may need to change the default. > >

[Qemu-devel] Re: SeaBIOS cdrom regression with Vista

2009-11-20 Thread Kevin O'Connor
On Fri, Nov 20, 2009 at 02:08:03PM -0500, Kevin O'Connor wrote: > On Fri, Nov 20, 2009 at 01:03:51PM -0500, Kevin O'Connor wrote: > > I've looked into this, and it looks like the cdrom is left in an odd > > state. At this point, I think SeaBIOS is tickling a bug outside of > > seabios (eg, in Vist

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-20 Thread Kevin O'Connor
On Sat, Nov 14, 2009 at 02:47:45PM -0500, Kevin O'Connor wrote: > On Thu, Nov 12, 2009 at 01:20:58PM +0200, Naphtali Sprei wrote: > > I've found a problem with the usage of SeaBIOS/gPXE in Qemu. The > > scenario is when failing to boot from network and falling back to > > booting from hard-disk (-

[Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-20 Thread Kevin O'Connor
On Thu, Nov 19, 2009 at 10:30:20PM +0100, Sebastian Herbszt wrote: > i386-softmmu/qemu -M isapc -bios pc-bios/bios.bin Thanks for reporting this. After compiling seabios with CONFIG_DEBUG_SERIAL set in src/config.h and running: qemu -M isapc -serial file:foo I see: Unable to unlock ram - bridg

Re: [Qemu-devel] Networking hangs

2009-11-20 Thread Aurelien Jarno
On Thu, Nov 19, 2009 at 05:48:02PM -0500, Christoffer Dall wrote: > Hi. > > I am experiencing problems with bridged networking to ARM guests. I have > experimented with various kernel versions, distributions and host > machines and I experience the problem in all cases. > > When I copy files in

Re: [Qemu-devel] Networking hangs

2009-11-20 Thread Scott Tsai
On Sat, Nov 21, 2009 at 7:29 AM, Aurelien Jarno wrote: > On Thu, Nov 19, 2009 at 05:48:02PM -0500, Christoffer Dall wrote: >> Hi. >> >> I am experiencing problems with bridged networking to ARM guests. I have >> experimented with various kernel versions, distributions and host >> machines and I ex

[Qemu-devel] [PATCH] Allow build of linuxboot.S with old assemblers

2009-11-20 Thread Juergen Lock
In the spirit of ff56954baf9cfab5cbbe18d10b4a09e4a17f39a8, fix the build of linuxboot.S with old as(1) (as found in some BSD base systems) by emitting the bytes of the insn it doesn't like instead. Signed-off-by: Juergen Lock --- a/pc-bios/optionrom/optionrom.h +++ b/pc-bios/optionrom/optionrom.

[Qemu-devel] [PATCH 1/3] Fix tap breakage on BSD hosts (no IFF_VNET_HDR)

2009-11-20 Thread Juergen Lock
net/tap-bsd.c was assuming IFF_VNET_HDR was always available, which I think isn't true on any BSD. Signed-off-by: Juergen Lock --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -87,6 +87,17 @@ int tap_open(char *ifname, int ifname_si dev = devname(s.st_rdev, S_IFCHR); pstrcpy(ifname, ifname_s

[Qemu-devel] [PATCH 3/3] tap-bsd: handle ifname on FreeBSD hosts

2009-11-20 Thread Juergen Lock
Handle ifname on FreeBSD hosts; if no ifname is given, always start the search from tap0. (Simplified/cleaned up version of what has been in the FreeBSD ports for a long time.) Signed-off-by: Juergen Lock --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -49,11 +49,39 @@ int tap_open(char *ifname, int

[Qemu-devel] [PATCH 0/3] Misc tap fixes found on FreeBSD

2009-11-20 Thread Juergen Lock
Hi! I made another experimental FreeBSD qemu git snapshot port update (see other mail), and came up with these patches when getting tap back to working order again: 1. Fix tap breakage on BSD hosts (no IFF_VNET_HDR) 2. Avoid segfault on net_tap_init() failure 3. tap-bsd: handle ifname on FreeBSD

[Qemu-devel] [PATCH 2/3] Avoid segfault on net_tap_init() failure

2009-11-20 Thread Juergen Lock
Check for fd == -1 there. Signed-off-by: Juergen Lock --- a/net/tap.c +++ b/net/tap.c @@ -400,6 +400,9 @@ int net_init_tap(QemuOpts *opts, Monitor } fd = net_tap_init(opts, &vnet_hdr); +if (fd == -1) { +return -1; +} } s = net_tap_fd_in

[Qemu-devel] FreeBSD qemu-devel git snapshot port update up for testing

2009-11-20 Thread Juergen Lock
Hi! I've made another qemu git snapshot port update, http://people.freebsd.org/~nox/qemu/qemu-devel-20091120.patch or, alternatively, http://people.freebsd.org/~nox/qemu/qemu-devel-20091120.shar and since our emulators/qemu-devel port still is older than the main port (and

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-20 Thread Kevin O'Connor
On Tue, Nov 17, 2009 at 03:23:46PM +0200, Avi Kivity wrote: > On 11/17/2009 04:26 AM, Kevin O'Connor wrote: >> On Mon, Nov 16, 2009 at 04:02:20PM +0200, Avi Kivity wrote: Something that is likely related, I am seeing reboot failures in seabios's pmm_free. Immediately after loading gpxe,