[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Paolo Bonzini
On 11/23/2009 03:17 AM, Anthony Liguori wrote: You mean, each device would have multiple sections? We already use chunks for each device state. If they want to, yes. We only migrate things that are guest visible. Everything else is left to the user to configure. We wouldn't migrate the

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Gerd Hoffmann
On 11/20/09 18:41, Paul Brook wrote: On Tuesday 17 November 2009, Gerd Hoffmann wrote: Add a greeting string to CharDriverState which is printed after initialization. Used to have the qemu vc consoles labeled. This way we can avoid walking all the chardevs a second time after initialization

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Sun, Nov 22, 2009 at 08:17:46PM -0600, Anthony Liguori wrote: Paolo Bonzini wrote: I don't see how this fixes anything. If you used feature bits, how do you migrate from a version that has a feature bit that an older version doesn't know about? Do you just ignore it? I'd go with chunk

[Qemu-devel] [PATCH] isa: serial+parallel: fixup index property.

2009-11-23 Thread Gerd Hoffmann
The index property for both isa-serial and isa-parallel is declared as hex number whereas it should be int. Fix it. --- hw/parallel.c |2 +- hw/serial.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/parallel.c b/hw/parallel.c index 5ae8348..12693d4 100644 ---

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Paolo Bonzini
On 11/23/2009 09:26 AM, Gleb Natapov wrote: I'd go with chunk instead of feature bits, specifying them like in the PNG specification: You mean, each device would have multiple sections? We already use chunks for each device state. Each device can send device info in multiple formats

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 10:29:12AM +0100, Paolo Bonzini wrote: On 11/23/2009 09:26 AM, Gleb Natapov wrote: I'd go with chunk instead of feature bits, specifying them like in the PNG specification: You mean, each device would have multiple sections? We already use chunks for each

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-23 Thread Michael S. Tsirkin
On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. Changes since V2: - Increase stat field size to 64 bits - Report all sizes in kb (not pages) - Drop anon_pages

[Qemu-devel] Re: [PATCH 13/17] PCI: Convert pci_device_hot_add() to QObject

2009-11-23 Thread Michael S. Tsirkin
On Tue, Nov 17, 2009 at 06:32:20PM -0200, Luiz Capitulino wrote: Return a QDict with information about the just added device. This commit should not change user output. Please, note that this patch does not do error handling conversion. In error conditions the handler still calls

[Qemu-devel] Re: [PATCH 5/7] qdev: add qdev_foreach()

2009-11-23 Thread Gerd Hoffmann
On 11/20/09 15:20, Mark McLoughlin wrote: I've pushed a series of patches to the fix-announce-self-rfc.v2 branch on my tree: http://repo.or.cz/w/qemu/markmc.git Looks much better. If you have a special version for nics anyway (qemu_new_nic) you can have that one take a NICConf parameter

Re: [Qemu-devel] [PATCH] isa: serial+parallel: fixup index property.

2009-11-23 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: The index property for both isa-serial and isa-parallel is declared as hex number whereas it should be int. Fix it. Yes, that's much better.

Re: [Qemu-devel] [PATCH] SerialICE - Qemu based (x86) firmware debugger

2009-11-23 Thread JonY
On 11/22/2009 01:15, Stefan Reinauer wrote: Dear x86 hardware and low-level software developers and enthusiasts! coresystems GmbH is glad to finally release SerialICE 1.5, our Integrated Circuit Emulator over Serial. SerialICE (http://www.serialice.com) is a BIOS/Firmware debugging tool. It

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-23 Thread Gerd Hoffmann
On 11/20/09 22:33, H. Peter Anvin wrote: +static const uint16_t isa_debugcon_iobase[MAX_DEBUGCON_PORTS] = { 0xe9 }; Not needed here. +if (isa-index == -1) +isa-index = index; +if (isa-index= MAX_DEBUGCON_PORTS) +return -1; +if (isa-iobase == -1) +

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-23 Thread Dor Laor
On 11/23/2009 11:44 AM, Michael S. Tsirkin wrote: On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. Changes since V2: - Increase stat field size to 64 bits - Report all

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Gleb Natapov
On Sun, Nov 22, 2009 at 12:07:50PM -0500, Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 04:08:53PM +0200, Gleb Natapov wrote: Microsoft SVVP (Server Virtualization Validation Program) expects arbitrary SMBIOS field to have certain values otherwise it fails. We all want to make Microsoft

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Gleb Natapov
On Sun, Nov 22, 2009 at 09:01:45PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 04:31:24PM +0100, Sebastian Herbszt wrote: Bad things could happen if someone modifies the BIOS because it's unprotected (e.g. VM crash). BIOS is reloaded during VM reset.

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Gleb Natapov
On Sun, Nov 22, 2009 at 11:04:34PM +0100, Sebastian Herbszt wrote: Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 05:38:09PM +0200, Gleb Natapov wrote: On Sun, Nov 22, 2009 at 04:31:24PM +0100, Sebastian Herbszt wrote: // Write protect bios memory. make_bios_readonly(); Hmmm. How is

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Gleb Natapov
On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 05:10:53PM +0200, Gleb Natapov wrote: On Sun, Nov 22, 2009 at 04:07:56PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: May be make qemu to map it writable if isapc is specified. I don't

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Gleb Natapov
On Sun, Nov 22, 2009 at 12:40:24PM -0500, Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 05:38:09PM +0200, Gleb Natapov wrote: On Sun, Nov 22, 2009 at 04:31:24PM +0100, Sebastian Herbszt wrote: // Write protect bios memory. make_bios_readonly(); Hmmm. How is tpr patching works

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-23 Thread Vadim Rozenfeld
On 11/23/2009 01:00 PM, Dor Laor wrote: On 11/23/2009 11:44 AM, Michael S. Tsirkin wrote: On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. Changes since V2: -

[Qemu-devel] [PATCHv2][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Gleb Natapov
Microsoft SVVP (Server Virtualization Validation Program) expects arbitrary SMBIOS field to have certain values otherwise it fails. We all want to make Microsoft happy don't we? So lets put values MS expects in there. Values modified by the patch: Type 0: Bit 2 of byte 2 must be 1 Type 1:

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Juan Quintela
Dor Laor dl...@redhat.com wrote: In the last couple of days we discovered some issues regarding stable ABI and the robustness of the live migration protocol. Let's just jump right into it, ordered by complexity: 1. Control *every* feature exposed to the guest by qemu cmdline: While

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 01:25:32PM +0100, Juan Quintela wrote: Gleb Natapov g...@redhat.com wrote: On Sun, Nov 22, 2009 at 08:17:46PM -0600, Anthony Liguori wrote: Paolo Bonzini wrote: I don't see how this fixes anything. If you used feature bits, how do you migrate from a version that

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 01:29:11PM +0100, Juan Quintela wrote: Gleb Natapov g...@redhat.com wrote: On Mon, Nov 23, 2009 at 10:29:12AM +0100, Paolo Bonzini wrote: On 11/23/2009 09:26 AM, Gleb Natapov wrote: I'd go with chunk instead of feature bits, specifying them like in the PNG

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-23 Thread Luiz Capitulino
On Sat, 21 Nov 2009 11:02:41 +0100 Markus Armbruster arm...@redhat.com wrote: Now, what should a client do when it discovers the monitor command it needs to use has grown a new error? Refuse to use the command for fear of having to present a sub-par error message to the user in case it

Re: [Qemu-devel] seabios: missing DMI type 4 entry if -cpu parameter is used

2009-11-23 Thread Gleb Natapov
On Sun, Nov 22, 2009 at 06:05:02PM +0100, Sebastian Herbszt wrote: v0.11.0-rc0-1677: use -cpu pentium and check SMBIOS tables. DMI type 4 entry is missing. Works with Bochs bios. See two problems here. First one in seabios (patch attached). And the second one in QEMU. Why pentium cpu type

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Juan Quintela wrote: Gleb Natapov g...@redhat.com wrote: On Sun, Nov 22, 2009 at 08:17:46PM -0600, Anthony Liguori wrote: Paolo Bonzini wrote: I don't see how this fixes anything. If you used feature bits, how do you migrate from a version that has a feature bit that an older

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-23 Thread Luiz Capitulino
On Sun, 22 Nov 2009 10:08:16 -0600 Anthony Liguori anth...@codemonkey.ws wrote: I'm certainly willing to consider alternative ways to do qmp_error() but taking a free form string is not an option in my mind. It goes against the fundamentals of what we're trying to build with QMP. Agreed.

Re: [Qemu-devel] Re: [RFC v0 00/15] QEMU Monitor Protocol

2009-11-23 Thread Luiz Capitulino
On Sun, 22 Nov 2009 10:04:15 -0600 Anthony Liguori anth...@codemonkey.ws wrote: Luiz Capitulino wrote: { execute: info, arguments: { item: balloon } } {return: 512} { execute: info, arguments: { item: network } } {return: [{devices: [{name: user.0, info: net=10.0.2.0, restricted=n},

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Juan Quintela wrote: Dor Laor dl...@redhat.com wrote: I will go further, and think that this kind of issues should be put into the machine type. I agree. If you start qemu with -M pc-0.10, it should save the state in a 0.10 compatible way (that don't happens at the moment, but it

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-23 Thread Anthony Liguori
Luiz Capitulino wrote: On Sun, 22 Nov 2009 10:08:16 -0600 Anthony Liguori anth...@codemonkey.ws wrote: I'm certainly willing to consider alternative ways to do qmp_error() but taking a free form string is not an option in my mind. It goes against the fundamentals of what we're trying to

Re: [Qemu-devel] [PATCH 11/17] block: Convert bdrv_info() to QObject

2009-11-23 Thread Luiz Capitulino
On Fri, 20 Nov 2009 15:06:26 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Each block device information is stored in a QDict and the returned QObject is a QList of all devices. This commit should not change user output.

Re: [Qemu-devel] [PATCH 12/17] char: Convert qemu_chr_info() to QObject

2009-11-23 Thread Luiz Capitulino
On Fri, 20 Nov 2009 15:10:20 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Paul Brook
On Monday 23 November 2009, Gerd Hoffmann wrote: On 11/20/09 18:41, Paul Brook wrote: On Tuesday 17 November 2009, Gerd Hoffmann wrote: Add a greeting string to CharDriverState which is printed after initialization. Used to have the qemu vc consoles labeled. This way we can avoid

[Qemu-devel] Re: [PATCH 13/17] PCI: Convert pci_device_hot_add() to QObject

2009-11-23 Thread Luiz Capitulino
On Mon, 23 Nov 2009 11:44:57 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Nov 17, 2009 at 06:32:20PM -0200, Luiz Capitulino wrote: Return a QDict with information about the just added device. This commit should not change user output. Please, note that this patch does not

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-23 Thread Luiz Capitulino
On Mon, 23 Nov 2009 07:11:53 -0600 Anthony Liguori anth...@codemonkey.ws wrote: Luiz Capitulino wrote: On Sun, 22 Nov 2009 10:08:16 -0600 Anthony Liguori anth...@codemonkey.ws wrote: I'm certainly willing to consider alternative ways to do qmp_error() but taking a free form

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Paolo Bonzini wrote: On 11/23/2009 03:17 AM, Anthony Liguori wrote: You mean, each device would have multiple sections? We already use chunks for each device state. If they want to, yes. We only migrate things that are guest visible. Everything else is left to the user to configure. We

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-23 Thread Alexander Graf
Am 23.11.2009 um 14:34 schrieb Luiz Capitulino lcapitul...@redhat.com: On Mon, 23 Nov 2009 07:11:53 -0600 Anthony Liguori anth...@codemonkey.ws wrote: Luiz Capitulino wrote: On Sun, 22 Nov 2009 10:08:16 -0600 Anthony Liguori anth...@codemonkey.ws wrote: I'm certainly willing to consider

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Eduardo Habkost
Excerpts from Anthony Liguori's message of Mon Nov 23 00:17:46 -0200 2009: Paolo Bonzini wrote: I don't see how this fixes anything. If you used feature bits, how do you migrate from a version that has a feature bit that an older version doesn't know about? Do you just ignore it? I'd

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: Juan Quintela wrote: Dor Laor dl...@redhat.com wrote: My idea here is that we need to have further use of machine descriptions, once that is done, we need something like a new property for qdev (version?). Once there, each device could do:

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Paolo Bonzini
On 11/23/2009 02:51 PM, Eduardo Habkost wrote: Right, but I wouldn't be surprised if a user complains that I know that my guest don't use that VM feature, so I want to be able to migrate to an older version anyway. That's a bit more tricky. What if the older version doesn't support sound

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 03:09:35PM +0100, Juan Quintela wrote: Gleb Natapov g...@redhat.com wrote: On Mon, Nov 23, 2009 at 01:25:32PM +0100, Juan Quintela wrote: Gleb Natapov g...@redhat.com wrote: On Sun, Nov 22, 2009 at 08:17:46PM -0600, Anthony Liguori wrote: Yes, I proposed to send

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Juan Quintela wrote: Anthony Liguori anth...@codemonkey.ws wrote: Juan Quintela wrote: I'm not at all convinced that you can downgrade the version of a device without exposing a functional change to a guest. In fact, I'm pretty certain that it's provably impossible. Please give

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Gleb Natapov wrote: My problem implementing optional features/sections/... is not the savevm/VMState bits. At the end, implementing that is easy. What is more dificult is once that a device have 5 features, what are the valid combinations. i.e. if you have pci and msix features, msix requires

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Eduardo Habkost wrote: Migration needs to be conservative. There should be only two possible outcomes: 1) a successful live migration or 2) graceful failure with the source VM still running correctly. Silently ignoring things that could affect the guests behavior means that it's possible that

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 08:51:17AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: My problem implementing optional features/sections/... is not the savevm/VMState bits. At the end, implementing that is easy. What is more dificult is once that a device have 5 features, what are the valid

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Paolo Bonzini wrote: On 11/23/2009 02:51 PM, Eduardo Habkost wrote: Right, but I wouldn't be surprised if a user complains that I know that my guest don't use that VM feature, so I want to be able to migrate to an older version anyway. That's a bit more tricky. What if the older version

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Eduardo Habkost
On Mon, Nov 23, 2009 at 03:21:24PM +0100, Paolo Bonzini wrote: On 11/23/2009 02:51 PM, Eduardo Habkost wrote: Right, but I wouldn't be surprised if a user complains that I know that my guest don't use that VM feature, so I want to be able to migrate to an older version anyway. That's a bit

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is unidirectional. As long as qemu can send out all of the data without the stream closing, it will succeed on the source. While this may sound like a bug, it's an impossible problem to solve as it's

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Gerd Hoffmann
On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc. cheers, Gerd

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Eduardo Habkost wrote: The pvclock MSRs are an example: if the guest is not using pvclock, not restoring the MSRs won't make any difference. Strictly speaking, not migrating them is wrong, but the user may argue that they know it won't impact their guest OS, and that they want to take the risk.

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Paul Brook
On Monday 23 November 2009, Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc. That's

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 04:10:48PM +0100, Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Anthony Liguori
Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc. A vc is what renders the for VNC so

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is unidirectional. As long as qemu can send out all of the data without the stream closing, it will succeed on the source. While this may

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Eduardo Habkost
Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009: Juan Quintela wrote: But if you know substitute qemu-0.11 and qemu-0.12 for RHEL5.4 and RHEL5.4.1, you will see that the code bases are going to be really, really similar. And if any savevm format is changed, it is

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Paolo Bonzini
On 11/23/2009 04:22 PM, Gleb Natapov wrote: As far as I remember the two general's problem talks about unreliable channel, not unreliable nodes. Why not having destination send ACK/NACK to the source when it knows that migration succeeded/failed. If source gets NACK it continues, if it gets ACK

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is unidirectional. As long as qemu can send out all of the data without the stream closing, it will succeed

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Eduardo Habkost
On Mon, Nov 23, 2009 at 09:00:05AM -0600, Anthony Liguori wrote: snip I think the problem is that you shouldn't be changing the guest visible state in a stable update of qemu. If you change the guest visible state in a stable update, then you won't be able to support live migration

Re: [Qemu-devel] [PATCH 12/17] char: Convert qemu_chr_info() to QObject

2009-11-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 20 Nov 2009 15:10:20 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit should not

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 09:32:48AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is unidirectional. As long as qemu can send out all of

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 05:01:58PM +0100, Juan Quintela wrote: Anthony Liguori anth...@codemonkey.ws wrote: Gleb Natapov wrote: My problem implementing optional features/sections/... is not the savevm/VMState bits. At the end, implementing that is easy. What is more dificult is once

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-23 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Markus Armbruster wrote: I'm thinking and talking primarily about the protocol, and that probably makes me too terse on implementation. I didn't mean to suggest that for adding the data part we should add new arguments providing the data. That

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:32:48AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Gleb Natapov wrote: According to Anthony this is not a bug. Management has all the means to resolve this situation properly. The bug would be if dst and src both run or both exit. Yup. And they do. If you do the same migration with libvirt, it will fail gracefully with a -1 in the

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Gerd Hoffmann
On 11/23/09 16:20, Anthony Liguori wrote: Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc.

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 10:09:15AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:32:48AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: Then I don't see why Juan claims what

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 21 Nov 2009 11:02:41 +0100 Markus Armbruster arm...@redhat.com wrote: Now, what should a client do when it discovers the monitor command it needs to use has grown a new error? Refuse to use the command for fear of having to present a

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Eduardo Habkost wrote: Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009: Juan Quintela wrote: But if you know substitute qemu-0.11 and qemu-0.12 for RHEL5.4 and RHEL5.4.1, you will see that the code bases are going to be really, really similar. And if any

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Gleb Natapov wrote: I am OK with management being responsible to sort things out. Juan said that destination can't abort migration in the middle, so I pointed out easy solution that will work in 99.999% cases. I think there's something elegant about doing migration in a unidirectional

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Juan Quintela wrote: you can weasel the way you want (I can also do it). Customer had: 5.4 - 5.4 migration working (suboptimally) Now appears 5.4.1 that works best with migration. But he want to do the migration in two steps: migrate from qemu 5.4 - 5.4.1, and be able to migrate back if he

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Eduardo Habkost
Excerpts from Anthony Liguori's message of Mon Nov 23 14:16:39 -0200 2009: Eduardo Habkost wrote: Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009: snip In our own stable branch, we do not introduce any savevm changes. I would recommend the same policy

[Qemu-devel] Re: [PATCHv2][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Paolo Bonzini
On 11/23/2009 01:03 PM, Gleb Natapov wrote: p-bios_characteristics[0] = 0x08; /* BIOS characteristics not supported */ FWIW, I agree with not changing this. From reading the spec, it seems like the characteristics extensions are totally separate from the basic characteristics, and

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Sebastian Herbszt
Gleb Natapov wrote: On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 05:10:53PM +0200, Gleb Natapov wrote: On Sun, Nov 22, 2009 at 04:07:56PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: May be make qemu to map it writable if isapc is

Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Sebastian Herbszt
Gleb Natapov wrote: On Mon, Nov 23, 2009 at 12:57:14AM +0100, Carl-Daniel Hailfinger wrote: On 22.11.2009 18:39, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote: Is the requirement for Targeted Content Delivery specified

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Sebastian Herbszt
Gleb Natapov wrote: On Sun, Nov 22, 2009 at 09:41:26PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 06:39:16PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: Microsoft SVVP

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Eduardo Habkost wrote: That may be good enough for upstream Qemu, but IMO for RHEL it is not a realistic policy. If the definition of guest visible state is buggy on the current implementation, we can't drop entirely the possibility of fixing it on our stable branch. After mulling over it a

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 07:15:55PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 09:41:26PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 06:39:16PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at

Re: [Qemu-devel] seabios: missing DMI type 4 entry if -cpu parameter is used

2009-11-23 Thread Sebastian Herbszt
Gleb Natapov wrote: On Sun, Nov 22, 2009 at 06:05:02PM +0100, Sebastian Herbszt wrote: v0.11.0-rc0-1677: use -cpu pentium and check SMBIOS tables. DMI type 4 entry is missing. Works with Bochs bios. See two problems here. First one in seabios (patch attached). And the second one in QEMU. Why

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Juan Quintela wrote: The problem here isn't migration, it's what you've decided to backport into your stable branch. No. the problem is that I made a mistake in the past. And didn't add a field to the state that I should. It just happens to work without that field in several use cases.

[Qemu-devel] Re: [PATCH 0/3 v5] Live migration without shared storage

2009-11-23 Thread Jan Kiszka
Avi Kivity wrote: On 11/03/2009 11:40 AM, Liran Schour wrote: - Liran Avi Kivitya...@redhat.com wrote on 02/11/2009 20:47:34: On 11/02/2009 03:40 PM, lir...@il.ibm.com wrote: This series adds support for live migration without shared storage, means copy the storage

Re: [Qemu-devel] Re: virtio: Report new guest memory statistics pertinent to memory ballooning (V4)

2009-11-23 Thread Anthony Liguori
Avi Kivity wrote: The new monitor will support async command completion but even then I don't think we should allow a guest to stop command execution indefinitely (it would tie up resources at the client). Well, I think we're going to end up pushing this to 0.13 as we're quickly approaching

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Sebastian Herbszt
Gleb Natapov wrote: On Mon, Nov 23, 2009 at 07:15:55PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 09:41:26PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 06:39:16PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov

Re: [Qemu-devel] [PATCH] Makefile: Add missing rule for config-devices.mak

2009-11-23 Thread Paul Brook
On Sunday 22 November 2009, Stefan Weil wrote: All files config-devices.mak are copies from files in directory default-configs. See commit a992fe3, specifically make defconfig. Paul

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Sebastian Herbszt
Gleb Natapov wrote: On Mon, Nov 23, 2009 at 06:57:47PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 05:10:53PM +0200, Gleb Natapov wrote: On Sun, Nov 22, 2009 at 04:07:56PM +0100, Sebastian Herbszt

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 08:12:32PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Mon, Nov 23, 2009 at 06:57:47PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 05:10:53PM +0200, Gleb Natapov

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Eduardo Habkost
On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote: Eduardo Habkost wrote: That may be good enough for upstream Qemu, but IMO for RHEL it is not a realistic policy. If the definition of guest visible state is buggy on the current implementation, we can't drop entirely the

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 07:48:20PM +0100, Sebastian Herbszt wrote: What about using the vendor provided by CPUID, so it displays the correct value on coreboot and others, and change qemu cpus to a different vendor string like padded QEMU or something. Currently qemu64 uses AMD, kvm64 and

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-23 Thread Gleb Natapov
On Mon, Nov 23, 2009 at 08:19:54PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 09:01:45PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Nov 22, 2009 at 04:31:24PM +0100, Sebastian Herbszt wrote: Bad things could happen if someone modifies the

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-23 Thread Anthony Liguori
Eduardo Habkost wrote: On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote: Eduardo Habkost wrote: That may be good enough for upstream Qemu, but IMO for RHEL it is not a realistic policy. If the definition of guest visible state is buggy on the current implementation, we

[Qemu-devel] [PATCH 01/17] Introduce qemu-objects.h header file

2009-11-23 Thread Luiz Capitulino
An easy way to include all QEMU objects. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-objects.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 qemu-objects.h diff --git a/qemu-objects.h b/qemu-objects.h new file mode

[Qemu-devel] [PATCH 02/17] Makefile: move QObject objs to their own entry

2009-11-23 Thread Luiz Capitulino
Other subsystems will need to link against them. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7843690..35238f5 100644 --- a/Makefile +++ b/Makefile @@ -82,6 +82,11 @@

[Qemu-devel] [PATCH v1 00/17]: info handlers conversions to QObject

2009-11-23 Thread Luiz Capitulino
Hi, This series covers almost half of the info handlers conversions to the QObject style, the other half is a bit more complicated as some handlers can be defined by different machine types. changelog - v0 - v1 - Minor fixes (indentation, casts, etc) - Improved some documentation and

[Qemu-devel] [PATCH 03/17] QDict: Introduce qdict_get_qbool()

2009-11-23 Thread Luiz Capitulino
This is a helper function that does type checking before retrieving a QBool from the dictionary. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile |2 +- qdict.c | 15 +++ qdict.h |1 + 3 files changed, 17 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 04/17] QDict: Introduce qdict_get_qlist()

2009-11-23 Thread Luiz Capitulino
A helper function to get a QList from a QDict. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile |2 +- qdict.c | 13 + qdict.h |2 ++ 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 8b4c4e6..89fbdc6 100644 ---

[Qemu-devel] [PATCH 05/17] monitor: Fix do_info_balloon() output

2009-11-23 Thread Luiz Capitulino
New monitor commands should always return values in bytes. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 3286ba2..e3368c8 100644 --- a/monitor.c +++ b/monitor.c

[Qemu-devel] [PATCH 06/17] monitor: Convert do_info_status() to QObject

2009-11-23 Thread Luiz Capitulino
Return a QString with status information. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 33 +++-- 1 files changed, 27 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index e3368c8..c9104c3 100644 --- a/monitor.c +++

[Qemu-devel] [PATCH 07/17] monitor: Convert do_info_kvm() to QObject

2009-11-23 Thread Luiz Capitulino
Return a QString with kvm status information. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 31 +-- 1 files changed, 25 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index c9104c3..c2e82c8 100644 --- a/monitor.c +++

[Qemu-devel] [PATCH 08/17] monitor: Convert do_info_name() to QObject

2009-11-23 Thread Luiz Capitulino
Return a QString with the current VM name. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index c2e82c8..1540254 100644 --- a/monitor.c +++ b/monitor.c @@ -349,10

[Qemu-devel] [PATCH 09/17] monitor: Convert do_info_hpet() to QObject

2009-11-23 Thread Luiz Capitulino
Return a QString with HPET information. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 1540254..ab21db4 100644 --- a/monitor.c +++ b/monitor.c @@

[Qemu-devel] [PATCH 10/17] monitor: Convert do_info_uuid() to QObject

2009-11-23 Thread Luiz Capitulino
The returned QObject is a QString, snprintf() is used because the UUID_FMT is too complex for qobject_from_jsonf(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c

  1   2   >