[Qemu-devel] [PATCH] eepro100: Better documentation for temporary data

2009-12-14 Thread Stefan Weil
Michael S. Tsirkin suggested more documentation for two temporary status values. Well, here it is. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 22e5bed..5a77409

[FOR 0.12 PATCH] qdev: Improve uni-north device names (was: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace)

2009-12-14 Thread Markus Armbruster
Switch to the names suggested by Blue Swirl. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/unin_pci.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index f07c966..3ae4e7a 100644 --- a/hw/unin_pci.c +++

[Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Gerd Hoffmann
On 12/13/09 21:43, Michael S. Tsirkin wrote: Add features property to virtio. This makes it possible to e.g. define machine without indirect buffer support, which is required for 0.10 compatibility. or without hardware checksum support, which is required for 0.11 compatibility. I'd suggest to

[Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 10:41:26AM +0100, Gerd Hoffmann wrote: On 12/13/09 21:43, Michael S. Tsirkin wrote: Add features property to virtio. This makes it possible to e.g. define machine without indirect buffer support, which is required for 0.10 compatibility. or without hardware checksum

[Qemu-devel] [FOR 0.12 PATCH] Simplify qemu_realloc()

2009-12-14 Thread Markus Armbruster
No functional change. Bonus: looks just like qemu_malloc() now. Signed-off-by: Markus Armbruster arm...@redhat.com --- I tagged this FOR 0.12 because I think you might want to consider it for 0.12, not because I think it must go into 0.12. qemu-malloc.c |8 +++- 1 files changed, 3

[Qemu-devel] Re: [PATCH] s390: Fix buggy assignment

2009-12-14 Thread Alexander Graf
On 14.12.2009, at 10:39, Stefan Weil wrote: nd-model keeps dynamically allocated model names. So casting of a constant string is wrong here. Signed-off-by: Stefan Weil w...@mail.berlios.de So we're wasting 7 bytes of strdup malloc'ed data we never free. Probably now worth thinking about

[Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Gerd Hoffmann
On 12/14/09 10:42, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 10:41:26AM +0100, Gerd Hoffmann wrote: On 12/13/09 21:43, Michael S. Tsirkin wrote: Add features property to virtio. This makes it possible to e.g. define machine without indirect buffer support, which is required for 0.10

[Qemu-devel] Re: -serial stdio broken

2009-12-14 Thread Gerd Hoffmann
On 12/13/09 10:38, Blue Swirl wrote: On Sun, Dec 13, 2009 at 8:24 AM, Blue Swirlblauwir...@gmail.com wrote: I guess e1c09175bc00dd8dfb2ad1b26e1858dcdc109b59 or 998bbd74b9d813b14a3a3b5009a5d5a48c7dce51 broke -serial stdio for all targets: qemu -serial stdio -monitor stdio Oh. It is actually

[Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 11:16:34AM +0100, Gerd Hoffmann wrote: On 12/14/09 10:44, Michael S. Tsirkin wrote: No, it did not even start booting the kernel. Just gave me blank screen. [ testing ] Oh. That is something completely different. A bug in the rom loader. It fails to fit both

[Qemu-devel] [PATCH] Check rom_load_all() return value.

2009-12-14 Thread Gerd Hoffmann
... otherwise we'll continue without the bios loaded in case the option roms don't fit. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- vl.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index c0d98f5..1682808 100644 --- a/vl.c +++ b/vl.c @@ -6031,7

[Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 11:24:41AM +0100, Gerd Hoffmann wrote: On 12/14/09 10:42, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 10:41:26AM +0100, Gerd Hoffmann wrote: On 12/13/09 21:43, Michael S. Tsirkin wrote: Add features property to virtio. This makes it possible to e.g. define

[Qemu-devel] [PATCH] correcting ARM CPSR register bit position comment

2009-12-14 Thread nemesisofstate
From: nemesis neme...@nemesis-laptop.(none) --- target-arm/cpu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 4a1c53f..910604f 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -90,7 +90,7 @@ typedef struct CPUARMState

[Qemu-devel] [FOR 0.12][RESEND][PATCH] kvm: x86: Use separate exception_injected CPUState field

2009-12-14 Thread Jan Kiszka
Marcelo correctly remarked that there are usage conflicts between QEMU core code and KVM /wrt exception_index. So spend a separate field and also save/restore it properly. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- NOTE: This obsoletes the meanwhile merge patch

[Qemu-devel] [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register

2009-12-14 Thread Jan Kiszka
hw_breakpoint_type and hw_breakpoint_len used the wrong index multiplier to extract type and len. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/cpu.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index

Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Alexander Graf
Am 14.12.2009 um 12:10 schrieb Michael S. Tsirkin m...@redhat.com: On Mon, Dec 14, 2009 at 11:24:41AM +0100, Gerd Hoffmann wrote: On 12/14/09 10:42, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 10:41:26AM +0100, Gerd Hoffmann wrote: On 12/13/09 21:43, Michael S. Tsirkin wrote: Add

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Alexander Graf
Am 14.12.2009 um 11:59 schrieb Michael S. Tsirkin m...@redhat.com: On Mon, Dec 14, 2009 at 11:16:34AM +0100, Gerd Hoffmann wrote: On 12/14/09 10:44, Michael S. Tsirkin wrote: No, it did not even start booting the kernel. Just gave me blank screen. [ testing ] Oh. That is something

Re: [Qemu-devel] approaches to 3D virtualisation

2009-12-14 Thread Paul Brook
On Saturday 12 December 2009, Dave Airlie wrote: So I've been musing on the addition of some sort of 3D passthrough for qemu (as I'm sure have lots of ppl) IIUC a typical graphics system consists of several operations: 1) Allocate space for data objects[2] on server[1]. 2) Upload data from

Re: [Qemu-devel] [PATCH] correcting ARM CPSR register bit position comment

2009-12-14 Thread Paul Brook
-uint32_t VF; /* V is the bit 31. All other bits are undefined */ +uint32_t VF; /* V is the bit 28. */ No. The original comment is correct. Paul

Re: [Qemu-devel] Guest bridge setup variations

2009-12-14 Thread Arnd Bergmann
On Friday 11 December 2009, Anthony Liguori wrote: Arnd Bergmann wrote: 3) given an fd, treat a vhost-style interface This could mean two things, not sure which one you mean. Either the file descriptor could be the vhost file descriptor, or the socket or tap file descriptor from

Re: [Qemu-devel] [PATCH] correcting ARM CPSR register bit position comment

2009-12-14 Thread Laurent Desnogues
On Mon, Dec 14, 2009 at 1:07 PM, Paul Brook p...@codesourcery.com wrote: -    uint32_t VF; /* V is the bit 31. All other bits are undefined */ +    uint32_t VF; /* V is the bit 28. */ No. The original comment is correct. And so that the answer is at least a bit useful: these fields are not

[Qemu-devel] [PATCH 03/11] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g

2009-12-14 Thread Isaku Yamahata
To match Linux PCI register definition, rename PCI_SUBVENDOR_ID to PCI_SUBSYSTEM_VENDOR_ID. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c |2 +- hw/pci.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 344d72b..fb03ee2

[Qemu-devel] [PATCH 02/11] pci: clean up pci_bar_address()

2009-12-14 Thread Isaku Yamahata
make pci_bar_address independent of PCI_BAR_UNMAPPED value. PCI_BAR_UNMAPPED could be arbitrary value which doesn't match possible pci bar. So == PCI_BAR_UNMAPPED check is not good. This patch cleans it up. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c |3 +-- 1 files

[Qemu-devel] [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID.

2009-12-14 Thread Isaku Yamahata
There is no user and they're obsolete. So remove them. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index 0309674..91f3809 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -154,9 +154,7 @@

[Qemu-devel] [PATCH 09/11] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM.

2009-12-14 Thread Isaku Yamahata
Define symbolic value in i440fx configuration space for 0x59, 0x5f and 0x7f and use them. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/piix_pci.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index

[Qemu-devel] [PATCH 01/11] pci: remove PCIBus::config_reg.

2009-12-14 Thread Isaku Yamahata
PCIBus::config_reg isn't used anymore, so remove it. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 404eead..aed3a24 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -40,7 +40,6 @@ struct

[Qemu-devel] [PATCH 10/11] piix_pci: use range helper function

2009-12-14 Thread Isaku Yamahata
use range helper function in i440fx_write_config(). Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/piix_pci.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 7bbaf50..304f84a 100644 --- a/hw/piix_pci.c +++

[Qemu-devel] [PATCH 11/11] msix: use range helper function.

2009-12-14 Thread Isaku Yamahata
use range helper function in msix_write_config(). Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/msix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 0baedef..2ca0900 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -175,7 +175,7 @@

[Qemu-devel] [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config().

2009-12-14 Thread Isaku Yamahata
They call only pci_default_{read, write}_config(). So they aren't necessary. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/gt64xxx.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c index fb7f5bd..c8034e2 100644 ---

[Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 12:37:29PM +0100, Gerd Hoffmann wrote: On 12/14/09 12:10, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 11:24:41AM +0100, Gerd Hoffmann wrote: for block: if (strcmp(s-serial_str, 0)) features |= 1 VIRTIO_BLK_F_IDENTIFY; if

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 12:55:28PM +0100, Alexander Graf wrote: Am 14.12.2009 um 11:59 schrieb Michael S. Tsirkin m...@redhat.com: On Mon, Dec 14, 2009 at 11:16:34AM +0100, Gerd Hoffmann wrote: On 12/14/09 10:44, Michael S. Tsirkin wrote: No, it did not even start booting the kernel. Just

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Alexander Graf
Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 12:55:28PM +0100, Alexander Graf wrote: Am 14.12.2009 um 11:59 schrieb Michael S. Tsirkin m...@redhat.com: On Mon, Dec 14, 2009 at 11:16:34AM +0100, Gerd Hoffmann wrote: On 12/14/09 10:44, Michael S. Tsirkin wrote:

[Qemu-devel] Re: [PATCH 02/11] pci: clean up pci_bar_address()

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 09:48:17PM +0900, Isaku Yamahata wrote: make pci_bar_address independent of PCI_BAR_UNMAPPED value. PCI_BAR_UNMAPPED could be arbitrary value which doesn't match possible pci bar. So == PCI_BAR_UNMAPPED check is not good. This patch cleans it up. Signed-off-by: Isaku

[Qemu-devel] Re: [PATCH 03/11] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 09:48:18PM +0900, Isaku Yamahata wrote: To match Linux PCI register definition, rename PCI_SUBVENDOR_ID to PCI_SUBSYSTEM_VENDOR_ID. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Acked-by: Michael S. Tsirkin m...@redhat.com --- hw/pci.c |2 +- hw/pci.h

[Qemu-devel] Re: [PATCH 06/11] pci: use pci_regs.h

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 09:48:21PM +0900, Isaku Yamahata wrote: include pci_regs.h and remove duplicated defines. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Good stuff. Acked-by: Michael S. Tsirkin m...@redhat.com --- hw/pci.h | 72

[Qemu-devel] Re: [PATCH 08/11] acpi: use range helper function.

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 09:48:23PM +0900, Isaku Yamahata wrote: use range helper function in pm_write_config(). Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Acked-by: Michael S. Tsirkin m...@redhat.com --- hw/acpi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] Re: [PATCH 09/11] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM.

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 09:48:24PM +0900, Isaku Yamahata wrote: Define symbolic value in i440fx configuration space for 0x59, 0x5f and 0x7f and use them. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Good overall. Can you pls verify that applying this patch generates same binary as

[Qemu-devel] Re: [PATCH 10/11] piix_pci: use range helper function

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 09:48:25PM +0900, Isaku Yamahata wrote: use range helper function in i440fx_write_config(). Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/piix_pci.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/piix_pci.c

Re: [Qemu-devel] Spice project is now open

2009-12-14 Thread Gerd Hoffmann
Hi, Well, in fact VNC would wait for the refresh timer of the VGA framebuffer dirty thing and only send a single update too. Well, it isn't that simple. When copyrect is used updates can be *much* more frequently. Reason is that the vnc server has to push out outstanding dirty regions

[Qemu-devel] Re: [PATCH 00/11] various pci clean ups.

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 09:48:15PM +0900, Isaku Yamahata wrote: This patch series is for various somewhat atrandom clean up. Michael, this patch series possibly conflicts with your cleanups. Which patch should I rebase to? My tree is here:

Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 02:30:19PM +0100, Markus Armbruster wrote: Gerd Hoffmann kra...@redhat.com writes: On 12/14/09 12:10, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 11:24:41AM +0100, Gerd Hoffmann wrote: for block: if (strcmp(s-serial_str, 0)) features |= 1

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 02:35:31PM +0100, Alexander Graf wrote: Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 12:55:28PM +0100, Alexander Graf wrote: Am 14.12.2009 um 11:59 schrieb Michael S. Tsirkin m...@redhat.com: On Mon, Dec 14, 2009 at 11:16:34AM +0100, Gerd Hoffmann

[Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-14 Thread Anthony Liguori
The QEMU team is pleased to announce the availability of the 0.12.0-rc2 release. This is the second release candidate for the 0.12.0 release. This release is not intended for production use. Testing release candidates is a great way to contribute to QEMU and improve the quality of the 0.12.0

Re: [Qemu-devel] X support for QXL and SPICE

2009-12-14 Thread Gerd Hoffmann
On 12/12/09 00:58, Soeren Sandmann wrote: Even this simple support provides a better user experience than VNC because scrolling is accelerated and doesn't result in a huge bitmap getting sent across the wire. (I don't know if VNC has support for bltblt, but even if it does, a screenscraping VNC

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Anthony Liguori
The old behavior with two different nic types and -boot n was undefined. The old etherboot roms were quite large. To large to fit more than one (certainly not two). How does real hw handle this? I'm pretty sure most servers these days use more option rom space than this. They usually have

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Anthony Liguori
Alexander Graf wrote: Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 12:55:28PM +0100, Alexander Graf wrote: Am 14.12.2009 um 11:59 schrieb Michael S. Tsirkin m...@redhat.com: On Mon, Dec 14, 2009 at 11:16:34AM +0100, Gerd Hoffmann wrote: On

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Anthony Liguori
Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and won't be able to recover. I don't quite understand this. In 0.11, we never loaded option roms unless a user specified

Re: [Qemu-devel] vmware vga + kvm interaction

2009-12-14 Thread Anthony Liguori
Dave Airlie wrote: I actually reinvented at least one of the patches locally and it didn't seem to help, but I'll try and take a closer look today, http://repo.or.cz/w/qemu/aliguori-queue.git vmware-vga-for-dave Is the local branch I have for vmware-vga work. I'm not sure why I never

Re: [Qemu-devel] Spice project is now open

2009-12-14 Thread Anthony Liguori
Gerd Hoffmann wrote: Hi, Well, in fact VNC would wait for the refresh timer of the VGA framebuffer dirty thing and only send a single update too. Well, it isn't that simple. When copyrect is used updates can be *much* more frequently. Reason is that the vnc server has to push out

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Gerd Hoffmann
On 12/12/09 23:35, Dor Laor wrote: 2. VDI (Virtual Desktop Interface) http://www.spice-space.org/vdi.html It's an abstraction layer for graphics/keyboard/mouse/sound /usb/serial. We need it anyway regardless of spice. What is our user like to switch from vnc to SDL on runtime? It's good for

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Anthony Liguori
Gerd Hoffmann wrote: On 12/12/09 23:35, Dor Laor wrote: 2. VDI (Virtual Desktop Interface) http://www.spice-space.org/vdi.html It's an abstraction layer for graphics/keyboard/mouse/sound /usb/serial. We need it anyway regardless of spice. What is our user like to switch from vnc to SDL on

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Gerd Hoffmann
On 12/14/09 15:10, Anthony Liguori wrote: The old behavior with two different nic types and -boot n was undefined. The old etherboot roms were quite large. To large to fit more than one (certainly not two). Two worked with the etherboot roms. So there must be some way to just have more

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Avi Kivity
On 12/14/2009 04:42 PM, Anthony Liguori wrote: I think it's a bit trickier though because ideally you would want to use the vnc protocol to negotiate which vm you're connecting to. Right, of course. If the client can no longer choose the target using its port number, it has to select it in

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Anthony Liguori
Gerd Hoffmann wrote: On 12/14/09 15:10, Anthony Liguori wrote: The old behavior with two different nic types and -boot n was undefined. The old etherboot roms were quite large. To large to fit more than one (certainly not two). Two worked with the etherboot roms. Yes, they were 32k. Two

Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Gerd Hoffmann
On 12/14/09 14:59, Michael S. Tsirkin wrote: It's not an easy quesiton. If we do it as disable bits, then we get incompatible machines when running on different hosts. In case that one host supports feature which the other doesn't and the feature isn't masked out? Well, management failure

[Qemu-devel] [FOR 0.12 PATCH v2] Check rom_load_all() return value.

2009-12-14 Thread Gerd Hoffmann
Check rom_load_all() return value. Also don't make option rom loading failure fatal. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/loader.c |2 +- vl.c|5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index 2d7a2c4..89491a2

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Daniel P. Berrange
On Mon, Dec 14, 2009 at 08:42:12AM -0600, Anthony Liguori wrote: Avi Kivity wrote: On 12/13/2009 01:46 AM, Anthony Liguori wrote: Dan Berrange and I have been talking about being able to move VNC server into a central process such that all of the VMs can have a single VNC port that can be

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Daniel P. Berrange
On Mon, Dec 14, 2009 at 04:53:07PM +0200, Avi Kivity wrote: On 12/14/2009 04:42 PM, Anthony Liguori wrote: I think it's a bit trickier though because ideally you would want to use the vnc protocol to negotiate which vm you're connecting to. Right, of course. If the client can no longer

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Avi Kivity
On 12/14/2009 05:17 PM, Daniel P. Berrange wrote: Yes - need to pass the encryption state. Hopefully the crypto stacks support this. There's no mechanism for this in the SASL libraries. With GNUTLS there is the ability to preserve negotiated session state from one TLS conenection and

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Anthony Liguori
Avi Kivity wrote: On 12/14/2009 05:17 PM, Daniel P. Berrange wrote: Yes - need to pass the encryption state. Hopefully the crypto stacks support this. There's no mechanism for this in the SASL libraries. With GNUTLS there is the ability to preserve negotiated session state from one

Re: [Qemu-devel] Qemu terminating with SIGABRT

2009-12-14 Thread David S. Ahern
I'm using a variant of the KVM source from RHEL5 plus a few cherry-picked patches. Host OS is RHEL 5.3. The servers are using E5540 or E5504 processors. The host OS is running from a small USB key, and there is no place to write a core file. Other accommodations have to be made to get it.

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Anthony Liguori
Avi Kivity wrote: You can still implement this with SCM_RIGHTS. Authenticate, select guest, drop tls, pass fd to qemu, authenticate, hack hack hack, drop tls, pass fd back to proxy, goto 10. Here's how I'd envision this working. Start qemu with: qemu -vnc proxy:/path/to/unix/domain/socket

[Qemu-devel] Re: [PATCH] Seabios: Fix PkgLength calculation for the SSDT.

2009-12-14 Thread Magnus Christensson
On 12/13/2009 04:14 PM, Kevin O'Connor wrote: - Forwarded message from Gleb Natapovg...@redhat.com - From: Gleb Natapovg...@redhat.com To: Kevin O'Connorke...@koconnor.net Date: Sun, 13 Dec 2009 15:18:08 +0200 Subject: Re: [...@virtutech.com: [coreboot] [PATCH] Seabios: Fix PkgLength

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 08:25:53AM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and won't be able to recover. I don't quite

Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 04:01:33PM +0100, Gerd Hoffmann wrote: On 12/14/09 14:59, Michael S. Tsirkin wrote: It's not an easy quesiton. If we do it as disable bits, then we get incompatible machines when running on different hosts. In case that one host supports feature which the other

[Qemu-devel] Re: -serial stdio broken

2009-12-14 Thread Blue Swirl
On Mon, Dec 14, 2009 at 10:55 AM, Gerd Hoffmann kra...@redhat.com wrote: On 12/13/09 10:38, Blue Swirl wrote: On Sun, Dec 13, 2009 at 8:24 AM, Blue Swirlblauwir...@gmail.com  wrote: I guess e1c09175bc00dd8dfb2ad1b26e1858dcdc109b59 or 998bbd74b9d813b14a3a3b5009a5d5a48c7dce51 broke -serial

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-14 Thread Blue Swirl
On Mon, Dec 14, 2009 at 4:20 PM, Anthony Liguori aligu...@linux.vnet.ibm.com wrote: Artyom Tarasenko wrote: 2009/12/14 Anthony Liguori aligu...@linux.vnet.ibm.com: The current plan is to release 0.12.0 on Friday, Dec 18th.  Depending on the severity of bug fixes we get between now and

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-14 Thread Avi Kivity
On 12/14/2009 04:06 PM, Anthony Liguori wrote: The QEMU team is pleased to announce the availability of the 0.12.0-rc2 release. This is the second release candidate for the 0.12.0 release. This release is not intended for production use. I'm missing the tag for this release? -- error

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Glauber Costa
On Mon, Dec 14, 2009 at 04:01:43PM +0200, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 02:35:31PM +0100, Alexander Graf wrote: Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 12:55:28PM +0100, Alexander Graf wrote: Am 14.12.2009 um 11:59 schrieb Michael S. Tsirkin

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Glauber Costa
On Mon, Dec 14, 2009 at 04:11:43PM +0200, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 08:11:59AM -0600, Anthony Liguori wrote: Alexander Graf wrote: Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 12:55:28PM +0100, Alexander Graf wrote: Am 14.12.2009 um 11:59 schrieb

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Glauber Costa
On Mon, Dec 14, 2009 at 08:22:12AM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: Well I am pretty sure that I used virtio + e1000 with 0.11 and apparently I can't now. So it does look like a regression to me ... That's what I said, we should make sure that we stop loading roms

[Qemu-devel] Re: -serial stdio broken

2009-12-14 Thread Gerd Hoffmann
It looks like vl.c was a poor place to do the mux choice. I just wonder why mux option can't be automatically enabled for stdio in qemu-char.c:qemu_chr_parse_compat() or somewhere nearby. The mux driver grabs the 'Ctrl-a' hotkey, so I wouldn't enable that unconditionally because the chardev

Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Gerd Hoffmann
On 12/14/09 17:23, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 04:01:33PM +0100, Gerd Hoffmann wrote: So how do you do this? Assume we have -disable_hw_csum. We want new machine type to have it off, right? But now you run qemu on host which does not support hw_csum. With your suggestion it

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-14 Thread Anthony Liguori
Avi Kivity wrote: On 12/14/2009 04:06 PM, Anthony Liguori wrote: The QEMU team is pleased to announce the availability of the 0.12.0-rc2 release. This is the second release candidate for the 0.12.0 release. This release is not intended for production use. I'm missing the tag for this

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Mark McLoughlin
On Mon, 2009-12-14 at 15:10 +, Daniel P. Berrange wrote: The model I had in mind was for the proxy to define a VNC extension that allows the client to query what 'desktops' are available and request switching between them at any time. The list of desktop would of course be authorized per

[Qemu-devel] target-alpha: An approach to fp insn qualifiers

2009-12-14 Thread Richard Henderson
One of the other folks here (I'm sorry, I've forgotten who as I misplaced the mail) passed me a preliminary patch to tackle the missing fp rounding mode support. That patch added helpers to change the rounding mode, and injected them before and after every fp insn that forced a rounding mode.

Re: [Qemu-devel] RFC: exit on incoming exec migrate failure

2009-12-14 Thread Andrew Farmer
On 11 Dec 2009, at 13:19, Daniel P. Berrange wrote: On Wed, Dec 09, 2009 at 01:10:18PM -0800, Andrew Farmer wrote: Right now, if an incoming migrate through exec fails, the qemu process will end up chewing CPU indefinitely - it looks like it closes the migration FD but doesn't remove its IO

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Sebastian Herbszt
Anthony Liguori wrote: Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and won't be able to recover. I don't quite understand this. In 0.11, we never loaded option roms

Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 06:18:29PM +0100, Gerd Hoffmann wrote: On 12/14/09 17:23, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 04:01:33PM +0100, Gerd Hoffmann wrote: So how do you do this? Assume we have -disable_hw_csum. We want new machine type to have it off, right? But now you run

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 08:12:48PM +0100, Sebastian Herbszt wrote: Anthony Liguori wrote: Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and won't be able to recover.

[Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 12:37:29PM +0100, Gerd Hoffmann wrote: On 12/14/09 12:10, Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 11:24:41AM +0100, Gerd Hoffmann wrote: for block: if (strcmp(s-serial_str, 0)) features |= 1 VIRTIO_BLK_F_IDENTIFY; if

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Anthony Liguori
Sebastian Herbszt wrote: Anthony Liguori wrote: Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and won't be able to recover. I don't quite understand this. In 0.11,

[Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Michael S. Tsirkin
Hi! I have a linux guest where init crashes during boot with invalid opcode error with kernel 2.6.31, but works fine with kernel 2.6.32. It also works fine even with 2.6.31 with qemu-kvm. With Gleb's help, we figured out that the opcode in question is syscall, which is unsupported by hardware on

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Sebastian Herbszt
Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 08:12:48PM +0100, Sebastian Herbszt wrote: Anthony Liguori wrote: Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Anthony Liguori
Michael S. Tsirkin wrote: Hi! I have a linux guest where init crashes during boot with invalid opcode error with kernel 2.6.31, but works fine with kernel 2.6.32. It also works fine even with 2.6.31 with qemu-kvm. With Gleb's help, we figured out that the opcode in question is syscall, which is

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 01:33:50PM -0600, Anthony Liguori wrote: Sebastian Herbszt wrote: Anthony Liguori wrote: Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and won't

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 01:44:22PM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: Hi! I have a linux guest where init crashes during boot with invalid opcode error with kernel 2.6.31, but works fine with kernel 2.6.32. It also works fine even with 2.6.31 with qemu-kvm. With Gleb's

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Anthony Liguori
Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 01:44:22PM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: Hi! I have a linux guest where init crashes during boot with invalid opcode error with kernel 2.6.31, but works fine with kernel 2.6.32. It also works fine even with

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Anthony Liguori
Michael S. Tsirkin wrote: At some level this is wrong. ROM presence is a hardware feature and you definitely need to select your hardware when you create a VM. For real hardware, cards with PXE are sometimes more expensive than without as they need ROM memory. People do select hardware based

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Gleb Natapov
On Mon, Dec 14, 2009 at 01:57:29PM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: On Mon, Dec 14, 2009 at 01:44:22PM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: Hi! I have a linux guest where init crashes during boot with invalid opcode error with kernel 2.6.31, but

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Sebastian Herbszt
Anthony Liguori wrote: Sebastian Herbszt wrote: Anthony Liguori wrote: Michael S. Tsirkin wrote: Further, we should error out when device is added. Doing this during boot is way too late, management won't be able to understand such errors and won't be able to recover. I don't quite

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Anthony Liguori
Gleb Natapov wrote: I thought KVM emulates the syscall instruction? I swear I've seen patches for that. It is. Starting from 2.6.32. Okay, so this is a performance vs. migration compatibility issue then? BTW, couldn't we just not advertise syscall in cpuid? That should fix it too

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Gleb Natapov
On Mon, Dec 14, 2009 at 02:02:03PM -0600, Anthony Liguori wrote: Gleb Natapov wrote: I thought KVM emulates the syscall instruction? I swear I've seen patches for that. It is. Starting from 2.6.32. Okay, so this is a performance vs. migration compatibility issue then? BTW, couldn't we

Re: [Qemu-devel] target-alpha: An approach to fp insn qualifiers

2009-12-14 Thread Laurent Desnogues
On Mon, Dec 14, 2009 at 7:02 PM, Richard Henderson r...@twiddle.net wrote: One of the other folks here (I'm sorry, I've forgotten who as I misplaced the mail) passed me a preliminary patch to tackle the missing fp rounding mode support.  That patch added helpers to change the rounding mode, and

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 02:02:03PM -0600, Anthony Liguori wrote: Gleb Natapov wrote: I thought KVM emulates the syscall instruction? I swear I've seen patches for that. It is. Starting from 2.6.32. Okay, so this is a performance vs. migration compatibility issue then? BTW,

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 10:08:38PM +0200, Gleb Natapov wrote: On Mon, Dec 14, 2009 at 02:02:03PM -0600, Anthony Liguori wrote: Gleb Natapov wrote: I thought KVM emulates the syscall instruction? I swear I've seen patches for that. It is. Starting from 2.6.32. Okay, so this is a

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Anthony Liguori
Michael S. Tsirkin wrote: This might help 32 bit guests, but not guests with 64 bit kernel and 32 bit userspace (my case) because all 64 bit CPUs advertise syscall bit in cpuid. Thus 64 bit guests do not seem to even bother checking this bit: AMD + 64 bit - syscall. Okay, I don't see a

[Qemu-devel] [PATCH] vnc: hextile: do not generate ForegroundSpecified and SubrectsColoured tiles

2009-12-14 Thread Anthony Liguori
This violates the RFB specification (section 6.6.4). It happens to work with most clients but it's still wrong. Reported-by: Yaniv Kaul yk...@redhat.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- vnchextile.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 01:59:47PM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: At some level this is wrong. ROM presence is a hardware feature and you definitely need to select your hardware when you create a VM. For real hardware, cards with PXE are sometimes more expensive than

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 02:18:33PM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: This might help 32 bit guests, but not guests with 64 bit kernel and 32 bit userspace (my case) because all 64 bit CPUs advertise syscall bit in cpuid. Thus 64 bit guests do not seem to even bother

Re: [Qemu-devel] Re: qdev property bug?

2009-12-14 Thread Sebastian Herbszt
Gerd Hoffmann wrote: On 12/14/09 21:20, Michael S. Tsirkin wrote: So far, it's not clear to me that anyone has demonstrated how this is harmful for people that don't want pxe booting. Assuming we fix the bug about rom loading, then there's really no impact to users. Fix (v2) is on the list

  1   2   >