Re: [Qemu-devel] [PATCH] Workaround for broken OSS_GETVERSION on FreeBSD, part two

2010-01-09 Thread malc
; > #ifdef USE_DSP_POLICY > if (ioctl (fd, OSS_GETVERSION, &version)) { > +#ifdef __FreeBSD__ > +/* > + * Looks like atm (20100109) FreeBSD knows OSS_GETVERSION > + * since 7.x, but currently only on the mixer device (or in > + * the Linuxolat

[Qemu-devel] [PATCH] Workaround for broken OSS_GETVERSION on FreeBSD, part two

2010-01-09 Thread Juergen Lock
Juergen Lock --- a/audio/ossaudio.c +++ b/audio/ossaudio.c @@ -289,8 +289,25 @@ static int oss_open (int in, struct oss_ #ifdef USE_DSP_POLICY if (ioctl (fd, OSS_GETVERSION, &version)) { +#ifdef __FreeBSD__ +/* +* Looks like atm (20100109) FreeBSD knows OS

Re: [Qemu-devel] [PATCH] Fix build if OSS_GETVERSION is not defined

2010-01-09 Thread Juergen Lock
On Sat, Jan 09, 2010 at 03:03:43PM +0100, Andreas Färber wrote: > > Am 09.01.2010 um 14:45 schrieb Juergen Lock: > > > On Sat, Jan 09, 2010 at 12:33:44AM +0300, malc wrote: > >> On Fri, 8 Jan 2010, Juergen Lock wrote: > >> > >>> And also I forgot to say this is stable-0.12 material too. > >> > >>

Re: [Qemu-devel] [PATCH] Fix build if OSS_GETVERSION is not defined

2010-01-09 Thread Andreas Färber
Am 09.01.2010 um 14:45 schrieb Juergen Lock: On Sat, Jan 09, 2010 at 12:33:44AM +0300, malc wrote: On Fri, 8 Jan 2010, Juergen Lock wrote: And also I forgot to say this is stable-0.12 material too. You really should talk to the people who know what that means :) Oh sorry I should have gu

Re: [Qemu-devel] [PATCH] Fix build if OSS_GETVERSION is not defined

2010-01-09 Thread Juergen Lock
On Sat, Jan 09, 2010 at 12:33:44AM +0300, malc wrote: > On Fri, 8 Jan 2010, Juergen Lock wrote: > > > On Fri, Jan 08, 2010 at 11:27:13AM +0300, malc wrote: > > > On Thu, 7 Jan 2010, Juergen Lock wrote: > > > > > > > In this case it was missing on FreeBSD <= 6.x (Which also doesn't have > > > > S