[Qemu-devel] [PATCH 4/4] Try not to exceed max downtime on stage3

2010-01-11 Thread Liran Schour
Move to stage3 only when remaining work can be done below max downtime. To make sure the process will converge we will try only MAX_DIRTY_ITERATIONS. Signed-off-by: Liran Schour --- block-migration.c | 67 +++- 1 files changed, 45 insertions(+),

[Qemu-devel] [PATCH 2/4] Tranfer dirty blocks during iterative phase

2010-01-11 Thread Liran Schour
Start transfer dirty blocks during the iterative stage. That will reduce the time that the guest will be suspended Signed-off-by: Liran Schour --- block-migration.c | 158 +++-- 1 files changed, 116 insertions(+), 42 deletions(-) diff --git a/blo

[Qemu-devel] [PATCH 0/4] Reduce down time during migration without shared storage

2010-01-11 Thread Liran Schour
This series of patches reduce the down time of the guest during a migration without shared storage. It does that by start transfer dirty blocks in the iterative phase. In the current code transferring of dirty blocks begins only during the full phase while the guest is suspended. Therefore the gu

[Qemu-devel] [PATCH 3/4] Count dirty blocks and expose an API to get dirty count

2010-01-11 Thread Liran Schour
This will manage dirty counter for each device and will allow to get the dirty counter from above. Signed-off-by: Liran Schour --- block.c | 20 block.h |1 + block_int.h |1 + 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/block.c b/block.

[Qemu-devel] [PATCH 1/4] Remove unused code

2010-01-11 Thread Liran Schour
blk_mig_save_bulked_block is never called with sync flag. Remove the sync flag. Calculate bulk completion during blk_mig_save_bulked_block. Signed-off-by: Liran Schour --- block-migration.c | 63 1 files changed, 24 insertions(+), 39 deletio

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: > >diff --git a/target-i386/kvm.c b/target-i386/kvm.c > >index 4084503..6a841de 100644 > >--- a/target-i386/kvm.c > >+++ b/target-i386/kvm.c > >@@ -17,6 +17,7 @@ > > #include > > > > #in

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Amit Shah
On (Mon) Jan 11 2010 [23:33:56], Jamie Lokier wrote: > Amit Shah wrote: > > > Are you talking about a VNC protocol command between qemu's VNC server > > > and the user's VNC client, or a private protocol between the guest and > > > qemu's VNC server? > > > > What happens is: > > > > 1. Guest puts

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Amit Shah
On (Mon) Jan 11 2010 [18:28:52], Anthony Liguori wrote: >>> >>> I would think that any buffering should be pushed back to the guest. >>> IOW, if there's available data from the char driver, but the guest >>> doesn't have a buffer. Don't select on the char driver until the guest >>> has a buffer av

Re: [Qemu-devel] [PATCH V12 00/27] split out piix specific part from pc emulator and some clean ups

2010-01-11 Thread Isaku Yamahata
Hi Anthony. Although I know that you're busy catching up the holidays, what's the status of this patch series? It looks like that you've committed patches which conflicts with it, so what can I do with this patch series to make your merge easier? thanks, On Wed, Jan 06, 2010 at 11:39:24AM +0900,

Re: [Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2010-01-11 Thread Jamie Lokier
Gleb Natapov wrote: > On Sun, Dec 20, 2009 at 09:28:34AM -0600, Anthony Liguori wrote: > > Gleb Natapov wrote: > > >On Sun, Dec 20, 2009 at 09:11:18AM -0600, Anthony Liguori wrote: > > >>Gleb Natapov wrote: > > >>>On Sun, Dec 20, 2009 at 08:58:40AM -0600, Anthony Liguori wrote: > > No. You hav

[Qemu-devel] RE: [ANNOUNCE] KVM developer conference call

2010-01-11 Thread Xin, Xiaohui
Hi, Chris We are interested in joining the conference, since we are now working on the zero copy patch based on vhost-net. Thanks Xiaohui -Original Message- From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of Chris Wright Sent: Tuesday, January 12, 2010 10:16

[Qemu-devel] KVM call agenda for Jan 12

2010-01-11 Thread Chris Wright
Please send in any agenda items you are interested in covering. 1) administrivia 2) qemu 0.13 kvm feature merge issues 3) vhost-net todo's

[Qemu-devel] [ANNOUNCE] KVM developer conference call

2010-01-11 Thread Chris Wright
The KVM project is announcing a regular conference call focused on KVM development issues. The call will take place weekly on Tuesdays at 15:00 UTC for 1 hour. The purpose of the call is to discuss relevant development issues in a high bandwidth forum, certainly _not_ meant to supplant discussion

Re: [Qemu-devel] [PATCH 1/5] lsi: use QTAILQ for lsi_queue

2010-01-11 Thread Anthony Liguori
On 01/06/2010 10:08 AM, Gerd Hoffmann wrote: Replace the funky array logic for queued commands with standard qemu list functions. Also rename lsi_queue to lsi_request. Signed-off-by: Gerd Hoffmann Applied all. Thanks. Regards, Anthony Liguori --- hw/lsi53c895a.c | 68 +

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Anthony Liguori
On 01/11/2010 02:39 AM, Amit Shah wrote: On (Fri) Jan 08 2010 [10:26:59], Anthony Liguori wrote: On 01/08/2010 07:35 AM, Jamie Lokier wrote: Sometimes it looks like TCP is maintaining write boundaries, but it is just an artifact of its behaviour on many systems, and is not reliable ev

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Anthony Liguori
On 01/11/2010 05:33 PM, Jamie Lokier wrote: Amit Shah wrote: Are you talking about a VNC protocol command between qemu's VNC server and the user's VNC client, or a private protocol between the guest and qemu's VNC server? What happens is: 1. Guest puts something on its clipboard 2.

Re: [Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Anthony Liguori
On 01/11/2010 06:04 PM, Luiz Capitulino wrote: As async messages were one of the reasons for having QMP, I thought that there was a consensus that making it part of the "original" protocol was ok, meaning that they would be always available. That's the only reason. Right, but then it'

Re: [Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Luiz Capitulino
On Mon, 11 Jan 2010 12:57:15 -0600 Anthony Liguori wrote: > On 01/11/2010 12:34 PM, Luiz Capitulino wrote: > > Hi. > > > > We (Markus and I) are working on getting QMP forward compatibility > > support, > > supported. :) > > > > We have a plan for it and I'd like to ask the CC'ed people to

Re: [Qemu-devel] [PATCH] raw-posix: Detect CDROM via ioctl

2010-01-11 Thread Cole Robinson
On 01/11/2010 06:13 PM, Simon Horman wrote: > On Mon, Jan 11, 2010 at 01:30:18PM -0500, Cole Robinson wrote: >> Current CDROM detection is hardcoded based on source file name. >> Make this smarter by attempting a CDROM specific ioctl. >> >> This makes '-cdrom /dev/sr0' succeed with no media present

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Jamie Lokier
Amit Shah wrote: > > Are you talking about a VNC protocol command between qemu's VNC server > > and the user's VNC client, or a private protocol between the guest and > > qemu's VNC server? > > What happens is: > > 1. Guest puts something on its clipboard > 2. An agent on the guest gets notified

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Jan Kiszka
Anthony Liguori wrote: > On 01/11/2010 02:40 PM, Jan Kiszka wrote: >> Anthony Liguori wrote: >> >>> On 01/07/2010 10:24 AM, Gleb Natapov wrote: >>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/

Re: [Qemu-devel] [PATCH] raw-posix: Detect CDROM via ioctl

2010-01-11 Thread Simon Horman
On Mon, Jan 11, 2010 at 01:30:18PM -0500, Cole Robinson wrote: > Current CDROM detection is hardcoded based on source file name. > Make this smarter by attempting a CDROM specific ioctl. > > This makes '-cdrom /dev/sr0' succeed with no media present. > > Signed-off-by: Cole Robinson > --- > blo

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Anthony Liguori
On 01/11/2010 04:10 PM, Stefan Weil wrote: I haven't read this whole thread, but I really prefer things like pci_set_vendor_id(pci_dev, ); A close alternative, would be some refactoring to allow PCI config space to be represented as a C structure. Gerd had some patches at one point for thi

[Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-11 Thread Igor Kovalenko
On Tue, Jan 12, 2010 at 12:29 AM, Blue Swirl wrote: > On Sun, Jan 10, 2010 at 6:41 PM, Blue Swirl wrote: >> On Sun, Jan 3, 2010 at 7:18 PM, Blue Swirl wrote: >>> On Sun, Jan 3, 2010 at 6:06 PM, Michael S. Tsirkin wrote: On Sun, Jan 03, 2010 at 06:50:15PM +0100, Alexander Graf wrote: >

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Anthony Liguori schrieb: > On 01/11/2010 02:30 PM, Michael S. Tsirkin wrote: >> On Mon, Jan 11, 2010 at 09:18:51PM +0100, Stefan Weil wrote: >> >>> Michael S. Tsirkin schrieb: >>> On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb:

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Anthony Liguori
On 01/11/2010 02:30 PM, Michael S. Tsirkin wrote: On Mon, Jan 11, 2010 at 09:18:51PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 04:07:26PM +0

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Anthony Liguori
On 01/11/2010 02:40 PM, Jan Kiszka wrote: Anthony Liguori wrote: On 01/07/2010 10:24 AM, Gleb Natapov wrote: diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -17,6 +17,7 @@ #include #include +#in

Re: [Qemu-devel] [RFC] New naming rules for GPXE romfiles

2010-01-11 Thread Anthony Liguori
On 01/11/2010 03:18 PM, Stefan Weil wrote: The current names of GPXE romfiles are something like pxe-e1000.bin, pxe-ne2k_pci.bin, pxe-rtl8139.bin. This was adequate when these names were computed by a simple rule using the device name. Today, an ethernet device can be associated to any romfile

[Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-11 Thread Blue Swirl
On Sun, Jan 10, 2010 at 6:41 PM, Blue Swirl wrote: > On Sun, Jan 3, 2010 at 7:18 PM, Blue Swirl wrote: >> On Sun, Jan 3, 2010 at 6:06 PM, Michael S. Tsirkin wrote: >>> On Sun, Jan 03, 2010 at 06:50:15PM +0100, Alexander Graf wrote: On 03.01.2010, at 18:44, Michael S. Tsirkin wrote: >>>

[Qemu-devel] [RFC] New naming rules for GPXE romfiles

2010-01-11 Thread Stefan Weil
The current names of GPXE romfiles are something like pxe-e1000.bin, pxe-ne2k_pci.bin, pxe-rtl8139.bin. This was adequate when these names were computed by a simple rule using the device name. Today, an ethernet device can be associated to any romfile name. Etherboot's Rom-o-Matic (which creates

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Jan Kiszka
Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: >> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> index 4084503..6a841de 100644 >> --- a/target-i386/kvm.c >> +++ b/target-i386/kvm.c >> @@ -17,6 +17,7 @@ >> #include >> >> #include >> +#include > > This breaks the bui

Re: [Qemu-devel] [PATCH 0/5] tcg-sparc improvements

2010-01-11 Thread Palle Lyckegaard
On Mon, 11 Jan 2010, Richard Henderson wrote: Richard Henderson (5): tcg-sparc: Add tcg_out_arithc. tcg-sparc: Implement add2, sub2, mulu2. tcg-sparc: Do not remove %o[012] from 'r' constraint. tcg-sparc: Implement division properly. tcg-sparc: Implement ext32[su]_i64 Great work :-) No

[Qemu-devel] Re: [PATCH] pci: Add missing 'const' in argument to pci_get_xxx

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 09:20:13PM +0100, Stefan Weil wrote: > pci_get_byte, pci_get_word, pci_get_long and pci_get_quad > all take a const uint8_t pointer, because they only read > the configuration data. > > Their prototypes should reflect this fact. > > Signed-off-by: Stefan Weil Applied, th

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 09:18:51PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: > >> Michael S. Tsirkin schrieb: > >>> On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > >

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: >> Michael S. Tsirkin schrieb: >>> On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: > On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: > ... >>

[Qemu-devel] [PATCH] pci: Add missing 'const' in argument to pci_get_xxx

2010-01-11 Thread Stefan Weil
pci_get_byte, pci_get_word, pci_get_long and pci_get_quad all take a const uint8_t pointer, because they only read the configuration data. Their prototypes should reflect this fact. Signed-off-by: Stefan Weil --- hw/pci.h | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH-RFC 00/13] vhost-net: preview

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 08:09:10PM +, Daniel P. Berrange wrote: > On Mon, Jan 11, 2010 at 07:16:42PM +0200, Michael S. Tsirkin wrote: > > Here's an untested patchset with vhost support for upstream qemu. Note > > that you should not expect performance gains from vhost unless in-kernel > > irqc

Re: [Qemu-devel] [PATCH 4/5] tcg-sparc: Implement division properly.

2010-01-11 Thread Richard Henderson
On 01/11/2010 11:09 AM, Richard Henderson wrote: +/* Load Y with the sign/zero extension of RS1 to 64-bits. */ +if (uns) { +tcg_out_sety(s, TCG_REG_G0); +} else { +tcg_out_arith(s, TCG_REG_I5, rs1, 31, SHIFT_SRA); Bah. tcg_out_arithi. Programming by code inspectio

Re: [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max

2010-01-11 Thread Anthony Liguori
On 01/07/2010 01:31 AM, Amit Shah wrote: VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in hw/virtio.h. Also, bump up the value of the maximum allowed virtqueues to 64. This is in preparation to allow multiple ports per virtio-console device. Signed-off-by: Amit Shah

Re: [Qemu-devel] [PATCH-RFC 00/13] vhost-net: preview

2010-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2010 at 07:16:42PM +0200, Michael S. Tsirkin wrote: > Here's an untested patchset with vhost support for upstream qemu. Note > that you should not expect performance gains from vhost unless in-kernel > irqchip is enabled (which is not in upstream qemu now). Since adding > vhost in

Re: [Qemu-devel] [PATCH] dmg: fix ->open failure

2010-01-11 Thread Anthony Liguori
On 01/11/2010 07:06 AM, Christoph Hellwig wrote: Currently the dmg image format driver simply opens the images as raw if any kind of failure happens. This is contrarty to the behaviour of all other image formats which just return an error and let the block core deal with it. Signed-off-by: Chri

Re: [Qemu-devel] [PATCHv7 1/3] qdev: add bit property type

2010-01-11 Thread Anthony Liguori
On 01/10/2010 05:52 AM, Michael S. Tsirkin wrote: This adds "bit" property type, which is a boolean stored in a 32 bit integer field, with legal values on and off. Will be used by virtio for feature bits. Signed-off-by: Michael S. Tsirkin Acked-by: Gerd Hoffmann Applied. Thanks. Regards

Re: [Qemu-devel] [PATCH 1/6] pc: add machine type for 0.12

2010-01-11 Thread Anthony Liguori
On 01/08/2010 08:25 AM, Gerd Hoffmann wrote: Add a new machine type for qemu 0.12. Also fixup the 0.11 machine type: msi for virtio-blk-pci was enabled after the 0.11 release, so turn it off in the 0.11 machine type. Signed-off-by: Gerd Hoffmann Applied all. Thanks. Regards, Anthony Li

Re: [Qemu-devel] [PATCH] pc-bios: Update README (SeaBIOS)

2010-01-11 Thread Anthony Liguori
On 01/07/2010 12:27 PM, Stefan Weil wrote: The PC BIOS no longer comes from Bochs. This patch updates the related entry. V2 - Modify SeaBIOS description and URL (Thanks to Gleb Natapov for the hint). Signed-off-by: Stefan Weil Applied. Thanks. Regards, Anthony Liguori --- pc-b

Re: [Qemu-devel] [PATCH] [tftp] Handle TFTP ERROR from client

2010-01-11 Thread Anthony Liguori
On 01/07/2010 11:01 AM, Thomas Horsten wrote: If a PXE client only wants to find out the size of a file, it will open the file and then abort the transfer by sending a TFTP ERROR packet. The ERROR packet should cause qemu to terminate the session. If not, the sessions will soon run out and cause

[Qemu-devel] [PATCH 5/5] tcg-sparc: Implement ext32[su]_i64

2010-01-11 Thread Richard Henderson
The 32-bit right-shift instructions is defined to extend the shifted output to 64-bits. A shift count of zero therefore is a simple extension without actually shifting. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 16 tcg/sparc/tcg-target.h |5 + 2 fi

[Qemu-devel] [PATCH 4/5] tcg-sparc: Implement division properly.

2010-01-11 Thread Richard Henderson
The {div,divu}2 opcodes are intended for systems for which the division instruction produces both quotient and remainder. Sparc is not such a system. Indeed, the remainder must be computed as quot = a / b rem = a - (quot * b) Split out a tcg_out_div32 function that properly initializes Y wi

[Qemu-devel] [PATCH 0/5] tcg-sparc improvements

2010-01-11 Thread Richard Henderson
As noticed elsewhere on the list mulu2_i32 is missing. Which led me to notice that add2_i32 and sub2_i32 were also missing and also led me to notice that division was incorrectly implemented. My initial implementation of 32-bit division copied the existing practice of using the 64-bit division i

[Qemu-devel] [PATCH 3/5] tcg-sparc: Do not remove %o[012] from 'r' constraint.

2010-01-11 Thread Richard Henderson
Only 'L' constraint needs that. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 6934580..8675fce 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-ta

[Qemu-devel] [PATCH 2/5] tcg-sparc: Implement add2, sub2, mulu2.

2010-01-11 Thread Richard Henderson
Add missing 32-bit double-word support opcodes. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 067e26e..6934580 100644 --- a/tcg/

[Qemu-devel] [PATCH 1/5] tcg-sparc: Add tcg_out_arithc.

2010-01-11 Thread Richard Henderson
Add a function to handle the register-vs-immediate test for arithmetic. Also, adjust the OP_32_64 macro so that it auto-indents properly. Rename the gen_arith32 label to gen_arith, since it handles 64-bit arithmetic as well. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 86 +++

Re: [Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2010 at 12:57:15PM -0600, Anthony Liguori wrote: > On 01/11/2010 12:34 PM, Luiz Capitulino wrote: > > Hi. > > > > We (Markus and I) are working on getting QMP forward compatibility > > support, > >supported. :) > > > > We have a plan for it and I'd like to ask the CC'ed people

Re: [Qemu-devel] [PATCH] virtio-pci: thinko fix

2010-01-11 Thread Anthony Liguori
On 01/11/2010 09:57 AM, Michael S. Tsirkin wrote: Since patch ed757e140c0ada220f213036e4497315d24ca8bct, virtio will sometimes clear all status registers on bus master disable, which loses information such as VIRTIO_CONFIG_S_FAILED bit. This is a result of a patch being misapplied: code uses !

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: > >> Michael S. Tsirkin schrieb: > >>> On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: > >>> ... > --- > hw/eepro100.c |

Re: [Qemu-devel] [PATCH 2/3] use pkg-config for sdl when cross compiling

2010-01-11 Thread Anthony Liguori
On 01/07/2010 08:42 AM, Paolo Bonzini wrote: Together with the previous patch this enables using the prefixed pkg-config, thus picking up the correct flags for SDL. Since pkg-config has an awful lot of dependencies, I still use sdl-config when not cross-compiling since some people may only have

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: >> Michael S. Tsirkin schrieb: >>> On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: >>> ... --- hw/eepro100.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) dif

[Qemu-devel] Registering key events android (qemu based) emulator

2010-01-11 Thread Anwar Ghani
Hi All guys I am a bit new to this stuff. I want to call a method after user presses a combination of keys lets say alt+s or whatever. How can I do it using which event handler. Best Regards Anwar Ghani +31 647 344 773 --- On Mon, 1/11/10, Anthony Liguori wrote: From: Anthony Liguori Su

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Anthony Liguori
On 01/07/2010 10:24 AM, Gleb Natapov wrote: diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -17,6 +17,7 @@ #include #include +#include This breaks the build on a default F12 install because while kvm.h is

[Qemu-devel] virtio: Add memory statistics reporting to the balloon driver (V6)

2010-01-11 Thread Adam Litke
After some good discussion, V6 of this patch integrates well with the new QMP support. When the monitor is in QMP mode, the query-balloon command triggers a stats refresh request to the guest. This request is asynchronous. If the guest does not respond then nothing further happens. When stats a

Re: [Qemu-devel] [PATCH] dmg: fix ->open failure

2010-01-11 Thread malc
On Mon, 11 Jan 2010, Christoph Hellwig wrote: > On Mon, Jan 11, 2010 at 02:56:16PM +0100, Kevin Wolf wrote: > > Are you going to propose a cleaner patch? I have currently some other > > bugs to do first, but I was certainly planning to do so. However, I'll > > happily leave it to you if you have t

Re: [Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Anthony Liguori
On 01/11/2010 12:34 PM, Luiz Capitulino wrote: Hi. We (Markus and I) are working on getting QMP forward compatibility support, supported. :) We have a plan for it and I'd like to ask the CC'ed people to review it. Needless to say, but the objective here is to add new commands, argument

[Qemu-devel] Re: [PATCH] eepro100: Update ROM file support

2010-01-11 Thread Michael S. Tsirkin
On Thu, Jan 07, 2010 at 05:13:30PM +0100, Stefan Weil wrote: > Use new way to associate ROM files to devices. > > Currently, there is only a ROM file for i82559er > included in QEMU, so the patch does not add > .romfile for the other devices. > > When flexible mode is fixed in eepro100, adding >

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions (was Re: [PATCH] eepro100: Fix initial value for PCI_STATUS)

2010-01-11 Thread Michael S. Tsirkin
On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: > > ... > >> --- > >> hw/eepro100.c | 4 +--- > >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> > >> diff --git a/hw/eepro100.c b/hw/ee

[Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Luiz Capitulino
Hi. We (Markus and I) are working on getting QMP forward compatibility support, supported. :) We have a plan for it and I'd like to ask the CC'ed people to review it. Needless to say, but the objective here is to add new commands, arguments, async messages and protocol features w/o breaking

[Qemu-devel] [PATCH] raw-posix: Detect IDE floppy via ioctl

2010-01-11 Thread Cole Robinson
Current IDE floppy detection is hardcoded based on source file name. Make this smarter by attempting a floppy specific ioctl. Signed-off-by: Cole Robinson --- block/raw-posix.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/block/raw-posix.c b/block/r

[Qemu-devel] [PATCH] raw-posix: Detect CDROM via ioctl

2010-01-11 Thread Cole Robinson
Current CDROM detection is hardcoded based on source file name. Make this smarter by attempting a CDROM specific ioctl. This makes '-cdrom /dev/sr0' succeed with no media present. Signed-off-by: Cole Robinson --- block/raw-posix.c | 18 +- 1 files changed, 17 insertions(+), 1

[Qemu-devel] Re: Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 09:13:23AM -0600, Anthony Liguori wrote: > On 01/11/2010 08:46 AM, Avi Kivity wrote: >> On 01/11/2010 04:37 PM, Anthony Liguori wrote: That has the downside of bouncing a cache line on unrelated exits. >>> >>> >>> The read and write sides of the ring are widely separate

[Qemu-devel] Re: Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 08:37:10AM -0600, Anthony Liguori wrote: > On 01/11/2010 08:29 AM, Avi Kivity wrote: >> On 01/11/2010 03:49 PM, Anthony Liguori wrote: So instead of disabling notify while requests are active we might want to only disable it while we are inside virtio_blk_handle_ou

[Qemu-devel] [PATCH 2/2] block: untangle open flag manipulation in bdrv_open2

2010-01-11 Thread Christoph Hellwig
Untangle the open flag manipulation in bdrv_open2 and document why we are clearing the various flags in the different flag combinations. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2010-01-11 17

[Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit

2010-01-11 Thread Christoph Hellwig
Check the whitelist as early as possible instead of continuing the setup, and move all the error handling code to the end of the function. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2010-01-11 1

Re: [Qemu-devel] [PATCH] dmg: fix ->open failure

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 03:11:52PM +0100, Kevin Wolf wrote: > More or less the same hack, just in cleaner? Or trying to fundamentally > change things? I think you haven't answered yet to what I said in the > thread of my original hack. I'm quoting it here for convenience: Well, not dealing with th

[Qemu-devel] [PATCH] vnc_refresh: return if vd->timer is NULL

2010-01-11 Thread Stefano Stabellini
Hi all, calling vnc_update_client in vnc_refresh might have the unlikely side effect of setting vd->timer = NULL, if the last vnc client disconnected. In this case we have to return from vnc_refresh without updating the timer, otherwise we cause a segfault. Signed-off-by: Stefano Stabellini ---

[Qemu-devel] [PATCH-RFC 11/13] vhost net support

2010-01-11 Thread Michael S. Tsirkin
This adds vhost net support in qemu. Will be tied to tap device and virtio later. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin --- Makefile.target |1 + hw/vhost.c | 349 +

[Qemu-devel] [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-11 Thread Michael S. Tsirkin
start/stop backend on driver start/stop Signed-off-by: Michael S. Tsirkin --- hw/virtio-net.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index c2a389f..99169e1 100644 --- a/hw/virtio-net.c +++

[Qemu-devel] [PATCH-RFC 12/13] virtio: add status change callback

2010-01-11 Thread Michael S. Tsirkin
vhost net backend needs to be notified when frontend status changes. Add a callback. Signed-off-by: Michael S. Tsirkin --- hw/s390-virtio-bus.c |3 +++ hw/syborg_virtio.c |2 ++ hw/virtio-pci.c |6 ++ hw/virtio.h |1 + 4 files changed, 12 insertions(+), 0 dele

[Qemu-devel] [PATCH-RFC 10/13] tap: add API to retrieve vhost net header

2010-01-11 Thread Michael S. Tsirkin
same comment as patch 09. Signed-off-by: Michael S. Tsirkin --- net/tap.c |7 +++ net/tap.h |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index d9f2e41..166cf05 100644 --- a/net/tap.c +++ b/net/tap.c @@ -491,3 +491,10 @@ int net_init_ta

[Qemu-devel] [PATCH-RFC 09/13] tap: add vhost/vhostfd options

2010-01-11 Thread Michael S. Tsirkin
Looks like order got mixed up: vhost_net header is added by a follow-up patch. Will be fixed in the next revision. Signed-off-by: Michael S. Tsirkin --- net.c |8 net/tap.c | 29 + qemu-options.hx |4 +++- 3 files changed, 40 inserti

[Qemu-devel] [PATCH-RFC 08/13] net/tap: add interface to get device fd

2010-01-11 Thread Michael S. Tsirkin
Will be used by vhost to attach/detach to backend. Signed-off-by: Michael S. Tsirkin --- net/tap.c |7 +++ net/tap.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index d3492de..7e9ca79 100644 --- a/net/tap.c +++ b/net/tap.c @@ -269,6 +26

[Qemu-devel] [PATCH-RFC 07/13] virtio: move typedef to qemu-common

2010-01-11 Thread Michael S. Tsirkin
make it possible to use type without header include Signed-off-by: Michael S. Tsirkin --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.h b/hw/virtio.h index 193b3f9..6a7e3ec 100644 --- a/hw/virtio.h +++ b/hw/virtio.h @@

[Qemu-devel] [PATCH-RFC 06/13] s390-virtio: fill in irqfd support

2010-01-11 Thread Michael S. Tsirkin
Don't know how to make queuefd work: probably need support for binding hypercalls to eventfd in kvm? Again, just a demonstration, probably not for commit, because s390 does not have vector support. Signed-off-by: Michael S. Tsirkin --- hw/s390-virtio-bus.c | 16 1 files chang

[Qemu-devel] [PATCH-RFC 05/13] syborg_virtio: add irqfd/eventfd support

2010-01-11 Thread Michael S. Tsirkin
No idea if it's right .. and syborg does not support vectors so we won't get performance gains out of it either - so quite likely it's best to just keep this patch out of qemu. But just to show what's possible. Signed-off-by: Michael S. Tsirkin --- hw/syborg_virtio.c | 25

[Qemu-devel] [PATCH-RFC 04/13] virtio-pci: fill in irqfd/queufd support

2010-01-11 Thread Michael S. Tsirkin
Support irqfd/queuefd. The last one only with kvm, that's okay because vhost relies on kvm anyway. Signed-off-by: Michael S. Tsirkin --- hw/virtio-pci.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 6d0f

[Qemu-devel] [PATCH-RFC 03/13] virtio: add iofd/irqfd support

2010-01-11 Thread Michael S. Tsirkin
Add binding API to set iofd/irqfd support. Will be used by vhost. Signed-off-by: Michael S. Tsirkin --- hw/virtio.c | 13 ++--- hw/virtio.h |4 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 8e3c9ad..b9ec863 100644 --- a/hw/virt

[Qemu-devel] [PATCH-RFC 02/13] kvm: add API to set ioeventfd

2010-01-11 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- kvm-all.c | 24 kvm.h |3 +++ 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index a312654..aa00119 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1113,3 +1113,27 @@ void kvm_remove_all_bre

[Qemu-devel] [PATCH-RFC 01/13] virtio: export virtqueue structure

2010-01-11 Thread Michael S. Tsirkin
vhost needs physical addresses for ring so expose that structure. Signed-off-by: Michael S. Tsirkin --- hw/virtio.c | 18 -- hw/virtio.h | 17 + 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 3c609ce..8e3c9ad 1

[Qemu-devel] [PATCH-RFC 00/13] vhost-net: preview

2010-01-11 Thread Michael S. Tsirkin
Here's an untested patchset with vhost support for upstream qemu. Note that you should not expect performance gains from vhost unless in-kernel irqchip is enabled (which is not in upstream qemu now). Since adding vhost involves quite a bit of infrastructure, I thought it makes sense to send an RF

[Qemu-devel] Re: New kvm-related qemu patch queue

2010-01-11 Thread Anthony Liguori
On 01/10/2010 06:02 AM, Avi Kivity wrote: In order to improve qemu.git kvm integration quality wrt performance, features, and reliability Marcelo and I will begin to maintain a patch queue based on qemu.git containing kvm-related patches. We will review and apply patches to this queue, test th

Re: [Qemu-devel] mulu2 not implemented for tcg target sparc

2010-01-11 Thread Richard Henderson
On 01/10/2010 01:17 PM, Palle Lyckegaard wrote: On Sun, 10 Jan 2010, Blue Swirl wrote: Is it needed somewhere? I was trying to run qemu-system-mips with a NetBSD malta kernel that generates a MIPS mult operation. Tracing the code through tcg points at a missing mulu2 opreration for sparc.

[Qemu-devel] Re: [ kvm-Bugs-2907597 ] qemu vnc server clips at 2560x1600

2010-01-11 Thread Avi Kivity
On 01/11/2010 04:30 PM, Avi Kivity wrote: VNC_MAX_WIDTH and VNC_MAX_HEIGHT in vnc.h are currently defined to 2048. We do dirty tracking with a bitmap and that bitmap is currently a fixed size. 2048 is bigger than any physical screen that I know of so I assume this is a multiple monitor sce

Re: [Qemu-devel] [PATCH] remove pending exception on vcpu reset.

2010-01-11 Thread Anthony Liguori
On 01/06/2010 08:30 AM, Gleb Natapov wrote: Without this qemu can even start on kvm modules with events support since default value of exception_injected in zero and this is #DE exception. Signed-off-by: Gleb Natapov Applied. Thanks. Regards, Anthony Liguori diff --git a/target-i386/kv

Re: [Qemu-devel] [PATCH resend] vmware_vga: Check cursor dimensions passed from guest to avoid buffer overflow

2010-01-11 Thread Anthony Liguori
On 01/05/2010 10:43 PM, Roland Dreier wrote: Check that the cursor dimensions passed from the guest for the DEFINE_CURSOR command don't overflow the available space in the cursor.image[] or cursor.mask[] arrays before copying data from the guest into those arrays. Signed-off-by: Roland Dreier

Re: [Qemu-devel] [PATCH] Fix CPU topology initialization

2010-01-11 Thread Anthony Liguori
On 01/05/2010 10:26 AM, Jiri Denemark wrote: Late initialization of CPU topology in CPUState prevents KVM guests to actually see the topology. Signed-off-by: Jiri Denemark Applied. Thanks. Regards, Anthony Liguori --- vl.c |8 1 files changed, 4 insertions(+), 4 deletio

Re: [Qemu-devel] [PATCH] finish VPATH -> vpath translation

2010-01-11 Thread Anthony Liguori
On 01/04/2010 04:02 AM, Paolo Bonzini wrote: This adds a few more vpath suffixes and points the remaining two paths explicitly to $(SRC_PATH) in order to eliminate the VPATH assignment from config-host.mak. Signed-off-by: Paolo Bonzini Applied. Thanks. Regards, Anthony Liguori Cc: Jua

Re: [Qemu-devel] [BUGFIX] MCE: Fix bug of IA32_MCG_STATUS after system reset

2010-01-11 Thread Anthony Liguori
On 01/05/2010 02:32 AM, Huang Ying wrote: Now, if we inject a fatal MCE into guest OS, for example Linux, Linux will go panic and then reboot. But if we inject another MCE now, system will reset directly instead of go panic firstly, because MCG_STATUS.MCIP is set to 1 and not cleared after reboot

[Qemu-devel] [PATCH] virtio-pci: thinko fix

2010-01-11 Thread Michael S. Tsirkin
Since patch ed757e140c0ada220f213036e4497315d24ca8bct, virtio will sometimes clear all status registers on bus master disable, which loses information such as VIRTIO_CONFIG_S_FAILED bit. This is a result of a patch being misapplied: code uses ! instead of ~ for bit operations as in Yan's original

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 09:35 AM, Avi Kivity wrote: On 01/11/2010 05:32 PM, Anthony Liguori wrote: On 01/11/2010 09:31 AM, Avi Kivity wrote: On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size, various

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 05:32 PM, Anthony Liguori wrote: On 01/11/2010 09:31 AM, Avi Kivity wrote: On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size, various tx mitigation schemes, timeout durations,

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 09:31 AM, Avi Kivity wrote: On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size, various tx mitigation schemes, timeout durations, etc) and then we can do some deep performance

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size, various tx mitigation schemes, timeout durations, etc) and then we can do some deep performance studies to see how things interact with eac

[Qemu-devel] [PATCH 2/4] ppc-40x: Correct check for Endian swapping TLB entries.

2010-01-11 Thread Edgar E. Iglesias
Bailout on 40x TLB entries with endianess swapping only if the entry is valid. Signed-off-by: Edgar E. Iglesias --- target-ppc/op_helper.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c index 3575b29..f905c64 10

  1   2   >