[Qemu-devel] Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption in kvm mode

2010-02-22 Thread Jan Kiszka
Avi Kivity wrote: On 02/19/2010 07:21 PM, Jan Kiszka wrote: This should explain a lot of the weird breakages of upstream KVM we've seen recently (actually we should have seen it much earlier): Stop translating eflags into TCG format when in kvm mode as we never translate it back and rather

[Qemu-devel] Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption in kvm mode

2010-02-22 Thread Avi Kivity
On 02/22/2010 10:13 AM, Jan Kiszka wrote: Avi Kivity wrote: On 02/19/2010 07:21 PM, Jan Kiszka wrote: This should explain a lot of the weird breakages of upstream KVM we've seen recently (actually we should have seen it much earlier): Stop translating eflags into TCG format when in

[Qemu-devel] Re: qemu-kvm 0.12.2 VNC segfault

2010-02-22 Thread Avi Kivity
On 02/21/2010 07:23 PM, Chris Webb wrote: Some sort of race where a client disconnects and is removed from the client list while the vnc_refresh() loop is iterating over it, maybe? Looks like c727a05459, and high time for 0.12.3. Anthony? -- error compiling committee.c: too many

[Qemu-devel] Re: [patch uq/master 0/4] uq/master: iothread consume signals via sigtimedwait and cleanups

2010-02-22 Thread Avi Kivity
On 02/18/2010 12:14 AM, Marcelo Tosatti wrote: See individual patches for details. Applied, thanks. -- error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [PATCH 11/20] eepro100: Use symbolic names for bits in EEPROM id

2010-02-22 Thread Michael S. Tsirkin
On Sun, Feb 21, 2010 at 10:38:02PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Sun, Feb 14, 2010 at 05:16:20PM +0100, Stefan Weil wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 17 - 1 files changed, 16 insertions(+), 1

Re: [Qemu-devel] [PATCH] QEMU e820 reservation patch

2010-02-22 Thread Avi Kivity
On 02/21/2010 09:13 PM, Kevin O'Connor wrote: I'd like to have QEMU handle more, I picked the TSS page because we changed the location of that in the past and it was the one that triggered my patch in the first place. Now we have the infrastructure, it will be easier to add more. What

[Qemu-devel] [PATCH] apb_pci: minor cleanup

2010-02-22 Thread Michael S. Tsirkin
pci_data_write ignores high 8 bit in address, so there seems to be no need to set them in apb_pci. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Blue Swirl, please consider the following (untested) patch. Thanks! hw/apb_pci.c |6 ++ 1 files changed, 2 insertions(+), 4

Re: [Qemu-devel] [PATCH] fix 'i' format handling in memory dump

2010-02-22 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: It was broken by 09b9418c6d0. (!env !is_physical) != (!is_physical) when env is true. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/monitor.c b/monitor.c index b1a6edc..19470d1 100644 --- a/monitor.c +++ b/monitor.c @@ -1297,8 +1297,6 @@

Re: [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

2010-02-22 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 20.02.2010 02:49, schrieb Juan Quintela: Anthony Liguori anth...@codemonkey.ws wrote: On 02/15/2010 10:19 AM, Kevin Wolf wrote: The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-22 Thread Loïc Minier
On Sat, Feb 20, 2010, malc wrote: No, i'm against using locking GCC builtins for all the other targets (well PPC) Do you have benchmarks with/without GCC atomic builtins? -- Loïc Minier

[Qemu-devel] [PATCH] apc_pci: simplify using rwhandler

2010-02-22 Thread Michael S. Tsirkin
Use rwhandler to simplify apb_pci. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Blue Swirl, please consider the following (compile-tested only) patch. hw/apb_pci.c | 74 ++--- 1 files changed, 13 insertions(+), 61 deletions(-)

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-22 Thread malc
On Mon, 22 Feb 2010, Lo?c Minier wrote: On Sat, Feb 20, 2010, malc wrote: No, i'm against using locking GCC builtins for all the other targets (well PPC) Do you have benchmarks with/without GCC atomic builtins? No. -- mailto:av1...@comtv.ru

[Qemu-devel] QEMU in TLM-2.0 environment

2010-02-22 Thread Alex Rozenman
Hi, I would like to be able to do small contributions in QEMU in order to connect it to our TLM-2.0 ESL modelling platform. I am working for a commercial company; we use LGPL cut of QEMU. I planning to enhance hot plugin mode allowing to bind peripherals more easily, distinguish debug calls from

Re: [Qemu-devel] QEMU in TLM-2.0 environment

2010-02-22 Thread Alexander Graf
On 22.02.2010, at 12:09, Alex Rozenman wrote: Hi, I would like to be able to do small contributions in QEMU in order to connect it to our TLM-2.0 ESL modelling platform. I am working for a commercial company; we use LGPL cut of QEMU. I planning to enhance hot plugin mode allowing to

Re: [Qemu-devel] [PATCH] QMP: Spec: Private Extensions support

2010-02-22 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 02/19/2010 07:04 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: We need a bit more than just this. Here's my suggestion: I think this is much more restrictive than necessary. Unnecessarily restrictive

[Qemu-devel] Address translation - virt-phys-ram

2010-02-22 Thread Ian Molton
Hi folks, I've been updating some old patches which make use of a function to translate guest virtual addresses into pointers into the guest RAM. As I understand it qemu has guest virtual and physical addresses, the latter of which map somehow to host ram addresses. The function which the code

[Qemu-devel] [patch uq/master 0/2] wake iothread on virtio kick / flush_coalesced_mmio smp_wmb

2010-02-22 Thread Marcelo Tosatti
See individual patches for details.

[Qemu-devel] [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Marcelo Tosatti
VIRTIO_PCI_QUEUE_NOTIFY is used to inform availability of new buffers, so wakeup the iothread to process that information immediately. Reported-by: Amit Shah amit.s...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu/hw/virtio-pci.c

[Qemu-devel] [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Marcelo Tosatti
Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu/kvm-all.c === --- qemu.orig/kvm-all.c +++ qemu/kvm-all.c @@ -718,6 +718,9 @@ static int kvm_handle_io(uint16_t port, return

[Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Avi Kivity
On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: VIRTIO_PCI_QUEUE_NOTIFY is used to inform availability of new buffers, so wakeup the iothread to process that information immediately. Reported-by: Amit Shahamit.s...@redhat.com Signed-off-by: Marcelo Tosattimtosa...@redhat.com Index:

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Avi Kivity
On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: Cc: Michael S. Tsirkinm...@redhat.com Signed-off-by: Marcelo Tosattimtosa...@redhat.com Index: qemu/kvm-all.c === --- qemu.orig/kvm-all.c +++ qemu/kvm-all.c @@ -718,6 +718,9 @@ static

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Alexander Graf
Blue Swirl wrote: Thanks, applied. This patch breaks building on ppc32. Reverting it makes it compile again: In file included from /suse/agraf/git/qemu/tcg/tcg.c:158: /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) Alex On

Re: [Qemu-devel] Address translation - virt-phys-ram

2010-02-22 Thread Anthony Liguori
On 02/22/2010 07:59 AM, Ian Molton wrote: Hi folks, I've been updating some old patches which make use of a function to translate guest virtual addresses into pointers into the guest RAM. As I understand it qemu has guest virtual and physical addresses, the latter of which map somehow to host

Re: [Qemu-devel] [BUG] Regression: readonly raw images no longer work

2010-02-22 Thread Naphtali Sprei
Stefan Weil wrote: This command used to work, but fails now: $ i386-softmmu/qemu -snapshot /dev/sda qemu: could not open disk image /dev/sda: Permission denied $ ls -l /dev/sda brw-rw-r-- 1 root disk 8, 0 13. Feb 08:55 /dev/sda The original file of a snapshot needs only read access,

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Jay Foad
This patch breaks building on ppc32. Reverting it makes it compile again: /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) Does it build if you remove line 1696? If so, I'd suggest doing that. Thanks, Jay.

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Marcelo Tosatti
On Mon, Feb 22, 2010 at 04:23:32PM +0200, Avi Kivity wrote: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: Cc: Michael S. Tsirkinm...@redhat.com Signed-off-by: Marcelo Tosattimtosa...@redhat.com Index: qemu/kvm-all.c === ---

[Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Marcelo Tosatti
On Mon, Feb 22, 2010 at 04:20:52PM +0200, Avi Kivity wrote: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: VIRTIO_PCI_QUEUE_NOTIFY is used to inform availability of new buffers, so wakeup the iothread to process that information immediately. Reported-by: Amit Shahamit.s...@redhat.com

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Michael S. Tsirkin
On Mon, Feb 22, 2010 at 10:59:08AM -0300, Marcelo Tosatti wrote: Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com We'll need implementation for other arches, I'll dust off my patch that adds it and repost,

[Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Avi Kivity
On 02/22/2010 04:29 PM, Marcelo Tosatti wrote: On Mon, Feb 22, 2010 at 04:20:52PM +0200, Avi Kivity wrote: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: VIRTIO_PCI_QUEUE_NOTIFY is used to inform availability of new buffers, so wakeup the iothread to process that information

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Avi Kivity
On 02/22/2010 04:45 PM, Marcelo Tosatti wrote: On Mon, Feb 22, 2010 at 04:23:32PM +0200, Avi Kivity wrote: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: Cc: Michael S. Tsirkinm...@redhat.com Signed-off-by: Marcelo Tosattimtosa...@redhat.com Index: qemu/kvm-all.c

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Michael S. Tsirkin
On Mon, Feb 22, 2010 at 04:57:29PM +0200, Avi Kivity wrote: On 02/22/2010 04:45 PM, Marcelo Tosatti wrote: On Mon, Feb 22, 2010 at 04:23:32PM +0200, Avi Kivity wrote: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: Cc: Michael S. Tsirkinm...@redhat.com Signed-off-by: Marcelo

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Avi Kivity
On 02/22/2010 04:57 PM, Michael S. Tsirkin wrote: There is no need (for this case). Older read cannot be reordered with write, writes are not reordered with other writes, writes by a single processor are observed in the same order by all processors. Well, Linux does use sfence.

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Michael S. Tsirkin
On Mon, Feb 22, 2010 at 05:08:00PM +0200, Avi Kivity wrote: On 02/22/2010 04:57 PM, Michael S. Tsirkin wrote: There is no need (for this case). Older read cannot be reordered with write, writes are not reordered with other writes, writes by a single processor are observed in the same

[Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Marcelo Tosatti
On Mon, Feb 22, 2010 at 04:51:46PM +0200, Avi Kivity wrote: On 02/22/2010 04:29 PM, Marcelo Tosatti wrote: On Mon, Feb 22, 2010 at 04:20:52PM +0200, Avi Kivity wrote: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: VIRTIO_PCI_QUEUE_NOTIFY is used to inform availability of new buffers, so

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Stefan Weil
Jay Foad schrieb: This patch breaks building on ppc32. Reverting it makes it compile again: /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) Does it build if you remove line 1696? If so, I'd suggest doing that.

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Alexander Graf
Jay Foad wrote: This patch breaks building on ppc32. Reverting it makes it compile again: /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) Does it build if you remove line 1696? If so, I'd suggest doing that.

[Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.

2010-02-22 Thread Bartlomiej Zolnierkiewicz
On Monday 22 February 2010 12:57:19 am David Miller wrote: From: Rob Landley r...@landley.net Date: Sun, 21 Feb 2010 10:25:09 -0600 085219f79cad89291699bd2bfb21c9fdabafe65f is first bad commit commit 085219f79cad89291699bd2bfb21c9fdabafe65f Author: Sam Ravnborg s...@ravnborg.org Date:

[Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.

2010-02-22 Thread David Miller
From: Rob Landley r...@landley.net Date: Sun, 21 Feb 2010 10:25:09 -0600 085219f79cad89291699bd2bfb21c9fdabafe65f is first bad commit commit 085219f79cad89291699bd2bfb21c9fdabafe65f Author: Sam Ravnborg s...@ravnborg.org Date: Fri Jan 2 18:47:34 2009 -0800 sparc32: use proper types

[Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.

2010-02-22 Thread David Miller
Here's the fix I'll use, thanks for the report Rob: sparc32: Fix struct stat uid/gid types. Commit 085219f79cad89291699bd2bfb21c9fdabafe65f (sparc32: use proper types in struct stat) Accidently changed the struct stat uid/gid members to uid_t and gid_t, but those get set to __kernel_uid32_t

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Avi Kivity
On 02/22/2010 05:08 PM, Michael S. Tsirkin wrote: I imagine all arches need an instruction. For reads as well. Note, gcc has a __sync_synchronize() builtin that compiles to mfence on x86. We might use that as a baseline for both rmb and wmb, and let each arch override it incrementally.

[Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Anthony Liguori
On 02/22/2010 09:16 AM, Marcelo Tosatti wrote: Are you concerned about spurious wakeups? Yes. Also, qemu_notify_event() is an undirected notification (wakes up all iothreads, and all devices), whereas -handle_output() is directed (wakes up exactly what is needed). What's the

[Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Avi Kivity
On 02/22/2010 05:29 PM, Anthony Liguori wrote: On 02/22/2010 09:16 AM, Marcelo Tosatti wrote: Are you concerned about spurious wakeups? Yes. Also, qemu_notify_event() is an undirected notification (wakes up all iothreads, and all devices), whereas -handle_output() is directed (wakes up

[Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Anthony Liguori
On 02/22/2010 09:32 AM, Avi Kivity wrote: On 02/22/2010 05:29 PM, Anthony Liguori wrote: On 02/22/2010 09:16 AM, Marcelo Tosatti wrote: Are you concerned about spurious wakeups? Yes. Also, qemu_notify_event() is an undirected notification (wakes up all iothreads, and all devices), whereas

[Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Jay Foad
The qemu_ld32s op is only defined if TCG_TARGET_REG_BITS == 64. Signed-off-by: Jay Foad jay.f...@gmail.com --- tcg/hppa/tcg-target.c |1 - tcg/ppc/tcg-target.c |2 -- tcg/sparc/tcg-target.c |4 3 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY

2010-02-22 Thread Avi Kivity
On 02/22/2010 05:42 PM, Anthony Liguori wrote: Spurious calls to qemu_notify_event() also make it difficult to tell when it's actually necessary to call qemu_notify_event() vs. when it's just something that doesn't hurt. One improvement in this area would be to add a context parameter (which

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Jay Foad
Does it build if you remove line 1696? If so, I'd suggest doing that. Yes, that fixes it. Please grep through all tcg targets and send a patch removing all references to ld32s if you think it's not necessary. Done. Unfortunately I'm not in a position to try building any of the affected tcg

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Stefan Weil
Jay Foad schrieb: The qemu_ld32s op is only defined if TCG_TARGET_REG_BITS == 64. Signed-off-by: Jay Foad jay.f...@gmail.com --- tcg/hppa/tcg-target.c |1 - tcg/ppc/tcg-target.c |2 -- tcg/sparc/tcg-target.c |4 3 files changed, 4 insertions(+), 3 deletions(-) diff

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Jay Foad
--- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -1693,7 +1693,6 @@ static const TCGTargetOpDef ppc_op_defs[] = {      { INDEX_op_qemu_ld16u, { r, L } },      { INDEX_op_qemu_ld16s, { r, L } },      { INDEX_op_qemu_ld32u, { r, L } }, -    { INDEX_op_qemu_ld32s, { r, L } }, No. As

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread malc
On Mon, 22 Feb 2010, Jay Foad wrote: The qemu_ld32s op is only defined if TCG_TARGET_REG_BITS == 64. Your mail client mangled the patch. [..snip..] @@ -1319,9 +1319,11 @@ static inline void tcg_out_op(TCGContext *s, int opc, const TCGArg *args, Here. [..snip..] Fixed and applied. --

[Qemu-devel] [PATCH] tcg/ppc: Add missing conditional compilation

2010-02-22 Thread Stefan Weil
INDEX_op_qemu_ld32s is only used when TCG_TARGET_REG_BITS == 64. This fixes a compile error (reported by Alexander Graf). Signed-off-by: Stefan Weil w...@mail.berlios.de --- tcg/ppc/tcg-target.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tcg/ppc/tcg-target.c

Re: [Qemu-devel] Address translation - virt-phys-ram

2010-02-22 Thread Ian Molton
Anthony Liguori wrote: cpu_physical_memory_map(). But this function has some subtle characteristics. It may return a bounce buffer if you attempt to map MMIO memory. There is a limited pool of bounce buffers available so it may return NULL in the event that it cannot allocate a bounce

Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command

2010-02-22 Thread Adam Litke
On Fri, 2010-02-19 at 15:47 -0600, Anthony Liguori wrote: On 02/12/2010 02:55 PM, Adam Litke wrote: Arghh... Adding missing S-O-B Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must

Re: [Qemu-devel] Address translation - virt-phys-ram

2010-02-22 Thread Anthony Liguori
On 02/22/2010 10:46 AM, Ian Molton wrote: Anthony Liguori wrote: cpu_physical_memory_map(). But this function has some subtle characteristics. It may return a bounce buffer if you attempt to map MMIO memory. There is a limited pool of bounce buffers available so it may return NULL in

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Marcelo Tosatti
Acked-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu/kvm-all.c === --- qemu.orig/kvm-all.c +++ qemu/kvm-all.c @@ -21,6 +21,7 @@ #include linux/kvm.h #include qemu-common.h

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Stefan Weil
Jay Foad schrieb: --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -1693,7 +1693,6 @@ static const TCGTargetOpDef ppc_op_defs[] = { { INDEX_op_qemu_ld16u, { r, L } }, { INDEX_op_qemu_ld16s, { r, L } }, { INDEX_op_qemu_ld32u, { r, L } }, -{ INDEX_op_qemu_ld32s, {

[Qemu-devel] Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Avi Kivity
On 02/22/2010 06:57 PM, Marcelo Tosatti wrote: Acked-by: Michael S. Tsirkinm...@redhat.com Signed-off-by: Marcelo Tosattimtosa...@redhat.com Applied, thanks. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] tcg/ppc: Add missing conditional compilation

2010-02-22 Thread malc
On Mon, 22 Feb 2010, Stefan Weil wrote: INDEX_op_qemu_ld32s is only used when TCG_TARGET_REG_BITS == 64. TCG_TARGET_REG_BITS is always 32 for PPC32. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] Address translation - virt-phys-ram

2010-02-22 Thread Ian Molton
Anthony Liguori wrote: On 02/22/2010 10:46 AM, Ian Molton wrote: Anthony Liguori wrote: cpu_physical_memory_map(). But this function has some subtle characteristics. It may return a bounce buffer if you attempt to map MMIO memory. There is a limited pool of bounce buffers available

Re: [Qemu-devel] Address translation - virt-phys-ram

2010-02-22 Thread Alexander Graf
Ian Molton wrote: Anthony Liguori wrote: On 02/22/2010 10:46 AM, Ian Molton wrote: Anthony Liguori wrote: cpu_physical_memory_map(). But this function has some subtle characteristics. It may return a bounce buffer if you attempt to map MMIO memory. There is a

Re: [Qemu-devel] Re: qemu-kvm 0.12.2 VNC segfault

2010-02-22 Thread Chris Webb
Avi Kivity a...@redhat.com writes: On 02/21/2010 07:23 PM, Chris Webb wrote: Some sort of race where a client disconnects and is removed from the client list while the vnc_refresh() loop is iterating over it, maybe? Looks like c727a05459, and high time for 0.12.3. Anthony? Ah yes, looks

[Qemu-devel] [PATCH] Fix to 'gdb detach' stub

2010-02-22 Thread Daniel Gutson
With this patch, 'gdb detach' correctly resumes the inferior execution after detaching the debugger. The bug was caused by qemu asking gdb to execute a syscall (isatty) after the detach, and then waiting (forever) for the reply. I fixed this by properly setting gdb_syscall_mode appropriately in

Re: [Qemu-devel] getfd monitor command broken

2010-02-22 Thread Luiz Capitulino
On Fri, 19 Feb 2010 10:21:41 -0800 Ed Swierk eswi...@aristanetworks.com wrote: Commit c62313bbdc48f72e93fa8196f2fff96ba35e4e9d seems to have broken the getfd monitor command in qemu 0.12. Does it work with current master? How do you reproduce it?

[Qemu-devel] Full build broken

2010-02-22 Thread Luiz Capitulino
Hi Paul, Commit bc3b26f5 breaks a full QEMU build for me: cc1: warnings being treated as errors /home/lcapitulino/src/qmp-unstable/hw/pl181.c: In function ‘pl181_fifo_run’: /home/lcapitulino/src/qmp-unstable/hw/pl181.c:185: error: ‘value’ may be used uninitialized in this function make[1]:

[Qemu-devel] Re: [PATCH] apb_pci: minor cleanup

2010-02-22 Thread Blue Swirl
Thanks, applied. On 2/22/10, Michael S. Tsirkin m...@redhat.com wrote: pci_data_write ignores high 8 bit in address, so there seems to be no need to set them in apb_pci. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Blue Swirl, please consider the following (untested) patch.

[Qemu-devel] Re: [PATCH] apc_pci: simplify using rwhandler

2010-02-22 Thread Blue Swirl
Thanks, applied. On 2/22/10, Michael S. Tsirkin m...@redhat.com wrote: Use rwhandler to simplify apb_pci. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Blue Swirl, please consider the following (compile-tested only) patch. hw/apb_pci.c | 74

[Qemu-devel] [PATCH 0/8] [GIT PULL] qemu-kvm.git uq/master queue

2010-02-22 Thread Marcelo Tosatti
The following changes since commit bf76bafa5ade434ef2747caa95510ecb7946: Edgar E. Iglesias (1): crisv10: Prettify. are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (1): kvm: Fix eflags corruption in kvm mode

[Qemu-devel] [PATCH 8/8] kvm-all.c: define smp_wmb and use it for coalesced mmio

2010-02-22 Thread Marcelo Tosatti
Acked-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- kvm-all.c |3 ++- qemu-barrier.h |7 +++ 2 files changed, 9 insertions(+), 1 deletions(-) create mode 100644 qemu-barrier.h diff --git

[Qemu-devel] [PATCH 5/8] kvm specific wait_io_event

2010-02-22 Thread Marcelo Tosatti
In KVM mode the global mutex is released when vcpus are executing, which means acquiring the fairness mutex is not required. Also for KVM there is one thread per vcpu, so tcg_has_work is meaningless. Add a new qemu_wait_io_event_common function to hold common code between TCG/KVM.

[Qemu-devel] [PATCH 3/8] kvm: Kill CR3_CACHE feature references

2010-02-22 Thread Marcelo Tosatti
From: Jes Sorensen jes.soren...@redhat.com Remove all references to KVM_CR3_CACHE as it was never implemented. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- target-i386/kvm.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 6/8] kvm: consume internal signal with sigtimedwait

2010-02-22 Thread Marcelo Tosatti
Change the way the internal qemu signal, used for communication between iothread and vcpus, is handled. Block and consume it with sigtimedwait on the outer vcpu loop, which allows more precise timing control. Change from standard signal (SIGUSR1) to real-time one, so multiple signals are not

[Qemu-devel] [PATCH 2/8] kvm: Fix eflags corruption in kvm mode

2010-02-22 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com This should explain a lot of the weird breakages of upstream KVM we've seen recently (actually we should have seen it much earlier): Stop translating eflags into TCG format when in kvm mode as we never translate it back and rather sync this broken state

[Qemu-devel] [PATCH 4/8] block SIGCHLD in vcpu thread(s)

2010-02-22 Thread Marcelo Tosatti
Otherwise a vcpu thread can run the sigchild handler causing waitpid() from iothread to fail. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index

[Qemu-devel] Re: qemu-kvm 0.12.2 VNC segfault

2010-02-22 Thread Anthony Liguori
On 02/22/2010 02:54 AM, Avi Kivity wrote: On 02/21/2010 07:23 PM, Chris Webb wrote: Some sort of race where a client disconnects and is removed from the client list while the vnc_refresh() loop is iterating over it, maybe? Looks like c727a05459, and high time for 0.12.3. Anthony? Indeed.

[Qemu-devel] Re: [PATCH] Fix to 'gdb detach' stub

2010-02-22 Thread Daniel Gutson
[Re-done with git.] With this patch, 'gdb detach' correctly resumes the inferior execution after detaching the debugger. The bug was caused by qemu asking gdb to execute a syscall (isatty) after the detach, and then waiting (forever) for the reply. I fixed this by properly setting

Re: [Qemu-devel] Re: [PATCH] Fix lost serial TX interrupts. Report receive overruns.

2010-02-22 Thread Anthony Liguori
On 02/10/2010 04:37 PM, Justin T. Gibbs wrote: Properly formatted patch now attached. Applied. Thanks. Regards, Anthony Liguori -- Justin

Re: [Qemu-devel] [PATCH v2] add close callback for tty-based char device

2010-02-22 Thread Anthony Liguori
On 02/10/2010 07:27 PM, David Ahern wrote: v1 - v2 coding style changes Add a tty close callback. Right now if a guest device that is connected to a tty-based chardev in the host is removed, the tty is not closed. With this patch it is closed. Example use case is connecting an emulated USB

Re: [Qemu-devel] Isochronous devices support in QEMU

2010-02-22 Thread David S. Ahern
David Ahern On 02/22/2010 12:32 AM, Taimoor Mirza wrote: Hi all, I've few questions about QEMU: 1) I read in QEMU's official documentation that in case of using host system devices USB devices requiring real time streaming (i.e. USB Video Cameras) are not supported yet. Also there

[Qemu-devel] Re: [PATCH 0/8] [GIT PULL] qemu-kvm.git uq/master queue

2010-02-22 Thread Anthony Liguori
On 02/22/2010 03:26 PM, Marcelo Tosatti wrote: The following changes since commit bf76bafa5ade434ef2747caa95510ecb7946: Edgar E. Iglesias (1): crisv10: Prettify. are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka

[Qemu-devel] KVM call agenda for Feb 23

2010-02-22 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

Re: [Qemu-devel] [PATCH] QEMU e820 reservation patch

2010-02-22 Thread Kevin O'Connor
On Mon, Feb 22, 2010 at 10:33:12AM +0200, Gleb Natapov wrote: On Sun, Feb 21, 2010 at 02:13:51PM -0500, Kevin O'Connor wrote: Are you thinking of moving qemu more torwards what coreboot does, or did you have a different idea in mind? We shouldn't compare coreboot with qemu. Qemu is a

[Qemu-devel] Regression: DOSPlus 1.2-je5 doesn't boot correctly since QEMU-0.6.1

2010-02-22 Thread Roy Tam
Hi all, This is an very old regression that DOSPlus 1.2-je5 boots in QEMU 0.5~0.6.0, and 0.6.1 breaks booting DOSPlus 1.2-je5 till now. Floppy Disk Image: http://roy.reactos.me:9088/files/dp12je5.zip

[Qemu-devel] Re: Regression: DOSPlus 1.2-je5 doesn't boot correctly since QEMU-0.6.1

2010-02-22 Thread Roy Tam
2010/2/23 Roy Tam roy...@gmail.com: Hi all, This is an very old regression that DOSPlus 1.2-je5 boots in QEMU 0.5~0.6.0, and 0.6.1 breaks booting DOSPlus 1.2-je5 till now. Floppy Disk Image: http://roy.reactos.me:9088/files/dp12je5.zip OK r1049 breaks booting DOSPlus. Is it really fix the

Re: [Qemu-devel] getfd monitor command broken

2010-02-22 Thread Ed Swierk
On Mon, Feb 22, 2010 at 12:51 PM, Luiz Capitulino lcapitul...@redhat.com wrote: How do you reproduce it? Here's a test program that reproduces the problem. Start qemu with -chardev socket,id=monitor,path=/tmp/qemu-monitor,server,nowait -mon chardev=monitor,mode=readline and run check_getfd

[Qemu-devel] Re: Regression: DOSPlus 1.2-je5 doesn't boot correctly since QEMU-0.6.1

2010-02-22 Thread Roy Tam
2010/2/23 Roy Tam roy...@gmail.com: 2010/2/23 Roy Tam roy...@gmail.com: Hi all, This is an very old regression that DOSPlus 1.2-je5 boots in QEMU 0.5~0.6.0, and 0.6.1 breaks booting DOSPlus 1.2-je5 till now. Floppy Disk Image: http://roy.reactos.me:9088/files/dp12je5.zip OK r1049 breaks

[Qemu-devel] [BREAKAGE] cc84de9570ffe01a9c3c169bd62ab9586a9a080c breaks win32 build

2010-02-22 Thread Roy Tam
Hi all, cc84de9570ffe01a9c3c169bd62ab9586a9a080c breaks win32 build as there is no sigset_t in MinGW.

[Qemu-devel] Serial: not checking (lsr UART_LSR_THRE) in IER and not setting thr_ipending (Was Re: Regression: DOSPlus 1.2-je5 doesn't boot correctly since QEMU-0.6.1)

2010-02-22 Thread Roy Tam
2010/2/23 Roy Tam roy...@gmail.com: 2010/2/23 Roy Tam roy...@gmail.com: 2010/2/23 Roy Tam roy...@gmail.com: Hi all, This is an very old regression that DOSPlus 1.2-je5 boots in QEMU 0.5~0.6.0, and 0.6.1 breaks booting DOSPlus 1.2-je5 till now. Floppy Disk Image: