[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Jan Kiszka
Marcelo Tosatti wrote: On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel

Re: [Qemu-devel] [PATCH RFC 12/48] error: New error_printf() and error_vprintf()

2010-03-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Mon, 01 Mar 2010 09:54:32 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 24 Feb 2010 18:55:24 +0100 Markus Armbruster arm...@redhat.com wrote: FIXME They should return int, so

Re: [Qemu-devel] [PATCH RFC 35/48] monitor: New in_qmp_mon()

2010-03-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Mon, 01 Mar 2010 10:19:49 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 24 Feb 2010 18:55:47 +0100 Markus Armbruster arm...@redhat.com wrote: Signed-off-by: Markus

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Michael S. Tsirkin
On Mon, Mar 01, 2010 at 03:54:00PM -0600, Anthony Liguori wrote: On 03/01/2010 01:27 PM, Michael S. Tsirkin wrote: On Sun, Feb 28, 2010 at 10:39:21PM +, Paul Brook wrote: I'm sympathetic to your arguments though. As qemu is today, the above is definitely the right thing to do. But

Re: [Qemu-devel] [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests

2010-03-02 Thread Michael S. Tsirkin
On Mon, Mar 01, 2010 at 01:26:37PM +0200, Gleb Natapov wrote: On Mon, Mar 01, 2010 at 12:14:43PM +0100, Alexander Graf wrote: On 14.09.2009, at 15:31, Yan Vugenfirer wrote: Signed-off-by: Yan Vugenfirer yvuge...@redhat.com --- hw/virtio-pci.c | 14 -- 1 files

Re: [Qemu-devel] Re: EHCI support in QEMU

2010-03-02 Thread Kevin Wolf
Am 01.03.2010 22:17, schrieb Jan Kiszka: Niels de Vos wrote: If someone is interested in this partially ported patch, I'm happy to share, but it will at least need some attention to make it compile. After that, lots of tests need to be done and probably quite some bugfixes are required. I'm

RE: [Qemu-devel] Errors while building qemu

2010-03-02 Thread Taimoor Mirza
I've not passed any switch to enable or disable libcurl. I just downloaded QEMU 0.12.2, ran ./configure and then make which gives me errors Also I've few questions 1) How can I enable or disable something? 2) How can I change config-host.h. Actually I want to configure gadget fs

Re: [Qemu-devel] [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests

2010-03-02 Thread Alexander Graf
On 02.03.2010, at 11:09, Michael S. Tsirkin wrote: On Mon, Mar 01, 2010 at 01:26:37PM +0200, Gleb Natapov wrote: On Mon, Mar 01, 2010 at 12:14:43PM +0100, Alexander Graf wrote: On 14.09.2009, at 15:31, Yan Vugenfirer wrote: Signed-off-by: Yan Vugenfirer yvuge...@redhat.com ---

Re: [Qemu-devel] [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests

2010-03-02 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 12:03:15PM +0100, Alexander Graf wrote: On 02.03.2010, at 11:09, Michael S. Tsirkin wrote: On Mon, Mar 01, 2010 at 01:26:37PM +0200, Gleb Natapov wrote: On Mon, Mar 01, 2010 at 12:14:43PM +0100, Alexander Graf wrote: On 14.09.2009, at 15:31, Yan Vugenfirer

[Qemu-devel] [PATCH] qemu-img rebase: Add -f option

2010-03-02 Thread Kevin Wolf
Allow the user to specify the format of the image to rebase. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 258dc62..7fc980a 100644 --- a/qemu-img.c +++

Re: [Qemu-devel] [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests

2010-03-02 Thread Alexander Graf
On 02.03.2010, at 12:05, Michael S. Tsirkin wrote: On Tue, Mar 02, 2010 at 12:03:15PM +0100, Alexander Graf wrote: On 02.03.2010, at 11:09, Michael S. Tsirkin wrote: On Mon, Mar 01, 2010 at 01:26:37PM +0200, Gleb Natapov wrote: On Mon, Mar 01, 2010 at 12:14:43PM +0100, Alexander Graf

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: Marcelo Tosatti wrote: On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: -

[Qemu-devel] Re: [PATCH RFC 12/48] error: New error_printf() and error_vprintf()

2010-03-02 Thread Paolo Bonzini
On 03/02/2010 09:33 AM, Markus Armbruster wrote: Paolo's error_raise() works for me, although I like error_report() a bit better. error_report is also fine, of course. But we need two names, one for simple, direct error reporting (now qemu_error()), and one for QMP-compatible error reporting

[Qemu-devel] [PATCH] qemu: printf related build fixes

2010-03-02 Thread Michael S. Tsirkin
Some versions of glibc (e.g. globc 2.5 that ships with rhel5.4) make printf a macro. This makes using preprocessor within calls to printf illegal. Move preprocessor use outside printf calls. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- qemu-img.c |5 +++-- readline.c |1 + vl.c

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Paul Brook
I think this assumption is unsafe. There are machines where RAM mappings can change. It's not uncommon for a chip select (i.e. physical memory address region) to be switchable to several different sources, one of which may be RAM. I'm pretty sure this functionality is present (but not

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Anthony Liguori
On 03/02/2010 08:33 AM, Paul Brook wrote: I think this assumption is unsafe. There are machines where RAM mappings can change. It's not uncommon for a chip select (i.e. physical memory address region) to be switchable to several different sources, one of which may be RAM. I'm pretty sure this

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Paul Brook
With a new api, cpu_physical_memory_map() changes semantics. It only returns pointers for static ram mappings. Everything else is bounced which guarantees that an address can't change during DMA. Doesn't this mean that only the initial RAM is directly DMA-able? While memory

Re: [Qemu-devel] can i get the QEMU source code for ARM host platform?

2010-03-02 Thread Paul Brook
I want to port QEMU on the ARM11 platform. I think, many developers try to this work. Should already work. Paul

[Qemu-devel] Re: [PATCH] qemu: printf related build fixes

2010-03-02 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 03:25:40PM +0200, Michael S. Tsirkin wrote: Some versions of glibc (e.g. globc 2.5 that ships with rhel5.4) make printf a macro. This makes using preprocessor within calls to printf illegal. Move preprocessor use outside printf calls. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Anthony Liguori
On 03/02/2010 08:55 AM, Paul Brook wrote: With a new api, cpu_physical_memory_map() changes semantics. It only returns pointers for static ram mappings. Everything else is bounced which guarantees that an address can't change during DMA. Doesn't this mean that only the initial RAM

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Paul Brook
The key difference is that these regions are created and destroyed rarely and in such a way that the destruction is visible to the guest. So you're making ram unmap an asynchronous process, and requiring that the address space not be reused until that umap has completed? It

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 03:53:30PM +, Paul Brook wrote: The key difference is that these regions are created and destroyed rarely and in such a way that the destruction is visible to the guest. So you're making ram unmap an asynchronous process, and requiring that the address

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Anthony Liguori
On 03/02/2010 09:53 AM, Paul Brook wrote: The key difference is that these regions are created and destroyed rarely and in such a way that the destruction is visible to the guest. So you're making ram unmap an asynchronous process, and requiring that the address space not be reused

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Marcelo Tosatti
On Sun, Feb 28, 2010 at 02:57:56PM -0600, Anthony Liguori wrote: On 02/28/2010 11:19 AM, Michael S. Tsirkin wrote: Both have security implications so I think it's important that they be addressed. Otherwise, I'm pretty happy with how things are. Care suggesting some solutions? The

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Jan Kiszka
Marcelo Tosatti wrote: On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: Marcelo Tosatti wrote: On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: -

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 10:12:05AM -0600, Anthony Liguori wrote: On 03/02/2010 09:53 AM, Paul Brook wrote: The key difference is that these regions are created and destroyed rarely and in such a way that the destruction is visible to the guest. So you're making ram unmap an asynchronous

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Anthony Liguori
On 03/02/2010 10:12 AM, Marcelo Tosatti wrote: On Sun, Feb 28, 2010 at 02:57:56PM -0600, Anthony Liguori wrote: On 02/28/2010 11:19 AM, Michael S. Tsirkin wrote: Both have security implications so I think it's important that they be addressed. Otherwise, I'm pretty happy with how

[Qemu-devel] [PATCH RFC] vhost: ring: verify ring is not being moved

2010-03-02 Thread Michael S. Tsirkin
abort if it is Signed-off-by: Michael S. Tsirkin m...@redhat.com --- So the following is a simple solution for unstable ring mappings security issue: simply detect this and stop. Will repost series with this later after some testing, but this is an RFC to get early feedback if any. hw/vhost.c

[Qemu-devel] Re: [PATCH RFC] vhost: ring: verify ring is not being moved

2010-03-02 Thread Anthony Liguori
On 03/02/2010 10:54 AM, Michael S. Tsirkin wrote: abort if it is Signed-off-by: Michael S. Tsirkinm...@redhat.com --- So the following is a simple solution for unstable ring mappings security issue: simply detect this and stop. Will repost series with this later after some testing, but this

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 10:56:48AM -0600, Anthony Liguori wrote: On 03/02/2010 10:12 AM, Marcelo Tosatti wrote: On Sun, Feb 28, 2010 at 02:57:56PM -0600, Anthony Liguori wrote: On 02/28/2010 11:19 AM, Michael S. Tsirkin wrote: Both have security implications so I think it's

[Qemu-devel] Re: [PATCHv2 02/12] kvm: add API to set ioeventfd

2010-03-02 Thread Michael S. Tsirkin
On Thu, Feb 25, 2010 at 01:19:30PM -0600, Anthony Liguori wrote: On 02/25/2010 12:28 PM, Michael S. Tsirkin wrote: Comment on kvm usage: rather than require users to do if (kvm_enabled()) and/or ifdefs, this patch adds an API that, internally, is defined to stub function on non-kvm build, and

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 10:56:48AM -0600, Anthony Liguori wrote: On 03/02/2010 10:12 AM, Marcelo Tosatti wrote: On Sun, Feb 28, 2010 at 02:57:56PM -0600, Anthony Liguori wrote: On 02/28/2010 11:19 AM, Michael S. Tsirkin wrote: Both have security implications so I think it's important that

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Anthony Liguori
On 03/02/2010 12:00 PM, Marcelo Tosatti wrote: - it always returns a transient mapping - it may (transparently) bounce - it may fail to bounce, caller must deal The new function I'm proposing has the following semantics: What exactly are the purposes of the new function? We need an

[Qemu-devel] [PATCH 11/20] eepro100: Use symbolic names for bits in EEPROM id

2010-03-02 Thread Stefan Weil
V2 - Use UPPER_CASE for enum values Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index c2ff569..2a871b8 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@

[Qemu-devel] [PATCH 03/20] eepro100: Fix PXE boot

2010-03-02 Thread Stefan Weil
The phy handling was wrong for PXE, GPXE boot: GPXE's eepro100 driver did not detect a valid link. This is fixed here. V2 - Use UPPER_CASE for enum values Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 20 ++-- 1 files changed, 14 insertions(+), 6

[Qemu-devel] [PATCHv3 00/12] vhost-net: upstream integration

2010-03-02 Thread Michael S. Tsirkin
Here's a patchset with vhost support for upstream qemu, rabed to latest bits. Note that irqchip/MSI is no longer required for vhost, but you should not expect performance gains from vhost unless in-kernel irqchip is enabled (which is not in upstream qemu now), and unless guest enables MSI. A

[Qemu-devel] [PATCHv3 01/12] tap: add interface to get device fd

2010-03-02 Thread Michael S. Tsirkin
Will be used by vhost to attach/detach to backend. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 7a7320c..fc59fd4 100644 --- a/net/tap.c +++

[Qemu-devel] [PATCHv3 02/12] kvm: add API to set ioeventfd

2010-03-02 Thread Michael S. Tsirkin
Comment on kvm usage: rather than require users to do if (kvm_enabled()) and/or ifdefs, this patch adds an API that, internally, is defined to stub function on non-kvm build, and checks kvm_enabled for non-kvm run. While rest of qemu code still uses if (kvm_enabled()), I think this approach is

[Qemu-devel] [PATCHv3 03/12] notifier: event notifier implementation

2010-03-02 Thread Michael S. Tsirkin
event notifiers are slightly generalized eventfd descriptors. Current implementation depends on eventfd because vhost is the only user, and vhost depends on eventfd anyway, but a stub is provided for non-eventfd case. We'll be able to further generalize this when another user comes along and we

[Qemu-devel] [PATCHv3 04/12] virtio: add notifier support

2010-03-02 Thread Michael S. Tsirkin
Add binding API to set host/guest notifiers. Will be used by vhost. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c |5 - hw/virtio.h |3 +++ 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 7c020a3..1f5e7be 100644 ---

[Qemu-devel] [PATCHv3 05/12] virtio: add APIs for queue fields

2010-03-02 Thread Michael S. Tsirkin
vhost needs physical addresses for ring and other queue fields, so add APIs for these. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c | 76 +++ hw/virtio.h | 15 +++- 2 files changed, 90 insertions(+), 1

[Qemu-devel] [PATCHv3 06/12] virtio: add set_status callback

2010-03-02 Thread Michael S. Tsirkin
vhost net backend needs to be notified when frontend status changes. Add a callback, similar to set_features. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/s390-virtio-bus.c |4 +++- hw/syborg_virtio.c |2 +- hw/virtio-pci.c |5 +++-- hw/virtio.h |9

[Qemu-devel] [PATCHv3 07/12] virtio: move typedef to qemu-common

2010-03-02 Thread Michael S. Tsirkin
make it possible to use type without header include Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.h b/hw/virtio.h index 58b06bf..6f2fab0 100644 --- a/hw/virtio.h +++

[Qemu-devel] [PATCHv3 08/12] virtio-pci: fill in notifier support

2010-03-02 Thread Michael S. Tsirkin
Support host/guest notifiers in virtio-pci. The last one only with kvm, that's okay because vhost relies on kvm anyway. Note on kvm usage: kvm ioeventfd API is implemented on non-kvm systems as well, this is the reason we don't need if (kvm_enabled()) around it. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv3 09/12] vhost: vhost net support

2010-03-02 Thread Michael S. Tsirkin
This adds vhost net device support in qemu. Will be tied to tap device and virtio by following patches. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Makefile.target |2 + configure | 36 +++

[Qemu-devel] [PATCHv3 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Michael S. Tsirkin
This adds vhost binary option to tap, to enable vhost net accelerator. Default is off for now, we'll be able to make default on long term when we know it's stable. vhostfd option can be used by management, to pass in the fd. Assigning vhostfd implies vhost=on. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv3 12/12] virtio-net: vhost net support

2010-03-02 Thread Michael S. Tsirkin
This connects virtio-net to vhost net backend. The code is structured in a way analogous to what we have with vnet header capability in tap. We start/stop backend on driver start/stop as well as on save and vm start (for migration). Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCHv3 11/12] tap: add API to retrieve vhost net header

2010-03-02 Thread Michael S. Tsirkin
will be used by virtio-net for vhost net support Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 19c4fa2..35c05d7 100644 --- a/net/tap.c +++

[Qemu-devel] Loading RAM from /dev/shm

2010-03-02 Thread Piotr 'deletek' Kupisiewicz
Hi all, As far as qemu makes use of /dev/shm - we can access RAM of any VM running on the system. This gives some nice possibility of copying that RAM to some physical location (disk) and restore it later (something like snapshot, but we can make /dev/shm working in diff way and lot more).

[Qemu-devel] Re: [PATCH 03/20] eepro100: Fix PXE boot

2010-03-02 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 07:43:36PM +0100, Stefan Weil wrote: The phy handling was wrong for PXE, GPXE boot: GPXE's eepro100 driver did not detect a valid link. This is fixed here. V2 - Use UPPER_CASE for enum values Signed-off-by: Stefan Weil w...@mail.berlios.de Please repost the

[Qemu-devel] [PATCHv3 01/20] eepro100: Fix compiler errors from debug messages

2010-03-02 Thread Stefan Weil
When debug output was enabled (by defining DEBUG_EEPRO100), some debug messages resulted in a compiler error. This is fixed here. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/eepro100.c

[Qemu-devel] [PATCHv3 03/20] eepro100: Fix PXE boot

2010-03-02 Thread Stefan Weil
The phy handling was wrong for PXE, GPXE boot: GPXE's eepro100 driver did not detect a valid link. This is fixed here. V2 - Use UPPER_CASE for enum values Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 20 ++-- 1 files changed, 14 insertions(+), 6

[Qemu-devel] [PATCHv3 02/20] eepro100: Add missing SCB register names

2010-03-02 Thread Stefan Weil
Some system control block registers were addressed using their offset value. Use symbolic names now and clean the documentation. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCHv3 05/20] eepro100: Add all supported devices to pci.c

2010-03-02 Thread Stefan Weil
All eepro100 devices work with drivers which only use basic features. They were tested with gpxe boot. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/pci.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index

[Qemu-devel] [PATCHv3 07/20] eepro100: Update copyright notice

2010-03-02 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 8ee4087..6c11209 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -1,15 +1,15 @@ /* * QEMU i8255x (PRO100)

[Qemu-devel] [PATCHv3 06/20] eepro100: Add TODO list

2010-03-02 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index c072e90..8ee4087 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -31,6 +31,14 @@ * * Intel 8255x 10/100 Mbps

[Qemu-devel] [PATCHv3 08/20] eepro100: Add device descriptions

2010-03-02 Thread Stefan Weil
Add descriptions for all devices. These descriptions are shown when users call qemu -device ? Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index

[Qemu-devel] [PATCHv3 10/20] eepro100: Remove old unused code

2010-03-02 Thread Stefan Weil
This code is no longer needed. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index a58c640..c2ff569 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@

[Qemu-devel] [PATCHv3 14/20] eepro100: Fix CU Start command

2010-03-02 Thread Stefan Weil
CU Start is allowed when the CU is in the idle or suspended state. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 40d8db5..a9bf7a0 100644 --- a/hw/eepro100.c

[Qemu-devel] [PATCHv3 13/20] eepro100: Support RNR interrupt

2010-03-02 Thread Stefan Weil
The RNR interrupt is triggered under these conditions: * the RU is not ready to receive a frame due to missing resources * the RU is ready and a RU abort command was requested Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 13 ++--- 1 files changed, 10

[Qemu-devel] [PATCHv3 11/20] eepro100: Use symbolic names for bits in EEPROM id

2010-03-02 Thread Stefan Weil
V2 - Use UPPER_CASE for enum values Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index c2ff569..2a871b8 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@

[Qemu-devel] [PATCHv3 12/20] eepro100: Replace variable name to fix a compiler warning

2010-03-02 Thread Stefan Weil
When compiling with -Wshadow, gcc gives a warning which is fixed by renaming stat - status. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 2a871b8..7eaa876

[Qemu-devel] [PATCHv3 09/20] eepro100: Use symbolic names and BIT macros in binary operations

2010-03-02 Thread Stefan Weil
Instead of magic numbers like 0x8000, symbolic names are used for the SCB command and status bits. There are too many configuration bits to use symbolic names there, too. Using the BIT macro is a little help when comparing code and documentation. For the same reason, some other constants were

[Qemu-devel] [PATCHv3 16/20] eepro100: Use tx.status

2010-03-02 Thread Stefan Weil
There is no need for a local variable status. Using tx.status makes it clearer which status is addressed. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index

[Qemu-devel] [PATCHv3 15/20] eepro100: Prettify code (no functional changes)

2010-03-02 Thread Stefan Weil
* Fix indentation. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index a9bf7a0..cf4e0ac 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -188,11 +188,11 @@ typedef

[Qemu-devel] [PATCHv3 17/20] eepro100: New function for reading command block

2010-03-02 Thread Stefan Weil
Move code which reads the command block to the new function read_cb. The patch also fixes some endianess issues related to the command block and moves declarations of local variables to the beginning of the block. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 42

[Qemu-devel] [PATCHv3 18/20] eepro100: Add diagnose command

2010-03-02 Thread Stefan Weil
Real hardware would run an internal self-test. The emulation just returns a passed status. Original patch was from Reimar Döffinger, thanks. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCHv3 20/20] eepro100: Keep includes sorted

2010-03-02 Thread Stefan Weil
I always try to keep standard includes sorted and add a comment why they are there (so they can be removed when they are no longer needed). Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/eepro100.c

[Qemu-devel] [PATCHv3 19/20] eepro100: Remove C++ comments

2010-03-02 Thread Stefan Weil
C++ comments are unwanted, so this is fixed here. * Replace C++ comments by C comments. * Put code which was deactivated by a C++ comment in #if 0...#endif. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 185 +++-- 1

Re: [Qemu-devel] tcg/arm fixes and improvements

2010-03-02 Thread andrzej zaborowski
On 1 March 2010 22:33, Aurelien Jarno aurel...@aurel32.net wrote: This patch series fix a bug in div2/divu2 ops, implement setcond and setcond2 ops and improve brcond/setcond by allowing immediate constants. Thanks, pushed the four changes + added a missing break after setcond2. I'm not

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-02 Thread Paul Brook
The new function I'm proposing has the following semantics: - it always returns a persistent mapping - it never bounces - it will only fail if the mapping isn't ram So you're assuming that virtio rings are in ram that is not hot-pluggable or remapable, and the whole region is contiguous?

Re: [Qemu-devel] Intel PXA270 System-on-chip emulation in QEMU

2010-03-02 Thread andrzej zaborowski
Hi Taimoor, On 1 March 2010 09:01, Taimoor Mirza mooni_mi...@hotmail.com wrote: I want to know about Intel PXA270 System-on-chip emulation in QEMU. Does this emulation includes USB client controller emulation? If you mean usb slave or device support, no, it's not supported by Qemu's PXA270

Re: [Qemu-devel] [PATCH] Fix curses return key when using -k

2010-03-02 Thread andrzej zaborowski
On 28 February 2010 15:35, Samuel Thibault samuel.thiba...@gnu.org wrote: Hello, There is a small incoherency in curses_keys.h, which makes it fail to emit \n when using e.g. -k fr: curses2keysym transforms \r and 0x157 into \n, but name2keysym binds \r with Return, not \n.  The patch below

[Qemu-devel] VGA doesn't work on isapc target

2010-03-02 Thread Agarwal, Lomesh
I have downloaded qemu 0.12.3 and successfully compiled it on Ubuntu 9.10 I can boot Linux disk image from qemu download site. Now I want to boot a compiled Linux image for 486 on a 486 target. For this purpose I use the following command - qemu -M isapc -kernel

[Qemu-devel] Re: [PATCH] Added Cortex_a8_v3 version, and added a shift instruction for NEON.

2010-03-02 Thread George Karavaev
Here's the patch after suggested changes. --- target-arm/cpu.h |1 + target-arm/helper.c|3 +++ target-arm/translate.c | 16 +--- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 4a1c53f..8751402 100644 ---

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 05:31:09PM +0100, Jan Kiszka wrote: Marcelo Tosatti wrote: On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: Marcelo Tosatti wrote: On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related

[Qemu-devel] [PATCH] qemu-img: Fix error Unknown option 'size' when using host_device format

2010-03-02 Thread Bitti
qemu-kvm-0.11.0 When I run: sudo qemu-img convert ubuntu-kvm/disk0.qcow2 -O host_device /dev/vg01/vm_test I get this: Unknown option 'size' Ubuntu Bug: https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/460542 Signed-off-by: Bitti bitaro...@gmail.com --- --- block/raw-posix.c.orig

[Qemu-devel] Possible invalid emulation of rex.W-prefixed far jump

2010-03-02 Thread Brad Spengler
Hi all, I'm writing to report a possible bug in the qemu emulation of rex.W-prefixed far jumps. It affects far jumps of this type with both rip-relative and absolute addresses. The yasm syntax for these instructions: jmp far qword [addr] jmp far qword [addr wrt rip] and the resulting