[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

On 03/04/2010 04:46 PM, Michael Tokarev wrote: Hello. There are a few bugs filed about an.. interesting behavour. For example: http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html https://bugs.launchpad.net/qemu/+bug/513273 After quite some mix-n-matching, at least on my test ma

[Qemu-devel] [PATCH] EHCI support - device recognized, but no data

Jan: I spent some more time on the EHCI support today. With the attached patch (delta to the patch from yesterday) a USB key is recognized within the guest (FC-12): scsi 2:0:0:0: Direct-Access Kingston DT HyperXPMAP PQ: 0 ANSI: 0 CCS sd 2:0:0:0: Attached scsi generic sg1 type 0 sd 2:0

[Qemu-devel] pc-bios/bios.bin - where it comes from?

Hello. There are a few bugs filed about an.. interesting behavour. For example: http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html https://bugs.launchpad.net/qemu/+bug/513273 After quite some mix-n-matching, at least on my test machine, I can say that the issue gets triggered by s

[Qemu-devel] Re: [PATCH] block: add logical_block_size property

Am Donnerstag 04 März 2010 14:20:17 schrieb Christoph Hellwig: > > Add a logical block size attribute as various guest side tools only > increase the filesystem sector size based on it, not the advisory > physical block size. > > For scsi we already have support for a different logical block size

[Qemu-devel] Re: [PATCH 02/17] vrtio-9p: Implement P9_TVERSION for 9P

On Thu, 4 Mar 2010 11:23:24 +0200, "Michael S. Tsirkin" wrote: > On Wed, Mar 03, 2010 at 01:00:59PM -0600, Anthony Liguori wrote: > > [ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion] > > > > Signed-off-by: Anthony Liguori > > Signed-off-by: Aneesh Kumar K.V > > --- > > hw/virtio-9p.

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

On Wed, 3 Mar 2010 23:35:36 +0300 (MSK), malc wrote: > On Wed, 3 Mar 2010, Anthony Liguori wrote: > > > This get the mount to work on the guest > > > > [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] > > > > Signed-off-by: Anthony Liguori > > Signed-off-by: Gautham R Shenoy > > S

[Qemu-devel] [PATCH] tcg/arm: implement andc op

Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |4 tcg/arm/tcg-target.h |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index dabc0f5..756f131 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -14

[Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

TCG internal helpers only access to the values passed in arguments, and do not modify the CPU internal state. Thus they can be declared as const and pure. Signed-off-by: Aurelien Jarno --- tcg/tcg-op.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op.h b

[Qemu-devel] [PATCH 2/3] tcg/arm: use helpers for divu/remu

Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 94 -- tcg/arm/tcg-target.h |1 - 2 files changed, 0 insertions(+), 95 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 756f131..0ff8f99 100644 --- a/tcg/arm/

[Qemu-devel] [PATCH 1/3] tcg: add div/rem 32-bit helpers

Some targets like ARM would benefit to use 32-bit helpers for div/rem/divu/remu. Create a #define for div2 so that targets can select between div, div2 and helpers implementation. Use the helpers version if none of the #define are present. Signed-off-by: Aurelien Jarno --- tcg-runtime.c

[Qemu-devel] [PATCH 0/3] tcg/arm: fix division

The division on TCG ARM is currently broken due to to wrong constraints: "1" and "2" are interpreted as arguments aliasing instead of constraints. This could obviously be fixed, but the division on TCG ARM becomes quite complex: for no obvious reason div2/divu2 are implemented instead of div/div

[Qemu-devel] [PATCH] tcg: add div/rem 32-bit helpers

Some targets like ARM would benefit to use 32-bit helpers for div/rem/divu/remu. Create a #define for div2 so that targets can select between div, div2 and helper implementation. Use the helper version if none of the #define are present. Signed-off-by: Aurelien Jarno --- tcg-runtime.c

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

* Aurelien Jarno [2010-03-04 15:27]: > On Tue, Feb 23, 2010 at 06:02:15PM +0100, Aurelien Jarno wrote: > > Ryan Harper a écrit : > > > Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M > > > memsize. > > > This patch adds a simple check and error message (much like the 2047 > >

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

On Tue, Feb 23, 2010 at 06:02:15PM +0100, Aurelien Jarno wrote: > Ryan Harper a écrit : > > Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize. > > This patch adds a simple check and error message (much like the 2047 limit > > on > > 32-bit hosts) on ram_size in the contro

Re: [Qemu-devel] [RFC] Documentation: Create qemu-doc.html with makeinfo instead of html2texi

Aurelien Jarno schrieb: > On Fri, Feb 12, 2010 at 11:43:28AM +0100, Stefan Weil wrote: >> Hello, >> >> today, html documentation is created using texi2html. >> >> makeinfo can also create html output which looks different. >> I think it looks better, but try it yourself: >> >> texi2html (old): >> h

[Qemu-devel] [PATCH] Documentation: Modify rule for html output (better looking output format)

To create html output from texi input, texi2html was used. Output from makeinfo looks cleaner, so replace the old rule and use makeinfo now. For those who want to use their own variant of html output, the macros MAKEINFO and MAKEINFOFLAGS allow customisation. Option "-I ." is not needed (the curre

[Qemu-devel] Re: [PATCH 45/50] qemu-option: Functions to convert to/from QDict

On Thu, 04 Mar 2010 22:12:01 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 4 Mar 2010 16:57:06 +0100 > > Markus Armbruster wrote: > > > >> The functions are somewhat restricted. Good enough for the job at > >> hand. We'll extend them when we need more. > >> > >> Si

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

On Thu, 04 Mar 2010 22:06:42 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 4 Mar 2010 16:56:49 +0100 > > Markus Armbruster wrote: > > > >> While fully converted handlers are not supposed to print anything when > >> running in a QMP monitor, they are free to print in a

[Qemu-devel] Re: [PATCH 45/50] qemu-option: Functions to convert to/from QDict

Luiz Capitulino writes: > On Thu, 4 Mar 2010 16:57:06 +0100 > Markus Armbruster wrote: > >> The functions are somewhat restricted. Good enough for the job at >> hand. We'll extend them when we need more. >> >> Signed-off-by: Markus Armbruster >> --- >> qemu-option.c | 79 >>

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

Luiz Capitulino writes: > On Thu, 4 Mar 2010 16:56:49 +0100 > Markus Armbruster wrote: > >> While fully converted handlers are not supposed to print anything when >> running in a QMP monitor, they are free to print in a human monitor. > > I disagree. > > One of the key decisions behind the ne

[Qemu-devel] Re: [PATCH 45/50] qemu-option: Functions to convert to/from QDict

On Thu, 4 Mar 2010 16:57:06 +0100 Markus Armbruster wrote: > The functions are somewhat restricted. Good enough for the job at > hand. We'll extend them when we need more. > > Signed-off-by: Markus Armbruster > --- > qemu-option.c | 79 > ++

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster wrote: > While fully converted handlers are not supposed to print anything when > running in a QMP monitor, they are free to print in a human monitor. I disagree. One of the key decisions behind the new Monitor design is that handlers are p

[Qemu-devel] [PATCH] Makefile: Fix names of GPXE ROM files

da51e79b7ff2126cc2448749d657a4f6e3b1270f added two new ROM files and removed an old one for eepro100.c. These changes were missing in Makefile (which resulted in a broken "make install"). Reported by Lucas Meneghel Rodrigues, thanks. Signed-off-by: Stefan Weil --- Makefile |4 +++- 1 files

[Qemu-devel] Re: Build failure for upstream qemu 04-03-2010

Anthony Liguori schrieb: > It was broken by: > > commit da51e79b7ff2126cc2448749d657a4f6e3b1270f > Author: Stefan Weil > Date: Tue Mar 2 22:37:44 2010 +0100 > > eepro100: Support gpxe boot for all eepro100 devices > > Only two boot ROM files are needed for all devices. > > * Add thes

[Qemu-devel] Re: Build failure for upstream qemu 04-03-2010

It was broken by: commit da51e79b7ff2126cc2448749d657a4f6e3b1270f Author: Stefan Weil Date: Tue Mar 2 22:37:44 2010 +0100 eepro100: Support gpxe boot for all eepro100 devices Only two boot ROM files are needed for all devices. * Add these GPXE ROM files using new naming conventi

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: > > The regression seems to be caused by seabios commit d7e998f. Kevin, the > > failure can be seen on the attached screenshot, which happens on the > > first reboot of

[Qemu-devel] Build failure for upstream qemu 04-03-2010

Hi folks, I found this problem trying to build qemu from the qemu.git repo: 03/04 13:07:34 ERROR| kvm:0061| Test failed: Command failed, rc=2, Command returned non-zero exit status * Command: make install Exit status: 2 Duration: 0 stdout: install -d -m0755 -p "/usr/local/autotest/te

Re: [Qemu-devel] [PATCH] Check for invalid initrd file

M. Mohan Kumar wrote: > From c5dca54f67ec6aac16c6c5e09958417b2b3ee5a1 Mon Sep 17 00:00:00 2001 > From: M. Mohan Kumar > Date: Thu, 4 Mar 2010 14:23:07 +0530 > Subject: [PATCH] Check for invalid initrd file > > When qemu is invoked with an invalid initrd file, it crashes. Following > patch prints

[Qemu-devel] [PATCH 17/50] error: Rename qemu_error_new() to qerror_report()

Signed-off-by: Markus Armbruster --- hw/qdev.c|2 +- monitor.c| 80 +- qemu-error.c |6 ++-- qemu-error.h | 10 +++--- 4 files changed, 49 insertions(+), 49 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index f170ea0.

[Qemu-devel] [PATCH 36/50] error: New QERR_DEVICE_NO_BUS

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index b79b4fa..733723e 100644 --- a/qerror.c +++ b/qerror.c @@ -73,6 +73,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 25/50] qdev: Hide "no_user" devices from users

Users can't create them, so qdev_device_help() shouldn't list them. Fix that. Also make qdev_device_add() pretend they don't exist. Before, it rejected them with a "can't be added via command line" message, which wasn't quite right for monitor command device_add. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH 30/50] error: New QERR_PROPERTY_NOT_FOUND

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 41ff946..4de1039 100644 --- a/qerror.c +++ b/qerror.c @@ -105,6 +105,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 27/50] monitor: New monitor_cur_is_qmp()

Signed-off-by: Markus Armbruster --- monitor.c |6 ++ monitor.h |2 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 55d78d5..3580d37 100644 --- a/monitor.c +++ b/monitor.c @@ -194,6 +194,12 @@ static inline int monitor_ctrl_mode(const Mon

[Qemu-devel] [PATCH 50/50] monitor: convert do_device_add() to QObject

Signed-off-by: Markus Armbruster --- hw/qdev.c | 42 ++ hw/qdev.h |2 +- qemu-monitor.hx |3 ++- 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 241f204..35e7a88 100644 --- a/hw/qdev.c +++

[Qemu-devel] [PATCH 43/50] Revert "qdev: Use QError for 'device not found' error"

This reverts commit 3ced9f7a36189aed94d8bf86f3f5087a53012455. The next commit will convert all of qdev_device_add() to QError, and it'll be clearer with this partial conversion reverted. Signed-off-by: Markus Armbruster --- hw/qdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 33/50] qdev: Relax parsing of bus option

Treat multiple successive slashes as a one slash. Ignore trailing slashes. This is how POSIX pathnames work. Signed-off-by: Markus Armbruster --- hw/qdev.c | 26 +- 1 files changed, 17 insertions(+), 9 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 1de4ff6..40

[Qemu-devel] [PATCH 37/50] qdev: Convert qbus_find() to QError

Signed-off-by: Markus Armbruster --- hw/qdev.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 40b07fb..bbb1e44 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -216,18 +216,21 @@ DeviceState *qdev_device_add(QemuOpts *opts)

[Qemu-devel] [PATCH 44/50] error: Convert do_device_add() to QError

Conversion to QObject is still missing. Signed-off-by: Markus Armbruster --- hw/qdev.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d3204d4..e3fcc75 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -200,15 +200,15 @@ DeviceState

[Qemu-devel] [PATCH 28/50] error: Let converted handlers print in human monitor

While fully converted handlers are not supposed to print anything when running in a QMP monitor, they are free to print in a human monitor. For instance, device_add (not yet converted) prints help, and will continue to do so after conversion. Moreover, utility functions converted to QError should

[Qemu-devel] [PATCH 21/50] QemuOpts: Fix qemu_config_parse() to catch file read errors

Signed-off-by: Markus Armbruster --- qemu-config.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 2de97cd..ad130fb 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -475,6 +475,10 @@ int qemu_config_parse(FILE *fp, const char *fnam

[Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError

Signed-off-by: Markus Armbruster --- hw/qdev-properties.c |6 ++ hw/qdev.c|2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 11f7b76..780a9d8 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c

[Qemu-devel] [PATCH 29/50] error: Polish human-readable error descriptions

Also put error definitions in alphabetical order Signed-off-by: Markus Armbruster --- qerror.c | 28 ++-- qerror.h | 14 +++--- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/qerror.c b/qerror.c index b400480..41ff946 100644 --- a/qerror.c ++

[Qemu-devel] [PATCH 48/50] monitor: New argument type 'O'

In the human monitor, it declares a single optional argument to be parsed according to the QemuOptsList given by its name. In QMP, it declares an optional argument for each member of the QemuOptsList. Restriction: only lists with empty desc are supported for now. Good enough for the job at hand.

[Qemu-devel] [PATCH 22/50] error: Track locations on command line

New LOC_CMDLINE. Use it for tracking option with argument in lookup_opt(). We now report errors like this qemu: -device smbus-eeprom: Did not find I2C bus for smbus-eeprom Signed-off-by: Markus Armbruster --- qemu-error.c | 20 qemu-error.h |3 ++- vl.c

[Qemu-devel] [PATCH 46/50] qemu-option: Move the implied first name into QemuOptsList

We sometimes permit omitting the first option name, for example -device foo is short for -device driver=foo. The name to use ("driver" in the example) is passed as argument to qemu_opts_parse(). For each QemuOptsList, we use at most one such name. Move the name into QemuOptsList, and pass whether

[Qemu-devel] [PATCH 20/50] error: Track locations in configuration files

New LOC_FILE. Use it for tracking file name and line number in qemu_config_parse(). We now report errors like qemu:foo.conf:42: Did not find I2C bus for smbus-eeprom In particular, gems like this message: -device: no driver specified become almost nice now: qemu:foo.conf:44: -dev

[Qemu-devel] [PATCH 38/50] error: New error_printf_unless_qmp()

Signed-off-by: Markus Armbruster --- qemu-error.c | 11 +++ qemu-error.h |2 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index a8c178b..5d5fe37 100644 --- a/qemu-error.c +++ b/qemu-error.c @@ -41,6 +41,17 @@ void error_printf(const

[Qemu-devel] [PATCH 19/50] error: Include the program name in error messages to stderr

Signed-off-by: Markus Armbruster --- qemu-error.c | 20 +++- qemu-error.h |1 + vl.c |2 ++ 3 files changed, 22 insertions(+), 1 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index 0d673c5..214e448 100644 --- a/qemu-error.c +++ b/qemu-error.c @@ -113,13

[Qemu-devel] [PATCH 16/50] error: Replace qemu_error() by error_report()

error_report() terminates the message with a newline. Strip it it from its arguments. This fixes a few error messages lacking a newline: net_handle_fd_param()'s "No file descriptor named %s found", and tap_open()'s "vnet_hdr=1 requested, but no kernel support for IFF_VNET_HDR available" (all thre

[Qemu-devel] [PATCH 24/50] qdev: Factor qdev_create_from_info() out of qdev_create()

To make it obvious that -device and device_add can't die in hw_error(). Signed-off-by: Markus Armbruster --- hw/qdev.c | 37 ++--- 1 files changed, 22 insertions(+), 15 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 80e5c36..7bc711b 100644 --- a/hw/qdev.

[Qemu-devel] [PATCH 47/50] qemu-option: Rename find_list() to qemu_find_opts() & external linkage

Next commit wants to use it. Signed-off-by: Markus Armbruster --- qemu-config.c |8 qemu-config.h |1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index a2e0193..150157c 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -309,7 +3

[Qemu-devel] [PATCH 49/50] monitor: Use argument type 'O' for device_add

While there, improve the params help text. Signed-off-by: Markus Armbruster --- hw/qdev.c |3 +-- qemu-monitor.hx |4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 1edfce8..241f204 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -766,8 +7

[Qemu-devel] [PATCH 45/50] qemu-option: Functions to convert to/from QDict

The functions are somewhat restricted. Good enough for the job at hand. We'll extend them when we need more. Signed-off-by: Markus Armbruster --- qemu-option.c | 79 + qemu-option.h |3 ++ 2 files changed, 82 insertions(+), 0 deleti

[Qemu-devel] [PATCH 42/50] error: New QERR_NO_BUS_FOR_DEVICE

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 107161c..ece51f8 100644 --- a/qerror.c +++ b/qerror.c @@ -125,6 +125,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 34/50] error: New QERR_BUS_NOT_FOUND

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 62bb00f..e7a485e 100644 --- a/qerror.c +++ b/qerror.c @@ -41,6 +41,10 @@ static const QType qerror_type = { */ static const

[Qemu-devel] [PATCH 39/50] error: New QERR_BAD_BUS_FOR_DEVICE

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 733723e..68ef78c 100644 --- a/qerror.c +++ b/qerror.c @@ -41,6 +41,10 @@ static const QType qerror_type = { */ static const

[Qemu-devel] [PATCH 15/50] error: Don't abuse qemu_error() for non-error in scsi_hot_add()

Commit 30d335d6 converted an informational message from monitor_printf() to qemu_error(), probably because the latter doesn't need a mon argument. A later commit will make qemu_error() print additional stuff that is only appropriate for proper errors, and then this will break. Clean it up. Signe

[Qemu-devel] [PATCH 18/50] error: Infrastructure to track locations for error reporting

New struct Location holds a location. So far, the only location is LOC_NONE, so this doesn't do anything useful yet. Passing the current location all over the place would be too cumbersome. Hide it away in static cur_loc instead, and provide accessors. Print it in error_report(). Store it in Q

[Qemu-devel] [PATCH 40/50] error: New QERR_BUS_NO_HOTPLUG

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 68ef78c..b61cc33 100644 --- a/qerror.c +++ b/qerror.c @@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 06/50] monitor: Separate "default monitor" and "current monitor" cleanly

Commits 376253ec..731b0364 introduced global variable cur_mon, which points to the "default monitor" (if any), except during execution of monitor_read() or monitor_control_read() it points to the monitor from which we're reading instead (the "current monitor"). Monitor command handlers run within

[Qemu-devel] [PATCH 07/50] block: Simplify usb_msd_initfn() test for "can read bdrv key"

The old test assumes that "hotplugged" implies "we have a current monitor for reading the key". This is in fact true, but it's not obviously true. Aside: if it were false, we could pass a null pointer to monitor_read_bdrv_key_start(), which would then crash. The previous commit permits us to che

[Qemu-devel] [PATCH 13/50] error: Don't abuse qemu_error() for non-error in qdev_device_help()

qdev_device_help() prints device information with qemu_error(). A later commit will make qemu_error() print additional stuff that is only appropriate for proper errors, and then this will break. Use error_printf() instead. While there, simplify: instead of printing a buffer filled by qdev_print_

[Qemu-devel] [PATCH 31/50] error: New QERR_PROPERTY_VALUE_BAD

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 4de1039..62bb00f 100644 --- a/qerror.c +++ b/qerror.c @@ -109,6 +109,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 41/50] error: New QERR_DEVICE_INIT_FAILED

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index b61cc33..107161c 100644 --- a/qerror.c +++ b/qerror.c @@ -61,6 +61,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 08/50] monitor: Factor monitor_set_error() out of qemu_error_internal()

This separates the monitor part from the QError part. Signed-off-by: Markus Armbruster --- monitor.c | 21 + monitor.h |3 +++ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 8e2e5c3..da52cb4 100644 --- a/monitor.c +++ b/monit

[Qemu-devel] [PATCH 26/50] qdev: Hide "ptr" properties from users

Users can't set them, so qdev_device_help() shouldn't list them. Fix that. Also make qdev_prop_parse() hide them instead of printing a meaningless "has no parser" error message. Their value means nothing to users, so qdev_print_props() shouldn't print it. Fix by removing their print method. Th

[Qemu-devel] [PATCH 14/50] error: Don't abuse qemu_error() for non-error in qbus_find()

qbus_find() adds an informational line to error messages, and prints both lines with one qemu_error(). Use error_printf() for the informational line instead. While there, simplify: instead of printing buffers filled by qbus_list_bus() and qbus_list_dev() in one go, make them print it. Signed-off

[Qemu-devel] [PATCH 23/50] qdev: Fix -device and device_add to handle unsuitable bus gracefully

"device_add isa-serial,bus=pci.0" kills QEMU. Not good. Signed-off-by: Markus Armbruster --- hw/qdev.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 25e1703..80e5c36 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -204,6 +204,11 @@ DeviceStat

[Qemu-devel] [PATCH 35/50] error: New QERR_DEVICE_MULTIPLE_BUSSES

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index e7a485e..b79b4fa 100644 --- a/qerror.c +++ b/qerror.c @@ -57,6 +57,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 11/50] error: Move qemu_error & friends into their own header

Signed-off-by: Markus Armbruster --- hw/scsi-bus.c |2 +- hw/scsi-disk.c|3 +-- hw/scsi-generic.c |1 + hw/usb-serial.c |1 + hw/virtio-net.c |1 + hw/virtio-pci.c |2 +- monitor.h |1 + net/dump.c|1 + net/socket.c |2 +- ne

[Qemu-devel] [PATCH 12/50] error: New error_printf() and error_vprintf()

Signed-off-by: Markus Armbruster --- qemu-error.c | 49 ++--- qemu-error.h | 14 ++ 2 files changed, 56 insertions(+), 7 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index 63bcdcf..d20fd0f 100644 --- a/qemu-error.c +++ b/qemu-

[Qemu-devel] [PATCH 09/50] error: Move qemu_error() & friends from monitor.c to own file

They're about reporting errors, not about the monitor. Signed-off-by: Markus Armbruster --- Makefile.target |1 + monitor.c | 89 - qemu-error.c| 92 +++ 3 files changed, 93

[Qemu-devel] [PATCH 04/50] pc: Factor common code out of pc_boot_set() and cmos_init()

Code duplicated in commit 0ecdffbb. The two versions are similar, but not identical: * cmos_init() reports errors to stderr, pc_boot_set() via qemu_error(). The latter is fine for both, so pick that for the common code. * cmos_init() obeys fd_bootchk, pc_boot_set() ignores it. Make it a

[Qemu-devel] [PATCH 10/50] error: Simplify error sink setup

qemu_error_sink can either point to a monitor or a file. In practice, it always points to the current monitor if we have one, else to stderr. Simply route errors to the current monitor or else to stderr, and remove qemu_error_sink along with the functions to control it. Actually, the old code sw

[Qemu-devel] [PATCH 03/50] pc: Fix error reporting for -boot once

Commit 0ecdffbb created pc_boot_set() for use from monitor command "boot_set", via qemu_boot_set(). pc_boot_set() reports errors to cur_mon, which works fine for monitor code. Commit e0f084bf reused the function int reset handler restore_boot_devices(). Use of cur_mon is problematic in that cont

[Qemu-devel] [PATCH 00/50] Convert device_add to QObject / QError

Why this is such a big job? There are two issues with a naive conversion: * Error message degradation The error messages are worded for -device. They aren't so hot to begin with, because we typically have many -device, and to which one a message applies is often not obvious. Now, QMP w

[Qemu-devel] [PATCH 02/50] savevm: Fix -loadvm to report errors to stderr, not the monitor

A monitor may not even exist. Change load_vmstate() to use qemu_error() instead of monitor_printf(). Parameter mon is now unused, remove it. Signed-off-by: Markus Armbruster --- monitor.c |2 +- savevm.c | 24 +++- sysemu.h |2 +- vl.c |2 +- 4 files cha

[Qemu-devel] [PATCH 05/50] tools: Remove unused cur_mon from qemu-tool.c

Signed-off-by: Markus Armbruster --- qemu-tool.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qemu-tool.c b/qemu-tool.c index 18b48af..bbce99f 100644 --- a/qemu-tool.c +++ b/qemu-tool.c @@ -33,8 +33,6 @@ void qemu_service_io(void) { } -Monitor *cur_mon; - void m

[Qemu-devel] [PATCH 01/50] usb: Remove disabled monitor_printf() in usb_read_file()

The monitor_printf() reports failure. Printing is wrong, because the caller tries various arguments, and expects the function to fail for some or all. Disabled since commit 26a9e82a. Remove it. Signed-off-by: Markus Armbruster --- usb-linux.c |8 1 files changed, 0 insertions(+),

Re: [Qemu-devel] Re: EHCI support in QEMU

On Wed, Mar 3, 2010 at 11:58 PM, David S. Ahern wrote: > On 03/03/2010 04:47 PM, Jan Kiszka wrote: >> >> Thanks for your work, David and Niels! I assume that David based this on >> Niels' patch, so there is nothing to be merged? David's version built >> for me, so I pushed >> >>       git://git.ki

Re: [Qemu-devel] [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue

On 03/04/2010 09:05 AM, Marcelo Tosatti wrote: The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9: Samuel Thibault (1): (curses) Use more descriptive values are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/mast

Re: [Qemu-devel] [PULL] eepro100

On 03/03/2010 06:08 AM, Michael S. Tsirkin wrote: The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9: Samuel Thibault (1): (curses) Use more descriptive values are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.

[Qemu-devel] [PATCH 3/6] KVM: Rework of guest debug state writing

From: Jan Kiszka So far we synchronized any dirty VCPU state back into the kernel before updating the guest debug state. This was a tribute to a deficite in x86 kernels before 2.6.33. But as this is an arch-dependent issue, it is better handle in the x86 part of KVM and remove the writeback point

[Qemu-devel] [PATCH 5/6] KVM: x86: Restrict writeback of VCPU state

From: Jan Kiszka Do not write nmi_pending, sipi_vector, and mpstate unless we at least go through a reset. And TSC as well as KVM wallclocks should only be written on full sync, otherwise we risk to drop some time on state read-modify-write. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosa

[Qemu-devel] [PATCH 6/6] x86: Extend validity of bsp_to_cpu

From: Jan Kiszka As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, bsp_to_cpu can also be based on the latter directly. This will help an early user of it: KVM while initializing mp_state. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/pc.c |3 ++

[Qemu-devel] [PATCH 4/6] KVM: Rework VCPU state writeback API

From: Jan Kiszka This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in qemu_loadvm_state (writ

[Qemu-devel] [PATCH 2/6] Add option to use file backed guest memory

Port qemu-kvm's -mem-path and -mem-prealloc options. These are useful for backing guest memory with huge pages via hugetlbfs. Signed-off-by: Marcelo Tosatti CC: john cooper --- cpu-all.h |3 + exec.c | 115 -- qemu-options.

[Qemu-devel] [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue

The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9: Samuel Thibault (1): (curses) Use more descriptive values are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Avi Kivity (1): Allocate memory below 4GB

[Qemu-devel] [PATCH 1/6] Allocate memory below 4GB as one chunk

From: Avi Kivity Instead of allocating a separate chunk for the first 640KB and another for 1MB+, allocate one large chunk. This plays well in terms of alignment and size with large pages. Signed-off-by: Avi Kivity Signed-off-by: Marcelo Tosatti --- hw/pc.c | 11 ++- 1 files change

[Qemu-devel] [PATCH] scsi: update comment on the standards revision

Signed-off-by: Christoph Hellwig Index: qemu/hw/scsi-disk.c === --- qemu.orig/hw/scsi-disk.c2010-03-04 14:39:43.699022260 +0100 +++ qemu/hw/scsi-disk.c 2010-03-04 14:41:26.768255602 +0100 @@ -462,8 +462,12 @@ static int scsi_disk

[Qemu-devel] [PATCH] block: add logical_block_size property

Add a logical block size attribute as various guest side tools only increase the filesystem sector size based on it, not the advisory physical block size. For scsi we already have support for a different logical block size in place for CDROMs that we can built upon. Only my recent block device c

Re: [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set

On Thu, 4 Mar 2010, malc wrote: That's not enough, later on there's a bunch of operations assuming 32bit width... -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

On Thu, Mar 04, 2010 at 05:59:11PM +0530, Amit Shah wrote: > On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote: > > On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote: > > > On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: > > > > make it possible to use type without header

Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote: > On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote: > > On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: > > > make it possible to use type without header include > > > > Why? > > So that vhost.h does not need to includ

Re: [Qemu-devel] [PATCHv4 06/12] virtio: add set_status callback

On Thu, Mar 04, 2010 at 05:49:37PM +0530, Amit Shah wrote: > On (Wed) Mar 03 2010 [19:16:13], Michael S. Tsirkin wrote: > > vhost net backend needs to be notified when > > frontend status changes. Add a callback, > > similar to set_features. > > > > Signed-off-by: Michael S. Tsirkin > > --- > >

Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote: > On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: > > make it possible to use type without header include > > Why? So that vhost.h does not need to include virtio.h > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/virtio

Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: > make it possible to use type without header include Why? > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio.h |1 - > qemu-common.h |1 + > 2 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/virtio.h b/

Re: [Qemu-devel] [PATCHv4 06/12] virtio: add set_status callback

On (Wed) Mar 03 2010 [19:16:13], Michael S. Tsirkin wrote: > vhost net backend needs to be notified when > frontend status changes. Add a callback, > similar to set_features. > > Signed-off-by: Michael S. Tsirkin > --- > hw/s390-virtio-bus.c |2 +- > hw/syborg_virtio.c |2 +- > hw/virt

[Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set

Signed-off-by: malc --- target-i386/translate.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index a597e80..68e6df9 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -4589,9 +4589,7 @@ static tar

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

On Thu, Mar 04, 2010 at 12:35:45PM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, Mar 01, 2010 at 06:

  1   2   >