[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-04 Thread Jan Kiszka
Gleb Natapov wrote: On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, cpu_is_bsp can also be based on the latter directly. This

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-04 Thread Gleb Natapov
On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals

Re: [Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-04 Thread Gerd Hoffmann
On 03/03/10 19:53, Stefan Weil wrote: This would indeed simplify the code. Although I don't like tricky programming like DO_UPCAST (because I saw too much code where tricky programming was faulty programming), Yea, when coding C++ in C you need little tricks now and then ;) You need that in

[Qemu-devel] [PATCH v2 00/10] FORTIFY_SOURCE followup

2010-03-04 Thread Juan Quintela
Hi Series updated with yesterday comments v2: - drop un-needed slirp exit() patch (kevin) - add qemu_write_full() documentation (danp) - use strerror(-errno) (kevin, pbonzini) Please review and apply. Later, Juan. v1: This series make: - all block *_create() functions return -errno

[Qemu-devel] [PATCH 03/10] qcow2: return errno instead of -1

2010-03-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/qcow2.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index bf8170e..5b6dad9 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -851,7 +851,7 @@ static int

[Qemu-devel] [PATCH 02/10] slirp: check system() success

2010-03-04 Thread Juan Quintela
we shouldn't call W*() macros until we check that fork worked. Signed-off-by: Juan Quintela quint...@redhat.com --- net/slirp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 317cca7..7f846ec 100644 --- a/net/slirp.c +++ b/net/slirp.c @@

[Qemu-devel] [PATCH 01/10] cow: return errno instead of -1

2010-03-04 Thread Juan Quintela
Remove not needed ret = 0 assignment. Signed-off-by: Juan Quintela quint...@redhat.com --- block/cow.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/block/cow.c b/block/cow.c index 3733385..97e9745 100644 --- a/block/cow.c +++ b/block/cow.c @@ -224,7 +224,7 @@

[Qemu-devel] [PATCH 04/10] qcow: return errno instead of -1

2010-03-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/qcow.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 003db1e..c619984 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -766,7 +766,7 @@ static int qcow_create(const char

[Qemu-devel] [PATCH 05/10] vmdk: return errno instead of -1

2010-03-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 56c28a0..5b1d197 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -740,7 +740,7 @@ static int vmdk_create(const

[Qemu-devel] [PATCH 06/10] vmdk: make vmdk_snapshot_create return -errno

2010-03-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c | 79 ++--- 1 files changed, 58 insertions(+), 21 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5b1d197..67a690e 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@

[Qemu-devel] [PATCH 07/10] vmdk: fix double free

2010-03-04 Thread Juan Quintela
fail_gd error case would also free rgd_buf that was already freed Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 67a690e..819c1c9 100644 --- a/block/vmdk.c +++

[Qemu-devel] [PATCH 08/10] vmdk: share cleanup code

2010-03-04 Thread Juan Quintela
cleanup code is identical for error/success cases. Only difference are goto labels. Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 819c1c9..007fca4 100644

[Qemu-devel] [PATCH 09/10] block: print errno on error

2010-03-04 Thread Juan Quintela
Now that we changed all create calls to return errno, just print it. Signed-off-by: Juan Quintela quint...@redhat.com --- qemu-img.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 0c9f2d4..e51b40c 100644 --- a/qemu-img.c +++ b/qemu-img.c

[Qemu-devel] [PATCH 10/10] documentation: qemu_write_full don't work with non-blocking fd's

2010-03-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- osdep.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 5bf3c00..abbc8a2 100644 --- a/osdep.c +++ b/osdep.c @@ -261,6 +261,11 @@ int qemu_open(const char *name, int flags, ...) * * Return

[Qemu-devel] Re: [PATCH 02/10] slirp: check system() success

2010-03-04 Thread Michael S. Tsirkin
On Thu, Mar 04, 2010 at 10:00:31AM +0100, Juan Quintela wrote: we shouldn't call W*() macros until we check that fork worked. Signed-off-by: Juan Quintela quint...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com --- net/slirp.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH] Check for invalid initrd file

2010-03-04 Thread M. Mohan Kumar
From c5dca54f67ec6aac16c6c5e09958417b2b3ee5a1 Mon Sep 17 00:00:00 2001 From: M. Mohan Kumar mo...@in.ibm.com Date: Thu, 4 Mar 2010 14:23:07 +0530 Subject: [PATCH] Check for invalid initrd file When qemu is invoked with an invalid initrd file, it crashes. Following patch prints a error message and

[Qemu-devel] Re: [PATCH 02/17] vrtio-9p: Implement P9_TVERSION for 9P

2010-03-04 Thread Michael S. Tsirkin
On Wed, Mar 03, 2010 at 01:00:59PM -0600, Anthony Liguori wrote: [ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 263

[Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set

2010-03-04 Thread malc
Signed-off-by: malc av1...@comtv.ru --- target-i386/translate.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index a597e80..68e6df9 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -4589,9

Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

2010-03-04 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: make it possible to use type without header include Why? Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCHv4 06/12] virtio: add set_status callback

2010-03-04 Thread Michael S. Tsirkin
On Thu, Mar 04, 2010 at 05:49:37PM +0530, Amit Shah wrote: On (Wed) Mar 03 2010 [19:16:13], Michael S. Tsirkin wrote: vhost net backend needs to be notified when frontend status changes. Add a callback, similar to set_features. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

2010-03-04 Thread Amit Shah
On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote: On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote: On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: make it possible to use type without header include Why? So that vhost.h does not need to include virtio.h

Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

2010-03-04 Thread Michael S. Tsirkin
On Thu, Mar 04, 2010 at 05:59:11PM +0530, Amit Shah wrote: On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote: On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote: On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: make it possible to use type without header include

Re: [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set

2010-03-04 Thread malc
On Thu, 4 Mar 2010, malc wrote: That's not enough, later on there's a bunch of operations assuming 32bit width... -- mailto:av1...@comtv.ru

[Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-04 Thread Christoph Hellwig
Add a logical block size attribute as various guest side tools only increase the filesystem sector size based on it, not the advisory physical block size. For scsi we already have support for a different logical block size in place for CDROMs that we can built upon. Only my recent block device

[Qemu-devel] [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue

2010-03-04 Thread Marcelo Tosatti
The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9: Samuel Thibault (1): (curses) Use more descriptive values are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Avi Kivity (1): Allocate memory below 4GB

[Qemu-devel] [PATCH 4/6] KVM: Rework VCPU state writeback API

2010-03-04 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in

[Qemu-devel] [PATCH 6/6] x86: Extend validity of bsp_to_cpu

2010-03-04 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, bsp_to_cpu can also be based on the latter directly. This will help an early user of it: KVM while initializing mp_state. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

[Qemu-devel] [PATCH 5/6] KVM: x86: Restrict writeback of VCPU state

2010-03-04 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Do not write nmi_pending, sipi_vector, and mpstate unless we at least go through a reset. And TSC as well as KVM wallclocks should only be written on full sync, otherwise we risk to drop some time on state read-modify-write. Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PULL] eepro100

2010-03-04 Thread Anthony Liguori
On 03/03/2010 06:08 AM, Michael S. Tsirkin wrote: The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9: Samuel Thibault (1): (curses) Use more descriptive values are available in the git repository at:

Re: [Qemu-devel] Re: EHCI support in QEMU

2010-03-04 Thread Niels de Vos
On Wed, Mar 3, 2010 at 11:58 PM, David S. Ahern daah...@cisco.com wrote: On 03/03/2010 04:47 PM, Jan Kiszka wrote: Thanks for your work, David and Niels! I assume that David based this on Niels' patch, so there is nothing to be merged? David's version built for me, so I pushed      

[Qemu-devel] [PATCH 01/50] usb: Remove disabled monitor_printf() in usb_read_file()

2010-03-04 Thread Markus Armbruster
The monitor_printf() reports failure. Printing is wrong, because the caller tries various arguments, and expects the function to fail for some or all. Disabled since commit 26a9e82a. Remove it. Signed-off-by: Markus Armbruster arm...@redhat.com --- usb-linux.c |8 1 files

[Qemu-devel] [PATCH 05/50] tools: Remove unused cur_mon from qemu-tool.c

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-tool.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qemu-tool.c b/qemu-tool.c index 18b48af..bbce99f 100644 --- a/qemu-tool.c +++ b/qemu-tool.c @@ -33,8 +33,6 @@ void qemu_service_io(void) { } -Monitor

[Qemu-devel] [PATCH 02/50] savevm: Fix -loadvm to report errors to stderr, not the monitor

2010-03-04 Thread Markus Armbruster
A monitor may not even exist. Change load_vmstate() to use qemu_error() instead of monitor_printf(). Parameter mon is now unused, remove it. Signed-off-by: Markus Armbruster arm...@redhat.com --- monitor.c |2 +- savevm.c | 24 +++- sysemu.h |2 +- vl.c |

[Qemu-devel] [PATCH 00/50] Convert device_add to QObject / QError

2010-03-04 Thread Markus Armbruster
Why this is such a big job? There are two issues with a naive conversion: * Error message degradation The error messages are worded for -device. They aren't so hot to begin with, because we typically have many -device, and to which one a message applies is often not obvious. Now, QMP

[Qemu-devel] [PATCH 03/50] pc: Fix error reporting for -boot once

2010-03-04 Thread Markus Armbruster
Commit 0ecdffbb created pc_boot_set() for use from monitor command boot_set, via qemu_boot_set(). pc_boot_set() reports errors to cur_mon, which works fine for monitor code. Commit e0f084bf reused the function int reset handler restore_boot_devices(). Use of cur_mon is problematic in that

[Qemu-devel] [PATCH 10/50] error: Simplify error sink setup

2010-03-04 Thread Markus Armbruster
qemu_error_sink can either point to a monitor or a file. In practice, it always points to the current monitor if we have one, else to stderr. Simply route errors to the current monitor or else to stderr, and remove qemu_error_sink along with the functions to control it. Actually, the old code

[Qemu-devel] [PATCH 35/50] error: New QERR_DEVICE_MULTIPLE_BUSSES

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index e7a485e..b79b4fa 100644 --- a/qerror.c +++ b/qerror.c @@ -57,6 +57,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 23/50] qdev: Fix -device and device_add to handle unsuitable bus gracefully

2010-03-04 Thread Markus Armbruster
device_add isa-serial,bus=pci.0 kills QEMU. Not good. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 25e1703..80e5c36 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -204,6

[Qemu-devel] [PATCH 26/50] qdev: Hide ptr properties from users

2010-03-04 Thread Markus Armbruster
Users can't set them, so qdev_device_help() shouldn't list them. Fix that. Also make qdev_prop_parse() hide them instead of printing a meaningless has no parser error message. Their value means nothing to users, so qdev_print_props() shouldn't print it. Fix by removing their print method.

[Qemu-devel] [PATCH 08/50] monitor: Factor monitor_set_error() out of qemu_error_internal()

2010-03-04 Thread Markus Armbruster
This separates the monitor part from the QError part. Signed-off-by: Markus Armbruster arm...@redhat.com --- monitor.c | 21 + monitor.h |3 +++ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 8e2e5c3..da52cb4 100644 ---

[Qemu-devel] [PATCH 41/50] error: New QERR_DEVICE_INIT_FAILED

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index b61cc33..107161c 100644 --- a/qerror.c +++ b/qerror.c @@ -61,6 +61,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 06/50] monitor: Separate default monitor and current monitor cleanly

2010-03-04 Thread Markus Armbruster
Commits 376253ec..731b0364 introduced global variable cur_mon, which points to the default monitor (if any), except during execution of monitor_read() or monitor_control_read() it points to the monitor from which we're reading instead (the current monitor). Monitor command handlers run within

[Qemu-devel] [PATCH 40/50] error: New QERR_BUS_NO_HOTPLUG

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 68ef78c..b61cc33 100644 --- a/qerror.c +++ b/qerror.c @@ -49,6 +49,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 34/50] error: New QERR_BUS_NOT_FOUND

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 62bb00f..e7a485e 100644 --- a/qerror.c +++ b/qerror.c @@ -41,6 +41,10 @@ static const QType qerror_type = {

[Qemu-devel] [PATCH 42/50] error: New QERR_NO_BUS_FOR_DEVICE

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 107161c..ece51f8 100644 --- a/qerror.c +++ b/qerror.c @@ -125,6 +125,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 45/50] qemu-option: Functions to convert to/from QDict

2010-03-04 Thread Markus Armbruster
The functions are somewhat restricted. Good enough for the job at hand. We'll extend them when we need more. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-option.c | 79 + qemu-option.h |3 ++ 2 files changed, 82

[Qemu-devel] [PATCH 49/50] monitor: Use argument type 'O' for device_add

2010-03-04 Thread Markus Armbruster
While there, improve the params help text. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c |3 +-- qemu-monitor.hx |4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 1edfce8..241f204 100644 --- a/hw/qdev.c +++

[Qemu-devel] [PATCH 47/50] qemu-option: Rename find_list() to qemu_find_opts() external linkage

2010-03-04 Thread Markus Armbruster
Next commit wants to use it. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-config.c |8 qemu-config.h |1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index a2e0193..150157c 100644 --- a/qemu-config.c +++

[Qemu-devel] [PATCH 24/50] qdev: Factor qdev_create_from_info() out of qdev_create()

2010-03-04 Thread Markus Armbruster
To make it obvious that -device and device_add can't die in hw_error(). Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c | 37 ++--- 1 files changed, 22 insertions(+), 15 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 80e5c36..7bc711b

[Qemu-devel] [PATCH 16/50] error: Replace qemu_error() by error_report()

2010-03-04 Thread Markus Armbruster
error_report() terminates the message with a newline. Strip it it from its arguments. This fixes a few error messages lacking a newline: net_handle_fd_param()'s No file descriptor named %s found, and tap_open()'s vnet_hdr=1 requested, but no kernel support for IFF_VNET_HDR available (all three

[Qemu-devel] [PATCH 38/50] error: New error_printf_unless_qmp()

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-error.c | 11 +++ qemu-error.h |2 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index a8c178b..5d5fe37 100644 --- a/qemu-error.c +++ b/qemu-error.c @@ -41,6 +41,17 @@ void

[Qemu-devel] [PATCH 22/50] error: Track locations on command line

2010-03-04 Thread Markus Armbruster
New LOC_CMDLINE. Use it for tracking option with argument in lookup_opt(). We now report errors like this qemu: -device smbus-eeprom: Did not find I2C bus for smbus-eeprom Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-error.c | 20 qemu-error.h |3

[Qemu-devel] [PATCH 48/50] monitor: New argument type 'O'

2010-03-04 Thread Markus Armbruster
In the human monitor, it declares a single optional argument to be parsed according to the QemuOptsList given by its name. In QMP, it declares an optional argument for each member of the QemuOptsList. Restriction: only lists with empty desc are supported for now. Good enough for the job at

[Qemu-devel] [PATCH 29/50] error: Polish human-readable error descriptions

2010-03-04 Thread Markus Armbruster
Also put error definitions in alphabetical order Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c | 28 ++-- qerror.h | 14 +++--- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/qerror.c b/qerror.c index b400480..41ff946 100644

[Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev-properties.c |6 ++ hw/qdev.c|2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 11f7b76..780a9d8 100644 --- a/hw/qdev-properties.c +++

[Qemu-devel] [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-04 Thread Markus Armbruster
While fully converted handlers are not supposed to print anything when running in a QMP monitor, they are free to print in a human monitor. For instance, device_add (not yet converted) prints help, and will continue to do so after conversion. Moreover, utility functions converted to QError should

[Qemu-devel] [PATCH 44/50] error: Convert do_device_add() to QError

2010-03-04 Thread Markus Armbruster
Conversion to QObject is still missing. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d3204d4..e3fcc75 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -200,15

[Qemu-devel] [PATCH 37/50] qdev: Convert qbus_find() to QError

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 40b07fb..bbb1e44 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -216,18 +216,21 @@ DeviceState

[Qemu-devel] [PATCH 43/50] Revert qdev: Use QError for 'device not found' error

2010-03-04 Thread Markus Armbruster
This reverts commit 3ced9f7a36189aed94d8bf86f3f5087a53012455. The next commit will convert all of qdev_device_add() to QError, and it'll be clearer with this partial conversion reverted. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c |4 ++-- 1 files changed, 2

[Qemu-devel] [PATCH 50/50] monitor: convert do_device_add() to QObject

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c | 42 ++ hw/qdev.h |2 +- qemu-monitor.hx |3 ++- 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 241f204..35e7a88 100644

[Qemu-devel] [PATCH 27/50] monitor: New monitor_cur_is_qmp()

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- monitor.c |6 ++ monitor.h |2 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 55d78d5..3580d37 100644 --- a/monitor.c +++ b/monitor.c @@ -194,6 +194,12 @@ static inline int

[Qemu-devel] [PATCH 30/50] error: New QERR_PROPERTY_NOT_FOUND

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 41ff946..4de1039 100644 --- a/qerror.c +++ b/qerror.c @@ -105,6 +105,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 25/50] qdev: Hide no_user devices from users

2010-03-04 Thread Markus Armbruster
Users can't create them, so qdev_device_help() shouldn't list them. Fix that. Also make qdev_device_add() pretend they don't exist. Before, it rejected them with a can't be added via command line message, which wasn't quite right for monitor command device_add. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH 36/50] error: New QERR_DEVICE_NO_BUS

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index b79b4fa..733723e 100644 --- a/qerror.c +++ b/qerror.c @@ -73,6 +73,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 17/50] error: Rename qemu_error_new() to qerror_report()

2010-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c|2 +- monitor.c| 80 +- qemu-error.c |6 ++-- qemu-error.h | 10 +++--- 4 files changed, 49 insertions(+), 49 deletions(-) diff --git a/hw/qdev.c

Re: [Qemu-devel] [PATCH] Check for invalid initrd file

2010-03-04 Thread jvrao
M. Mohan Kumar wrote: From c5dca54f67ec6aac16c6c5e09958417b2b3ee5a1 Mon Sep 17 00:00:00 2001 From: M. Mohan Kumar mo...@in.ibm.com Date: Thu, 4 Mar 2010 14:23:07 +0530 Subject: [PATCH] Check for invalid initrd file When qemu is invoked with an invalid initrd file, it crashes. Following

[Qemu-devel] Build failure for upstream qemu 04-03-2010

2010-03-04 Thread Lucas Meneghel Rodrigues
Hi folks, I found this problem trying to build qemu from the qemu.git repo: 03/04 13:07:34 ERROR| kvm:0061| Test failed: Command make install failed, rc=2, Command returned non-zero exit status * Command: make install Exit status: 2 Duration: 0 stdout: install -d -m0755 -p

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-04 Thread Marcelo Tosatti
On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: The regression seems to be caused by seabios commit d7e998f. Kevin, the failure can be seen on the attached screenshot, which happens on the first reboot of WinXP

[Qemu-devel] Re: Build failure for upstream qemu 04-03-2010

2010-03-04 Thread Stefan Weil
Anthony Liguori schrieb: It was broken by: commit da51e79b7ff2126cc2448749d657a4f6e3b1270f Author: Stefan Weil w...@mail.berlios.de Date: Tue Mar 2 22:37:44 2010 +0100 eepro100: Support gpxe boot for all eepro100 devices Only two boot ROM files are needed for all devices.

[Qemu-devel] [PATCH] Makefile: Fix names of GPXE ROM files

2010-03-04 Thread Stefan Weil
da51e79b7ff2126cc2448749d657a4f6e3b1270f added two new ROM files and removed an old one for eepro100.c. These changes were missing in Makefile (which resulted in a broken make install). Reported by Lucas Meneghel Rodrigues, thanks. Signed-off-by: Stefan Weil w...@mail.berlios.de --- Makefile |

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-04 Thread Luiz Capitulino
On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster arm...@redhat.com wrote: While fully converted handlers are not supposed to print anything when running in a QMP monitor, they are free to print in a human monitor. I disagree. One of the key decisions behind the new Monitor design is

[Qemu-devel] Re: [PATCH 45/50] qemu-option: Functions to convert to/from QDict

2010-03-04 Thread Luiz Capitulino
On Thu, 4 Mar 2010 16:57:06 +0100 Markus Armbruster arm...@redhat.com wrote: The functions are somewhat restricted. Good enough for the job at hand. We'll extend them when we need more. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-option.c | 79

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-04 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster arm...@redhat.com wrote: While fully converted handlers are not supposed to print anything when running in a QMP monitor, they are free to print in a human monitor. I disagree. One of

[Qemu-devel] Re: [PATCH 45/50] qemu-option: Functions to convert to/from QDict

2010-03-04 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 4 Mar 2010 16:57:06 +0100 Markus Armbruster arm...@redhat.com wrote: The functions are somewhat restricted. Good enough for the job at hand. We'll extend them when we need more. Signed-off-by: Markus Armbruster arm...@redhat.com

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-04 Thread Luiz Capitulino
On Thu, 04 Mar 2010 22:06:42 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster arm...@redhat.com wrote: While fully converted handlers are not supposed to print anything when running in

[Qemu-devel] Re: [PATCH 45/50] qemu-option: Functions to convert to/from QDict

2010-03-04 Thread Luiz Capitulino
On Thu, 04 Mar 2010 22:12:01 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 4 Mar 2010 16:57:06 +0100 Markus Armbruster arm...@redhat.com wrote: The functions are somewhat restricted. Good enough for the job at hand. We'll

[Qemu-devel] [PATCH] Documentation: Modify rule for html output (better looking output format)

2010-03-04 Thread Stefan Weil
To create html output from texi input, texi2html was used. Output from makeinfo looks cleaner, so replace the old rule and use makeinfo now. For those who want to use their own variant of html output, the macros MAKEINFO and MAKEINFOFLAGS allow customisation. Option -I . is not needed (the

Re: [Qemu-devel] [RFC] Documentation: Create qemu-doc.html with makeinfo instead of html2texi

2010-03-04 Thread Stefan Weil
Aurelien Jarno schrieb: On Fri, Feb 12, 2010 at 11:43:28AM +0100, Stefan Weil wrote: Hello, today, html documentation is created using texi2html. makeinfo can also create html output which looks different. I think it looks better, but try it yourself: texi2html (old):

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size 4095M without kvm

2010-03-04 Thread Aurelien Jarno
On Tue, Feb 23, 2010 at 06:02:15PM +0100, Aurelien Jarno wrote: Ryan Harper a écrit : Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit on 32-bit hosts) on ram_size in the control path

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size 4095M without kvm

2010-03-04 Thread Ryan Harper
* Aurelien Jarno aurel...@aurel32.net [2010-03-04 15:27]: On Tue, Feb 23, 2010 at 06:02:15PM +0100, Aurelien Jarno wrote: Ryan Harper a écrit : Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple check and error message (much like the

[Qemu-devel] [PATCH] tcg: add div/rem 32-bit helpers

2010-03-04 Thread Aurelien Jarno
Some targets like ARM would benefit to use 32-bit helpers for div/rem/divu/remu. Create a #define for div2 so that targets can select between div, div2 and helper implementation. Use the helper version if none of the #define are present. Signed-off-by: Aurelien Jarno aurel...@aurel32.net ---

[Qemu-devel] [PATCH 0/3] tcg/arm: fix division

2010-03-04 Thread Aurelien Jarno
The division on TCG ARM is currently broken due to to wrong constraints: 1 and 2 are interpreted as arguments aliasing instead of constraints. This could obviously be fixed, but the division on TCG ARM becomes quite complex: for no obvious reason div2/divu2 are implemented instead of

[Qemu-devel] [PATCH 1/3] tcg: add div/rem 32-bit helpers

2010-03-04 Thread Aurelien Jarno
Some targets like ARM would benefit to use 32-bit helpers for div/rem/divu/remu. Create a #define for div2 so that targets can select between div, div2 and helpers implementation. Use the helpers version if none of the #define are present. Signed-off-by: Aurelien Jarno aurel...@aurel32.net ---

[Qemu-devel] [PATCH 2/3] tcg/arm: use helpers for divu/remu

2010-03-04 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/arm/tcg-target.c | 94 -- tcg/arm/tcg-target.h |1 - 2 files changed, 0 insertions(+), 95 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 756f131..0ff8f99

[Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-04 Thread Aurelien Jarno
TCG internal helpers only access to the values passed in arguments, and do not modify the CPU internal state. Thus they can be declared as const and pure. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/tcg-op.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH] tcg/arm: implement andc op

2010-03-04 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/arm/tcg-target.c |4 tcg/arm/tcg-target.h |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index dabc0f5..756f131 100644 --- a/tcg/arm/tcg-target.c +++

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-04 Thread Aneesh Kumar K. V
On Wed, 3 Mar 2010 23:35:36 +0300 (MSK), malc av1...@comtv.ru wrote: On Wed, 3 Mar 2010, Anthony Liguori wrote: This get the mount to work on the guest [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by:

[Qemu-devel] Re: [PATCH 02/17] vrtio-9p: Implement P9_TVERSION for 9P

2010-03-04 Thread Aneesh Kumar K. V
On Thu, 4 Mar 2010 11:23:24 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 03, 2010 at 01:00:59PM -0600, Anthony Liguori wrote: [ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V

[Qemu-devel] Re: [PATCH] block: add logical_block_size property

2010-03-04 Thread Christian Borntraeger
Am Donnerstag 04 März 2010 14:20:17 schrieb Christoph Hellwig: Add a logical block size attribute as various guest side tools only increase the filesystem sector size based on it, not the advisory physical block size. For scsi we already have support for a different logical block size in

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-04 Thread Anthony Liguori
On 03/04/2010 04:46 PM, Michael Tokarev wrote: Hello. There are a few bugs filed about an.. interesting behavour. For example: http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html https://bugs.launchpad.net/qemu/+bug/513273 After quite some mix-n-matching, at least on my test