Re: [Qemu-devel] [PATCH] tcg: add div/rem 32-bit helpers

2010-03-05 Thread Blue Swirl
On 3/4/10, Aurelien Jarno wrote: > Some targets like ARM would benefit to use 32-bit helpers for > div/rem/divu/remu. > > Create a #define for div2 so that targets can select between > div, div2 and helper implementation. Use the helper version if none > of the #define are present. > > Signed

Re: [Qemu-devel] qemu on Solaris

2010-03-05 Thread Blue Swirl
On 3/4/10, Seth G wrote: > Hi, > > I just sent a fair amount of time trying to figure out problems > with the qemu build and resulting binary. The first problem (which > is no longer a problem due to the shell OpenSolaris uses) was that > `sh' was used in rules.mak to perform commands -- I h

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-05 Thread Kevin O'Connor
On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote: > On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: > > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: > > > The regression seems to be caused by seabios commit d7e998f. Kevin, the > > > failure can be

[Qemu-devel] [PATCH] Shared memory uio_pci driver

2010-03-05 Thread Cam Macdonell
This patch adds a driver for my shared memory PCI device using the uio_pci interface. The driver exports two memory regions. The first memory region are device registers for sending interrupts and the second memory region maps the shared memory. Cam --- drivers/uio/Kconfig |8 +++ dri

[Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-05 Thread Cam Macdonell
Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository. This device now creates a qemu character device and

[Qemu-devel] [PATCH] Support adding a file to qemu's ram allocation

2010-03-05 Thread Cam Macdonell
This avoids the need of using qemu_ram_alloc and mmap with MAP_FIXED to map a host file into guest RAM. This function mmaps the opened file anywhere and adds the memory to the ram blocks. Usage is qemu_add_file_to_ram(fd, size, MAP_SHARED); --- cpu-common.h |1 + exec.c | 33 +

[Qemu-devel] [PATCH 2/2] Wrong error message in block_passwd command

2010-03-05 Thread Shahar Havivi
Signed-off-by: Shahar Havivi --- block.c |7 +-- monitor.c |7 ++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 31d1ba4..e891544 100644 --- a/block.c +++ b/block.c @@ -1134,8 +1134,11 @@ int bdrv_set_key(BlockDriverState *bs, const cha

[Qemu-devel] [PATCH 1/2] QError: New QERR_DEVICE_NOT_ENCRYPTED

2010-03-05 Thread Shahar Havivi
Signed-off-by: Shahar Havivi --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 2f657f4..4e63a54 100644 --- a/qerror.c +++ b/qerror.c @@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error

2010-03-05 Thread Shahar Havivi
The next two patches fix the wrong error message in block_passwd monitor command: when trying to decrypt un-encrypted drive, user get error wrong password. "1" add error message to qerror.h and qerror.c "2" patch the monitor command error handling Shahar Havivi (2): QError: New QERR_DEVICE_NOT_

[Qemu-devel] [PATCH] tcg: update README with const and pure helpers

2010-03-05 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/README | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/tcg/README b/tcg/README index f0e21a1..281c114 100644 --- a/tcg/README +++ b/tcg/README @@ -75,10 +75,13 @@ destroyed, but local temporaries and globals are preserved.

[Qemu-devel] [PATCH] better describe -net options

2010-03-05 Thread Brian Thomason
The manpage reflects that multiple -net user calls may be made, but if this is done, it can cause the program to hang. Instead, multiple -net calls can be combined into one, and this patch adds that information to qemu-options.hx. Also, -net user may only be used in conjunction with -net nic. This

Re: [Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Luiz Capitulino
On Fri, 05 Mar 2010 17:47:49 +0100 Markus Armbruster wrote: > Shahar Havivi writes: > > > diff --git a/qerror.c b/qerror.c > > index 2f657f4..4e63a54 100644 > > --- a/qerror.c > > +++ b/qerror.c > > @@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = { > > .desc = "

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-05 Thread Aurelien Jarno
On Fri, Mar 05, 2010 at 11:15:45AM +, Paul Brook wrote: > > TCG internal helpers only access to the values passed in arguments, and > > do not modify the CPU internal state. Thus they can be declared as > > const and pure. > > I think this needs an explanatory comment. It's not immediately obv

Re: [Qemu-devel] Re: Regression: segfault on ARM host

2010-03-05 Thread Aurelien Jarno
On Tue, Mar 02, 2010 at 01:05:29AM +0100, Aurelien Jarno wrote: > On Mon, Mar 01, 2010 at 11:33:23PM +0100, Paolo Bonzini wrote: > > On 03/01/2010 10:33 PM, Aurelien Jarno wrote: > >> While trying to implement setcond on TCG ARM, I have discovered it does > >> not work anymore. I have bisected this

[Qemu-devel] [PATCH] tcg/arm: correctly save/restore registers in prologue/epilogue

2010-03-05 Thread Aurelien Jarno
Since commit 6113d6d3169393c323ac4c82d756a850145a5e7a QEMU crashes on ARM hosts. This is not a bug of this commit, but a latent bug revealed by this commit. The TCG code is called through a procedure call using the prologue and epilogue code. This code does not save and restore enough registers. T

Re: [Qemu-devel] Re: Another VNC crash, qemu-kvm-0.12.3

2010-03-05 Thread Alexander Graf
On 05.03.2010, at 17:52, Chris Webb wrote: > Anthony Liguori writes: > >> On 03/01/2010 12:14 PM, Chris Webb wrote: >>> We've just seen another VNC related qemu-kvm crash, this time an arithmetic >>> exception at vnc.c:1424 in the newly release qemu-kvm 0.12.3. >>> >>> [...] >>> 1423 if

Re: [Qemu-devel] [PATCH] QMP: Spec: Private Extensions support

2010-03-05 Thread Markus Armbruster
Anthony asked me to take a stab at rewriting his draft to something more along the lines of what I'm thinking. Here goes. I put some remarks [in brackets]. FYI, I'll be out of town until Wednesday. 6. Downstream extension of QMP -- We recommend that downstream cons

[Qemu-devel] Re: [PATCHv4 09/12] vhost: vhost net support

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:35], Michael S. Tsirkin wrote: > +static int vhost_virtqueue_init(struct vhost_dev *dev, > +struct VirtIODevice *vdev, > +struct vhost_virtqueue *vq, > +unsigned idx) > +{ >

[Qemu-devel] Re: Another VNC crash, qemu-kvm-0.12.3

2010-03-05 Thread Chris Webb
Anthony Liguori writes: > On 03/01/2010 12:14 PM, Chris Webb wrote: > >We've just seen another VNC related qemu-kvm crash, this time an arithmetic > >exception at vnc.c:1424 in the newly release qemu-kvm 0.12.3. > > > > [...] > > 1423 if (vs->absolute) { > > 1424 kbd_mouse_event

Re: [Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Markus Armbruster
Shahar Havivi writes: > diff --git a/qerror.c b/qerror.c > index 2f657f4..4e63a54 100644 > --- a/qerror.c > +++ b/qerror.c > @@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = { > .desc = "The %(device) is encrypted", > }, > { > +.error_fmt = QERR_D

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-05 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 4 Mar 2010 17:50:20 -0300 > Luiz Capitulino wrote: > >> On Thu, 4 Mar 2010 16:56:49 +0100 >> Markus Armbruster wrote: >> >> > While fully converted handlers are not supposed to print anything when >> > running in a QMP monitor, they are free to print in a hum

[Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Luiz Capitulino
On Fri, 5 Mar 2010 17:47:33 +0200 Shahar Havivi wrote: > On Fri, Mar 05, 2010 at 04:22:55PM +0100, Kevin Wolf wrote: > > Date: Fri, 05 Mar 2010 16:22:55 +0100 > > From: Kevin Wolf > > To: Shahar Havivi > > CC: qemu-devel@nongnu.org, Dor Laor , > > Luiz Capitulino > > Subject: Re: [PATCH] W

[Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Shahar Havivi
On Fri, Mar 05, 2010 at 04:22:55PM +0100, Kevin Wolf wrote: > Date: Fri, 05 Mar 2010 16:22:55 +0100 > From: Kevin Wolf > To: Shahar Havivi > CC: qemu-devel@nongnu.org, Dor Laor , > Luiz Capitulino > Subject: Re: [PATCH] Wrong error message in block_passwd command > > Am 05.03.2010 16:12,

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-05 Thread Luiz Capitulino
On Thu, 4 Mar 2010 17:50:20 -0300 Luiz Capitulino wrote: > On Thu, 4 Mar 2010 16:56:49 +0100 > Markus Armbruster wrote: > > > While fully converted handlers are not supposed to print anything when > > running in a QMP monitor, they are free to print in a human monitor. > > I disagree. I've

[Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Kevin Wolf
Am 05.03.2010 16:12, schrieb Shahar Havivi: > Monitor command 'block_passwd' reports a wrong error message when > drive is not encrypted > > Signed-off-by: Shahar Havivi > --- > block.c |9 ++--- > monitor.c |7 ++- > qerror.c |4 > qerror.h |3 +++ > 4 files cha

[Qemu-devel] [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Shahar Havivi
Monitor command 'block_passwd' reports a wrong error message when drive is not encrypted Signed-off-by: Shahar Havivi --- block.c |9 ++--- monitor.c |7 ++- qerror.c |4 qerror.h |3 +++ 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/block.c b/b

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Michael Tokarev
Anthony Liguori wrote: > On 03/05/2010 03:17 AM, Michael Tokarev wrote: >> The thing is that roms/seabios directory is _empty_ in >> qemu-KVM-0.12.3.tar.gz. > > That's a mistake as I don't think that was Avi/Marcelo's intention. It's this way since 0.12.0. When 0.12 come out similar question wer

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Anthony Liguori
On 03/05/2010 03:17 AM, Michael Tokarev wrote: The thing is that roms/seabios directory is _empty_ in qemu-KVM-0.12.3.tar.gz. That's a mistake as I don't think that was Avi/Marcelo's intention. So I can't use the sources you (the qemu-kvm team anyway) ship because there's no shipped source

Re: [Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Anthony Liguori
On 03/05/2010 07:39 AM, Aurelien Jarno wrote: Anthony Liguori a écrit : On 03/04/2010 04:46 PM, Michael Tokarev wrote: Hello. There are a few bugs filed about an.. interesting behavour. For example: http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html https://bugs.l

Re: [Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 03/04/2010 04:46 PM, Michael Tokarev wrote: >> Hello. >> >> There are a few bugs filed about an.. interesting >> behavour. For example: >> >> http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html >> https://bugs.launchpad.net/qemu/+bug/513273 >> >> After

[Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote: > + > +EventNotifier *virtio_queue_guest_notifier(VirtQueue *vq) > +{ > +return &vq->guest_notifier; > +} > +EventNotifier *virtio_queue_host_notifier(VirtQueue *vq) > +{ > +return &vq->host_notifier; > +} Where are these host_noti

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Gerd Hoffmann
Hi, BTW, is there any reason preventing updating vgabios to 0.6c version - the latest released one? Yes. It expects some new bochs vbe interface bits being present. qemu doesn't provide them (yet), thus it simply doesn't work. There's no compelling improvement in 0.6c and updating vgab

[Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote: > vhost needs physical addresses for ring and other queue fields, > so add APIs for these. Already discussed on IRC, but mentioning here so that it doesn't get lost: > +target_phys_addr_t virtio_queue_get_desc(VirtIODevice *vdev, int n) >

[Qemu-devel] Re: [PATCHv4 04/12] virtio: add notifier support

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:04], Michael S. Tsirkin wrote: > Add binding API to set host/guest notifiers. > Will be used by vhost. I've already mentioned this on IRC, but I'll put it here too, for tracking. > > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio.c |5 - > hw/virtio.h |

[Qemu-devel] Re: [PATCHv4 03/12] notifier: event notifier implementation

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:00], Michael S. Tsirkin wrote: > event notifiers are slightly generalized eventfd descriptors. Current > implementation depends on eventfd because vhost is the only user, and > vhost depends on eventfd anyway, but a stub is provided for non-eventfd > case. > > We'll be

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-05 Thread Paul Brook
> TCG internal helpers only access to the values passed in arguments, and > do not modify the CPU internal state. Thus they can be declared as > const and pure. I think this needs an explanatory comment. It's not immediately obvious that tcg_gen_helperN and tcg_gen_helper{32,64} have significantl

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-05 Thread Kevin Wolf
Am 05.03.2010 10:32, schrieb Christoph Hellwig: > On Fri, Mar 05, 2010 at 10:26:21AM +0100, Kevin Wolf wrote: >> Is there a check anywhere that the user didn't give us an odd block >> size? We could get an interesting bit mask otherwise. > > Not yet. I used to have such a check in the first incar

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-05 Thread Christoph Hellwig
On Fri, Mar 05, 2010 at 10:26:21AM +0100, Kevin Wolf wrote: > Is there a check anywhere that the user didn't give us an odd block > size? We could get an interesting bit mask otherwise. Not yet. I used to have such a check in the first incarnation of the block topology patches, but I have no idea

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-05 Thread Kevin Wolf
Am 04.03.2010 14:20, schrieb Christoph Hellwig: > > Add a logical block size attribute as various guest side tools only > increase the filesystem sector size based on it, not the advisory > physical block size. > > For scsi we already have support for a different logical block size > in place for

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Michael Tokarev
Anthony Liguori wrote: > On 03/04/2010 04:46 PM, Michael Tokarev wrote: >> Hello. >> >> There are a few bugs filed about an.. interesting >> behavour. For example: >> >> http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html >> https://bugs.launchpad.net/qemu/+bug/513273 >> [] > pc-bio

[Qemu-devel] [PATCH] use absolute URLs for .gitmodules

2010-03-05 Thread Paolo Bonzini
The relative URLs do not work when cloning a fork of qemu or when cloning from the Savannah URL. Signed-off-by: Paolo Bonzini Signed-off-by: Paolo Bonzini --- .gitmodules |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index dd4745e..5217ce