[Qemu-devel] [PATCH] use absolute URLs for .gitmodules

2010-03-05 Thread Paolo Bonzini
The relative URLs do not work when cloning a fork of qemu or when cloning from the Savannah URL. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- .gitmodules |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Michael Tokarev
Anthony Liguori wrote: On 03/04/2010 04:46 PM, Michael Tokarev wrote: Hello. There are a few bugs filed about an.. interesting behavour. For example: http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html https://bugs.launchpad.net/qemu/+bug/513273 [] pc-bios/bios.bin gets

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-05 Thread Kevin Wolf
Am 04.03.2010 14:20, schrieb Christoph Hellwig: Add a logical block size attribute as various guest side tools only increase the filesystem sector size based on it, not the advisory physical block size. For scsi we already have support for a different logical block size in place for

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-05 Thread Christoph Hellwig
On Fri, Mar 05, 2010 at 10:26:21AM +0100, Kevin Wolf wrote: Is there a check anywhere that the user didn't give us an odd block size? We could get an interesting bit mask otherwise. Not yet. I used to have such a check in the first incarnation of the block topology patches, but I have no idea

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-05 Thread Kevin Wolf
Am 05.03.2010 10:32, schrieb Christoph Hellwig: On Fri, Mar 05, 2010 at 10:26:21AM +0100, Kevin Wolf wrote: Is there a check anywhere that the user didn't give us an odd block size? We could get an interesting bit mask otherwise. Not yet. I used to have such a check in the first incarnation

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-05 Thread Paul Brook
TCG internal helpers only access to the values passed in arguments, and do not modify the CPU internal state. Thus they can be declared as const and pure. I think this needs an explanatory comment. It's not immediately obvious that tcg_gen_helperN and tcg_gen_helper{32,64} have significantly

[Qemu-devel] Re: [PATCHv4 04/12] virtio: add notifier support

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:04], Michael S. Tsirkin wrote: Add binding API to set host/guest notifiers. Will be used by vhost. I've already mentioned this on IRC, but I'll put it here too, for tracking. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c |5 -

[Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote: vhost needs physical addresses for ring and other queue fields, so add APIs for these. Already discussed on IRC, but mentioning here so that it doesn't get lost: +target_phys_addr_t virtio_queue_get_desc(VirtIODevice *vdev, int n) +{

Re: [Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Aurelien Jarno
Anthony Liguori a écrit : On 03/04/2010 04:46 PM, Michael Tokarev wrote: Hello. There are a few bugs filed about an.. interesting behavour. For example: http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html https://bugs.launchpad.net/qemu/+bug/513273 After quite some

Re: [Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Anthony Liguori
On 03/05/2010 07:39 AM, Aurelien Jarno wrote: Anthony Liguori a écrit : On 03/04/2010 04:46 PM, Michael Tokarev wrote: Hello. There are a few bugs filed about an.. interesting behavour. For example: http://www.mail-archive.com/k...@vger.kernel.org/msg29834.html

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Anthony Liguori
On 03/05/2010 03:17 AM, Michael Tokarev wrote: The thing is that roms/seabios directory is _empty_ in qemu-KVM-0.12.3.tar.gz. That's a mistake as I don't think that was Avi/Marcelo's intention. So I can't use the sources you (the qemu-kvm team anyway) ship because there's no shipped

[Qemu-devel] Re: pc-bios/bios.bin - where it comes from?

2010-03-05 Thread Michael Tokarev
Anthony Liguori wrote: On 03/05/2010 03:17 AM, Michael Tokarev wrote: The thing is that roms/seabios directory is _empty_ in qemu-KVM-0.12.3.tar.gz. That's a mistake as I don't think that was Avi/Marcelo's intention. It's this way since 0.12.0. When 0.12 come out similar question were

[Qemu-devel] [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Shahar Havivi
Monitor command 'block_passwd' reports a wrong error message when drive is not encrypted Signed-off-by: Shahar Havivi shah...@redhat.com --- block.c |9 ++--- monitor.c |7 ++- qerror.c |4 qerror.h |3 +++ 4 files changed, 19 insertions(+), 4 deletions(-) diff

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-05 Thread Luiz Capitulino
On Thu, 4 Mar 2010 17:50:20 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster arm...@redhat.com wrote: While fully converted handlers are not supposed to print anything when running in a QMP monitor, they are free to print in a human

[Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Luiz Capitulino
On Fri, 5 Mar 2010 17:47:33 +0200 Shahar Havivi shah...@redhat.com wrote: On Fri, Mar 05, 2010 at 04:22:55PM +0100, Kevin Wolf wrote: Date: Fri, 05 Mar 2010 16:22:55 +0100 From: Kevin Wolf kw...@redhat.com To: Shahar Havivi shah...@redhat.com CC: qemu-devel@nongnu.org, Dor Laor

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-05 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 4 Mar 2010 17:50:20 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster arm...@redhat.com wrote: While fully converted handlers are not supposed to print anything when running in

[Qemu-devel] Re: [PATCHv4 09/12] vhost: vhost net support

2010-03-05 Thread Amit Shah
On (Wed) Mar 03 2010 [19:16:35], Michael S. Tsirkin wrote: +static int vhost_virtqueue_init(struct vhost_dev *dev, +struct VirtIODevice *vdev, +struct vhost_virtqueue *vq, +unsigned idx) +{ +

Re: [Qemu-devel] [PATCH] QMP: Spec: Private Extensions support

2010-03-05 Thread Markus Armbruster
Anthony asked me to take a stab at rewriting his draft to something more along the lines of what I'm thinking. Here goes. I put some remarks [in brackets]. FYI, I'll be out of town until Wednesday. 6. Downstream extension of QMP -- We recommend that downstream

Re: [Qemu-devel] Re: Another VNC crash, qemu-kvm-0.12.3

2010-03-05 Thread Alexander Graf
On 05.03.2010, at 17:52, Chris Webb wrote: Anthony Liguori anth...@codemonkey.ws writes: On 03/01/2010 12:14 PM, Chris Webb wrote: We've just seen another VNC related qemu-kvm crash, this time an arithmetic exception at vnc.c:1424 in the newly release qemu-kvm 0.12.3. [...] 1423

Re: [Qemu-devel] Re: Regression: segfault on ARM host

2010-03-05 Thread Aurelien Jarno
On Tue, Mar 02, 2010 at 01:05:29AM +0100, Aurelien Jarno wrote: On Mon, Mar 01, 2010 at 11:33:23PM +0100, Paolo Bonzini wrote: On 03/01/2010 10:33 PM, Aurelien Jarno wrote: While trying to implement setcond on TCG ARM, I have discovered it does not work anymore. I have bisected this

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-05 Thread Aurelien Jarno
On Fri, Mar 05, 2010 at 11:15:45AM +, Paul Brook wrote: TCG internal helpers only access to the values passed in arguments, and do not modify the CPU internal state. Thus they can be declared as const and pure. I think this needs an explanatory comment. It's not immediately obvious

Re: [Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Luiz Capitulino
On Fri, 05 Mar 2010 17:47:49 +0100 Markus Armbruster arm...@redhat.com wrote: Shahar Havivi shah...@redhat.com writes: diff --git a/qerror.c b/qerror.c index 2f657f4..4e63a54 100644 --- a/qerror.c +++ b/qerror.c @@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH] better describe -net options

2010-03-05 Thread Brian Thomason
The manpage reflects that multiple -net user calls may be made, but if this is done, it can cause the program to hang. Instead, multiple -net calls can be combined into one, and this patch adds that information to qemu-options.hx. Also, -net user may only be used in conjunction with -net nic.

[Qemu-devel] [PATCH] tcg: update README with const and pure helpers

2010-03-05 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/README | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/tcg/README b/tcg/README index f0e21a1..281c114 100644 --- a/tcg/README +++ b/tcg/README @@ -75,10 +75,13 @@ destroyed, but local temporaries and

[Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error

2010-03-05 Thread Shahar Havivi
The next two patches fix the wrong error message in block_passwd monitor command: when trying to decrypt un-encrypted drive, user get error wrong password. 1 add error message to qerror.h and qerror.c 2 patch the monitor command error handling Shahar Havivi (2): QError: New

[Qemu-devel] [PATCH 1/2] QError: New QERR_DEVICE_NOT_ENCRYPTED

2010-03-05 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 2f657f4..4e63a54 100644 --- a/qerror.c +++ b/qerror.c @@ -49,6 +49,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 2/2] Wrong error message in block_passwd command

2010-03-05 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- block.c |7 +-- monitor.c |7 ++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 31d1ba4..e891544 100644 --- a/block.c +++ b/block.c @@ -1134,8 +1134,11 @@ int

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-05 Thread Kevin O'Connor
On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote: On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: The regression seems to be caused by seabios commit d7e998f. Kevin, the failure can be seen on

Re: [Qemu-devel] qemu on Solaris

2010-03-05 Thread Blue Swirl
On 3/4/10, Seth G seth.goldb...@sun.com wrote: Hi, I just sent a fair amount of time trying to figure out problems with the qemu build and resulting binary. The first problem (which is no longer a problem due to the shell OpenSolaris uses) was that `sh' was used in rules.mak to perform

Re: [Qemu-devel] [PATCH] tcg: add div/rem 32-bit helpers

2010-03-05 Thread Blue Swirl
On 3/4/10, Aurelien Jarno aurel...@aurel32.net wrote: Some targets like ARM would benefit to use 32-bit helpers for div/rem/divu/remu. Create a #define for div2 so that targets can select between div, div2 and helper implementation. Use the helper version if none of the #define are