[Qemu-devel] Re: [PATCH] use absolute URLs for .gitmodules

2010-03-07 Thread Paolo Bonzini
On 03/06/2010 11:10 PM, Aurelien Jarno wrote: Is the slash at the end of the URL really wanted? It works either with or without. Paolo

[Qemu-devel] [RESEND][PATCH][STABLE] Don't set default monitor when there is a mux'ed one

2010-03-07 Thread Jan Kiszka
This fixes eg. -nographic -serial mon:stdio [-serial ...]. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- vl.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 10d8e34..bffb796 100644 --- a/vl.c +++ b/vl.c @@ -5369,6 +5369,9 @@ int main(int

[Qemu-devel] [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter

2010-03-07 Thread Jan Kiszka
The missing '@' broke 'udp::port@:port' parsing. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qemu-char.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 86c7c5a..0d8553d 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2333,7

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-07 Thread Jan Kiszka
Gleb Natapov wrote: On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: BTW, do real systems allow to hot plug BSP as well? Or how is the case handled when you unplug the BSP and then reboot the box? Did you mean hot unplug BSP? OS determines what CPU is BSP by checking BSP bit in

[Qemu-devel] [PATCH] Avoid crash on '-usbdevice device' without parameters

2010-03-07 Thread Jan Kiszka
Many usbdevice_init implementors assume params is non-NULL. Signed-off-by: Jan Kiszka jan.kis...@web.de --- hw/usb-bus.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 7c82314..89e2ea6 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@

[Qemu-devel] [PATCH v2] Avoid crash on '-usbdevice device' without parameters

2010-03-07 Thread Jan Kiszka
Many usbdevice_init implementors assume params is non-NULL. Signed-off-by: Jan Kiszka jan.kis...@web.de --- Build fixed - sorry. hw/usb-bus.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 7c82314..3bb8986 100644 --- a/hw/usb-bus.c

Re: [Qemu-devel] [PATCH] EHCI support - device recognized, but no data

2010-03-07 Thread Jan Kiszka
Kevin Wolf wrote: Am Freitag, 5. März 2010 04:17 schrieb David S. Ahern: Jan: I spent some more time on the EHCI support today. With the attached patch (delta to the patch from yesterday) a USB key is recognized within the guest (FC-12): Looks very nice. Actually I could access the file

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-07 Thread Jan Kiszka
Jan Kiszka wrote: Gleb Natapov wrote: On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: BTW, do real systems allow to hot plug BSP as well? Or how is the case handled when you unplug the BSP and then reboot the box? Did you mean hot unplug BSP? OS determines what CPU is BSP by

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-07 Thread Gleb Natapov
On Sun, Mar 07, 2010 at 02:44:50PM +0100, Jan Kiszka wrote: Jan Kiszka wrote: Gleb Natapov wrote: On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: BTW, do real systems allow to hot plug BSP as well? Or how is the case handled when you unplug the BSP and then reboot the box?

Re: [Qemu-devel] QEMU license problem (was [PATCH v3] Drop --whole-archive and static libraries)

2010-03-07 Thread Anthony Liguori
On 03/06/2010 05:33 AM, Stefan Weil wrote: Blue Swirl schrieb: Thanks, applied. On Wed, Jan 6, 2010 at 7:24 PM, Andreas Färber andreas.faer...@web.de wrote: From: Andreas Färberafaer...@opensolaris.org Juan has contributed a cool Makefile infrastructure that enables us to drop

[Qemu-devel] bs-enable_write_cache and the guest ABI

2010-03-07 Thread Avi Kivity
block.c says: /* * Yes, BDRV_O_NOCACHE aka O_DIRECT means we have to present a * write cache to the guest. We do need the fdatasync to flush * out transactions for block allocations, and we maybe have a * volatile write cache in our backing device to deal with. */

Re: [Qemu-devel] QEMU license problem (was [PATCH v3] Drop --whole-archive and static libraries)

2010-03-07 Thread Laurent Desnogues
On Sun, Mar 7, 2010 at 2:53 PM, Anthony Liguori anth...@codemonkey.ws wrote: [...] Removing libqemu.a was technically ok, but throws a license problem: Every file contains a copyright/license.  The statement in the top level is just a statement of intention.  It's to make sure that people do

[Qemu-devel] Re: QEMU license problem (was [PATCH v3] Drop --whole-archive and static libraries)

2010-03-07 Thread Juan Quintela
Stefan Weil w...@mail.berlios.de wrote: Blue Swirl schrieb: Thanks, applied. Removing libqemu.a was technically ok, but throws a license problem: In particular, the QEMU virtual CPU core library (libqemu.a) is released under the GNU Lesser General Public License. Without libqemu.a, this

[Qemu-devel] Re: QEMU license problem (was [PATCH v3] Drop --whole-archive and static libraries)

2010-03-07 Thread Andreas Färber
Am 07.03.2010 um 17:47 schrieb Juan Quintela: Stefan Weil w...@mail.berlios.de wrote: Removing libqemu.a was technically ok, but throws a license problem: In particular, the QEMU virtual CPU core library (libqemu.a) is released under the GNU Lesser General Public License. Without libqemu.a,

Re: [Qemu-devel] [RFC] Documentation: Create qemu-doc.html with makeinfo instead of html2texi

2010-03-07 Thread Andreas Färber
Hello, Am 04.03.2010 um 22:25 schrieb Stefan Weil: Aurelien Jarno schrieb: On Fri, Feb 12, 2010 at 11:43:28AM +0100, Stefan Weil wrote: today, html documentation is created using texi2html. makeinfo can also create html output which looks different. I think it looks better, but try it

[Qemu-devel] [PATCH] Fix compiler warning on parsing the -usbdevice parameter

2010-03-07 Thread Niels de Vos
With the added checks on the parameter for -usbdevice, the following warning got introduced: hw/usb-bus.c: In function ‘usbdevice_create’: hw/usb-bus.c:278: error: assignment discards qualifiers from pointer target type It is okay to drop the qualifier (const) from the empty string here.

[Qemu-devel] Re: [PATCH] Fix compiler warning on parsing the -usbdevice parameter

2010-03-07 Thread Niels de Vos
Ah, just noticed this warning is only in Jans git... For those who were wondering :) Cheers, Niels On 3/7/10, Niels de Vos nixpa...@users.sourceforge.net wrote: With the added checks on the parameter for -usbdevice, the following warning got introduced: hw/usb-bus.c: In function

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-07 Thread Paul Brook
Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository. No. All new devices should be fully qdev

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure

2010-03-07 Thread Paul Brook
On Fri, Mar 05, 2010 at 11:15:45AM +, Paul Brook wrote: TCG internal helpers only access to the values passed in arguments, and do not modify the CPU internal state. Thus they can be declared as const and pure. I think this needs an explanatory comment. It's not immediately

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-07 Thread Jamie Lokier
Paul Brook wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository. No. All new devices

[Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

2010-03-07 Thread Roy Tam
Hi all, I found some regression bugs that seems relate to SeaBIOS and I hope we can add back booting with Bochs BIOS in git so that we can further testing that the bug is in SeaBIOS or in QEMU 0.12. Following list is the regression that I encountered and which works in 0.11.1: - Windows NT

Re: [Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

2010-03-07 Thread Roy Tam
2010/3/8 Roy Tam roy...@gmail.com: 2010/3/8 Keen Shoes keensh...@yahoo.com.cn: Hi all, I found some regression bugs that seems relate to SeaBIOS and I hope we can add back booting with Bochs BIOS in git so that we can further testing that the bug is in SeaBIOS or in QEMU 0.12. == Try

[Qemu-devel] Latest CVS build of qemu-system-ppc not boot debian_lenny_powerpc_small.qcow

2010-03-07 Thread tielian
qemu-system-ppc -hda debian_lenny_powerpc_small.qcow qemu: fatal: Trying to execute code outside RAM or ROM at 0x NIP LR CTR XER MSR HID0 0300 HF idx 0 Segmentation fault uname -a Linux debian 2.6.32-2-amd64 #1 SMP Fri Feb 12

[Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-07 Thread Amit Shah
On (Sat) Mar 06 2010 [21:07:57], Michael S. Tsirkin wrote: On Fri, Mar 05, 2010 at 06:38:35PM +0530, Amit Shah wrote: On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote: + +EventNotifier *virtio_queue_guest_notifier(VirtQueue *vq) +{ +return vq-guest_notifier; +}

[Qemu-devel] Re: [PATCHv4 09/12] vhost: vhost net support

2010-03-07 Thread Amit Shah
On (Sat) Mar 06 2010 [21:06:35], Michael S. Tsirkin wrote: +r = vhost_virtqueue_set_addr(dev, vq, idx, dev-log_enabled); +if (r 0) { +r = -errno; +goto fail_alloc; +} +if (!vdev-binding-guest_notifier || !vdev-binding-host_notifier) { +