[Qemu-devel] Re: [PATCH 0/9] virtio-serial fixes, ABI updates

2010-03-21 Thread Michael S. Tsirkin
On Fri, Mar 19, 2010 at 05:28:37PM +0530, Amit Shah wrote: > Hello, > > This series fixes a few issues pointed out by Avi and Juan. Avi > pointed out we should do full scatter/gather processing of guest data > even if current (well-behaved) guests don't send multiple iovs per > element. > > Juan

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-21 Thread Michael S. Tsirkin
On Fri, Mar 19, 2010 at 01:41:59AM +, Jamie Lokier wrote: > Juan Quintela wrote: > > vstrucut virtio_common *create_virtio_comon(, size we really want); > > Again, this implements superclass/subclass as well as you can implemnt > > it in C. > > It would be more type-safe for create_virtio_

[Qemu-devel] [PATCH] read-only: allow read-only CDROM with any interface

2010-03-21 Thread Naphtali Sprei
Signed-off-by: Naphtali Sprei --- vl.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/vl.c b/vl.c index 2e38b77..d3863d7 100644 --- a/vl.c +++ b/vl.c @@ -1255,19 +1255,16 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque, bdrv_flags &= ~BDRV_O_N

Re: [Qemu-devel] virtio block device and sysfs

2010-03-21 Thread Jamie Lokier
Anthony Liguori wrote: > On 03/06/2010 04:42 PM, Marc Haber wrote: > >Hi, > > > >I am looking to get in touch with somebody who knows more about the > >connection between host configuration, qemu, kvm, and the virtio block > >device driver guest side than I know. > > > >My goal is to have a possibi

Re: [Qemu-devel] [PATCH] read-only: allow read-only CDROM with any interface

2010-03-21 Thread Richard Henderson
On 03/21/2010 08:33 AM, Naphtali Sprei wrote: -if (ro == 1) { +if (media == MEDIA_CDROM) { +ro = 1; +} +if (ro == 1&& +media != MEDIA_CDROM) { /* CDROM is fine for any interface, don't check */ if (type != IF_SCSI&& type != IF_VIRTIO&& type != IF_FLOPP

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-21 Thread Jamie Lokier
Michael S. Tsirkin wrote: > That's version 1 of my patch. Version 2 removed even need for macro > completely by moving allocations to the caller. The downside of moving allocations are: (1) it's one more call in the caller, to allocate the type, (2) it needs a virtual destructor for each type to f

Re: [Qemu-devel] build error in current master

2010-03-21 Thread Anthony Liguori
On 03/20/2010 03:14 AM, Blue Swirl wrote: On 3/20/10, Paul Bolle wrote: 0) Building current master (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, Introduce a default qmp session) fails here: $ make> /dev/null cc1: warnings being treated as errors curses.c: In function ‘curses_display_

Re: [Qemu-devel] build error in current master

2010-03-21 Thread Anthony Liguori
On 03/20/2010 03:14 AM, Blue Swirl wrote: On 3/20/10, Paul Bolle wrote: 0) Building current master (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, Introduce a default qmp session) fails here: $ make> /dev/null cc1: warnings being treated as errors curses.c: In function ‘curses_display_

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-21 Thread Michael S. Tsirkin
On Sun, Mar 21, 2010 at 06:11:43PM +, Jamie Lokier wrote: > Michael S. Tsirkin wrote: > > That's version 1 of my patch. Version 2 removed even need for macro > > completely by moving allocations to the caller. > > The downside of moving allocations are: (1) it's one more call in the > caller,

Re: [Qemu-devel] build error in current master

2010-03-21 Thread Blue Swirl
On 3/21/10, Anthony Liguori wrote: > On 03/20/2010 03:14 AM, Blue Swirl wrote: > > > On 3/20/10, Paul Bolle wrote: > > > > > > > 0) Building current master > (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, > > > Introduce a default qmp session) fails here: > > > > > > $ make> /dev/null > > > cc1:

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-21 Thread Michael S. Tsirkin
On Sun, Mar 21, 2010 at 06:11:43PM +, Jamie Lokier wrote: > Michael S. Tsirkin wrote: > > That's version 1 of my patch. Version 2 removed even need for macro > > completely by moving allocations to the caller. > > The downside of moving allocations are: (1) it's one more call in the > caller,

Re: [Qemu-devel] build error in current master

2010-03-21 Thread Anthony Liguori
On 03/21/2010 02:37 PM, Blue Swirl wrote: On 3/21/10, Anthony Liguori wrote: On 03/20/2010 03:14 AM, Blue Swirl wrote: On 3/20/10, Paul Bolle wrote: 0) Building current master (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, Introduce a default qmp session

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-21 Thread Luiz Capitulino
On Sat, 20 Mar 2010 00:29:25 +0200 Shahar Havivi wrote: > Fix to Luiz comments. Better to resend the whole series with a 'v2' in it, also I think you'll have to rebase against master because this series conflicts with latest Anthony's series. I have some QError comments below. > > Signed-of

[Qemu-devel] Re: [PATCH 04/11] error: New QERR_INVALID_PARAMETER_VALUE

2010-03-21 Thread Luiz Capitulino
On Fri, 19 Mar 2010 22:05:53 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 18 Mar 2010 17:33:11 +0100 > > Markus Armbruster wrote: > > > >> > >> Signed-off-by: Markus Armbruster > >> --- > >> qerror.c |4 > >> qerror.h |3 +++ > >> 2 files changed, 7 in

[Qemu-devel] Re: [PATCH 2/6] error: Trim includes in qerror.c

2010-03-21 Thread Luiz Capitulino
On Fri, 19 Mar 2010 22:33:29 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 17 Mar 2010 18:56:50 +0100 > > Markus Armbruster wrote: > > > >> > >> Signed-off-by: Markus Armbruster > >> --- > >> qerror.c |2 -- > >> 1 files changed, 0 insertions(+), 2 deletions(-)

[Qemu-devel] Re: [PATCH 1/6] error: Trim includes after "Move qemu_error & friends..."

2010-03-21 Thread Luiz Capitulino
On Fri, 19 Mar 2010 22:31:05 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 17 Mar 2010 18:56:49 +0100 > > Markus Armbruster wrote: > > > >> Missed in commit 2f792016. > >> > >> Signed-off-by: Markus Armbruster > >> --- > >> hw/qdev-properties.c |1 + > >> monito

[Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-21 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Sun, Mar 21, 2010 at 06:11:43PM +, Jamie Lokier wrote: >> Michael S. Tsirkin wrote: >> > That's version 1 of my patch. Version 2 removed even need for macro >> > completely by moving allocations to the caller. >> >> The downside of moving allocations are: (1)

[Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-21 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Sun, Mar 21, 2010 at 06:11:43PM +, Jamie Lokier wrote: >> Michael S. Tsirkin wrote: >> > That's version 1 of my patch. Version 2 removed even need for macro >> > completely by moving allocations to the caller. >> >> The downside of moving allocations are: (1)

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-21 Thread Anthony Liguori
On 03/21/2010 08:06 PM, Juan Quintela wrote: "Michael S. Tsirkin" wrote: On Sun, Mar 21, 2010 at 06:11:43PM +, Jamie Lokier wrote: Michael S. Tsirkin wrote: That's version 1 of my patch. Version 2 removed even need for macro completely by moving allocations to the caller

[Qemu-devel] Re: [PATCH 0/9] virtio-serial fixes, ABI updates

2010-03-21 Thread Amit Shah
On (Sun) Mar 21 2010 [15:47:53], Michael S. Tsirkin wrote: > On Fri, Mar 19, 2010 at 05:28:37PM +0530, Amit Shah wrote: > > Hello, > > > > This series fixes a few issues pointed out by Avi and Juan. Avi > > pointed out we should do full scatter/gather processing of guest data > > even if current (

Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages

2010-03-21 Thread Amit Shah
On (Sat) Mar 20 2010 [09:40:50], Avi Kivity wrote: > On 03/19/2010 01:58 PM, Amit Shah wrote: >> + >> +offset = 0; >> +for (i = 0; i< elem.out_num; i++) { >> +memcpy(buf + offset, elem.out_sg[i].iov_base, >> + elem.out_sg[i].iov_len); >> +o

[Qemu-devel] Re: [PATCH 0/2] qemu-kvm: Introduce wrapper functions to access phys_ram_dirty, and replace existing direct accesses to it.

2010-03-21 Thread Yoshiaki Tamura
Marcelo Tosatti wrote: On Wed, Mar 17, 2010 at 02:51:46PM +0900, Yoshiaki Tamura wrote: Before replacing byte-based dirty bitmap with bit-based dirty bitmap, clearing direct accesses to the bitmap first seems to be good point to start with. This patch set is based on the following discussion.

[Qemu-devel] Build always fail on x86_32 host for i386_softmmu target

2010-03-21 Thread Bruce Majia
Hi, When I built qemu on my x86_32 host with following configure line: $ ./configure --prefix=/usr/local/qemus/master \ --target-list=i386-softmmu $ make The build will always fail with message: ... CCi386-softmmu/fpu/softfloat-native.o /m