On Thu, May 6, 2010 at 10:51 PM, Blue Swirl wrote:
> On 5/5/10, Igor Kovalenko wrote:
>> On Wed, May 5, 2010 at 12:21 AM, Blue Swirl wrote:
>> > On 5/3/10, Igor Kovalenko wrote:
>> >> On Mon, May 3, 2010 at 11:54 PM, Blue Swirl wrote:
>> >> > On 5/3/10, Igor Kovalenko wrote:
>> >> >> On
On Thu, 6 May 2010 10:42:10 -0300
Miguel Di Ciurcio Filho wrote:
> Hi there,
>
> I'm working on the conversion of the 'info network' command do QMP,
> and I think I've found some problems.
>
> Running qemu like this: qemu -net socket,listen=:
>
> In net/socket.c, the function net_socket_li
On 05/07/2010 02:39 PM, Jan Kiszka wrote:
Hi guys,
/*
* QFloat Module
*
* Copyright (C) 2009 Red Hat Inc.
*
* Authors:
* Luiz Capitulino
*
* This work is licensed under the terms of the GNU GPL, version 2. See
* the COPYING file in the top-level directory.
*
* Copyright I
Jan Kiszka wrote:
> Moreover, some of the QObject files are LGPL, some GPL. I bet this was
> also not intended. But what was the idea behind the LGPL? Some libqmp which
> can be used by closed source apps?
I believe LGPL is needed for source apps that have GPLv2-incompatible
licensing. E.g. GPLv3
Hi all,
I wondered why we have the post_save callback in vmstate. Conceptually,
it made no sense to me. So I grep'ed for its users - and found exactly
one: tmp105. As suspected, only "strange" code was found:
static void tmp105_post_save(void *opaque)
{
TMP105State *s = opaque;
s->faults
Luiz,
I missed this when the API was first proposed:
cur_mon is scheduled for removal (one day...). It's just an intermediate
step to convert all users to explicit 'mon' passing. Thus, new APIs
should not rely it.
I just realized that monitor_cur_is_qmp() does so. It should be
refactored to moni
mips_abi_choices and mips_arch_choices are only used locally.
Signed-off-by: Stefan Weil
---
mips-dis.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mips-dis.c b/mips-dis.c
index 169169c..ae64543 100644
--- a/mips-dis.c
+++ b/mips-dis.c
@@ -3035,7 +3035,7 @@ struct
On Fri, 07 May 2010 21:39:54 +0200
Jan Kiszka wrote:
> Hi guys,
>
> /*
> * QFloat Module
> *
> * Copyright (C) 2009 Red Hat Inc.
> *
> * Authors:
> * Luiz Capitulino
> *
> * This work is licensed under the terms of the GNU GPL, version 2. See
> * the COPYING file in the top-level dir
On Tue, 4 May 2010 13:20:29 +0200
Markus Armbruster wrote:
> Markus Armbruster (4):
> doc: Fix host forwarding monitor command documentation
> doc: Fix acl monitor command documentation
> doc: Heading for monitor command cpu got lost, restore it
> doc: Clean up monitor command function i
Hi guys,
/*
* QFloat Module
*
* Copyright (C) 2009 Red Hat Inc.
*
* Authors:
* Luiz Capitulino
*
* This work is licensed under the terms of the GNU GPL, version 2. See
* the COPYING file in the top-level directory.
*
* Copyright IBM, Corp. 2009
*
* Authors:
* Anthony Liguori
Avoid counting the io hole as part of ram, a vm started with 4G
should report 4G in smbios, not 4.5G.
Signed-off-by: Alex Williamson
---
src/smbios.c | 68 +-
1 files changed, 43 insertions(+), 25 deletions(-)
diff --git a/src/smbios.c
Thanks, applied.
On 5/7/10, Stefan Weil wrote:
> tcg_out_reloc is only used locally (in */target.c which is
> included in tcg.c).
>
> Signed-off-by: Stefan Weil
> ---
> tcg/tcg.c |4 ++--
> tcg/tcg.h |3 ---
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tcg/
[sorry didn't see the CC to the mailinglist]
Am Friday 23 April 2010 09:23:49 schrieb Jan Kiszka:
> Michael Walle wrote:
> > Hi Jan,
> >
> > your commit "Optimize consecutive CFI02 writes by remapping memory
> > lazily" breaks the code execution from flash.
> >
> > If you write to the flash, the
On Fri, 07 May 2010 16:21:13 +0200
Jan Kiszka wrote:
> Luiz Capitulino wrote:
> > On Fri, 07 May 2010 13:45:03 +0200
> > Jan Kiszka wrote:
> >
> >> Hi Luiz,
> >>
> >> what is the recommended way of pushing larger buffers (up to 64K so far)
> >> into a qdict? QLIST of QINT (one per byte) looks a
Thanks, applied.
On 5/6/10, Stefan Weil wrote:
> Function usage() is only used locally.
>
> Signed-off-by: Stefan Weil
> ---
> tests/qruncom.c |2 +-
> tests/runcom.c |2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qruncom.c b/tests/qruncom.c
> i
On 5/7/10, Kevin Wolf wrote:
> A recent build fix for OpenBSD moved the BlockDriver definition of qcow2 to
> somewhere in the middle of the source file. This series tries to solve the
> problem in a different way that allows the definition to stay where everyone
> looks for it.
>
> Blue Swirl,
On Fri, May 07, 2010 at 09:37:22AM +0200, Kevin Wolf wrote:
> Am 07.05.2010 03:19, schrieb Marcelo Tosatti:
> > On Thu, Nov 19, 2009 at 01:19:55PM +0100, Jan Kiszka wrote:
> >> Hi,
> >>
> >> I just managed to push a qemu-kvm process (git rev. b496fe3431) into an
> >> endless loop in qcow2_alloc_clu
Use bdrv_pwrite to access the backing device instead of pread, and
convert the driver to implementing the bdrv_open method which gives
it an already opened BlockDriverState for the underlying device.
Signed-off-by: Christoph Hellwig
Index: qemu/block/cow.c
===
We don't have an equivalent to mmap in the qemu block API, so read and
write the bitmap directly. At least in the dumb implementation added
in this patch this is a lot less efficient, but it means cow can also
work on windows, and over nbd or curl. And it fixes qemu-iotests testcase
012 which did
Use container_of for one direction and &acb->common for the other one.
Signed-off-by: Kevin Wolf
---
block.c |3 ++-
block/blkdebug.c |4 ++--
block/qcow.c |2 +-
block/qcow2.c|2 +-
block/vdi.c |2 +-
5 files changed, 7 insertions(+), 6 deletions(-)
di
From: Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block.h b/block.h
index f87d24e..278259c 100644
--- a/block.h
+++ b/block.h
@@ -38,7 +38,7 @@ typedef struct QEMUSnapshotInfo {
On Fri, 07 May 2010 11:49:42 +0200
Markus Armbruster wrote:
> +Any new names downstream wishes to add must begin with '__'. To ensure
> +compatibility with other downstreams, it is strongly recommended that
> +you prefix the commands with '__RFQDN_' where RFQDN is a valid, reverse
> +fully quali
El 07/05/2010, a las 14:54, Anthony Liguori escribió:
> The QEMU team is pleased to announce the availability of the 0.12.4
> release. This is a stable release of the 0.12 series and only contains bug
> fixes since 0.12.3.
>
> It can be downloaded from Savannah at:
>
> http://download.savanna
Use bdrv_pwrite to access the backing device instead of pread, and
convert the driver to implementing the bdrv_open method which gives
it an already opened BlockDriverState for the underlying device.
Dmg actually does an lseek to a negative offset in the open routine,
which we replace with offset
Signed-off-by: Gerd Hoffmann
---
vnc.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vnc.c b/vnc.c
index e497c70..69f3816 100644
--- a/vnc.c
+++ b/vnc.c
@@ -2238,6 +2238,7 @@ static void vnc_connect(VncDisplay *vd, int csock)
if (vs->vd->lock_key_sync) {
Kevin Wolf a écrit :
> Am 08.04.2010 20:37, schrieb Aurelien Jarno:
>> Hi all,
>>
>> A number of fixes have been accumulated in the stable-0.12 branch, and
>> I think it's time to release a new stable version. I would like to see
>> that happening for the end of next week (around the 18th of April)
On Tue, Mar 30, 2010 at 01:58:53PM -0300, Thadeu Lima de Souza Cascardo wrote:
> The registers SIMR and CIMR allow interrupts to be masked/unsmasked
> without a read-modify-write. Linux m68knommu port uses this for some
> platforms. Without this patch, a m5208evb_defconfig won't boot. With
> this p
tcg_out_reloc is only used locally (in */target.c which is
included in tcg.c).
Signed-off-by: Stefan Weil
---
tcg/tcg.c |4 ++--
tcg/tcg.h |3 ---
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index beceff0..f3c7909 100644
--- a/tcg/tcg.c
+++ b/tcg/
On 5/7/10, Kevin Wolf wrote:
> Am 07.05.2010 17:45, schrieb Blue Swirl:
>
> > On 5/7/10, Kevin Wolf wrote:
> >> A recent build fix for OpenBSD moved the BlockDriver definition of qcow2
> to
> >> somewhere in the middle of the source file. This series tries to solve
> the
> >> problem in a
Thanks, applied.
On 5/7/10, Richard Henderson wrote:
> Implement the "functions may be omitted with NULL pointer"
> interface mentioned in the function block comment by transforming
> NULL entries in the read/write arrays into calls to the
> unassigned_mem family of functions.
>
> Signed-off-
Implement the "functions may be omitted with NULL pointer"
interface mentioned in the function block comment by transforming
NULL entries in the read/write arrays into calls to the
unassigned_mem family of functions.
Signed-off-by: Richard Henderson
---
exec.c | 12 ++--
1 files change
Am 07.05.2010 17:45, schrieb Blue Swirl:
> On 5/7/10, Kevin Wolf wrote:
>> A recent build fix for OpenBSD moved the BlockDriver definition of qcow2 to
>> somewhere in the middle of the source file. This series tries to solve the
>> problem in a different way that allows the definition to stay wh
Thanks, applied.
On 5/6/10, Stefan Weil wrote:
> Function usage is only used locally, so add "static".
>
> Signed-off-by: Stefan Weil
> ---
> darwin-user/main.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/darwin-user/main.c b/darwin-user/main.c
> index a
On 5/6/10, Stefan Weil wrote:
> mips_abi_choices and mips_arch_choices are only used locally.
>
> Signed-off-by: Stefan Weil
> ---
> mips-dis.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mips-dis.c b/mips-dis.c
> index 56bffe5..4623a1c 100644
> --- a/
phys_page_find (exec.c) returns sometimes a page for addresses where
nothing is connected.
One example, done with qemu-system-sparc -M SS-20
ok f130 2f spacec@ .
// The address translates correctly, in cpu_physical_memory_rw
// addr== 0xff130 (where nothing is connected)
// but then phys
On 5/7/10, Gerd Hoffmann wrote:
> This patch allows to set PCI vendor and device IDs using defines
> (PCI_VID and PCI_DID). Use it for vgabios.bin.
>
> Signed-off-by: Gerd Hoffmann
> ---
> Makefile |4 ++--
> vbe.c |6 +-
> vgabios.c |5 +
> 3 files changed, 12 i
On 5/6/10, Artyom Tarasenko wrote:
> 2010/4/28 Artyom Tarasenko :
>
> > 2010/4/27 Richard Henderson :
> >> On 04/26/2010 02:54 PM, Artyom Tarasenko wrote:
> >>> This patch introduces a regression. qemu crashes on lance test:
> >>
> >> I'm not sure how to get to this, since the sparc-test image
On 5/7/10, Paolo Bonzini wrote:
> On 05/06/2010 08:12 PM, Blue Swirl wrote:
>
> > On 5/5/10, Gerd Hoffmann wrote:
> >
> > > Add a new cursor type to console.h and a bunch of functions to
> > > deal with cursors the (new) cursor.c file.
> > >
> > > Signed-off-by: Gerd Hoffmann
> > > ---
> > >
Use pread/pwrite instead of lseek + read/write in preparation of using the
qemu block API.
Signed-off-by: Christoph Hellwig
Index: qemu/block/cow.c
===
--- qemu.orig/block/cow.c 2010-05-04 19:11:24.897004616 +0200
+++ qemu/blo
From: Stefan Weil
Even it is not very useful, users may create images of size 0.
Without the special option CONFIG_ZERO_MALLOC, qemu_mallocz
aborts execution when it is told to allocate 0 bytes,
so avoid this kind of call.
Cc: Kevin Wolf
Signed-off-by: Stefan Weil
Signed-off-by: Kevin Wolf
-
This series converts the cow image driver to the block API. This fixes
a failure in qemu-iotests 012, and allows compiling it on window by
removing the dependency on mmap. The downside is that it's possible
a lot slower for bitmap accesses, at least with the current naive
implementation. Anyone
From: Christoph Hellwig
Use bdrv_pwrite to access the backing device instead of pread, and
convert the driver to implementing the bdrv_open method which gives
it an already opened BlockDriverState for the underlying device.
Signed-off-by: Christoph Hellwig
Signed-off-by: Kevin Wolf
---
block/
We can't assume the file protocol for Windows devices, they need the same
detection as other files for which an explicit protocol is not specified.
Signed-off-by: Kevin Wolf
---
block.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 6345
When reopening the image, don't guess the driver, but use the same driver as
was used before. This is important if the format=... option was used for that
image.
Signed-off-by: Kevin Wolf
---
block.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
When cancelling a request, bdrv_aio_cancel may decide that it waits for
completion of a request rather than for cancellation. IDE therefore can't
abandon its DMA status before calling bdrv_aio_cancel; otherwise the callback
of a completed request would use invalid data.
Signed-off-by: Kevin Wolf
From: Christoph Hellwig
Use pread instead of lseek + read in preparation of using the qemu
block API.
Signed-off-by: Christoph Hellwig
Signed-off-by: Kevin Wolf
---
block/bochs.c | 63 ++--
1 files changed, 20 insertions(+), 43 deletions(-
From: Christoph Hellwig
Use pread instead of lseek + read in preparation of using the qemu
block API.
Signed-off-by: Christoph Hellwig
Signed-off-by: Kevin Wolf
---
block/cloop.c | 32 +---
1 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/block/cl
From: Christoph Hellwig
Use bdrv_pwrite to access the backing device instead of pread, and
convert the driver to implementing the bdrv_open method which gives
it an already opened BlockDriverState for the underlying device.
Signed-off-by: Christoph Hellwig
Signed-off-by: Kevin Wolf
---
block/
From: Ryota Ozaki
- use err(3) instead of errx(3) if errno is available
to report why failed
- let fail prior to daemon(3) if opening a nbd file
is likely to fail after daemonizing to avoid silent
failure exit
- add missing 'ret = 1' when unix_socket_outgoing failed
Signed-off-by: Ryota Oz
The following changes since commit 2065061ede22d401aae2ce995c3af54db9d28639:
Igor V. Kovalenko (1):
sparc64: handle asi referencing nucleus and secondary MMU contexts
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Christoph Hellwig (4):
cloo
Use pread instead of lseek + read in preparation of using the qemu
block API. Note that dmg actually uses the implicit file offset
a lot in dmg_open, and we had to replace it with an offset variable.
Signed-off-by: Christoph Hellwig
Index: qemu-kevin/block/dmg.c
When dmg_read_chunk encounters an uncompressed chunk it currently
calls read without any previous adjustment of the file postion.
This seems very wrong, and the "reference" implementation in
dmg2img does a search to the same offset as done in the various
compression cases, so do the same here.
Si
This patchset fixes a bug found through code inspection in dmg,
and converts it to the qemu block driver API. Note that I have no
way to actually generate dmg images, so it's entirely tested.
And compared to the dmg2img tool it seems we're missing support for
a lot of features in the dmg format,
Hi. If gmake extension is allowed, nasty rm in the rule can be removed
by using intermediate file which is removed after build.
We can combine your cleanup with mine.
[PATCH] vgabios: Makefile: clean up using gmake extension.
clean up nasty rule by using gmake extension
Signed-off-by: Isaku Yama
Luiz Capitulino wrote:
> On Fri, 07 May 2010 13:45:03 +0200
> Jan Kiszka wrote:
>
>> Hi Luiz,
>>
>> what is the recommended way of pushing larger buffers (up to 64K so far)
>> into a qdict? QLIST of QINT (one per byte) looks a bit heavy. I thought
>> about hex-encoding the content first (series o
The QEMU team is pleased to announce the availability of the 0.12.4
release. This is a stable release of the 0.12 series and only contains
bug fixes since 0.12.3.
It can be downloaded from Savannah at:
http://download.savannah.gnu.org/releases/qemu/qemu-0.12.4.tar.gz
On behalf of the QEMU te
On 05/07/2010 04:40 AM, Aurelien Jarno wrote:
Anthony Liguori a écrit :
On 05/06/2010 08:09 AM, Kevin Wolf wrote:
Am 08.04.2010 20:37, schrieb Aurelien Jarno:
Hi all,
A number of fixes have been accumulated in the stable-0.12 branch, and
I think it's time to release a new s
Rules for how to extend QMP downstream (if you really have to) without
creating interoparability hassles.
Signed-off-by: Markus Armbruster
---
Aside:
* Advice on downstream modifications, items 1. and 2. could use a
rationale.
* Section '5 Compatibility Considerations' could use some love.
Add PCI vgabios for the qemu vmeare vga (15ad:0405).
Name it vgabios-vmware.bin.
Signed-off-by: Gerd Hoffmann
---
Makefile | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 58f064e..2a093e8 100644
--- a/Makefile
+++ b/Makefile
@@ -14,7 +1
Add PCI vgabios for the qemu standard vga (1234:).
Name it vgabios-stdvga.bin.
Signed-off-by: Gerd Hoffmann
---
Makefile | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index d440b93..58f064e 100644
--- a/Makefile
+++ b/Makefile
@@ -14,12
Anthony Liguori a écrit :
> On 05/06/2010 08:09 AM, Kevin Wolf wrote:
>> Am 08.04.2010 20:37, schrieb Aurelien Jarno:
>>
>>> Hi all,
>>>
>>> A number of fixes have been accumulated in the stable-0.12 branch, and
>>> I think it's time to release a new stable version. I would like to see
>>> that
Signed-off-by: Gerd Hoffmann
---
console.h | 11 +++
input.c | 37 -
vnc.c | 13 -
vnc.h |2 +-
4 files changed, 28 insertions(+), 35 deletions(-)
diff --git a/console.h b/console.h
index 6def115..431410a 100644
--- a/c
This reverts commit 20d97356c9df6d68fbd37d6334fdb7063f24eab6.
The BlockDriver definition should stay at the end of source files.
Conflicts:
block/qcow2.c
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 490
1 files changed, 245 in
vmware vga has the framebuffer at pci region 1 not 0. This patch makes
pci_get_lfb_addr check region 1 too. It also gives names to the
numbered labels to make the code more readable.
Signed-off-by: Gerd Hoffmann
---
vgabios.c | 23 ++-
1 files changed, 14 insertions(+), 9
OpenBSDs gcc is said to generate warnings for this declaration, so don't
reference bdrv_qcow2 directly, but look it up using bdrv_find_format.
Signed-off-by: Kevin Wolf
---
block/qcow2.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
in
On 05/06/2010 08:12 PM, Blue Swirl wrote:
On 5/5/10, Gerd Hoffmann wrote:
Add a new cursor type to console.h and a bunch of functions to
deal with cursors the (new) cursor.c file.
Signed-off-by: Gerd Hoffmann
---
Makefile.objs |3 +-
console.h | 24 ++-
cursor.c
Am 06.05.2010 22:04, schrieb Christoph Hellwig:
>
> Use pread instead of lseek + read in preparation of using the qemu
> block API.
>
> Signed-off-by: Christoph Hellwig
Thanks, applied both patches to the block branch.
We'll probably have to live with the fact that we can't test changes to
the
Use a single rule for building bios binaries.
Use target specific variables to set compile flags.
This makes it more obvious what the differences between the versions
are. It also makes it easier to add new bios binaries with slightly
different settings.
Signed-off-by: Gerd Hoffmann
---
Makefi
A recent build fix for OpenBSD moved the BlockDriver definition of qcow2 to
somewhere in the middle of the source file. This series tries to solve the
problem in a different way that allows the definition to stay where everyone
looks for it.
Blue Swirl, as I don't have an OpenBSD installation hand
Hi folks,
Here is a short status update about what is happening in spice land.
For those which don't know yet what spice is: Spice is a remote desktop
protocol. It uses a paravirtual graphics card (qxl) for good
performance. The (slightly outdated) project website with background
informa
Le Fri, 07 May 2010 09:55:23 +0200, Kevin Wolf a écrit :
> Am 06.05.2010 20:29, schrieb Stefan Weil:
> > This patch fixes a regression introduced by commit
> > 95a2f9bc588c3f83375d87b0a9394f89a1bcfada.
> >
> > The fix is based on a patch from Kevin Wolf. Here his comment:
> >
> > "The number of blo
This patch allows to set PCI vendor and device IDs using defines
(PCI_VID and PCI_DID). Use it for vgabios.bin.
Signed-off-by: Gerd Hoffmann
---
Makefile |4 ++--
vbe.c |6 +-
vgabios.c |5 +
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Mak
Hi Luiz,
what is the recommended way of pushing larger buffers (up to 64K so far)
into a qdict? QLIST of QINT (one per byte) looks a bit heavy. I thought
about hex-encoding the content first (series of "%02X"), then
registering it as QSTRING. Or should we introduce a new type, QBUFFER?
Jan
--
S
On Fri, 07 May 2010 13:45:03 +0200
Jan Kiszka wrote:
> Hi Luiz,
>
> what is the recommended way of pushing larger buffers (up to 64K so far)
> into a qdict? QLIST of QINT (one per byte) looks a bit heavy. I thought
> about hex-encoding the content first (series of "%02X"), then
> registering it
Am 06.05.2010 20:53, schrieb Stefan Weil:
> Even it is not very useful, users may create images of size 0.
>
> Without the special option CONFIG_ZERO_MALLOC, qemu_mallocz
> aborts execution when it is told to allocate 0 bytes,
> so avoid this kind of call.
>
> Cc: Kevin Wolf
> Signed-off-by: Ste
Am 06.05.2010 20:29, schrieb Stefan Weil:
> This patch fixes a regression introduced by commit
> 95a2f9bc588c3f83375d87b0a9394f89a1bcfada.
>
> The fix is based on a patch from Kevin Wolf. Here his comment:
>
> "The number of blocks needs to be rounded up to cover all of the virtual hard
> disk. W
Am 07.05.2010 03:19, schrieb Marcelo Tosatti:
> On Thu, Nov 19, 2009 at 01:19:55PM +0100, Jan Kiszka wrote:
>> Hi,
>>
>> I just managed to push a qemu-kvm process (git rev. b496fe3431) into an
>> endless loop in qcow2_alloc_cluster_offset, namely over
>> QLIST_FOREACH(old_alloc, &s->cluster_allocs,
77 matches
Mail list logo
