Re: [Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Jan Kiszka
Avi Kivity wrote: > On 05/10/2010 01:59 PM, Jan Kiszka wrote: >> From a quick glance at the JSON spec, there is no room for a new type. I >> think we have to overload an existing one and convert that into a >> QBuffer (typically, we know the actual semantic). Hex string encoding is >> most compact

Re: [Qemu-devel] Re: ehci fixes

2010-05-10 Thread Vincent Palatin
On Sun, 09 May 2010 20:36:03 -0600 "David S. Ahern" wrote: > > While using the EHCI patchset, I have found 2 minor issues. > > So, I send in this email thread 2 fix proposals. > > Changes look good to me. > > Are you looking at any particular device or EHCI in general? I'm just using it to exe

Re: [Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Avi Kivity
On 05/10/2010 01:59 PM, Jan Kiszka wrote: From a quick glance at the JSON spec, there is no room for a new type. I think we have to overload an existing one and convert that into a QBuffer (typically, we know the actual semantic). Hex string encoding is most compact, so I went this road. Base

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Jan Kiszka
Markus Armbruster wrote: > Jan Kiszka writes: > >> Markus Armbruster wrote: >>> Jan Kiszka writes: >>> Markus Armbruster wrote: > Jan Kiszka writes: > >> Luiz, >> >> I missed this when the API was first proposed: >> >> cur_mon is scheduled for removal (one day..

[Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Luiz Capitulino
On Mon, 10 May 2010 12:59:47 +0200 Jan Kiszka wrote: > Luiz Capitulino wrote: > > On Fri, 07 May 2010 16:21:13 +0200 > > Jan Kiszka wrote: > > > >> Luiz Capitulino wrote: > >>> On Fri, 07 May 2010 13:45:03 +0200 > >>> Jan Kiszka wrote: > >>> > Hi Luiz, > > what is the recommende

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Markus Armbruster
Jan Kiszka writes: > Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> Markus Armbruster wrote: Jan Kiszka writes: > Luiz, > > I missed this when the API was first proposed: > > cur_mon is scheduled for removal (one day...). It's just an intermediate > ste

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Luiz Capitulino
On Mon, 10 May 2010 14:23:05 +0200 Jan Kiszka wrote: > Markus Armbruster wrote: > > Jan Kiszka writes: > > > >> Markus Armbruster wrote: > >>> Jan Kiszka writes: > >>> > Luiz, > > I missed this when the API was first proposed: > > cur_mon is scheduled for removal (one

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Jan Kiszka
Markus Armbruster wrote: > Jan Kiszka writes: > >> Markus Armbruster wrote: >>> Jan Kiszka writes: >>> Luiz, I missed this when the API was first proposed: cur_mon is scheduled for removal (one day...). It's just an intermediate step to convert all users to explicit

[Qemu-devel] [PATCH 1/1] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
ahci disk look up from IF_SCSI now. test a sata disk: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,file=/tmp/disk test a sata cd: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,media=cdrom,file=KNOPPIX_V6.0.1CD-2009-02-08-EN.iso Signe

[Qemu-devel] [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
When ahci init ,driver will send ATA_SRST command,ahci device report device type through port's sig register. Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not support cdrom media. I just copy ide_atapi_cmd from hw/ide/core.c into hw/ahci.c,change a little,then the cdrom c

[Qemu-devel] [PATCH 0/1] [RFC][ahci] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
When ahci init ,driver will send ATA_SRST command,ahci device report device type through port's sig register. Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not support cdrom media. I just copy ide_atapi_cmd from hw/ide/core.c into hw/ahci.c,change a little,then the cdrom c

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 04/21/2010 08:53 PM, Cam Macdonell wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository.

[Qemu-devel] [PATCH 1/1] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
ahci disk look up from IF_SCSI now. test a sata disk: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,file=/tmp/disk test a sata cd: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,media=cdrom,file=KNOPPIX_V6.0.1CD-2009-02-08-EN.iso Signe

Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-10 Thread 乔崇
Alexander Graf 写道: Hi Chong, 乔崇 wrote: Alexander Graf 写道: Hi Chong (or Qiao? Which one is your first name?), Thanks your advice,My first name is Chong. Upfront - please don't top post. Top posting is when you write your reply at

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-10 Thread chen huacai
>> --- a/hw/mips.h >> +++ b/hw/mips.h >> @@ -5,6 +5,9 @@ >>  /* gt64xxx.c */ >>  PCIBus *pci_gt64120_init(qemu_irq *pic); >> >> +/* bonito.c */ >> +PCIBus *bonito_init_2e(qemu_irq pic); >> + >>  /* ds1225y.c */ >>  void *ds1225y_init(target_phys_addr_t mem_base, const char *filename); >>  void ds12

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Markus Armbruster
Jan Kiszka writes: > Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> Luiz, >>> >>> I missed this when the API was first proposed: >>> >>> cur_mon is scheduled for removal (one day...). It's just an intermediate >>> step to convert all users to explicit 'mon' passing. Thus, new APIs >>> sh

[Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Jan Kiszka
Luiz Capitulino wrote: > On Fri, 07 May 2010 16:21:13 +0200 > Jan Kiszka wrote: > >> Luiz Capitulino wrote: >>> On Fri, 07 May 2010 13:45:03 +0200 >>> Jan Kiszka wrote: >>> Hi Luiz, what is the recommended way of pushing larger buffers (up to 64K so far) into a qdict? QLIST o

[Qemu-devel] Re: [PATCH v5 3/5] Add functions for assigning ioeventfd and irqfds.

2010-05-10 Thread Avi Kivity
On 04/21/2010 08:53 PM, Cam Macdonell wrote: Generic functions to assign irqfds and ioeventfds. Signoff. } #ifdef KVM_IOEVENTFD +int kvm_set_irqfd(int fd, uint16_t vector, uint32_t gsi) +{ +struct kvm_irqfd call = { }; +int r; + +call.fd = fd; +call.gsi = gsi;

[Qemu-devel] Re: [PATCH v5 2/5] Support adding a file to qemu's ram allocation

2010-05-10 Thread Avi Kivity
On 04/21/2010 08:53 PM, Cam Macdonell wrote: This avoids the need of using qemu_ram_alloc and mmap with MAP_FIXED to map a host file into guest RAM. This function mmaps the opened file anywhere and adds the memory to the ram blocks. Usage is qemu_ram_mmap(fd, size, MAP_SHARED, offset); S

Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-05-10 Thread Christoph Hellwig
On Mon, May 10, 2010 at 11:41:15AM +0200, Kevin Wolf wrote: > For one, there is a typo in the variable name, and also this is a void > function which shouldn't return anything. The caller still seems to use > the return value. Should probably stay an int function. Yes, this was missing a quilt ref

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Stefan Hajnoczi
> diff --git a/src/virtio-blk.c b/src/virtio-blk.c > new file mode 100644 > index 000..a41c336 > --- /dev/null > +++ b/src/virtio-blk.c > @@ -0,0 +1,155 @@ > +// Virtio blovl boot support. Just noticed the "blovl" typo. > +        char *desc = malloc_tmphigh(MAXDESCSIZE); > +        struct vi

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Jan Kiszka
Markus Armbruster wrote: > Jan Kiszka writes: > >> Luiz, >> >> I missed this when the API was first proposed: >> >> cur_mon is scheduled for removal (one day...). It's just an intermediate >> step to convert all users to explicit 'mon' passing. Thus, new APIs >> should not rely it. >> >> I just r

Re: [Qemu-devel] [PATCH 2/3] dmg: use pread

2010-05-10 Thread Kevin Wolf
Am 07.05.2010 16:56, schrieb Christoph Hellwig: > Use pread instead of lseek + read in preparation of using the qemu > block API. Note that dmg actually uses the implicit file offset > a lot in dmg_open, and we had to replace it with an offset variable. > > Signed-off-by: Christoph Hellwig > >

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-10 Thread Kevin Wolf
Am 09.05.2010 12:17, schrieb Stefan Weil: > Kevin and you are right, and my interpretation of disk_size was wrong. > > disk_size is not the size used for the blocks (then it would have to be > large enough to keep all blocks). > > disk_size is the number of bytes which are really used for data >

[Qemu-devel] Re: AHCI support integration

2010-05-10 Thread Joerg Roedel
On Sun, May 09, 2010 at 09:11:17PM +0200, Alexander Graf wrote: > Sebastian Herbszt wrote: > > The ICH6 AHCI implementation submitted by Chong is an all-in-one > > attempt (ahci.c). > > It includes all needed parts of the ICH6, AHCI, SATA and ATA > > specification. > > The code in hw/ide/* on the o

Re: [Qemu-devel] Re: [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined)

2010-05-10 Thread Paolo Bonzini
> 3. Change the definition of WIN32_LEAN_AND_MEAN in configure/make. > > Solution 3 is a very simple change. It works for the moment, > but would raise warnings when a library header file with a > different definition of WIN32_LEAN_AND_MEAN is used. > When I scanned the system headers of my mingw3

Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-05-10 Thread Kevin Wolf
Am 07.05.2010 17:17, schrieb Christoph Hellwig: > We don't have an equivalent to mmap in the qemu block API, so read and > write the bitmap directly. At least in the dumb implementation added > in this patch this is a lot less efficient, but it means cow can also > work on windows, and over nbd or

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Markus Armbruster
Jan Kiszka writes: > Luiz, > > I missed this when the API was first proposed: > > cur_mon is scheduled for removal (one day...). It's just an intermediate > step to convert all users to explicit 'mon' passing. Thus, new APIs > should not rely it. > > I just realized that monitor_cur_is_qmp() does

Re: [Qemu-devel] Re: sparc64 lazy conditional codes evaluation

2010-05-10 Thread Mark Cave-Ayland
Blue Swirl wrote: Thanks a lot, with this patch my tests passed! I applied the combined patch. Yes, I definitely see an improvement with this patch - at least my Debian lenny SPARC boot cd doesn't randomly kernel panic any more. It looks as if it now just can't find /init which could just be

[Qemu-devel] [PATCHv3] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov --- Changelog: v1->v2: - free memory in case of vq initialization error. - change license of virtio ring/pci to LGPLv3 with permission of Laurent Vivier (aka the author). v2->v3: - fr

Re: [Qemu-devel] [PATCH 2/5] Add defines for PCI IDs.

2010-05-10 Thread Gerd Hoffmann
On 05/07/10 17:32, Blue Swirl wrote: On 5/7/10, Gerd Hoffmann wrote: This patch allows to set PCI vendor and device IDs using defines (PCI_VID and PCI_DID). Use it for vgabios.bin. Signed-off-by: Gerd Hoffmann --- Makefile |4 ++-- vbe.c |6 +- vgabios.c |5 +

Re: [Qemu-devel] AHCI support integration

2010-05-10 Thread Christoph Egger
On Sunday 09 May 2010 18:01:50 Sebastian Herbszt wrote: > The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt > (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA > specification. The code in hw/ide/* on the other hand is split (or could be > split) into sma

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
On Mon, May 10, 2010 at 09:25:20AM +0100, Stefan Hajnoczi wrote: > > diff --git a/src/virtio-blk.c b/src/virtio-blk.c > > new file mode 100644 > > index 000..a41c336 > > --- /dev/null > > +++ b/src/virtio-blk.c > > @@ -0,0 +1,155 @@ > > +// Virtio blovl boot support. > > Just noticed the "blov

Re: [Qemu-devel] Re: AHCI support integration

2010-05-10 Thread Christoph Egger
On Sunday 09 May 2010 21:11:17 Alexander Graf wrote: > Sebastian Herbszt wrote: > > The ICH6 AHCI implementation submitted by Chong is an all-in-one > > attempt (ahci.c). > > It includes all needed parts of the ICH6, AHCI, SATA and ATA > > specification. > > The code in hw/ide/* on the other hand i

[Qemu-devel] Re: [SeaBIOS] [PATCHv3] Support for booting from virtio disks

2010-05-10 Thread Stefan Hajnoczi
Looks good. Stefan

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-10 Thread Avi Kivity
On 05/10/2010 10:41 AM, Avi Kivity wrote: On 05/06/2010 11:07 PM, Michael Tokarev wrote: There was a bug recently fixed in vnc code. Apparently there's something similar in the cirrus emulation as well. Here it triggers _always_ (including old versions of kvm) when running windows NT and hittin

[Qemu-devel] [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov --- Changelog: v1->v2: - free memory in case of vq initialization error. - change license of virtio ring/pci to LGPLv3 with permission of Laurent Vivier (aka the author). diff --git a/M

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-10 Thread Avi Kivity
On 05/06/2010 11:07 PM, Michael Tokarev wrote: There was a bug recently fixed in vnc code. Apparently there's something similar in the cirrus emulation as well. Here it triggers _always_ (including old versions of kvm) when running windows NT and hitting "test" button in its display resolution d

[Qemu-devel] [PATCH v2] QMP: Add "Downstream extension of QMP" to spec

2010-05-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- v2: Clarify use of __RFQDN (Thanks, Luiz!) QMP/qmp-spec.txt | 55 ++ 1 files changed, 55 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt index f3c0327..9d30a8c 100644 --- a/

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-05-10 Thread Avi Kivity
On 05/09/2010 10:35 PM, Gerhard Wiesinger wrote: Please run kvm_stat and report output for both tests to confirm. See below. 2nd column is per second statistic when running the test. efer_reload 0 0 exits 18470836 554582 fpu_reload 214783

<    1   2