Re: [Qemu-devel] [PATCH 1/2] Add no-op aio emulation stub

2010-05-11 Thread Stefan Hajnoczi
bdrv_aio_noop_em() could be useful for benchmarking and optimizing the aio code. It serves as a cheap operation that lets us see the cost of the aio roundtrip. Stefan

[Qemu-devel] the linux can not login in qemu

2010-05-11 Thread daniel tian
Hi, guys, I ported my mips-based machine into qemu. But the poky linux can not login when startup in qemu. here are the command and startup log: ./qemu-system-mipsel -M mavrix -kernel ../../kernel/vmlinux -hda ~/rootfs_poky.ext2 -append root=/dev/hda rootfstype=ext2 console=ttyS0 -serial stdio

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-11 Thread Kevin Wolf
Am 10.05.2010 22:12, schrieb Stefan Weil: The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of the block size.

Re: [Qemu-devel] [PATCH 2/3] dmg: use pread

2010-05-11 Thread Kevin Wolf
Am 10.05.2010 22:20, schrieb Christoph Hellwig: On Mon, May 10, 2010 at 12:07:40PM +0200, Kevin Wolf wrote: + if (type == 0x6d697368 count = 244) { int new_size, chunk_count; - if(lseek(s-fd,200,SEEK_CUR)0) - goto fail; + +offset += 4; Isn't this

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/10/2010 08:52 PM, Anthony Liguori wrote: Why try to attempt to support multi-master shared memory? What's the use-case? I don't see it as multi-master, but that the latest guest to join shouldn't have their contents take precedence. In developing this patch, my motivation has been to

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/10/2010 08:25 PM, Anthony Liguori wrote: On 05/10/2010 11:59 AM, Avi Kivity wrote: On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during initialization, I would have to use MAP_FIXED to mmap the memory. This is what I did before the qemu_ram_mmap()

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Avi Kivity
On 05/10/2010 06:48 PM, Anthony Liguori wrote: On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapovg...@redhat.com A related problem that I think we need to think about how we solve is indicating to

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 02:17 AM, Cam Macdonell wrote: On Mon, May 10, 2010 at 5:59 AM, Avi Kivitya...@redhat.com wrote: On 04/21/2010 08:53 PM, Cam Macdonell wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also

[Qemu-devel] Re: [PATCH 1/2] Add no-op aio emulation stub

2010-05-11 Thread Kevin Wolf
Am 10.05.2010 23:51, schrieb Alexander Graf: We need to be able to do nothing in AIO fashion. Since I suspect this could be useful for more cases than the non flushing, I figured I'd create a new function that does everything AIO-like, but doesn't do anything. Signed-off-by: Alexander Graf

[Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Kevin Wolf
Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new parameter to -drive that allows us to set the flushing behavior to on or off,

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Stefan Hajnoczi
From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into bev[], which contains IPL entries (the drives). Is the order of bev[] entries well-defined? Is there a way for QEMU command-line to know that the first virtio-blk

[Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-11 Thread Joerg Roedel
On Tue, May 11, 2010 at 01:19:27AM +0200, Alexander Graf wrote: On 11.05.2010, at 00:13, Sebastian Herbszt wrote: The problem of incremental patches will be a non issue as soon as the git tree is available. I set up a mailing list and a git tree for development. The mailing list is

Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Markus Armbruster
Alex Williamson alex.william...@redhat.com writes: If the init function of a device fails, as might happen with device assignment, we never undo the work done by do_pci_register_device(). This not only causes a bit of a memory leak, but also leaves a bogus pointer in the bus devices array

Re: [Qemu-devel] [RFC][MIPS][PATCH 2/6] Initial support of vt82686b south bridge used by fulong mini pc

2010-05-11 Thread chen huacai
On Tue, May 11, 2010 at 3:28 AM, Blue Swirl blauwir...@gmail.com wrote: On 5/9/10, chen huacai zltjiang...@gmail.com wrote: This patch add initial support of vt82686b south bridge used by fulong mini pc  Signed-off-by: Huacai Chen zltjiang...@gmail.com  -  diff --git a/Makefile.target

Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Gerd Hoffmann
On 05/11/10 11:25, Markus Armbruster wrote: Alex Williamsonalex.william...@redhat.com writes: If the init function of a device fails, as might happen with device assignment, we never undo the work done by do_pci_register_device(). This not only causes a bit of a memory leak, but also leaves a

[Qemu-devel] Re: [PATCH] block/vpc: Fix conversion from size to disk geometry

2010-05-11 Thread Kevin Wolf
Am 10.05.2010 21:46, schrieb Stefan Weil: The VHD algorithm calculates a disk geometry which is usually smaller than the requested size. QEMU tried to round up but failed for certain sizes: qemu-img create -f vpc disk.vpc 9437184 would create an image with 9435136 bytes (which is too

[Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-11 Thread Alexander Graf
Am 11.05.2010 um 11:25 schrieb Joerg Roedel j...@8bytes.org: On Tue, May 11, 2010 at 01:19:27AM +0200, Alexander Graf wrote: On 11.05.2010, at 00:13, Sebastian Herbszt wrote: The problem of incremental patches will be a non issue as soon as the git tree is available. I set up a mailing

Re: [Qemu-devel] [RFC][MIPS][PATCH 3/6] Initial support of VIA IDE controller used by fulong mini pc

2010-05-11 Thread chen huacai
 +    pci_register_bar((PCIDevice *)d, 4, 0x10,  +                           PCI_BASE_ADDRESS_SPACE_IO, bmdma_map);  +  +    vmstate_register(0, vmstate_ide_pci, d); Is this correct? I think so, since ide/piix.c and ide/cmd646.c both do in this way. -- Huacai Chen

[Qemu-devel] Qemu-KVM Livate Migration 0.12.2 - 0.12.3/4 broken?

2010-05-11 Thread Peter Lieven
Hi Qemu/KVM Devel Team, Live Migration from a 0.12.2 qemu-kvm to a 0.12.3 (and 0.12.4) does not work: load of migration failed Is there any way to find out, why exactly it fails? I have a lot of VMs running on 0.12.2 and would like to migrate them to 0.12.4 cmdline: -net

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Christoph Hellwig
On Tue, May 11, 2010 at 10:36:24AM +0200, Kevin Wolf wrote: Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new parameter to -drive

[Qemu-devel] [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Juan Quintela
This variable contains the objects shared between tools and qemu binary. Add qemu-error.o only in one place, it could be built in two places depending of make ordering. Signed-off-by: Juan Quintela quint...@redhat.com --- Makefile |8 +--- Makefile.objs |9 ++--- 2 files

[Qemu-devel] [PATCH 0/2] Makefile: remoeve duplicate qemu-error.o

2010-05-11 Thread Juan Quintela
Hi qemu-error.o appears in several places in Makefile*, with several combinations of make; make clean; make you could get a build error. Fix it defining it in a single place. Once there, just create a shared-obj-y for objects that are needed for both tools and qemu binary. This should remove

[Qemu-devel] [PATCH 2/2] state that fsdev depends on LINUX only once

2010-05-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- Makefile.objs |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 95d864b..f963c3f 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -35,8 +35,8 @@ net-nested-$(CONFIG_SLIRP) +=

Re: [Qemu-devel] [PATCH 2/2] acpi: remove static gpe and pci0_status variables

2010-05-11 Thread Isaku Yamahata
Hi Blue. I send out very similar patches before and got acked-by from Gerd. But they haven't been merged yet. Please look at them. Instead of reinventing similar patches, those patches should be merged. If necessary, I'm willing to rebase them and resend them. As for code iteself, the hotplug

Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Markus Armbruster
Juan Quintela quint...@redhat.com writes: This variable contains the objects shared between tools and qemu binary. Add qemu-error.o only in one place, it could be built in two places depending of make ordering. Yup, that's what I should've done when I added qemu-error.c.

Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Kevin Wolf
Am 11.05.2010 13:13, schrieb Juan Quintela: This variable contains the objects shared between tools and qemu binary. Add qemu-error.o only in one place, it could be built in two places depending of make ordering. Signed-off-by: Juan Quintela quint...@redhat.com --- a/Makefile.objs +++

[Qemu-devel] [PATCH v2] Fix -device help and documentation

2010-05-11 Thread Markus Armbruster
Commit 6616b2ad reverted commit 40ea285c. Looks like a mismerge to me. Signed-off-by: Markus Armbruster arm...@redhat.com --- v2: rebased (v1 fell through the cracks apparently) qemu-options.hx | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 11.05.2010 13:13, schrieb Juan Quintela: This variable contains the objects shared between tools and qemu binary. Add qemu-error.o only in one place, it could be built in two places depending of make ordering. Signed-off-by: Juan Quintela

[Qemu-devel] Re: [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Juan Quintela
Kevin Wolf kw...@redhat.com wrote: Am 11.05.2010 13:13, schrieb Juan Quintela: This variable contains the objects shared between tools and qemu binary. Add qemu-error.o only in one place, it could be built in two places depending of make ordering. Signed-off-by: Juan Quintela

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
What about another cache=... value instead of adding more options? I'm quite sure you'll only ever need this with writeback caching. So we could have cache=none|writethrough|writeback|wb-noflush or something like that. I agree. The cache option really isn't too useful. There's a

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Gleb Natapov
On Tue, May 11, 2010 at 11:19:07AM +0300, Avi Kivity wrote: On 05/10/2010 06:48 PM, Anthony Liguori wrote: On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapovg...@redhat.com A related problem that

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Gleb Natapov
On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into bev[], which contains IPL entries (the drives). Is the order of bev[] entries well-defined?

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 07:15 AM, Paul Brook wrote: What about another cache=... value instead of adding more options? I'm quite sure you'll only ever need this with writeback caching. So we could have cache=none|writethrough|writeback|wb-noflush or something like that. I think this table is

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Kevin O'Connor
On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into bev[], which contains IPL entries (the drives). Is the order of bev[] entries well-defined?

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Gleb Natapov
On Tue, May 11, 2010 at 08:45:29AM -0400, Kevin O'Connor wrote: On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into bev[], which contains IPL

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Anthony Liguori
On 05/11/2010 02:59 AM, Avi Kivity wrote: (Replying again to list) What data structure would you use? For a lockless ring queue, you can only support a single producer and consumer. To achieve bidirectional communication in virtio, we always use two queues. You don't have to use a

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
cache=always (or a more scary name like cache=lie to defend against idiots) Reads and writes are cached. Guest flushes are ignored. Useful for dumb guests in non-critical environments. I really don't believe that we should support a cache=lie. There are many other obtain the

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 08:12 AM, Paul Brook wrote: cache=always (or a more scary name like cache=lie to defend against idiots) Reads and writes are cached. Guest flushes are ignored. Useful for dumb guests in non-critical environments. I really don't believe that we should support a

[Qemu-devel] Re: KVM call agenda for May 11

2010-05-11 Thread Chris Wright
* Chris Wright (chr...@redhat.com) wrote: Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. No agenda, so no call this week. thanks, -chris

[Qemu-devel] [PATCH] Fix regression for -drive file=

2010-05-11 Thread Markus Armbruster
Empty file used to create an empty drive (no media). Since commit 9dfd7c7a, it's an error: qemu: could not open disk image : No such file or directory. Older versions of libvirt can choke on this. Signed-off-by: Markus Armbruster arm...@redhat.com --- If this goes in, I'll prepare a patch for

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. - Exposing named errno in QMP errors (hope it's not too late)

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Alexander Graf
Luiz Capitulino wrote: On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. - Exposing named errno in QMP errors - flush=on Alex

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
In a development environment the rules can be a bit different. For example if you're testing an OS installer then you really don't want to be passing magic mount options. If the host machine dies then you don't care about the state of the guest because you're going to start from scratch

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Tue, 11 May 2010 15:50:32 +0200 Alexander Graf ag...@suse.de wrote: Luiz Capitulino wrote: On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. - Exposing named errno in QMP errors

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Jes Sorensen
On 05/11/10 15:53, Luiz Capitulino wrote: On Tue, 11 May 2010 15:50:32 +0200 Alexander Graf ag...@suse.de wrote: Luiz Capitulino wrote: On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. -

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Tue, 11 May 2010 15:57:10 +0200 Jes Sorensen jes.soren...@redhat.com wrote: On 05/11/10 15:53, Luiz Capitulino wrote: On Tue, 11 May 2010 15:50:32 +0200 Alexander Graf ag...@suse.de wrote: Luiz Capitulino wrote: On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 04:10 PM, Anthony Liguori wrote: On 05/11/2010 02:59 AM, Avi Kivity wrote: (Replying again to list) What data structure would you use? For a lockless ring queue, you can only support a single producer and consumer. To achieve bidirectional communication in virtio, we always

Re: [Qemu-devel] qemu-system-sh4 broken again.

2010-05-11 Thread Shin-ichiro KAWASAKI
Hello, Aurelian, Thank you for clarification. I've understood the situation. My comment is not the solution for Rob's problem. Best Regards, Shin-ichiro KAWASAKI (2010/05/11 0:48), Aurelien Jarno wrote: Shin-ichiro KAWASAKI a écrit : Hello, Rob, This mail might be too late, but I want to

[Qemu-devel] [PATCH v2] sh: sm501: add 2D engine support

2010-05-11 Thread Shin-ichiro KAWASAKI
Hello Blue Swirl, and thank you for the review. Here's the patch modified according to your comments. abort() is used instead of assert(), and const modifier added for CPU*MemoryFunc. Best Regards, Shin-ichiro KAWASAKI

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Cam Macdonell
On Tue, May 11, 2010 at 8:03 AM, Avi Kivity a...@redhat.com wrote: On 05/11/2010 04:10 PM, Anthony Liguori wrote: On 05/11/2010 02:59 AM, Avi Kivity wrote: (Replying again to list) What data structure would you use?  For a lockless ring queue, you can only support a single producer and

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 05:17 PM, Cam Macdonell wrote: The master is the shared memory area. It's a completely separate entity that is represented by the backing file (or shared memory server handing out the fd to mmap). It can exists independently of any guest. I think the master/peer idea

[Qemu-devel] Re: [SeaBIOS] About cpu_set, CPU hotplug and related subjects

2010-05-11 Thread Carl-Daniel Hailfinger
On 28.04.2010 12:45, Gleb Natapov wrote: On Wed, Apr 28, 2010 at 12:41:51PM +0200, Jes Sorensen wrote: The CPU declarations are particularly tricky as they get pretty big and complex and need to live in the DSDT, whereas a lot of other things we can shift off to separate SSDT tables and

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Alexander Graf
Paul Brook wrote: What about another cache=... value instead of adding more options? I'm quite sure you'll only ever need this with writeback caching. So we could have cache=none|writethrough|writeback|wb-noflush or something like that. I agree. The cache option really isn't

[Qemu-devel] [PATCH] Fix leul_to_cpu on big endian hosts

2010-05-11 Thread Alexander Graf
Commit 213acd2e introduced leul_to_cpu with a special code path for big endian hosts. Unfortunately that code used preprocessor magic that didn't work. This patch replaces the explicit ##s by glue() which is proven to work reliably, enabling me to compile qemu on ppc again. Signed-off-by:

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 08:50 AM, Paul Brook wrote: In a development environment the rules can be a bit different. For example if you're testing an OS installer then you really don't want to be passing magic mount options. If the host machine dies then you don't care about the state of the guest because

[Qemu-devel] [PPC] Can't boot iso images

2010-05-11 Thread Alexander Graf
Howdy, While trying to boot an openSUSE 11.1 iso I always get /packages/elf-loader is missing. Apparently that bug was fixed in a more recent version of OpenBIOS. According to git log the version in pc-bios is r721. Could we please pull in a more recent version? Alex

Re: [Qemu-devel] [RFC] default mac address issue

2010-05-11 Thread Bruce Rogers
On 5/10/2010 at 01:33 PM, Anthony Liguori anth...@codemonkey.ws wrote: ... 1) have qemu print a warning to stdout/stderr that the default mac address is being used and that it will interfere with other vms running the same way on a common network segment This is definitely

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Anthony Liguori
On 05/11/2010 09:53 AM, Avi Kivity wrote: On 05/11/2010 05:17 PM, Cam Macdonell wrote: The master is the shared memory area. It's a completely separate entity that is represented by the backing file (or shared memory server handing out the fd to mmap). It can exists independently of any

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Alexander Graf
Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to front-end drivers whenever they were unable to read data immediately, e.g.

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Jan Kiszka
Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to front-end drivers whenever they were unable to read

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: On 05/11/2010 08:12 AM, Paul Brook wrote: cache=always (or a more scary name like cache=lie to defend against idiots) Reads and writes are cached. Guest flushes are ignored. Useful for dumb guests in non-critical environments. I really don't believe

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Alexander Graf
Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to front-end drivers

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Cam Macdonell
On Tue, May 11, 2010 at 9:51 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/11/2010 09:53 AM, Avi Kivity wrote: On 05/11/2010 05:17 PM, Cam Macdonell wrote: The master is the shared memory area.  It's a completely separate entity that is represented by the backing file (or shared

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-11 Thread Stefan Weil
Am 11.05.2010 18:23, schrieb Alexander Graf: On S390 we don't have a real TCG implementation but use a stub instead. This stub obviously doesn't call any of the TCG helper functions that are usually used by the other TCG targets. If such a helper function is static though, we end up getting a

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 10:53 AM, Paul Brook wrote: I disagree. We should not be removing or rejecting features just because they allow you to shoot yourself in the foot. We probably shouldn't be enabling them by default, but that's a whole different question. I disagree and think the mentality

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 11:32 AM, Jamie Lokier wrote: Anthony Liguori wrote: On 05/11/2010 08:12 AM, Paul Brook wrote: cache=always (or a more scary name like cache=lie to defend against idiots) Reads and writes are cached. Guest flushes are ignored. Useful for dumb guests in

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-11 Thread Richard Henderson
On 05/11/2010 09:47 AM, Stefan Weil wrote: Won't you get another warning about unreachable code because tcg_abort never returns? We don't enable that warning. What about condition compilation for tcg_out_reloc (don't compile it for hosts which don't need it)? All hosts should need it. S390

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Cam Macdonell
On Tue, May 11, 2010 at 11:05 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/11/2010 11:39 AM, Cam Macdonell wrote: Most of the people I hear from who are using my patch are using a peer model to share data between applications (simulations, JVMs, etc). But guest-to-host applications

Re: [Qemu-devel] forking i386 binaries on arm linux user mode

2010-05-11 Thread Damion Yates
On Wed, 10 Feb 2010, Laurent Desnogues wrote: On Wed, Feb 10, 2010 at 10:38 PM, Damion Yates dam...@google.com wrote: I can now run loads of linux binaries on my armlinux system (a Nokia n900). I've tried tower toppler (http://toppler.sourceforge.net/) which uses SDL (via X11) and this

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 06:51 PM, Anthony Liguori wrote: On 05/11/2010 09:53 AM, Avi Kivity wrote: On 05/11/2010 05:17 PM, Cam Macdonell wrote: The master is the shared memory area. It's a completely separate entity that is represented by the backing file (or shared memory server handing out the fd

Re: [Qemu-devel] forking i386 binaries on arm linux user mode

2010-05-11 Thread Richard Henderson
On 05/11/2010 10:08 AM, Damion Yates wrote: Also is there some magic in gnemul-x86 beyond being a set of x86 libs? No. Does it do any shortcutting to system calls in native rather than sticking with the libs under emulation more? No. Could you explain what you did? I've tried the

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 08:05 PM, Anthony Liguori wrote: On 05/11/2010 11:39 AM, Cam Macdonell wrote: Most of the people I hear from who are using my patch are using a peer model to share data between applications (simulations, JVMs, etc). But guest-to-host applications work as well of course. I think

Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Blue Swirl
On 5/10/10, Alex Williamson alex.william...@redhat.com wrote: If the init function of a device fails, as might happen with device assignment, we never undo the work done by do_pci_register_device(). This not only causes a bit of a memory leak, but also leaves a bogus pointer in the bus

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: qemu-img create -f raw foo.img 10G mkfs.ext3 foo.img mount -oloop,rw,barrier=1 -t ext3 foo.img mnt Works perfectly fine. Hmm, interesting. Didn't know loop propagated barriers. So you're suggesting to use qemu with a loop device, and ext2 (bit faster than ext3) and

Re: [Qemu-devel] [RFC][MIPS][PATCH 3/6] Initial support of VIA IDE controller used by fulong mini pc

2010-05-11 Thread Blue Swirl
On 5/11/10, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On 5/9/10, chen huacai zltjiang...@gmail.com wrote: This patch add initial support of VIA IDE controller used by fulong mini pc Signed-off-by: Huacai Chen zltjiang...@gmail.com -

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Anthony Liguori
On 05/11/2010 11:39 AM, Cam Macdonell wrote: Most of the people I hear from who are using my patch are using a peer model to share data between applications (simulations, JVMs, etc). But guest-to-host applications work as well of course. I think transparent migration can be achieved by making

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Jamie Lokier
Paul Brook wrote: cache=none: No host caching. Reads and writes both go directly to underlying storage. Useful to avoid double-caching. cache=writethrough Reads are cached. Writes go directly to underlying storage. Useful for broken guests that aren't aware of drive caches. These

Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Alex Williamson
On Tue, 2010-05-11 at 21:17 +0300, Blue Swirl wrote: On 5/10/10, Alex Williamson alex.william...@redhat.com wrote: hw/pci.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index f167436..3d3560e 100644 --- a/hw/pci.c

[Qemu-devel] [PATCH v2] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Alex Williamson
If the init function of a device fails, as might happen with device assignment, we never undo the work done by do_pci_register_device(). This not only causes a bit of a memory leak, but also leaves a bogus pointer in the bus devices array that can cause a segfault or garbage data from 'info pci'.

[Qemu-devel] Re: [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Ryan Harper
* Michael S. Tsirkin m...@redhat.com [2010-05-05 16:37]: Generally, the Host end of the virtio ring doesn't need to see where Guest is up to in consuming the ring. However, to completely understand what's going on from the outside, this information must be exposed. For example, host can

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Avi Kivity
On 05/11/2010 11:36 AM, Kevin Wolf wrote: Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new parameter to -drive that allows us to set

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Avi Kivity
On 05/11/2010 06:40 PM, Anthony Liguori wrote: But if the goal is to make sure that fsync's don't result in data actually being on disk, there are many other ways to accomplish this. First, for the vast majority of users, this is already the case because ext3 defaults to disabling barriers.

[Qemu-devel] Re: [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-11 Thread Blue Swirl
On 5/11/10, Richard Henderson r...@twiddle.net wrote: Use int32 types instead of target_ulong when computing ICC. This simplifies the generated code for 32-bit host and 64-bit guest. Use the same simplified expressions for ICC as were already used for XCC in carry flag generation. ADDX

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Avi Kivity
On 05/07/2010 06:23 AM, Rusty Russell wrote: On Thu, 6 May 2010 07:30:00 pm Avi Kivity wrote: On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote: + /* We publish the last-seen used index at the end of the available ring. +* It is at the end for backwards compatibility. */

[Qemu-devel] Re: [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.

2010-05-11 Thread Blue Swirl
On 5/11/10, Richard Henderson r...@twiddle.net wrote: Computing carry is trivial for some inputs. By avoiding an external function call, we generate near-optimal code for the common cases of add+addx (double-word arithmetic) and cmp+addx (a setcc pattern). Signed-off-by: Richard

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-11 Thread Alexander Graf
Am 11.05.2010 um 19:26 schrieb Richard Henderson r...@twiddle.net: On 05/11/2010 09:47 AM, Stefan Weil wrote: Won't you get another warning about unreachable code because tcg_abort never returns? We don't enable that warning. What about condition compilation for tcg_out_reloc (don't

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-11 Thread Blue Swirl
On 5/11/10, chen huacai zltjiang...@gmail.com wrote: +s-pci = qemu_mallocz(sizeof(*s-pci)); +assert(s-pci != NULL); +bonito_state = s; + +/* get the north bridge pci bus */ +s-pci-bus = pci_register_bus(NULL, pci, pci_bonito_set_irq, +

[Qemu-devel] Re: [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Michael S. Tsirkin
On Tue, May 11, 2010 at 01:46:08PM -0500, Ryan Harper wrote: * Michael S. Tsirkin m...@redhat.com [2010-05-05 16:37]: Generally, the Host end of the virtio ring doesn't need to see where Guest is up to in consuming the ring. However, to completely understand what's going on from the

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Michael S. Tsirkin
On Tue, May 11, 2010 at 10:27:22PM +0300, Avi Kivity wrote: On 05/07/2010 06:23 AM, Rusty Russell wrote: On Thu, 6 May 2010 07:30:00 pm Avi Kivity wrote: On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote: + /* We publish the last-seen used index at the end of the available ring. +

[Qemu-devel] Re: [PATCH v2] QMP: Add Downstream extension of QMP to spec

2010-05-11 Thread Luiz Capitulino
On Mon, 10 May 2010 09:16:05 +0200 Markus Armbruster arm...@redhat.com wrote: Signed-off-by: Markus Armbruster arm...@redhat.com Looks good to me. --- v2: Clarify use of __RFQDN (Thanks, Luiz!) QMP/qmp-spec.txt | 55 ++ 1 files

[Qemu-devel] [PATCH] ahci: use interface type IF_SATA

2010-05-11 Thread Sebastian Herbszt
Use interface type IF_SATA instead of IF_SCSI. Signed-off-by: Sebastian Herbszt herb...@gmx.de diff --git a/hw/ahci.c b/hw/ahci.c index 2763075..6f7b807 100644 --- a/hw/ahci.c +++ b/hw/ahci.c @@ -1160,7 +1160,7 @@ static AHCIState *ahci_new(void) s-timer = qemu_new_timer(vm_clock,

[Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a port is assigned or not

2010-05-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ioport.c |5 + ioport.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index 53dd87a..b718047 100644 --- a/ioport.c +++ b/ioport.c @@ -190,6 +190,11 @@ void isa_unassign_ioport(pio_addr_t

[Qemu-devel] [PATCH 2/2] all vga: fail graicefully when vga ports are taken

2010-05-11 Thread Gerd Hoffmann
Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/cirrus_vga.c |3 +++ hw/vga-pci.c|3 +++ hw/vmware_vga.c |3 +++ 3 files changed, 9 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/2] acpi: remove static gpe and pci0_status variables

2010-05-11 Thread Blue Swirl
On 5/11/10, Isaku Yamahata yamah...@valinux.co.jp wrote: Hi Blue. I send out very similar patches before and got acked-by from Gerd. But they haven't been merged yet. Please look at them. Instead of reinventing similar patches, those patches should be merged. If necessary, I'm willing to

Re: [Qemu-devel] qemu-kvm problem with DOS/4GW extender and EMM386.EXE

2010-05-11 Thread Mohammed Gamal
On Tue, May 11, 2010 at 11:56 PM, Andy Walls awa...@md.metrocast.net wrote: Running an MS-DOS 6.22 image with qemu-kvm on a RedHat Linux OS, I noticed the guest OS becomes hung and my dmesg gets spammed with        set_cr0: #GP, set PG flag with a clear PE flag That message appears to be the

Re: [Qemu-devel] qemu-kvm problem with DOS/4GW extender and EMM386.EXE

2010-05-11 Thread Avi Kivity
On 05/11/2010 11:56 PM, Andy Walls wrote: Running an MS-DOS 6.22 image with qemu-kvm on a RedHat Linux OS, I noticed the guest OS becomes hung and my dmesg gets spammed with set_cr0: #GP, set PG flag with a clear PE flag That message appears to be the linux kernel's kvm emulator

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-11 Thread Artyom Tarasenko
2010/5/11 Richard Henderson r...@twiddle.net: Use int32 types instead of target_ulong when computing ICC.  This simplifies the generated code for 32-bit host and 64-bit guest. Use the same simplified expressions for ICC as were already used for XCC in carry flag generation. ADDX ICC carry

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: There's got to be a better place to fix this. Disable barriers in your guests? If only it were that easy. OS installs are the thing that this feature would most help. They take ages, do a huge amount of writing with lots of seeking, and if the host fails you're going

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
Paul Brook wrote: cache=none: No host caching. Reads and writes both go directly to underlying storage. Useful to avoid double-caching. cache=writethrough Reads are cached. Writes go directly to underlying storage. Useful for broken guests that aren't aware of drive

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
Paul Brook wrote: cache=none: No host caching. Reads and writes both go directly to underlying storage. Useful to avoid double-caching. cache=writethrough Reads are cached. Writes go directly to underlying storage. Useful for broken guests that

  1   2   >