On Thu, May 27, 2010 at 06:37:10PM +, Blue Swirl wrote:
> 2010/5/27 Gleb Natapov :
> > On Wed, May 26, 2010 at 08:35:00PM +, Blue Swirl wrote:
> >> On Wed, May 26, 2010 at 8:09 PM, Jan Kiszka wrote:
> >> > Blue Swirl wrote:
> >> >> On Tue, May 25, 2010 at 9:44 PM, Jan Kiszka wrote:
> >> >
Hi,
Thankss for your answer.
SVM always clears the vmcb.eventinj on vmrun because every exception is
injected right after vmrun finished and cpu is in guest mode. It can
happen (for example if taking the exception causes a page fault) that
the vmcb.eventinj field is copied to vmcb.exit_int_info
Roedel, Joerg wrote:
> On Thu, May 27, 2010 at 06:20:00PM -0400, Jan Kiszka wrote:
>> Erik van der Kouwe wrote:
>>> Problem is: I'm compiling in Linux and testing in MINIX. Testing on the
>>> real hardware would require a reboot everytime. Moreover, it might screw
>>> up my system if I make bad mis
Artyom Tarasenko wrote:
> 2010/5/27 Bob Breuer :
>
>> Artyom Tarasenko wrote:
>>
>>> Was going to put some more empty slots into SS-10/20 (VSIMMs, SX)
>>> after we are done with SS-5 (due to technical limitations I can switch
>>> access from one real SS model to another one once a few days
On Thu, May 27, 2010 at 02:53:18PM -0400, Jan Kiszka wrote:
> Based on the KVM code (which is known to work perfectly :) ), I think
> you are right: SVM apparently clears the valid bit in EVENTINJ during
> VMRUN once it starts processing the injection, not after it as it's the
> case in current QEM
On Thu, May 27, 2010 at 06:20:00PM -0400, Jan Kiszka wrote:
> Erik van der Kouwe wrote:
> > Problem is: I'm compiling in Linux and testing in MINIX. Testing on the
> > real hardware would require a reboot everytime. Moreover, it might screw
> > up my system if I make bad mistakes (the MINIX filesys
On Fri, May 28, 2010 at 02:10:59AM -0400, Jan Kiszka wrote:
> Erik van der Kouwe wrote:
> > In my experience, if I provide the -enable-kvm switch then the guest VMM
> > never detects the presence of virtualization support. Does this only
> > work on AMD hardware? Or do I need to supply some additi
Soluzioni Finanziarie
Siamo operativi in tutta Italia
Fin World
Novità: Prestito per casalinghe e studenti ( Visualizza )
Aziende in crisi: gestione dei debiti e rilancio dell'attività ( Visualizza )
Finanziamenti per aziende e privati ( Visualizza )
Commercialista On-line (Visualizza )
H
On 05/27/2010 05:44 PM, Jes Sorensen wrote:
> Candidate for stable too?
It should be safe to apply, but I didn't find any current users where
the mask was applied in a way where it was causing problems. Not sure if
you want the noise, or apply it as better safe than sorry?
The only use in fact
Igor Kovalenko wrote:
With many debian iso images I consistently get scrolling blanks after
the following line on qemu video console:
io sched cfq registered (default)
Please share your qemu command line, and installer prompt input if any.
Yeah, I do too. I originally thought that the Debian
Hi, All:
Is there a way to directly assign a device to guest os even the hardware
doesn't support VT-d and equivalent?
Thanks
Mu
On Fri, May 28, 2010 at 12:43 PM, Mark Cave-Ayland
wrote:
> Igor Kovalenko wrote:
>
>> With many debian iso images I consistently get scrolling blanks after
>> the following line on qemu video console:
>>
>> io sched cfq registered (default)
>>
>> Please share your qemu command line, and installer
On Fri, May 28, 2010 at 03:45:09AM -0400, Erik van der Kouwe wrote:
> This is a ok, the problem is the event_inj field rather than the
> exit_int_info field. From what I've seen the SVM specification neither
> specifies that the CPU writes to this field nor does it explicitly
> forbid it. Given
add helper function which converts root bus to pci domain.
make them aware of pci domain.
Signed-off-by: Isaku Yamahata
---
Changes: V1 -> V2
- removed pci_find_bus()
- renamed pci_find_bus_by_bus() to pci_find_bus()
- add abort()
---
hw/pci-hotplug.c |7 ---
hw/pci.c | 22 +++
On 05/28/10 10:32, Paolo Bonzini wrote:
> On 05/27/2010 05:44 PM, Jes Sorensen wrote:
>> > Candidate for stable too?
>> It should be safe to apply, but I didn't find any current users where
>> the mask was applied in a way where it was causing problems. Not sure if
>> you want the noise, or apply
On Thu, May 27, 2010 at 05:13:16PM +0300, Michael S. Tsirkin wrote:
> On Thu, May 27, 2010 at 02:44:42PM +0900, Isaku Yamahata wrote:
> > address and config_size are both unsigned.
> > So check which is bigger before minus operation.
> > Otherwise the result of minus can be unexpected
> > big value
From: Igor V. Kovalenko
Signed-off-by: Igor V. Kovalenko
---
sparc-dis.c |2 ++
target-sparc/op_helper.c | 10 +-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/sparc-dis.c b/sparc-dis.c
index c1b682d..dbd3b4f 100644
--- a/sparc-dis.c
+++ b/sparc-dis.c
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 17 ++---
hw/virtio-serial.h | 12
2 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index ccd277a..8a99a99 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-con
Add a 'description' along with each qdev property to document the input
each qdev property takes.
Signed-off-by: Amit Shah
---
block_int.h | 10 +++---
hw/a9mpcore.c |2 +-
hw/acpi_piix4.c |2 +-
hw/arm11mpcore.c |4 +-
hw/arm_sysctl.c |4 +-
Signed-off-by: Amit Shah
---
net.h | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/net.h b/net.h
index 0e9cc5d..8ad439a 100644
--- a/net.h
+++ b/net.h
@@ -20,10 +20,17 @@ typedef struct NICConf {
VLANClientState *peer;
} NICConf;
+#define PROP_NET_MAC
On 05/26/10 21:50, Michael S. Tsirkin wrote:
> Here's a rewrite of the original patch with a new layout.
> I haven't tested it yet so no idea how this performs, but
> I think this addresses the cache bounce issue raised by Avi.
> Posting for early flames/comments.
>
> Generally, the Host end of th
From: M. Mohan Kumar
SYNOPSIS
size[4] Tgetattr tag[2] fid[4]
size[4] Rgetattr tag[2] lstat[n]
DESCRIPTION
The getattr transaction inquires about the file identified by fid.
The reply will contain a machine-independent directory entry,
laid out as follows:
Another series of fixes for bugs that were found using blkdebug. The last two
of them are presumably relevant even outside error paths and can cause
corruption. They should be applied to stable-0.12, too.
Kevin Wolf (5):
qcow2: Allow qcow2_get_cluster_offset to return errors
qcow2: Change l2_l
Provide the error code to the caller instead of just indicating success/error.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 38 ++
1 files changed, 22 insertions(+), 16 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index e
Refblock allocation code needs to take into consideration that update_refcount
will load a different refcount block into the cache, so it must initialize the
cache for a new refcount block only afterwards. Not doing this means that not
only the refcount in the wrong block is updated, but also that
write_refcount_block_entries used to return -EIO for any errors. Change this to
return the real error code.
Signed-off-by: Kevin Wolf
---
block/qcow2-refcount.c | 27 +++
1 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qco
qcow2_get_cluster_offset() looks up a given virtual disk offset and returns the
offset of the corresponding cluster in the image file. Errors (e.g. L2 table
can't be read) are currenctly indicated by a return value of 0, which is
unfortuately the same as for any unallocated cluster. So in effect we
Am 27.05.2010 17:56, schrieb Nicholas A. Bellinger:
> On Thu, 2010-05-20 at 15:18 +0200, Kevin Wolf wrote:
>> Am 17.05.2010 18:45, schrieb Nicholas A. Bellinger:
>>> From: Nicholas Bellinger
>>>
>>> Greetings,
>>>
>>> Attached are the updated patches following hch's comments to fix
>>> scsi-gener
After it is done with updating refcounts in the cache, update_refcount writes
all changed entries to disk. If a refcount block allocation fails, however,
there was no change yet and therefore first_index = last_index = -1. Don't
treat -1 as a normal sector index (resulting in a 512 byte write!) but
Amit Shah writes:
> Add a 'description' along with each qdev property to document the input
> each qdev property takes.
>
> Signed-off-by: Amit Shah
I always wanted this, and never got around to code it up. Thanks!
[...]
> diff --git a/block_int.h b/block_int.h
> index 1a7240c..767cd29 100644
Amit Shah writes:
> Signed-off-by: Amit Shah
> ---
> hw/virtio-console.c | 17 ++---
> hw/virtio-serial.h | 12
> 2 files changed, 22 insertions(+), 7 deletions(-)
>
> diff --git a/hw/virtio-console.c b/hw/virtio-console.c
> index ccd277a..8a99a99 100644
> --- a/hw
Please test this against an unmodified upstream qemu to validate whether
this is a qemu or a qemu-kvm issue. Also, please include the full
command line along with the exact version information.
If you can collect a backtrace and attach it, that would also be
helpful. Thanks!
** Changed in: qemu
Amit Shah writes:
> Signed-off-by: Amit Shah
> ---
> net.h | 13 ++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/net.h b/net.h
> index 0e9cc5d..8ad439a 100644
> --- a/net.h
> +++ b/net.h
> @@ -20,10 +20,17 @@ typedef struct NICConf {
> VLANClientState *
Can you attempt to reproduce this against the latest upstream git? I
believe a fix for this has been committed and we probably need to
backport it to stable.
--
e1000 irq problems after live migration with qemu-kvm 0.12.4
https://bugs.launchpad.net/bugs/585113
You received this bug notification
On (Fri) May 28 2010 [14:49:39], Markus Armbruster wrote:
> Amit Shah writes:
>
> > Add a 'description' along with each qdev property to document the input
> > each qdev property takes.
> >
> > Signed-off-by: Amit Shah
>
> I always wanted this, and never got around to code it up. Thanks!
Cool
On (Fri) May 28 2010 [14:50:17], Markus Armbruster wrote:
> Amit Shah writes:
>
> > Signed-off-by: Amit Shah
> > ---
> > hw/virtio-console.c | 17 ++---
> > hw/virtio-serial.h | 12
> > 2 files changed, 22 insertions(+), 7 deletions(-)
> >
> > diff --git a/hw/virti
On (Fri) May 28 2010 [14:50:46], Markus Armbruster wrote:
> Amit Shah writes:
>
> > Signed-off-by: Amit Shah
> > ---
> > net.h | 13 ++---
> > 1 files changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/net.h b/net.h
> > index 0e9cc5d..8ad439a 100644
> > --- a/net.h
> > +++
*** This bug is a duplicate of bug 585113 ***
https://bugs.launchpad.net/bugs/585113
** This bug has been marked a duplicate of bug 585113
e1000 irq problems after live migration with qemu-kvm 0.12.4
--
some guests hangs after migration (qemu-kvm-0.12)
https://bugs.launchpad.net/bugs/5841
Reviewed-by: Stefan Hajnoczi
* john cooper [2010-03-25 00:45]:
> This series adds the minimal support to qemu and virtio_blk
> to support passing of a virtio_blk serial id string from qemu
> through the guest driver and to the guest userland.
>
> This is derived in part from a patch set posted by Rusty some
> time ago, but h
Roedel, Joerg wrote:
> On Fri, May 28, 2010 at 02:10:59AM -0400, Jan Kiszka wrote:
> > Erik van der Kouwe wrote:
>
> > > In my experience, if I provide the -enable-kvm switch then the guest VMM
> > > never detects the presence of virtualization support. Does this only
> > > work on AMD hardware? O
Hi,
And the svm-emulation is only available on AMD hardware.
I assume you mean nested SVM emulation in a KVM guest is only
available on real AMD hardware?
Is this due to something inherent, or just a limitation of the KVM
code not handling all the necessary traps in kvm-intel?
I don't think
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c |5 +
hw/qdev.h|1 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 9ffdba7..b6ee50f 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@
Signed-off-by: Markus Armbruster
---
hw/ide/cmd646.c |4 ++--
hw/ide/core.c | 30 ++
hw/ide/internal.h |5 +++--
hw/ide/isa.c|2 +-
hw/ide/macio.c |2 +-
hw/ide/microdrive.c |3 ++-
hw/ide/mmio.c |2 +-
hw/ide/p
Show the actual default value instead of when the property has
not been set.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index e8c066a..a3559d1 100644
--- a/hw/scsi-disk.c
+++
IDEState members drive_serial_str and version are now left empty until
an actual drive is connected. Before, they got a default value that
was overwritten when a drive got connected. Doesn't matter, because
they're used only while a drive is connected.
Signed-off-by: Markus Armbruster
---
hw/i
parse_string() qemu_strdup()s the property value. It is never freed.
It needs to be freed along with the device. Otherwise, the value of
scsi-disk property "ver" gets leaked when hot-unplugging the disk, for
instance.
Call new PropertyInfo method free() from qdev_free(). Implement it
for qdev_p
Signed-off-by: Markus Armbruster
---
hw/ide/internal.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/ide/internal.h b/hw/ide/internal.h
index 2efc784..b4554ce 100644
--- a/hw/ide/internal.h
+++ b/hw/ide/internal.h
@@ -464,8 +464,6 @@ typedef int (*ide_qdev_initfn)(
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 32 +---
1 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index c3334b1..443ff10 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2633,27 +2633,29 @@ void ide_init_d
On Fri, May 28, 2010 at 09:30:19AM -0400, Erik van der Kouwe wrote:
> Would be nice to have nested VMX support though, given that Intel CPUs
> are so much more common than AMDs. I've been searching on the Dell
> website (in the Netherlands) for a laptop recently and I couldn't find a
> single AM
Commit 428c149b added IDEState member conf to let commit 0009baf1 find
the BlockConf from there. It exists only for qdev drives, created via
ide_drive_initfn(), not for drives created via ide_init2().
But for a qdev drive, we can just as well reach its IDEDevice, which
contains the BlockConf. Do
On Fri, 28 May 2010 00:19:48 +0200
Jan Kiszka wrote:
> Luiz Capitulino wrote:
> > On Sun, 23 May 2010 12:59:19 +0200
> > Jan Kiszka wrote:
> >
> >> From: Jan Kiszka
> >>
> >> Allow to specify the device to be removed via device_del not only by ID
> >> but also by its full or abbreviated qtree
It needs to be a qdev property, because it belongs to the drive's
guest part.
Bonus: info qtree now shows the serial number.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 11 ++-
hw/ide/internal.h |4 +++-
hw/ide/qdev.c | 16 +++-
3 files changed, 24 i
Unused since commit 9dfd7c7a.
Signed-off-by: Markus Armbruster
---
sysemu.h |1 -
vl.c |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sysemu.h b/sysemu.h
index 063319c..fd83b7d 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -178,7 +178,6 @@ typedef struct DriveInfo {
On Fri, 28 May 2010 00:20:08 +0200
Jan Kiszka wrote:
> Luiz Capitulino wrote:
> > On Sun, 23 May 2010 12:59:26 +0200
> > Jan Kiszka wrote:
> >
> >> From: Jan Kiszka
> >>
> >> Ported commands that are marked 'user_only' will not be considered for
> >> QMP monitor sessions. This allows to implem
Am 27.05.2010 16:20, schrieb jes.soren...@redhat.com:
> From: Jes Sorensen
>
> Hi,
>
> Reading through some of the blk code, I noticed a lot of cases where
> we mix and match between hard-coded values for the block size of 512
> and using BDRV_SECTOR_SIZE. Trying to clean it up a bit and change
It needs to be a qdev property, because it belongs to the drive's
guest part.
Bonus: info qtree now shows the serial number.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-dis
Unused since commit 751c6a17.
Signed-off-by: Markus Armbruster
---
sysemu.h |1 -
vl.c |2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/sysemu.h b/sysemu.h
index 879446a..063319c 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -176,7 +176,6 @@ typedef struct DriveInfo {
I'm working on cleanly separating block device host and guest parts.
I'd like to route all this work through Kevin's block tree. This is
just preliminaries.
Markus Armbruster (14):
blockdev: Belatedly remove MAX_DRIVES
blockdev: Belatedly remove driveopts
usb: Remove unused usb_device_add()
Show the actual default value instead of when the property has
not been set.
Signed-off-by: Markus Armbruster
---
hw/ide/qdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 5f301bc..9b2aa21 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide
On Fri, May 28, 2010 at 09:20:31AM -0400, Jamie Lokier wrote:
> Roedel, Joerg wrote:
> > On Fri, May 28, 2010 at 02:10:59AM -0400, Jan Kiszka wrote:
> > > Erik van der Kouwe wrote:
> >
> > > > In my experience, if I provide the -enable-kvm switch then the guest VMM
> > > > never detects the presen
Unused since commit b3e461d3.
Signed-off-by: Markus Armbruster
---
vl.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 9283469..76a9b25 100644
--- a/vl.c
+++ b/vl.c
@@ -1315,7 +1315,7 @@ static void smp_parse(const char *optarg)
/
Amit Shah writes:
> On (Fri) May 28 2010 [14:50:46], Markus Armbruster wrote:
>> Amit Shah writes:
>>
>> > Signed-off-by: Amit Shah
>> > ---
>> > net.h | 13 ++---
>> > 1 files changed, 10 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/net.h b/net.h
>> > index 0e9cc5d..8ad439a
> Try to pci hotplug a vga card, watch qemu die with hw_error().
> This patch fixes it.
I think this is wrong. There's no reason why VGA adapters shouldn't be
hotplugged. You should fix the underlying problems that prevent hotplugging
(or make them fail gracefully).
Paul
> The problem is that this path is never used as tsr_retry is never > 0
> initially. So if qemu_chr_write() fails, we never try again but drop
qemu_chr_write is a blocking interface. It should only fail if an
unrecoverable error occurs. In that case there's noting useful we can do, and
no reason
Hi,
Would be nice to have nested VMX support though, given that Intel CPUs
are so much more common than AMDs. I've been searching on the Dell
website (in the Netherlands) for a laptop recently and I couldn't find a
single AMD model.
That doesn't mean they are uncommon ;-) There are many vend
Luiz Capitulino wrote:
> On Fri, 28 May 2010 00:19:48 +0200
> Jan Kiszka wrote:
>
>> Luiz Capitulino wrote:
>>> On Sun, 23 May 2010 12:59:19 +0200
>>> Jan Kiszka wrote:
>>>
From: Jan Kiszka
Allow to specify the device to be removed via device_del not only by ID
but also by i
Jan Kiszka writes:
> Luiz Capitulino wrote:
>> On Sun, 23 May 2010 12:59:19 +0200
>> Jan Kiszka wrote:
>>
>>> From: Jan Kiszka
>>>
>>> Allow to specify the device to be removed via device_del not only by ID
>>> but also by its full or abbreviated qtree path. For this purpose,
>>> qdev_find is
Von meinem iPhone gesendet
Am 28.05.2010 um 14:50 schrieb Anthony Liguori :
> Can you attempt to reproduce this against the latest upstream git? I
> believe a fix for this has been committed and we probably need to
> backport it to stable.
>
Anthony, can you specify which commit contains the bu
Markus Armbruster wrote:
> Jan Kiszka writes:
>
>> Luiz Capitulino wrote:
>>> On Sun, 23 May 2010 12:59:19 +0200
>>> Jan Kiszka wrote:
>>>
From: Jan Kiszka
Allow to specify the device to be removed via device_del not only by ID
but also by its full or abbreviated qtree path.
Signed-off-by: Markus Armbruster
---
hw/usb-serial.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/usb-serial.c b/hw/usb-serial.c
index 5b2483a..c19580f 100644
--- a/hw/usb-serial.c
+++ b/hw/usb-serial.c
@@ -545,6 +545,11 @@ static int usb_serial_initfn(USBDevic
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi
Hi,
We were looking at the dmidecode output from qemu-kvm pre-seabios and
current qemu-kvm and noticed some of the strings have changed.
The main problem with this is that certain OSes are quite sensitive to
system changes and avoiding to change things unnecessarily would
probably be a good thing
Reviewed-by: Stefan Hajnoczi
I haven't figured out this function yet so I can't review this one sorry.
Stefan
On Fri, May 28, 2010 at 05:24:47PM +0200, Jes Sorensen wrote:
> I guess the Socket Designation in particular might have been done for a
> reason?
>
It was part of commit cf2affa6de. And was a result of moving to
snprintf() instead of direct string manipulation. Before that
string was created like
Am 27.05.2010 21:11, schrieb Christian Brunner:
> This is a block driver for the distributed file system Ceph
> (http://ceph.newdream.net/). This driver uses librados (which
> is part of the Ceph server) for direct access to the Ceph object
> store and is running entirely in userspace. Therefore
If the L2 table was already updated in cache, but writing it to disk has
failed, we must not continue using the changed version in the cache to stay
consistent with what's on the disk.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Hi Anthony,
this includes again some patches that should be applied to stable-0.12, too:
86fa8da qcow2: Fix corruption after error in update_refcount
25408c0 qcow2: Fix corruption after refblock allocation
cbf1dff block: Fix multiwrite with overlapping requests
175e115 qcow2: Fix
From: Gerd Hoffmann
When creating guest disks the qdev way using ...
-drive if=none,id=$name,args
-device $driver,drive=$name
it is not possible to specify rerror, werror and readonly arguments
for drive as drive_init allows/blocks them based on the interface (if=)
specified and none isn't
qcow2_get_cluster_offset() looks up a given virtual disk offset and returns the
offset of the corresponding cluster in the image file. Errors (e.g. L2 table
can't be read) are currenctly indicated by a return value of 0, which is
unfortuately the same as for any unallocated cluster. So in effect we
l2_allocate has some intermediate states in which the image is inconsistent.
Change the order to write to the L1 table only after the new L2 table has
successfully been initialized.
Also reset the L2 cache in failure case, it's very likely wrong.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluste
From: MORITA Kazutaka
This patch enables protocol drivers to use their create options which
are not supported by the format. For example, protcol drivers can use
a backing_file option with raw format.
Signed-off-by: MORITA Kazutaka
Signed-off-by: Kevin Wolf
---
block.c |7 +++
Provide the error code to the caller instead of just indicating success/error.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 38 ++
1 files changed, 22 insertions(+), 16 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index e
From: Nicholas A. Bellinger
This patch adds a missing bdrv_delete() call in find_image_format() so that a
SG_IO BlockDriver properly releases the temporary BlockDriverState *bs created
from bdrv_file_open()
Signed-off-by: Nicholas A. Bellinger
Reported-by: Chris Krumme
Signed-off-by: Kevin Wol
With overlapping requests, the total number of sectors is smaller than the sum
of the nb_sectors of both requests.
Signed-off-by: Kevin Wolf
---
block.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index cd70730..47be5ba 100644
--- a/block.c
+++ b/b
From: Jes Sorensen
C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit
safe as it and BDRV_SECTOR_MASK may be used against 64 bit addresses.
Signed-off-by: Jes Sorensen
Signed-off-by: Kevin Wolf
---
block.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
Refblock allocation code needs to take into consideration that update_refcount
will load a different refcount block into the cache, so it must initialize the
cache for a new refcount block only afterwards. Not doing this means that not
only the refcount in the wrong block is updated, but also that
The new multiwrite commands allows to use qemu-io for testing
bdrv_aio_multiwrite.
Signed-off-by: Kevin Wolf
---
qemu-io.c | 192 +
1 files changed, 192 insertions(+), 0 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index f39109e..7
After it is done with updating refcounts in the cache, update_refcount writes
all changed entries to disk. If a refcount block allocation fails, however,
there was no change yet and therefore first_index = last_index = -1. Don't
treat -1 as a normal sector index (resulting in a 512 byte write!) but
Am 27.05.2010 um 22:45 schrieb Richard Henderson:
From: Alexander Graf
---
tcg/s390/tcg-target.c |3 ++
tcg/s390/tcg-target.h | 86
+++--
2 files changed, 86 insertions(+), 3 deletions(-)
This one's missing an SoB, and fwiw I think it should
From: Stefan Hajnoczi
This patch expands tabs on a few lines so the code formats nicely and
follows the QEMU coding style.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
posix-aio-compat.c | 58 ++--
1 files changed, 29 insertion
On 05/28/2010 11:51 AM, Kevin Wolf wrote:
Am 28.05.2010 18:48, schrieb Anthony Liguori:
On 05/28/2010 11:45 AM, Kevin Wolf wrote:
Hi Anthony,
this includes again some patches that should be applied to stable-0.12, too:
86fa8da qcow2: Fix corruption after error in update_refcou
write_refcount_block_entries used to return -EIO for any errors. Change this to
return the real error code.
Signed-off-by: Kevin Wolf
---
block/qcow2-refcount.c | 27 +++
1 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qco
On 05/28/2010 09:49 AM, Andreas Färber wrote:
> Am 27.05.2010 um 22:45 schrieb Richard Henderson:
>
>> From: Alexander Graf
>>
>> ---
>> tcg/s390/tcg-target.c |3 ++
>> tcg/s390/tcg-target.h | 86
>> +++--
>> 2 files changed, 86 insertions(+), 3 del
On 05/28/2010 11:45 AM, Kevin Wolf wrote:
Hi Anthony,
this includes again some patches that should be applied to stable-0.12, too:
86fa8da qcow2: Fix corruption after error in update_refcount
25408c0 qcow2: Fix corruption after refblock allocation
cbf1dff block: Fix multiwrite wi
Am 28.05.2010 18:48, schrieb Anthony Liguori:
> On 05/28/2010 11:45 AM, Kevin Wolf wrote:
>> Hi Anthony,
>>
>> this includes again some patches that should be applied to stable-0.12, too:
>>
>> 86fa8da qcow2: Fix corruption after error in update_refcount
>> 25408c0 qcow2: Fix corruption a
The following changes since commit 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb:
Jes Sorensen (1):
vhost_net.c: v2 Fix build failure introduced by
0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2
The patches almostly base on http://meego.gitorious.org/qemu-maemo/qemu work
and
act as pr
Signed-off-by: cmchao
---
hw/omap.h |3 +
hw/omap2.c | 523
hw/omap_gpio.c | 523
3 files changed, 526 insertions(+), 523 deletions(-)
diff --git a/hw/omap.h b/hw/oma
1 - 100 of 178 matches
Mail list logo
