[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-03 Thread Jan Kiszka
Glauber Costa wrote: On Wed, Jun 02, 2010 at 09:15:10AM +0200, Jan Kiszka wrote: +QemuOptsList qemu_machine_opts = { +.name = M, +.head = QTAILQ_HEAD_INITIALIZER(qemu_machine_opts.head), +.desc = { +{ +.name = mach, +.type = QEMU_OPT_STRING,

Re: [Qemu-devel] [PATCH v3 02/17] qdev: Fix scanning across single-bus devices

2010-06-03 Thread Jan Kiszka
Paul Brook wrote: From: Jan Kiszka jan.kis...@siemens.com As long as we allow /dev.1 as shortcut for /dev1/bus1, we also have to make sure that /dev1/dev2 works for /dev1/bus1/dev2/bus2 - as long as there is only one child bus per device. How about we make this explicit in the syntax by

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-03 Thread Jan Kiszka
Blue Swirl wrote: But how about if we introduced instead a message based IRQ? Then the message could specify the originator device, maybe ACK/coalesce/NACK callbacks and a bigger payload than just 1 bit of level. I think that could achieve the same coalescing effect as what the bidirectional

Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-03 Thread Jan Kiszka
Anthony Liguori wrote: On 06/01/2010 01:35 PM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: On Tue, 01 Jun 2010 16:44:24 +0200 Markus Armbrusterarm...@redhat.com wrote: Luiz Capitulinolcapitul...@redhat.com writes: On Mon, 31 May 2010

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-03 Thread Gleb Natapov
On Thu, Jun 03, 2010 at 08:23:46AM +0200, Jan Kiszka wrote: Blue Swirl wrote: But how about if we introduced instead a message based IRQ? Then the message could specify the originator device, maybe ACK/coalesce/NACK callbacks and a bigger payload than just 1 bit of level. I think that

Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-03 Thread Paul Brook
Also require IDs to start with a letter to provide for possible future extensions. I'd go further than that, and require that user specified IDs match [A-Za-z][A-Za-z0-9_-]* Paul

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-03 Thread Jan Kiszka
Gleb Natapov wrote: On Thu, Jun 03, 2010 at 08:23:46AM +0200, Jan Kiszka wrote: Blue Swirl wrote: But how about if we introduced instead a message based IRQ? Then the message could specify the originator device, maybe ACK/coalesce/NACK callbacks and a bigger payload than just 1 bit of level.

Re: [Qemu-devel] [PATCH] block: Fix serial number assignment

2010-06-03 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: We should use 'dinfo-serial' length, 'serial' is a pointer, so the serial number length is currently limited to the pointer size. This fixes https://bugs.launchpad.net/qemu/+bug/584143 and is also valid for stable. Signed-off-by: Luiz

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-03 Thread Gleb Natapov
On Thu, Jun 03, 2010 at 08:59:23AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Thu, Jun 03, 2010 at 08:23:46AM +0200, Jan Kiszka wrote: Blue Swirl wrote: But how about if we introduced instead a message based IRQ? Then the message could specify the originator device, maybe

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-03 Thread Gleb Natapov
On Thu, Jun 03, 2010 at 10:03:00AM +0300, Gleb Natapov wrote: On Thu, Jun 03, 2010 at 08:59:23AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Thu, Jun 03, 2010 at 08:23:46AM +0200, Jan Kiszka wrote: Blue Swirl wrote: But how about if we introduced instead a message based IRQ? Then

Re: [Qemu-devel] [PATCH] qbus: fix memory leak in qbus_free()

2010-06-03 Thread Markus Armbruster
Isaku Yamahata yamah...@valinux.co.jp writes: On Wed, Jun 02, 2010 at 05:01:13PM +0200, Markus Armbruster wrote: Isaku Yamahata yamah...@valinux.co.jp writes: BusState::name is allocated in qbus_create_inplace(). So it should be freed by qbus_free(). Correct. Signed-off-by: Isaku

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open

2010-06-03 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 02 Jun 2010 20:26:58 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: From: Michael Tokarev m...@tls.msk.ru In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints

[Qemu-devel] [PATCH 0/4] Asynchronous tcp incoming migration.

2010-06-03 Thread Yoshiaki Tamura
Hi, This series add asynchronous tcp incoming migration. Currently, tcp migration on incoming side is blocked when outgoing has started on the remote side, and you can't do anything. With this series you can get info of incoming migration by calling info migrate like on outgoing side. This

[Qemu-devel] [PATCH 1/4] savevm: refactor qemu_loadvm_state().

2010-06-03 Thread Yoshiaki Tamura
Split qemu_loadvm_state(), and introduce qemu_loadvm_state_{begin,iterate,complete,async}. qemu_loadvm_state_async() is a function to handle a single incoming section. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- savevm.c | 206

[Qemu-devel] [PATCH 4/4] migration: add support to print migration info on incoming side.

2010-06-03 Thread Yoshiaki Tamura
Set current_migration after calling tcp_star_incoming_migration(). On incoming side, we don't have to print remaining rams, so introduce incoming flag to switch messages. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c | 18 ++ 1 files changed, 14

[Qemu-devel] [PATCH 3/4] arch_init: calculate transferred bytes at ram_load().

2010-06-03 Thread Yoshiaki Tamura
Currently incoming side of migration doesn't know how many bytes are transferred. To print info migrate on incoming side, we need to calculate transferred bytes at ram_load(). Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- arch_init.c |6 +- 1 files changed, 5

[Qemu-devel] [PATCH 2/4] migration-tcp: add support for asynchronous incoming migration.

2010-06-03 Thread Yoshiaki Tamura
Introduce tcp_incoming_migration_async(), and register it handle incoming migration asynchronously. MigrateInocming is used to pass argument to tcp_incoming_migration_async(). tcp_start_incoming_migration() allocates FdMigrationState, and returns MigrationState to print incoming migration info.

[Qemu-devel] Re: [PATCH 2/3] qemu-thread: add cleanup_push() and cleanup_pop()

2010-06-03 Thread Paolo Bonzini
On 05/29/2010 09:38 AM, Corentin Chary wrote: Signed-off-by: Corentin Charycorenti...@iksaif.net --- qemu-thread.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qemu-thread.h b/qemu-thread.h index 19bb30c..e5006bb 100644 --- a/qemu-thread.h +++ b/qemu-thread.h @@

Re: [Qemu-devel] [PATCH 3/9] QMP: First half of the new argument checking code

2010-06-03 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 02 Jun 2010 08:59:11 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: [...] + +type = qobject_to_qstring(obj); +assert(type != NULL); + +if (qstring_get_str(type)[0]

Re: [Qemu-devel] Re: [PATCH 2/3] qemu-thread: add cleanup_push() and cleanup_pop()

2010-06-03 Thread Corentin Chary
On Thu, Jun 3, 2010 at 9:27 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 05/29/2010 09:38 AM, Corentin Chary wrote: Signed-off-by: Corentin Charycorenti...@iksaif.net ---  qemu-thread.h |    4  1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qemu-thread.h

Re: [Qemu-devel] Arm big endian?

2010-06-03 Thread Paul Brook
I'm trying to get arm big endian support to work. I patched the 2.6.33 kernel to pretend that good old versatilepb can have a big endian CPU plugged into it (attached), and then I built a kernel with the attached .config, and qemu went boing: That's about the result I'd expect. The fact that

[Qemu-devel] Re: [PATCH 3/3] vnc: threaded VNC server

2010-06-03 Thread Paolo Bonzini
On 05/29/2010 09:38 AM, Corentin Chary wrote: Implement a threaded VNC server using the producer-consumer model. The main thread will push encoding jobs (a list a rectangles to update) in a queue, and the VNC worker thread will consume that queue and send framebuffer updates to the output

Re: [Qemu-devel] [PATCH 13/13] blockdev: New -blockdev to define a host block device

2010-06-03 Thread Christoph Hellwig
On Wed, Jun 02, 2010 at 06:55:29PM +0200, Markus Armbruster wrote: Existing -drive defines both host and guest part. To make it work with -device, we created if=none. But all this does is peel off guest device selection. The other guest properties such as geometry, removable vs. fixed

Re: [Qemu-devel] Re: [PATCH 3/3] vnc: threaded VNC server

2010-06-03 Thread Corentin Chary
On Thu, Jun 3, 2010 at 9:55 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 05/29/2010 09:38 AM, Corentin Chary wrote: Implement a threaded VNC server using the producer-consumer model. The main thread will push encoding jobs (a list a rectangles to update) in a queue, and the VNC worker

Re: [Qemu-devel] [PATCH 0/4] Add virtio disk identification support

2010-06-03 Thread john cooper
john cooper wrote: I'm all for putting this issue to rest, but if we're going to live with an ioctl interface retrieving the id string, let's make it a little more friendly from the user's perspective. The qemu side of the patch is ok as-is. The guest-user interface issue is contained in the

[Qemu-devel] [Bug 585113] Re: e1000 irq problems after live migration with qemu-kvm 0.12.4

2010-06-03 Thread Michael Tokarev
Please note that this bug affects 0.12 stable as well. It'd be really nice to know the commit which fixed the issue, in order to backport it to -stable... -- e1000 irq problems after live migration with qemu-kvm 0.12.4 https://bugs.launchpad.net/bugs/585113 You received this bug notification

Re: [Qemu-devel] [PATCH v2 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-06-03 Thread Isaku Yamahata
Maybe it is time to enhance pci_host.c to take a callback to decode the address, so that you can use pci_host helper functions. It would simplify this patch and eliminates code duplication. Some comments below. On Wed, May 19, 2010 at 10:26:32PM +0800, Huacai Chen wrote: Signed-off-by: Huacai

[Qemu-devel] [PATCH v3 0/7] MIPS: Initial support for fulong (Loongson-2E based) mini pc

2010-06-03 Thread chen huacai
Changes from v2: 1, split the code of CPU definition and machine construction 2, remove useless memory r/w functions 3, add source of pmon 4, code style and other errors have been fixed Changes from v1: 1, fulong support is limited to mips64el only (doesn't affect mips, mips64 and mipsel) 2, qdev

[Qemu-devel] [PATCH V3 0/3] qemu: Make AIO threading framework generic.

2010-06-03 Thread Gautham R Shenoy
Hi, This is the v3 of the patch-series to have a generic asynchronous task offloading framework within qemu. V2 can be found here: http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02227.html Changes from V2: = - Made use

[Qemu-devel] [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t

2010-06-03 Thread Gautham R Shenoy
Add qemu wrappers for pthread_attr_t handling. Signed-off-by: Gautham R Shenoy e...@in.ibm.com --- qemu-thread.c | 34 ++ qemu-thread.h | 11 +++ 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/qemu-thread.c b/qemu-thread.c index

[Qemu-devel] [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks

2010-06-03 Thread Gautham R Shenoy
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch creates a generic asynchronous-task-offloading infrastructure. It's extracted out of the threading framework that is being used by paio. The reason for extracting out this generic infrastructure of the posix-aio-compat.c is so

[Qemu-devel] [PATCH V3 3/3] qemu: Convert AIO code to use the generic threading infrastructure.

2010-06-03 Thread Gautham R Shenoy
This patch makes the paio subsystem use the generic work offloading infrastructure, there by decoupling asynchronous threading framework portion out of posix-aio-compat.c The patch has been tested with fstress. Signed-off-by: Gautham R Shenoy e...@in.ibm.com --- posix-aio-compat.c | 155

Re: [Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-03 Thread Paul Brook
the irqchip option, if you note, is not x86-specific, in any case. Any machine has an irqchip. The first idea was to use something like apic=in_kernel|userspace which would be, that, very x86-centric. How is this not x86-pc specific? All you're doing is creating two different machines, one

Re: [Qemu-devel] [PATCH v2 2/6] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-06-03 Thread Isaku Yamahata
Some comments below. NOTE: I just checked pci related code and I'm not familiar with those chips. On Wed, May 19, 2010 at 10:27:23PM +0800, Huacai Chen wrote: Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target |2 +- hw/pc.h |7 + hw/pci_ids.h|

Re: [Qemu-devel] [PATCH 0/2] tcg cleanups, part 4

2010-06-03 Thread malc
On Wed, 2 Jun 2010, Richard Henderson wrote: The tcg_out_mov patch you've seen before, but now contains a TCG_TYPE_REG that should address the concerns you had with the changes to the sparc port. It's also been updated to HEAD to reflect the changes in tcg/i386. The second patch is new.

Re: [Qemu-devel] [PATCH] Name the default PCI bus pci.0 on all architectures

2010-06-03 Thread Andreas Färber
Am 02.06.2010 um 16:12 schrieb Daniel P. Berrange: On Fri, May 28, 2010 at 08:39:53PM +0100, Paul Brook wrote: The system emulators for each arch are using inconsistent naming for the default PCI bus pci vs pci.0. Since it is conceivable we'll have multiple PCI buses in the future standardize

Re: [Qemu-devel] Re: [PATCH 3/3] vnc: threaded VNC server

2010-06-03 Thread Paolo Bonzini
+void vnc_job_push(VncJob *job) +{ +    vnc_lock_queue(queue); +    if (QLIST_EMPTY(job-rectangles)) { +        qemu_free(job); No need to lock if you get into the then block. I locked it because the main thread can try to push a job while a consumer is removing one, so I can't

[Qemu-devel] Re: [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks

2010-06-03 Thread Corentin Chary
On Thu, Jun 3, 2010 at 10:56 AM, Gautham R Shenoy e...@in.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch creates a generic asynchronous-task-offloading infrastructure. It's extracted out of the threading framework that is being used by paio. The reason for

[Qemu-devel] Re: [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t

2010-06-03 Thread Paolo Bonzini
On 06/03/2010 10:56 AM, Gautham R Shenoy wrote: Add qemu wrappers for pthread_attr_t handling. The point of these wrappers AFAIU is not only to add error_exit, but also to be portable to Windows in the future. Is it necessary to create the threads as detached? If you set queue-min_threads

[Qemu-devel] Re: [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks

2010-06-03 Thread Paolo Bonzini
On 06/03/2010 01:41 PM, Corentin Chary wrote: +if (sigprocmask(SIG_SETMASK,set,oldset)) { +async_abort(errno, sigprocmask); +} + +qemu_thread_create_attr(thread,attr, async_worker_thread, queue); + +if (sigprocmask(SIG_SETMASK,oldset, NULL)) { +

[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-03 Thread Anthony Liguori
On 06/03/2010 01:07 AM, Jan Kiszka wrote: Glauber Costa wrote: On Wed, Jun 02, 2010 at 09:15:10AM +0200, Jan Kiszka wrote: +QemuOptsList qemu_machine_opts = { +.name = M, +.head = QTAILQ_HEAD_INITIALIZER(qemu_machine_opts.head), +.desc = { +{ +.name =

[Qemu-devel] Re: [PATCH v2 1/2] early set current_machine

2010-06-03 Thread Anthony Liguori
On 06/01/2010 12:56 PM, Glauber Costa wrote: this way, the machine_init function itself can know which machine is current in use, not only the late init code. While your touching it... We only use current_machine in hw/device-hotplug.c. I think it would be better to introduce an

[Qemu-devel] [PATCH] make qemu_thread_create block all signals

2010-06-03 Thread Paolo Bonzini
All signals will thus be routed through the IO thread. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c| 38 +++--- qemu-thread.c |7 +++ 2 files changed, 18 insertions(+), 27 deletions(-) diff --git a/cpus.c b/cpus.c index

[Qemu-devel] [Bug 581737] Re: Can't read e1000 NIC EEPROM on NetBSD guest

2010-06-03 Thread Izumi Tsutsui
** Patch added: patch by git format-patch --signoff http://launchpadlibrarian.net/49607393/qemu-git.patch -- Can't read e1000 NIC EEPROM on NetBSD guest https://bugs.launchpad.net/bugs/581737 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] Re: Unposted reserved_va patch

2010-06-03 Thread Richard Henderson
On 06/02/2010 09:54 PM, Paul Brook wrote: Hmm, maybe. My reasoning was that this is consistent with the current behavior of the ELF loader. If you specify -G then the target application will be splatted at that address, regardless of whether it's already used by the host. Well, sort-of.

[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-03 Thread Anthony Liguori
On 06/01/2010 12:56 PM, Glauber Costa wrote: This patch adds initial support for the -machine option, that allows command line specification of machine attributes (always relying on safe defaults). Besides its value per-se, it is the saner way we found to allow for enabling/disabling of kvm's

[Qemu-devel] [PATCH 1/2] Make v9fs_do_utimensat accept timespec structures instead of v9stat.

2010-06-03 Thread Sripathi Kodi
One of Mohan's recent patches (Message-Id: 1275286613-16757-1-git-send-email-mo...@in.ibm.com) implements v9fs_do_utimensat function. Currently v9fs_do_utimensat takes a V9fsStat argument and builds timespec structures. It sets tv_nsec values to 0 by default. Instead of this it should take struct

[Qemu-devel] [PATCH 2/2] virtio-9p: Implement server side of setattr for 9P2000.L protocol.

2010-06-03 Thread Sripathi Kodi
SYNOPSIS size[4] Tsetattr tag[2] attr[n] size[4] Rsetattr tag[2] DESCRIPTION The setattr command changes some of the file status information. attr resembles the iattr structure used in Linux kernel. It specifies which status parameter is to be changed and to

[Qemu-devel] Re: [RFC PATCH v4 0/3] Sheepdog: distributed storage system for QEMU

2010-06-03 Thread MORITA Kazutaka
At Wed, 02 Jun 2010 12:49:02 +0200, Kevin Wolf wrote: Am 28.05.2010 04:44, schrieb MORITA Kazutaka: Hi all, This patch adds a block driver for Sheepdog distributed storage system. Please consider for inclusion. Hint for next time: You should remove the RFC from the subject line if

[Qemu-devel] Re: [RFC PATCH v4 3/3] block: add sheepdog driver for distributed storage support

2010-06-03 Thread MORITA Kazutaka
At Tue, 01 Jun 2010 09:58:04 -0500, Thanks for your comments! Chris Krumme wrote: On 05/27/2010 09:44 PM, MORITA Kazutaka wrote: Sheepdog is a distributed storage system for QEMU. It provides highly + +static int connect_to_sdog(const char *addr) +{ + char buf[64]; + char

[Qemu-devel] [Bug 513273] Re: kvm with -vga std is broken since karmic

2010-06-03 Thread Michael Tokarev
um. Can't you just take approach used in Debian, namely, to provide the sources for the bios files and compile them at build time? That is somewhat ugly, but at least it works... -- kvm with -vga std is broken since karmic https://bugs.launchpad.net/bugs/513273 You received this bug

[Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension

2010-06-03 Thread Paolo Bonzini
On 06/03/2010 05:25 PM, Alexander Graf wrote: Am 03.06.2010 um 15:18 schrieb Paolo Bonzini pbonz...@redhat.com: On 06/01/2010 10:12 PM, Igor V. Kovalenko wrote: From: Igor V. Kovalenkoigor.v.kovale...@gmail.com - change return type of ldl_* to uint32_t to prevent unwanted sign extension

[Qemu-devel] [PATCH] In v9fs_remove_post_remove() we currently ignore the error returned by

2010-06-03 Thread Sripathi Kodi
the previous call to remove() and return an error only if freeing the fid fails. However, the client expects to see the error from remove(). Currently the client falsely thinks that the remove call has always succeeded. For example, doing rmdir on a non-empty directory does not return ENOTEMPTY.

[Qemu-devel] [Bug 589231] [NEW] cirrus vga is very slow in qemu-kvm-0.12

2010-06-03 Thread Michael Tokarev
Public bug reported: As has been reported multiple times (*), there were a regression in qemu-kvm from 0.11 to 0.12, which causes significant slowdown in cirrus vga emulation. For windows guests, where standard VGA driver works reasonable well, -vga std is a good workaround. But for e.g. linux

[Qemu-devel] [Bug 588735] Re: Quit command not working

2010-06-03 Thread Jan Smets
The host now has 8GB of memory, problem remains. Try ./configure --target-list=x86_64-softmmu --enable-profiler --enable- gprof --enable-io-thread --enable-debug-tcg --enable-debug Without these options it magically works :) -- Quit command not working

[Qemu-devel] [Bug 319014] Re: serial usb-device can't be passed-through to a guest

2010-06-03 Thread Nico Prenzel
Hello Anthony, which qemu-kvm version do you expect to work with serial usb devices? After you've changed this ticket status and I've checked it again with qemu-kvm version 0.12.4. The reported error message is gone away and the device is present in the guest. The cdc_acm driver loads too

[Qemu-devel] Re: [RFC PATCH v4 3/3] block: add sheepdog driver for distributed storage support

2010-06-03 Thread MORITA Kazutaka
At Wed, 02 Jun 2010 15:55:42 +0200, Kevin Wolf wrote: Am 28.05.2010 04:44, schrieb MORITA Kazutaka: Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog.

[Qemu-devel] [PATCH 01/16] vl.c: Remove double include of netinet/in.h for Solaris

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com vl.c: netinet/in.h is already included once above for the generic non win32 code. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 417554f..7c4298a

[Qemu-devel] [PATCH 03/16] Introduce os-win32.c and move polling functions from vl.c

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces os-win32.c. It is meant to carry win32 specific functions thata are not relevant for all of QEMU as well as win32 versions of various pieces like signal handling etc. Move win32 polling handler helper functions from vl.c to os-win32.c

[Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, I have been working on a set of patches to clean up the vl.c code, by separating out OS specific code into OS specific files. Basically it introduces two header files: qemu-os-win32.h and qemu-os-posix.h as well as os-win32.c and os-posix.c. I have

[Qemu-devel] [PATCH 16/16] Move set_proc_name() to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move handling to change process name to POSIX specific files plus add a better error message to cover the case where the feature isn't supported. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 24

[Qemu-devel] [PATCH 02/16] Create qemu-os-win32.h and move WIN32 specific declarations there

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Create qemu-os-win32.h for WIN32 specific declarations. Move polling handling declaration into this file from sysemu.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-os-win32.h | 43 +++ sysemu.h

[Qemu-devel] [PATCH 05/16] Introduce os-posix.c and create os_setup_signal_handling()

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introcuce os-posix.c and move posix specific signal handling there. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.objs |1 + os-posix.c| 41 + sysemu.h |3 +++ vl.c

[Qemu-devel] [PATCH 04/16] vl.c: Move host_main_loop_wait() to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move host_main_loop_wait() to OS specific files. Create qemu-os-posix.h and provide empty inline for the POSIX case. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 43 +++

[Qemu-devel] [PATCH 06/16] Move win32 early signal handling setup to os_setup_signal_handling()

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move win32 early signal handling setup to os_setup_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 29 + vl.c | 30 -- 2 files changed, 29

[Qemu-devel] [PATCH 07/16] Rename os_setup_signal_handling() to os_setup_early_signal_handling()

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename os_setup_signal_handling() to os_setup_early_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |2 +- os-win32.c |2 +- sysemu.h |2 +- vl.c |2 +- 4 files changed, 4 insertions(+), 4

[Qemu-devel] [PATCH 09/16] Move find_datadir to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This moves the win32 and POSIX versions of find_datadir() to OS specific files, and removes some #ifdef clutter from vl.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 64 +++ os-win32.c |

[Qemu-devel] [PATCH 14/16] Make os_change_process_uid and os_change_root os-posix.c local

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com os_change_process_uid() and os_change_root() are now only called from os-posix.c, so no need to keep win32 stubs for them. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |8 qemu-os-posix.h |2 --

[Qemu-devel] [PATCH 11/16] Move runas handling from vl.c to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move code to handle runas, ie. change of user id of QEMU process to OS specific files and provide dummy stub for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 28 qemu-os-posix.h |1

[Qemu-devel] [PATCH 12/16] Move chroot handling to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 19 +++ qemu-os-posix.h |1 + qemu-os-win32.h |1 + vl.c| 18 +- 4 files

[Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introduce OS specific cmdline argument handling by calling os_parse_cmd_args() at the end of switch() statement. In addition move SMB argument to os-posix.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 34

[Qemu-devel] [PATCH 13/16] Move daemonize handling to OS specific files

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 102 os-win32.c |5 +++

[Qemu-devel] [PATCH 15/16] Move line-buffering setup to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move line-buffering setup to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |5 + qemu-os-posix.h |1 + qemu-os-win32.h |2 ++ vl.c|5 + 4 files changed, 9 insertions(+), 4

[Qemu-devel] [Bug 581737] Re: Can't read e1000 NIC EEPROM on NetBSD guest

2010-06-03 Thread Ryan Harper
Please email the patch to qemu-devel@nongnu.org via git-send-email. This will ensure the maintainers see the patch and the community has a chance to review the patch. -- Can't read e1000 NIC EEPROM on NetBSD guest https://bugs.launchpad.net/bugs/581737 You received this bug notification because

Re: [Qemu-devel] [Bug 319014] Re: serial usb-device can't be passed-through to a guest

2010-06-03 Thread David S. Ahern
On 06/03/10 09:41, Nico Prenzel wrote: Hello Anthony, which qemu-kvm version do you expect to work with serial usb devices? After you've changed this ticket status and I've checked it again with qemu-kvm version 0.12.4. The reported error message is gone away and the device is present

[Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect

2010-06-03 Thread Cole Robinson
Public bug reported: Tested with upstream qemu as of Jun 3 2010 If the source qemu instance can't connect to the migration destination (say there is no listening QEMU instance, or port is blocked by a firewall), all we get is info migrate - Migration status: failed. This is all we have to report

[Qemu-devel] Re: [PATCH 1/4] Add virtio disk identification support

2010-06-03 Thread Anthony Liguori
On 03/25/2010 12:32 AM, john cooper wrote: Add virtio-blk device id (s/n) support via virtio request. Remove artifacts of pci and ATA_IDENTIFY implementation relative to prior versions. Signed-off-by: john cooperjohn.coo...@redhat.com --- diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index

[Qemu-devel] Re: [PATCH 2/4] Add virtio disk identification support

2010-06-03 Thread Anthony Liguori
On 03/25/2010 12:33 AM, john cooper wrote: Fix bug which truncated serial string to 8 bytes, nul terminate. Signed-off-by: john cooperjohn.coo...@redhat.com --- diff --git a/vl.c b/vl.c index d69250c..b74cbba 100644 --- a/vl.c +++ b/vl.c @@ -1162,7 +1162,7 @@ DriveInfo *drive_init(QemuOpts

[Qemu-devel] [PATCH 0/3] Add virtio-blk support to persistent-storage rules

2010-06-03 Thread Ryan Harper
This patch series provides updates to udev to allow the creation symlinks for virtio-blk devices, specifically disk/by-id and disk/by-path. This is most useful for virtio-blk devices that do not yet have any filesystem for which a UUID can be extracted (disk/by-uuid). These patches (save the

[Qemu-devel] [Bug 267542] Re: MINIX 3 won't boot in qemu 0.9.1

2010-06-03 Thread Sylvain Nahas
Hi, I have retried with qemu 0.12.3 on the same binaries, and it works fine. For me, this report can be closed. Thanks, Sylvain ** Changed in: qemu Status: Incomplete = Fix Released -- MINIX 3 won't boot in qemu 0.9.1 https://bugs.launchpad.net/bugs/267542 You received this bug

[Qemu-devel] [Bug 267542] Re: MINIX 3 won't boot in qemu 0.9.1

2010-06-03 Thread Sylvain Nahas
Hi, I have switched the status to Fix Released. Was it the right thing to do? Sylvain -- MINIX 3 won't boot in qemu 0.9.1 https://bugs.launchpad.net/bugs/267542 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Fix

[Qemu-devel] [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-03 Thread Miguel Di Ciurcio Filho
Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. First issue: Their names implies different porpouses, but they do the same thing and have exactly the same code. Maybe copied and pasted and forgotten? bdrv_has_snapshot() is called in various places for actually

[Qemu-devel] [PATCH] Extra scan codes for missing keys (v2)

2010-06-03 Thread Brendan Sleight
aliguori bmsleight, please post to the top-level aliguori and add a (v2) otherwise, it's easy for me to get confused that i've already looked at a patch Thanks Hi All, First - Qemu is fantastic and allows lots of wonderful things. Second, when using qemu-system-ppc, I wanted to use sendkey

[Qemu-devel] [PATCH 1/2] tcg: get rid of copy_size in TCGOpDef

2010-06-03 Thread y
From: Aurelien Jarno aurel...@aurel32.net copy_size is a left-over from the dyngen era, remove it. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- exec-all.h |1 - exec.c |2 +- tcg/tcg-opc.h |2 +- tcg/tcg.c |2 +- tcg/tcg.h |3 +--

[Qemu-devel] [PATCH 2/2] tcg: get rid of DEF2 in tcg-opc.h

2010-06-03 Thread y
From: Aurelien Jarno aurel...@aurel32.net Now that tcg-opc.h is only used in TCG code, get rid of DEF2 in tcg-opc.h. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/tcg-opc.h | 293 + tcg/tcg.c |4 +- tcg/tcg.h |

[Qemu-devel] [PATCH 1/2] tcg: get rid of copy_size in TCGOpDef

2010-06-03 Thread Aurelien Jarno
copy_size is a left-over from the dyngen era, remove it. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- exec-all.h |1 - exec.c |2 +- tcg/tcg-opc.h |2 +- tcg/tcg.c |2 +- tcg/tcg.h |3 +-- translate-all.c | 16 6 files

[Qemu-devel] [PATCH 2/2] tcg: get rid of DEF2 in tcg-opc.h

2010-06-03 Thread Aurelien Jarno
Now that tcg-opc.h is only used in TCG code, get rid of DEF2 in tcg-opc.h. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/tcg-opc.h | 293 + tcg/tcg.c |4 +- tcg/tcg.h |2 +- 3 files changed, 149 insertions(+),

Re: [Qemu-devel] [PATCH 05/16] Introduce os-posix.c and create os_setup_signal_handling()

2010-06-03 Thread Richard Henderson
On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: --- a/sysemu.h +++ b/sysemu.h @@ -79,6 +79,9 @@ int qemu_loadvm_state(QEMUFile *f); /* SLIRP */ void do_info_slirp(Monitor *mon); +/* OS specific functions */ +void os_setup_signal_handling(void); + Can this go in your

Re: [Qemu-devel] [PATCH 12/16] Move chroot handling to OS specific files.

2010-06-03 Thread Richard Henderson
On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: +static inline void os_change_root(void) {}; You really like the ;, don't you. ;-) r~

Re: [Qemu-devel] [PATCH 11/16] Move runas handling from vl.c to OS specific files.

2010-06-03 Thread Richard Henderson
On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: +static inline void os_change_process_uid(void) {}; Stray ; r~

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-03 Thread Richard Henderson
On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: +/* + * Duplicate definition from vl.c to avoid messing up the entire build + */ +enum { +#define DEF(option, opt_arg, opt_enum, opt_help, arch_mask) \ +opt_enum, +#define DEFHEADING(text) +#include qemu-options.h +#undef DEF

Re: [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect

2010-06-03 Thread Yoshiaki Tamura
2010/6/4 Cole Robinson crobi...@redhat.com: Public bug reported: Tested with upstream qemu as of Jun 3 2010 If the source qemu instance can't connect to the migration destination (say there is no listening QEMU instance, or port is blocked by a firewall), all we get is info migrate -

Re: [Qemu-devel] [PATCH -V4 1/7] virtio-9p: Introduces an option to specify the security model.

2010-06-03 Thread Venkateswararao Jujjuri (JV)
Aneesh Kumar K.V wrote: On Wed, May 26, 2010 at 04:21:40PM -0700, Venkateswararao Jujjuri (JV) wrote: The new option is: -fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough] -virtfs fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag In the case

[Qemu-devel] I would like to do the link exchange with you.

2010-06-03 Thread Cheapest Rooms
Title: Untitled Document Hi, My name is Mark. I recently came across your website http://nongnu.org/ through search engine and found it is informative for our website's visitors. I would like to exchange link with our websites CheapestRoomsLondon.co.uk and CheapRoomsLondon.co.uk.

Re: [Qemu-devel] Arm big endian?

2010-06-03 Thread Rob Landley
On Thursday 03 June 2010 02:52:03 Paul Brook wrote: I'm trying to get arm big endian support to work. I patched the 2.6.33 kernel to pretend that good old versatilepb can have a big endian CPU plugged into it (attached), and then I built a kernel with the attached .config, and qemu went

[Qemu-devel] [PATCH 0/2] tcg-i386: merge 64-bit, guest_base improvement

2010-06-03 Thread Richard Henderson
This patch series is dependent on the tcg cleanups, part 4 patch series. The first patch merges the 64-bit code generator with the cleaned-up 32-bit code generator. I think the result is going to be easier to maintain than the two generators separately. I've spot-checked the code for 32-bit at

[Qemu-devel] [PATCH 2/2] tcg-i386: Use segment registers to implement GUEST_BASE.

2010-06-03 Thread Richard Henderson
For 32-bit, using a segment override is smaller than the 4-byte immediate offset. For 64-bit, segments can hold the entire 64-bit offset whereas the 4-byte immediate cannot. Only implemented for linux, with fallback to the immediate offset if the system call fails. Signed-off-by: Richard

Re: [Qemu-devel] [PATCH -V4 3/7] virtio-9p: modify create/open2 and mkdir for new security model.

2010-06-03 Thread Venkateswararao Jujjuri (JV)
Aneesh Kumar K.V wrote: On Wed, May 26, 2010 at 04:21:42PM -0700, Venkateswararao Jujjuri (JV) wrote: Add required infrastructure and modify create/open2 and mkdir per the new security model. Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/file-op-9p.h | 23

[Qemu-devel] [Bug 588748] Re: QEMU fails to boot DR DOS Plus since 0.6.1

2010-06-03 Thread Roy Tam
Can you add some debugging to see what IER is being set to? With DEBUG_SERIAL defined, serial logs: serial: event 2 serial: write addr=0x01 val=0x02 serial: read addr=0x01 val=0x02 serial: read addr=0x02 val=0x02 serial: write addr=0x01 val=0x00 serial: write addr=0x03 val=0x80 serial: write

[Qemu-devel] Re: [PATCHv3 1/2] virtio: support layout with avail ring before idx

2010-06-03 Thread Rusty Russell
On Wed, 2 Jun 2010 12:17:12 am Michael S. Tsirkin wrote: This adds an (unused) option to put available ring before control (avail index, flags), and adds padding between index and flags. This avoids cache line sharing between control and ring, and also makes it possible to extend avail control

  1   2   >