[Qemu-devel] Re: [PATCHv3 1/2] virtio: support layout with avail ring before idx

2010-06-04 Thread Rusty Russell
On Fri, 4 Jun 2010 09:12:05 pm Michael S. Tsirkin wrote: > On Fri, Jun 04, 2010 at 08:46:49PM +0930, Rusty Russell wrote: > > I'm uncomfortable with moving a field. > > > > We haven't done that before and I wonder what will break with old code. > > With e.g. my patch, We only do this conditionall

[Qemu-devel] [PATCH-V5 08/10] virtio-9p: Security model for symlink and readlink

2010-06-04 Thread Venkateswararao Jujjuri (JV)
Mapped mode stores extended attributes in the user space of the extended attributes. Given that the user space extended attributes are available to regular files only, special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. This m

[Qemu-devel] [PATCH-V5 06/10] virtio-9p: Security model for create/open2

2010-06-04 Thread Venkateswararao Jujjuri (JV)
In the mapped security model, VirtFS server intercepts and maps the file object create and get/set attribute requests. Files on the fileserver will be created with VirtFS servers (QEMU) user credentials and the client-users credentials are stored in extended attributes. On the request to get attrib

[Qemu-devel] [PATCH-V5 07/10] virtio-9p: Security model for mkdir

2010-06-04 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |2 +- hw/virtio-9p-local.c | 35 +-- hw/virtio-9p.c | 12 +--- 3 files changed, 43 insertions(+), 6 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h index b345189..12

[Qemu-devel] [PATCH-V5 02/10] virtio-9p: Make infrastructure for the new security model.

2010-06-04 Thread Venkateswararao Jujjuri (JV)
This patch adds required infrastructure for the new security model. Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h | 20 +++ hw/virtio-9p-local.c | 65 +++--- hw/virtio-9p.c | 23 - 3 files chang

[Qemu-devel] [PATCH-V5 09/10] virtio-9p: Implement Security model for mknod

2010-06-04 Thread Venkateswararao Jujjuri (JV)
Mapped mode stores extended attributes in the user space of the extended attributes. Given that the user space extended attributes are available to regular files only, special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. This m

[Qemu-devel] [PATCH-V5 05/10] virtio-9p: Implemented Security model for lstat and fstat

2010-06-04 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 62 ++--- 1 files changed, 58 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 0a21591..b1d2764 100644 --- a/hw/virtio-9p-local.c +++ b/hw/v

[Qemu-devel] [PATCH-V5 10/10] virtio-9p: Implement Security model for mksock using mknod.

2010-06-04 Thread Venkateswararao Jujjuri (JV)
This patch uses mknod to create socket. On Host/Fileserver: -rw---. 1 virfsuid virtfsgid 0 2010-05-11 09:57 asocket1 On Guest/Client: srwxr-xr-x 1 guestuser guestuser 0 2010-05-11 12:57 asocket1 Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |1 - hw/virtio-9p-local.c

[Qemu-devel] [PATCH-V5 01/10] virtio-9p: Introduces an option to specify the security model.

2010-06-04 Thread Venkateswararao Jujjuri (JV)
The new option is: -fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough] -virtfs fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag In the case of mapped security model, files are created with QEMU user credentials and the client-user's credentials are

[Qemu-devel] [PATCH-V5 04/10] virtio-9p: Security model for chown

2010-06-04 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |2 +- hw/virtio-9p-local.c |9 +++-- hw/virtio-9p.c |9 +++-- 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h index 1c8d89b..a53cd35 100644 --- a/hw/file-op

[Qemu-devel] [PATCH-V5 03/10] virtio-9p: Security model for chmod

2010-06-04 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |2 +- hw/virtio-9p-local.c | 11 +++ hw/virtio-9p.c |5 - 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h index 307bd1e..1c8d89b 100644 --- a/hw/file-op-9

[Qemu-devel] [PATCH-V5 0/10] virtio-9p:Introducing security model for VirtFS

2010-06-04 Thread Venkateswararao Jujjuri (JV)
This patch series introduces the security model for VirtFS. Brief description of this patch series: It introduces two type of security models for VirtFS. They are: mapped and passthrough. The following is common to both security models. * Client's VFS determines/enforces the access control. L

[Qemu-devel] Re: [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate

2010-06-04 Thread TeLeMan
no comments? On Tue, Jun 1, 2010 at 12:26, TeLeMan wrote: > The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced > expire_time of UHCIState. But expire_time is not in vmstate, the > second uhci_frame_timer will not be fired immediately after loadvm. > > Signed-off-by: TeLeMan > --- >  

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-04 Thread Jan Kiszka
Blue Swirl wrote: > On Thu, Jun 3, 2010 at 7:06 AM, Gleb Natapov wrote: >> On Thu, Jun 03, 2010 at 10:03:00AM +0300, Gleb Natapov wrote: >>> On Thu, Jun 03, 2010 at 08:59:23AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Thu, Jun 03, 2010 at 08:23:46AM +0200, Jan Kiszka wrote: >>

[Qemu-devel] [PATCH v6] Shared memory uio_pci driver

2010-06-04 Thread Cam Macdonell
This patch adds a driver for my shared memory PCI device using the uio_pci interface. The driver has three memory regions. The first memory region is for device registers for sending interrupts. The second BAR is for receiving MSI-X interrupts and the third memory region maps the shared memory.

[Qemu-devel] [PATCH v6 1/6] Device specification for shared memory PCI device

2010-06-04 Thread Cam Macdonell
--- docs/specs/ivshmem_device_spec.txt | 96 1 files changed, 96 insertions(+), 0 deletions(-) create mode 100644 docs/specs/ivshmem_device_spec.txt diff --git a/docs/specs/ivshmem_device_spec.txt b/docs/specs/ivshmem_device_spec.txt new file mode 100644 i

[Qemu-devel] [PATCH v6 6/6] the stand-alone shared memory server for inter-VM shared memory

2010-06-04 Thread Cam Macdonell
this code is a standalone server which will pass file descriptors for the shared memory region and eventfds to support interrupts between guests using inter-VM shared memory. --- contrib/ivshmem-server/Makefile | 16 ++ contrib/ivshmem-server/README | 30 +++ contrib/ivshmem-

[Qemu-devel] [PATCH v6 3/6] Change phys_ram_dirty to phys_ram_status

2010-06-04 Thread Cam Macdonell
phys_ram_dirty are 8-bit values storing 3 dirty bits. Change to more generic phys_ram_flags and use lower 4-bits for dirty status and leave upper 4 for other uses. The names of functions may need to be changed as well, such as c_p_m_get_dirty(). --- cpu-all.h | 16 +--- exec.c

[Qemu-devel] [PATCH v6 4/6] Add support for marking memory to not be migrated. On migration, memory is checked for the NO_MIGRATION_FLAG.

2010-06-04 Thread Cam Macdonell
This is useful for devices that do not want to take memory regions data with them on migration. --- arch_init.c | 28 cpu-all.h|2 ++ cpu-common.h |2 ++ exec.c | 12 4 files changed, 32 insertions(+), 12 deletions(-) diff --git a/

[Qemu-devel] [PATCH v6 5/6] Inter-VM shared memory PCI device

2010-06-04 Thread Cam Macdonell
Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository. -device ivshmem,size=[,shm=] Interrupts are su

[Qemu-devel] [PATCH v6 2/6] Add function to assign ioeventfd to MMIO.

2010-06-04 Thread Cam Macdonell
--- kvm-all.c | 32 kvm.h |1 + 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 47f58a6..2982631 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1257,6 +1257,38 @@ int kvm_set_signal_mask(CPUState *env, const sigset_

[Qemu-devel] [PATCH v6 0/6] Inter-VM Shared Memory Device with migration support

2010-06-04 Thread Cam Macdonell
Latest patch for PCI shared memory device that maps a host shared memory object to be shared between guests new in this series - migration support with 'master' and 'peer' roles for guest to determine who "owns" memory. With 'master', the guest has the canonical copy of the shared

[Qemu-devel] [PATCH 33/35] tcg-s390: Use the COMPARE IMMEDIATE instrucions for compares.

2010-06-04 Thread Richard Henderson
These instructions are available with extended-immediate facility. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 44 ++-- 1 files changed, 42 insertions(+), 2 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 8

[Qemu-devel] [PATCH 21/35] tcg-s390: Use the ADD IMMEDIATE instructions.

2010-06-04 Thread Richard Henderson
The ADD IMMEDIATE instructions are in the extended-immediate facility. Using them gives us a 32-bit immediate addend. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 96 1 files changed, 80 insertions(+), 16 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements

2010-06-04 Thread Blue Swirl
Thanks, applied. On Fri, Jun 4, 2010 at 4:23 PM, Richard Henderson wrote: > On 06/04/2010 07:27 AM, Paolo Bonzini wrote: >> Negative four byte displacements need to be sign-extended after >> c086b783eb7a578993d6d2ab62c4c2666800b63d.  Do so. > > Acked-by: Richard Henderson   > > >>         There a

[Qemu-devel] Re: option-rom (was cg14)

2010-06-04 Thread Blue Swirl
On Fri, Jun 4, 2010 at 5:40 PM, Artyom Tarasenko wrote: 2010/5/27 Bob Breuer : +    /* DBRI (audio) */ +    cpu_register_physical_memory_offset(0xEE0001000ULL, 0x1, bad_mem, 0xE0001000); >>> >>> Please add a new DBRI device ;-). >> >> Or maybe just a field in hwdef + empty

[Qemu-devel] [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Miguel Di Ciurcio Filho
Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. First issue: Their names implies different porpouses, but they do the same thing and have exactly the same code. Maybe copied and pasted and forgotten? bdrv_has_snapshot() is called in various places for actually checkin

[Qemu-devel] [PATCH] introduce -machine switch

2010-06-04 Thread Glauber Costa
This patch adds initial support for the -machine option, that allows command line specification of machine attributes. Besides its value per-se, it is the saner way we found to allow for enabling/disabling of kvm's in-kernel irqchip. machine-related options like kernel, initrd, etc, are now accept

[Qemu-devel] [PATCH 23/35] tcg-s390: Use the OR IMMEDIATE instructions.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 119 +--- 1 files changed, 111 insertions(+), 8 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 53a92c5..a17ef91 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s3

[Qemu-devel] [PATCH 35/35] tcg-s390: Enable compile in 32-bit mode.

2010-06-04 Thread Richard Henderson
The TCG translator will *not* work in 32-bit mode, and there is a check added to query_facilities to enforce that. However, QEMU can run in KVM mode when built in 32-bit mode, and this patch is just good enough to enable that method to continue. Signed-off-by: Richard Henderson --- tcg/s390/tcg

Re: [Qemu-devel] [PATCH 1/2] tcg: Add TYPE parameter to tcg_out_mov.

2010-06-04 Thread Blue Swirl
On Thu, Jun 3, 2010 at 12:26 AM, Richard Henderson wrote: > Mirror tcg_out_movi in having a TYPE parameter.  This allows x86_64 > to perform the move at the proper width, which may elide a REX prefix. > > Introduce a TCG_TYPE_REG enumerator to represent the "native width" > of the host register, a

Re: [Qemu-devel] [PATCH 1/2] tcg: Add TYPE parameter to tcg_out_mov.

2010-06-04 Thread Richard Henderson
On 06/04/2010 12:19 PM, Blue Swirl wrote: > Sparc32plus would match, though the ABI does not guarantee that higher > 32 bits are preserved. Actually, it does for %g and %o registers. See section 2.1.1. I've thought before about how to adjust the __sparcv8plus__ TCG to use full 64-bit registers a

[Qemu-devel] [PATCH 31/35] tcg-s390: Use 16-bit branches for forward jumps.

2010-06-04 Thread Richard Henderson
Translation blocks are never big enough to require 32-bit branches. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 27 ++- 1 files changed, 22 insertions(+), 5 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 13c4de6..81d5ad3

[Qemu-devel] [PATCH 32/35] tcg-s390: Use the LOAD AND TEST instruction for compares.

2010-06-04 Thread Richard Henderson
This instruction is always available, and nicely eliminates the constant load for comparisons against zero. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 133 +--- 1 files changed, 91 insertions(+), 42 deletions(-) diff --git a/tcg/s39

[Qemu-devel] [PATCH 34/35] tcg-s390: Use COMPARE AND BRANCH instructions.

2010-06-04 Thread Richard Henderson
These instructions are available with the general-instructions-extension facility. Use them if available. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 102 +--- 1 files changed, 95 insertions(+), 7 deletions(-) diff --git a/tcg/s390/

[Qemu-devel] [PATCH 27/35] tcg-s390: Rearrange qemu_ld/st to avoid register copy.

2010-06-04 Thread Richard Henderson
Split out qemu_ld/st_direct with full address components. Avoid copy from addr_reg to R2 for 64-bit guests. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 282 ++--- 1 files changed, 151 insertions(+), 131 deletions(-) diff --git a/tcg/

[Qemu-devel] [PATCH 30/35] tcg-s390: Implement GUEST_BASE.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configure |2 ++ tcg/s390/tcg-target.c | 24 ++-- tcg/s390/tcg-target.h |2 ++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 7f5b5b2..e80b820 100755 --- a/configure +++ b/c

[Qemu-devel] [PATCH 28/35] tcg-s390: Tidy tcg_prepare_qemu_ldst.

2010-06-04 Thread Richard Henderson
Make use of the reg+reg+disp addressing mode to eliminate redundant additions. Make use of the load-and-operate insns. Avoid an extra register copy when using the 64-bit shift insns. Fix the width of the TLB comparison. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 64 +

[Qemu-devel] [PATCH 26/35] tcg-s390: Tidy goto_tb.

2010-06-04 Thread Richard Henderson
Invent tcg_out_ld_abs, using LOAD RELATIVE instructions, and use it. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 37 + 1 files changed, 25 insertions(+), 12 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index f1e00

[Qemu-devel] [PATCH 29/35] tcg-s390: Tidy user qemu_ld/st.

2010-06-04 Thread Richard Henderson
Create a tcg_prepare_user_ldst to prep the host address to be used to implement the guest memory operation. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 33 + 1 files changed, 21 insertions(+), 12 deletions(-) diff --git a/tcg/s390/tcg-target.c

[Qemu-devel] [PATCH 24/35] tcg-s390: Use the XOR IMMEDIATE instructions.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 60 +--- 1 files changed, 56 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index a17ef91..5446591 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s39

[Qemu-devel] [PATCH 18/35] tcg-s390: Implement bswap operations.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 24 tcg/s390/tcg-target.h | 10 +- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 42e3224..3a98ca3 100644 --- a/tcg/s390/tcg-targe

[Qemu-devel] [PATCH 25/35] tcg-s390: Use the MULTIPLY IMMEDIATE instructions.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 43 +++ 1 files changed, 39 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 5446591..f1e00e9 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg

[Qemu-devel] [PATCH 09/35] s390: Disassemble some general-instruction-extension insns.

2010-06-04 Thread Richard Henderson
The full general-instruction-extension facility was added to binutils after the change to GPLv3. This is not the entire extension, just what we're using in TCG. Signed-off-by: Richard Henderson --- s390-dis.c | 89 ++- 1 files changed, 8

[Qemu-devel] [PATCH 20/35] tcg-s390: Use LOAD COMPLIMENT for negate.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index f53038b..826a2c8 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@ -1134,16 +1134,10 @@

[Qemu-devel] [PATCH 22/35] tcg-s390: Use the AND IMMEDIATE instructions.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 179 + 1 files changed, 166 insertions(+), 13 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 795ddcd..53a92c5 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/

[Qemu-devel] [PATCH 14/35] tcg-s390: Rearrange register allocation order.

2010-06-04 Thread Richard Henderson
Try to avoid conflicting with the outgoing function call arguments. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 95ea3c8..3944cb1 100

[Qemu-devel] [PATCH 19/35] tcg-s390: Implement rotates.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 46 ++ tcg/s390/tcg-target.h |4 ++-- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 3a98ca3..f53038b 100644 --- a/tc

[Qemu-devel] [PATCH 16/35] tcg-s390: Re-implement tcg_out_movi.

2010-06-04 Thread Richard Henderson
Make better use of the LOAD HALFWORD IMMEDIATE, LOAD IMMEDIATE, and INSERT IMMEDIATE instruction groups. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 129 +++-- 1 files changed, 113 insertions(+), 16 deletions(-) diff --git a/tcg/s390

[Qemu-devel] [PATCH 17/35] tcg-s390: Implement sign and zero-extension operations.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 164 - tcg/s390/tcg-target.h | 20 +++--- 2 files changed, 158 insertions(+), 26 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 71e017a..42e3224 100644 -

[Qemu-devel] [PATCH 10/35] tcg-s390: New TCG target

2010-06-04 Thread Richard Henderson
We already have stubs for a TCG target on S390, but were missing code that would actually generate instructions. So I took Uli's patch, cleaned it up and present it to you again :-). I hope I found all odd coding style and unprettiness issues, but if you still spot one feel free to nag about it.

[Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed.

2010-06-04 Thread Richard Henderson
Verify that we have all the instruction extensions that we generate. Future patches can tailor code generation to the set of instructions that are present. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 113 + 1 files changed, 113 in

[Qemu-devel] [PATCH 07/35] tcg: Optionally sign-extend 32-bit arguments for 64-bit host.

2010-06-04 Thread Richard Henderson
Some hosts (amd64, ia64) have an ABI that ignores the high bits of the 64-bit register when passing 32-bit arguments. Others, like s390x, require the value to be properly sign-extended for the type. I.e. "int32_t" must be sign-extended and "uint32_t" must be zero-extended to 64-bits. To effect t

[Qemu-devel] [PATCH 12/35] tcg-s390: Define TCG_TMP0.

2010-06-04 Thread Richard Henderson
Use a define for the temp register instead of hard-coding it. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 54 ++-- 1 files changed, 29 insertions(+), 25 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 5

[Qemu-devel] [PATCH 13/35] tcg-s390: Tidy regset initialization; use R14 as temporary.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 26 -- 1 files changed, 12 insertions(+), 14 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 2b80c02..95ea3c8 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@ -41

[Qemu-devel] [PATCH 06/35] tcg-s390: Allocate the code_gen_buffer near the main program.

2010-06-04 Thread Richard Henderson
This allows the use of direct calls to the helpers, and a direct branch back to the epilogue. Signed-off-by: Richard Henderson --- exec.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index bb3dcad..7bbfe60 100644 --- a/exec.c +++ b/exec.c @@ -519

[Qemu-devel] [PATCH 02/35] s390x: Avoid _llseek.

2010-06-04 Thread Richard Henderson
There's no _llseek on s390x either. Replace the existing test for __x86_64__ with a functional test for __NR_llseek. Signed-off-by: Richard Henderson --- linux-user/syscall.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c

[Qemu-devel] [PATCH 11/35] tcg-s390: Tidy unimplemented opcodes.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 25 ++--- 1 files changed, 10 insertions(+), 15 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 55f0fa9..5b2134b 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@ -824

[Qemu-devel] [PATCH 04/35] tcg-s390: Compute is_write in cpu_signal_handler.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- cpu-exec.c | 42 +++--- 1 files changed, 39 insertions(+), 3 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index c776605..026980a 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -1156,11 +1156,47 @@ int cpu_signal_handler

[Qemu-devel] [PATCH 05/35] tcg-s390: Icache flush is a no-op.

2010-06-04 Thread Richard Henderson
Before gcc 4.2, __builtin___clear_cache doesn't exist, and afterward the gcc s390 backend implements it as nothing. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/tcg/s390/tcg-target.h b/tcg/s390/tcg-target.

[Qemu-devel] [PATCH 00/35] S390 TCG target, version 2

2010-06-04 Thread Richard Henderson
Changes v1->v2 * Disassembler doesn't include GPLv3 code. * Smashed about 20 commits into the "New TCG Target" patch, which is fully functional from the beginning. * Merged a lot of the follow-on patches such that introducing the use of an instruction and conditionalizing the use of

[Qemu-devel] [PATCH 08/35] s390: Update disassembler to the last GPLv2 from binutils.

2010-06-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- s390-dis.c | 81 +--- 1 files changed, 50 insertions(+), 31 deletions(-) diff --git a/s390-dis.c b/s390-dis.c index 86dd84f..3d96be0 100644 --- a/s390-dis.c +++ b/s390-dis.c @@ -1,3 +1,4 @@ +/* opcodes

[Qemu-devel] [PATCH 03/35] s390x: Don't use a linker script for user-only.

2010-06-04 Thread Richard Henderson
The default placement of the application at 0x8000 is fine, and will avoid the default placement for most other guests. Signed-off-by: Richard Henderson --- configure |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 65f87a2..7f5b5b2 10075

[Qemu-devel] [PATCH 01/35] tcg-s390: Adjust compilation flags.

2010-06-04 Thread Richard Henderson
Force -m31/-m64 based on s390/s390x target. Force -march=z990. The TCG backend will always require the long-displacement facility, so the compiler may as well make use of that as well. Signed-off-by: Richard Henderson --- configure |7 ++- 1 files changed, 6 insertions(+), 1 deletions(

[Qemu-devel] Re: [PATCH] sparc32 esp fix spurious interrupts in chip reset

2010-06-04 Thread Blue Swirl
On Tue, Jun 1, 2010 at 8:16 PM, Artyom Tarasenko wrote: > 2010/6/1 Blue Swirl : >> On Tue, Jun 1, 2010 at 7:56 PM, Artyom Tarasenko >> wrote: >>> 2010/6/1 Blue Swirl : On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko wrote: > lower interrupt during chip reset. Otherwise the ESP_R

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-04 Thread Blue Swirl
On Thu, Jun 3, 2010 at 7:06 AM, Gleb Natapov wrote: > On Thu, Jun 03, 2010 at 10:03:00AM +0300, Gleb Natapov wrote: >> On Thu, Jun 03, 2010 at 08:59:23AM +0200, Jan Kiszka wrote: >> > Gleb Natapov wrote: >> > > On Thu, Jun 03, 2010 at 08:23:46AM +0200, Jan Kiszka wrote: >> > >> Blue Swirl wrote: >

[Qemu-devel] [Bug 589827] [NEW] QEMU netdev tap type id name is not used on linux host

2010-06-04 Thread JP Senior
Public bug reported: Tested with 0.12.3, 0.12.4, and latest git as of 4 jun 2010. The new -netdev type seems to ignore manual specifications of tap ifname. qemu-system-x86_64 -hda disk.img -netdev tap,id=ids_e0 -device e1000,netdev=ids_e0 **creates tap0 instead of ids_e0. tap0 passes traff

Re: [Qemu-devel] [PATCH 07/10] target-mips: add microMIPS CPUs

2010-06-04 Thread Nathan Froyd
On Fri, Jun 04, 2010 at 11:35:45AM -0700, Richard Henderson wrote: > On 05/24/2010 09:19 AM, Nathan Froyd wrote: > > Signed-off-by: Nathan Froyd > > --- > > target-mips/translate_init.c | 61 > > ++ > > 1 files changed, 61 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] [PATCH 06/10] target-mips: add microMIPS ASE support

2010-06-04 Thread Nathan Froyd
On Fri, Jun 04, 2010 at 11:30:38AM -0700, Richard Henderson wrote: > On 05/24/2010 09:19 AM, Nathan Froyd wrote: > > +int (*ldfun)(target_ulong); > > + > > +switch (mem_idx) > > +{ > > +case 0: ldfun = ldl_kernel; break; > > +case 1: ldfun = ldl_super; break; > > +default: >

Re: [Qemu-devel] [PATCH 10/10] hw: honor low bit in mipssim machine

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > Signed-off-by: Nathan Froyd > --- > hw/mips_mipssim.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/hw/mips_mipssim.c b/hw/mips_mipssim.c > index a747de5..cd6c2be 100644 > --- a/hw/mips_mipssim.c > +++ b/hw/mips_mip

Re: [Qemu-devel] [PATCH 07/10] target-mips: add microMIPS CPUs

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > Signed-off-by: Nathan Froyd > --- > target-mips/translate_init.c | 61 > ++ > 1 files changed, 61 insertions(+), 0 deletions(-) > Reviewed-by: Richard Henderson ... not that there's anything in here I coul

Re: [Qemu-devel] [PATCH 09/10] linux-user: honor low bit of entry PC for MIPS

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > Signed-off-by: Nathan Froyd > --- > linux-user/main.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 18b52c0..76d443b 100644 > --- a/linux-user/main.c > +++ b/linux-user/

Re: [Qemu-devel] [PATCH] Change 'query-version' to output broken down version string

2010-06-04 Thread Luiz Capitulino
On Wed, 2 Jun 2010 13:40:06 +0100 "Daniel P. Berrange" wrote: > A previous discussion brought up the fact that clients should > not have to parse version string from QMP, it should be given > to them pre-split. Right. > Change query-version output format from: > > { "qemu": "0.11.50", "pac

Re: [Qemu-devel] [PATCH 08/10] target-mips: add microMIPS exception handler support

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > return bad_pc; > } > +static void set_hflags_for_handler (CPUState *env) > +{ Missing vertical space between functions. r~

Re: [Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support, v2

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > This patch series adds support for the microMIPS ASE. microMIPS is a > new ASE similar to MIPS16, but re-encodes the entire instruction set > into 16-bit and 32-bit instructions--in contrast to MIPS16, which > re-encodes only integer instructions. The

Re: [Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP

2010-06-04 Thread Richard Henderson
On 06/04/2010 10:50 AM, Nathan Froyd wrote: > What's the benefit from declaring op1 as 'enum fopcode' or similar? Debugging and self-documentation. r~

Re: [Qemu-devel] [PATCH 06/10] target-mips: add microMIPS ASE support

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > +int (*ldfun)(target_ulong); > + > +switch (mem_idx) > +{ > +case 0: ldfun = ldl_kernel; break; > +case 1: ldfun = ldl_super; break; > +default: > +case 2: ldfun = ldl_user; break; > +} This *should* now be a compile err

[Qemu-devel] Re: [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Miguel Di Ciurcio Filho
On Fri, Jun 4, 2010 at 2:28 PM, Kevin Wolf wrote: >> @@ -1674,12 +1659,26 @@ void do_savevm(Monitor *mon, const QDict *qdict) >>  #endif >>      const char *name = qdict_get_try_str(qdict, "name"); >> >> +    /* Verify if there is a device that doesn't support snapshots and is >> writable */ >> +

[Qemu-devel] [PATCH 27/27] block: Fix serial number assignment

2010-06-04 Thread Kevin Wolf
From: Luiz Capitulino We should use 'dinfo->serial' length, 'serial' is a pointer, so the serial number length is currently limited to the pointer size. This fixes https://bugs.launchpad.net/qemu/+bug/584143 and is also valid for stable. Signed-off-by: Luiz Capitulino Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 01/10] target-mips: break out [ls][wd]c1 and rdhwr insn generation

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > Signed-off-by: Nathan Froyd > --- > target-mips/translate.c | 106 > ++- > 1 files changed, 59 insertions(+), 47 deletions(-) Acked-by: Richard Henderson r~

[Qemu-devel] [PATCH 26/27] blockdev: Collect block device code in new blockdev.c

2010-06-04 Thread Kevin Wolf
From: Markus Armbruster Anything that moves hundreds of lines out of vl.c can't be all bad. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- Makefile.objs|2 +- blockdev.c | 600 ++ blockdev.h | 7

Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > +case FMT_D: > \ > +if (abs) > \ > +check_cop1x(ctx); >

[Qemu-devel] [PATCH 22/27] close all the block drivers before the qemu process exits

2010-06-04 Thread Kevin Wolf
From: MORITA Kazutaka This patch calls the close handler of the block driver before the qemu process exits. This is necessary because the sheepdog block driver releases the lock of VM images in the close handler. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block.c |9 +++

Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

2010-06-04 Thread Luiz Capitulino
On Tue, 1 Jun 2010 19:12:19 -0300 Eduardo Habkost wrote: > I have no clue why the code had the is_inserted() check, as it doesn't matter > if there is a disk present at the host drive, when the user wants the virtual > device to be disconnected from the host device. Makes sense, although I have

[Qemu-devel] [PATCH 14/27] qdev: New qdev_prop_set_string()

2010-06-04 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/qdev-properties.c |5 + hw/qdev.h|1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 9ffdba7..b6ee50f 100644 ---

[Qemu-devel] [PATCH 25/27] qdev: Move declaration of qdev_init_bdrv() into qdev.h

2010-06-04 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/pl181.c |1 - hw/qdev.h |2 ++ hw/ssi-sd.c |1 - sysemu.h|2 -- 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pl181.c b/hw/pl181.c index 1924053..85cadc4 100644

[Qemu-devel] [PATCH 20/27] Fix error message in drive_init

2010-06-04 Thread Kevin Wolf
The real error is the return value of bdrv_open. errno might be overwritten or not even set to that value in the first place. Signed-off-by: Kevin Wolf --- vl.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 76a9b25..2769d1a 100644 --- a/vl.c +++

Re: [Qemu-devel] [PATCH] hxtool: Fix line number reporting on SQMP/EQMP errors

2010-06-04 Thread Luiz Capitulino
On Wed, 02 Jun 2010 09:06:03 +0200 Jan Kiszka wrote: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka Looks good. > --- > hxtool |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hxtool b/hxtool > index d499dc0..7ca83ed 100644 > --- a/hxtool > +++ b/hxtool > @

Re: [Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP

2010-06-04 Thread Nathan Froyd
On Fri, Jun 04, 2010 at 10:45:32AM -0700, Richard Henderson wrote: > On 05/24/2010 09:19 AM, Nathan Froyd wrote: > > @@ -5937,8 +6031,8 @@ static void gen_farith (DisasContext *ctx, uint32_t > > op1, > > enum { BINOP, CMPOP, OTHEROP } optype = OTHEROP; > > uint32_t func = ctx->opcode & 0

Re: [Qemu-devel] [PATCH v3 00/17] clean up vl.c code

2010-06-04 Thread Richard Henderson
On 06/04/2010 09:08 AM, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Hi, > > Ok third time lucky ... I hope! This fixes the missing git add on > qemu-options.h as building for win32 using mingw (thanks Paolo!). Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 05/10] target-mips: small changes to use new FMT_ enums

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > Signed-off-by: Nathan Froyd > --- > target-mips/translate.c | 17 + > 1 files changed, 9 insertions(+), 8 deletions(-) Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > +enum { > +OPC_ADD_S = FOP(0, FMT_S), Adding the enumeration is good. Naming the enumeration and using it in appropriate places is even better. > @@ -5937,8 +6031,8 @@ static void gen_farith (DisasContext *ctx, uint32_t op1, > enum { BINOP,

Re: [Qemu-devel] [PATCH 02/10] target-mips: add microMIPS-specific bits to mips-defs.h

2010-06-04 Thread Richard Henderson
On 05/24/2010 09:19 AM, Nathan Froyd wrote: > There's a new ASE_MICROMIPS instruction flag, and some extra CP0_Config3 > fields. The ISA and ISA_ON_EXC fields are specific to microMIPS. The > DSP2P is for version 2 of the DSP ASE. > > Signed-off-by: Nathan Froyd > --- > target-mips/cpu.h

[Qemu-devel] [PATCH 23/27] block: call the snapshot handlers of the protocol drivers

2010-06-04 Thread Kevin Wolf
From: MORITA Kazutaka When snapshot handlers are not defined in the format driver, it is better to call the ones of the protocol driver. This enables us to implement snapshot support in the protocol driver. We need to call bdrv_close() and bdrv_open() handlers of the format driver before and af

[Qemu-devel] option-rom (was cg14)

2010-06-04 Thread Artyom Tarasenko
>>> 2010/5/27 Bob Breuer : >>> +    /* DBRI (audio) */ >>> +    cpu_register_physical_memory_offset(0xEE0001000ULL, 0x1, bad_mem, >>> 0xE0001000); >> >> Please add a new DBRI device ;-). > > Or maybe just a field in hwdef + empty_slot? :-) Or actually don't bother at all. What is expected at

[Qemu-devel] [PATCH 09/27] ide: Remove useless IDEDeviceInfo members unit, drive

2010-06-04 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/internal.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/ide/internal.h b/hw/ide/internal.h index 2efc784..b4554ce 100644 --- a/hw/ide/internal.h +++ b/hw/ide/internal.h

[Qemu-devel] [PATCH 03/27] Cleanup: raw-posix.c: Be more consistent using BDRV_SECTOR_SIZE instead of 512

2010-06-04 Thread Kevin Wolf
From: Jes Sorensen Clean up raw-posix.c to be more consistent using BDRV_SECTOR_SIZE instead of hard coded 512 values. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block/raw-posix.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/block

[Qemu-devel] [PATCH 24/27] blockdev: Hide QEMUMachine from drive_init()

2010-06-04 Thread Kevin Wolf
From: Markus Armbruster To pave the way for moving it out of vl.c. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/device-hotplug.c |2 +- hw/usb-msd.c|2 +- sysemu.h|3 ++- vl.c| 12 +--- 4 files changed, 9 insertion

[Qemu-devel] [PATCH] qemu-iotests: qcow2 error path tests

2010-06-04 Thread Kevin Wolf
This adds test cases for qcow2 error paths (using blkdebug) Signed-off-by: Kevin Wolf --- 026 | 192 ++ 026.out | 558 +++ group |1 + 3 files changed, 751 insertions(+), 0 deletions(-) create mode 10075

[Qemu-devel] [PATCH 21/27] block: Assume raw for drives without media

2010-06-04 Thread Kevin Wolf
qemu -cdrom /dev/cdrom with an empty CD-ROM drive doesn't work any more because we try to guess the format and when this fails (because there is no medium) we exit with an error message. This patch should restore the old behaviour by assuming raw format for such drives. Signed-off-by: Kevin Wolf

  1   2   3   >