On Wed, Jul 07, 2010 at 02:47:10PM +0300, Michael S. Tsirkin wrote:
> > > I think this becomes too complex: as bridge configuration affects
> > > the bus operation, you might end up sticking a pointer to the device
> > > in the bus. A similar arrangement is in place in with piix_pci, and I
> > > w
Hi Stefan,
On 07/07/2010 01:44 AM, Stefan Hajnoczi wrote:
Signed-off-by: Stefan Hajnoczi
---
This applies to the tracing branch at:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing-dev
simpletrace.c | 23 +++
1 files changed, 15 insertions(+), 8 dele
[PATCH] Separate monitor command handler interfaces and tracing internals.
Signed-off-by: Prerna Saxena
---
monitor.c | 23 +++
simpletrace.c | 51 +--
tracetool |7 +++
3 files changed, 59 insertions(+), 22
So interpret it by hand.
Signed-off-by: Hidetoshi Seto
---
Makefile |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 7b82a33..6fc1b2c 100644
--- a/Makefile
+++ b/Makefile
@@ -171,7 +171,8 @@ distclean: clean
rm -f qemu-options.def
There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
Signed-off-by: Hidetoshi Seto
---
Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 560eac6..7b82a33 100644
--- a/Makefile
+++ b/Makefile
@@ -159,7 +159,7 @@ clean:
# avoid
Yes! Using SeaBIOS 6.0 worked for me as well. Thanks LightBit. I've been
waiting for this for quite a while.
--
Windows 98 doesn't detect mouse on qemu and SeaBIOS.
https://bugs.launchpad.net/bugs/521994
You received this bug notification because you are a member of qemu-
devel-ml, which is subsc
Marcelo Tosatti wrote:
> If ->write fails, declare migration status as MIG_STATE_ERROR.
>
> Also, in buffered_file.c, ->close the object in case of an
> error.
>
> Fixes "migrate -d "exec:dd of=file", where dd fails to open file.
>
> Signed-off-by: Marcelo Tosatti
Acked-by: Juan Quintela
Again
On Wed, Jul 7, 2010 at 6:15 PM, malc wrote:
> On Wed, 7 Jul 2010, Blue Swirl wrote:
>
>> Add I/O port registration functions which separate registration
>> from the mapping stage.
>
> Why?
So that the device code can specify all other parameters except for
the I/O port, which will be handled by P
If ->write fails, declare migration status as MIG_STATE_ERROR.
Also, in buffered_file.c, ->close the object in case of an
error.
Fixes "migrate -d "exec:dd of=file", where dd fails to open file.
Signed-off-by: Marcelo Tosatti
diff --git a/buffered_file.c b/buffered_file.c
index 54dc6c2..be147d
Thanks, applied. It also fixes OpenBSD build.
On Wed, Jul 7, 2010 at 6:25 AM, MORITA Kazutaka
wrote:
> WIN32 is not only the system which doesn't have TCP_CORK (e.g. OS X).
>
> Signed-off-by: MORITA Kazutaka
> ---
>
> Betts, I think this patch fix the compile error. Can you try this
> one?
>
>
On Wed, Jul 7, 2010 at 7:02 PM, Anthony Liguori wrote:
> On 07/07/2010 12:53 PM, Blue Swirl wrote:
>>
>> Add I/O port registration functions which separate registration
>> from the mapping stage.
>>
>> Move IOIO and MMIO BAR mapping to pci.c.
>>
>> TODO: fix dirty logging, coalesced MMIO and base
Implement a threaded VNC server using the producer-consumer model.
The main thread will push encoding jobs (a list a rectangles to update)
in a queue, and the VNC worker thread will consume that queue and send
framebuffer updates to the output buffer.
The threaded VNC server can be enabled with ./
All vnc_write() calls must be locked (except the ones present before
the protocol initialization).
Signed-off-by: Corentin Chary
---
ui/vnc.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 7330b2c..7fc40ac 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
The tight.png buffer was never released.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 52b81f3..3f19df2 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -167
This will allow to implement the threaded VNC server in a
more cleaner way.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-hextile.c | 14 ++--
ui/vnc-enc-tight.c | 204 +-
ui/vnc-enc-zlib.c| 34
ui/vnc.c |8 +-
ui
buf was never freed.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ade8e5f..4ff88a8 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1247,8 +1247,6 @@ sta
While using indexed colors, the last color was never added to the palette.
Triggered with ubuntu livecd.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 358221d..ade8e5f 1
vnc_jpeg and vnc_png are now "auto" by default, this means that
if the dependencies are installed (libjpeg or libpng), then they
will be enabled.
vnc_thread is disabled by default. It should be enabled by default
as soon as it's stable enougth.
Signed-off-by: Corentin Chary
---
configure | 14
Disable png filters for lower compression levels. This should lower
the CPU consumption and reduce encoding time.
This isn't in tight_conf because:
* tight_conf structure must not change, because it's shared with other
tight implementations (libvncserver, etc..).
* it'd exceed the 80 col limit.
Move sdl, vnc, curses and cocoa UI into ui/ to cleanup
the root directory. Also remove some unnecessary explicit
targets from Makefile.
Signed-off-by: Corentin Chary
---
Makefile | 38 +++-
Makefile.objs
Introduce a new encoding: VNC_ENCODING_TIGHT_PNG [1] (-269) with a new
tight filter VNC_TIGHT_PNG (0x0A). When the client tells it supports the Tight
PNG
encoding, the server will use tight, but will always send encoding pixels using
PNG instead of zlib. If the client also told it support JPEG, th
Add some missing functions in qemu-thread. Currently qemu-thread
is only used for io-thread but it will used by the vnc server soon
and we need those functions instead of calling pthread directly.
Signed-off-by: Corentin Chary
---
qemu-thread.c | 22 ++
qemu-thread.h |4
Add gradient filter and JPEG compression with an heuristic to detect how
lossy the comppression will be. This code has been adapted from
libvncserver/tight.c.
JPEG support can be enabled/disabled at compile time with --enable-vnc-jpeg
and --disable-vnc-jpeg.
Signed-off-by: Corentin Chary
---
Ma
This set contains all my patchs related to tight and threaded vnc server.
Since v1:
* Add a fix for jpeg and png with non-24bpp displays
* Better default values for vnc options in ./configure
* Fixed Tight PNG to use its own encoding number (-260)
* Cleaned tight send_sub_rect()
Tight JPEG and Mo
Profiling with callgrind seems to show that a lot of time is spent
in the palette code (mostly due to memory allocation and qdict to int
conversion).
This patch adds a VncPalette implementation. The palette is stored
in a hash table, like qdict, but which does way less memory allocations,
and does
Split send_sub_rect in send_sub_rect_jpeg and send_sub_rect_nojpeg to
remove all these #ifdef CONFIG_JPEG.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c | 80 +++
1 files changed, 55 insertions(+), 25 deletions(-)
diff --git a/ui/vnc-enc-
For the same reason that we don't use vnc-authentication-sasl.c but
vnc-auth-sals.c. Because it's to long.
Signed-off-by: Corentin Chary
---
Makefile.objs|4 ++--
ui/{vnchextile.h => vnc-enc-hextile-template.h} |0
ui/{vnc-encoding-hextile.c => vn
rgb_prepare_row bpp depends on the server display surface, not
the client.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 3f19df2..eaa88ce 100644
--- a/ui/v
Disable JPEG compression by default and only enable it if the
VNC client has sent the requested quality.
Signed-off-by: Corentin Chary
---
vnc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.c b/vnc.c
index ed0e096..9cf38d1 100644
--- a/vnc.c
+++ b/vnc.c
@@ -1644,
The lossy option can be used to enable lossy compression
methods like gradient or jpeg. This patch disable them by
default.
Signed-off-by: Corentin Chary
---
qemu-options.hx |7 +++
vnc-encoding-tight.c |4
vnc.c|2 ++
vnc.h|2 ++
4 f
Marcelo Tosatti wrote:
> If ->write fails, declare migration status as MIG_STATE_ERROR.
>
> Also, in buffered_file.c, ->close the object in case of an
> error.
>
> Fixes "migrate -d "exec:dd of=file", where dd fails to open file.
>
> Signed-off-by: Marcelo Tosatti
Acked-by: Juan Quintela
> d
You may want to try the patch to qemu that avi just posted to the qemu-
devel mailing list. I think this would probably fix your issue.
--
virsh save is very slow
https://bugs.launchpad.net/bugs/524447
You received this bug notification because you are a member of qemu-
devel-ml, which is subscri
On Wed, 7 Jul 2010, Blue Swirl wrote:
> Add I/O port registration functions which separate registration
> from the mapping stage.
Why?
[..snip..]
--
mailto:av1...@comtv.ru
On Wed, Jul 7, 2010 at 6:04 PM, Marcelo Tosatti wrote:
>
> If ->write fails, declare migration status as MIG_STATE_ERROR.
>
> Also, in buffered_file.c, ->close the object in case of an
> error.
>
> Fixes "migrate -d "exec:dd of=file", where dd fails to open file.
>
> Signed-off-by: Marcelo Tosatti
On Wed, Jul 7, 2010 at 5:55 PM, Michael S. Tsirkin wrote:
> On Wed, Jul 07, 2010 at 05:53:08PM +, Blue Swirl wrote:
>> Add I/O port registration functions which separate registration
>> from the mapping stage.
>>
>> Move IOIO and MMIO BAR mapping to pci.c.
>>
>> TODO: fix dirty logging, coales
Ran into this problem today with fresh Windows 2003 R2 install on a IDE
boot drive. Because the CD-ROM boot bypasses this problem the install
completes just fine, until I tell it to boot from the hard disk (via
libvirt).
Latest available packages from Debian testing;
qemu 0.12.4+dfsg-3
qemu-kvm 0
If ->write fails, declare migration status as MIG_STATE_ERROR.
Also, in buffered_file.c, ->close the object in case of an
error.
Fixes "migrate -d "exec:dd of=file", where dd fails to open file.
Signed-off-by: Marcelo Tosatti
diff --git a/buffered_file.c b/buffered_file.c
index 54dc6c2..be1
On Wed, Jul 07, 2010 at 05:53:08PM +, Blue Swirl wrote:
> Add I/O port registration functions which separate registration
> from the mapping stage.
>
> Move IOIO and MMIO BAR mapping to pci.c.
>
> TODO: fix dirty logging, coalesced MMIO and base address comparisons
> (eepro100 etc). Bridge fi
On Wed, Jul 07, 2010 at 05:31:39PM +, Blue Swirl wrote:
> On Tue, Jul 6, 2010 at 11:23 AM, Michael S. Tsirkin wrote:
> > bridge config write should trigger updates
> > on the secondary bus. never on the primary bus.
>
> If this is true, shouldn't updates happen on all buses from secondary
> t
Hi, just wanted to report, I just tried libvirt-0.8.2 which should use larger
dd blocksize.
save is still painfully slow, about 1MB/s while host is totally
idle...
regards
nik
On Tue, Jun 22, 2010 at 07:02:08PM -, Serge Hallyn wrote:
> Just a note that the 0.8.1 release available in maverick
QEMUFileBuffered stops writing when the underlying QEMUFile is not ready,
and tells its producer so. However, when the underlying QEMUFile becomes
ready, it neglects to pass that information along, resulting in stoppage
of all data until the next tick (a tenths of a second).
Usually this doesn't
On Tue, Jul 6, 2010 at 11:23 AM, Michael S. Tsirkin wrote:
> bridge config write should trigger updates
> on the secondary bus. never on the primary bus.
If this is true, shouldn't updates happen on all buses from secondary
to subordinate? Do we know which of these are immediately below
primary b
Per the EHCI specification a USB 2.0 host controller is comprised of one
high-speed controller and 0 to N USB 1.1 companion host controllers (UHCI or
OHCI) for low- and full-speed devices. Port routing and control logic
determines which HC owns a particular port. See Sections 1.2 and 4.2 of the
It compiles now.
On Jul 7, 2010, at 12:25 AM, MORITA Kazutaka wrote:
> WIN32 is not only the system which doesn't have TCP_CORK (e.g. OS X).
>
> Signed-off-by: MORITA Kazutaka
> ---
>
> Betts, I think this patch fix the compile error. Can you try this
> one?
>
> block/sheepdog.c |2 +-
> 1
On Wed, 7 Jul 2010, Juan Quintela wrote:
>
> Signed-off-by: Juan Quintela
> ---
> docs/migration.txt | 303
>
> 1 files changed, 303 insertions(+), 0 deletions(-)
> create mode 100644 docs/migration.txt
>
> diff --git a/docs/migration.txt
On Wed, Jul 07, 2010 at 10:07:09AM -0300, Luiz Capitulino wrote:
> On Mon, 5 Jul 2010 16:34:22 -0300
> Miguel Di Ciurcio Filho wrote:
>
> > Possible values for "type" are defined in the patch on the
> > qdev_property_type_to_string() function. To spot them in the current
> > code, hw/qdev.c:77:
>
On Mon, 5 Jul 2010 16:34:22 -0300
Miguel Di Ciurcio Filho wrote:
> Possible values for "type" are defined in the patch on the
> qdev_property_type_to_string() function. To spot them in the current
> code, hw/qdev.c:77:
>
> enum PropertyType {
> PROP_TYPE_UNSPEC = 0,
> PROP_TYPE_UINT8,
>
The VRING_AVAIL_F_NO_INTERRUPT flag is a hint that interrupts should be
suppressed. It does not guarantee that interrupts will not be raised.
Therefore, make sure to clear the interrupt after each virtio-blk read.
This avoids a stuck interrupt interfering with the OS loaded later in
the boot proce
Signed-off-by: Juan Quintela
---
docs/migration.txt | 303
1 files changed, 303 insertions(+), 0 deletions(-)
create mode 100644 docs/migration.txt
diff --git a/docs/migration.txt b/docs/migration.txt
new file mode 100644
index 000..551
This reverts commit 42ee76fe82093ba914f0dc83d2decbcf68866144.
Signed-off-by: Juan Quintela
---
hw/ide/pci.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/ide/pci.c b/hw/ide/pci.c
index 4d95cc5..780fc5f 100644
--- a/hw/ide/pci.c
+++ b/hw/ide/pci.c
@@ -123,7 +1
It reintroduces
Revert "ide save/restore pio/atapi cmd transfer fields and io buffer"
but using subsections. Added bonus is the addition of ide_dummy_transfer_stop
to transfer_end_table, that was missing.
Signed-off-by: Juan Quintela
---
hw/ide/pci.c | 30 ++
This reverts commit ed487bb1d69040b9dac64a4fc076d8dd82b131d6.
The conflicts are due to commit 4fc8d6711aff7a9c11e402c3d77b481609f9f486
that is a fix to the ide_drive_pre_save() function. It reverts both
(and both are reinstantiated later in the series)
Conflicts:
hw/ide/core.c
Signed-o
Signed-off-by: Juan Quintela
---
hw/ide/core.c | 90 -
hw/ide/internal.h |5 +++
2 files changed, 94 insertions(+), 1 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 8669602..20e639d 100644
--- a/hw/ide/core.c
+++ b/hw/
This commit adds subsections for each device section.
Subsections is the way to handle information that don't need to be sent
to de destination of a migration because its values are not needed. It is
the way to handle optional information. Notice that only the source can
decide if the information
v2:
- add documentation
- improve commit messages
- remove debug printf's
- rebase latest qemu
v1:
At the end, here is the migration subsections implementation. As an example I
ported the last
two ide changes to migration to work with subsections. Notes:
- subsections
I went for qemu_peek_b
On Wed, Jul 07, 2010 at 11:38:58AM +0900, Isaku Yamahata wrote:
> On Tue, Jul 06, 2010 at 03:18:52PM +0300, Michael S. Tsirkin wrote:
> > On Fri, Jul 02, 2010 at 11:30:11AM +0900, Isaku Yamahata wrote:
> > > allocate PCIBus dynamically for PCIBridge and bug fix of
> > > pci_unregister_secondary_bus
Am 06.07.2010 14:37, schrieb Markus Armbruster:
> Disk vs. CD needs to be in qdev, because it belongs to the drive's
> guest part.
>
> Keep ide-drive for backward compatibility.
>
> Signed-off-by: Markus Armbruster
> ---
> hw/ide/core.c | 11 +---
> hw/ide/internal.h |2 +-
> hw/i
Am 07.07.2010 11:34, schrieb Markus Armbruster:
> Christoph Hellwig writes:
>
>> On Tue, Jul 06, 2010 at 02:08:46PM +0200, Markus Armbruster wrote:
>>> * Any drive backed by host_floppy now retries.
>>
>> I would really prefer not to change the behaviour for this case, it'll
>> just confuse peopl
Kevin Wolf writes:
> Am 07.07.2010 03:37, schrieb Christoph Hellwig:
>> On Tue, Jul 06, 2010 at 02:37:47PM +0200, Markus Armbruster wrote:
>>> Disk vs. CD needs to be in qdev, because it belongs to the drive's
>>> guest part.
>>
>> Looks good, but the scsi-hd name feelds kinda awkward. This is
Christoph Hellwig writes:
> On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote:
>> drive_init() doesn't permit rerror for if=scsi, but that's worthless:
>> we get it via if=none and -device.
>>
>> Moreover, scsi-generic doesn't support werror. Since drive_init()
>> doesn't catch
Christoph Hellwig writes:
> On Tue, Jul 06, 2010 at 02:08:46PM +0200, Markus Armbruster wrote:
>> * Any drive backed by host_floppy now retries.
>
> I would really prefer not to change the behaviour for this case, it'll
> just confuse people looking at the history when finally removing this
> hac
Something recently (within the last week) committed to Git has broken
networking on Hurd guests with and without KVM. Does anyone have any
idea what it could be?
This is the command I'm using:
qemu -hda debian-hurd-k16-qemu.img -m 512 -boot c -net nic,model=rtl8139
-net user --enable-kvm
-
2010-06-24 00:16:03 -, Jamie Lokier:
> Serge Hallyn wrote:
> > The default of qemu-img (of using O_SYNC) is not very sensible
> > because anyway, the client (the kernel) uses caches (write-back),
> > (and "qemu-nbd -d" doesn't flush those by the way). So if for
> > instance qemu-nbd is killed,
On 07/07/2010 01:10 AM, Anthony Liguori wrote:
On 07/02/2010 06:15 AM, Prerna Saxena wrote:
Set up host kernel include paths specified by --kerneldir
When host kernel headers are placed in non-standard paths, the
KVM_CFLAGS are presently invoked only for a few .c files
(kvm*.c,vhost*.c) and not
Am 07.07.2010 03:37, schrieb Christoph Hellwig:
> On Tue, Jul 06, 2010 at 02:37:47PM +0200, Markus Armbruster wrote:
>> Disk vs. CD needs to be in qdev, because it belongs to the drive's
>> guest part.
>
> Looks good, but the scsi-hd name feelds kinda awkward. This is one
> case we're I'm really
65 matches
Mail list logo
