Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread malc
On Tue, 27 Jul 2010, Jun Koi wrote: > On Mon, Jul 26, 2010 at 8:16 PM, malc wrote: > > On Mon, 26 Jul 2010, Eliot Moss wrote: > > > >> On 7/26/2010 6:20 AM, Llu?s wrote: > >> > Eduardo Cruz writes: [..snip..] > >> > >> In the context of another simulator, we developed a different > >> technique,

[Qemu-devel] [PATCH for master 1/3] pci: move out pci internal structures, PCIBus, PCIBridge, and pci_bus_info.

2010-07-26 Thread Isaku Yamahata
move out pci internal structures, PCIBus, PCIBridge and pci_bus_info into private header file, pci_internals.h. This is a preparation. Later pci bridge implementation will be split out form pci.c into pci_bridge.c. Signed-off-by: Isaku Yamahata Signed-off-by: Michael S. Tsirkin --- hw/pci.c

[Qemu-devel] [PATCH] mips64el: fulong: PCI_DEVFN() clean up.

2010-07-26 Thread Isaku Yamahata
Use PCI_DEVFN() where appropriate. The resulted stripped binary remains same with/without thie patch. Cc: Huacai Chen Cc: Aurelien Jarno Signed-off-by: Isaku Yamahata --- hw/mips_fulong2e.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/mips_fulong2e.c

[Qemu-devel] [PATCH for master 2/3] pci_host: remove PCIHostState::busdev.

2010-07-26 Thread Isaku Yamahata
It is mostly unused expcet i440fx and bonito. So remove the member. Cc: Huacai Chen Cc: Aurelien Jarno Signed-off-by: Isaku Yamahata --- hw/bonito.c | 11 +++ hw/pci_host.h |1 - hw/piix_pci.c | 11 +++ 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/h

[Qemu-devel] [PATCH for master 3/3] pci/pci_host: pci host bus initialization clean up.

2010-07-26 Thread Isaku Yamahata
Embed PCIBus into PCIHostState and clean up of pci host bus initialization. And Embed PCIHostState into each devices. Especially pci host bus creation must be aware of pci segment, usually 0. Although some boards doesn't use PCIHostState at the moment, in long term enhance PCIHostState and convert

[Qemu-devel] [PATCH for master 0/3] pci, pcihost: pci host bus clean up

2010-07-26 Thread Isaku Yamahata
Changes for pci branch -> master tree: - rebased to master branch. - dropped bonito clean up.(will send it separately) - introduced "pci: move out pci internal structures" which is already commited to pci branch. but not into master tree. Isaku Yamahata (3): pci: move out pci internal structur

Re: [Qemu-devel] [PATCH 0/3] pci, pcihost: pci host bus clean up

2010-07-26 Thread Isaku Yamahata
On Tue, Jul 27, 2010 at 05:54:30AM +0200, Aurelien Jarno wrote: > On Mon, Jul 26, 2010 at 07:59:46PM +0900, Isaku Yamahata wrote: > > This patch set cleans up pci host bus initialization. > > This is for MST's pci branch. > > It also fixes bonito bugs which was found during tests. > > > > Isaku Ya

Re: [Qemu-devel] [PATCH 0/3] pci, pcihost: pci host bus clean up

2010-07-26 Thread Aurelien Jarno
On Mon, Jul 26, 2010 at 07:59:46PM +0900, Isaku Yamahata wrote: > This patch set cleans up pci host bus initialization. > This is for MST's pci branch. > It also fixes bonito bugs which was found during tests. > > Isaku Yamahata (3): > pci_host: remove PCIHostState::busdev. > pci/pci_host: pci

[Qemu-devel] Re: [PATCH 3/3] mips64el: fulong: fix pci multifunction bit

2010-07-26 Thread chen huacai
PCI_DEVFN() clean up parts is OK for me. On Tue, Jul 27, 2010 at 10:18 AM, Isaku Yamahata wrote: > Oh yes, I fixed it. I was lost during switching branches. > Chen, can you please take care of PCI_DEVFN() clean up part? > > > On Tue, Jul 27, 2010 at 09:10:02AM +0800, chen huacai wrote: >> Seems l

Re: [Qemu-devel] [RFC PATCH 02/14] KVM Test: Add a function get_interface_name() to kvm_net_utils.py

2010-07-26 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: > The function get_interface_name is used to get the interface name of linux > guest through the macaddress of specified macaddress. I wonder if it wouldn't be overkill to have separate utility libraries on the kvm test instead of a single kvm_ut

[Qemu-devel] Re: [RFC PATCH 01/14] KVM-test: Add a new macaddress pool algorithm

2010-07-26 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:34 +0800, Amos Kong wrote: > Old method uses the mac address in the configuration files which could > lead serious problem when multiple tests running in different hosts. > > This patch adds a new macaddress pool algorithm, it generates the mac prefix > based on mac addres

[Qemu-devel] Re: [SeaBIOS] [PATCH 2/2] seabios: pciinit: fix overflow when bar allocation.

2010-07-26 Thread Kevin O'Connor
On Mon, Jul 26, 2010 at 02:02:46PM +0900, Isaku Yamahata wrote: > When allocating bar, overflow can occur. > So add overflow check and don't allocate bar if overflowed. > Overflow check is ugly, but necessary. > Another suggested way is to change related variables u64 from u32 > thus overflow can't

[Qemu-devel] Re: [SeaBIOS] [PATCH 1/2] seabios: pciinit: fix 64bit bar initilization.

2010-07-26 Thread Kevin O'Connor
On Mon, Jul 26, 2010 at 02:02:45PM +0900, Isaku Yamahata wrote: > When 64bit bar allocation failed, leave it untouched as 32bit bar case. > There is no point to set higher bit to all 1, it is just leftover from > debug code. Thanks. -Kevin

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Jun Koi
On Mon, Jul 26, 2010 at 8:16 PM, malc wrote: > On Mon, 26 Jul 2010, Eliot Moss wrote: > >> On 7/26/2010 6:20 AM, Llu?s wrote: >> > Eduardo Cruz writes: >> > >> > > Thanks for your awnsers. Stean, after I find the right place to capture >> > > the >> > > reads and writes I'll definitely try your tr

[Qemu-devel] [PATCH v8 5/5] Inter-VM shared memory PCI device

2010-07-26 Thread Cam Macdonell
Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository. -device ivshmem,size=[,shm=] Interrupts are su

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-26 Thread Alex Williamson
On Mon, 2010-07-26 at 18:28 -0500, Anthony Liguori wrote: > On 07/26/2010 05:28 PM, Anthony Liguori wrote: > > On 07/26/2010 04:28 PM, Chris Wright wrote: > >> Please send in any agenda items you are interested in covering. > > > > - 0.13 update > > I'll pre-empt the 0.13 question with an answer.

[Qemu-devel] [PATCH v8 2/5] Device specification for shared memory PCI device

2010-07-26 Thread Cam Macdonell
Signed-off-by: Cam Macdonell --- docs/specs/ivshmem_device_spec.txt | 96 1 files changed, 96 insertions(+), 0 deletions(-) create mode 100644 docs/specs/ivshmem_device_spec.txt diff --git a/docs/specs/ivshmem_device_spec.txt b/docs/specs/ivshmem_device_

[Qemu-devel] [PATCH v8 4/5] Support marking a device as non-migratable

2010-07-26 Thread Cam Macdonell
A non-migratable device should be removed before migration and re-added after. Signed-off-by: Cam Macdonell --- hw/hw.h |2 ++ savevm.c | 44 +--- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index c2de6fe..28b42

[Qemu-devel] [PATCH v8 0/5] Inter-VM Shared Memory Device

2010-07-26 Thread Cam Macdonell
Latest patch for PCI shared memory device that maps a host shared memory object to be shared between guests new in this series v8 - rebased to qemu.git - added qemu_ram_alloc_from_ptr() function - removed irqfd support as support functions are not yet in qemu v7 - replace

[Qemu-devel] [PATCH v8 3/5] Add function to assign ioeventfd to MMIO.

2010-07-26 Thread Cam Macdonell
Signed-off-by: Cam Macdonell --- kvm-all.c | 32 kvm.h |1 + 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 7635f2f..d9a5dd0 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1241,6 +1241,38 @@ int kvm_set_signal_ma

[Qemu-devel] [PATCH v8 1/5] Add qemu_ram_alloc_from_ptr function

2010-07-26 Thread Cam Macdonell
Provide a function to add an allocated region of memory to the qemu RAM. This patch is copied from Marcelo's qemu_ram_map() in qemu-kvm and given the clearer name qemu_ram_alloc_from_ptr(). Signed-off-by: Cam Macdonell --- cpu-common.h |2 ++ exec.c | 43

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-26 Thread Anthony Liguori
On 07/26/2010 05:28 PM, Anthony Liguori wrote: On 07/26/2010 04:28 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - 0.13 update I'll pre-empt the 0.13 question with an answer. I'm just testing the VNC changes and if all goes well, I'll tag tonight.

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-26 Thread Anthony Liguori
On 07/26/2010 04:28 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - 0.13 update I'll pre-empt the 0.13 question with an answer. I'm just testing the VNC changes and if all goes well, I'll tag tonight. Initial thinking is to keep 0.14 short a

[Qemu-devel] sparc scsi/iommu/dma (was NMI handling)

2010-07-26 Thread Artyom Tarasenko
2010/7/26 Blue Swirl : > On Mon, Jul 26, 2010 at 4:53 PM, Artyom Tarasenko > wrote: >> 2010/6/21 Artyom Tarasenko : >>> 2010/5/25 Blue Swirl : >> About bugs, IIRC NetBSD 3.x crash could be related to IOMMU. > > What does indicate it? It happens where the disk sizes are normally > r

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Anthony Liguori
On 07/26/2010 04:46 PM, Cam Macdonell wrote: On Mon, Jul 26, 2010 at 2:41 PM, Anthony Liguori wrote: On 07/26/2010 03:27 PM, Avi Kivity wrote: On 07/26/2010 10:41 PM, Anthony Liguori wrote: kvm_set_irqfd() is fine, it just needs to be ported. It should be there due to vho

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Eduardo Cruz
> I define INSTR_MEM macro into a generation of a helper call, which will > receive > the run-time computed address. Could you share how did you do this? > If you'd also like to track pthreads and the like, you'll need some sort of > backdoor communication channel. Yes, I need to distinguish be

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Cam Macdonell
On Mon, Jul 26, 2010 at 2:41 PM, Anthony Liguori wrote: > On 07/26/2010 03:27 PM, Avi Kivity wrote: >> >>  On 07/26/2010 10:41 PM, Anthony Liguori wrote: >>> >>> kvm_set_irqfd() is fine, it just needs to be ported.  It should be there >>> due to vhost though? >>> >> >> It should, but isn't. >> >>>

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Lluís
Eduardo Cruz writes: > In the modification: >  Oh! BTW, my current prototype uses code like this on target-x86/translate.c: >> >>    #define tcg_gen_qemu_ld8u(arg, addr, mem_index)          \ >>        do {                                                 \ >>            INSTR_MEM(addr, 8);      

[Qemu-devel] KVM call agenda for July 27

2010-07-26 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Avi Kivity
On 07/26/2010 11:03 PM, Cam Macdonell wrote: Please add qemu_ram_map() as a separate patch to avoid interdependencies. Try to keep it at the same place etc., that will reduce merge difficulties later. qemu_ram_map() isn't my patch, Marcelo pushed it into qemu-kvm, so I dropped my version.

[Qemu-devel] qemu cp15 access

2010-07-26 Thread Raymes Khoury
I am having the problem with qemu, as described in the post http://old.nabble.com/-PATCH:-PR-target-42671--Use-Thumb1-GOT-address-loading-sequence-for--%09Thumb2-td27124497.html where accessing cp15 on ARM causes an error: qemu: fatal: cp15 insn ee1d2f70 R00= R01= R02= R03

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Anthony Liguori
On 07/26/2010 03:27 PM, Avi Kivity wrote: On 07/26/2010 10:41 PM, Anthony Liguori wrote: kvm_set_irqfd() is fine, it just needs to be ported. It should be there due to vhost though? It should, but isn't. qemu_ram_map() is more difficult. I would think the better approach would be to i

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Avi Kivity
On 07/26/2010 10:41 PM, Anthony Liguori wrote: kvm_set_irqfd() is fine, it just needs to be ported. It should be there due to vhost though? It should, but isn't. qemu_ram_map() is more difficult. I would think the better approach would be to invert things. Instead of a "give me a stab

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Anthony Liguori
On 07/26/2010 02:51 PM, Avi Kivity wrote: On 07/26/2010 10:01 PM, Cam Macdonell wrote: Is this against qemu.git or qemu-kvm.git? It depends on functions like qemu_ram_map() which are not present in qemu.git (and are present in qemu-kvm.git). It is against qemu-kvm.git. Is qemu_ram_map() go

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Avi Kivity
On 07/26/2010 11:16 PM, Cam Macdonell wrote: Marcelo's version is commit c15414b9 in qemu-kvm.git That appears to be a merge. Ah, the header changed in a merge, the original patch is commit 00d53f24. I'll pick it as part of my patch set as you suggest. Don't pick the patch, copy the cod

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Cam Macdonell
On Mon, Jul 26, 2010 at 2:11 PM, Avi Kivity wrote: >  On 07/26/2010 11:03 PM, Cam Macdonell wrote: >> >>> Please add qemu_ram_map() as a separate patch to avoid interdependencies. >>>  Try to keep it at the same place etc., that will reduce merge >>> difficulties >>> later. >> >> qemu_ram_map() is

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Anthony Liguori
On 07/26/2010 02:43 PM, Avi Kivity wrote: On 07/26/2010 10:35 PM, Anthony Liguori wrote: That's a bogus scenario because said evil distro would also enhance libvirt to detect the feature properly. That means a new libvirt release is needed. Which if you're a distro and you backport a KVM fe

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Cam Macdonell
On Mon, Jul 26, 2010 at 1:51 PM, Avi Kivity wrote: >  On 07/26/2010 10:01 PM, Cam Macdonell wrote: >> >>> Is this against qemu.git or qemu-kvm.git?  It depends on functions like >>> qemu_ram_map() which are not present in qemu.git (and are present in >>> qemu-kvm.git). >> >> It is against qemu-kvm

[Qemu-devel] [Bug 589564] Re: Windows host tap (tap-win32) is not working on QEMU ver 0.12.X

2010-07-26 Thread Ibrahim Umar
KP. Kang fix is working. But Lode Leroy fix is a more proper approach. I have tested the patch and confirm that the problem is now fixed using the provided patch. -- Windows host tap (tap-win32) is not working on QEMU ver 0.12.X https://bugs.launchpad.net/bugs/589564 You received this bug notifi

[Qemu-devel] Re: [PATCH] migration: Issue 'cont' only on successful incoming migration

2010-07-26 Thread Juan Quintela
Laine Stump wrote: > On 07/26/2010 10:23 AM, Luiz Capitulino wrote: >> On Sat, 24 Jul 2010 13:01:24 +0530 >> Amit Shah wrote: >> >>> On (Fri) Jul 23 2010 [15:08:18], Luiz Capitulino wrote: > diff --git a/monitor.c b/monitor.c > index 45fd482..d12a7b5 100644 > --- a/monitor.c > ++

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Avi Kivity
On 07/26/2010 10:01 PM, Cam Macdonell wrote: Is this against qemu.git or qemu-kvm.git? It depends on functions like qemu_ram_map() which are not present in qemu.git (and are present in qemu-kvm.git). It is against qemu-kvm.git. Is qemu_ram_map() going into qemu.git? Another function I use (

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Anthony Liguori
On 07/26/2010 02:01 PM, Cam Macdonell wrote: On Mon, Jul 26, 2010 at 7:48 AM, Anthony Liguori wrote: On 06/15/2010 03:23 PM, Cam Macdonell wrote: Latest patch for PCI shared memory device that maps a host shared memory object to be shared between guests Is this against qemu

[Qemu-devel] [PATCH 6/6] Initial documentation for migration

2010-07-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- docs/migration.txt | 303 1 files changed, 303 insertions(+), 0 deletions(-) create mode 100644 docs/migration.txt diff --git a/docs/migration.txt b/docs/migration.txt new file mode 100644 index 000..69d

[Qemu-devel] Re: [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Juan Quintela
Avi Kivity wrote: > On 07/26/2010 10:03 PM, Anthony Liguori wrote: >> On 07/26/2010 11:29 AM, Avi Kivity wrote: >>> On 07/26/2010 07:26 PM, Avi Kivity wrote: > The help output is *not* a supported interface. There is no supported, usable interface for this. >>> >>> Well actua

[Qemu-devel] [PATCH 1/6] Revert "ide save/restore pio/atapi cmd transfer fields and io buffer"

2010-07-26 Thread Juan Quintela
This reverts commit ed487bb1d69040b9dac64a4fc076d8dd82b131d6. The conflicts are due to commit 4fc8d6711aff7a9c11e402c3d77b481609f9f486 that is a fix to the ide_drive_pre_save() function. It reverts both (and both are reinstantiated later in the series) Conflicts: hw/ide/core.c Signed-o

[Qemu-devel] [PATCH 5/6] ide: fix migration in the middle of a bmdma transfer

2010-07-26 Thread Juan Quintela
It reintroduces Revert "ide save/restore pio/atapi cmd transfer fields and io buffer" but using subsections. Added bonus is the addition of ide_dummy_transfer_stop to transfer_end_table, that was missing. Signed-off-by: Juan Quintela --- hw/ide/pci.c | 30 ++

[Qemu-devel] [PATCH 3/6] vmstate: add subsections code

2010-07-26 Thread Juan Quintela
This commit adds subsections for each device section. Subsections is the way to handle information that don't need to be sent to de destination of a migration because its values are not needed. It is the way to handle optional information. Notice that only the source can decide if the information

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Avi Kivity
On 07/26/2010 10:35 PM, Anthony Liguori wrote: If you want libvirt to do the right thing, provide a proper capabilities interface. Using the version has its downsides as much as the help text. That's simply not the case. Please, provide an actual example where version is not reliable a

[Qemu-devel] [PATCH 4/6] ide: fix migration in the middle of pio operation

2010-07-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/ide/core.c | 90 - hw/ide/internal.h |5 +++ 2 files changed, 94 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index ccb7d32..db00083 100644 --- a/hw/ide/core.c +++ b/hw/

[Qemu-devel] [PATCH 2/6] Revert "ide save/restore current transfer fields"

2010-07-26 Thread Juan Quintela
This reverts commit 42ee76fe82093ba914f0dc83d2decbcf68866144. Signed-off-by: Juan Quintela --- hw/ide/pci.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 4d95cc5..780fc5f 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -123,7 +1

[Qemu-devel] [PATCH 0/6] [PATCH v2 0/6] Migration subsections (and ide as example)

2010-07-26 Thread Juan Quintela
v3: - spell checking documentation - s/[Qq]emu/QEMU/ v2: - add documentation - improve commit messages - remove debug printf's - rebase latest qemu v1: At the end, here is the migration subsections implementation. As an example I ported the last two ide changes to migration to work with subsec

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Anthony Liguori
On 07/26/2010 02:19 PM, Avi Kivity wrote: Is what we are supporting just what libvirt expects there to be or what any tool out there expects there to be? We should try to support all users, prioritized by the number of end users they represent. If this patch broke some other large user we'd

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Avi Kivity
On 07/26/2010 10:03 PM, Anthony Liguori wrote: On 07/26/2010 11:29 AM, Avi Kivity wrote: On 07/26/2010 07:26 PM, Avi Kivity wrote: The help output is *not* a supported interface. There is no supported, usable interface for this. Well actually, libvirt could probe this by starting qemu w

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Avi Kivity
On 07/26/2010 09:59 PM, Anthony Liguori wrote: If libvirt is going to parse -help output, they should do a better job at it. I can't expect QEMU developers to have detailed knowledge of how libvirt parses the help output to ensure that we don't break their code. Correct. libvirt could have

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Anthony Liguori
On 07/26/2010 11:29 AM, Avi Kivity wrote: On 07/26/2010 07:26 PM, Avi Kivity wrote: The help output is *not* a supported interface. There is no supported, usable interface for this. Well actually, libvirt could probe this by starting qemu with cache=x for various x and seeing if it break

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Cam Macdonell
On Mon, Jul 26, 2010 at 7:48 AM, Anthony Liguori wrote: > On 06/15/2010 03:23 PM, Cam Macdonell wrote: >> >> Latest patch for PCI shared memory device that maps a host shared memory >> object >> to be shared between guests >> > > Is this against qemu.git or qemu-kvm.git?  It depends on functions l

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Anthony Liguori
On 07/26/2010 11:54 AM, Avi Kivity wrote: Older versions of libvirt aren't a problem, they simply don't know about cache=unsafe. Let's be clear what's happening here. QEMU produces: " [,cache=writethrough|writeback|unsafe|none][,format=f]\n" Which is completely reasonable from a

[Qemu-devel] Re: NMI handling

2010-07-26 Thread Blue Swirl
On Mon, Jul 26, 2010 at 4:53 PM, Artyom Tarasenko wrote: > 2010/6/21 Artyom Tarasenko : >> 2010/5/25 Blue Swirl : > About bugs, IIRC NetBSD 3.x crash could be related to IOMMU. What does indicate it? It happens where the disk sizes are normally reported, so it could be a scsi/dm

[Qemu-devel] Re: [PATCH 4/7] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Anthony Liguori
Hi Kevin, There's an on-going discussion on this patch. Could you drop it from your pull request but leave it in your tree until the discussion is resolved? Thanks, Anthony Liguori On Jul 26, 2010 9:01 AM, "Kevin Wolf" wrote: From: Bruce Rogers Libvirt parses qemu help output to determine

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Eduardo Cruz
In the modification:  Oh! BTW, my current prototype uses code like this on target-x86/translate.c: > >    #define tcg_gen_qemu_ld8u(arg, addr, mem_index)          \ >        do {                                                 \ >            INSTR_MEM(addr, 8);                              \ >    

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Avi Kivity
On 07/26/2010 07:26 PM, Avi Kivity wrote: The help output is *not* a supported interface. There is no supported, usable interface for this. Well actually, libvirt could probe this by starting qemu with cache=x for various x and seeing if it breaks. But the milk has already been spilled.

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Avi Kivity
On 07/26/2010 07:40 PM, Anthony Liguori wrote: On 07/26/2010 11:26 AM, Avi Kivity wrote: I'm a practical guy, and I don't see that it's a huge burden for libvirt to detect downstreams and build a feature matrix based on versions. If someone demonstrates that it's infeasible, I'll happily rec

[Qemu-devel] Re: NMI handling

2010-07-26 Thread Artyom Tarasenko
2010/6/21 Artyom Tarasenko : > 2010/5/25 Blue Swirl : About bugs, IIRC NetBSD 3.x crash could be related to IOMMU. >>> >>> What does indicate it? It happens where the disk sizes are normally >>> reported, so it could be a scsi/dma/irq/fpu issue as well. >> >> IIRC the DVMA address was 0xfc0040

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Anthony Liguori
On 07/26/2010 11:26 AM, Avi Kivity wrote: I'm a practical guy, and I don't see that it's a huge burden for libvirt to detect downstreams and build a feature matrix based on versions. If someone demonstrates that it's infeasible, I'll happily reconsider. It generates a dependency. If the do

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Avi Kivity
On 07/26/2010 06:53 PM, Anthony Liguori wrote: You almost sound like Dan refused to consider anything but parsing help output, like it were Dan's fault that QEMU still doesn't provide a usable interface for querying its capabilities, and like the way to get it was to put more pressure on Dan.

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Anthony Liguori
On 07/23/2010 03:00 AM, Markus Armbruster wrote: Anthony Liguori writes: On 07/22/2010 03:42 AM, Daniel P. Berrange wrote: On Wed, Jul 21, 2010 at 06:39:32PM -0500, Anthony Liguori wrote: [...] If a distro backports a feature, it should change the QEMU version string.

[Qemu-devel] Re: [PATCH] migration: Issue 'cont' only on successful incoming migration

2010-07-26 Thread Laine Stump
On 07/26/2010 10:23 AM, Luiz Capitulino wrote: On Sat, 24 Jul 2010 13:01:24 +0530 Amit Shah wrote: On (Fri) Jul 23 2010 [15:08:18], Luiz Capitulino wrote: diff --git a/monitor.c b/monitor.c index 45fd482..d12a7b5 100644 --- a/monitor.c +++ b/monitor.c @@ -1056,6 +1056,10 @@ static int do_con

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Yufei Chen
On Mon, Jul 26, 2010 at 6:20 PM, Lluís wrote: > Eduardo Cruz writes: > >> Thanks for your awnsers. Stean, after I find the right place to capture the >> reads and writes I'll definitely try your trace tool. > >> Until now, this is what i found: > >> I am using the x86-64 target, and I know that, f

[Qemu-devel] Re: [PATCH] migration: Issue 'cont' only on successful incoming migration

2010-07-26 Thread Luiz Capitulino
On Sat, 24 Jul 2010 13:01:24 +0530 Amit Shah wrote: > On (Fri) Jul 23 2010 [15:08:18], Luiz Capitulino wrote: > > > diff --git a/monitor.c b/monitor.c > > > index 45fd482..d12a7b5 100644 > > > --- a/monitor.c > > > +++ b/monitor.c > > > @@ -1056,6 +1056,10 @@ static int do_cont(Monitor *mon, cons

[Qemu-devel] [PATCH 7/7] Fix -snapshot deleting images on disk change

2010-07-26 Thread Kevin Wolf
From: Blue Swirl Block device change command did not copy BDRV_O_SNAPSHOT flag. Thus the new image did not have this flag and the file got deleted during opening. Fix by copying BDRV_O_SNAPSHOT flag. Signed-off-by: Blue Swirl Signed-off-by: Kevin Wolf --- block.c|5 + block.h

[Qemu-devel] [PATCH 4/7] move 'unsafe' to end of caching modes in help

2010-07-26 Thread Kevin Wolf
From: Bruce Rogers Libvirt parses qemu help output to determine qemu features. In particular it probes for the following: "cache=writethrough|writeback|none". The addition of the unsafe cache mode was inserted within this string, as opposed to being added to the end, which impacted libvirt's prob

[Qemu-devel] [PATCH 5/7] block: default to 0 minimal / optiomal I/O size

2010-07-26 Thread Kevin Wolf
From: Christoph Hellwig Currently we set them to 512 bytes unless manually specified. Unforuntaly some brain-dead partitioning tools create unaligned partitions if they get low enough optiomal I/O size values, so don't report any at all unless explicitly set. Signed-off-by: Christoph Hellwig S

[Qemu-devel] [PATCH 3/7] virtio-blk: Create exit function to unregister savevm

2010-07-26 Thread Kevin Wolf
From: Alex Williamson Otherwise we can't migrate after we've removed a virtio block device. Signed-off-by: Alex Williamson Signed-off-by: Kevin Wolf --- hw/virtio-blk.c |8 hw/virtio-pci.c |1 + hw/virtio.h |1 + 3 files changed, 10 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 6/7] block: Use error codes from lower levels for error message

2010-07-26 Thread Kevin Wolf
From: Stefan Weil "No such file or directory" is a misleading error message when a user tries to open a file with wrong permissions. Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block.c | 27 +++ 1 files changed, 19 insertions(+), 8 deleti

[Qemu-devel] [PATCH 2/7] block migration: propagate return value when bdrv_write() returns < 0

2010-07-26 Thread Kevin Wolf
From: Yoshiaki Tamura Currently block_load() doesn't check return value of bdrv_write(), and even the destination weren't prepared to execute block migration, it proceeds and guest boots on the target. This patch fix this issue. Signed-off-by: Yoshiaki Tamura Signed-off-by: Kevin Wolf --- bl

[Qemu-devel] [PULL 0/7] Block patches

2010-07-26 Thread Kevin Wolf
Some more fixes for 0.13. The following changes since commit cdcf9153e5e17dde340135fee5dcc7c299f2d4f5: etrax: Update ethernet mgm-ctrl reg on writes (2010-07-25 21:03:56 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Alex Williamson (1): vir

[Qemu-devel] [PATCH 1/7] ide/atapi: add support for GET EVENT STATUS NOTIFICATION

2010-07-26 Thread Kevin Wolf
From: Aurelien Jarno The GET EVENT STATUS NOTIFICATION is a mandatory command according to MMC-3, even if event status notification is not supported. This patch adds support for this command. It returns NEA ("No Event Available") with an empty "Supported Event Classes" to show that it doesn't ev

[Qemu-devel] [PATCH] Create USB buses and devices based on USB version.

2010-07-26 Thread David Ahern
Create USB buses and devices based on USB version. This addresses addresses a number of FIXME's by assigning USB devices to a specific bus. t is also groundwork for adding ehci. Signed-off-by: David Ahern --- hw/usb-bus.c| 70 --- hw/usb

Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device

2010-07-26 Thread Anthony Liguori
On 06/15/2010 03:23 PM, Cam Macdonell wrote: Latest patch for PCI shared memory device that maps a host shared memory object to be shared between guests Is this against qemu.git or qemu-kvm.git? It depends on functions like qemu_ram_map() which are not present in qemu.git (and are present

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Lluís
malc writes: >> > 2) instrumentation: a set of generic macros that signal events that might >> > be >> > of >> > interest. >> >> Etc. >> >> In the context of another simulator, we developed a different >> technique, which would be quite general and might be of interest >> for QEMU. We comm

[Qemu-devel] Re: [PATCH 2/3] pci/pci_host: pci host bus initialization clean up.

2010-07-26 Thread Michael S. Tsirkin
> +/* > + * TODO: there remains some boards which doesn't use PCIHostState. > + * Enhance PCIHostState API and convert remaining boards. I think I remember this comment from Paul: On Tuesday 12 January 2010, Isaku Yamahata wrote: > To use pci host framework, use PCIHostState

[Qemu-devel] Re: [PATCH] block migration: replace tabs by spaces.

2010-07-26 Thread Kevin Wolf
Am 26.07.2010 06:25, schrieb Yoshiaki Tamura: > Signed-off-by: Yoshiaki Tamura Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread malc
On Mon, 26 Jul 2010, Eliot Moss wrote: > On 7/26/2010 6:20 AM, Llu?s wrote: > > Eduardo Cruz writes: > > > > > Thanks for your awnsers. Stean, after I find the right place to capture > > > the > > > reads and writes I'll definitely try your trace tool. > > > > > Until now, this is what i found:

[Qemu-devel] [PATCH 3/3] mips64el: fulong: fix pci multifunction bit

2010-07-26 Thread Isaku Yamahata
This patch fixes multifunction bits of bonito. Otherwise it aborts with the following message. > qemu-system-mips64el: PCI: single function device can't be populated in > function 5.1 Cc: Huacai Chen Cc: Aurelien Jarno Signed-off-by: Isaku Yamahata --- hw/mips_fulong2e.c | 14 +++--

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Eliot Moss
On 7/26/2010 6:20 AM, Lluís wrote: Eduardo Cruz writes: Thanks for your awnsers. Stean, after I find the right place to capture the reads and writes I'll definitely try your trace tool. Until now, this is what i found: I am using the x86-64 target, and I know that, for instance, lots of r

[Qemu-devel] [PATCH 2/3] pci/pci_host: pci host bus initialization clean up.

2010-07-26 Thread Isaku Yamahata
Embed PCIBus into PCIHostState and clean up of pci host bus initialization. And Embed PCIHostState into each devices. Especially pci host bus creation must be aware of pci segment, usually 0. Although some boards doesn't use PCIHostState at the moment, in long term enhance PCIHostState and convert

[Qemu-devel] [PATCH 1/3] pci_host: remove PCIHostState::busdev.

2010-07-26 Thread Isaku Yamahata
It is mostly unused expcet i440fx and bonito. So remove the member. Cc: Huacai Chen Cc: Aurelien Jarno Signed-off-by: Isaku Yamahata --- hw/bonito.c | 13 - hw/pci_host.h |1 - hw/piix_pci.c | 11 +++ 3 files changed, 15 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 0/3] pci, pcihost: pci host bus clean up

2010-07-26 Thread Isaku Yamahata
This patch set cleans up pci host bus initialization. This is for MST's pci branch. It also fixes bonito bugs which was found during tests. Isaku Yamahata (3): pci_host: remove PCIHostState::busdev. pci/pci_host: pci host bus initialization clean up. mips64el: fulong: fix pci multifunction b

Re: [Qemu-devel] memory trace with qemu

2010-07-26 Thread Lluís
Eduardo Cruz writes: > Thanks for your awnsers. Stean, after I find the right place to capture the > reads and writes I'll definitely try your trace tool. > Until now, this is what i found: > I am using the x86-64 target, and I know that, for instance, lots of reads > pass here: > target-i386/t

Re: [Qemu-devel] Old DGUX Machine and Adaptec SCSI PCI Controller

2010-07-26 Thread Artyom Tarasenko
2010/7/25 DG UX : > Hello all, > > We have an old DG/UX machine (2 actually), in production use (scary, I > know). > These days I am trying to virtualize/emulate those machines. As we cannot > upgrade / reinstall the applications on a different platfrom, I am trying to > boot it up (DD'ed all the d

Re: [Qemu-devel] Old DGUX Machine and Adaptec SCSI PCI Controller

2010-07-26 Thread Jes Sorensen
On 07/25/10 21:39, Avi Kivity wrote: > On 07/25/2010 04:08 PM, DG UX wrote: >> >> Currently, these DGUX machines only support Qlogic and Adaptec, no IDE >> whatsoever and no LSI. >> Any way Qemu will support anything like that? >> >> I got to know these DGUX machines very well, and know all the lo

Re: [Qemu-devel] Old DGUX Machine and Adaptec SCSI PCI Controller

2010-07-26 Thread DG UX
It's an AIC-7880 CHIP On Mon, Jul 26, 2010 at 12:43 PM, Jes Sorensen wrote: > On 07/25/10 21:39, Avi Kivity wrote: > > On 07/25/2010 04:08 PM, DG UX wrote: > >> > >> Currently, these DGUX machines only support Qlogic and Adaptec, no IDE > >> whatsoever and no LSI. > >> Any way Qemu will support

[Qemu-devel] [Bug 587993] Re: qemu-kvm 0.12.4+dfsg-1 from debian squeeze crashes "BUG: unable to handle kernel NULL pointer" (sym53c8xx)

2010-07-26 Thread Jes Sorensen
Looks like the SCSI driver is causing problems. QEMU's SCSI emulation is known to be broken, please use IDE or virtio-blk. Jes -- qemu-kvm 0.12.4+dfsg-1 from debian squeeze crashes "BUG: unable to handle kernel NULL pointer" (sym53c8xx) https://bugs.launchpad.net/bugs/587993 You received this

[Qemu-devel] Re: [PATCH] vhost_dev_unassign_memory() don't assert if removing first entry in list.

2010-07-26 Thread Michael S. Tsirkin
On Mon, Jul 26, 2010 at 08:49:19AM +0200, Jes Sorensen wrote: > On 07/24/10 21:03, Michael S. Tsirkin wrote: > > On Fri, Jul 23, 2010 at 05:16:42PM +0200, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen > >> diff --git a/hw/vhost.c b/hw/vhost.c > >> index d37a66e..f30cf91 100644 > >> --- a/

Re: [Qemu-devel] [PATCH] Fix -snapshot deleting images on disk change

2010-07-26 Thread Kevin Wolf
Am 25.07.2010 22:49, schrieb Blue Swirl: > Block device change command did not copy BDRV_O_SNAPSHOT flag. Thus > the new image did not have this flag and the file got deleted during > opening. > > Fix by copying BDRV_O_SNAPSHOT flag. > > Signed-off-by: Blue Swirl Thanks, applied to the block br

[Qemu-devel] Re: [PATCH] block: Use error codes from lower levels for error message

2010-07-26 Thread Kevin Wolf
Am 21.07.2010 21:51, schrieb Stefan Weil: > "No such file or directory" is a misleading error message > when a user tries to open a file with wrong permissions. > > v2: return an 0/-errno int and pass the BlockDriver* by reference > as suggested by Kevin Wolf > > Cc: Kevin Wolf > Signed-off-