Re: [Qemu-devel] compile qemu

2010-08-15 Thread Stefan Hajnoczi
On Sun, Aug 15, 2010 at 5:17 AM, chandra shekar chandrashekar...@gmail.com wrote: how to compile qemu using gcc when i compile it is giving so many errors,thank you In order to get help you need to post the build output (compiler error messages) and you gcc version. Also see the Latest version

Re: [Qemu-devel] [PATCH 1/5] CODING_STYLE: add preprocessor rules

2010-08-15 Thread Blue Swirl
On Sat, Aug 14, 2010 at 2:27 PM, Andreas Färber andreas.faer...@web.de wrote: Am 13.08.2010 um 18:56 schrieb Blue Swirl: +Use parenthesis when checking if a macro is defined, and use +indentation to track nesting: + +#if defined(HAVE_POSIX_FALLOCATE) !defined(HAVE_FALLOCATE) +# define

Re: [Qemu-devel] [PATCH 1/5] CODING_STYLE: add preprocessor rules

2010-08-15 Thread Andreas Färber
Am 15.08.2010 um 09:46 schrieb Blue Swirl: On Sat, Aug 14, 2010 at 2:27 PM, Andreas Färber andreas.faer...@web.de wrote: While indentation is nice to read, it is patch-unfriendly. Consider: #ifdef SOMETHINGNEW yay #else // previous stuff follows #if defined(OLDONE) # define one #endif foo

[Qemu-devel] MegaSAS 8708EM2 qemu-kvm.git tree updated to v0.12.5

2010-08-15 Thread Nicholas A. Bellinger
Greetings Hannes, hch and Co, The lastest code from upstream qemu-kvm.git v0.12.5 has been merged into the megasas HBA emulation friendly qemu-kvm.git/master and scsi-bsg branches at: http://git.kernel.org/?p=virt/kvm/nab/qemu-kvm.git;a=summary The merge commitdiffs for master and scsi-bsg can

Re: [Qemu-devel] [PATCH 1/2] RESEND: Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

2010-08-15 Thread Blue Swirl
Thanks, applied. On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell c...@cs.ualberta.ca wrote: Signed-off-by: Cam Macdonell c...@cs.ualberta.ca ---  kvm-stub.c |    5 +  1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 3378bd3..d45f9fa 100644

Re: [Qemu-devel] [PATCH 2/2] RESEND: Disable build of ivshmem on non-KVM systems

2010-08-15 Thread Blue Swirl
Thanks, applied. On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell c...@cs.ualberta.ca wrote: Signed-off-by: Cam Macdonell c...@cs.ualberta.ca ---  Makefile.target |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-15 Thread Blue Swirl
Thanks, applied both. On Wed, Aug 11, 2010 at 7:37 PM, Stefan Weil w...@mail.berlios.de wrote: Am 11.08.2010 21:19, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 6:51 PM, Blue Swirlblauwir...@gmail.com  wrote: On Wed, Aug 11, 2010 at 6:18 PM, Stefan Weilw...@mail.berlios.de  wrote: Am

[Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization

2010-08-15 Thread Blue Swirl
On Fri, Aug 13, 2010 at 8:29 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/8/6 Artyom Tarasenko atar4q...@googlemail.com: 2010/8/2 Artyom Tarasenko atar4q...@googlemail.com: Btw, it would be nice to get this patch applied for 0.13: it's a pure fix, and it allows running the OBP

[Qemu-devel] [PATCH] target-i386: svm: Fix MSRPM check

2010-08-15 Thread Adam Lackorzynski
Correct the calculation of the offset in the msrpm for the MSR range 0 - 0x1fff. Signed-off-by: Adam Lackorzynski a...@os.inf.tu-dresden.de --- target-i386/op_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c

[Qemu-devel] [PATCH] sparc escc IUS improvements (SunOS 4.1.4 fix)

2010-08-15 Thread Artyom Tarasenko
According to scc_escc_um.pdf: - Reset Highest IUS must update irq status to allow processing of the next priority interrupt. - rx interrupt has always higher priority than tx on same channel The documentation only explicitly says that Reset Highest IUS command (0x38) clears IUS bits, not

[Qemu-devel] Re: [PATCH 08/15] xen: Read and write the state of the VM in xenstore

2010-08-15 Thread Paolo Bonzini
On 08/13/2010 02:53 PM, Anthony Liguori wrote: On 08/12/2010 09:09 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Introduce functions to read and write the state of the VM in xenstore. This basically creates a new management interface for QEMU via

[Qemu-devel] Re: [PATCH 0/5] CODING_STYLE amendments

2010-08-15 Thread Paolo Bonzini
On 08/12/2010 02:56 PM, malc wrote: On Thu, 12 Aug 2010, Blue Swirl wrote: Add a few rules, based loosely on libvirt HACKING. Blue Swirl (5): CODING_STYLE: add preprocessor rules CODING_STYLE: add C type rules CODING_STYLE: add memory management rules CODING_STYLE: add string

[Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-15 Thread Paolo Bonzini
On 08/14/2010 10:52 AM, Andreas Färber wrote: Well, this is not coding style but architectural guide. We could introduce a new document, rename CODING_STYLE or bury this to qemu-tech.texi. But I still (optimistically) think that some kind of READ_ME_BEFORE_CODING would help. I agree that we

[Qemu-devel] Re: [qemu-kvm] build fail on i386 RHEL5u4

2010-08-15 Thread Avi Kivity
On 08/11/2010 04:49 AM, Hao, Xudong wrote: Hi, Recently I build qemu-kvm on 32bit RHEL5u4/RHEL5u5, it will fail on fuction vhost_dev_sync_region. But RHEL5u1 system is fine to build. Did anyone meet similar issue? qemu-kvm commit: 59d71ddb432db04b57ee2658ce50a3e35d7db97e build error: ...

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-15 Thread Avi Kivity
On 08/14/2010 12:01 AM, malc wrote: This is all perfectly reasonable, but begs one question, where do we stop codifying self-evident truths (or who is the ultimiate judge of what is self-evident and what isn't), since taking the above to extreme we will end up adding stuff like: you must use

[Qemu-devel] [RFC] usb-ccid: add smart card reader CCID usb device

2010-08-15 Thread Alon Levy
Hi, This patch adds a usb CCID device, a common standard for smart cards that is supported by linux and windows (and probably others that I didn't test). It is intended to be used by SPICE and RHEV-M, but of course it is valuable independently from those. Uses include usage of client smartcard

[Qemu-devel] [PATCH 1/2] Split region allocation code from pci_bios_init_device()

2010-08-15 Thread Eduard - Gabriel Munteanu
pci_bios_alloc() can be used to allocate space in the PCI region for other purposes. This is needed by the AMD IOMMU support code. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- src/pciinit.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 2/2] AMD IOMMU support

2010-08-15 Thread Eduard - Gabriel Munteanu
This initializes the AMD IOMMU and creates ACPI tables for it. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- Makefile |2 +- src/acpi.c | 79 src/iommu.c| 64

[Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-08-15 Thread Eduard - Gabriel Munteanu
PCI devices should access memory through pci_memory_*() instead of cpu_physical_memory_*(). This also provides support for translation and access checking in case an IOMMU is emulated. Memory maps are treated as remote IOTLBs (that is, translation caches belonging to the IOMMU-aware device

[Qemu-devel] [PATCH 7/7] ac97: use the PCI memory access interface

2010-08-15 Thread Eduard - Gabriel Munteanu
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/ac97.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 4319bc8..9ee4894 100644 --- a/hw/ac97.c +++

[Qemu-devel] [PATCH 5/7] rtl8139: use the PCI memory access interface

2010-08-15 Thread Eduard - Gabriel Munteanu
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/rtl8139.c | 99 - 1 files changed, 56 insertions(+), 43 deletions(-) diff --git a/hw/rtl8139.c

[Qemu-devel] [PATCH 1/7] pci: add range_covers_range()

2010-08-15 Thread Eduard - Gabriel Munteanu
This helper function allows map invalidation code to determine which maps must be invalidated. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/pci.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index

[Qemu-devel] [PATCH 6/7] eepro100: use the PCI memory access interface

2010-08-15 Thread Eduard - Gabriel Munteanu
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/eepro100.c | 78 ++--- 1 files changed, 41 insertions(+), 37 deletions(-) diff --git a/hw/eepro100.c

[Qemu-devel] [PATCH 0/7] AMD IOMMU emulation patches v3

2010-08-15 Thread Eduard - Gabriel Munteanu
Hi, Please have a look at these and merge if you wish. I hope I've addressed the issues people have raised. Some changes from the previous RFC: - included and updated the other two device patches - moved map registration and invalidation management into PCI code - AMD IOMMU emulation is always

[Qemu-devel] [PATCH 3/7] AMD IOMMU emulation

2010-08-15 Thread Eduard - Gabriel Munteanu
This introduces emulation for the AMD IOMMU, described in AMD I/O Virtualization Technology (IOMMU) Specification. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- Makefile.target |2 + hw/amd_iommu.c | 688 +++

[Qemu-devel] [PATCH 3/5] HACKING: add memory management rules

2010-08-15 Thread Blue Swirl
Add memory management rules, somewhat like libvirt HACKING. Signed-off-by: Blue Swirl blauwir...@gmail.com --- HACKING | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/HACKING b/HACKING index 7c6b49e..e0342df 100644 --- a/HACKING +++ b/HACKING @@ -68,3 +68,14

[Qemu-devel] [PATCH 4/7] ide: use the PCI memory access interface

2010-08-15 Thread Eduard - Gabriel Munteanu
Emulated PCI IDE controllers now use the memory access interface. This also allows an emulated IOMMU to translate and check accesses. Map invalidation results in cancelling DMA transfers. Since the guest OS can't properly recover the DMA results in case the mapping is changed, this is a fairly

[Qemu-devel] [PATCH v2 0/5] Introduce HACKING

2010-08-15 Thread Blue Swirl
Create a new file HACKING and add a few rules. Blue Swirl (5): HACKING: add preprocessor rules HACKING: add C type rules HACKING: add memory management rules HACKING: add string management rules HACKING: add rules for printf-like functions CODING_STYLE |3 - HACKING | 118

[Qemu-devel] [PATCH 1/5] HACKING: add preprocessor rules

2010-08-15 Thread Blue Swirl
Add a new file, HACKING, in order to collect recurring issues with submitted patches. Start with preprocessor rules, adapted from libvirt HACKING. Signed-off-by: Blue Swirl blauwir...@gmail.com --- HACKING |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) create mode 100644

Re: [Qemu-devel] Re: Latest version in Git doesn't link - any ideas?

2010-08-15 Thread Nigel Horne
On 15/08/10 00:44, Cam Macdonell wrote: Yup, it was my patch. Sorry about that. Patches are in the list, just need to be merged. It works now - thanks! Cam -Nigel

Re: [Qemu-devel] [PATCH 7/7] ac97: use the PCI memory access interface

2010-08-15 Thread malc
On Sun, 15 Aug 2010, Eduard - Gabriel Munteanu wrote: This allows the device to work properly with an emulated IOMMU. Fine with me. [..snip..] -- mailto:av1...@comtv.ru

[Qemu-devel] [PATCH 5/5] HACKING: add rules for printf-like functions

2010-08-15 Thread Blue Swirl
Add rules for printf-like functions, based on libvirt HACKING. Signed-off-by: Blue Swirl blauwir...@gmail.com --- HACKING | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/HACKING b/HACKING index 54bd2fd..8e2a298 100644 --- a/HACKING +++ b/HACKING @@ -103,3

[Qemu-devel] [PATCH 4/5] HACKING: add string management rules

2010-08-15 Thread Blue Swirl
Add string management rules, somewhat like libvirt HACKING. Signed-off-by: Blue Swirl blauwir...@gmail.com --- HACKING | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/HACKING b/HACKING index e0342df..54bd2fd 100644 --- a/HACKING +++ b/HACKING @@

[Qemu-devel] [PATCH 2/5] HACKING: add C type rules

2010-08-15 Thread Blue Swirl
Add C type rules, adapted from libvirt HACKING. Also include a description of special QEMU scalar types. Move typedef rule from CODING_STYLE rule 3 to HACKING rule 6 where it belongs. Signed-off-by: Blue Swirl blauwir...@gmail.com --- CODING_STYLE |3 -- HACKING | 64

[Qemu-devel] Re: [PATCH 1/5] HACKING: add preprocessor rules

2010-08-15 Thread Andreas Schwab
Blue Swirl blauwir...@gmail.com writes: +For variadic macros, stick with C99 syntax: + +#define DPRINTF(fmt, ...) \ +do { printf(IRQ: fmt, ## __VA_ARGS__); } while (0) That's not C99 syntax, the combination with ## is a gcc extension. In C99 you

Re: [Qemu-devel] [PATCH 2/5] HACKING: add C type rules

2010-08-15 Thread Anthony Liguori
Hi Blue, Thanks for putting this document together. It should be quiet helpful! On 08/15/2010 12:50 PM, Blue Swirl wrote: Add C type rules, adapted from libvirt HACKING. Also include a description of special QEMU scalar types. Move typedef rule from CODING_STYLE rule 3 to HACKING rule 6

[Qemu-devel] [Bug 510612] Re: sound broken in qemu 0.12.x

2010-08-15 Thread Michael Tokarev
Isn't it the case that's fixed by commit d9812b033a17c82f9e933757c1c3ef364e3ba62d as shown in http://comments.gmane.org/gmane.comp.emulators.qemu/72593 which is actually this very bugreport mirrored to qemu-devel mailinglist? -- sound broken in qemu 0.12.x https://bugs.launchpad.net/bugs/510612

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-15 Thread Anthony Liguori
On 08/11/2010 11:34 AM, Blue Swirl wrote: On Wed, Aug 11, 2010 at 10:58 AM, Stefan Weilw...@mail.berlios.de wrote: Hi, since several months, QEMU for Windows (and mingw32 cross builds) no longer builds without error. Not true for mingw32, it was building fine here until the latest

[Qemu-devel] RE: [qemu-kvm] build fail on i386 RHEL5u4

2010-08-15 Thread Hao, Xudong
Avi Kivity wrote: On 08/11/2010 04:49 AM, Hao, Xudong wrote: Hi, Recently I build qemu-kvm on 32bit RHEL5u4/RHEL5u5, it will fail on fuction vhost_dev_sync_region. But RHEL5u1 system is fine to build. Did anyone meet similar issue? qemu-kvm commit:

[Qemu-devel] Re: [PATCH 0/7] AMD IOMMU emulation patches v3

2010-08-15 Thread Anthony Liguori
On 08/15/2010 02:27 PM, Eduard - Gabriel Munteanu wrote: Hi, Please have a look at these and merge if you wish. I hope I've addressed the issues people have raised. It's looking pretty good so far. I'm very happy with the modifications to the PCI layer. It looks like given the helpers