Re: [Qemu-devel] [PATCH] Avoid exit in trap as it breaks with some shells

2010-09-25 Thread Blue Swirl
Thanks, applied. Please remember to add the Signed-off-line. On Sat, Sep 25, 2010 at 7:52 PM, Loïc Minier wrote: > Don't call exit in the trap handler as it causes the return code to be > zero with some buggy shells (dash and pdksh at least) and is useless > here anyway. > --- >  configure |    4

Re: [Qemu-devel] Re: [PATCH] i386 debugging stubs: Consider segment bases

2010-09-25 Thread Jan Kiszka
Am 25.09.2010 10:35, Eddie Kohler wrote: > Thanks for the response. I agree the patch is a workaround, but it is a > useful workaround, and I'd still argue for including it. Nope, sorry, I have to vote against this. > > The patch doesn't *require* that CS.base == DS.base. Breakpoints It does.

Re: [Qemu-devel] Re: Problem with virtio

2010-09-25 Thread Frans de Boer
On 09/21/2010 01:15 AM, Frans de Boer wrote: > On 09/20/2010 11:19 PM, Vadim Rozenfeld wrote: > >> On Mon, 2010-09-20 at 22:22 +0200, Frans de Boer wrote: >> >> >>> On 09/20/2010 07:46 PM, Michael S. Tsirkin wrote: >>> >>> On Sun, Sep 19, 2010 at 11:13:16PM +0200, Frans

[Qemu-devel] [Bug 647793] [NEW] tap-bsd.c has no test for Mac OS X

2010-09-25 Thread Ted Lemon
Public bug reported: The Mac OS X tun/tap driver is equivalent to the FreeBSD driver, but bsd-tap.c uses the NetBSD/OpenBSD driver, which works differently. The fix is easy--just check for __APPLE__ in the same place where you check for FreeBSD in net/tap-bsd.c. This problem exists in the curre

[Qemu-devel] [Bug 647793] Re: tap-bsd.c has no test for Mac OS X

2010-09-25 Thread Ted Lemon
** Patch added: "tap-bsd.diff" https://bugs.launchpad.net/bugs/647793/+attachment/1636699/+files/tap-bsd.diff -- tap-bsd.c has no test for Mac OS X https://bugs.launchpad.net/bugs/647793 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

[Qemu-devel] [PATCH] Avoid exit in trap as it breaks with some shells

2010-09-25 Thread Loïc Minier
Don't call exit in the trap handler as it causes the return code to be zero with some buggy shells (dash and pdksh at least) and is useless here anyway. --- configure |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 3bfc5e9..9d3acfc 100755 ---

[Qemu-devel] eepro100 multicast

2010-09-25 Thread Dunc
Hi all, I've been trying to set up some olives running inside qemu to practice for Juniper exam. I came across the multicast issue when enabling VRRP After lots of googling and reading forums, where people have being doing hacky patches, I found a page that suggests this has been fixed now, just

Re: [Qemu-devel] [PATCH] Some tweaks to make some features only built-in when necessary

2010-09-25 Thread Brian Jackson
On 9/25/2010 3:27 AM, Blue Swirl wrote: On Fri, Sep 24, 2010 at 9:10 PM, Brian Jackson wrote: In trying to make the qemu binary size smaller, I've come across some things that can be left out of the binary without affecting the binary working. I've got more patches in the pipeline but the more

[Qemu-devel] Re: virtio-blk XFS corruption

2010-09-25 Thread Peter Lieven
Am 25.09.2010 um 17:58 schrieb Christoph Hellwig: > On Sat, Sep 25, 2010 at 05:40:34PM +0200, Peter Lieven wrote: >> >> Am 25.09.2010 um 17:37 schrieb Christoph Hellwig: >> >>> FYI, qemu 0.12.2 is missing: >> >> you mean 0.12.4 not 0.12.2, don't you? > > Yes, sorry. (but 0.12.2 is of course m

[Qemu-devel] Re: virtio-blk XFS corruption

2010-09-25 Thread Peter Lieven
Am 25.09.2010 um 17:58 schrieb Christoph Hellwig: > On Sat, Sep 25, 2010 at 05:40:34PM +0200, Peter Lieven wrote: >> >> Am 25.09.2010 um 17:37 schrieb Christoph Hellwig: >> >>> FYI, qemu 0.12.2 is missing: >> >> you mean 0.12.4 not 0.12.2, don't you? > > Yes, sorry. (but 0.12.2 is of course m

[Qemu-devel] Re: virtio-blk XFS corruption

2010-09-25 Thread Christoph Hellwig
On Sat, Sep 25, 2010 at 05:40:34PM +0200, Peter Lieven wrote: > > Am 25.09.2010 um 17:37 schrieb Christoph Hellwig: > > > FYI, qemu 0.12.2 is missing: > > you mean 0.12.4 not 0.12.2, don't you? Yes, sorry. (but 0.12.2 is of course missing it, too..) > > which in the past was very good at trigg

[Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot

2010-09-25 Thread Kevin O'Connor
On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote: > vring_virtqueue should be zeroed otherwise old values will be reused > after reboot. > > Signed-off-by: Gleb Natapov Applied. Thanks. -Kevin

[Qemu-devel] Re: virtio-blk XFS corruption

2010-09-25 Thread Peter Lieven
Am 25.09.2010 um 17:37 schrieb Christoph Hellwig: > FYI, qemu 0.12.2 is missing: you mean 0.12.4 not 0.12.2, don't you? > > block: fix sector comparism in multiwrite_req_compare > > which in the past was very good at triggering XFS guest corruption. > Please try with the patch applied o

[Qemu-devel] Re: virtio-blk XFS corruption

2010-09-25 Thread Christoph Hellwig
FYI, qemu 0.12.2 is missing: block: fix sector comparism in multiwrite_req_compare which in the past was very good at triggering XFS guest corruption. Please try with the patch applied or even better latests qemu from git.

Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler

2010-09-25 Thread Blue Swirl
On Sat, Sep 25, 2010 at 12:01 PM, Loïc Minier wrote: > On Sat, Sep 25, 2010, Blue Swirl wrote: >> It looks like dash and ksh are not compliant and use the return value >> of echo or rm inside trap handler: >> dash -c 'trap "sh -c \"exit 4\"; exit" 0 1 2 3 9 11 13 15;exit 3'; echo $? >> 4 > >  I've

[Qemu-devel] Re: [PATCH v8] Introduce qemu_madvise()

2010-09-25 Thread Blue Swirl
Thanks, applied. I moved the include line below #include "config-host.h", otherwise CONFIG_xx would have been undefined. On Sat, Sep 25, 2010 at 10:58 AM, Andreas Färber wrote: > From: Andreas Färber > > vl.c has a Sun-specific hack to supply a prototype for madvise(), > but the call site has ap

[Qemu-devel] Re: virtio-blk XFS corruption

2010-09-25 Thread Peter Lieven
Am 25.09.2010 um 16:44 schrieb Stefan Hajnoczi: > On Sat, Sep 25, 2010 at 2:43 PM, Peter Lieven wrote: >> we experience filesystem corruption using virtio-blk on some guest systems >> togehter with XFS. We still use qemu-kvm 0.12.4. > [...] >> It seems that 64-bit Ubuntu LTS 10.04.1 is affected

[Qemu-devel] Re: virtio-blk XFS corruption

2010-09-25 Thread Stefan Hajnoczi
On Sat, Sep 25, 2010 at 2:43 PM, Peter Lieven wrote: > we experience filesystem corruption using virtio-blk on some guest systems > togehter with XFS. We still use qemu-kvm 0.12.4. [...] > It seems that 64-bit Ubuntu LTS 10.04.1 is affected as well as an older > openSuse 11.1 system with kernel

Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler

2010-09-25 Thread Markus Armbruster
Loïc Minier writes: > On Sat, Sep 25, 2010, Blue Swirl wrote: >> It looks like dash and ksh are not compliant and use the return value >> of echo or rm inside trap handler: >> dash -c 'trap "sh -c \"exit 4\"; exit" 0 1 2 3 9 11 13 15;exit 3'; echo $? >> 4 > > I've filed https://bugs.launchpad.ne

[Qemu-devel] virtio-blk XFS corruption

2010-09-25 Thread Peter Lieven
Hi all, we experience filesystem corruption using virtio-blk on some guest systems togehter with XFS. We still use qemu-kvm 0.12.4. Does someone remember if there has been a fix submitted meanwhile? It seems that 64-bit Ubuntu LTS 10.04.1 is affected as well as an older openSuse 11.1 system wit

Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler

2010-09-25 Thread Loïc Minier
On Sat, Sep 25, 2010, Blue Swirl wrote: > It looks like dash and ksh are not compliant and use the return value > of echo or rm inside trap handler: > dash -c 'trap "sh -c \"exit 4\"; exit" 0 1 2 3 9 11 13 15;exit 3'; echo $? > 4 I've filed https://bugs.launchpad.net/dash/+bug/647450 to track thi

[Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-25 Thread Stefan Weil
Am 25.09.2010 10:01, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 9:23 PM, Stefan Weil wrote: Am 23.09.2010 22:24, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:11 PM, Stefan Weil wrote: Am 23.09.2010 21:03, schrieb Stefan Weil: Am 23.09.2010 20:53, schrieb Blue Swirl: On Thu, Sep 23,

[Qemu-devel] [PATCH v8] Introduce qemu_madvise()

2010-09-25 Thread Andreas Färber
From: Andreas Färber vl.c has a Sun-specific hack to supply a prototype for madvise(), but the call site has apparently moved to arch_init.c. Haiku doesn't implement madvise() in favor of posix_madvise(). OpenBSD and Solaris 10 don't implement posix_madvise() but madvise(). MinGW implements neit

Re: [Qemu-devel] [PATCH 8/8] [MIPS] qdev: convert rc4030 to sysbus device

2010-09-25 Thread Blue Swirl
On Sat, Sep 25, 2010 at 9:59 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> 2010/9/8 Hervé Poussineau : >>> Use it in Jazz emulation >>> Remove rc4030_init() function, which is not used anymore >>> >>> Signed-off-by: Hervé Poussineau >>> --- >>>  hw/mips.h      |    4 +- >>>  hw/mips_jaz

Re: [Qemu-devel] [PATCH 8/8] [MIPS] qdev: convert rc4030 to sysbus device

2010-09-25 Thread Markus Armbruster
Blue Swirl writes: > 2010/9/8 Hervé Poussineau : >> Use it in Jazz emulation >> Remove rc4030_init() function, which is not used anymore >> >> Signed-off-by: Hervé Poussineau >> --- >>  hw/mips.h      |    4 +- >>  hw/mips_jazz.c |    8 +-- >>  hw/rc4030.c    |  135 >> +

Re: [Qemu-devel] [PATCH 3/8] [MIPS] qdev: convert jazz-led to sysbus device

2010-09-25 Thread Markus Armbruster
Hervé Poussineau writes: > Use it in Jazz emulation > Remove jazz_led_init() function, which is not used anymore > Compile jazz_led.c file only once [...] > diff --git a/hw/jazz_led.c b/hw/jazz_led.c > index 4cb680c..f364301 100644 > --- a/hw/jazz_led.c > +++ b/hw/jazz_led.c [...] > @@ -70,30 +70

Re: [Qemu-devel] [PATCH 2/8] [MIPS] qdev: convert ds1225y nvram to sysbus device

2010-09-25 Thread Markus Armbruster
Hervé Poussineau writes: > Use it in Jazz emulation > Remove protection stuff, which doesn't belong to this device > Remove ds1225y_init() and ds1225y_set_protection() functions, which are not > used anymore > > Signed-off-by: Hervé Poussineau I think this would be easier to review if you spli

Re: [Qemu-devel] [PATCH 1/8] [MIPS] qdev: convert i8042 to sysbus device

2010-09-25 Thread Markus Armbruster
Hervé Poussineau writes: > Use it in Jazz emulation > Remove i8042_mm_init() function, which is not used anymore > > Signed-off-by: Hervé Poussineau > --- > hw/mips_jazz.c |3 ++- > hw/pc.h|3 --- > hw/pckbd.c | 55 +++ >

Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler

2010-09-25 Thread Blue Swirl
On Sat, Sep 25, 2010 at 8:31 AM, Loïc Minier wrote: > On Sat, Sep 25, 2010, Markus Armbruster wrote: >> This suggests the old code screws up the exit code.  It doesn't for me. >> Unless it does at least on some platforms, it's a cleanup, not a fix, >> and the commit message should reflect that. >

[Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-09-25 Thread Adam Lackorzynski
A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski Acked-by: Alexander Graf --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/multiboot.c

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-25 Thread Adam Lackorzynski
Refine check on bkpt so that smc and undefined instruction encodings are handled as an undefined instruction and trap. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm

Re: [Qemu-devel] Re: [PATCH] i386 debugging stubs: Consider segment bases

2010-09-25 Thread Eddie Kohler
Thanks for the response. I agree the patch is a workaround, but it is a useful workaround, and I'd still argue for including it. The patch doesn't *require* that CS.base == DS.base. Breakpoints correctly and exclusively use CS.base. However, any memory examination uses DS.base, and you're r

Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler

2010-09-25 Thread Loïc Minier
On Sat, Sep 25, 2010, Markus Armbruster wrote: > This suggests the old code screws up the exit code. It doesn't for me. > Unless it does at least on some platforms, it's a cleanup, not a fix, > and the commit message should reflect that. It does screw up the exit code for me; it seems it's becau

Re: [Qemu-devel] [PATCH] Some tweaks to make some features only built-in when necessary

2010-09-25 Thread Blue Swirl
On Fri, Sep 24, 2010 at 9:10 PM, Brian Jackson wrote: > In trying to make the qemu binary size smaller, I've come across some things > that can be left out of the binary without affecting the binary working. I've > got more patches in the pipeline but the more I try to take out, the more > invasiv

Re: TR : RE : [Qemu-devel] Re: Win2k host problem with {get, free}{addr, name}info()

2010-09-25 Thread Blue Swirl
On Fri, Sep 24, 2010 at 9:21 PM, Bastien ROUCARIES wrote: > Forget cc > > -- Message transféré -- > De : "Bastien ROUCARIES" > Date : 24 sept. 2010 23:21 > Objet : RE : [Qemu-devel] Re: Win2k host problem with {get, free}{addr, > name}info() > À : "Blue Swirl" > > If you see a re

[Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-25 Thread Blue Swirl
On Thu, Sep 23, 2010 at 9:23 PM, Stefan Weil wrote: > Am 23.09.2010 22:24, schrieb Blue Swirl: >> >> On Thu, Sep 23, 2010 at 7:11 PM, Stefan Weil wrote: >>> >>> Am 23.09.2010 21:03, schrieb Stefan Weil: Am 23.09.2010 20:53, schrieb Blue Swirl: > > On Thu, Sep 23, 2010 at 6:37 PM

Re: [Qemu-devel] Re: [PATCH v7] Introduce qemu_madvise()

2010-09-25 Thread Blue Swirl
On Fri, Sep 24, 2010 at 6:08 PM, Andreas Färber wrote: > Am 20.09.2010 um 22:33 schrieb Blue Swirl: > >> On Sun, Sep 19, 2010 at 10:11 AM, Andreas Färber >> wrote: >>> >>> From: Andreas Färber >>> >>> vl.c has a Sun-specific hack to supply a prototype for madvise(), >>> but the call site has app

[Qemu-devel] Re: [PATCH 2/3] Replace remaining gcc format attribute by macro GCC_FMT_ATTR (format checking)

2010-09-25 Thread Blue Swirl
On Thu, Sep 23, 2010 at 8:44 PM, Stefan Weil wrote: > Am 23.09.2010 22:33, schrieb Blue Swirl: >> >> On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil wrote: >>> >>> Replace the remaining format attribute printf by macro >>> GCC_FMT_ATTR which uses gnu_printf (if supported). >>> >>> This needs additio

[Qemu-devel] Re: [PATCH] i386 debugging stubs: Consider segment bases

2010-09-25 Thread Jan Kiszka
Am 25.09.2010 02:25, Eddie Kohler wrote: > Hi, > > QEMU has a bug that complicates GDB debugging of i386 targets when the > current code or data segment has a nonzero base. A fix is attached. > > If the current code segment has a nonzero base, breakpoints don't work > as expected, because the br