Re: [Qemu-devel] [PATCH] net: provide a friendly message when a user passes a bad -net tap, fd=X (v2)

2010-10-11 Thread Jason Wang
- "Anthony Liguori" wrote: > A lot of people copy libvirt's command line from ps -ef and then > wonder why the > VM isn't working correctly. Let's be kind and tell them what they > should do > instead. > > Without this patch, if you run with an invalid -net tap,fd=X, the > guest still > ru

Re: [Qemu-devel] [PATCH] monitor: properly handle invalid fd/vhostfd from command line

2010-10-11 Thread jason wang
On 10/09/2010 01:40 AM, Luiz Capitulino wrote: On Tue, 28 Sep 2010 16:57:44 +0200 "Michael S. Tsirkin" wrote: On Tue, Sep 28, 2010 at 11:53:43AM -0300, Luiz Capitulino wrote: On Mon, 27 Sep 2010 15:52:44 +0800 Jason Wang wrote: monitor_get_fd() may also be used to parse f

[Qemu-devel] [PATCH] Introduce 9p commandline arguments sanity checks

2010-10-11 Thread Harsh Prateek Bora
This patch checks the validity of 9p related commandline arguments and throws error if the arguments are not appropriate. Signed-off-by: Harsh Prateek Bora --- fsdev/qemu-fsdev.c | 39 ++- hw/virtio-9p.c |2 +- 2 files changed, 27 insertions(+), 14 d

Re: [Qemu-devel] [Bug 658904] [NEW] QEMU refers to VLAN, but doesn't mean 802.1Q

2010-10-11 Thread Mulyadi Santosa
On Tue, Oct 12, 2010 at 09:32, guenthert wrote: > Public bug reported: > > Throughout the (sparse) documentation and the cmd-line help text, Qemu > refers to VLAN ("virtual" LANs), which are unrelated to 802.1Q (tagged > ethernet) VLAN, which, IMHO is _very_ confusing. Beyond that, it's also > unn

[Qemu-devel] [Bug 658904] [NEW] QEMU refers to VLAN, but doesn't mean 802.1Q

2010-10-11 Thread guenthert
Public bug reported: Throughout the (sparse) documentation and the cmd-line help text, Qemu refers to VLAN ("virtual" LANs), which are unrelated to 802.1Q (tagged ethernet) VLAN, which, IMHO is _very_ confusing. Beyond that, it's also unnecessary, as the network in question isn't "virtual", only t

[Qemu-devel] qemu-kvm build issue on RHEL5.1

2010-10-11 Thread Hao, Xudong
Hi, Currently qemu-kvm build fail on RHEL5 with gcc 4.1.2, build can pass on Fedora11 with gcc 4.4.1, can anybody look on RHEL5 system? Gcc: 4.1.2 system: RHEL5.1 qemu-kvm: 85566812a4f8cae721fea0224e05a7e75c08c5dd ... LINK qemu-img LINK qemu-io CClibhw64/virtio-9p-local.o cc1: warni

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Kevin O'Connor
On Mon, Oct 11, 2010 at 12:18:55PM +0200, Gleb Natapov wrote: > Currently if VM is started with multiple disks it is almost impossible to > guess which one of them will be used as boot device especially if there > is a mix of ATA/virtio/SCSI devices. Essentially BIOS decides the order > and without

[Qemu-devel] Re: [RFT] qemu 0.13.0-rc3

2010-10-11 Thread Anthony Liguori
On 10/11/2010 06:45 PM, Luiz Capitulino wrote: On Mon, 11 Oct 2010 17:15:30 -0500 Anthony Liguori wrote: After suffering from a prolonged maintainer softlockup, I'm attempting to get 0.13.0 release process back on track. I've tagged qemu-0.13.0-rc3 in git which only carries a few changes

[Qemu-devel] Re: [RFT] qemu 0.13.0-rc3

2010-10-11 Thread Luiz Capitulino
On Mon, 11 Oct 2010 17:15:30 -0500 Anthony Liguori wrote: > After suffering from a prolonged maintainer softlockup, I'm attempting > to get 0.13.0 release process back on track. > > I've tagged qemu-0.13.0-rc3 in git which only carries a few changes > since 0.13.0-rc1. Most notably, a series

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Kevin O'Connor
On Mon, Oct 11, 2010 at 02:08:13PM +0200, Gleb Natapov wrote: > On Mon, Oct 11, 2010 at 01:16:00PM +0200, Bernhard Kohl wrote: > > I think this also applies to network booting via gPXE. Usually our VMs > > have 4 NICs, mixed virtio-net and PCI pass-through. 2 of the NICs shall > > be used for booti

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Kevin O'Connor
On Mon, Oct 11, 2010 at 07:04:25PM +0200, Gleb Natapov wrote: > On Mon, Oct 11, 2010 at 12:01:58PM -0500, Anthony Liguori wrote: > > On 10/11/2010 10:52 AM, Stefan Hajnoczi wrote: > > >SeaBIOS may do that but gPXE internally just probes all PCI devices. > > >It does not take advantage of the PCI bu

[Qemu-devel] [RFT] qemu 0.13.0-rc3

2010-10-11 Thread Anthony Liguori
After suffering from a prolonged maintainer softlockup, I'm attempting to get 0.13.0 release process back on track. I've tagged qemu-0.13.0-rc3 in git which only carries a few changes since 0.13.0-rc1. Most notably, a series of updates from Kevin Wolf and Cam Macdonell's ivshmem device. I t

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread H. Peter Anvin
On 10/11/2010 02:41 PM, Sebastian Herbszt wrote: > H. Peter Anvin wrote: >> On 10/11/2010 01:30 PM, Anthony Liguori wrote: >>> On 10/11/2010 02:59 PM, Gleb Natapov wrote: No boot rom should do that. extboot wreaks havoc when it is used. And since virtio is now supported by bios there is n

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Sebastian Herbszt
H. Peter Anvin wrote: On 10/11/2010 01:30 PM, Anthony Liguori wrote: On 10/11/2010 02:59 PM, Gleb Natapov wrote: No boot rom should do that. extboot wreaks havoc when it is used. And since virtio is now supported by bios there is no reason to use it. You don't really have a choice. You could

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 03:50:08PM -0500, Anthony Liguori wrote: > On 10/11/2010 03:36 PM, Gleb Natapov wrote: > >On Mon, Oct 11, 2010 at 03:30:21PM -0500, Anthony Liguori wrote: > >>On 10/11/2010 02:59 PM, Gleb Natapov wrote: > >>>No boot rom should do that. extboot wreaks havoc when it is used. >

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread H. Peter Anvin
On 10/11/2010 01:30 PM, Anthony Liguori wrote: > On 10/11/2010 02:59 PM, Gleb Natapov wrote: >> No boot rom should do that. extboot wreaks havoc when it is used. >> And since virtio is now supported by bios there is no reason to use it. > > You don't really have a choice. You could be doing hardw

Re: [Qemu-devel] [PULL] eeepro100, virtio, net, vhost fixes

2010-10-11 Thread Anthony Liguori
On 10/07/2010 09:54 AM, Michael S. Tsirkin wrote: Here are some fixes, all over the place. I am guessing the below fixes all make sense for the 0.13 branch, too. The per-device notifier patch is the only one that does not fix bugs, but it is needed for a bugfix patch on qemu-kvm stable that depe

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Anthony Liguori
On 10/11/2010 03:36 PM, Gleb Natapov wrote: On Mon, Oct 11, 2010 at 03:30:21PM -0500, Anthony Liguori wrote: On 10/11/2010 02:59 PM, Gleb Natapov wrote: No boot rom should do that. extboot wreaks havoc when it is used. And since virtio is now supported by bios there is no reason to us

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 03:30:21PM -0500, Anthony Liguori wrote: > On 10/11/2010 02:59 PM, Gleb Natapov wrote: > >No boot rom should do that. extboot wreaks havoc when it is used. > >And since virtio is now supported by bios there is no reason to use it. > > You don't really have a choice. You co

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Anthony Liguori
On 10/11/2010 02:59 PM, Gleb Natapov wrote: No boot rom should do that. extboot wreaks havoc when it is used. And since virtio is now supported by bios there is no reason to use it. You don't really have a choice. You could be doing hardware passthrough and the ROM on the card may hijack

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread H. Peter Anvin
On 10/11/2010 12:51 PM, Anthony Liguori wrote: > > -kernel hijacks int19 so it cannot participate in any kind of boot > order. It's either present (and therefore the bootable disk) or not > present. > That's a misdesign, though: it should be able to participate in BBS as a BEV. -hpa

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 02:51:09PM -0500, Anthony Liguori wrote: > On 10/11/2010 07:07 AM, Gerd Hoffmann wrote: > > Hi, > > > >>Floppy? Yes, I think we do. > > > >And *one* floppy controllers can actually have *two* drives > >connected, although booting from 'b' doesn't work IIRC. > > > >>>and sin

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 02:48:48PM -0500, Anthony Liguori wrote: > On 10/11/2010 07:16 AM, Gleb Natapov wrote: > >On Mon, Oct 11, 2010 at 02:07:14PM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >>>Floppy? Yes, I think we do. > >>And *one* floppy controllers can actually have *two* drives > >>conne

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Anthony Liguori
On 10/11/2010 07:07 AM, Gerd Hoffmann wrote: Hi, Floppy? Yes, I think we do. And *one* floppy controllers can actually have *two* drives connected, although booting from 'b' doesn't work IIRC. and since one PCI device may control more then one disk (ATA slave/master, SCSI LUNs). We can

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Anthony Liguori
On 10/11/2010 07:16 AM, Gleb Natapov wrote: On Mon, Oct 11, 2010 at 02:07:14PM +0200, Gerd Hoffmann wrote: Hi, Floppy? Yes, I think we do. And *one* floppy controllers can actually have *two* drives connected, although booting from 'b' doesn't work IIRC. and since

[Qemu-devel] [Bug 658610] [NEW] Check whether images have write permissions

2010-10-11 Thread Frank Groeneveld
Public bug reported: KVM/Qemu should check whether the disk images have write permissions in order to prevent users from getting weird IO errors in their VMs without understanding what's happening. ** Affects: qemu Importance: Undecided Status: New ** Affects: kvm (Ubuntu) Imp

[Qemu-devel] [patch 7/8] MCE: Relay UCR MCE to guest

2010-10-11 Thread Marcelo Tosatti
Port qemu-kvm's commit 4b62fff1101a7ad77553147717a8bd3bf79df7ef Author: Huang Ying Date: Mon Sep 21 10:43:25 2009 +0800 MCE: Relay UCR MCE to guest UCR (uncorrected recovery) MCE is supported in recent Intel CPUs, where some hardware error such as some memory error can be repo

[Qemu-devel] [patch 1/8] signalfd compatibility

2010-10-11 Thread Marcelo Tosatti
Port qemu-kvm's signalfd compat code. commit 5a7fdd0abd7cd24dac205317a4195446ab8748b5 Author: Anthony Liguori Date: Wed May 7 11:55:47 2008 -0500 Use signalfd() in io-thread This patch reworks the IO thread to use signalfd() instead of sigtimedwait() This will eliminate the ne

[Qemu-devel] [patch 8/8] Add savevm/loadvm support for MCE

2010-10-11 Thread Marcelo Tosatti
Port qemu-kvm's commit 1bab5d11545d8de5facf46c28630085a2f9651ae Author: Huang Ying Date: Wed Mar 3 16:52:46 2010 +0800 Add savevm/loadvm support for MCE MCE registers are saved/load into/from CPUState in kvm_arch_save/load_regs. To simulate the MCG_STATUS clearing upon res

[Qemu-devel] [patch 6/8] Add RAM -> physical addr mapping in MCE simulation

2010-10-11 Thread Marcelo Tosatti
From: Huang Ying In QEMU-KVM, physical address != RAM address. While MCE simulation needs physical address instead of RAM address. So kvm_physical_memory_addr_from_ram() is implemented to do the conversion, and it is invoked before being filled in the IA32_MCi_ADDR MSR. Reported-by: Dean Nelson

[Qemu-devel] [patch 2/8] iothread: use signalfd

2010-10-11 Thread Marcelo Tosatti
Block SIGALRM, SIGIO and consume them via signalfd. Signed-off-by: Marcelo Tosatti Index: qemu/cpus.c === --- qemu.orig/cpus.c +++ qemu/cpus.c @@ -33,6 +33,7 @@ #include "exec-all.h" #include "cpus.h" +#include "compatfd.h" #

[Qemu-devel] [patch 5/8] Export qemu_ram_addr_from_host

2010-10-11 Thread Marcelo Tosatti
To be used by next patches. Signed-off-by: Marcelo Tosatti Index: qemu/cpu-common.h === --- qemu.orig/cpu-common.h +++ qemu/cpu-common.h @@ -47,7 +47,8 @@ void qemu_ram_free(ram_addr_t addr); /* This should only be used for ram loc

[Qemu-devel] [patch 4/8] kvm: x86: add mce support

2010-10-11 Thread Marcelo Tosatti
Port qemu-kvm's MCE support commit c68b2374c9048812f488e00ffb95db66c0bc07a7 Author: Huang Ying Date: Mon Jul 20 10:00:53 2009 +0800 Add MCE simulation support to qemu/kvm KVM ioctls are used to initialize MCE simulation and inject MCE. The real MCE simulation is implemented in

[Qemu-devel] [patch 0/8] port qemu-kvm's MCE support (v3)

2010-10-11 Thread Marcelo Tosatti
Port qemu-kvm's KVM MCE (Machine Check Exception) handling to qemu. It allows qemu to propagate MCEs to the guest. v2: - rename do_qemu_ram_addr_from_host. - fix kvm_on_sigbus/kvm_on_sigbus_vcpu naming. - fix bank register restoration (Dean Nelson). v3: - condition MCE generation on MCE_SEG_P bit

[Qemu-devel] [patch 3/8] Expose thread_id in info cpus

2010-10-11 Thread Marcelo Tosatti
commit ce6325ff1af34dbaee91c8d28e792277e43f1227 Author: Glauber Costa Date: Wed Mar 5 17:01:10 2008 -0300 Augment info cpus This patch exposes the thread id associated with each cpu through the already well known 'info cpus' interface. Signed-off-by: Marcelo Tosatti Index: q

Re: [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Markus Armbruster
Jes, I feel a bit bad finding still more faults, but here goes... jes.soren...@redhat.com writes: > From: Jes Sorensen > > strtosz() returns -1 on error. It now supports human unit formats in > eg. 1.0G, with better error handling. > > Signed-off-by: Jes Sorensen > --- > cutils.c | 61

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 12:01:58PM -0500, Anthony Liguori wrote: > On 10/11/2010 10:52 AM, Stefan Hajnoczi wrote: > >2010/10/11 Gleb Natapov: > >>On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: > >>>On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl > >>>wrote: > Am 11.10.2010 1

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Anthony Liguori
On 10/11/2010 10:52 AM, Stefan Hajnoczi wrote: 2010/10/11 Gleb Natapov: On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl wrote: Am 11.10.2010 12:18, schrieb ext Gleb Natapov: Currently if VM is starte

[Qemu-devel] [Bug 485251] Re: qemu 0.11.50: Guest boot failed when the drive interface is scsi

2010-10-11 Thread Michael Tokarev
The crashes were most likely fixed by commit e8637c9013609271772cc0c3436cb1240cd6b034 , which is a part of 0.13 and while it applies to 0.12 just fine, it didn't went into 0.12-stable. -- qemu 0.11.50: Guest boot failed when the drive interface is scsi https://bugs.launchpad.net/bugs/485251 You r

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not. The alternative is for the freelist to be a non-compat feature bit. That means older QEMU binaries cannot use a QED image that has en

Re: [Qemu-devel] [PATCH 03/12] eepro100: initialize a variable in all cases

2010-10-11 Thread Markus Armbruster
Stefan Weil writes: > Am 11.10.2010 16:53, schrieb Markus Armbruster: >> Blue Swirl writes: >> >>> Compiling with GCC 4.6.0 20100925 produced warnings: >>> /src/qemu/hw/eepro100.c: In function 'eepro100_read4': >>> /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used >>> uninitialized in th

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 11:18 AM, Anthony Liguori wrote: On 10/11/2010 10:46 AM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: It was discussed before, but I don't think we came to a conclusion. Are there any circ

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Avi Kivity
On 10/11/2010 12:18 PM, Gleb Natapov wrote: Currently if VM is started with multiple disks it is almost impossible to guess which one of them will be used as boot device especially if there is a mix of ATA/virtio/SCSI devices. Essentially BIOS decides the order and without looking into the code

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 11:02 AM, Avi Kivity wrote: On 10/11/2010 05:49 PM, Anthony Liguori wrote: On 10/11/2010 09:58 AM, Avi Kivity wrote: A leak is unacceptable. It means an image can grow to an unbounded size. If you are a server provider offering multitenancy, then a malicious guest can potentia

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:39 PM, Gleb Natapov wrote: On Mon, Oct 11, 2010 at 05:09:22PM +0200, Avi Kivity wrote: > On 10/11/2010 12:18 PM, Gleb Natapov wrote: > >Currently if VM is started with multiple disks it is almost impossible to > >guess which one of them will be used as boot device especially

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:10:16PM +0200, Avi Kivity wrote: > On 10/11/2010 12:37 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 10, 2010 at 11:10:15AM +0200, Avi Kivity wrote: > >> On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >> >This patch implements the read/write state machine. Operations a

[Qemu-devel] [PATCH V5 09/14] xen: Introduce the Xen mapcache

2010-10-11 Thread anthony . perard
From: Anthony PERARD The mapcache maps chucks of guest memory on demand, unmaps them when they are not needed anymore. Each call to qemu_get_ram_ptr makes a call to qemu_map_cache with the lock option, so mapcache will not unmap these ram_ptr. Signed-off-by: Anthony PERARD Signed-off-by: Stefa

[Qemu-devel] [PATCH V5 14/14] acpi-piix4: Add Xen hypercall for sleep state.

2010-10-11 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/acpi_piix4.c |4 hw/xen.h|2 ++ xen-all.c |7 +++ xen-stub.c |4 4 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index c8733e5..058bd5f 10

Re: [Qemu-devel] [RFC] Can we remove special handling of standard headers (introduced for dyngen / OSX?)

2010-10-11 Thread Stefan Weil
Am 10.10.2010 00:46, schrieb Andreas Färber: Am 04.10.2010 um 21:29 schrieb Stefan Weil: Am 25.09.2010 09:46, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 8:44 PM, Stefan Weil wrote: Am 23.09.2010 22:33, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil wrote: Replace the

[Qemu-devel] [PATCH V5 05/14] xen: Add xen in -accel option.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This come with the initialisation of Xen. Signed-off-by: Anthony PERARD --- Makefile.target |5 + hw/xen.h| 10 ++ vl.c|2 ++ xen-all.c | 25 + xen-stub.c | 17 + 5 files chang

[Qemu-devel] [PATCH V5 11/14] vl.c: Introduce getter for shutdown_requested and reset_requested.

2010-10-11 Thread anthony . perard
From: Anthony PERARD Introduce two functions qemu_shutdown_requested_get and qemu_reset_requested_get to get the value of shutdown/reset_requested without reset it. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- sysemu.h |2 ++ vl.c | 10 ++ 2 files chan

[Qemu-devel] [PATCH V5 12/14] xen: Initialize event channels and io rings

2010-10-11 Thread anthony . perard
From: Anthony PERARD Open and bind event channels; map ioreq and buffered ioreq rings. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_common.h |3 + xen-all.c | 407 +++ 2 files changed, 410 insertions(

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: > On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl wrote: > > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: > >> > >> Currently if VM is started with multiple disks it is almost impossible to > >> guess which one of them will be used

[Qemu-devel] [PATCH V5 10/14] Introduce qemu_ram_ptr_unlock.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After a call to qemu_ram_ptr_unlock, the pointer may be unmap from QEMU when used with Xen. Signed-off-by: Anthony PERARD --- cpu-common.h |1 + exec.c | 10 ++ xen-mapcache.c | 34

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 04:52:31PM +0100, Stefan Hajnoczi wrote: > 2010/10/11 Gleb Natapov : > > On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: > >> On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl > >> wrote: > >> > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: > >> >> > >> >>

[Qemu-devel] [PATCH V5 13/14] xen: Set running state in xenstore.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This tells to the xen management tool that the machine can begin run. Signed-off-by: Anthony PERARD --- xen-all.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index a0d1b9b..fc862cb 100644 --- a/x

[Qemu-devel] [PATCH V5 08/14] xen: add a 8259 Interrupt Controller

2010-10-11 Thread anthony . perard
From: Anthony PERARD Introduce a 8259 Interrupt Controller for target-xen; every set_irq call makes a Xen hypercall. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_common.h |2 ++ hw/xen_machine_fv.c |5 ++--- xen-all.c | 12 3

[Qemu-devel] [PATCH V5 06/14] xen: Add the Xen platform pci device

2010-10-11 Thread anthony . perard
From: Anthony PERARD Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |1 + hw/hw.h |3 + hw/pci_id

[Qemu-devel] [PATCH V5 07/14] piix_pci: Introduces Xen specific call for irq.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This patch introduces Xen specific call in piix_pci. The specific part for Xen is in write_config, set_irq and get_pirq. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/piix_pci.c | 28 ++-- hw/xen.h |6 ++ xe

[Qemu-devel] [PATCH V5 01/14] xen: Replace some tab-indents with spaces (clean-up).

2010-10-11 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/xen_backend.c | 308 hw/xen_disk.c| 412 +++--- hw/xen_nic.c | 222 +++--- 3 files changed, 471 insertions(+), 47

[Qemu-devel] [PATCH V5 03/14] xen: Add xen_machine_fv

2010-10-11 Thread anthony . perard
From: Anthony PERARD Add the Xen FV (Fully Virtualized) machine to Qemu; this is groundwork to add Xen device model support in Qemu. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |3 + hw/xen_common.h |5 ++ hw/xen_machine_fv.c | 158

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 04:06 PM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 03:44:38PM +0200, Avi Kivity wrote: > On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > >> > >> A leak is acceptable (it won't grow; it's just an unused, incorrect > >> freelist), but data corruption is not. > > > >

[Qemu-devel] [PATCH V5 04/14] Introduce -accel command option.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This option gives the ability to switch one "accelerator" like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each one and use the first whose works. So, -accel xen,kvm,tcg which would try Xen support fi

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Kevin Wolf
Am 11.10.2010 17:30, schrieb Stefan Hajnoczi: > On Mon, Oct 11, 2010 at 03:58:07PM +0200, Kevin Wolf wrote: >> Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: >>> Signed-off-by: Stefan Hajnoczi >>> --- >>> docs/specs/qed_spec.txt | 94 >>> +++ >>> 1 fi

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 10:46 AM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: It was discussed before, but I don't think we came to a conclusion. Are there any circumstances under which you don't want to

[Qemu-devel] [PATCH V5 02/14] xen: Support new libxc calls from xen unstable.

2010-10-11 Thread anthony . perard
From: Anthony PERARD Update the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We also check libxenctrl version in configure, from Xen 3.3.0 to Xen unstable. Signed-off-by: Anthony PERARD Signed-off-by: Stefano S

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:41 PM, Anthony Liguori wrote: On 10/11/2010 10:24 AM, Avi Kivity wrote: On 10/11/2010 05:02 PM, Anthony Liguori wrote: On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, i

Re: [Qemu-devel] [PATCH 03/12] eepro100: initialize a variable in all cases

2010-10-11 Thread Stefan Weil
Am 11.10.2010 16:53, schrieb Markus Armbruster: Blue Swirl writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/hw/eepro100.c: In function 'eepro100_read4': /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized] /src/q

[Qemu-devel] [PATCH V5 00/14] xen device model support

2010-10-11 Thread anthony . perard
From: Anthony PERARD Hi all, This is the fifth version of the patch series that adds Xen device model support in QEMU. The change we have made on the last version are: - We removed the Xen specific ACPI PIIX4 implementation and added a Xen call in acpi_piix4.c for the sleep state. - W

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Stefan Hajnoczi
2010/10/11 Gleb Natapov : > On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: >> On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl >> wrote: >> > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: >> >> >> >> Currently if VM is started with multiple disks it is almost impossible to >> >>

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 10:24 AM, Avi Kivity wrote: On 10/11/2010 05:02 PM, Anthony Liguori wrote: On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not.

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:49 PM, Anthony Liguori wrote: On 10/11/2010 09:58 AM, Avi Kivity wrote: A leak is unacceptable. It means an image can grow to an unbounded size. If you are a server provider offering multitenancy, then a malicious guest can potentially grow the image beyond it's allotted si

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > Signed-off-by: Stefan Hajnoczi > --- > docs/specs/qed_spec.txt | 94 > +++ > 1 files changed, 94 insertions(+), 0 deletions(-) > create mode 100644 docs/specs/qed_spec.txt > > diff --git a/docs/specs/

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: > > It was discussed before, but I don't think we came to a conclusion. Are > there any circumstances under which you don't want to set the > QED_CF_BACKING_FORMAT flag? I suggest the following: QED_CF_BACKING_FORMAT_RAW = 0x1 When set, the ba

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 05:09:22PM +0200, Avi Kivity wrote: > On 10/11/2010 12:18 PM, Gleb Natapov wrote: > >Currently if VM is started with multiple disks it is almost impossible to > >guess which one of them will be used as boot device especially if there > >is a mix of ATA/virtio/SCSI devices.

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:58:07PM +0200, Kevin Wolf wrote: > Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > > Signed-off-by: Stefan Hajnoczi > > --- > > docs/specs/qed_spec.txt | 94 > > +++ > > 1 files changed, 94 insertions(+), 0 deletions(-) > >

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:44:38PM +0200, Avi Kivity wrote: > On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > >> > >> A leak is acceptable (it won't grow; it's just an unused, incorrect > >> freelist), but data corruption is not. > > > >The alternative is for the freelist to be a non-compat fea

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 09:58 AM, Avi Kivity wrote: A leak is unacceptable. It means an image can grow to an unbounded size. If you are a server provider offering multitenancy, then a malicious guest can potentially grow the image beyond it's allotted size causing a Denial of Service attack against ano

Re: [Qemu-devel] [PATCH 03/12] eepro100: initialize a variable in all cases

2010-10-11 Thread Markus Armbruster
Blue Swirl writes: > Compiling with GCC 4.6.0 20100925 produced warnings: > /src/qemu/hw/eepro100.c: In function 'eepro100_read4': > /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used > uninitialized in this function [-Werror=uninitialized] > /src/qemu/hw/eepro100.c: In function 'eepro100_

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 05:42:30PM +0200, Avi Kivity wrote: > On 10/11/2010 05:39 PM, Gleb Natapov wrote: > >On Mon, Oct 11, 2010 at 05:09:22PM +0200, Avi Kivity wrote: > >> On 10/11/2010 12:18 PM, Gleb Natapov wrote: > >> >Currently if VM is started with multiple disks it is almost impossible

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: > On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: > >> > >> It was discussed before, but I don't think we came to a conclusion. Are > >> there any circumstances under which you don't want to set the > >> QED_CF_BACKING_FORMAT flag? > >

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 08:04 AM, Avi Kivity wrote: On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >Signed-off-by: Stefan Hajnoczi > >--- > > docs/specs/qed_spec.txt | 94

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not. The alternative is for the freelist to be a non-compat feature bit. That means older QEMU

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 04:54 PM, Anthony Liguori wrote: On 10/11/2010 08:04 AM, Avi Kivity wrote: On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >Signed-off-by: Stefan Hajnoczi > >--- > >

[Qemu-devel] Re: [PATCH v2 4/7] qed: Add QEMU Enhanced Disk image format

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > This patch introduces the qed on-disk layout and implements image > creation. Later patches add read/write and other functionality. > > Signed-off-by: Stefan Hajnoczi > --- > Makefile.objs |1 + > block/qed.c | 530 > ++

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:02 PM, Anthony Liguori wrote: On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not. The alternative is for the freelist to be

Re: [Qemu-devel] Re: [PATCH v2 0/7] qed: Add QEMU Enhanced Disk format

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 2:21 PM, Kevin Wolf wrote: > Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: >> This code is also available from git: >> >> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/qed > > This doesn't seem to be the same as the latest patches you posted to > qemu-devel. For

Re: [Qemu-devel] [PATCH 07/12] mips_fulong2e: Delete write only variables

2010-10-11 Thread Markus Armbruster
Blue Swirl writes: > Compiling with GCC 4.6.0 20100925 produced warnings like: > /src/qemu/hw/mips_fulong2e.c: In function 'mips_fulong2e_init': > /src/qemu/hw/mips_fulong2e.c:274:16: error: variable 'rtc_state' set > but not used [-Werror=unused-but-set-variable] > /src/qemu/hw/mips_fulong2e.c:2

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-11 Thread Anthony Liguori
On 10/11/2010 08:10 AM, Avi Kivity wrote: On 10/11/2010 12:37 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:10:15AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >This patch implements the read/write state machine. Operations are > >fully asynchronous an

Re: [Qemu-devel] [PATCH 1/7] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Markus Armbruster
Jes Sorensen writes: > On 10/11/10 10:51, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >>> +/* >>> + * Convert string to bytes, allowing either K/k for KB, M/m for MB, >>> + * G/g for GB or T/t for TB. Default without any postfix is MB. >>> + * End pointer will be returned in *end,

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:04:03PM +0200, Avi Kivity wrote: > On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > >> On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >> >Signed-off-by: Stefan Hajnoczi > >> >--- > >> > docs/specs/qe

Re: [Qemu-devel] [PATCH] CMOS file support

2010-10-11 Thread Markus Armbruster
Maybe Kevin or Christoph (cc'ed) can help. Mathias Krause writes: > On 24.09.2010 14:47, Markus Armbruster wrote: >> Mathias Krause writes: >> >>> On 17.09.2010 15:27, Anthony Liguori wrote: On 09/17/2010 01:50 AM, Mathias Krause wrote: > Am 16.09.2010 19:20 schrieb Anthony Liguori: >

[Qemu-devel] Re: [PATCH v2 0/7] qed: Add QEMU Enhanced Disk format

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > This code is also available from git: > > http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/qed This doesn't seem to be the same as the latest patches you posted to qemu-devel. Forgot to push? Kevin

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-11 Thread Avi Kivity
On 10/11/2010 12:37 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:10:15AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >This patch implements the read/write state machine. Operations are > >fully asynchronous and multiple operations may be active at an

Re: [Qemu-devel] [PATCH 1/7] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Jes Sorensen
On 10/11/10 10:51, Markus Armbruster wrote: > jes.soren...@redhat.com writes: >> +/* >> + * Convert string to bytes, allowing either K/k for KB, M/m for MB, >> + * G/g for GB or T/t for TB. Default without any postfix is MB. >> + * End pointer will be returned in *end, if end is valid. >> + * Retur

[Qemu-devel] Re: [PATCH] Suppress warning: zero-length gnu_printf format string

2010-10-11 Thread Paolo Bonzini
On 10/11/2010 02:52 PM, Markus Armbruster wrote: Warns about this line in check-qjson.c: QObject *obj = qobject_from_json(""); The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't work, because -Wall switches it on again. Fix by putting configured flags last. Signed-off-by:

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >Signed-off-by: Stefan Hajnoczi > >--- > > docs/specs/qed_spec.txt | 94 +++ > > 1

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl wrote: > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: >> >> Currently if VM is started with multiple disks it is almost impossible to >> guess which one of them will be used as boot device especially if there >> is a mix of ATA/virtio/SCSI devices.

[Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Jes . Sorensen
From: Jes Sorensen strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. Signed-off-by: Jes Sorensen --- cutils.c | 61 + qemu-common.h |1 + vl.c | 31 +--

[Qemu-devel] [PATCH] Suppress warning: zero-length gnu_printf format string

2010-10-11 Thread Markus Armbruster
Warns about this line in check-qjson.c: QObject *obj = qobject_from_json(""); The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't work, because -Wall switches it on again. Fix by putting configured flags last. Signed-off-by: Markus Armbruster --- configure |5 +++-- 1 fi

  1   2   >