Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 02:53:16PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote: On Fri, Oct 22, 2010 at 04:38:49PM +0200, Michael S. Tsirkin wrote: On Fri, Oct 22, 2010 at

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 04:02:36PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 07:55:57AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 25, 2010 at 02:53:16PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 25, 2010 at

[Qemu-devel] Re: [PATCH RFC] msi: remove range checks

2010-10-25 Thread Michael S. Tsirkin
Hmm, does this simply check that write is within the capability? Then I think I misunderstood what this does. Please replace hard-coded length logic with existing function call that gets the lengths, the range check can stay then. On Mon, Oct 25, 2010 at 04:07:13PM +0900, Isaku Yamahata wrote:

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-25 Thread Jes Sorensen
On 10/23/10 16:42, Blue Swirl wrote: On Mon, Oct 18, 2010 at 8:15 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Almost there: CCm68k-linux-user/m68k-semi.o /src/qemu/m68k-semi.c: In function

[Qemu-devel] Re: [PATCH RFC] msi: remove range checks

2010-10-25 Thread Isaku Yamahata
Seems good. For consistency, the range check in msix_write_config() should be also removed. On Mon, Oct 25, 2010 at 08:07:25AM +0200, Michael S. Tsirkin wrote: config write handlers should be idempotent. So no need for range checks. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification

2010-10-25 Thread Isaku Yamahata
On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote: Simplify logic for hotplug notification, by tracking state of the logical interrupt

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-25 Thread Isaku Yamahata
On Mon, Oct 25, 2010 at 07:55:57AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 25, 2010 at 02:53:16PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote: On Fri, Oct 22, 2010 at

[Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote: Simplify logic for hotplug notification, by tracking state of the logical interrupt condition. We then simply use this variable to make the interrupt

[Qemu-devel] Re: [PATCH rfc] pcie: get rid of range checks

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 03:17:37PM +0900, Isaku Yamahata wrote: Some comments below. On Mon, Oct 25, 2010 at 07:05:51AM +0200, Michael S. Tsirkin wrote: config cycle operations should be idempotent, so there's no need to complicate code with range checks. Signed-off-by: Michael S.

[Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification

2010-10-25 Thread Isaku Yamahata
On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote: Simplify logic for hotplug notification, by tracking state of the logical interrupt condition. We then simply use this variable to make the interrupt decision, according to spec. API is made cleaner as we no longer force

[Qemu-devel] [PATCH RFC] msi: remove range checks

2010-10-25 Thread Michael S. Tsirkin
config write handlers should be idempotent. So no need for range checks. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/msi.c | 29 - 1 files changed, 0 insertions(+), 29 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index a949d82..af8ea44 100644 ---

[Qemu-devel] Re: [PATCH rfc] pcie: get rid of range checks

2010-10-25 Thread Isaku Yamahata
Some comments below. On Mon, Oct 25, 2010 at 07:05:51AM +0200, Michael S. Tsirkin wrote: config cycle operations should be idempotent, so there's no need to complicate code with range checks. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Untested. Pls comment. hw/pcie.c |

[Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote: Simplify logic for hotplug notification, by tracking state of the logical interrupt condition. We then simply use this variable to make the interrupt decision, according to spec. API is made cleaner as we no longer force

Re: Fwd: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-25 Thread Kevin Wolf
Am 22.10.2010 18:22, schrieb Sage Weil: On Fri, 22 Oct 2010, Kevin Wolf wrote: [ Adding qemu-devel to CC again ] Am 21.10.2010 20:59, schrieb Sage Weil: On Thu, 21 Oct 2010, Christian Brunner wrote: Hi, is there a flush operation in librados? - I guess the only way to handle this, would

[Qemu-devel] [PATCH] vhost: enable log before starting vq

2010-10-25 Thread Michael S. Tsirkin
Log must be started before backend is enabled, to make sure no memory changes are untracked. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/vhost.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/vhost.c b/hw/vhost.c index

[Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 04:04:26PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote: On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote: Simplify logic for

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-25 Thread Alon Levy
On Fri, Oct 22, 2010 at 07:55:02AM -0500, Anthony Liguori wrote: On 10/22/2010 07:48 AM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levyal...@redhat.com wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote:

[Qemu-devel] Re: [RFC][PATCH 00/10] virtagent: host/guest RPC communication agent

2010-10-25 Thread Andrew Beekhof
On 10/23/2010 04:41 PM, Michael Roth wrote: On 10/23/2010 06:31 AM, Andrew Beekhof wrote: On 10/22/2010 08:45 PM, Michael Roth wrote: the ability to deploy to guests which may not support virtio-serial, which currently rules Matahari out. Possibly there has been some miscommunication,

Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks

2010-10-25 Thread Avi Kivity
On 10/24/2010 08:14 PM, Blue Swirl wrote: On Sun, Oct 24, 2010 at 3:34 PM, Avi Kivitya...@redhat.com wrote: The current ioport callbacks are not type-safe, in that they accept an opaque pointer as an argument whose type must match the argument to the registration function; this is not

[Qemu-devel] Re: [RFC][PATCH 00/10] virtagent: host/guest RPC communication agent

2010-10-25 Thread Andrew Beekhof
On 10/22/2010 08:45 PM, Michael Roth wrote: This set of patches is meant to be applied on top of the Virtproxy v1 patchset. OVERVIEW: There are a wide range of use cases motivating the need for a guest agent of some sort to extend the functionality/usability/control offered by QEMU. Some

[Qemu-devel] [PATCH RFC] virtio-net: don't dma while vm is stopped

2010-10-25 Thread Michael S. Tsirkin
DMA into memory while VM is stopped makes it hard to debug migration (consequitive saves result in different files). Sending while vm is stopped has an even worse effect as it confuses the bridges so that they do not know where to send packets. Fixing this completely is a large effort, this

[Qemu-devel] Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT

2010-10-25 Thread Avi Kivity
On 10/23/2010 04:12 PM, Kevin O'Connor wrote: On Thu, Oct 21, 2010 at 12:07:17PM +0200, Avi Kivity wrote: How do we manage the stable series wrt this issue? qemu-kvm-0.12.5 has a regression within the stable series that this patch fixes. qemu 0.12.5 does not, but only because it does

backdoor [Was: Re: [Qemu-devel] [PATCH 00/17] [RFC] static instrumentation]

2010-10-25 Thread Lluís
Blue Swirl writes: On Fri, Oct 22, 2010 at 6:32 PM, Lluís xscr...@gmx.net wrote: Lluís Vilanova (17):  backdoor: Declare host-side backdoor helpers  backdoor: [all] Include backdoor helper declarations  backdoor: Declare guest-side interface macros  backdoor: [i386] Decode backdoor

[Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote: --- a/hw/pcie.h +++ b/hw/pcie.h @@ -74,6 +74,11 @@ struct PCIExpressDevice { * also initialize it when loaded as * appropreately.

instrument [Was: Re: [Qemu-devel] [PATCH 00/17] [RFC] static instrumentation]

2010-10-25 Thread Lluís
Blue Swirl writes: On Fri, Oct 22, 2010 at 6:32 PM, Lluís xscr...@gmx.net wrote:  instrument: Handle config-time activation  instrument: Add initial instrumentation example  instrument: Dynamic per-CPU state of static instrumentation points  instrument: Code-generation macros  instrument:

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

2010-10-25 Thread Markus Armbruster
Stefan Weil w...@mail.berlios.de writes: Am 13.10.2010 09:13, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: [...] Do you think there is urgent need for a gpxe-eepro100-80862449.rom binary? Well, -device i82801 complains because it misses this binary. Do we want

[Qemu-devel] [PULL] virtio, vhost, migration

2010-10-25 Thread Michael S. Tsirkin
The following changes since commit c57c846a80f9306aa2c6cf7efdef45ed42723fac: qemu-timer: move commonly used timer code to qemu-timer-common (2010-10-23 15:24:07 +) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Michael S.

[Qemu-devel] Re: backdoor [Was: Re: [PATCH 00/17] [RFC] static instrumentation]

2010-10-25 Thread Paolo Bonzini
On 10/25/2010 12:54 PM, Lluís wrote: * Backdoor channels need to provide arguments. * It's better to provide the same mechanism for both *-user and softmmu (otherwise the application to simulate or the interposed librariy should be compiled differently on every case). You can add the

Re: [Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-25 Thread Luiz Capitulino
On Fri, 22 Oct 2010 22:49:10 +0200 Stefan Weil w...@mail.berlios.de wrote: Am 22.10.2010 19:33, schrieb Luiz Capitulino: On Fri, 22 Oct 2010 19:15:07 +0200 Markus Armbrusterarm...@redhat.com wrote: Luiz Capitulinolcapitul...@redhat.com writes: From: Jan

[Qemu-devel] Re: [V3 PATCH] net: properly handle illegal fd/vhostfd from command line

2010-10-25 Thread Luiz Capitulino
On Mon, 25 Oct 2010 13:39:59 +0800 Jason Wang jasow...@redhat.com wrote: When hanlding fd/vhostfd form command line through net_handle_fd_param(), we need to check mon and return value of strtol() otherwise we could get segmentation fault or invalid fd when user type an illegal fd/vhostfd.

[Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks

2010-10-25 Thread Juan Quintela
Avi Kivity a...@redhat.com wrote: +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data) +{ +IOPort *ioport = opaque; + +return ioport-ops-writeb(ioport, addr, data); +} + +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data) +{ +

[Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks

2010-10-25 Thread Avi Kivity
On 10/25/2010 02:54 PM, Juan Quintela wrote: Avi Kivitya...@redhat.com wrote: +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data) +{ +IOPort *ioport = opaque; + +return ioport-ops-writeb(ioport, addr, data); +} + +static void

Re: [Qemu-devel] Re: backdoor

2010-10-25 Thread Lluís
Paolo Bonzini writes: On 10/25/2010 12:54 PM, Lluís wrote: * Backdoor channels need to provide arguments. * It's better to provide the same mechanism for both *-user and softmmu (otherwise the application to simulate or the interposed librariy should be compiled differently on every case).

Re: [Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks

2010-10-25 Thread Anthony Liguori
On 10/24/2010 10:34 AM, Avi Kivity wrote: A recent qemu - qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the other

Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

2010-10-25 Thread Anthony Liguori
On 10/24/2010 12:38 PM, Avi Kivity wrote: On 10/24/2010 07:35 PM, Paolo Bonzini wrote: On 10/24/2010 05:34 PM, Avi Kivity wrote: A recent qemu - qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a

Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

2010-10-25 Thread Paolo Bonzini
On 10/25/2010 03:46 PM, Anthony Liguori wrote: Should we create a Documentation/ file with incomplete transitions and the commit(s) that introduced them, for volunteers who wish to do some dirty work or to learn Coccinelle? If we have a TODO, we could add a janitor section there. That's

Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

2010-10-25 Thread Anthony Liguori
On 10/25/2010 08:52 AM, Paolo Bonzini wrote: On 10/25/2010 03:46 PM, Anthony Liguori wrote: Should we create a Documentation/ file with incomplete transitions and the commit(s) that introduced them, for volunteers who wish to do some dirty work or to learn Coccinelle? If we have a TODO, we

Re: [Qemu-devel] [PATCH] initialize unit id of IDE bus

2010-10-25 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: Without this patch both buses on PIIX3_IDE device have the same unit id. Are you sure that's wrong? As far as I can see, IDEBus member unit is the currently active unit, set by write to port 6 (in ide_ioport_write()) and cleared on reset (in

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: Prevent two devices from claiming the same io port. Really? Your new check for double-claim is in the new isa_init_ioport(), which is for ISADevice only. Thus, only qdevified ISA devices can opt for this protection, by calling isa_init_ioport(). It

Re: [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus.

2010-10-25 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: PCI bus already has one. For ISA bus this patch series uses device's ioports to uniquely describe it. For isa-ide, for example, get_dev_path method returns: 01f0-01f7,03f6 for first IDE controller 0170-0177,0376 for second one Any I/O port used by the

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-25 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 03:33:41PM +0200, Michael S. Tsirkin wrote: Apologies if you receive this twice, the original message either disappeared or was delayed somehow. My main concern is with the fact that we add more state in notifiers that can easily get out of sync with users. If we

[Qemu-devel] [PATCH 0/4] scsi-disk: Complete rerror/werror support

2010-10-25 Thread Kevin Wolf
SCSI disks currently only support werror for write requests. This series adds rerror for failed read requests and respects werror also for flushes. Kevin Wolf (4): scsi-disk: Implement rerror option block: Allow bdrv_flush to return errors scsi-disk: Complete failed requests in

[Qemu-devel] [PATCH 2/4] block: Allow bdrv_flush to return errors

2010-10-25 Thread Kevin Wolf
This changes bdrv_flush to return 0 on success and -errno in case of failure. It's a requirement for implementing proper error handle in users of bdrv_flush. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 21 + block.h |2 +-

[Qemu-devel] [PATCH 1/4] scsi-disk: Implement rerror option

2010-10-25 Thread Kevin Wolf
This implements the rerror option for SCSI disks. Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c |2 +- hw/scsi-disk.c | 91 ++-- 2 files changed, 63 insertions(+), 30 deletions(-) diff --git a/blockdev.c b/blockdev.c

[Qemu-devel] [PATCH 4/4] scsi-disk: Implement werror for flushes

2010-10-25 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-disk.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 7418f0b..a1976ea 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -45,6 +45,7 @@ do { fprintf(stderr,

[Qemu-devel] [PATCH 3/4] scsi-disk: Complete failed requests in scsi_disk_emulate_command

2010-10-25 Thread Kevin Wolf
This pulls the request completion for error cases from the caller to scsi_disk_emulate_command. This should not change semantics, but allows to reuse scsi_handle_write_error() for flushes in the next patch. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-disk.c | 21

Re: [Qemu-devel] [PATCH] initialize unit id of IDE bus

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Without this patch both buses on PIIX3_IDE device have the same unit id. Are you sure that's wrong? So how do I know which bus is it on PIIX3_IDE? As far as I can see, IDEBus member

[Qemu-devel] [PATCH v2 0/2] Type-safe ioport callbacks

2010-10-25 Thread Avi Kivity
A recent qemu - qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the other 300-odd registrations is left as an excercise to

[Qemu-devel] [PATCH v2 1/2] Type-safe ioport callbacks

2010-10-25 Thread Avi Kivity
The current ioport callbacks are not type-safe, in that they accept an opaque pointer as an argument whose type must match the argument to the registration function; this is not checked by the compiler. This patch adds an alternative that is type-safe. Instead of an opaque argument, both

[Qemu-devel] [PATCH v2 2/2] piix4 acpi: convert io BAR to type-safe ioport callbacks

2010-10-25 Thread Avi Kivity
Acked-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/acpi_piix4.c | 30 ++ 1 files changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index f74f34c..c01c2ee 100644 --- a/hw/acpi_piix4.c

Re: [Qemu-devel] [PATCH] initialize unit id of IDE bus

2010-10-25 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Without this patch both buses on PIIX3_IDE device have the same unit id. Are you sure that's wrong? So how do I know which bus is it on

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

2010-10-25 Thread Stefan Weil
Am 25.10.2010 14:11, schrieb Markus Armbruster: Stefan Weil w...@mail.berlios.de writes: Am 13.10.2010 09:13, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: [...] Do you think there is urgent need for a gpxe-eepro100-80862449.rom binary? Well, -device i82801 complains

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-25 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 03:33:41PM +0200, Michael S. Tsirkin wrote: My main concern is with the fact that we add more state in notifiers that can easily get out of sync with users. If we absolutely need this state, let's try to at least document the state machine, and make the API for state

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-25 Thread Blue Swirl
On Mon, Oct 25, 2010 at 7:39 AM, Jes Sorensen jes.soren...@redhat.com wrote: On 10/23/10 16:42, Blue Swirl wrote: On Mon, Oct 18, 2010 at 8:15 AM,  jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Almost there:  

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 06:23:24PM +0200, Stefan Weil wrote: Am 25.10.2010 14:11, schrieb Markus Armbruster: Stefan Weil w...@mail.berlios.de writes: Am 13.10.2010 09:13, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: [...] Do you think there is urgent need for a

Re: [Qemu-devel] [PATCH] initialize unit id of IDE bus

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 06:22:12PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Without this patch both buses on PIIX3_IDE device have the same unit id.

Re: [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus.

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: PCI bus already has one. For ISA bus this patch series uses device's ioports to uniquely describe it. For isa-ide, for example, get_dev_path method returns: 01f0-01f7,03f6 for first

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Prevent two devices from claiming the same io port. Really? Your new check for double-claim is in the new isa_init_ioport(), which is for ISADevice only. Thus, only qdevified ISA

[Qemu-devel] Re: [V3 PATCH] net: properly handle illegal fd/vhostfd from command line

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 10:52:05AM -0200, Luiz Capitulino wrote: On Mon, 25 Oct 2010 13:39:59 +0800 Jason Wang jasow...@redhat.com wrote: When hanlding fd/vhostfd form command line through net_handle_fd_param(), we need to check mon and return value of strtol() otherwise we could get

[Qemu-devel] Re: [RFC][PATCH 00/10] virtagent: host/guest RPC communication agent

2010-10-25 Thread Michael Roth
On 10/25/2010 05:30 AM, Andrew Beekhof wrote: On 10/22/2010 08:45 PM, Michael Roth wrote: This set of patches is meant to be applied on top of the Virtproxy v1 patchset. OVERVIEW: There are a wide range of use cases motivating the need for a guest agent of some sort to extend the

Re: backdoor [Was: Re: [Qemu-devel] [PATCH 00/17] [RFC] static instrumentation]

2010-10-25 Thread Blue Swirl
On Mon, Oct 25, 2010 at 10:54 AM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Fri, Oct 22, 2010 at 6:32 PM, Lluís xscr...@gmx.net wrote: Lluís Vilanova (17):  backdoor: Declare host-side backdoor helpers  backdoor: [all] Include backdoor helper declarations  backdoor: Declare

Re: [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus.

2010-10-25 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: PCI bus already has one. For ISA bus this patch series uses device's ioports to uniquely describe it. For isa-ide, for example, get_dev_path

Re: [Qemu-devel] [PATCH] initialize unit id of IDE bus

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 08:06:13PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 06:22:12PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote: Gleb

[Qemu-devel] [PATCH 2/3] v2 Fix Block Hotplug race with drive_unplug()

2010-10-25 Thread Ryan Harper
Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap where by mgmt applications that assume the block resource has been removed without confirming that the guest

Re: [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus.

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 07:53:41PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: PCI bus already has one. For ISA bus this patch series uses device's

Re: [Qemu-devel] [PATCH] initialize unit id of IDE bus

2010-10-25 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 06:22:12PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Without this patch both buses on

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 08:01:13PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Prevent two devices from claiming the same io port. Really? Your

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Prevent two devices from claiming the same io port. Really? Your new check for double-claim is in the new isa_init_ioport(), which is for

Re: instrument [Was: Re: [Qemu-devel] [PATCH 00/17] [RFC] static instrumentation]

2010-10-25 Thread Blue Swirl
On Mon, Oct 25, 2010 at 11:13 AM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Fri, Oct 22, 2010 at 6:32 PM, Lluís xscr...@gmx.net wrote:  instrument: Handle config-time activation  instrument: Add initial instrumentation example  instrument: Dynamic per-CPU state of static

[Qemu-devel] [PATCH 3/3] Add qmp version of drive_unplug

2010-10-25 Thread Ryan Harper
Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..e8f3d4a 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,32 @@

[Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-10-25 Thread Ryan Harper
This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond leaving the guest with continued access to

Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks

2010-10-25 Thread Blue Swirl
On Mon, Oct 25, 2010 at 10:00 AM, Avi Kivity a...@redhat.com wrote:  On 10/24/2010 08:14 PM, Blue Swirl wrote: On Sun, Oct 24, 2010 at 3:34 PM, Avi Kivitya...@redhat.com  wrote:  The current ioport callbacks are not type-safe, in that they accept an opaque  pointer as an argument whose

[Qemu-devel] [PATCH 1/3] v2 Add drive_get_by_id

2010-10-25 Thread Ryan Harper
Add a function to find a drive by id string. Changes since v1: -Coding Style fix Signed-off-by: Ryan Harper ry...@us.ibm.com --- blockdev.c | 13 + blockdev.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ff7602b..5fc3b9b

Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal

2010-10-25 Thread Ryan Harper
* Kevin Wolf kw...@redhat.com [2010-10-22 11:12]: Am 22.10.2010 17:48, schrieb Luiz Capitulino: On Thu, 21 Oct 2010 21:55:51 -0500 Ryan Harper ry...@us.ibm.com wrote: This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of

[Qemu-devel] KVM call agenda for Oct 26

2010-10-25 Thread Juan Quintela
Please send in any agenda items you are interested in covering. Cheers, Juan.

[Qemu-devel] Re: KVM call agenda for Oct 26

2010-10-25 Thread Chris Wright
* Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. Guest agents

[Qemu-devel] [RFC 0/2]: QMP: Human Monitor passthrough

2010-10-25 Thread Luiz Capitulino
This is my first try on implementing HMP passthrough via QMP. I've tried to follow Anthony's advice on creating a buffered char device. If this approach is good (and the implementation is not faulty), I believe this is very near a mergeble state (although I haven't tested much yet). Example: -

[Qemu-devel] [PATCH 2/2] QMP: Introduce Human Monitor passthrough command

2010-10-25 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands, please check its documentation in the hmp-commands.hx file for usage information. Please, also note that not all HMP commands can be executed this way, in special commands that: o need to store monitor related data (eg. getfd) o read

[Qemu-devel] [PATCH 1/2] qemu-char: Introduce Buffered driver

2010-10-25 Thread Luiz Capitulino
This driver handles in-memory qemu-char driver operations, that's, all writes to this driver are stored in an internal buffer. The driver doesn't talk to the external world in any way. Right now it's very simple: it supports only writes. But it can be easily extended to support more operations.

[Qemu-devel] Re: backdoor

2010-10-25 Thread Lluís
Blue Swirl writes: On Mon, Oct 25, 2010 at 10:54 AM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: and there are guest visible side effects. I don't understand what you mean with guest-visible effects. The guest can examine itself and determine that it has been modified. Well, yes,

Re: [Qemu-devel] Re: backdoor

2010-10-25 Thread Anthony Liguori
On 10/25/2010 08:37 AM, Lluís wrote: Paolo Bonzini writes: On 10/25/2010 12:54 PM, Lluís wrote: * Backdoor channels need to provide arguments. * It's better to provide the same mechanism for both *-user and softmmu (otherwise the application to simulate or the interposed librariy

Re: [Qemu-devel] Re: [RFC][PATCH 00/10] virtagent: host/guest RPC communication agent

2010-10-25 Thread Anthony Liguori
On 10/25/2010 05:30 AM, Andrew Beekhof wrote: On 10/22/2010 08:45 PM, Michael Roth wrote: This set of patches is meant to be applied on top of the Virtproxy v1 patchset. OVERVIEW: There are a wide range of use cases motivating the need for a guest agent of some sort to extend the

Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport defs

2010-10-25 Thread Anthony Liguori
On 10/22/2010 01:45 PM, Michael Roth wrote: Common code for sending/recieving RPCs via http over virtproxy channel. Eventually these will all be switched to asynchronous handlers to avoid deadlocks between qemu and the guest. For now we can usually get away with just doing asynchronous reads for

Re: [Qemu-devel] [RFC][PATCH 07/10] virtagent: add getdmesg RPC

2010-10-25 Thread Anthony Liguori
On 10/22/2010 01:46 PM, Michael Roth wrote: Add RPC to view guest dmesg output. Signed-off-by: Michael Rothmdr...@linux.vnet.ibm.com --- virtagent-daemon.c | 45 + virtagent-daemon.h |1 + 2 files changed, 46 insertions(+), 0 deletions(-)

[Qemu-devel] Re: instrument

2010-10-25 Thread Lluís
Blue Swirl writes: On Mon, Oct 25, 2010 at 11:13 AM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: A lot of internal state needs to be made available to the instrumentation code, which is a problem if that is considered as an API. I don't get what you mean by that. In principle, only

Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport defs

2010-10-25 Thread malc
On Mon, 25 Oct 2010, Anthony Liguori wrote: On 10/22/2010 01:45 PM, Michael Roth wrote: Common code for sending/recieving RPCs via http over virtproxy channel. Eventually these will all be switched to asynchronous handlers to avoid deadlocks between qemu and the guest. For now we can

Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport defs

2010-10-25 Thread Anthony Liguori
On 10/25/2010 04:54 PM, malc wrote: On Mon, 25 Oct 2010, Anthony Liguori wrote: On 10/22/2010 01:45 PM, Michael Roth wrote: Common code for sending/recieving RPCs via http over virtproxy channel. Eventually these will all be switched to asynchronous handlers to avoid deadlocks

Re: [Qemu-devel] Re: backdoor

2010-10-25 Thread Lluís
Anthony Liguori writes: On 10/25/2010 08:37 AM, Lluís wrote: I know extending the ISA is not nice at all, but I think that's much more maintainable than a per-guest OS interface (supposing some will need extra guest drivers). On x86, there are some architecturally nicer ways to do this.

Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport defs

2010-10-25 Thread malc
On Mon, 25 Oct 2010, Anthony Liguori wrote: On 10/25/2010 04:54 PM, malc wrote: On Mon, 25 Oct 2010, Anthony Liguori wrote: On 10/22/2010 01:45 PM, Michael Roth wrote: Common code for sending/recieving RPCs via http over virtproxy channel. Eventually these will all

Re: [Qemu-devel] Re: backdoor

2010-10-25 Thread Anthony Liguori
On 10/25/2010 05:48 PM, Lluís wrote: For instance, a CPUID leaf could be used in the 0x40001xxx range. Right, I commented this in a previous mail as a much nicer way to do it, but I was just too lazy to look up how CPUID works and instead ported the implementation I already had in bochs