[Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-08 Thread Gleb Natapov
Properly check array bounds before accessing array element. Signed-off-by: Gleb Natapov diff --git a/hw/usb-net.c b/hw/usb-net.c index 70f9263..84e2d79 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -1142,7 +1142,7 @@ static int usb_net_handle_control(USBDevice *dev, int request, int value,

Re: [Qemu-devel] smp: linux guest only sees 1 CPU when not using KVM

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 11:30:52PM +0100, Lluís wrote: > Lennart Sorensen writes: > > > On Mon, Nov 08, 2010 at 10:57:19PM +0100, Lluís wrote: > >> Well, thre's nothing more to add than the contents in the subject. > >> > >> I tried booting up with -smp 2, and /proc/cpuinfo on the linux guest > >

[Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 06:59:37PM -0500, Kevin O'Connor wrote: > On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote: > > vring_virtqueue should be zeroed otherwise old values will be reused > > after reboot. > > > > Signed-off-by: Gleb Natapov > > diff --git a/src/virtio-blk.c b/src/vi

Re: [Qemu-devel] [PATCH 3/3] Add helper functions to enable virtio-9p make use of the threadlets

2010-11-08 Thread Venkateswararao Jujjuri (JV)
On 11/8/2010 2:47 AM, Arun R Bharadwaj wrote: > From: Gautham R Shenoy > > infrastructure for offloading blocking tasks such as making posix calls on > to the helper threads and handle the post_posix_operations() from the > context of the iothread. This frees the vcpu thread to process any other

[Qemu-devel] Re: [patch 0/3] block migration fixes

2010-11-08 Thread Yoshiaki Tamura
Marcelo Tosatti wrote: > Following patchset fixes block migration corruption issues. Hi Marcelo, Thanks for looking into this issue. Although we tried your patches, we're still seeing the corruption. If we execute block migration while copying a file locally, md5sum of the copied file doesn't m

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Isaku Yamahata
On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > Replace bus number with slot numbers of parent bridges up to the root. > This works for root bridge in a compatible way because bus number there > is hard-coded to 0. > IMO nested bridges are broken anyway, no way to be compatibl

[Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

2010-11-08 Thread Ryan Harper
Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap where by mgmt applications that assume the block resource has been removed without confirming that the guest h

[Qemu-devel] [PATCH 0/2] v6 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
After *much* discussion, here's version 6. This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond le

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_del

2010-11-08 Thread Ryan Harper
Signed-off-by: Ryan Harper --- qmp-commands.hx | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..1e0d4e9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,35 @@ Example: EQMP

[Qemu-devel] [PATCH v2 2/2] rtl8139: add vlan tag extraction

2010-11-08 Thread Benjamin Poirier
Add support to the emulated hardware to remove vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier Cc: Igor V. Kovalenko --- Changes since v1: * moved the debug print statement inside the if block and reworded accordingly. (as suggested by Igor) AFAIK, e

[Qemu-devel] [PATCH v2 1/2] rtl8139: add vlan tag insertion

2010-11-08 Thread Benjamin Poirier
Add support to the emulated hardware to add vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier Cc: Igor V. Kovalenko --- Changes since v1: * moved the debug print statement inside the if block and reworded accordingly. (as suggested by Igor) hw/rtl8139.

Re: [Qemu-devel] [PATCH 1/2] rtl8139: add vlan tag insertion

2010-11-08 Thread Benjamin Poirier
On 08/11/10 11:34 AM, Stefan Hajnoczi wrote: > On Sun, Nov 7, 2010 at 9:25 PM, Benjamin Poirier > wrote: >> Add support to the emulated hardware to add vlan tags in packets going >> from the guest to the network. >> >> Signed-off-by: Benjamin Poirier >> Cc: Igor V. Kovalenko >> --- >> hw/rtl813

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-08 Thread Nigel Horne
Stefan, > You can grab the code like this: > git clone -b scsi_assert git://repo.or.cz/qemu/stefanha.git > > If the assert triggers in that world then data corruption was > previously possible but hidden (a SCSI request has a one data buffer > and concurrent reads are being issued to the same buffe

[Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot

2010-11-08 Thread Kevin O'Connor
On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote: > vring_virtqueue should be zeroed otherwise old values will be reused > after reboot. > > Signed-off-by: Gleb Natapov > diff --git a/src/virtio-blk.c b/src/virtio-blk.c > index 34d7863..7a25826 100644 > --- a/src/virtio-blk.c > +++ b/

[Qemu-devel] Single 64bit memory transaction instead of two 32bit memory transaction.

2010-11-08 Thread Adnan Khaleel
In the file exec.c: The memory Write/Read functions are declared as an array of 4 entries where the index values of 0,1,2 correspond to 8,16 and 32bit write and read functions respectively. CPUWriteMemoryFunc *io_mem_write[IO_MEM_NB_ENTRIES][4]; CPUReadMemoryFunc *io_mem_read[IO_MEM_NB_ENTRIES]

[Qemu-devel] running Uboot under QEMU

2010-11-08 Thread William Estrada
Hi group, I'm trying to build and run Uboot on my Fedora 13 laptop. I'm lost. Any 'How To'? -- William Estrada Mt Umunhum, CA, USA HTTP://64.124.13.3 ( Mt-Umunhum-Wireless.net ) Skype: MrUmunhum

[Qemu-devel] Re: [PATCH] intel-hda: add msi support

2010-11-08 Thread malc
On Mon, 8 Nov 2010, Gerd Hoffmann wrote: > This patch adds MSI support to the intel hda audio driver. It is > enabled by default, use '-device intel-hda,msi=0' to disable it. > > Signed-off-by: Gerd Hoffmann > --- > hw/intel-hda.c | 30 -- > 1 files changed, 28 in

[Qemu-devel] [PATCH 2/2] trace: enable all events by default

2010-11-08 Thread Lluís
Enable all trace events by default, assuming their frequency is relatively low, so there will be no measurable performace impact. Signed-off-by: Lluís Vilanova --- trace-events | 251 +- 1 files changed, 124 insertions(+), 127 deletions(-)

[Qemu-devel] [PATCH 1/2] trace: always use the "nop" backend on events with the "disable" keyword

2010-11-08 Thread Lluís
Any event with the keyword/property "disable" generates an empty trace event using the "nop" backend, regardless of the current backend. Generalize the "property" concept in the trace-events file, so tracetool now has: * get_name: Get only the event name * get_property: Return if a propery event

Re: [Qemu-devel] smp: linux guest only sees 1 CPU when not using KVM

2010-11-08 Thread Lluís
Lennart Sorensen writes: > On Mon, Nov 08, 2010 at 10:57:19PM +0100, Lluís wrote: >> Well, thre's nothing more to add than the contents in the subject. >> >> I tried booting up with -smp 2, and /proc/cpuinfo on the linux guest >> only return one CPU, while booting with "-smp 2 -enable-kvm" shows

[Qemu-devel] [PATCH] intel-hda: add msi support

2010-11-08 Thread Gerd Hoffmann
This patch adds MSI support to the intel hda audio driver. It is enabled by default, use '-device intel-hda,msi=0' to disable it. Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c | 30 -- 1 files changed, 28 insertions(+), 2 deletions(-) diff --git a/hw/intel-hda.c

Re: [Qemu-devel] smp: linux guest only sees 1 CPU when not using KVM

2010-11-08 Thread Lennart Sorensen
On Mon, Nov 08, 2010 at 10:57:19PM +0100, Lluís wrote: > Well, thre's nothing more to add than the contents in the subject. > > I tried booting up with -smp 2, and /proc/cpuinfo on the linux guest > only return one CPU, while booting with "-smp 2 -enable-kvm" shows 2 > CPUs. I was under the impre

Re: [Qemu-devel] Access to specific isa card with Qemu???

2010-11-08 Thread François Revol
Hi, > We have a software that runs on MS-DOS and must communicate with a specific > card installed on port isa. > We want to use this software in Qemu with a machine that runs XP. > Is it possible to access to the ISA port with Qemu in this case? > > Do we have to do a specific development? > C

[Qemu-devel] smp: linux guest only sees 1 CPU when not using KVM

2010-11-08 Thread Lluís
Well, thre's nothing more to add than the contents in the subject. I tried booting up with -smp 2, and /proc/cpuinfo on the linux guest only return one CPU, while booting with "-smp 2 -enable-kvm" shows 2 CPUs. Lluis -- "And it's much the same thing with knowledge, for whenever you learn some

[Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 07:29:50PM +0200, Gleb Natapov wrote: > > This will make it compatible with existing code and generally > > what users expect. > > > It will drop domain and bus number part anyway. Yes but the proposal was to add :00: in front to make it have the expected format for mo

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Michael S. Tsirkin
On Fri, Nov 05, 2010 at 05:01:49PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Nov 05, 2010 at 02:27:49PM +0100, Markus Armbruster wrote: > >> I'd be fine with any of these: > >> > >> 1. A new command "device_disconnet ID" (or similar name) to disconnect > >>

[Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 11:00:17PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:29:50PM +0200, Gleb Natapov wrote: > > > This will make it compatible with existing code and generally > > > what users expect. > > > > > It will drop domain and bus number part anyway. > > Yes but th

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 13:40 +0200, Michael S. Tsirkin wrote: > > > > On Wed, Oct 06, 2010 at 02:

Re: [Qemu-devel] [PATCH 2/2] Add support for generating a systemtap tapset static probes

2010-11-08 Thread Stefan Hajnoczi
On Mon, Nov 8, 2010 at 11:33 AM, Daniel P. Berrange wrote: > @@ -390,6 +396,54 @@ linetod_end_dtrace() > EOF > } > > +linetos_begin_dtrace() > +{ > +return > +} > + > +linetos_dtrace() > +{ > +local name args arglist state Missing binary, i, and arg. > +name=$(get_name "$1") > +

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-08 Thread Stefan Hajnoczi
On Mon, Nov 8, 2010 at 2:33 PM, Arun R Bharadwaj wrote: > diff --git a/Makefile.objs b/Makefile.objs > index cd5a24b..3b7ec27 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -9,6 +9,7 @@ qobject-obj-y += qerror.o > > block-obj-y = cutils.o cache-utils.o qemu-malloc.o qemu-option.o module.

Re: [Qemu-devel] [PATCH] trace: Trace SCSI request lifecycle

2010-11-08 Thread Stefan Hajnoczi
On Mon, Nov 8, 2010 at 7:18 PM, Blue Swirl wrote: > On Mon, Nov 8, 2010 at 9:44 AM, Stefan Hajnoczi > wrote: >> This patch adds trace events for SCSI request allocation, freeing, CDB >> parsing, read, and write.  These trace events can be used to instrument >> the SCSI request lifecycle. > > How

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Alex Williamson
On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: > > > > On Mon, 2010-11-08 at 13:40

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-08 Thread Blue Swirl
On Mon, Nov 8, 2010 at 2:36 PM, Stefan Hajnoczi wrote: > I just gave the SPARC Linux 2.6 image from qemu.org a spin on sun4m but no > luck: > > sparc-softmmu/qemu-system-sparc -kernel > '/tmp/sparc-test/vmlinux-2.6.11+tcx' -initrd > '/tmp/sparc-test/linux.img' -append "root=/dev/ram" -drive > if=

[Qemu-devel] [PATCH 0/2] Add support for SystemTAP and DTrace tracing backends (v5)

2010-11-08 Thread Daniel P. Berrange
A repost of the SystemTAP/DTrace patches from http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg00496.html The patch is now split into two pieces. The first patch contains the generic DTrace tracing backend support. The second patch contains additional pieces for SystemTAP to generate

[Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-08 Thread Daniel P. Berrange
This introduces a new tracing backend that targets the SystemTAP implementation of DTrace userspace tracing. The core functionality should be applicable and standard across any DTrace implementation on Solaris, OS-X, *BSD, but the Makefile rules will likely need some small additional changes to cop

[Qemu-devel] [PATCH 2/2] Add support for generating a systemtap tapset static probes

2010-11-08 Thread Daniel P. Berrange
This introduces generation of a qemu.stp/qemu-system-XXX.stp files which provides tapsets with friendly names for static probes & their arguments. Instead of probe process("qemu").mark("qemu_malloc") { printf("Malloc %d %p\n", $arg1, $arg2); } It is now possible todo probe qe

Re: [Qemu-devel] [PATCH] trace: Trace SCSI request lifecycle

2010-11-08 Thread Blue Swirl
On Mon, Nov 8, 2010 at 9:44 AM, Stefan Hajnoczi wrote: > This patch adds trace events for SCSI request allocation, freeing, CDB > parsing, read, and write.  These trace events can be used to instrument > the SCSI request lifecycle. How about converting also the DPRINTFs in hw/scsi-disk.c to trace

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-08 Thread Stefan Hajnoczi
On Mon, Nov 8, 2010 at 4:57 PM, Daniel P. Berrange wrote: > On Mon, Nov 08, 2010 at 04:52:01PM +, Stefan Hajnoczi wrote: >> On Mon, Nov 8, 2010 at 11:33 AM, Daniel P. Berrange >> wrote: >> > diff --git a/Makefile b/Makefile >> > index 02698e9..384bf72 100644 >> > --- a/Makefile >> > +++ b/Ma

[Qemu-devel] [patch 2/3] block: set sector dirty on AIO write completion

2010-11-08 Thread Marcelo Tosatti
Sectors are marked dirty in the bitmap on AIO submission. This is wrong since data has not reached storage. Set a given sector as dirty in the dirty bitmap on AIO completion, so that reading a sector marked as dirty is guaranteed to return uptodate data. Signed-off-by: Marcelo Tosatti Index: qe

[Qemu-devel] [patch 1/3] block: fix shift in dirty bitmap calculation

2010-11-08 Thread Marcelo Tosatti
Otherwise upper 32 bits of bitmap entries are not correctly calculated. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/block.c === --- qemu-kvm.orig/block.c +++ qemu-kvm/block.c @@ -930,14 +930,14 @@ static void set_dirty_bitmap(Blo

[Qemu-devel] [patch 3/3] block migration: do not submit multiple AIOs for same sector

2010-11-08 Thread Marcelo Tosatti
Block migration can submit multiple AIO reads for the same sector/chunk, but completion of such reads can happen out of order: migration guest - get_dirty(N) - aio_read(N) - clear_dirty(N) write(N) set_dirty(N) - get_dirty(N) - aio_rea

[Qemu-devel] [patch 0/3] block migration fixes

2010-11-08 Thread Marcelo Tosatti
Following patchset fixes block migration corruption issues.

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 12:39:01PM -0600, Ryan Harper wrote: > * Michael S. Tsirkin [2010-11-08 10:57]: > > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > > * Markus Armbruster [2010-11-08 06:04]: > > > > "Michael S. Tsirkin" writes: > > > > > > > > > On Mon, Nov 08, 2010 at 1

[Qemu-devel] Re: phys_page_find bug?

2010-11-08 Thread Artyom Tarasenko
On Fri, May 7, 2010 at 6:26 PM, Artyom Tarasenko wrote: > phys_page_find (exec.c) returns sometimes a page for addresses where > nothing is connected. > > One example, done with qemu-system-sparc -M SS-20 > > ok f130 2f spacec@ . > > // The address translates correctly, in cpu_physical_memory_

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
* Daniel P. Berrange [2010-11-08 11:05]: > On Mon, Nov 08, 2010 at 06:56:02PM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > > * Markus Armbruster [2010-11-08 06:04]: > > > > "Michael S. Tsirkin" writes: > > > > >> Here's how the various obj

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-08 10:57]: > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > * Markus Armbruster [2010-11-08 06:04]: > > > "Michael S. Tsirkin" writes: > > > > > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > > > >> Ryan Harper writes: >

[Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 08:12:55PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:29:50PM +0200, Gleb Natapov wrote: > > On Mon, Nov 08, 2010 at 07:17:37PM +0200, Michael S. Tsirkin wrote: > > > On Sun, Oct 31, 2010 at 01:40:08PM +0200, Gleb Natapov wrote: > > > > Domain should be de

[Qemu-devel] [PATCH] linux-user: remove unnecessary local from __get_user(), __put_user()

2010-11-08 Thread Peter Maydell
Remove an unnecessary local variable from the __get_user() and __put_user() macros. This avoids confusing compilation failures if the name of the local variable ('size') happens to be the same as the variable the macro user is trying to read/write. Signed-off-by: Peter Maydell --- linux-user/qem

[Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 07:29:50PM +0200, Gleb Natapov wrote: > On Mon, Nov 08, 2010 at 07:17:37PM +0200, Michael S. Tsirkin wrote: > > On Sun, Oct 31, 2010 at 01:40:08PM +0200, Gleb Natapov wrote: > > > Domain should be determined form parent bus and bus number is configured > > > by guest and sho

[Qemu-devel] Re: [PATCH 2/4] hda-audio: exit cleanup

2010-11-08 Thread malc
On Mon, 8 Nov 2010, Gerd Hoffmann wrote: > Add exit callback to the driver. Unregister the sound card properly > on exit. > > Signed-off-by: Gerd Hoffmann > --- > hw/hda-audio.c | 23 +++ > 1 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/hw/hda-audio.c

[Qemu-devel] Re: [PATCH] add VMSTATE_BOOL

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 01, 2010 at 03:51:54PM +0100, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > --- > hw/hw.h | 14 ++ > savevm.c | 21 + > 2 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/hw/hw.h b/hw/hw.h > index e935364..234c713 100644

[Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 07:17:37PM +0200, Michael S. Tsirkin wrote: > On Sun, Oct 31, 2010 at 01:40:08PM +0200, Gleb Natapov wrote: > > Domain should be determined form parent bus and bus number is configured > > by guest and should not be used in qemu internally. > > > > Signed-off-by: Gleb Natap

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 07:08:37PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:00:15PM +0200, Gleb Natapov wrote: > > On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > > > On Mon, 2010-11-

[Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func

2010-11-08 Thread Michael S. Tsirkin
On Sun, Oct 31, 2010 at 01:40:08PM +0200, Gleb Natapov wrote: > Domain should be determined form parent bus and bus number is configured > by guest and should not be used in qemu internally. > > Signed-off-by: Gleb Natapov > --- > hw/pci.c | 11 ++- > 1 files changed, 6 insertions(+),

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Alex Williamson
On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 13:40 +0200, Michael S. Tsirkin wrote: > > > On Wed, Oct 06, 2010 at 02:58:57PM -0600, Alex Williamson wrote: > > > > Our code paths for saving o

[Qemu-devel] Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func

2010-11-08 Thread Michael S. Tsirkin
On Sun, Oct 31, 2010 at 01:40:08PM +0200, Gleb Natapov wrote: > Domain should be determined form parent bus and bus number is configured > by guest and should not be used in qemu internally. > > Signed-off-by: Gleb Natapov > --- > hw/pci.c | 11 ++- > 1 files changed, 6 insertions(+),

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 07:00:15PM +0200, Gleb Natapov wrote: > On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 04, 2010 at

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 06:56:02PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > * Markus Armbruster [2010-11-08 06:04]: > > > "Michael S. Tsirkin" writes: > > > >> Here's how the various objects are connected to each other: > > > >> > > > >>

[Qemu-devel] Re: KVM call agenda for Nov 9

2010-11-08 Thread Anthony Liguori
On 11/08/2010 08:23 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. For once I start: - report from linux plumbers virt track (jes?, anthony?) - report from linux kernel summit (avi?) Good thinking. Regards, Anthony Liguori Cheers, Juan. -- To u

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > > pcibus_dev_print() w

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-08 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 04:52:01PM +, Stefan Hajnoczi wrote: > On Mon, Nov 8, 2010 at 11:33 AM, Daniel P. Berrange wrote: > > diff --git a/Makefile b/Makefile > > index 02698e9..384bf72 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1,6 +1,10 @@ > >  # Makefile for QEMU. > > > >  GENERAT

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > * Markus Armbruster [2010-11-08 06:04]: > > "Michael S. Tsirkin" writes: > > > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > > >> Ryan Harper writes: > > >> > > >> > * Markus Armbruster [2010-11-06 04:19

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 13:40 +0200, Michael S. Tsirkin wrote: > > On Wed, Oct 06, 2010 at 02:58:57PM -0600, Alex Williamson wrote: > > > Our code paths for saving or migrating a VM are full of functions that > > > return void, leavin

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-08 Thread Stefan Hajnoczi
On Mon, Nov 8, 2010 at 11:33 AM, Daniel P. Berrange wrote: > diff --git a/Makefile b/Makefile > index 02698e9..384bf72 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,6 +1,10 @@ >  # Makefile for QEMU. > >  GENERATED_HEADERS = config-host.h trace.h qemu-options.def > +GENERATED_HEADERS = config-h

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 09:36:59AM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 18:26 +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 04, 2010 at 03:

Re: [Qemu-devel] [RFC] tracing: consistent usage of "disable" in "trace-events"

2010-11-08 Thread Lluís
Daniel P Berrange writes: > On Mon, Nov 08, 2010 at 04:55:10PM +0100, Lluís wrote: >> In any case, there might appear other events that could have performance >> implications, although I understand the ease of usage of having all >> trace events available by default. > Ok, I agree that if we have

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Alex Williamson
On Mon, 2010-11-08 at 18:26 +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > > pcibus_dev_print() was erro

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 01:03:18PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > >> Ryan Harper writes: > >> > >> > * Markus Armbruster [2010-11-06 04:19]: > >> >> Ryan Harper writes: > >> >> > >> >>

Re: [Qemu-devel] [PATCH 1/2] rtl8139: add vlan tag insertion

2010-11-08 Thread Stefan Hajnoczi
On Sun, Nov 7, 2010 at 9:25 PM, Benjamin Poirier wrote: > Add support to the emulated hardware to add vlan tags in packets going > from the guest to the network. > > Signed-off-by: Benjamin Poirier > Cc: Igor V. Kovalenko > --- >  hw/rtl8139.c |   46 +++--

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > pcibus_dev_print() was erroneously retrieving the device bus > > > number from the secondary bus

[Qemu-devel] [PATCH 1/3] usb-linux: Store devpath into USBHostDevice when usb_fs_type == USB_FS_SYS

2010-11-08 Thread Hans de Goede
This allows us to recreate the sysfspath used during scanning later (which will be used in a later patch in this series). --- usb-linux.c | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index c3c38ec..61e8ec6 100644 -

[Qemu-devel] [PATCH 3/3] usb-linux: Get the active configuration from sysfs rather then asking the dev

2010-11-08 Thread Hans de Goede
Some devices seem to choke on receiving a USB_REQ_GET_CONFIGURATION ctrl msg (witnessed with a digital picture frame usb id 1908:1320). When usb_fs_type == USB_FS_SYS, the active configuration can be read directly from sysfs, which allows using this device through qemu's usb redirection. More in ge

[Qemu-devel] [PATCH 2/3] usb-linux: introduce a usb_linux_get_configuration function

2010-11-08 Thread Hans de Goede
The next patch in this series introduces multiple ways to get the configuration dependent upon usb_fs_type, it is cleaner to put this into its own function. --- usb-linux.c | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/usb-linux.c b/usb-linu

[Qemu-devel] [PATCH 0/3] usb-linux do not send unnecessary GET_CONFIGURATION

2010-11-08 Thread Hans de Goede
Hi All, First a short self-into. I've been a FOSS developer for 10+ years, working on a large variety of projects. Most relevant for my appearing here on the qemu list is my experience in reverse engineering and writing usb webcam drivers for the Linux kernel and libgphoto2 camlibs for various sma

[Qemu-devel] Access to specific isa card with Qemu???

2010-11-08 Thread Djamel Hakkar
Hello, We have a software that runs on MS-DOS and must communicate with a specific card installed on port isa. We want to use this software in Qemu with a machine that runs XP. Is it possible to access to the ISA port with Qemu in this case? Do we have to do a specific development? Can you help

Re: [Qemu-devel] [RFC] tracing: consistent usage of "disable" in "trace-events"

2010-11-08 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 04:55:10PM +0100, Lluís wrote: > Daniel P Berrange writes: > > > On Mon, Nov 08, 2010 at 03:42:15PM +0100, Lluís wrote: > >> On the current implementation, the "disable" keyword in "trace-events" > >> has different semantics, depending on the backend: > >> > >> * nop:

Re: [Qemu-devel] [RFC] tracing: consistent usage of "disable" in "trace-events"

2010-11-08 Thread Lluís
Daniel P Berrange writes: > On Mon, Nov 08, 2010 at 03:42:15PM +0100, Lluís wrote: >> On the current implementation, the "disable" keyword in "trace-events" >> has different semantics, depending on the backend: >> >> * nop: ignored (not a problem) >> * simple : enables tracing, but sets dynam

Re: [Qemu-devel] [RFC] tracing: consistent usage of "disable" in "trace-events"

2010-11-08 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 03:42:15PM +0100, Lluís wrote: > On the current implementation, the "disable" keyword in "trace-events" > has different semantics, depending on the backend: > > * nop: ignored (not a problem) > * simple : enables tracing, but sets dynamic state to disable > * ust: d

[Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-08 Thread Arun R Bharadwaj
From: Aneesh Kumar K.V This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The patch creates a global queue on-to which subsystems can queue their tasks to be executed asynchronously. The patch also provides API's that allow a subsystem to create a private

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Alex Williamson
On Mon, 2010-11-08 at 13:40 +0200, Michael S. Tsirkin wrote: > On Wed, Oct 06, 2010 at 02:58:57PM -0600, Alex Williamson wrote: > > Our code paths for saving or migrating a VM are full of functions that > > return void, leaving no opportunity for a device to cancel a migration, > > either from erro

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Alex Williamson
On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > pcibus_dev_print() was erroneously retrieving the device bus > > number from the secondary bus number offset of the device > > instead of the bridge above the device.

[Qemu-devel] [RFC] tracing: consistent usage of "disable" in "trace-events"

2010-11-08 Thread Lluís
On the current implementation, the "disable" keyword in "trace-events" has different semantics, depending on the backend: * nop: ignored (not a problem) * simple : enables tracing, but sets dynamic state to disable * ust: disables tracing (uses nop backend) * dtrace : same as simple Would

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-08 Thread Stefan Hajnoczi
I just gave the SPARC Linux 2.6 image from qemu.org a spin on sun4m but no luck: sparc-softmmu/qemu-system-sparc -kernel '/tmp/sparc-test/vmlinux-2.6.11+tcx' -initrd '/tmp/sparc-test/linux.img' -append "root=/dev/ram" -drive if=scsi,file=test.raw,cache=none The kernel correctly notices the sda de

[Qemu-devel] [RFC] tracing: per-CPU tracing state

2010-11-08 Thread Lluís
As more and more tracing backends appear (right now: nop, simple, ust and the new dtrace), it is harder to provide a tracetool where these backends can be efficiently used without being aware of per-CPU tracing state. What I have now is basically: * trace.h : trace_##name Backend-specific decla

[Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-08 Thread Arun R Bharadwaj
* Arun R Bharadwaj [2010-11-08 16:16:50]: Make paio subsystem use threadlets infrastructure From: Aneesh Kumar K.V This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The patch creates a global queue on-to which subsystems can queue their tasks to be exe

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-08 Thread Stefan Hajnoczi
On Mon, Nov 8, 2010 at 2:04 PM, Nigel Horne <671...@bugs.launchpad.net> wrote: >> You can grab the code like this: >> git clone -b scsi_assert git://repo.or.cz/qemu/stefanha.git >> >> > That retrieves a directory called scsi_assert which is empty.  Are you > expecting that?  Should I therefore use

[Qemu-devel] KVM call agenda for Nov 9

2010-11-08 Thread Juan Quintela
Please send in any agenda items you are interested in covering. For once I start: - report from linux plumbers virt track (jes?, anthony?) - report from linux kernel summit (avi?) Cheers, Juan.

Re: [Qemu-devel] [PATCH v2 5/6] backdoor: [i386] provide and implement intruction-based backdoor interface

2010-11-08 Thread Lluís
Gleb Natapov writes: > On Thu, Nov 04, 2010 at 11:36:15PM +0100, Lluís wrote: >> Take the unused CPUID 0x40001xxx range as the backdoor instruction. >> > In KVM (and it fits the spec nicely) cpuid is defined in terms of > tables. There is no callback that is called when particular cpuid is > que

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-08 Thread Nigel Horne
Stefan, > If it's not easy to share your disk image, could you please test this > QEMU tree which backports the assert: > > http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/scsi_assert > > You can grab the code like this: > git clone -b scsi_assert git://repo.or.cz/qemu/stefanha.git > >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
* Markus Armbruster [2010-11-08 06:04]: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > >> Ryan Harper writes: > >> > >> > * Markus Armbruster [2010-11-06 04:19]: > >> >> Ryan Harper writes: > >> >> > >> >> > * Markus Armbruster [20

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-08 Thread Nigel Horne
On 11/08/2010 05:42 AM, Stefan Hajnoczi wrote: > Hi Nigel, > Is there a disk image available to reproduce this bug? I searched for > Debian SPARC 2.4-based disk images but wasn't able to find one. > I got the image http://wiki.qemu.org/Download. It was sometime ago and it may no longer be th

[Qemu-devel] [PATCH 1/4] intel-hda: exit cleanup

2010-11-08 Thread Gerd Hoffmann
Add pci exit callback for the intel-hda device and cleanup properly. Also add an exit callback to the HDA bus implementation and make sure it is called on qdev_free(). Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c | 20 hw/intel-hda.h |1 + 2 files changed, 21 insert

[Qemu-devel] [PATCH 2/4] hda-audio: exit cleanup

2010-11-08 Thread Gerd Hoffmann
Add exit callback to the driver. Unregister the sound card properly on exit. Signed-off-by: Gerd Hoffmann --- hw/hda-audio.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/hda-audio.c b/hw/hda-audio.c index 1035774..5593c84 100644 --- a/hw/hda

[Qemu-devel] [PATCH 0/4] intel-hda: fixes

2010-11-08 Thread Gerd Hoffmann
Hi, This patch series brings a few fixes for the intel-hda driver. please apply, Gerd François Revol (1): intel-hda: Honor WAKEEN bits. Gerd Hoffmann (3): intel-hda: exit cleanup hda-audio: exit cleanup intel-hda: update irq status on WAKEEN changes. hw/hda-audio.c | 23

[Qemu-devel] [PATCH 4/4] intel-hda: update irq status on WAKEEN changes.

2010-11-08 Thread Gerd Hoffmann
When the guest updates the WAKEEN register we must re-calculate the IRQ status. Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 2c1ef12..e478e67 100644 --- a/hw/intel-hda.c +++ b/h

[Qemu-devel] [PATCH 3/4] intel-hda: Honor WAKEEN bits.

2010-11-08 Thread Gerd Hoffmann
From: François Revol HDA: Honor WAKEEN bits when deciding to raise an interrupt on codec status change. This prevents an interrupt storm with the Haiku HDA driver which does not handle codec status changes in the irq handler. Signed-off-by: François Revol Signed-off-by: Gerd Hoffmann --- hw/

Re: [Qemu-devel] [REFACTORED CODE] [PATCH 0/3] Threadlets: A generic task offloading framework.

2010-11-08 Thread Arun R Bharadwaj
* Arun R Bharadwaj [2010-11-08 16:16:50]: > Hi, > > This is the v9 of the refactored patch-series to have a generic > asynchronous task offloading framework (called threadlets) > within qemu. > > Testing carried out: I have run KVM autotest suite with this patch. This test suite ran successf

[Qemu-devel] [Bug 544527] Re: usbfs is bugged with >2.6.32.9 and <=2.6.33 (breaks VMWare, Qemu, sane scanners, ...)

2010-11-08 Thread David Kühling
This is not fixed in Ubuntu 10.10 (i.e. 32-bit apps running on 64-bit kernel get incorrectly truncated isochronous transfers). Re-opened a new bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/672516 -- usbfs is bugged with >2.6.32.9 and <=2.6.33 (breaks VMWare, Qemu, sane scann

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: >> Ryan Harper writes: >> >> > * Markus Armbruster [2010-11-06 04:19]: >> >> Ryan Harper writes: >> >> >> >> > * Markus Armbruster [2010-11-05 11:11]: >> >> >> Ryan Harper writes: >> >> >> >>

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Michael S. Tsirkin
On Wed, Oct 06, 2010 at 02:58:57PM -0600, Alex Williamson wrote: > Our code paths for saving or migrating a VM are full of functions that > return void, leaving no opportunity for a device to cancel a migration, > either from error or incompatibility. The ivshmem driver attempted to > solve this w

  1   2   >