[Qemu-devel] [Bug 432154] Re: dynamic block device attach/detach not functional with karmic KVM

2010-11-09 Thread Kiall
@Wolfgang I believe this is still an issue in maverick/10.10 aswell. I can attach a volume with UEC (10.10 metal and 10.10 instance). If you issue a `shutdown -r now` within the instance, the volume will be attached after the reboot... just spent about 8 hours getting that far! -- dynamic block

[Qemu-devel] patch errors

2010-11-09 Thread chandra shekar
hi everyone i have tried to apply the patch http://lists.gnu.org/archive/html/qemu-devel/2009-01/msg01213.html to qemu but when i do patch -p1

Re: [Qemu-devel] [Bug 670769] Re: CDROM size not updated when changing image files

2010-11-09 Thread agraf
On 10.11.2010, at 04:17, Alex Davis wrote: > Please note that until this bug is fixed, one cannot successfully > install a guest OS from a set of CD-ROMS where the first disk image is > smaller than subsequent ones. > > -- > CDROM size not updated when changing image files > https://bugs.launch

[Qemu-devel] [Bug 670769] Re: CDROM size not updated when changing image files

2010-11-09 Thread Alex Davis
Please note that until this bug is fixed, one cannot successfully install a guest OS from a set of CD-ROMS where the first disk image is smaller than subsequent ones. -- CDROM size not updated when changing image files https://bugs.launchpad.net/bugs/670769 You received this bug notification beca

Re: [Qemu-devel] Re: [RFC][RESEND][PATCH v1 02/15] virtproxy: qemu-vp, standalone daemon skeleton

2010-11-09 Thread Michael Roth
On 11/09/2010 04:45 AM, Amit Shah wrote: On (Fri) Nov 05 2010 [08:32:30], Adam Litke wrote: On Thu, 2010-11-04 at 08:57 -0500, Michael Roth wrote: This resembles vl.c's main_loop_wait() but I can see why you might want your own. There is opportunity for sharing the select logic and ioh callbac

Re: [Qemu-devel] [PATCH 3/3] Add helper functions to enable virtio-9p make use of the threadlets

2010-11-09 Thread Venkateswararao Jujjuri (JV)
On 11/9/2010 1:06 AM, Stefan Hajnoczi wrote: > On Mon, Nov 8, 2010 at 10:47 AM, Arun R Bharadwaj > wrote: >> diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c >> index 7c59988..61b65fd 100644 >> --- a/hw/virtio-9p.c >> +++ b/hw/virtio-9p.c >> @@ -18,6 +18,7 @@ >> #include "fsdev/qemu-fsdev.h" >> #inc

Re: [Qemu-devel] Re: [PATCH] spice: add audio

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Fran?ois Revol wrote: > > > >> Add support for the spice audio interface. With this patch applied > >> audio can be forwarded over the network from/to the spice client. Both > >> recording and playback is supported. > >> > >> The driver is first in the driver list, but the

Re: [Qemu-devel] Re: [PATCH] spice: add audio

2010-11-09 Thread François Revol
> >> Add support for the spice audio interface. With this patch applied >> audio can be forwarded over the network from/to the spice client. Both >> recording and playback is supported. >> >> The driver is first in the driver list, but the can_be_default flag is >> set only in case spice is act

[Qemu-devel] Re: [PATCH] spice: add audio (Gerd Hoffmann)

2010-11-09 Thread François Revol
>>> Add support for the spice audio interface. With this patch applied >>> audio can be forwarded over the network from/to the spice client. Both >>> recording and playback is supported. >>> Interesting :) The new file misses a copyright & license header I'd say. François.

[Qemu-devel] Re: [PATCH 1/3] usb-linux: Store devpath into USBHostDevice when usb_fs_type == USB_FS_SYS

2010-11-09 Thread Yuriy Kaminskiy
Hans de Goede wrote: > This allows us to recreate the sysfspath used during scanning later > (which will be used in a later patch in this series). > --- > usb-linux.c | 29 +++-- > 1 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/usb-linux.c b/usb-linu

[Qemu-devel] Re: [PATCH] spice: add audio

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > Add support for the spice audio interface. With this patch applied > audio can be forwarded over the network from/to the spice client. Both > recording and playback is supported. > > The driver is first in the driver list, but the can_be_default flag i

Re: [Qemu-devel] [patch] performance counters from inside of Qemu

2010-11-09 Thread Lluís
Vince Weaver writes: [...] > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 26ea1e5..f2aa2d7 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -31,6 +31,20 @@ > //#define DEBUG_MMU > +long long global_ins_count[3] = {0,0,0}; > + > +void helper_insn_count(u

Re: [Qemu-devel] networking issue

2010-11-09 Thread Mulyadi Santosa
On Mon, Nov 8, 2010 at 16:31, chandra shekar wrote: > i have installed ubunt 8.04 in qemu and my host os qemu 10.04 but iam unable > to browse > the internet in guest ubuntu and i have tried many options and many forums > say > the default ip the guest will be 10.0.2.15 but the guest is not assign

Re: [Qemu-devel] [patch] performance counters from inside of Qemu

2010-11-09 Thread Vince Weaver
On Sat, 6 Nov 2010, Stefan Hajnoczi wrote: > On Thu, Nov 4, 2010 at 7:20 PM, Vince Weaver wrote: > > This is mostly a proof of concept, I'm not sure if anyone is interested in > > this.  It could in theory be useful for tracking down performance problems > > from iside of Qemu using existing to

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 10:44 -0700, Alex Williamson wrote: > On Tue, 2010-11-09 at 18:49 +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 09, 2010 at 09:30:45AM -0700, Alex Williamson wrote: > > > On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: > > > > On Tue, Nov 09, 2010 at 08:47:00AM

[Qemu-devel] Re: [PATCH] Overwrite argv to set process title, eliminating 16-character prctl() limit.

2010-11-09 Thread John Morrissey
On Sun, Nov 07, 2010 at 09:49:27PM +0100, Torsten Förtsch wrote: > I am quite new to the list but why not do both call prctl(PR_SET_NAME, > name) and overwrite argv? > > The point is some tools read /proc/PID/cmdline but others the name field in > /proc/PID/status. The former is changed by overwr

Re: [Qemu-devel] Single 64bit memory transaction instead of two 32bit memory transaction.

2010-11-09 Thread Blue Swirl
On Mon, Nov 8, 2010 at 11:27 PM, Adnan Khaleel wrote: > In the file exec.c: > > The memory Write/Read functions are declared as an array of 4 entries where > the index values of 0,1,2 correspond to 8,16 and 32bit write and read > functions respectively. > > CPUWriteMemoryFunc *io_mem_write[IO_MEM_

[Qemu-devel] Re: phys_page_find bug?

2010-11-09 Thread Blue Swirl
On Mon, Nov 8, 2010 at 6:55 PM, Artyom Tarasenko wrote: > On Fri, May 7, 2010 at 6:26 PM, Artyom Tarasenko > wrote: >> phys_page_find (exec.c) returns sometimes a page for addresses where >> nothing is connected. >> >> One example, done with qemu-system-sparc -M SS-20 >> >> ok f130 2f spacec@

Re: [Qemu-devel] [PATCH] trace: Trace SCSI request lifecycle

2010-11-09 Thread Blue Swirl
On Mon, Nov 8, 2010 at 9:30 PM, Stefan Hajnoczi wrote: > On Mon, Nov 8, 2010 at 7:18 PM, Blue Swirl wrote: >> On Mon, Nov 8, 2010 at 9:44 AM, Stefan Hajnoczi >> wrote: >>> This patch adds trace events for SCSI request allocation, freeing, CDB >>> parsing, read, and write.  These trace events can

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 18:49 +0200, Michael S. Tsirkin wrote: > On Tue, Nov 09, 2010 at 09:30:45AM -0700, Alex Williamson wrote: > > On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: > > > On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: > > > > > > But it could. What if

[Qemu-devel] Re: [PATCH] spice: add audio

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > On 11/09/10 17:36, malc wrote: > > On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > > > > > Add support for the spice audio interface. With this patch applied > > > audio can be forwarded over the network from/to the spice client. Both > > > recording and pl

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-09 Thread Nigel Horne
Stefan, > $ /sbin/fdisk -lu ~njh/qemu/sparc/debian.img > ...hopefully this displays the slices/partitions... > Device Boot Start End Blocks > Id System > test.raw1 *2048 1026047 512000 83 Linux > > $ mount -o loop,offset=$((2048 * 5

[Qemu-devel] Re: [PATCH] spice: add audio

2010-11-09 Thread Gerd Hoffmann
On 11/09/10 17:36, malc wrote: On Tue, 9 Nov 2010, Gerd Hoffmann wrote: Add support for the spice audio interface. With this patch applied audio can be forwarded over the network from/to the spice client. Both recording and playback is supported. The driver is first in the driver list, but t

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 09:30:45AM -0700, Alex Williamson wrote: > On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: > > > > > But it could. What if ivshmem is acting in a peer role, but has no > > > > > clients, could

[Qemu-devel] Re: [PATCH] spice: add audio

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > Add support for the spice audio interface. With this patch applied > audio can be forwarded over the network from/to the spice client. Both > recording and playback is supported. > > The driver is first in the driver list, but the can_be_default flag i

[Qemu-devel] [PATCH] spice: add audio

2010-11-09 Thread Gerd Hoffmann
Add support for the spice audio interface. With this patch applied audio can be forwarded over the network from/to the spice client. Both recording and playback is supported. The driver is first in the driver list, but the can_be_default flag is set only in case spice is active. So if you have

[Qemu-devel] KVM call minutes for Nov 9

2010-11-09 Thread Chris Wright
linux plumbers - qemu talks, including xen folks efforts to get patches upstream - considering virtio - considering seabios - even some xenner interest - seabios presentation - uefi - still needs CSM support (lot of work) to be the only BIOS - otherwise need legacy BIOS and UEFI and users

[Qemu-devel] Re: [PATCH] intel-hda: fix codec addressing.

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > The HDA bus supports up to 15 codecs, with addresses 0 ... 14. > We get that wrong in two places: > > * When handing out addresses we accept address 15 as valid. > * The bitmasks for two registers (WAKEEN and STATESTS) don't >have bit 14 set. > >

Re: [Qemu-devel] [PATCH v2 6/6] intel-hda: fix codec addressing.

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > The HDA bus supports up to 15 codecs, with addresses 0 ... 14. > We get that wrong in two places: > > * When handing out addresses we accept address 15 as valid. > * The bitmasks for two registers (WAKEEN and STATESTS) don't >have bit 14 set. > >

[Qemu-devel] [PATCH] intel-hda: fix codec addressing.

2010-11-09 Thread Gerd Hoffmann
The HDA bus supports up to 15 codecs, with addresses 0 ... 14. We get that wrong in two places: * When handing out addresses we accept address 15 as valid. * The bitmasks for two registers (WAKEEN and STATESTS) don't have bit 14 set. This patch fixes it. [ v2: codestyle: add braces ] Signe

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: > > > But it could. What if ivshmem is acting in a peer role, but has no > > > clients, could it migrate? What if ivshmem is migratable when the > > > migration begins, but while the migration continues, a connection is > > > setup

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: > On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: > > > > But it could. What if ivshmem is acting in a peer role, but has no > > > > clients, could it migrate? What if ivshmem is migratable when the > > > > migration be

[Qemu-devel] [PATCH] pci: fix device path for devices behind nested bridges

2010-11-09 Thread Michael S. Tsirkin
We were using bus number in the device path, which is clearly broken as this number is guest-assigned for all devices except the root. Fix by using hierarchical list of slot/function numbers, walking the path from root down to device, instead. Add :00 as bus number so that if there are no nested b

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 17:42 +0200, Michael S. Tsirkin wrote: > On Tue, Nov 09, 2010 at 08:34:54AM -0700, Alex Williamson wrote: > > On Tue, 2010-11-09 at 17:07 +0200, Michael S. Tsirkin wrote: > > > On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: > > > > On Tue, 2010-11-09 at 14:00

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 08:34:54AM -0700, Alex Williamson wrote: > On Tue, 2010-11-09 at 17:07 +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: > > > On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Nov 08, 2010 at 02:

Re: [Qemu-devel] [RFC] tracing: per-CPU tracing state

2010-11-09 Thread Stefan Hajnoczi
On Tue, Nov 9, 2010 at 3:11 PM, Lluís wrote: > Stefan Hajnoczi writes: > >> On Mon, Nov 8, 2010 at 2:35 PM, Lluís wrote: >>> Another important change would be to provide a generic interface inside >>> QEMU that provides a programmatic control of the tracing state of all >>> events (both per-cpu a

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 17:07 +0200, Michael S. Tsirkin wrote: > On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: > > On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: > > > > On Mon, 2010-11-08 at 22:59

[Qemu-devel] Re: KVM: High CPU load with audio enabled

2010-11-09 Thread Michael Tokarev
09.11.2010 16:48, malc wrote: > On Tue, 9 Nov 2010, Jan Kiszka wrote: > >> Am 09.11.2010 00:48, Michael Tokarev wrote: [] >>> Yes, sound in 0.13 appears to be broken. It is looping in >>> select/read loop forever, read returns EAGAIN and select >>> says the filedescriptor is ready. >> >> Try to s

[Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-09 Thread Lluís
Enable all trace events by default, assuming their frequency is relatively low, so there will be no measurable performace impact. Signed-off-by: Lluís Vilanova --- trace-events | 251 +- 1 files changed, 124 insertions(+), 127 deletions(-)

[Qemu-devel] [PATCH v2 2/3] trace: always use the "nop" backend on events with the "disable" keyword

2010-11-09 Thread Lluís
Any event with the keyword/property "disable" generates an empty trace event using the "nop" backend, regardless of the current backend. Generalize the "property" concept in the trace-events file, so tracetool now has: * get_name: Get only the event name * get_property: Return if an event propert

Re: [Qemu-devel] [PATCH v2 1/3] trace: [ust] fix generation of 'trace.c' on events without args

2010-11-09 Thread Stefan Hajnoczi
On Tue, Nov 9, 2010 at 2:08 PM, Lluís wrote: > Signed-off-by: Lluís Vilanova > --- >  tracetool |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-09 Thread Gerd Hoffmann
On 11/02/10 12:15, Gerd Hoffmann wrote: Hi, How does password expiration help with security at all? VNC passwords are obviously rather weak, so if you can limit the time the password is valid to the window in which you are expecting the incoming VNC connection this limits the time to attack

Re: [Qemu-devel] [PATCH v2 0/6] intel-hda: bugfixes and msi support

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > Hi, > > This patch series brings a bunch of bugfixes for the intel-hda driver > and it also adds MSI support to reduce interrupt sharing. Applied. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [vgabios patch v2 00/11] vgabios update

2010-11-09 Thread Gerd Hoffmann
On 11/03/10 12:41, Gerd Hoffmann wrote: Hi, This patch series updates the vgabios, the patches are intended for the vgabios.git tree @ git.qemu.org [ ... ] The following changes since commit 6e62666cfc19e7fd45dd0d7c3ad62fd8d0b5f67a: - added DPMS support to cirrus vgabios (patch from G

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-09 Thread Stefan Hajnoczi
On Tue, Nov 9, 2010 at 1:28 PM, Nigel Horne <671...@bugs.launchpad.net> wrote: > Stefan, >> Would it be possible to share your the kernel image (vmlinuz) and >> initrd file?  That's all we need to reproduce the bug. >> > > Sure - how do I create them from the Image file I have?  (I don't use an > e

[Qemu-devel] Re: [PATCH] add VMSTATE_BOOL

2010-11-09 Thread Gerd Hoffmann
On 11/09/10 14:05, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 12:50:11PM +0100, Gerd Hoffmann wrote: Hi, +static int get_bool(QEMUFile *f, void *pv, size_t size) +{ +bool *v = pv; +*v = qemu_get_byte(f); +return 0; I think we should verify that value is 0 or 1 and fail

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-09 Thread Stefan Hajnoczi
On Tue, Nov 9, 2010 at 12:06 PM, Arun R Bharadwaj wrote: > * Stefan Hajnoczi [2010-11-08 21:29:12]: > >> On Mon, Nov 8, 2010 at 2:33 PM, Arun R Bharadwaj >> wrote: >> > diff --git a/Makefile.objs b/Makefile.objs >> > index cd5a24b..3b7ec27 100644 >> > --- a/Makefile.objs >> > +++ b/Makefile.objs

Re: [Qemu-devel] [RFC] tracing: per-CPU tracing state

2010-11-09 Thread Stefan Hajnoczi
On Mon, Nov 8, 2010 at 2:35 PM, Lluís wrote: > As more and more tracing backends appear (right now: nop, simple, ust > and the new dtrace), it is harder to provide a tracetool where these > backends can be efficiently used without being aware of per-CPU tracing > state. Per-CPU as in per-vcpu or

Re: [Qemu-devel] [PATCH 0/3]: QMP: Improve demo scripts

2010-11-09 Thread Markus Armbruster
Luiz Capitulino writes: > Please, check individual patches for details. I skimmed them, couldn't spot any problems. PATCH 1 breaks qmp-shell, PATCH 2 unbreaks it. Bisectability no-no in theory, but unlikely to bite in practice. Not worth a respin.

[Qemu-devel] Re: KVM: High CPU load with audio enabled

2010-11-09 Thread malc
On Tue, 9 Nov 2010, Jan Kiszka wrote: > Am 09.11.2010 00:48, Michael Tokarev wrote: > > 08.11.2010 15:40, Stefan Pietsch wrote: > >> Hi, > >> > >> I'm running a Windows XP guest in KVM. After enabling the audio support > >> (-soundhw es1370) the CPU load of the KVM process in the host system > >>

[Qemu-devel] Re: [patch 0/3] block migration fixes

2010-11-09 Thread Marcelo Tosatti
On Tue, Nov 09, 2010 at 03:02:12PM +0900, Yoshiaki Tamura wrote: > Marcelo Tosatti wrote: > > Following patchset fixes block migration corruption issues. > > Hi Marcelo, > > Thanks for looking into this issue. Although we tried your patches, we're > still > seeing the corruption. If we execute

Re: [Qemu-devel] [PATCH 0/3] spice: misc bugfixes

2010-11-09 Thread Gerd Hoffmann
On 11/02/10 12:56, Gerd Hoffmann wrote: Hi, This patch series brings a few bugfixes for spice. please pull, Gerd The following changes since commit 7d72e76228351d18a856f1e4f5365b59d3205dc3: intel-hda: documentation update (2010-11-02 00:41:04 +0300) are available in the git reposit

[Qemu-devel] Re: [PATCH] add VMSTATE_BOOL

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 12:50:11PM +0100, Gerd Hoffmann wrote: > Hi, > > +static int get_bool(QEMUFile *f, void *pv, size_t size) > +{ > +bool *v = pv; > +*v = qemu_get_byte(f); > +return 0; > > >I think we should verify that value is 0 or 1 and fail > >migration

[Qemu-devel] Re: [PATCH 0/2] v6 Decouple block device removal from device removal

2010-11-09 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 08:25:52PM -0600, Ryan Harper wrote: > After *much* discussion, here's version 6. > > This patch series decouples the detachment of a block device from the removal > of the backing pci-device. Removal of a hotplugged pci device requires the > guest to respond before qemu t

[Qemu-devel] Re: [patch 3/3] block migration: do not submit multiple AIOs for same sector

2010-11-09 Thread Kevin Wolf
Am 08.11.2010 20:02, schrieb Marcelo Tosatti: > Block migration can submit multiple AIO reads for the same sector/chunk, but > completion of such reads can happen out of order: > > migration guest > - get_dirty(N) > - aio_read(N) > - clear_dirty(N) > write(N)

Re: [Qemu-devel] Re: [patch 3/3] block migration: do not submit multiple AIOs for same sector

2010-11-09 Thread Marcelo Tosatti
On Tue, Nov 09, 2010 at 01:42:10PM +0100, Kevin Wolf wrote: > > +static int bmds_aio_inflight(BlkMigDevState *bmds, int64_t sector) > > +{ > > +int64_t chunk = sector / (int64_t)BDRV_SECTORS_PER_DIRTY_CHUNK; > > + > > +if (bmds->aio_bitmap && > > Is bmds->aio_bitmap ever supposed to be NUL

[Qemu-devel] [PATCH 3/4] add ccid-card-emulated device (v2)

2010-11-09 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy --- Makefile.objs |2 +- configure | 21 ++ hw/ccid-card-emulated.c | 492 ++

Re: [Qemu-devel] [PATCH v3 0/4] use new vgabios.

2010-11-09 Thread Gerd Hoffmann
On 11/03/10 12:56, Gerd Hoffmann wrote: Hi, This patch series will put the new vgabios into use for stdvga and vmware_vga. The vgabios patches this patch series depends on have just been posted to the list. For obvious reasons it depends on the new vgabios binaries being present, i.e. vgabi

[Qemu-devel] [PATCH v2 1/3] trace: [ust] fix generation of 'trace.c' on events without args

2010-11-09 Thread Lluís
Signed-off-by: Lluís Vilanova --- tracetool |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tracetool b/tracetool index 7010858..f0fe01d 100755 --- a/tracetool +++ b/tracetool @@ -275,6 +275,7 @@ linetoc_ust() name=$(get_name "$1") args=$(get_args "$1") a

Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-09 Thread Nigel Horne
Stefan, > Would it be possible to share your the kernel image (vmlinuz) and > initrd file? That's all we need to reproduce the bug. > Sure - how do I create them from the Image file I have? (I don't use an external kernel image and initrd file to boot) > Stefan > > -Nigel -- Sparc gue

[Qemu-devel] [PATCH 4/4] ccid: add docs

2010-11-09 Thread Alon Levy
--- docs/ccid.txt | 133 + 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff --git a/docs/ccid.txt b/docs/ccid.txt new file mode 100644 index 000..5eac611 --- /dev/null +++ b/docs/ccid.txt @@ -0,0

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 11:41:43AM +0900, Isaku Yamahata wrote: > On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > > Replace bus number with slot numbers of parent bridges up to the root. > > This works for root bridge in a compatible way because bus number there > > is hard-co

[Qemu-devel] Re: [PATCH] add VMSTATE_BOOL

2010-11-09 Thread Gerd Hoffmann
Hi, +static int get_bool(QEMUFile *f, void *pv, size_t size) +{ +bool *v = pv; +*v = qemu_get_byte(f); +return 0; I think we should verify that value is 0 or 1 and fail migration otherwise, to make it more robust. I still think such a check doesn't belong into the migration co

Re: [Qemu-devel] Re: [PATCH] pc: Fix e820 fw_cfg for big endian

2010-11-09 Thread Alexander Graf
On 09.11.2010, at 11:57, Jes Sorensen wrote: > On 11/08/10 04:57, Alex Williamson wrote: >> Signed-off-by: Alex Williamson >> --- >> >> Compile tested only. Only current user is kvm, no cross-arch users. >> >> hw/pc.c | 14 +++--- >> 1 files changed, 7 insertions(+), 7 deletions(-) >

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-09 Thread Arun R Bharadwaj
* Stefan Hajnoczi [2010-11-08 21:29:12]: > On Mon, Nov 8, 2010 at 2:33 PM, Arun R Bharadwaj > wrote: > > diff --git a/Makefile.objs b/Makefile.objs > > index cd5a24b..3b7ec27 100644 > > --- a/Makefile.objs > > +++ b/Makefile.objs > > @@ -9,6 +9,7 @@ qobject-obj-y += qerror.o > > > > block-obj-y

[Qemu-devel] Re: [PATCH 0/3] usb-linux do not send unnecessary GET_CONFIGURATION

2010-11-09 Thread Gerd Hoffmann
Hi, It failed at the first device I threw at it (a usb keychain picture frame), the problem is that this (el cheapo) device does not seem to grok GET_CONFIGURATION. This patch sets makes this device work (and stops qemu from unnecessary sending a GET_CONFIGURATION ctrl msg in general) by readi

[Qemu-devel] [PATCH 0/4] usb-ccid (v5)

2010-11-09 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. v4->v5 changes: * rebased to latest * remove static debug in card devices * fix --ena

[Qemu-devel] [PATCH 3/4] add ccid-card-emulated device (v2)

2010-11-09 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy --- Makefile.objs |2 +- configure | 21 ++ hw/ccid-card-emulated.c | 495 ++

[Qemu-devel] Re: [PATCH] add VMSTATE_BOOL

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 10:37:37AM +0100, Gerd Hoffmann wrote: > Hi, > > >>+#define VMSTATE_BOOL_ARRAY(_f, _s, _n) \ > >>+VMSTATE_BOOL_ARRAY_V(_f, _s, _n, 0) > >>+ > > > >Why don't we pack the bits? > > Point being? As long as we don't save *big* arrays of boo

[Qemu-devel] Re: [PATCH] add VMSTATE_BOOL

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 02:28:37PM +0100, Gerd Hoffmann wrote: > On 11/09/10 14:05, Michael S. Tsirkin wrote: > >On Tue, Nov 09, 2010 at 12:50:11PM +0100, Gerd Hoffmann wrote: > >> Hi, > >> > >>+static int get_bool(QEMUFile *f, void *pv, size_t size) > >>+{ > >>+bool *v = pv; > >>

[Qemu-devel] [PATCH 0/4] usb-ccid (v6)

2010-11-09 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. v5->v6 changes: * really remove static debug (I apologize for claiming to have done so

[Qemu-devel] [Bug 673009] [NEW] Latest git crashes in if_start with netBSD guest

2010-11-09 Thread Nigel Horne
Public bug reported: The latest version in git (cfd07e7abb1ef39373cd4ce312b015d61b9eea8d) crashes when running a NetBSD guest Host OS: Debian Linux/x86_64 5.0 C Compiler: 4.4.5 Guest OS:NetBSD/i386 5.0.2 Command Line: Build Configure: ./configure --enable-linux-aio --enable-io-thread --enable-kv

Re: [Qemu-devel] smp: linux guest only sees 1 CPU when not using KVM

2010-11-09 Thread Lluís
Gleb Natapov writes: > Yes. Qemu should emulate smp fine. What "info cpus" in monitor shows? > Anything interesting in dmesg? Hmpf. I tried again with a clean version, so either I was too sleepy yesterday or my changes unexpectedly broke SMP. As I still have to resolve some conflicts, I'll try l

[Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-11-09 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

Re: [Qemu-devel] [PATCH 0/4] usb-ccid (v5)

2010-11-09 Thread Alon Levy
NACK self. Forgot the statics. On Tue, Nov 09, 2010 at 01:40:07PM +0200, Alon Levy wrote: > This patchset adds three new devices, usb-ccid, ccid-card-passthru and > ccid-card-emulated, providing a CCID bus, a simple passthru protocol > implementing card requiring a client, and a standalone emulate

[Qemu-devel] Re: [patch 2/3] block: set sector dirty on AIO write completion

2010-11-09 Thread Kevin Wolf
Am 08.11.2010 20:02, schrieb Marcelo Tosatti: > Sectors are marked dirty in the bitmap on AIO submission. This is wrong > since data has not reached storage. > > Set a given sector as dirty in the dirty bitmap on AIO completion, so that > reading a sector marked as dirty is guaranteed to return up

[Qemu-devel] Re: [patch 1/3] block: fix shift in dirty bitmap calculation

2010-11-09 Thread Kevin Wolf
Am 08.11.2010 20:02, schrieb Marcelo Tosatti: > Otherwise upper 32 bits of bitmap entries are not correctly calculated. > > Signed-off-by: Marcelo Tosatti Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH 2/4] ccid: add passthru card device

2010-11-09 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea Signed-off-by: Alon Levy --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 277 ++

Re: [Qemu-devel] Re: [PATCH] pc: Fix e820 fw_cfg for big endian

2010-11-09 Thread Jes Sorensen
On 11/09/10 13:42, Alexander Graf wrote: > > On 09.11.2010, at 11:57, Jes Sorensen wrote: > >> On 11/08/10 04:57, Alex Williamson wrote: >>> Signed-off-by: Alex Williamson >>> --- >>> >>> Compile tested only. Only current user is kvm, no cross-arch users. >>> >>> hw/pc.c | 14 +++--- >

[Qemu-devel] [PATCH 4/4] ccid: add docs

2010-11-09 Thread Alon Levy
--- docs/ccid.txt | 133 + 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff --git a/docs/ccid.txt b/docs/ccid.txt new file mode 100644 index 000..5eac611 --- /dev/null +++ b/docs/ccid.txt @@ -0,0

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Nov 08, 2010 at 07:

Re: [Qemu-devel] Re: [PATCH] Delete IOHandlers after potentially running them

2010-11-09 Thread Stefan Hajnoczi
On Wed, Nov 3, 2010 at 6:39 PM, Juan Quintela wrote: > Anthony Liguori wrote: >> On 11/03/2010 10:12 AM, Juan Quintela wrote: >>> Anthony Liguori  wrote: >>> On 11/03/2010 09:29 AM, Stefan Hajnoczi wrote: > Since commit 4bed9837309e58d208183f81d8344996744292cf an .fd_read() > ha

[Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-11-09 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH 2/4] ccid: add passthru card device

2010-11-09 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea Signed-off-by: Alon Levy --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 278 ++

[Qemu-devel] Re: KVM: High CPU load with audio enabled

2010-11-09 Thread Michael Tokarev
09.11.2010 17:33, Michael Tokarev wrote: > 09.11.2010 16:48, malc wrote: >> On Tue, 9 Nov 2010, Jan Kiszka wrote: >> >>> Am 09.11.2010 00:48, Michael Tokarev wrote: > [] Yes, sound in 0.13 appears to be broken. It is looping in select/read loop forever, read returns EAGAIN and select >>>

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: > > > > On Mon, 2010-11-08 at 18:54

Re: [Qemu-devel] [RFC] tracing: per-CPU tracing state

2010-11-09 Thread Lluís
Stefan Hajnoczi writes: > On Mon, Nov 8, 2010 at 2:35 PM, Lluís wrote: >> As more and more tracing backends appear (right now: nop, simple, ust >> and the new dtrace), it is harder to provide a tracetool where these >> backends can be efficiently used without being aware of per-CPU tracing >> sta

[Qemu-devel] Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: > On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Nov 08, 2010 at 10:

[Qemu-devel] Re: [PATCH] pc: Fix e820 fw_cfg for big endian

2010-11-09 Thread Jes Sorensen
On 11/08/10 04:57, Alex Williamson wrote: > Signed-off-by: Alex Williamson > --- > > Compile tested only. Only current user is kvm, no cross-arch users. > > hw/pc.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) Patch looks fine to me, but are there any systems out

[Qemu-devel] [PATCH v2 1/6] intel-hda: exit cleanup

2010-11-09 Thread Gerd Hoffmann
Add pci exit callback for the intel-hda device and cleanup properly. Also add an exit callback to the HDA bus implementation and make sure it is called on qdev_free(). Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c | 20 hw/intel-hda.h |1 + 2 files changed, 21 insert

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-09 Thread Markus Armbruster
Gleb Natapov writes: > On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> > Properly check array bounds before accessing array element. >>

Re: [Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-11-09 Thread Alon Levy
On Tue, Nov 09, 2010 at 11:11:21AM +0100, Markus Armbruster wrote: > Alon Levy writes: > > > A CCID device is a smart card reader. It is a USB device, defined at [1]. > > This patch introduces the usb-ccid device that is a ccid bus. Next patches > > will > > introduce two card types to use it, a

[Qemu-devel] [PATCH v2 4/6] intel-hda: update irq status on WAKEEN changes.

2010-11-09 Thread Gerd Hoffmann
When the guest updates the WAKEEN register we must re-calculate the IRQ status. Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 2c1ef12..e478e67 100644 --- a/hw/intel-hda.c +++ b/h

[Qemu-devel] [PATCH v2 3/6] intel-hda: Honor WAKEEN bits.

2010-11-09 Thread Gerd Hoffmann
From: François Revol HDA: Honor WAKEEN bits when deciding to raise an interrupt on codec status change. This prevents an interrupt storm with the Haiku HDA driver which does not handle codec status changes in the irq handler. Signed-off-by: François Revol Signed-off-by: Gerd Hoffmann --- hw/

[Qemu-devel] [PATCH v2 5/6] intel-hda: add msi support

2010-11-09 Thread Gerd Hoffmann
This patch adds MSI support to the intel hda audio driver. It is enabled by default, use '-device intel-hda,msi=0' to disable it. [ v2: codestyle: add braces ] Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c | 33 +++-- 1 files changed, 31 insertions(+), 2 deletio

[Qemu-devel] [PATCH v2 2/6] hda-audio: exit cleanup

2010-11-09 Thread Gerd Hoffmann
Add exit callback to the driver. Unregister the sound card properly on exit. [ v2: codestyle: add braces ] Signed-off-by: Gerd Hoffmann --- hw/hda-audio.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/hw/hda-audio.c b/hw/hda-audio.c index 1035

[Qemu-devel] [PATCH v2 6/6] intel-hda: fix codec addressing.

2010-11-09 Thread Gerd Hoffmann
The HDA bus supports up to 15 codecs, with addresses 0 ... 14. We get that wrong in two places: * When handing out addresses we accept address 15 as valid. * The bitmasks for two registers (WAKEEN and STATESTS) don't have bit 14 set. This patch fixes it. Signed-off-by: Gerd Hoffmann --- h

[Qemu-devel] [PATCH v2 0/6] intel-hda: bugfixes and msi support

2010-11-09 Thread Gerd Hoffmann
Hi, This patch series brings a bunch of bugfixes for the intel-hda driver and it also adds MSI support to reduce interrupt sharing. Changes in v2: * Codestyle fixups. * Added one more bugfix. * Added MSI patch. François Revol (1): intel-hda: Honor WAKEEN bits. Gerd Hoffmann (5): int

Re: [Qemu-devel] Re: [RFC][RESEND][PATCH v1 02/15] virtproxy: qemu-vp, standalone daemon skeleton

2010-11-09 Thread Amit Shah
On (Fri) Nov 05 2010 [08:32:30], Adam Litke wrote: > On Thu, 2010-11-04 at 08:57 -0500, Michael Roth wrote: > > > This resembles vl.c's main_loop_wait() but I can see why you might want > > > your own. There is opportunity for sharing the select logic and ioh > > > callbacks but I think that could

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-09 Thread Gleb Natapov
On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote: > >> Gleb Natapov writes: > >> > >> > Properly check array bounds before accessing array element. > >> > >> Impact? > >> > > Gappi

  1   2   >