[Qemu-devel] Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 07:20:51PM +, Blue Swirl wrote: > 2010/11/10 Gleb Natapov : > > On Wed, Nov 10, 2010 at 07:11:54PM +, Blue Swirl wrote: > >> On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > >> > > >> > Signed-off-by: Gleb Natapov > >> > --- > >> >  hw/fw_cfg.h |    1 + > >>

[Qemu-devel] Log Console Output to File

2010-11-10 Thread qemu
Hi, Is there a way to log / copy the console output (like the Linux boot info, if booting QEMU to Linux) to a file? Thanks!

[Qemu-devel] No Virtual Console

2010-11-10 Thread qemu
Hi, My apologies up front for the dumb question, but ... I am running qemu (actually, qemu-system-arm), and when I launch it I do not get a new virtual console to open. I have had this in the past (older Linux install), but inside OpenSuSE 11.3, with QEMU 0.12.5 or 0.13.0 I do not get this to ha

[Qemu-devel] [RFC][PATCH v3 11/11] virtagent: Makefile/configure changes to build virtagent bits

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile|2 +- Makefile.target |2 +- configure | 25 + 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a435ae1..ed67ad1 100644 --- a/Makefile +++ b/Makefile @@ -137,7 +137,7

[Qemu-devel] [RFC][PATCH v3 07/11] virtagent: add getdmesg RPC

2010-11-10 Thread Michael Roth
Add RPC to view guest dmesg output. Signed-off-by: Michael Roth --- virtagent-daemon.c | 44 virtagent-daemon.h |1 + 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/virtagent-daemon.c b/virtagent-daemon.c index 3615e8a..51e4e0f

[Qemu-devel] [RFC][PATCH v3 04/11] virtagent: base RPC client definitions

2010-11-10 Thread Michael Roth
Base skeleton and helpers for executing RPC commands. Monitor commands will result in a connect() being issued to the virtagent service socket, which will then be transported to the listening RPC server in the guest via the virtproxy layer, RPC requests are then sent/recieved via http over the resu

[Qemu-devel] [RFC][PATCH v3 10/11] virtagent: qemu integration, add va invocation via virtproxy chardev

2010-11-10 Thread Michael Roth
From: root With these modifications we can now start virtagent via a bool option to the virtproxy chardev. For example: qemu -chardev virtproxy,id=va_id,virtagent=on and then passing the chardev id to whatever device we're using for the transport (virtio/isa serial) Signed-off-by: Michael Roth

[Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-10 Thread Mike Ryan
Add an option to specify the host interface to send multicast packets on when using a multicast socket for networking. The option takes the name of a host interface (e.g., eth0) and sets the IP_MULTICAST_IF socket option, which causes the packets to use that interface as an egress. This is useful

[Qemu-devel] [RFC][PATCH v3 09/11] virtagent: qemu-vp integration, use virtagent init functions

2010-11-10 Thread Michael Roth
From: root Invoke virtagent client/server instances via their init functions. Signed-off-by: Michael Roth --- qemu-vp.c | 61 - 1 files changed, 20 insertions(+), 41 deletions(-) diff --git a/qemu-vp.c b/qemu-vp.c index fe06e07..2f

[Qemu-devel] [RFC][PATCH v3 06/11] virtagent: add agent_viewfile command

2010-11-10 Thread Michael Roth
Utilize the getfile RPC to provide a means to view text files in the guest. Getfile can handle binary files as well but we don't advertise that here due to the special handling requiring to store it and provide it back to the user (base64 encoding it for instance). Hence the potentially confusing "

[Qemu-devel] [RFC][PATCH v3 08/11] virtagent: add agent_viewdmesg command

2010-11-10 Thread Michael Roth
Add commands to view guest dmesg output. Currently it is a 16K buffer. Signed-off-by: Michael Roth --- hmp-commands.hx | 16 + qmp-commands.hx | 35 +++ virtagent.c | 100 +++ virtagent.h |3 ++ 4 files

[Qemu-devel] [RFC][PATCH v3 02/11] virtagent: base definitions for host/guest RPC server

2010-11-10 Thread Michael Roth
Basic skeleton code for RPC server. This is shared by both the guest-side RPC server as well as the host-side one (the advertised RPCs for each by guest/host-specific arrays). Signed-off-by: Michael Roth --- virtagent-daemon.c | 194 virtagen

[Qemu-devel] [RFC][PATCH v3 01/11] virtagent: add common rpc transport defs

2010-11-10 Thread Michael Roth
Common code for sending/recieving RPCs via http over virtproxy channel. All communication is done via asynchronous read/write handlers and using non-blocking reads/writes Signed-off-by: Michael Roth --- virtagent-common.c | 431 virtagent-com

[Qemu-devel] [RFC][PATCH v3 05/11] virtagent: add getfile RPC

2010-11-10 Thread Michael Roth
Add RPC to retrieve a guest file. A size limit of some sort will eventually be needed else we can block the monitor for arbitrarily long periods of time. This interface is intended for smaller reads like peeking at logs and /proc and such. Signed-off-by: Michael Roth --- virtagent-daemon.c | 5

[Qemu-devel] [RFC][PATCH v3 03/11] virtagent: qemu-vp, integrate virtagent server

2010-11-10 Thread Michael Roth
This allows the guest RPC server to be integrated into the qemu-vp/virtproxy i/o loop Signed-off-by: Michael Roth --- qemu-vp.c | 115 - 1 files changed, 106 insertions(+), 9 deletions(-) diff --git a/qemu-vp.c b/qemu-vp.c index 3a376

[Qemu-devel] [RFC][PATCH v3 00/11] virtagent: host/guest RPC communication agent

2010-11-10 Thread Michael Roth
The previous submission was missing the subject, please disregard it. This set of patches is meant to be applied on top of the recently submitted Virtproxy v2 patchset. It can also be obtained at: git://repo.or.cz/qemu/mdroth.git virtproxy_v2 OVERVIEW: There are a wide range of use cases motiv

[Qemu-devel] (no subject)

2010-11-10 Thread Michael Roth
>From Michael Roth # This line is ignored. From: Michael Roth Subject: [RFC][PATCH v3 00/11] virtagent: host/guest RPC communication agent In-Reply-To: This set of patches is meant to be applied on top of the recently submitted Virtproxy v2 patchset. It can also be obtained at: git://repo.or.

Re: [Qemu-devel] [RFC][PATCH v2 00/19] virtproxy: host/guest communication layer

2010-11-10 Thread Michael Roth
On 11/10/2010 04:27 PM, Michael Roth wrote: OVERVIEW: Virtproxy proxies and multiplexes socket streams over a data channel between a host and a guest (currently network connections, emulated serial, or virtio-serial channels are supported). This allows for services such as guest data collecti

[Qemu-devel] [RFC][PATCH v2 12/19] virtproxy: add vp_handle_packet()

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- virtproxy.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 0cc8950..01a36c2 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -464,6 +464,29 @@ static int vp_handle_data_packet(void *drv,

[Qemu-devel] [RFC][PATCH v2 03/19] virtproxy: add debug functions for virtproxy core

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- virtproxy.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 8f18d83..3686c77 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -13,6 +13,23 @@ #include "virtproxy.h" +#define DEBUG_VP + +#i

[Qemu-devel] [RFC][PATCH v2 09/19] virtproxy: interfaces to set/remove/handle VPOForwards

2010-11-10 Thread Michael Roth
Functions to add listener FDs (oforwards) which set up proxied connections to associated service, and the corresponding handler function to process to new connections to said FDs and initialize new client connections to the associated remote server over the channel Signed-off-by: Michael Roth ---

[Qemu-devel] [RFC][PATCH v2 16/19] virtproxy: qemu integration, add virtproxy chardev

2010-11-10 Thread Michael Roth
This allows us to create a virtproxy instance via a chardev. It can now be created with something like: qemu -chardev virtproxy,id=vp1 \ -device virtio-serial \ -device virtserialport,chardev=vp1 In the future the ability to add oforwards/iforwards in the command-line invocation and the

[Qemu-devel] [RFC][PATCH v2 00/19] virtproxy: host/guest communication layer

2010-11-10 Thread Michael Roth
OVERVIEW: Virtproxy proxies and multiplexes socket streams over a data channel between a host and a guest (currently network connections, emulated serial, or virtio-serial channels are supported). This allows for services such as guest data collection agents, host/guest file transfer, and event

[Qemu-devel] [RFC][PATCH v2 13/19] virtproxy: interfaces to set/remove VPIForwards

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- virtproxy.c | 59 +++ virtproxy.h |2 ++ 2 files changed, 61 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 01a36c2..b683ee6 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -7

[Qemu-devel] [RFC][PATCH v2 18/19] virtproxy: qemu-vp, main logic

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- qemu-vp.c | 475 - 1 files changed, 474 insertions(+), 1 deletions(-) diff --git a/qemu-vp.c b/qemu-vp.c index 5075cdc..3a3762a 100644 --- a/qemu-vp.c +++ b/qemu-vp.c @@ -9,10 +9,54 @@ * This work is

[Qemu-devel] [RFC][PATCH v2 19/19] virtproxy: Makefile/configure changes to build qemu-vp

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- .gitignore |1 + Makefile |4 +++- configure |1 + 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index a43e4d1..da307d2 100644 --- a/.gitignore +++ b/.gitignore @@ -31,6 +31,7 @@ qemu-img-cmds.texi qemu-img-

[Qemu-devel] [RFC][PATCH v2 02/19] virtproxy: qemu-vp, standalone daemon skeleton

2010-11-10 Thread Michael Roth
Daemon to be run in guest, or on host in standalone mode. (re-)implements some qemu utility functions used by core virtproxy.c code via wrapper functions. For built-in virtproxy code we will define these wrapper functions in terms of qemu's built-in implementations. Main logic will come in a later

[Qemu-devel] [RFC][PATCH v2 15/19] virtproxy: add virtproxy-builtin.c for compat defs

2010-11-10 Thread Michael Roth
Virtproxy relies on routines defined within qemu-vp which mirror various i/o related operations in qemu to provide similar functionality for the guest daemon. When building virtproxy as part of qemu rather than qemu-vp we need these definitions to provide those functions in terms of the original qe

[Qemu-devel] [RFC][PATCH v2 01/19] virtproxy: base data structures and constants

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- virtproxy.c | 136 +++ virtproxy.h | 34 +++ 2 files changed, 170 insertions(+), 0 deletions(-) create mode 100644 virtproxy.c create mode 100644 virtproxy.h diff --git a/virtproxy.c b/virtp

[Qemu-devel] [RFC][PATCH v2 04/19] virtproxy: list look-up functions conns/oforwards/iforwards

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- virtproxy.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 3686c77..2cfd905 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -151,3 +151,47 @@ static QemuOptsList vp

[Qemu-devel] [RFC][PATCH v2 05/19] virtproxy, add vp_channel_send_all

2010-11-10 Thread Michael Roth
This handles sending of data to channel fd (qemu-vp in guest) or the device associated with the virtproxy chardev for the host depending on the context. vp_chr_read() wraps qemu_chr_read(), it'll be defined later in virtproxy-builtin.c, and noop'd in the guest agent via qemu-vp.c. Signed-off-by: M

[Qemu-devel] [RFC][PATCH v2 07/19] virtproxy: add read handler for communication channel

2010-11-10 Thread Michael Roth
Handle data coming in over the channel as VPPackets: Process control messages and forward data from remote client/server connections to the appropriate server/client FD on our end. We also provide here a helper function to process a stream of packets from the channel. Signed-off-by: Michael Roth

[Qemu-devel] [RFC][PATCH v2 06/19] virtproxy: add accept handler for communication channel

2010-11-10 Thread Michael Roth
This accept()'s connections to the socket we told virt-proxy to listen for the channel connection on and sets the appropriate read handler for the resulting FD. Signed-off-by: Michael Roth --- virtproxy.c | 37 + 1 files changed, 37 insertions(+), 0 deletion

[Qemu-devel] [RFC][PATCH v2 08/19] virtproxy: add vp_new() VPDriver constructor

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- virtproxy.c | 40 virtproxy.h |6 ++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 091a223..401d51c 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -359,3 +359,43 @@

[Qemu-devel] [RFC][PATCH v2 10/19] virtproxy: add handler for data packets

2010-11-10 Thread Michael Roth
Process VPPackets coming in from channel and send them to the appropriate server/client connections. Signed-off-by: Michael Roth --- virtproxy.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index f189

[Qemu-devel] [RFC][PATCH v2 14/19] virtproxy: add read handler for proxied connections

2010-11-10 Thread Michael Roth
reads data from client/server connections as they become readable, then sends the data over the channel Signed-off-by: Michael Roth --- virtproxy.c | 80 +++ 1 files changed, 80 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/vi

[Qemu-devel] [RFC][PATCH v2 11/19] virtproxy: add handler for control packet

2010-11-10 Thread Michael Roth
Process control packets coming in over the channel. This entails setting up/tearing down connections to local services initiated from the other end of the channel. Signed-off-by: Michael Roth --- virtproxy.c | 154 +++ 1 files changed, 154

[Qemu-devel] [RFC][PATCH v2 17/19] virtproxy: qemu integration, add virtproxy to Makefile.targets

2010-11-10 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index 91e6e74..f08c435 100644 --- a/Makefile.target +++ b/Makefile.target @@ -164,7 +164,7 @@ endif #CONFIG_BSD_USER # System emulator targ

Re: [Qemu-devel] [PATCH] ioport: Fix duplicated code

2010-11-10 Thread Stefan Weil
Am 10.11.2010 15:21, schrieb Luiz Capitulino: Functions register_ioport_read() and register_ioport_write() are almost identical, the only difference is that they write to different arrays. Introduce register_ioport() to handle this difference and change both functions to use it instead of duplic

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: > On Wed, Nov 10, 2010 at 7:57 PM, Lluís wrote: >> Blue Swirl writes: >> >>> On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: So, my patch is just a matter of having all events available _only_ when you use a backend other than "nop". >> >>> Then the default for simpl

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-10 Thread Alon Levy
On Wed, Nov 10, 2010 at 04:49:38PM +0100, Markus Armbruster wrote: > Sorry for coming so late to this thread... > > Alon Levy writes: > > > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > >> On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > >> >On 10/21/10 08:36, Alon Levy wrote:

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 7:57 PM, Lluís wrote: > Blue Swirl writes: > >> On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: >>> So, my patch is just a matter of having all events available _only_ when >>> you use a backend other than "nop". > >> Then the default for simpletrace (and dtrace?) should als

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-10 Thread Stefan Hajnoczi
On Wed, Nov 10, 2010 at 5:54 PM, Arun R Bharadwaj wrote: > * Stefan Hajnoczi [2010-11-10 13:45:29]: >> On Wed, Nov 10, 2010 at 1:19 PM, Arun R Bharadwaj >> wrote: >> I wonder if the condition variable has a measurable performance >> overhead.  We unconditionally broadcast on paiocb completion.  

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: > On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: >> So, my patch is just a matter of having all events available _only_ when >> you use a backend other than "nop". > Then the default for simpletrace (and dtrace?) should also be disabled > initial state. If you have 1000 tracepo

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

2010-11-10 Thread Ryan Harper
* Markus Armbruster [2010-11-10 11:40]: > Ryan Harper writes: > > > * Markus Armbruster [2010-11-10 06:48]: > >> One real question, and a couple of nits. > >> > >> Ryan Harper writes: > >> > >> > Block hot unplug is racy since the guest is required to acknowlege the > >> > ACPI > >> > unplu

[Qemu-devel] Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Blue Swirl
2010/11/10 Gleb Natapov : > On Wed, Nov 10, 2010 at 07:11:54PM +, Blue Swirl wrote: >> On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.h |    1 + >> >  hw/pc.c     |   19 +++ >> >  sysemu.h    |    1 + >> >  v

[Qemu-devel] Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 07:11:54PM +, Blue Swirl wrote: > On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > >  hw/fw_cfg.h |    1 + > >  hw/pc.c     |   19 +++ > >  sysemu.h    |    1 + > >  vl.c        |   40 ++

[Qemu-devel] Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.h |    1 + >  hw/pc.c     |   19 +++ >  sysemu.h    |    1 + >  vl.c        |   40 >  4 files changed, 61 insertions(+), 0 deletions(-)

[Qemu-devel] Re: [PATCHv3 10/14] Add get_dev_path callback for usb bus.

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 06:37:45PM +, Blue Swirl wrote: > On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > >  hw/usb-bus.c |   35 +++ > >  1 files changed, 35 insertions(+), 0 deletions(-) > > > > diff --git a/h

[Qemu-devel] [PATCH 3/3] QMP/qmp-shell: Introduce HMP mode

2010-11-10 Thread Luiz Capitulino
In which qmp-shell will exclusively use the HMP passthrough feature, this is useful for testing. Example: # ./qmp-shell -H qmp-sock Welcome to the HMP shell! Connected to QEMU 0.13.50 (QEMU) info network VLAN 0 devices: user.0: net=10.0.2.0, restricted=n e1000.0

[Qemu-devel] [PATCH] ioport: Fix duplicated code

2010-11-10 Thread Luiz Capitulino
Functions register_ioport_read() and register_ioport_write() are almost identical, the only difference is that they write to different arrays. Introduce register_ioport() to handle this difference and change both functions to use it instead of duplicating code. Signed-off-by: Luiz Capitulino ---

[Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-10 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino --- monitor.c | 39 +++ qmp-comma

[Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-10 Thread Luiz Capitulino
This driver handles in-memory chardev operations. That's, all writes to this driver are stored in an internal buffer and it doesn't talk to the external world in any way. Right now it's very simple: it supports only writes. But it can be easily extended to support more operations. This is going t

[Qemu-devel] [PATCH v2 0/3]: QMP: Human Monitor passthrough

2010-11-10 Thread Luiz Capitulino
Simple example: -> { "execute": "hmp_passthrough", "arguments": { "command-line": "print /i 10+25" } } <- { "return": "35\r\n" } Please, check individual patches for details. Also note that this series depends on the script improvements one. changelog - v1 -> v2 - A number of small cl

[Qemu-devel] Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.h |    1 + >  hw/pc.c     |   19 +++ >  sysemu.h    |    1 + >  vl.c        |   40 >  4 files changed, 61 insertions(+), 0 deletions(-)

[Qemu-devel] Re: [PATCHv3 11/14] Add bootindex parameter to net/block/fd device

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 06:32:54PM +, Blue Swirl wrote: > On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > If bootindex is specified on command line a string that describes device > > in firmware readable way is added into sorted list. Later this list will > > be passed into firmware t

[Qemu-devel] Re: [PATCHv3 10/14] Add get_dev_path callback for usb bus.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/usb-bus.c |   35 +++ >  1 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/hw/usb-bus.c b/hw/usb-bus.c > index 256b881..6292282 100644 > --- a/hw/usb-bu

[Qemu-devel] Re: [PATCHv3 04/14] Add get_fw_dev_path callback to ISA bus in qdev.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > Use device ioports to create unique device path. > > Signed-off-by: Gleb Natapov > --- >  hw/isa-bus.c |   15 +++ >  1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/hw/isa-bus.c b/hw/isa-bus.c > index c0ac7e9..7

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 08:21:55PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 08:02:12PM +0200, Gleb Natapov wrote: > > On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > > > > > > Signed-off

[Qemu-devel] Re: [PATCHv3 11/14] Add bootindex parameter to net/block/fd device

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > If bootindex is specified on command line a string that describes device > in firmware readable way is added into sorted list. Later this list will > be passed into firmware to control boot order. > > Signed-off-by: Gleb Natapov > --- >  bloc

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 6:21 PM, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 08:02:12PM +0200, Gleb Natapov wrote: >> On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: >> > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: >> > > >> > > Signed-off-by: Gleb Nat

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: > Blue Swirl writes: > >> On Tue, Nov 9, 2010 at 2:08 PM, Lluís wrote: >>> Enable all trace events by default, assuming their frequency is relatively >>> low, >>> so there will be no measurable performace impact. > >> Even if the impact for one trace

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Michael S. Tsirkin
On Wed, Nov 10, 2010 at 08:02:12PM +0200, Gleb Natapov wrote: > On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: > > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > > > > Signed-off-by: Gleb Natapov > > > > Good stuff. We should also consider using this for

[Qemu-devel] Re: [PATCHv3 00/14] boot order specification

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 06:08:56PM +, Blue Swirl wrote: > On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > This is current sate of the patch series for people to comment on. > > I am using open firmware naming scheme to specify device path names. > > > > Names look like this on pci mac

[Qemu-devel] Re: [PATCHv3 00/14] boot order specification

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > This is current sate of the patch series for people to comment on. > I am using open firmware naming scheme to specify device path names. > > Names look like this on pci machine: > /p...@i0cf8/i...@1,1/dr...@1/d...@0 > /p...@i0cf8/i...@1/f...@

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > Good stuff. We should also consider using this for > CLI and monitor. Some comments below. > > > --- > > hw/pci.c | 54 +

Re: [Qemu-devel] [PATCH 2/3] Move threadlets infrastructure to qemu-threadlets.c

2010-11-10 Thread Arun R Bharadwaj
* Blue Swirl [2010-11-10 17:29:30]: > On Wed, Nov 10, 2010 at 1:19 PM, Arun R Bharadwaj > wrote: > > The reason for creating this generic infrastructure is so that other > > subsystems, > > such as virtio-9p could make use of it for offloading tasks that could > > block. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: > On Tue, Nov 9, 2010 at 2:08 PM, Lluís wrote: >> Enable all trace events by default, assuming their frequency is relatively >> low, >> so there will be no measurable performace impact. > Even if the impact for one tracepoint is low, if all tracepoints are > enabled, eventual

Re: [Qemu-devel] [PATCH 2/3] Move threadlets infrastructure to qemu-threadlets.c

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 1:19 PM, Arun R Bharadwaj wrote: > The reason for creating this generic infrastructure is so that other > subsystems, > such as virtio-9p could make use of it for offloading tasks that could block. > > Signed-off-by: Arun R Bharadwaj > Signed-off-by: Aneesh Kumar K.V > S

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-10 Thread Arun R Bharadwaj
* Stefan Hajnoczi [2010-11-10 13:45:29]: > On Wed, Nov 10, 2010 at 1:19 PM, Arun R Bharadwaj > wrote: > > @@ -301,106 +431,58 @@ static ssize_t handle_aiocb_rw(struct qemu_paiocb > > *aiocb) > >     return nbytes; > >  } > > > > -static void *aio_thread(void *unused) > > +static void aio_thread

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

2010-11-10 Thread Ryan Harper
* Markus Armbruster [2010-11-10 11:40]: > Ryan Harper writes: > > > * Markus Armbruster [2010-11-10 06:48]: > >> One real question, and a couple of nits. > >> > >> Ryan Harper writes: > >> > >> > Block hot unplug is racy since the guest is required to acknowlege the > >> > ACPI > >> > unplu

[Qemu-devel] [Bug 432154] Re: dynamic block device attach/detach not functional with karmic KVM

2010-11-10 Thread Kiall
@Wolfgang: Yes - Specifying, for example, /dev/vda triggers the use of virtio over the "standard" - and works exactly as you would expect EBS volumes to :) There *is* still a bug preventing /dev/sdX from working .. but I've sank too much time into finding it at the moment, I'll probably dig in aga

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-10 Thread Anthony Liguori
On 11/10/2010 11:22 AM, Ian Molton wrote: Ping ? I think the best way forward is to post patches. To summarize what I was trying to express in the thread, I think this is not the right long term architecture but am not opposed to it as a short term solution. I think having a new virtio devi

[Qemu-devel] [PATCHv3 13/14] Add notifier that will be called when machine is fully created.

2010-11-10 Thread Gleb Natapov
Action that depends on fully initialized device model should register with this notifier chain. Signed-off-by: Gleb Natapov --- sysemu.h |2 ++ vl.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index 6b85d86..46a588c 100644 -

[Qemu-devel] [PATCHv3 05/14] Store IDE bus id in IDEBus structure for easy access.

2010-11-10 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/ide/cmd646.c b/

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

2010-11-10 Thread Markus Armbruster
Ryan Harper writes: > * Markus Armbruster [2010-11-10 06:48]: >> One real question, and a couple of nits. >> >> Ryan Harper writes: >> >> > Block hot unplug is racy since the guest is required to acknowlege the ACPI >> > unplug event; this may not happen synchronously with the device removal

[Qemu-devel] [PATCHv3 12/14] Add bootindex parameter to pci assigned device.

2010-11-10 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/device-assignment.c |7 +++ hw/device-assignment.h |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index bde231d..15c2b42 100644 --- a/hw/device-assignment.c +++ b/hw/device-assign

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Michael S. Tsirkin
On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov Good stuff. We should also consider using this for CLI and monitor. Some comments below. > --- > hw/pci.c | 54 ++ > 1 files changed, 54 insertion

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-10 Thread Ian Molton
Ping ? On 05/11/10 18:05, Ian Molton wrote: On 03/11/10 18:17, Anthony Liguori wrote: On 11/03/2010 01:03 PM, Ian Molton wrote: Why is it better than using virtio-serial? For one thing, it enforces the PID in kernel so the guests processes cant screw each other over by forging the PID pass

[Qemu-devel] [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/pci.c | 54 ++ 1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 92aaa85..ab0399c 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -63,12 +63,14 @@ struct PCIBus { static vo

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Tue, Nov 9, 2010 at 2:08 PM, Lluís wrote: > Enable all trace events by default, assuming their frequency is relatively > low, > so there will be no measurable performace impact. Even if the impact for one tracepoint is low, if all tracepoints are enabled, eventually (considering that the numb

[Qemu-devel] [PATCHv3 07/14] Add get_dev_path callback for system bus.

2010-11-10 Thread Gleb Natapov
Prints out mmio or pio used to access child device. Signed-off-by: Gleb Natapov --- hw/pci_host.c |2 ++ hw/sysbus.c | 30 ++ hw/sysbus.h |4 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index bc5b771

[Qemu-devel] [PATCHv3 09/14] Record which USBDevice USBPort belongs too.

2010-11-10 Thread Gleb Natapov
Ports on root hub will have NULL here. This is needed to reconstruct path from device to its root hub to build device path. Signed-off-by: Gleb Natapov --- hw/usb-bus.c |3 ++- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +- hw/usb.h

[Qemu-devel] [PATCHv3 11/14] Add bootindex parameter to net/block/fd device

2010-11-10 Thread Gleb Natapov
If bootindex is specified on command line a string that describes device in firmware readable way is added into sorted list. Later this list will be passed into firmware to control boot order. Signed-off-by: Gleb Natapov --- block_int.h |4 +++- hw/e1000.c |7 +++ hw/eepro10

[Qemu-devel] [PATCHv3 06/14] Add get_fw_dev_path callback to IDE bus.

2010-11-10 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/qdev.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 88ff657..01a181b 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -24,9 +24,12 @@ /* - */

[Qemu-devel] [PATCHv3 10/14] Add get_dev_path callback for usb bus.

2010-11-10 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/usb-bus.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 256b881..6292282 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -5,11 +5,13 @@ #include "monitor.h" stat

[Qemu-devel] [PATCHv3 03/14] Keep track of ISA ports ISA device is using in qdev.

2010-11-10 Thread Gleb Natapov
Store all io ports used by device in ISADevice structure. Signed-off-by: Gleb Natapov --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 25 + hw/isa.h |4 hw/m48t59.c

[Qemu-devel] [PATCHv3 00/14] boot order specification

2010-11-10 Thread Gleb Natapov
This is current sate of the patch series for people to comment on. I am using open firmware naming scheme to specify device path names. Names look like this on pci machine: /p...@i0cf8/i...@1,1/dr...@1/d...@0 /p...@i0cf8/i...@1/f...@03f1/flo...@1 /p...@i0cf8/i...@1/f...@03f1/flo...@0 /p...@i0cf8/i

[Qemu-devel] [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/fw_cfg.h |1 + hw/pc.c | 19 +++ sysemu.h|1 + vl.c| 40 4 files changed, 61 insertions(+), 0 deletions(-) diff --git a/hw/fw_cfg.h b/hw/fw_cfg.h index 4d13a4f..bfbf1f9 100644

[Qemu-devel] [PATCHv3 04/14] Add get_fw_dev_path callback to ISA bus in qdev.

2010-11-10 Thread Gleb Natapov
Use device ioports to create unique device path. Signed-off-by: Gleb Natapov --- hw/isa-bus.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index c0ac7e9..741d28e 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -31,11 +31,13 @

[Qemu-devel] [PATCHv3 01/14] Introduce fw_name field to DeviceInfo structure.

2010-11-10 Thread Gleb Natapov
Add "fw_name" to DeviceInfo to use in device path building. In contrast to "name" "fw_name" should refer to functionality device provides instead of particular device model like "name" does. Signed-off-by: Gleb Natapov --- hw/fdc.c|1 + hw/ide/isa.c|1 + hw/ide/qdev.c |

[Qemu-devel] [PATCHv3 02/14] Introduce new BusInfo callback get_fw_dev_path.

2010-11-10 Thread Gleb Natapov
New get_fw_dev_path callback will be used for build device path usable by firmware in contrast to qdev qemu internal device path. Signed-off-by: Gleb Natapov --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 9f90efe..dc669b3 10064

[Qemu-devel] [Bug 673613] [NEW] ARM semihosting SYS_GET_CMDLINE does not return arguments

2010-11-10 Thread Wolfgang Schildbach
Public bug reported: I have downloaded version 0.13.0 of the code, configured with: './configure' '--prefix=/tmp/qemu-0.13.0' '--interp- prefix=/tmp/qemu-0.13.0/usr/local/gnemul/qemu-%M' '--target-list=arm- softmmu arm-linux-user armeb-linux-user' and built using gcc version 4.3.2 (Debian 4.3.2-1

[Qemu-devel] [Bug 432154] Re: dynamic block device attach/detach not functional with karmic KVM

2010-11-10 Thread Wolfgang Nagele
@Serge: Yes acpiphp is definitely loaded. I used the UEC images. @Kiall: Thanks for the hint about vdX. Does that mean you just specify (for example) vda when attaching the device to the instance and that will work? I have no cluster installed with which i could test atm. -- dynamic block device

Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed

2010-11-10 Thread Alex Williamson
On Sun, 2010-11-07 at 14:59 +, Blue Swirl wrote: > On Fri, Nov 5, 2010 at 9:40 PM, Alex Williamson > wrote: > > We can't let the compiler define the alignment for qemu_cfg data. > > Actually, whole e820_table implementation seems to be buggy. The > structure may not be passed directly to fw_c

[Qemu-devel] Re: [PATCH] Remove code duplication from savevm instance_id creation code.

2010-11-10 Thread Alex Williamson
On Sun, 2010-11-07 at 14:16 +0200, Gleb Natapov wrote: > Code in register_savevm_live() and vmstate_register_with_alias_id() > looks identical except idstr used. Move into separate function. > > Signed-off-by: Gleb Natapov looks ok to me. Acked-by: Alex Williamson > diff --git a/savevm.c b/sa

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

2010-11-10 Thread Ryan Harper
* Markus Armbruster [2010-11-10 06:48]: > One real question, and a couple of nits. > > Ryan Harper writes: > > > Block hot unplug is racy since the guest is required to acknowlege the ACPI > > unplug event; this may not happen synchronously with the device removal > > command > > Well, I woul

Re: [Qemu-devel] [PATCH] usb-linux: allow multiple devices with matching IDs

2010-11-10 Thread Markus Armbruster
Grazvydas Ignotas writes: > Right now if we pass through multiple USB devices with matching vendor > and product IDs, only first one is passed to guest, as the code thinks > second device is already attached. The only way to get those devices > working is to specify bus.addr which is inconvenient

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-10 Thread Anthony Liguori
On 11/09/2010 07:42 AM, Gerd Hoffmann wrote: are available in the git repository at: git://anongit.freedesktop.org/spice/qemu passwd.2 Ping? What is the status here? My view is that it's wrong for QEMU because it's a specific management policy that isn't generally useful. It can be easily

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-10 Thread Anthony Liguori
On 10/08/2010 05:08 AM, Daniel P. Berrange wrote: On Thu, Oct 07, 2010 at 02:53:05PM -0500, Anthony Liguori wrote: On 10/07/2010 06:15 AM, Gerd Hoffmann wrote: This patch adds support for expiring passwords to vnc. It adds a new lifetime parameter to the vnc_display_password() functi

  1   2   >