[Qemu-devel] Re: [PATCH 3/6] pci/aer: remove dead code

2010-12-06 Thread Isaku Yamahata
The eventual result looks okay. But if-clauses that surrounds msi_trigger = true should be eliminated at the same time. 1/6, 3/6 and, 4/6 could be reordered for bisectability. thanks, On Fri, Dec 03, 2010 at 12:54:37AM +0200, Michael S. Tsirkin wrote: > Remove some unused variables and return val

[Qemu-devel] Re: [PATCH 6/6] pci/aer: factor out common code

2010-12-06 Thread Isaku Yamahata
Looks good. Maybe assert(0) should be replaced by abort(). Anyway this patch removes it, though. On Fri, Dec 03, 2010 at 12:54:47AM +0200, Michael S. Tsirkin wrote: > Same logic is used to assert interrupts > and send msix messages, so add a static functin for this. > > Signed-off-by: Michael S.

[Qemu-devel] Re: pcie aer comment

2010-12-06 Thread Isaku Yamahata
On Fri, Dec 03, 2010 at 01:02:35AM +0200, Michael S. Tsirkin wrote: > Also, the code has many cases that look like: > > if (root_cmd & PCI_ERR_ROOT_CMD_COR_EN) { > } > If the intent is to add some code later, pls put a TODO here. > Otherwise please remove these or replace w

[Qemu-devel] Re: [PATCH 5/6] pci/aer: fix interrupt on config write

2010-12-06 Thread Isaku Yamahata
Looks good. On Fri, Dec 03, 2010 at 12:54:43AM +0200, Michael S. Tsirkin wrote: > config write handling for aer seems broken: > For example, it won't clear a level interrupt > when command register is set to 0. > > Make it match the spec: level should equal > the logical or of enabled bits, msi o

[Qemu-devel] Re: [PATCH 1/6] pci: untangle pci/msi dependency

2010-12-06 Thread Isaku Yamahata
On Fri, Dec 03, 2010 at 12:54:33AM +0200, Michael S. Tsirkin wrote: > diff --git a/hw/pcie_aer.c b/hw/pcie_aer.c > index 235ac53..18bbd5a 100644 > --- a/hw/pcie_aer.c > +++ b/hw/pcie_aer.c > @@ -339,10 +339,10 @@ static bool pcie_aer_msg_root_port(PCIDevice *dev, > const PCIEAERMsg *msg) > >

Re: [Qemu-devel] [PATCH v8 7/7] virtio-console: Enable port throttling when chardev is slow to consume data

2010-12-06 Thread Amit Shah
On (Mon) Dec 06 2010 [13:23:50], Paul Brook wrote: > > Sure. My proposal is for qemu_chr_write() to succeed all the time. If > > the backend can block, and the caller can handle it, it can get a > > -EAGAIN (or WSAEWOULDBLOCK) return. When the backend becomes writable, > > the chardev can call t

[Qemu-devel] Re: [PATCH] pci: make command SERR bit writable

2010-12-06 Thread Isaku Yamahata
On Thu, Dec 02, 2010 at 09:32:12PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 26, 2010 at 09:01:41PM +0900, Isaku Yamahata wrote: > > pcie aer wants SERR bit to be writable. > > So make it writable. For compatibility, introduce compat global property > > command_serr_enable and don't make it wr

Re: [Qemu-devel] Displaying serial terminals on qemu

2010-12-06 Thread Stevens, Weston
I forgot to mention we must also use our own devices also located on the floppy disk, E.G. /fd0/dev/tty0, /fd0/dev/ttyS0, /fd0/dev/ttyS1 instead of /dev/tty0, /dev/ttyS0, and /dev/ttyS1 on the host OS. How could I get 3 qemu SDL windows to pop up at once, 1 of the terminals running on /fd0/dev/t

Re: [Qemu-devel] Displaying serial terminals on qemu

2010-12-06 Thread Serge E. Hallyn
Quoting Stevens, Weston (wstev...@eecs.wsu.edu): > I run Ubuntu 10.04 LTS and have qemu 0.12.3. For a class project, we are > building our own pseudo-linux operating system, so we have our own kernel AND > user processes that we built, and we run this OS from a virtual floppy disk. > So we don't

[Qemu-devel] KVM call agenda for Dec 7

2010-12-06 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-06 Thread Michael Roth
On 12/06/2010 04:06 PM, Adam Litke wrote: On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: Add RPC to retrieve a guest file. This interface is intended for smaller reads like peeking at logs and /proc and such. Signed-off-by: Michael Roth --- virtagent-server.c | 59 ++

[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-06 Thread Michael Roth
On 12/06/2010 04:08 PM, Adam Litke wrote: On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: Utilize the getfile RPC to provide a means to view text files in the guest. Getfile can handle binary files as well but we don't advertise that here due to the special handling requiring to store it

[Qemu-devel] [PATCH 2/2] monitor: implement x86 info mem for PAE and long modes

2010-12-06 Thread Blue Swirl
'info mem' didn't show correct information for PAE mode and x86_64 long mode. Fix by implementing the output for missing modes. Signed-off-by: Blue Swirl --- monitor.c | 174 1 files changed, 162 insertions(+), 12 deletions(-) diff

[Qemu-devel] [PATCH 1/2] monitor: implement x86 info tlb for PAE and long modes

2010-12-06 Thread Blue Swirl
'info tlb' didn't show correct information for PAE mode and x86_64 long mode. Implement the missing modes. Also print NX bit for PAE and long modes. Fix off-by-one error in 32 bit mode mask. Signed-off-by: Blue Swirl --- monitor.c | 151 -

[Qemu-devel] Displaying serial terminals on qemu

2010-12-06 Thread Stevens, Weston
I run Ubuntu 10.04 LTS and have qemu 0.12.3. For a class project, we are building our own pseudo-linux operating system, so we have our own kernel AND user processes that we built, and we run this OS from a virtual floppy disk. So we don't borrow anything from the Ubuntu host OS like the login,

[Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-06 Thread Michael Roth
On 12/06/2010 04:02 PM, Adam Litke wrote: On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: +static void va_http_send_handler(void *opaque) +{ +VAHTState *s =&va_state->send_state; +enum va_http_status http_status; +int fd = va_state->fd; +int ret; + +TRACE("called, fd:

[Qemu-devel] Re: [RFC][PATCH v5 19/21] virtagent: add virtagent guest daemon

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > +static void usage(const char *cmd) > +{ > +printf( > +"Usage: %s -c \n" > +"QEMU virtagent guest agent\n" > +"\n" > +" -c, --channel channel options of the form:\n" > +"::[:channel_id]\n" > +" -v, --verbose

[Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > +/* va_getdmesg(): return dmesg output > + * rpc return values: > + * - dmesg output as a string > + */ > +static xmlrpc_value *va_getdmesg(xmlrpc_env *env, > + xmlrpc_value *param, > +

[Qemu-devel] Re: [RFC][PATCH v5 03/21] virtagent: common code for managing client/server rpc jobs

2010-12-06 Thread Michael Roth
On 12/06/2010 03:57 PM, Adam Litke wrote: On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: +/* create new client job and then put it on the queue. this can be + * called externally from virtagent. Since there can only be one virtagent + * instance we access state via an object-scoped globa

[Qemu-devel] Re: [RFC][PATCH v5 03/21] virtagent: common code for managing client/server rpc jobs

2010-12-06 Thread Michael Roth
On 12/06/2010 03:54 PM, Adam Litke wrote: On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: +/* create new client job and then put it on the queue. this can be + * called externally from virtagent. Since there can only be one virtagent + * instance we access state via an object-scoped globa

[Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > +static void va_http_send_handler(void *opaque) > +{ > +VAHTState *s = &va_state->send_state; > +enum va_http_status http_status; > +int fd = va_state->fd; > +int ret; > + > +TRACE("called, fd: %d", fd); > + > +switch

[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > Utilize the getfile RPC to provide a means to view text files in the > guest. Getfile can handle binary files as well but we don't advertise > that here due to the special handling requiring to store it and provide > it back to the user (base

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > Add RPC to retrieve a guest file. This interface is intended > for smaller reads like peeking at logs and /proc and such. > > Signed-off-by: Michael Roth > --- > virtagent-server.c | 59 >

[Qemu-devel] Re: [PATCH v2 1/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-06 Thread Marcelo Tosatti
On Mon, Dec 06, 2010 at 07:04:01PM -0200, Marcelo Tosatti wrote: > On Mon, Dec 06, 2010 at 09:03:46AM -0500, Glauber Costa wrote: > > Usually nobody usually thinks about that scenario (me included and > > specially), > > but kvmclock can be actually disabled in the host. > > > > It happens in two

[Qemu-devel] Re: [RFC][PATCH v5 03/21] virtagent: common code for managing client/server rpc jobs

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > +/* create new client job and then put it on the queue. this can be > + * called externally from virtagent. Since there can only be one virtagent > + * instance we access state via an object-scoped global rather than pass > + * it around. >

[Qemu-devel] Re: [PATCH v2 1/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-06 Thread Marcelo Tosatti
On Mon, Dec 06, 2010 at 09:03:46AM -0500, Glauber Costa wrote: > Usually nobody usually thinks about that scenario (me included and specially), > but kvmclock can be actually disabled in the host. > > It happens in two scenarios: > 1. host too old. > 2. we passed -kvmclock to our -cpu parameter.

[Qemu-devel] Re: [RFC][PATCH v5 03/21] virtagent: common code for managing client/server rpc jobs

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > +/* create new client job and then put it on the queue. this can be > + * called externally from virtagent. Since there can only be one virtagent > + * instance we access state via an object-scoped global rather than pass > + * it around. > +

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-12-06 Thread Christian Brunner
2010/12/6 Kevin Wolf : Hi Kevin, > This lacks a Signed-off-by. Please merge Yehuda's fix for configure when > you resend the patch. I've sent an updated patch. > What's the easiest way to try it out? I tried to use vstart.sh and copy > the generated ceph.conf to /etc/ceph/ceph.conf so that qemu

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v9)

2010-12-06 Thread Christian Brunner
This is a new version of the rbd driver. The only difference from v8 is a check for a recent librados version in configure. If the librados version is too old, rbd support will be disabled. RBD is an block driver for the distributed file system Ceph (http://ceph.newdream.net/). This driver uses l

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-12-06 Thread Yehuda Sadeh Weinraub
On Mon, Dec 6, 2010 at 4:48 AM, Kevin Wolf wrote: > > > What's the easiest way to try it out? I tried to use vstart.sh and copy > the generated ceph.conf to /etc/ceph/ceph.conf so that qemu-img etc. > find the monitor address. However, that leads to a hang when I try "rbd > list" or "./qemu-img cr

Re: [Qemu-devel] [PATCH, RFT] monitor: implement x86 info tlb for PAE and long modes

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 1:05 PM, Ian Campbell wrote: > On Mon, 2010-12-06 at 12:12 +0100, Alexander Graf wrote: >> On 05.12.2010, at 17:25, Blue Swirl wrote: >> >> > 'info tlb' didn't show correct information for PAE mode and >> > x86_64 long mode. >> > >> > Implement the missing modes. Also print

[Qemu-devel] [PATCH 12/25] Monitor: Move qmp_query_kvm() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_kvm_print() to call it. Signed-off-by: Luiz Capitulino --- monitor.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/monitor.c b/monitor.c index 1fbe78b..e8f0562 100644 --- a/monitor.c +++ b/monitor.c @@ -1994,6

[Qemu-devel] [PATCH 23/25] Monitor: Convert do_info_migrate_print() into do_info_migrate()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_migrate() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- migration.c |8 ++-- migration.h |2 +- monitor.c |3 +-- 3 files changed, 8 insertions(+), 5 deletion

[Qemu-devel] [PATCH 07/25] Monitor: Convert bdrv_info_print() into bdrv_info()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_block() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- block.c |6 +- block.h |2 +- monitor.c |3 +-- 3 files changed, 7 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PATCH, RFT] monitor: implement x86 info tlb for PAE and long modes

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 11:12 AM, Alexander Graf wrote: > > On 05.12.2010, at 17:25, Blue Swirl wrote: > >> 'info tlb' didn't show correct information for PAE mode and >> x86_64 long mode. >> >> Implement the missing modes. Also print NX bit for PAE and long modes. >> Fix off-by-one error in 32 bit

[Qemu-devel] [PATCH 25/25] Monitor: do_info(): Drop unused code

2010-12-06 Thread Luiz Capitulino
Last commits moved QMP calling code to the info handlers themselves, now do_info() does nothing with QMP anymore, just drop all QMP handling code from it. Signed-off-by: Luiz Capitulino --- monitor.c | 42 ++ 1 files changed, 6 insertions(+), 36 deletion

[Qemu-devel] [PATCH 20/25] Monitor: Move qmp_query_uuid() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_uuid_print() to call it. Signed-off-by: Luiz Capitulino --- monitor.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 2d1f183..e9b07f3 100644 --- a/monitor.c +++ b/monitor.c @@ -806,11 +806,6 @@

[Qemu-devel] [PATCH 22/25] Monitor: qmp_query_migrate(): Return {} for empty MigrationState

2010-12-06 Thread Luiz Capitulino
When no migration has been performed (ie. empty MigrationState), qmp_query_migrate() returns nothing. Let's do what other query handlers do: return an empty json-object. Signed-off-by: Luiz Capitulino --- migration.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/m

[Qemu-devel] [PATCH 19/25] Monitor: Convert do_info_name_print() into do_info_name()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_name() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 8

[Qemu-devel] [PATCH 21/25] Monitor: Convert do_info_uuid_print() into do_info_uuid()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_uuid() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index e9b0

[Qemu-devel] [PATCH 16/25] Monitor: Convert do_info_mice_print() into do_info_mice()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_mice() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- console.h |2 +- input.c |9 +++-- monitor.c |3 +-- 3 files changed, 9 insertions(+), 5 deletions(-) di

[Qemu-devel] [PATCH 24/25] Monitor: Introduce do_info_balloon()

2010-12-06 Thread Luiz Capitulino
Today, the do_info() function takes care of handling asynchronous calls. But what we really want is to move all the asynchronous stuff behind the (future) QMP API. The QMP API will be directly used by handlers, and won't be tied to the human monitor common code (like do_info()) in any way. This c

[Qemu-devel] [PATCH 17/25] Monitor: Convert do_info_vnc_print() into do_info_vnc()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_vnc() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- console.h |2 +- monitor.c |3 +-- ui/vnc.c |9 +++-- 3 files changed, 9 insertions(+), 5 deletions(-) dif

[Qemu-devel] [PATCH 11/25] Monitor: Convert do_pci_info_print() into do_pci_info()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_pci() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- hw/pci.c |7 ++- hw/pci.h |2 +- monitor.c |3 +-- 3 files changed, 8 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv_stats()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_blockstats() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- block.c |6 +- block.h |2 +- monitor.c |3 +-- 3 files changed, 7 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 18/25] Monitor: Move qmp_query_name() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_name_print() to call it. Signed-off-by: Luiz Capitulino --- monitor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 59b3866..89325d8 100644 --- a/monitor.c +++ b/monitor.c @@ -748,6 +748,12 @

[Qemu-devel] [PATCH 15/25] Monitor: Convert do_info_status_print() into do_info_status()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_status() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 731

[Qemu-devel] [PATCH 04/25] Monitor: Move qmp_query_version() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_version_print() to call it. Signed-off-by: Luiz Capitulino --- monitor.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/monitor.c b/monitor.c index 481eab2..6252b3f 100644 --- a/monitor.c +++ b/monito

[Qemu-devel] [PATCH 14/25] Monitor: Move qmp_query_status() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_status_print() to use it. Signed-off-by: Luiz Capitulino --- monitor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 4286375..731cb35 100644 --- a/monitor.c +++ b/monitor.c @@ -2137,6 +2137,1

[Qemu-devel] [PATCH 13/25] Monitor: Convert do_info_kvm_print() into do_info_kvm()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_kvm() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index e8f05

[Qemu-devel] [PATCH 06/25] Monitor: Convert qemu_chr_info_print() into qemu_chr_info()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_chardev() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c |3 +-- qemu-char.c |8 ++-- qemu-char.h |2 +- 3 files changed, 8 insertions(+), 5 deletion

[Qemu-devel] [PATCH 03/25] Monitor: Drop balloon handlers comments

2010-12-06 Thread Luiz Capitulino
Commit 637503d122eb7656d91a8489e254d9e880be7504 dropped (duplicated) documentation from code, but it missed the balloon handlers. Signed-off-by: Luiz Capitulino --- balloon.c | 24 1 files changed, 0 insertions(+), 24 deletions(-) diff --git a/balloon.c b/balloon.c in

[Qemu-devel] [PATCH 09/25] Monitor: Move qmp_query_cpus() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change monitor_print_cpus() to call it. Signed-off-by: Luiz Capitulino --- monitor.c | 78 ++-- 1 files changed, 39 insertions(+), 39 deletions(-) diff --git a/monitor.c b/monitor.c index 3091a1a..f067d07 100644 -

[Qemu-devel] [PATCH 10/25] Monitor: Convert monitor_print_cpus() into do_info_cpus()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_cpus() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

2010-12-06 Thread Luiz Capitulino
Query handlers still carry their human monitor name. This commit renames all of them to a more QMP-like name. For example, do_info_version() is renamed to qmp_query_version(). Signed-off-by: Luiz Capitulino --- balloon.c |4 +- balloon.h |2 +- block.c |4 +- block.h |

[Qemu-devel] [PATCH 05/25] Monitor: Convert do_info_version_print() into do_info_version()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_version() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c inde

[Qemu-devel] [PATCH 02/25] QMP: Drop user_print usage from the qmp_query_cmds[] table

2010-12-06 Thread Luiz Capitulino
QMP doesn't use this field, it's only useful in the human monitor. NOTE: Other unused fields are going to be dropped by future commits. Signed-off-by: Luiz Capitulino --- monitor.c | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/monitor.c b/monitor.

[Qemu-devel] [PATCH v1 00/25]: Monitor: First step on an internal QMP API

2010-12-06 Thread Luiz Capitulino
Today, when writing an info command that is used by QMP and HMP, the programmer has to implement: 1. The handler itself, that's the function that gathers data and returns it as QObjects 2. A pretty printing function, which is called by the human monitor to print the returned QObjects in

Re: [Qemu-devel] [PATCH 05/10] ARM: Return correct result for float-to-integer conversion of NaN

2010-12-06 Thread Nathan Froyd
On Mon, Dec 06, 2010 at 05:00:06PM +, Peter Maydell wrote: > The ARM architecture mandates that converting a NaN value to > integer gives zero (if Invalid Operation FP exceptions are > not being trapped). This isn't the behaviour of the SoftFloat > library, so NaNs must be special-cased. > > S

Re: [Qemu-devel] [PATCH 07/10] ARM: Return correct result for single<->double conversion of NaN

2010-12-06 Thread Nathan Froyd
On Mon, Dec 06, 2010 at 05:00:08PM +, Peter Maydell wrote: > The ARM ARM defines that if the input to a single<->double conversion > is a NaN then the output is always forced to be a quiet NaN by setting > the most significant bit of the fraction part. > > Signed-off-by: Peter Maydell Review

Re: [Qemu-devel] [PATCH 06/10] softfloat: Add float*_maybe_silence_nan() functions

2010-12-06 Thread Nathan Froyd
On Mon, Dec 06, 2010 at 05:00:07PM +, Peter Maydell wrote: > Add functions float*_maybe_silence_nan() which ensure that a > value is not a signaling NaN by turning it into a quiet NaN. > > Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd -Nathan

Re: [Qemu-devel] [PATCH 04/10] softfloat: Add float*_is_any_nan() functions

2010-12-06 Thread Nathan Froyd
On Mon, Dec 06, 2010 at 05:00:05PM +, Peter Maydell wrote: > Add float*_is_any_nan() functions which return true if the argument > is a NaN of any kind (quiet or signalling). > > Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd -Nathan

Re: [Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 3:07 PM, Fabien Chouteau wrote: > On 12/06/2010 11:44 AM, Artyom Tarasenko wrote: >> >> On Mon, Dec 6, 2010 at 10:26 AM, Fabien Chouteau >>  wrote: >>> >>> Hi everyone, >>> I'm glad to submit my first patches to the Qemu-devel list. >>> >>> This patch set introduces a new SP

Re: [Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: > Hi everyone, > I'm glad to submit my first patches to the Qemu-devel list. > > This patch set introduces a new SPARC V8 machine: Leon3. It's an open-source > VHDL System-On-Chip, well known in space industry (more information on > http://www

Re: [Qemu-devel] [PATCH 6/6] [RFC] SPARCV8 asr17 register support.

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  hw/leon3.c               |    6 ++ >  target-sparc/cpu.h       |    1 + >  target-sparc/machine.c   |    2 ++ >  target-sparc/translate.c |   10 ++ >  4 files changed, 19 insertions(+),

Re: [Qemu-devel] [PATCH 5/6] [RFC] Emulation of Leon3.

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  Makefile.target          |    5 +- >  hw/leon3.c               |  310 > ++ >  target-sparc/cpu.h       |   10 ++ >  target-sparc/helper.c    |    2 +- >

Re: [Qemu-devel] [PATCH 4/6] [RFC] Header file for the GRLIB components.

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  hw/grlib.h |   27 +++ >  1 files changed, 27 insertions(+), 0 deletions(-) > > diff --git a/hw/grlib.h b/hw/grlib.h > new file mode 100644 > index 000..eab7974 > --- /dev

Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  hw/grlib_gptimer.c |  448 > >  1 files changed, 448 insertions(+), 0 deletions(-) > > diff --git a/hw/grlib_gptimer.c b/hw/grlib_gptimer.c > new

Re: [Qemu-devel] [PATCH 3/6] [RFC] Emulation of GRLIB APB UART as defined in GRLIB IP Core User's Manual.

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  hw/grlib_apbuart.c |  231 > >  1 files changed, 231 insertions(+), 0 deletions(-) > > diff --git a/hw/grlib_apbuart.c b/hw/grlib_apbuart.c > new

Re: [Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Peter Maydell
On 6 December 2010 16:57, Nathan Froyd wrote: > FWIW--and this is not particularly conducive to random insn > sequences--the approach taken when doing the AltiVec bits was to have > code that looked like: > >  for each insn: >     for a suitable set of inputs: >        setup interesting registers

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-06 Thread Blue Swirl
On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  hw/grlib_irqmp.c |  416 > ++ >  1 files changed, 416 insertions(+), 0 deletions(-) > > diff --git a/hw/grlib_irqmp.c b/hw/grlib_irqmp.c > new fil

[Qemu-devel] [PATCH 07/10] ARM: Return correct result for single<->double conversion of NaN

2010-12-06 Thread Peter Maydell
The ARM ARM defines that if the input to a single<->double conversion is a NaN then the output is always forced to be a quiet NaN by setting the most significant bit of the fraction part. Signed-off-by: Peter Maydell --- target-arm/helper.c | 12 ++-- 1 files changed, 10 insertions(+),

[Qemu-devel] [PATCH 03/10] ARM: Fix sense of to_integer bit in Neon VCVT float/int conversion

2010-12-06 Thread Peter Maydell
Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 696abf6..afb3872 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.

[Qemu-devel] [PATCH 06/10] softfloat: Add float*_maybe_silence_nan() functions

2010-12-06 Thread Peter Maydell
Add functions float*_maybe_silence_nan() which ensure that a value is not a signaling NaN by turning it into a quiet NaN. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 38 ++ fpu/softfloat.h|2 ++ 2 files changed, 40 insertion

[Qemu-devel] [PATCH 08/10] ARM: Ignore top 16 bits when doing VCVT from 16 bit fixed point

2010-12-06 Thread Peter Maydell
VCVT of 16 bit fixed point to float should ignore the top 16 bits of the source register. Cast to int16_t and friends rather than int16 -- the former is guaranteed exactly 16 bits wide where the latter is merely at least 16 bits wide (and so is usually 32 bits). Signed-off-by: Peter Maydell Revie

[Qemu-devel] [PATCH 10/10] ARM: Implement VCVT to 16 bit integer using new softfloat routines

2010-12-06 Thread Peter Maydell
Use the softfloat conversion routines for conversion to 16 bit integers, because just casting to a 16 bit type truncates the value rather than saturating it at 16-bit MAXINT/MININT. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/helper.c |2 +- 1 files changed, 1 inse

[Qemu-devel] [PATCH 01/10] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Peter Maydell
Correct the decoding of source and destination registers for the VFP forms of the VCVT instructions which convert between floating point and integer or fixed-point. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c | 19 --- 1 files changed, 12

[Qemu-devel] [PATCH 09/10] softfloat: Add float/double to 16 bit integer conversion functions

2010-12-06 Thread Peter Maydell
The ARM architecture needs float/double to 16 bit integer conversions. (The 32 bit versions aren't sufficient because of the requirement to saturate at 16 bit MAXINT/MININT and to get the exception bits right.) Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- fpu/softfloat.c | 136 ++

[Qemu-devel] [PATCH 05/10] ARM: Return correct result for float-to-integer conversion of NaN

2010-12-06 Thread Peter Maydell
The ARM architecture mandates that converting a NaN value to integer gives zero (if Invalid Operation FP exceptions are not being trapped). This isn't the behaviour of the SoftFloat library, so NaNs must be special-cased. Signed-off-by: Peter Maydell --- target-arm/helper.c | 27 ++

[Qemu-devel] [PATCH 02/10] ARM: Fix decoding of Neon forms of VCVT between float and fixed point

2010-12-06 Thread Peter Maydell
Fix errors in the decoding of the Neon forms of fixed-point VCVT: * fixed-point VCVT is op 14 and 15, not 15 and 16 * the fbits immediate field was being misinterpreted * the sense of the to_fixed bit was inverted Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translat

[Qemu-devel] [PATCH V2 00/10] ARM: fix VCVT instructions

2010-12-06 Thread Peter Maydell
This patch series corrects a number of errors in the decoding and implementation of various forms of the ARM VCVT instruction. The resulting qemu has been tested by execution of 100,000 random variants of these instruction patterns with register values cross-checked against the results given by Cor

[Qemu-devel] [PATCH 04/10] softfloat: Add float*_is_any_nan() functions

2010-12-06 Thread Peter Maydell
Add float*_is_any_nan() functions which return true if the argument is a NaN of any kind (quiet or signalling). Signed-off-by: Peter Maydell --- fpu/softfloat.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/fpu/softfloat.h b/fpu/softfloat.h index 9528825..9be

Re: [Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Nathan Froyd
On Mon, Dec 06, 2010 at 04:48:25PM +, Peter Maydell wrote: > I'm not sure how well it would fit into being committed to qemu (yet): > it works as a program where you run half of it on real ARM hardware > and the other half under qemu (or valgrind) and it compares register > results after execut

Re: [Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Peter Maydell
On 6 December 2010 16:30, Nathan Froyd wrote: > On Thu, Nov 11, 2010 at 06:23:55PM +, Peter Maydell wrote: >> Correct the decoding of source and destination registers >> for the VFP forms of the VCVT instructions which convert >> between floating point and integer or fixed-point. >> >> Signed-

Re: [Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Nathan Froyd
On Thu, Nov 11, 2010 at 06:23:55PM +, Peter Maydell wrote: > Correct the decoding of source and destination registers > for the VFP forms of the VCVT instructions which convert > between floating point and integer or fixed-point. > > Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd I

[Qemu-devel] Re: [PATCH v5 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 17:08, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-06 Thread Kevin Wolf
Am 03.12.2010 22:23, schrieb ronnie sahlberg: > Thankyou. > > On Sat, Dec 4, 2010 at 7:32 AM, Stefan Hajnoczi wrote: >> >> You want the library to be GPL, not LGPL? > > I have changed it to LGPLv3 for next submission. Please use "LGPL 2.1 or later". IIRC, qemu has some parts that are GPL 2 only

[Qemu-devel] [PATCH v6 3/5] qed: Table, L2 cache, and cluster functions

2010-12-06 Thread Stefan Hajnoczi
This patch adds code to look up data cluster offsets in the image via the L1/L2 tables. The L2 tables are writethrough cached in memory for performance (each read/write requires a lookup so it is essential to cache the tables). With cluster lookup code in place it is possible to implement bdrv_is

[Qemu-devel] [PATCH v6 4/5] qed: Read/write support

2010-12-06 Thread Stefan Hajnoczi
This patch implements the read/write state machine. Operations are fully asynchronous and multiple operations may be active at any time. Allocating writes lock tables to ensure metadata updates do not interfere with each other. If two allocating writes need to update the same L2 table they will

[Qemu-devel] [PATCH v6 2/5] qed: Add QEMU Enhanced Disk image format

2010-12-06 Thread Stefan Hajnoczi
This patch introduces the qed on-disk layout and implements image creation. Later patches add read/write and other functionality. Signed-off-by: Stefan Hajnoczi --- Makefile.objs |1 + block/qed.c | 554 + block/qed.h | 148 +

[Qemu-devel] [PATCH v5 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-img.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index aded72d..6b2b18b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -314,13 +314,15 @@ static int img_create(int argc,

[Qemu-devel] [PATCH v6 0/5] qed: Add QEMU Enhanced Disk format

2010-12-06 Thread Stefan Hajnoczi
For a changelog against v5, see below. QEMU Enhanced Disk format is a disk image format that forgoes features found in qcow2 in favor of better levels of performance and data integrity. Due to its simpler on-disk layout, it is possible to safely perform metadata updates more efficiently. Install

[Qemu-devel] [PATCH v6 5/5] qed: Consistency check support

2010-12-06 Thread Stefan Hajnoczi
This patch adds support for the qemu-img check command. It also introduces a dirty bit in the qed header to mark modified images as needing a check. This bit is cleared when the image file is closed cleanly. If an image file is opened and it has the dirty bit set, a consistency check will run an

[Qemu-devel] [PATCH v6 1/5] docs: Add QED image format specification

2010-12-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/specs/qed_spec.txt | 130 +++ 1 files changed, 130 insertions(+), 0 deletions(-) create mode 100644 docs/specs/qed_spec.txt diff --git a/docs/specs/qed_spec.txt b/docs/specs/qed_spec.txt new file mode 100644 in

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes Sorensen
On 12/06/10 16:57, Kevin Wolf wrote: > bdrv_delete doesn't check for NULL, so this still isn't enough. Try > something like "qemu-img resize -f vmdx foo +0" and you'll get a segfault. G :( It's a bummer things are so inconsistent throughout QEMU, most of the free() functions can handle it. U

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 16:45, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > qemu-img.c | 14 +- > 1 files changed, 9 insertions(+), 5 deletions(-) > @@ -1432,7 +1434,7 @@ static int img_resize(int argc, char **argv) > int c, ret, relati

[Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-img.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index aded72d..2deac67 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -314,13 +314,15 @@ static int img_create(int argc, char

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes Sorensen
On 12/06/10 16:25, Kevin Wolf wrote: >> } >> n = get_option_parameter(param, BLOCK_OPT_SIZE)->value.n; >> free_option_parameters(param); >> >> bs = bdrv_new_open(filename, fmt, BDRV_O_FLAGS | BDRV_O_RDWR); >> if (!bs) { >> -return 1; >> +ret = -1; >> +

[Qemu-devel] Re: [PATCH v3 0/7] Cleanup qemu-img code

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 15:25, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Hi, > > These patches applies a number of cleanups to qemu-img.c as well as a > minor bug in qemu-malloc.c. > > The handling of block help printing is moved to shared code, which > allows the "?" detection to happen

[Qemu-devel] [PATCH 2/2] Remove dead code for ARM semihosting commandline handling

2010-12-06 Thread Peter Maydell
From: Wolfgang Schildbach There are some bits in the code which were used to store the commandline for the semihosting call. These bits are now write-only and can be removed. Signed-off-by: Wolfgang Schildbach Reviewed-by: Peter Maydell --- bsd-user/bsdload.c |2 -- bsd-user/qemu.h

  1   2   >