Re: [Qemu-devel] Re: [Spice-devel] RFC; usb redirection protocol

2010-12-16 Thread Gerd Hoffmann
Hi, I know of devices that will enumerate twice, first as one device, then after a certain setup exchange as another. But that seems to be covered by the suggestion here, it will just be identicle to two completely different transports. Or identify devices by physical port instead of bus

[Qemu-devel] Re: [Spice-devel] RFC; usb redirection protocol

2010-12-16 Thread Gerd Hoffmann
Hi, It could be that the implementation decides to not handle synchroneous commands synchroneous at all. The main difference I'm trying to make here is between commands which do things to end points which cannot be done while other packets are in flight (like setting configuration, or

Re: [Qemu-devel] Re: [PATCH 00/15] Megasas HBA emulation and SCSI update v.3

2010-12-16 Thread Stefan Hajnoczi
On Thu, Dec 16, 2010 at 1:45 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2010-12-13 at 08:32 +0100, Hannes Reinecke wrote: On 12/10/2010 11:14 PM, Paolo Bonzini wrote: On 11/24/2010 05:50 PM, Christoph Hellwig wrote: Btw, it might make sense to split this series into

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 04:08:16PM +0900, Isaku Yamahata wrote: On Wed, Dec 15, 2010 at 08:27:49AM -0700, Alex Williamson wrote: On Wed, 2010-12-15 at 11:56 +0200, Michael S. Tsirkin wrote: On Tue, Dec 14, 2010 at 11:34:53AM -0700, Alex Williamson wrote: On Tue, 2010-12-14 at 14:26

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/15/2010 08:00 PM, Luiz Capitulino wrote: Looks like a GUI feature to me, Really? Can't see how you can build NMI to all CPUs from NMI this CPU. Or am I misunderstanding you? I guess so. Avi referred to 'nmi button on many machines', I assumed he meant a virtual machine GUI,

[Qemu-devel] Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:50PM +0900, Yoshiaki Tamura wrote: Record ioport event to replay it upon failover.

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 15 Dec 2010 18:45:09 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 15 Dec 2010 19:18:32 +0200 Avi Kivity a...@redhat.com wrote: [...] I'd like to see cpu-index made

[Qemu-devel] Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-16 Thread Yoshiaki Tamura
2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:50PM +0900, Yoshiaki Tamura wrote: Record

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: 2010/12/3 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/12/2 Michael S. Tsirkin m...@redhat.com: On Wed, Dec 01, 2010 at 05:03:43PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Sun,

[Qemu-devel] Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 06:50:04PM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On

Re: [Qemu-devel] [PATCH 1/2] Introduce strtosz_suffix()

2010-12-16 Thread Markus Armbruster
Sorry for the late review. jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This introduces strtosz_suffix() which allows the caller to specify a default suffix in case the non default of MB is wanted. strtosz() is kept as a wrapper for strtosz_suffix() which

Re: [Qemu-devel] [PATCH 0/1] introduce spice-qemu-char chardev

2010-12-16 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: Adding a chardev backend for spice, for usage by spice vdagent over a with virtio-serial device. Please put this into PATCH 1/1, so it gets committed. Thanks.

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/16/2010 12:48 PM, Luiz Capitulino wrote: Ok, I didn't know that, but I had another idea: the command could accept either a single cpu index or a list: { execute: inject-nmi, arguments: { cpus: 2 } } { execute: inject-nmi, arguments: { cpus: [1, 2, 3, 4] } } This has the feature

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 11:03:38 +0200 Avi Kivity a...@redhat.com wrote: On 12/15/2010 08:00 PM, Luiz Capitulino wrote: Looks like a GUI feature to me, Really? Can't see how you can build NMI to all CPUs from NMI this CPU. Or am I misunderstanding you? I guess so. Avi

[Qemu-devel] [PATCH 1/3] qemu-img.c: Re-factor img_create()

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch re-factors img_create() moving the code doing the actual work into block.c where it can be shared with QEMU. This is needed to be able to create images from QEMU to be used for live snapshots. Signed-off-by: Jes Sorensen

[Qemu-devel] [PATCH 3/3] Prevent creating an image with the same filename as backing file

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 765f9f3..027dc6a 100644 --- a/block.c +++ b/block.c @@ -2769,6 +2769,13 @@ int

[Qemu-devel] [PATCH v2 0/3] Re-factor img_create() and add live snapshots

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This set of patches re-factors img_create() and moves the core part of it into block.c so it can be accessed from qemu as well as qemu-img. The second patch adds basic live snapshots support to the code, however only snapshots to external QCOW2

[Qemu-devel] [PATCH 2/5] ccid: add passthru card device

2010-12-16 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy al...@redhat.com ---

[Qemu-devel] [PATCH 0/5] usb-ccid (v10)

2010-12-16 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 2/3] Introduce do_snapshot_blkdev() and monitor command to handle it.

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The monitor command is: snapshot_blkdev device [snapshot-file] [format] Default format is qcow2. For now snapshots without a snapshot-file, eg internal snapshots, are not supported. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- blockdev.c

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 12:51:14 +0200 Avi Kivity a...@redhat.com wrote: On 12/16/2010 12:48 PM, Luiz Capitulino wrote: Ok, I didn't know that, but I had another idea: the command could accept either a single cpu index or a list: { execute: inject-nmi, arguments: { cpus: 2 } } {

Re: [Qemu-devel] [Qestion] What status of memory stats feature

2010-12-16 Thread Luiz Capitulino
On Wed, 15 Dec 2010 16:58:03 -0600 Adam Litke a...@us.ibm.com wrote: On Wed, 2010-12-15 at 15:39 -0200, Luiz Capitulino wrote: On Wed, 15 Dec 2010 16:20:05 +0900 Ken'ichi Ohmichi oomi...@mxs.nes.nec.co.jp wrote: Hi, I tried to get the memory stats by using

[Qemu-devel] [PATCH 4/5] ccid: add ccid-card-emulated device (v2)

2010-12-16 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and

[Qemu-devel] [PATCH 1/5] usb-ccid: add CCID bus

2010-12-16 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

[Qemu-devel] Re: [PATCH 1/3] qemu-img.c: Re-factor img_create()

2010-12-16 Thread Kevin Wolf
Am 16.12.2010 12:04, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com This patch re-factors img_create() moving the code doing the actual work into block.c where it can be shared with QEMU. This is needed to be able to create images from QEMU to be used for live

Re: [Qemu-devel] [PATCH 3/3] Prevent creating an image with the same filename as backing file

2010-12-16 Thread Stefan Hajnoczi
On Thu, Dec 16, 2010 at 11:04 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---  block.c |    7 +++  1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH 5/5] ccid: add docs

2010-12-16 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. --- docs/ccid.txt | 125 ++ docs/libcacard.txt | 483 2 files changed, 125 insertions(+), 483

[Qemu-devel] [PATCH 2/2] ARM: Implement correct NaN propagation rules

2010-12-16 Thread Peter Maydell
Implement the correct NaN propagation rules for ARM targets by providing an appropriate pickNaN function. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- fpu/softfloat-specialize.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 2/3] Introduce do_snapshot_blkdev() and monitor command to handle it.

2010-12-16 Thread Kevin Wolf
Am 16.12.2010 12:04, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com The monitor command is: snapshot_blkdev device [snapshot-file] [format] Default format is qcow2. For now snapshots without a snapshot-file, eg internal snapshots, are not supported.

[Qemu-devel] [PATCH 0/2] ARM: Implement correct NaN propagation rules

2010-12-16 Thread Peter Maydell
IEEE754 doesn't specify precisely what NaN should be returned as the result of an operation on two input NaNs. The existing softfloat code hardwires x87 propagation rules. This patchset abstracts out the code in the various propagateFloat*NaN() functions which picks a NaN to return, so that it can

[Qemu-devel] Re: [PATCH 2/3] Introduce do_snapshot_blkdev() and monitor command to handle it.

2010-12-16 Thread Jes Sorensen
On 12/16/10 12:45, Kevin Wolf wrote: Am 16.12.2010 12:04, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com The monitor command is: snapshot_blkdev device [snapshot-file] [format] Default format is qcow2. For now snapshots without a snapshot-file, eg internal

[Qemu-devel] Re: [PATCH 3/3] Prevent creating an image with the same filename as backing file

2010-12-16 Thread Kevin Wolf
Am 16.12.2010 12:04, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 765f9f3..027dc6a 100644

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 16 Dec 2010 11:03:38 +0200 Avi Kivity a...@redhat.com wrote: On 12/15/2010 08:00 PM, Luiz Capitulino wrote: Looks like a GUI feature to me, Really? Can't see how you can build NMI to all CPUs from NMI this CPU. Or

[Qemu-devel] Re: [PATCH] ide: Register vm change state handler once only

2010-12-16 Thread Kevin Wolf
Am 10.12.2010 15:47, schrieb Stefan Hajnoczi: We register the vm change state handler in a PCI BAR map() function. This function can be called multiple times throughout the lifetime of a PCI IDE device. This results in duplicate vm change state handlers being register, none of which are ever

[Qemu-devel] Re: [PATCH 1/3] qemu-img.c: Re-factor img_create()

2010-12-16 Thread Jes Sorensen
On 12/16/10 12:35, Kevin Wolf wrote: Am 16.12.2010 12:04, schrieb jes.soren...@redhat.com: + +backing_fmt = get_option_parameter(param, BLOCK_OPT_BACKING_FMT); +if (backing_fmt backing_fmt-value.s) { +if (!bdrv_find_format(backing_fmt-value.s)) { +

Re: [Qemu-devel] [PATCH 1/5] usb-ccid: add CCID bus

2010-12-16 Thread Gerd Hoffmann
On 12/16/10 12:06, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card.

Re: [Qemu-devel] [PATCH 2/5] ccid: add passthru card device

2010-12-16 Thread Gerd Hoffmann
On 12/16/10 12:06, Alon Levy wrote: The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Acked-by: Gerd

[Qemu-devel] [PATCH 1/1] spice: add chardev

2010-12-16 Thread Alon Levy
Adding a chardev backend for spice, for usage by spice vdagent in conjunction with a properly named virtio-serial device. --- Makefile.objs |2 +- qemu-char.c |7 ++ qemu-config.c |9 ++ qemu-options.hx | 18 - spice-qemu-char.c | 222

[Qemu-devel] [PATCH 1/2] softfloat: abstract out target-specific NaN propagation rules

2010-12-16 Thread Peter Maydell
IEEE754 doesn't specify precisely what NaN should be returned as the result of an operation on two input NaNs. This is therefore target-specific. Abstract out the code in propagateFloat*NaN() which was implementing the x87 propagation rules, so that it can be easily replaced on a per-target basis.

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-16 Thread Paolo Bonzini
On 12/15/2010 08:04 PM, Michael S. Tsirkin wrote: This assuming upstream developers do not care about downstreams. To give a chance for downstream to cherry-pick changes, upstream should use subsections instead of version ids too. Then version ids should be deprecated altogether. Nothing

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/16/2010 01:47 PM, Markus Armbruster wrote: This has the feature of injecting the nmi in just some cpus, although I'm not sure this is going to be desired/useful. Use case for NMI-ing a subset of the CPUs? Heck, use case for anything else but NMI all? Exactly. -- error compiling

[Qemu-devel] [PATCH 2/4] Introduce do_snapshot_blkdev() and monitor command to handle it.

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The monitor command is: snapshot_blkdev device [snapshot-file] [format] Default format is qcow2. For now snapshots without a snapshot-file, eg internal snapshots, are not supported. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- blockdev.c

[Qemu-devel] [PATCH 1/4] qemu-img.c: Re-factor img_create()

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch re-factors img_create() moving the code doing the actual work into block.c where it can be shared with QEMU. This is needed to be able to create images from QEMU to be used for live snapshots. Signed-off-by: Jes Sorensen

[Qemu-devel] [PATCH v3 0/4] Re-factor img_create() and add live snapshots

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This set of patches re-factors img_create() and moves the core part of it into block.c so it can be accessed from qemu as well as qemu-img. The second patch adds basic live snapshots support to the code, however only snapshots to external QCOW2

Re: [Qemu-devel] [PATCH 3/5] libcacard: initial commit after coding style fixes

2010-12-16 Thread Gerd Hoffmann
On 12/16/10 12:06, Alon Levy wrote: libcacard emulates a Common Access Card (CAC) which is a standard for smartcards. It is used by the emulated ccid card introduced in a following patch. Docs are available in docs/libcacard.txt Looks good to me, although I'm not a crypto expert. Most of the

[Qemu-devel] [PATCH 4/4] bdrv_img_create() use proper errno return values

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Kevin suggested to have bdrv_img_create() return proper -errno values on error. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/block.c

Re: [Qemu-devel] [PATCH 4/5] ccid: add ccid-card-emulated device (v2)

2010-12-16 Thread Gerd Hoffmann
On 12/16/10 12:06, Alon Levy wrote: This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can

[Qemu-devel] [PATCH 3/4] Prevent creating an image with the same filename as backing file

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index a48b30c..0c14eee 100644 --- a/block.c +++ b/block.c @@ -2764,7 +2764,7 @@ int

Re: [Qemu-devel] [PATCH 5/5] ccid: add docs

2010-12-16 Thread Gerd Hoffmann
On 12/16/10 12:06, Alon Levy wrote: Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. --- docs/ccid.txt | 125 ++ docs/libcacard.txt | 483 Guess that

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 14:50:08 +0200 Avi Kivity a...@redhat.com wrote: On 12/16/2010 01:47 PM, Markus Armbruster wrote: This has the feature of injecting the nmi in just some cpus, although I'm not sure this is going to be desired/useful. Use case for NMI-ing a subset of the CPUs?

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/16/2010 03:09 PM, Luiz Capitulino wrote: On Thu, 16 Dec 2010 14:50:08 +0200 Avi Kivitya...@redhat.com wrote: On 12/16/2010 01:47 PM, Markus Armbruster wrote: This has the feature of injecting the nmi in just some cpus, although I'm not sure this is going to be

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 15:11:50 +0200 Avi Kivity a...@redhat.com wrote: On 12/16/2010 03:09 PM, Luiz Capitulino wrote: On Thu, 16 Dec 2010 14:50:08 +0200 Avi Kivitya...@redhat.com wrote: On 12/16/2010 01:47 PM, Markus Armbruster wrote: This has the feature of injecting

Re: [Qemu-devel] [PATCH 1/1] spice: add chardev

2010-12-16 Thread Gerd Hoffmann
On 12/16/10 12:29, Alon Levy wrote: Adding a chardev backend for spice, for usage by spice vdagent in conjunction with a properly named virtio-serial device. Usage example would be nice here. +#ifdef CONFIG_SPICE +#include spice-qemu-char.h +#endif #ifdef can be dropped. +#ifdef

[Qemu-devel] [PATCH] qemu.img.c: Use error_report() instead of own error() implementation

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-img.c | 128 +-- 1 files changed, 63 insertions(+), 65 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 603bdb3..d3921b6 100644

[Qemu-devel] [PATCH] qemu-img: Call error_set_progname

2010-12-16 Thread Kevin Wolf
Call error_set_progname during the qemu-img initialization, so that error messages printed with error_report() use the right prefix. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

[Qemu-devel] Re: [PATCH v3 0/4] Re-factor img_create() and add live snapshots

2010-12-16 Thread Kevin Wolf
Am 16.12.2010 13:52, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com Hi, This set of patches re-factors img_create() and moves the core part of it into block.c so it can be accessed from qemu as well as qemu-img. The second patch adds basic live snapshots

[Qemu-devel] Re: [PATCH] qemu.img.c: Use error_report() instead of own error() implementation

2010-12-16 Thread Kevin Wolf
Am 16.12.2010 14:31, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Thanks, applied to the block branch. Kevin

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-16 Thread Yoshiaki Tamura
2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: 2010/12/3 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/12/2 Michael S. Tsirkin m...@redhat.com: On Wed, Dec 01, 2010 at 05:03:43PM +0900, Yoshiaki Tamura wrote: 2010/11/28

[Qemu-devel] Re: [PATCH] qemu-img: Call error_set_progname

2010-12-16 Thread Jes Sorensen
On 12/16/10 15:13, Kevin Wolf wrote: Call error_set_progname during the qemu-img initialization, so that error messages printed with error_report() use the right prefix. Signed-off-by: Kevin Wolf kw...@redhat.com Acked-by: Jes Sorensen jes.soren...@redhat.com --- qemu-img.c |3 +++

[Qemu-devel] [PATCH] Remove NULL checks for bdrv_new return value

2010-12-16 Thread Kevin Wolf
It's an indirect call to qemu_malloc, which never returns an error. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/xen_disk.c | 17 ++--- qemu-img.c|5 + qemu-io.c |2 -- qemu-nbd.c|2 -- 4 files changed, 7 insertions(+), 19 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: 2010/12/3 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/12/2 Michael S. Tsirkin m...@redhat.com: On Wed,

[Qemu-devel] [PATCH v2] Remove NULL checks for bdrv_new return value

2010-12-16 Thread Kevin Wolf
It's an indirect call to qemu_malloc, which never returns an error. Signed-off-by: Kevin Wolf kw...@redhat.com --- v2: - Fixed bdrv_open failure case in xen_disk hw/xen_disk.c | 17 ++--- qemu-img.c|5 + qemu-io.c |2 -- qemu-nbd.c|2 -- 4 files

Re: [Qemu-devel] Re: [PATCH 00/15] Megasas HBA emulation and SCSI update v.3

2010-12-16 Thread Kevin Wolf
Am 16.12.2010 02:45, schrieb Benjamin Herrenschmidt: On Mon, 2010-12-13 at 08:32 +0100, Hannes Reinecke wrote: On 12/10/2010 11:14 PM, Paolo Bonzini wrote: On 11/24/2010 05:50 PM, Christoph Hellwig wrote: Btw, it might make sense to split this series into two. Patches 1 to 11 are genuine

[Qemu-devel] classic emulator Vs QEMU-TCG

2010-12-16 Thread Stefano Bonifazi
Hi all! I am a student, trying to understand QEMU, specifically TCG translation/execution. After spending much time on the code I still have big doubts. I think my doubts are due to the classic idea I have of an emulator. Actually as a student, I've never developed even a simple classic

Re: [Qemu-devel] classic emulator Vs QEMU-TCG

2010-12-16 Thread Peter Maydell
On 16 December 2010 15:20, Stefano Bonifazi stefboombas...@gmail.com wrote: so I thought tcg_qemu_tb_exec function should do the work of executing the translated binary in the host. But then I found out it is just a define in tcg.h: #define tcg_qemu_tb_exec(tb_ptr) ((long REGPARM (*)(void

Re: [Qemu-devel] ]PATCH 0/7] add TRIM/UNMAP support, v3

2010-12-16 Thread Kevin Wolf
Am 10.12.2010 16:00, schrieb Christoph Hellwig: This patchset adds support for the ATA TRIM and SCSI WRITE SAME with unmap commands, which allow reclaiming free space from a backing image. The user facing implementation is pretty complete, but not really efficient because the underlying

Re: [Qemu-devel] [PATCH 2/7] scsi-disk: support WRITE SAME (16) with unmap bit

2010-12-16 Thread Kevin Wolf
Am 10.12.2010 16:00, schrieb Christoph Hellwig: Support discards via the WRITE SAME command with the unmap bit set, and tell the initiator about the support for it via the block limit and the new thin provisioning EVPD pages. Also fix the comment which incorrectly describedthe block limits

[Qemu-devel] [PATCH v2] ide: Register vm change state handler once only

2010-12-16 Thread Stefan Hajnoczi
We register the vm change state handler in a PCI BAR map() function. This function can be called multiple times throughout the lifetime of a PCI IDE device. This results in duplicate vm change state handlers being register, none of which are ever unregistered. Instead, register the vm change

Re: [Qemu-devel] classic emulator Vs QEMU-TCG

2010-12-16 Thread Mulyadi Santosa
Hi Stefano I'll try to share what I know about TCG.. On Thu, Dec 16, 2010 at 22:20, Stefano Bonifazi stefboombas...@gmail.com wrote: Actually as a student, I've never developed even a simple classic emulator myself, you're not alone...trust me.. :) but in my idea it should follow

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-16 Thread Yoshiaki Tamura
2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: 2010/12/3 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp:

[Qemu-devel] [PATCH 2/2] Add proper -errno error return values to qcow2_open()

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com In addition this adds missing braces to the function to be consistent with the coding style. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block/qcow2.c | 61 1 files changed, 43

[Qemu-devel] [PATCH 0/2] qcow2 cleanups

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, These two patches tries to clean up the qcow2 code a little. First makes the function names consistent, ie. we shouldn't have qcow_ functions in the qcow2 code. Second tries to add proper errno return values to qcow2_open(). Jes Sorensen (2):

[Qemu-devel] [PATCH 1/2] block/qcow2.c: rename qcow_ functions to qcow2_

2010-12-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com It doesn't really make sense for functions in qcow2.c to be named qcow_ so convert the names to match correctly. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block/qcow2-cluster.c |6 +- block/qcow2-snapshot.c |6 +- block/qcow2.c

[Qemu-devel] -snapshot

2010-12-16 Thread Amador Pahim
Hello, Is a bad idea if I run multiples qemu vms pointing to the same disk img using -snapshot parameter? What kind of problem may I have? Thanks,

[Qemu-devel] Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-16 Thread Stefan Hajnoczi
On Thu, Dec 16, 2010 at 9:50 AM, Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/11/28 Michael S. Tsirkin

Re: [Qemu-devel] -snapshot

2010-12-16 Thread Stefan Hajnoczi
On Thu, Dec 16, 2010 at 4:21 PM, Amador Pahim ama...@pahim.org wrote: Is a bad idea if I run multiples qemu vms pointing to the same disk img using -snapshot parameter? What kind of problem may I have? It should work fine. -snapshot means that QEMU creates a temporary qcow2 file backed by the

Re: [Qemu-devel] -snapshot

2010-12-16 Thread Amador Pahim
Hello Stefan, Thank you for your answer. Just one more question: If, while my snapshot vms are running, the main disk is modified by a non snapshot vm? For example, installing some extra software.. this can freeze vms or something? Regards, Pahim On Thu, Dec 16, 2010 at 2:28 PM, Stefan Hajnoczi

Re: [Qemu-devel] ]PATCH 0/7] add TRIM/UNMAP support, v3

2010-12-16 Thread Christoph Hellwig
On Thu, Dec 16, 2010 at 04:43:20PM +0100, Kevin Wolf wrote: The SCSI changes seem to apply, but the rest conflicts with recent changes, most notably AHCI. Can you rebase on top of the block branch? I've tried to, but with the maze of pointer indirections I'm totally lost for now. I'll have to

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify

2010-12-16 Thread Stefan Hajnoczi
On Wed, Dec 15, 2010 at 12:59 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Dec 15, 2010 at 12:14 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 15, 2010 at 11:42:12AM +, Stefan Hajnoczi wrote: Are you happy with this patchset if I remove virtio-net-pci ioeventfd=on|off

Re: [Qemu-devel] [PATCH 2/7] scsi-disk: support WRITE SAME (16) with unmap bit

2010-12-16 Thread Christoph Hellwig
On Thu, Dec 16, 2010 at 04:48:15PM +0100, Kevin Wolf wrote: +scsi_req_set_status(r, GOOD, NO_SENSE); +scsi_req_complete(r-req); +scsi_remove_request(r); Isn't this the same as scsi_command_complete()? Yes. +return 0; And if you break; here instead

Re: [Qemu-devel] [PATCH 1/1] spice: add chardev

2010-12-16 Thread Alon Levy
On Thu, Dec 16, 2010 at 02:21:16PM +0100, Gerd Hoffmann wrote: On 12/16/10 12:29, Alon Levy wrote: Adding a chardev backend for spice, for usage by spice vdagent in conjunction with a properly named virtio-serial device. Usage example would be nice here. +#ifdef CONFIG_SPICE +#include

Re: [Qemu-devel] [PATCH 5/5] ccid: add docs

2010-12-16 Thread Alon Levy
On Thu, Dec 16, 2010 at 02:01:34PM +0100, Gerd Hoffmann wrote: On 12/16/10 12:06, Alon Levy wrote: Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. --- docs/ccid.txt | 125 ++ docs/libcacard.txt |

Re: [Qemu-devel] [PATCH 1/1] spice: add chardev

2010-12-16 Thread Gerd Hoffmann
Hi, +//#define SPICE_QEMU_CHAR_USE_IOCTL Why is this disabled? Does it depend on the chardev patches from Amit? There was a long discussion that concluded we don't want IOCTL's at all, and that there should be some other mechanism for connection state communication between the two sides.

Re: [Qemu-devel] -snapshot

2010-12-16 Thread Stefan Hajnoczi
On Thu, Dec 16, 2010 at 4:34 PM, Amador Pahim ama...@pahim.org wrote: Thank you for your answer. Just one more question: If, while my snapshot vms are running, the main disk is modified by a non snapshot vm? For example, installing some extra software.. this can freeze vms or something?

Re: [Qemu-devel] [PATCH v2] Remove NULL checks for bdrv_new return value

2010-12-16 Thread Stefan Hajnoczi
On Thu, Dec 16, 2010 at 2:44 PM, Kevin Wolf kw...@redhat.com wrote: It's an indirect call to qemu_malloc, which never returns an error. Signed-off-by: Kevin Wolf kw...@redhat.com --- v2: - Fixed bdrv_open failure case in xen_disk  hw/xen_disk.c |   17 ++---  qemu-img.c    |  

[Qemu-devel] Re: [PATCH 4/4] qcow2: Use block-queue

2010-12-16 Thread Stefan Hajnoczi
On Mon, Dec 13, 2010 at 4:29 PM, Kevin Wolf kw...@redhat.com wrote: diff --git a/block/qcow2.c b/block/qcow2.c index 537c479..e445913 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -136,6 +136,20 @@ static int qcow_read_extensions(BlockDriverState *bs, uint64_t start_offset,     return

[Qemu-devel] [PATCH 0/2] Fix rtl8139 migration with hotplug

2010-12-16 Thread Alex Williamson
Ok, I think this might actually make everyone happy, but I've been known to be wrong about that many times before. Juan challenged me to find an rtl8139 migration scenario that fails when hotplug is not involved (and not switch device creation order since that's a usage bug). I couldn't come up

[Qemu-devel] [patch 1/3] add migration_active function

2010-12-16 Thread Marcelo Tosatti
To query whether migration is active. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-kvm-block-copy/migration.c === --- qemu-kvm-block-copy.orig/migration.c +++ qemu-kvm-block-copy/migration.c @@ -448,3 +448,13 @@

Re: [Qemu-devel] [PATCH 00/14] [PULL] ARM fixes, v2

2010-12-16 Thread Peter Maydell
On 7 December 2010 15:50, Peter Maydell peter.mayd...@linaro.org wrote: The following changes since commit 2c90fe2b71df2534884bce96d90cbfcc93aeedb8:  Kirill Batuzov (1):        Speedup 'tb_find_slow' by using the same heuristic as during memory page lookup are available in the git repository

[Qemu-devel] [patch 0/3] add support for live block copy

2010-12-16 Thread Marcelo Tosatti
Add support for live block copy. This is similar (and based on), block migration, except it is performed without VM migration.

Re: [Qemu-devel] -snapshot

2010-12-16 Thread Stefan Weil
Am 16.12.2010 18:45, schrieb Stefan Hajnoczi: On Thu, Dec 16, 2010 at 4:34 PM, Amador Pahim ama...@pahim.org wrote: Thank you for your answer. Just one more question: If, while my snapshot vms are running, the main disk is modified by a non snapshot vm? For example, installing some extra

[Qemu-devel] [PATCH] qdev: sysbus_get_default must not return a NULL pointer (fix regression)

2010-12-16 Thread Stefan Weil
Every system should have some sort of main system bus, so sysbus_get_default should always return a valid bus. Without this patch, at least mipssim and malta no longer start but raise a null pointer access exception (caused by commit ec990eb622ad46df5ddcb1e94c418c271894d416). Cc: Anthony Liguori

[Qemu-devel] Re: [PATCH 0/3] add TRIM/UNMAP support, v4

2010-12-16 Thread Christoph Hellwig
This patchset adds support for the SCSI WRITE SAME with unmap command, which allows reclaiming free space from a backing image. The user facing implementation is pretty complete, but not really efficient because the underlying bdrv_discard implementation doesn't use the aio implementation yet.

[Qemu-devel] [PATCH 1/3] block: add discard support

2010-12-16 Thread Christoph Hellwig
Add a new bdrv_discard method to free blocks in a mapping image, and a new drive property to set the granularity for these discard. If no discard granularity support is set discard support is disabled. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block.c

[Qemu-devel] [PATCH 2/3] scsi-disk: support WRITE SAME (16) with unmap bit

2010-12-16 Thread Christoph Hellwig
Support discards via the WRITE SAME command with the unmap bit set, and tell the initiator about the support for it via the block limit and the new thin provisioning EVPD pages. Also fix the comment which incorrectly describedthe block limits EVPD page. Signed-off-by: Christoph Hellwig

[Qemu-devel] [PATCH 3/3] raw-posix: add discard support

2010-12-16 Thread Christoph Hellwig
Add support to discard blocks in a raw image residing on an XFS filesystem by calling the XFS_IOC_UNRESVSP64 ioctl to punch holes. Support for other hole punching mechanisms can be added when they become available. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block/raw-posix.c

[Qemu-devel] [PATCH 1/2] qdev: Track runtime machine modifications

2010-12-16 Thread Alex Williamson
Create a trivial interface to track whether the machine has been modified since boot. Adding or removing devices will trigger this to return true. An example usage scenario for such an interface is the rtl8139 driver which includes a cpu_register_io_memory() value in it's migration stream. For

[Qemu-devel] [patch 3/3] do not allow migration if block copy in progress

2010-12-16 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-kvm-block-copy/migration.c === --- qemu-kvm-block-copy.orig/migration.c +++ qemu-kvm-block-copy/migration.c @@ -19,6 +19,7 @@ #include block.h #include qemu_socket.h

[Qemu-devel] [patch 2/3] live block copy

2010-12-16 Thread Marcelo Tosatti
Add support for live block copy. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-kvm/block-copy.c === --- /dev/null +++ qemu-kvm/block-copy.c @@ -0,0 +1,728 @@ +/* + * QEMU live block copy + * + * Copyright (C) 2010

Re: [Qemu-devel] -snapshot

2010-12-16 Thread Amador Pahim
Thanks. Some stuff are clear now. I started a VDI Open Source project (http://www.ucs.br/projeto/osdvt/) and your information will help a lot. Pahim On Thu, Dec 16, 2010 at 4:16 PM, Stefan Weil w...@mail.berlios.de wrote: Am 16.12.2010 18:45, schrieb Stefan Hajnoczi: On Thu, Dec 16, 2010 at

  1   2   >