Re: [Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-31 Thread Aurelien Jarno
On Sat, Jan 01, 2011 at 12:41:10AM +0100, Andreas Färber wrote: > Am 31.12.2010 um 20:10 schrieb Aurelien Jarno: > >> On Thu, Dec 30, 2010 at 05:42:43PM +, Blue Swirl wrote: >>> I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in >>> hw/vga_template.h. I'd suppose that VGA (especially PCI

Re: [Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-31 Thread Andreas Färber
Am 31.12.2010 um 20:10 schrieb Aurelien Jarno: On Thu, Dec 30, 2010 at 05:42:43PM +, Blue Swirl wrote: I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in hw/vga_template.h. I'd suppose that VGA (especially PCI devices) would be always little endian, so why the checks? I also do

Re: [Qemu-devel] [PATCH] cirrus_vga: fix division by 0 for color expansion rop

2010-12-31 Thread Andreas Färber
Am 31.12.2010 um 20:11 schrieb Aurelien Jarno: Commit d85d0d3883f5a567fa2969a0396e42e0a662b3fa introduces a regression with Windows ME that leads to a division by 0 and a crash. It uses the color expansion rop with the source pitch set to 0. This is something allowed, as the manual explici

[Qemu-devel] [Bug 696015] Re: UMAAL should use unsigned multiply

2010-12-31 Thread Peter Maydell
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/696015 Title: UMAAL should use unsigned multiply Status in QEMU: Fix Committed Bug descript

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-12-31 Thread Dr. The Fugitive
running this on a real arm board, snapdragon htc phone this is a chroot apt-get install ubuntu-netbook. here is the results of my 'kill -SIGINT' for hanging mono processess, this does not appear to be an issue related to kvm, since this has been done outside the virtual machine: Setting up mono-

[Qemu-devel] Re: [PATCH v2] target-arm: fix UMAAL instruction

2010-12-31 Thread Aurelien Jarno
On Fri, Dec 31, 2010 at 09:09:04PM +, Peter Maydell wrote: > On 31 December 2010 20:54, Aurelien Jarno wrote: > > UMAAL should use unsigned multiply instead of signed. > > > > This patch fixes this issue by handling UMAAL separately from > > UMULL/UMLAL/SMULL/SMLAL as these instructions are di

[Qemu-devel] [Bug 696015] Re: UMAAL should use unsigned multiply

2010-12-31 Thread Peter Maydell
> If you could provide your patch with a Signed-off-by: line ...in fact Aurilien Jarno has produced a patch which fixes this bug and does some code cleanup in the process, so you don't need to do this. -- You received this bug notification because you are a member of qemu- devel-ml, which is sub

[Qemu-devel] Re: [PATCH v2] target-arm: fix UMAAL instruction

2010-12-31 Thread Peter Maydell
On 31 December 2010 20:54, Aurelien Jarno wrote: > UMAAL should use unsigned multiply instead of signed. > > This patch fixes this issue by handling UMAAL separately from > UMULL/UMLAL/SMULL/SMLAL as these instructions are different > enough. It also explicitly list instructions in case and catch

[Qemu-devel] [PATCH v2] target-arm: fix UMAAL instruction

2010-12-31 Thread Aurelien Jarno
UMAAL should use unsigned multiply instead of signed. This patch fixes this issue by handling UMAAL separately from UMULL/UMLAL/SMULL/SMLAL as these instructions are different enough. It also explicitly list instructions in case and catch nonexistent instruction as illegal. Also fixes a few style

[Qemu-devel] [Bug 696094] Re: TI Stellaris lm3s811evb (ARM Cortex-M3) : Systick interrupt not working

2010-12-31 Thread Frikkie Thirion
** Attachment added: "Project demonstrating that SysTick interrupt doesn't execute correctly." https://bugs.launchpad.net/bugs/696094/+attachment/1780598/+files/project.tar.bz2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

[Qemu-devel] [Bug 696094] [NEW] TI Stellaris lm3s811evb (ARM Cortex-M3) : Systick interrupt not working

2010-12-31 Thread Frikkie Thirion
Public bug reported: I've tried to create a small project that uses the CMSIS as base library. The problem is that the SysTick_interrupt_handler() doesn't get executed when the systick event is detected in QEMU. Furthermore, it seems asif QEMU gets stuck in an endless loop. QEMU doesn't respond

Re: [Qemu-devel] [PATCH] target-arm: fix UMAAL instruction

2010-12-31 Thread Peter Maydell
On 31 December 2010 19:11, Aurelien Jarno wrote: > UMAAL should use unsigned multiply instead of signed. Looks like we've both been working on the same thing this evening :-) > This patch fixes this issue by handling UMAAL separately from > UMULL/UMLAL/SMULL/SUMLAL are these instructions are dif

[Qemu-devel] [Bug 696015] Re: UMAAL should use unsigned multiply

2010-12-31 Thread Peter Maydell
Confirmed by checking the code against the ARM ARM that this is a good fix, and tested by the usual random instruction sequence generation for UMAAL/UMULL/UMLAL/SMULL/SMLAL. Reviewed-by: Peter Maydell If you could provide your patch with a Signed-off-by: line (see http://wiki.qemu.org/Contribute

Re: [Qemu-devel] [PATCH] TCG: Improve tb_phys_hash_func()

2010-12-31 Thread Aurelien Jarno
On Fri, Dec 31, 2010 at 08:46:02PM +0100, Aurelien Jarno wrote: > On Thu, Dec 30, 2010 at 05:55:38PM +, Blue Swirl wrote: > > On Wed, Dec 29, 2010 at 9:27 PM, Aurelien Jarno > > wrote: > > > Most of emulated CPU have instructions aligned on 16 or 32 bits, while > > > on others GCC tries to al

Re: [Qemu-devel] [PATCH] TCG: Improve tb_phys_hash_func()

2010-12-31 Thread Aurelien Jarno
On Thu, Dec 30, 2010 at 05:55:38PM +, Blue Swirl wrote: > On Wed, Dec 29, 2010 at 9:27 PM, Aurelien Jarno wrote: > > Most of emulated CPU have instructions aligned on 16 or 32 bits, while > > on others GCC tries to align the target jump location. This means that > > 1/2 or 3/4 of tb_phys_hash

[Qemu-devel] [PATCH] cirrus_vga: fix division by 0 for color expansion rop

2010-12-31 Thread Aurelien Jarno
Commit d85d0d3883f5a567fa2969a0396e42e0a662b3fa introduces a regression with Windows ME that leads to a division by 0 and a crash. It uses the color expansion rop with the source pitch set to 0. This is something allowed, as the manual explicitely says "When the source of color-expand data is disp

Re: [Qemu-devel] [PATCH] Fix curses on big endian hosts

2010-12-31 Thread Aurelien Jarno
On Thu, Dec 30, 2010 at 05:42:43PM +, Blue Swirl wrote: > On Wed, Dec 29, 2010 at 9:27 PM, Aurelien Jarno wrote: > > On big endian hosts, the curses interface is unusable: the emulated > > graphic card only displays garbage, while the monitor interface displays > > nothing (or rather only spac

[Qemu-devel] [PATCH] target-arm: fix UMAAL instruction

2010-12-31 Thread Aurelien Jarno
UMAAL should use unsigned multiply instead of signed. This patch fixes this issue by handling UMAAL separately from UMULL/UMLAL/SMULL/SUMLAL are these instructions are different enough. It also explicitely list instructions in case and catch inexistant instruction as illegal. Also fixes a few styl

[Qemu-devel] [Bug 696015] Re: UMAAL should use unsigned multiply

2010-12-31 Thread Anna Muravieva
** Patch added: "Fix for bug" https://bugs.launchpad.net/qemu/+bug/696015/+attachment/1780347/+files/arm_umaal.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/696015 Title: UMAAL should us

[Qemu-devel] [Bug 696015] [NEW] UMAAL should use unsigned multiply

2010-12-31 Thread Anna Muravieva
Public bug reported: ARM UMAAL should use unsigned multiply ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/696015 Title: UMAAL shou

[Qemu-devel] Re: [GIT PULL] kvm upstream updates

2010-12-31 Thread Jan Kiszka
Am 29.12.2010 16:42, Avi Kivity wrote: > On 12/29/2010 05:05 PM, Jan Kiszka wrote: >> Am 28.12.2010 11:36, Avi Kivity wrote: >> > The following changes since commit >> > 4cdc1cd137e0b98766916a7cdf2d5a9b3c6632fa: >> > >> >target-mips: fix host CPU consumption when guest is idle (2010-12-27 >>

[Qemu-devel] [PATCH] kvm: x86: Fix xcr0 reset mismerge

2010-12-31 Thread Jan Kiszka
From: Jan Kiszka For unknown reset, xcr0 reset ended up in kvm_arch_update_guest_debug on upstream merge. Fix this and also remove the misleading comment (1 is THE reset value). Signed-off-by: Jan Kiszka --- target-i386/kvm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff -

[Qemu-devel] [PATCH] kvm: x86: Remove redundant mp_state initialization

2010-12-31 Thread Jan Kiszka
From: Jan Kiszka kvm_arch_reset_vcpu initializes mp_state, and that function is invoked right after kvm_arch_init_vcpu. Signed-off-by: Jan Kiszka --- target-i386/kvm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 32310fa.

[Qemu-devel] [PATCH 4/5] kvm: Eliminate KVMState arguments

2010-12-31 Thread Jan Kiszka
From: Jan Kiszka QEMU supports only one VM, so there is only one kvm_state per process, and we gain nothing passing a reference to it around. Eliminate any need to refer to it outside of kvm-all.c. Signed-off-by: Jan Kiszka --- cpu-defs.h|2 - kvm-all.c | 233 +

[Qemu-devel] [PATCH 5/5] kvm: x86: Introduce kvmclock device to save/restore its state

2010-12-31 Thread Jan Kiszka
From: Jan Kiszka If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel state on migration, but this will also allow to visualize it one day. Signed-off-by: Jan Kiszka CC: Glauber Costa --- targ

[Qemu-devel] [PATCH 1/5] kvm: x86: Refactor msr_star/hsave_pa setup and checks

2010-12-31 Thread Jan Kiszka
From: Jan Kiszka Simplify kvm_has_msr_star/hsave_pa to booleans and push their one-time initialization into kvm_arch_init. Also handle potential errors of that setup procedure. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 47 +++ 1 files chang

[Qemu-devel] [PATCH 2/5] kvm: x86: Reset paravirtual MSRs

2010-12-31 Thread Jan Kiszka
From: Jan Kiszka Make sure to clear MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK, and MSR_KVM_ASYNC_PF_EN so that a freshly booted guest cannot be disturbed by old values. Signed-off-by: Jan Kiszka CC: Glauber Costa --- target-i386/kvm.c | 10 ++ 1 files changed, 10 insertions(+), 0 dele

[Qemu-devel] [PATCH 3/5] kvm: x86: Drop MCE MSRs write back restrictions

2010-12-31 Thread Jan Kiszka
From: Jan Kiszka There is no need to restrict writing back MCE MSRs to reset or full state updates as setting their values has no side effects. Signed-off-by: Jan Kiszka CC: Huang Ying --- target-i386/kvm.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/ta

[Qemu-devel] [PATCH 0/5] [uq/master] MSR refactorings, KVMState elimination, kvmclock device

2010-12-31 Thread Jan Kiszka
More refactorings of upstream KVM to allow further unifications with qemu-kvm. See patches for details. Jan Kiszka (5): kvm: x86: Refactor msr_star/hsave_pa setup and checks kvm: x86: Reset paravirtual MSRs kvm: x86: Drop MCE MSRs write back restrictions kvm: Eliminate KVMState arguments

[Qemu-devel] Re: [RFC 2/2] KVM, MCE, unpoison memory address across reboot

2010-12-31 Thread Jan Kiszka
Am 31.12.2010 06:22, Huang Ying wrote: > In Linux kernel HWPoison processing implementation, the virtual > address in processes mapping the error physical memory page is marked > as HWPoison. So that, the further accessing to the virtual > address will kill corresponding processes with SIGBUS. >