Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Paolo Bonzini
On 01/10/2011 11:21 PM, Jan Kiszka wrote: Am 10.01.2011 22:06, Jan Kiszka wrote: kvmclock should be created with kvm_state as a parameter and kvm_vm_ioctl() is passed the stored reference. Taking a global reference to kvm_state in machine_init is not a bad thing, obviously the machine initia

Re: [Qemu-devel] Re: phys_page_find bug?

2011-01-10 Thread Bob Breuer
Blue Swirl wrote: > On Mon, Jan 10, 2011 at 3:57 AM, Bob Breuer wrote: > >> Blue Swirl wrote: >> >>> On Mon, Nov 8, 2010 at 6:55 PM, Artyom Tarasenko >>> wrote: >>> >>> On Fri, May 7, 2010 at 6:26 PM, Artyom Tarasenko wrote: > phys_page_find (exec

Re: [Qemu-devel] [PATCH 3/3] target-ppc: fix sNaN propagation

2011-01-10 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 06:14:18PM -0600, Peter Maydell wrote: > On 2 January 2011 08:39, Aurelien Jarno wrote: > > The current FPU code returns 0.0 if one of the operand is a > > signaling NaN and the VXSNAN exception is disabled. > > > > fload_invalid_op_excp() doesn't return a qNaN in case of a

Re: [Qemu-devel] [PATCH 1/4] softfloat: Add float32_is_zero_or_denormal() function

2011-01-10 Thread Aurelien Jarno
On Fri, Jan 07, 2011 at 09:26:24AM +, Peter Maydell wrote: > Add a utility function to softfloat to test whether a float32 > is zero or denormal. > > Signed-off-by: Peter Maydell > --- > fpu/softfloat.h |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) Reviewed-by: Aurelien J

Re: [Qemu-devel] [PATCH 2/4] target-arm: Fix implementation of VRSQRTS

2011-01-10 Thread Aurelien Jarno
On Fri, Jan 07, 2011 at 09:26:25AM +, Peter Maydell wrote: > The implementation of the ARM VRSQRTS instruction (which calculates > (3 - op1 * op2) / 2) was missing the division operation. It also > did not handle the special cases of (0,inf) and (inf,0). > > Signed-off-by: Peter Maydell > ---

RE: [Qemu-devel] Re: [PATCH] audio: split sample conversion and volumemixing

2011-01-10 Thread Schildbach, Wolfgang
The fixed point path for scaling in mixeng_volume() seems to be under by a factor of two, IMHO. The right shift should be by 31, not 32. (Because the volume, which I assume is a signed 32 bit integer, can be 0.5 at most). Does the code work with FLOAT_MIXENG undefined? - Wolfgang Schildbach ---

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Jan Kiszka
Am 11.01.2011 00:04, Anthony Liguori wrote: >>> kvmclock should be created with >>> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored >>> reference. Taking a global reference to kvm_state in machine_init is >>> not a bad thing, obviously the machine initialization function needs

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Jan Kiszka
Am 11.01.2011 00:02, Anthony Liguori wrote: > On 01/10/2011 04:21 PM, Jan Kiszka wrote: >> Am 10.01.2011 22:06, Jan Kiszka wrote: >> kvmclock should be created with kvm_state as a parameter and kvm_vm_ioctl() is passed the stored reference. Taking a global reference to kvm_sta

Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation

2011-01-10 Thread Amit Shah
On (Mon) Jan 10 2011 [18:01:58], Chris Krumme wrote: > On 01/10/2011 08:31 AM, Markus Armbruster wrote: > >Amit Shah writes: > > > >[...] > >>diff --git a/hw/qdev.c b/hw/qdev.c > >>index 6fc9b02..168d0f6 100644 > >>--- a/hw/qdev.c > >>+++ b/hw/qdev.c > >>@@ -185,7 +185,8 @@ int qdev_device_help(Qe

[Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-10 Thread Richard Henderson
Special case deposits that are implementable with byte and word stores. Otherwise implement with double-word shift plus rotates. Expose tcg_scratch_alloc to the backend for allocation of scratch registers. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 67 +++

[Qemu-devel] [PATCH 3/7] tcg-hppa: Implement deposit operation.

2011-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/hppa/tcg-target.c | 58 +++- tcg/hppa/tcg-target.h |1 + 2 files changed, 53 insertions(+), 6 deletions(-) diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c index 7f4653e..a572cbf 100644 --- a/tcg

[Qemu-devel] [PATCH 4/7] tcg-ia64: Implement deposit operation.

2011-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.c | 115 + tcg/ia64/tcg-target.h |2 + 2 files changed, 117 insertions(+), 0 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index e2e44f7..5d19a61 100644 --- a/t

[Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional operation.

2011-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/README| 14 tcg/tcg-op.h | 64 + tcg/tcg-opc.h |6 + 3 files changed, 84 insertions(+), 0 deletions(-) diff --git a/tcg/README b/tcg/README index a18a87f..a50ecc6 100644

[Qemu-devel] [PATCH 6/7] target-i386: Use deposit operation.

2011-01-10 Thread Richard Henderson
Use this for assignment to the low byte or low word of a register. Signed-off-by: Richard Henderson --- target-i386/translate.c | 34 ++ 1 files changed, 6 insertions(+), 28 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 7b6e3

[Qemu-devel] Does qemu support cortex a8 and cortex a9 now?

2011-01-10 Thread Fan Chongbin-B32609
Hi, guys Does qemu support cortex a8 and cortex a9 now? If not, is there any plan for them? BR Jerry

[Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2

2011-01-10 Thread Richard Henderson
Changes since v1: * No attempt to pack pos+len into one operand. Updated backends to match this change. * Example in the README is a bit more complex. * Define an official tcg_scratch_alloc routine, used by the i386 target for the case in which we need a scratch register. I had

[Qemu-devel] [PATCH 2/7] tcg-ppc: Implement deposit operation.

2011-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 17 - tcg/ppc/tcg-target.h |1 + 2 files changed, 17 insertions(+), 1 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 7970268..39aa4f1 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg

[Qemu-devel] [PATCH 7/7] target-ppc: Use deposit operation.

2011-01-10 Thread Richard Henderson
Use this in implementing rl[wd]imi, at least for the cases that don't require true rotation. Signed-off-by: Richard Henderson --- target-ppc/translate.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 74e06d

Re: [Qemu-devel] [PATCH 3/3] target-ppc: fix sNaN propagation

2011-01-10 Thread Peter Maydell
On 2 January 2011 08:39, Aurelien Jarno wrote: > The current FPU code returns 0.0 if one of the operand is a > signaling NaN and the VXSNAN exception is disabled. > > fload_invalid_op_excp() doesn't return a qNaN in case of a VXSNAN > exception as the operand should be propagated instead of a new

Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation

2011-01-10 Thread Chris Krumme
On 01/10/2011 08:31 AM, Markus Armbruster wrote: Amit Shah writes: [...] diff --git a/hw/qdev.c b/hw/qdev.c index 6fc9b02..168d0f6 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -185,7 +185,8 @@ int qdev_device_help(QemuOpts *opts) if (!prop->info->parse) { continue;

[Qemu-devel] [PATCH 2/4] target-arm: Refactor translation of exception generating instructions

2011-01-10 Thread Peter Maydell
Create a new function which does the common sequence of gen_set_condexec, gen_set_pc_im, gen_exception, set is_jmp to DISAS_JUMP. Signed-off-by: Peter Maydell --- target-arm/translate.c | 43 +++ 1 files changed, 15 insertions(+), 28 deletions(-) diff -

[Qemu-devel] [PATCH 0/4] target-arm: get IT bits right at exceptions

2011-01-10 Thread Peter Maydell
This patchset (when combined with my previous patchset "Translate based on TB flags, not CPUState") is a fix for https://bugs.launchpad.net/qemu/+bug/581335 where we were not getting the IT (conditional execution) bits in the CPSR right when we took an unexpected exception in Thumb mode. The linux

[Qemu-devel] [PATCH 1/4] target-arm: Remove redundant setting of IT bits before Thumb SWI

2011-01-10 Thread Peter Maydell
Remove a redundant call to gen_set_condexec() in the translation of Thumb mode SWI. (SWI and WFI generate "exceptions" which happen after the execution of the instruction, ie when PC and IT bits have updated. So the condexec bits at this point are not correct. However, the code that handles finishi

[Qemu-devel] [PATCH 3/4] linux-user: ARM: clear the IT bits when invoking a signal handler

2011-01-10 Thread Peter Maydell
When invoking a signal handler for an ARM target, make sure the IT bits in the CPSR are cleared. (This would otherwise cause incorrect execution if the IT state was non-zero when an exception occured. This bug has been masked previously because we weren't getting the IT state bits at exception entr

[Qemu-devel] [PATCH 4/4] target-arm: Restore IT bits when resuming after an exception

2011-01-10 Thread Peter Maydell
We were not correctly restoring the IT bits when resuming execution after taking an unexpected exception in the middle of an IT block. Fix this by tracking them along with PC changes and restoring in gen_pc_load(). This fixes bug https://bugs.launchpad.net/qemu/+bug/581335 Signed-off-by: Peter Ma

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Anthony Liguori
On 01/10/2011 03:06 PM, Jan Kiszka wrote: Am 10.01.2011 21:31, Anthony Liguori wrote: On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: From: Jan Kiszka If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Anthony Liguori
On 01/10/2011 04:21 PM, Jan Kiszka wrote: Am 10.01.2011 22:06, Jan Kiszka wrote: kvmclock should be created with kvm_state as a parameter and kvm_vm_ioctl() is passed the stored reference. Taking a global reference to kvm_state in machine_init is not a bad thing, obviously the machine in

[Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8

2011-01-10 Thread digit
From: David 'Digit' Turner Signed-off-by: David 'Digit' Turner --- hw/qdev-properties.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 9219cd7..d5d9591 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -5

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-10 Thread Stefan Weil
Am 10.01.2011 18:59, schrieb Mateusz Loskot: On 10/01/11 17:08, Stefan Weil wrote: Am 10.01.2011 12:19, schrieb Mateusz Loskot: On 07/01/11 18:15, Stefan Weil wrote: There are no precompiled windows binaries of current qemu, so you will have to compile them yourself (which is not difficult onc

Re: [Qemu-devel] [PATCH 6/7] lan9118: fix a buffer overflow

2011-01-10 Thread Peter Maydell
On 10 January 2011 15:50, Blue Swirl wrote: > On Mon, Jan 10, 2011 at 12:45 PM, Markus Armbruster wrote: >> Covers all the obvious accesses except for a couple of s->eeprom[addr] >> in lan9118_eeprom_cmd().  addr is a parameter there, and the actual >> argument is val & 0xff, in lan9118_writel().

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Jan Kiszka
Am 10.01.2011 22:06, Jan Kiszka wrote: >> kvmclock should be created with >> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored >> reference. Taking a global reference to kvm_state in machine_init is >> not a bad thing, obviously the machine initialization function needs >> access

Re: [Qemu-devel] [PATCH] qemu-img snapshot: Use writeback caching

2011-01-10 Thread Stefan Hajnoczi
On Mon, Jan 10, 2011 at 4:54 PM, Kevin Wolf wrote: > None of the other qemu-img subcommands uses writethrough, and there's no > reason > why snapshot should be special. > > Signed-off-by: Kevin Wolf > --- >  qemu-img.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: S

Re: [Qemu-devel] [PATCH 0/5] usb-ccid (v14)

2011-01-10 Thread Blue Swirl
On Mon, Jan 10, 2011 at 2:32 PM, Alon Levy wrote: > On Mon, Jan 10, 2011 at 01:44:32PM +0100, Gerd Hoffmann wrote: >> On 01/08/11 11:28, Alon Levy wrote: >> >This patchset adds three new devices, usb-ccid, ccid-card-passthru and >> >ccid-card-emulated, providing a CCID bus, a simple passthru proto

[Qemu-devel] Re: [PATCH] linux-user: Add configure check for linux/fiemap.h and IOC_FS_FIEMAP

2011-01-10 Thread Blue Swirl
On Mon, Jan 10, 2011 at 1:11 PM, Peter Maydell wrote: > Add a configure check for the existence of linux/fiemap.h and the > IOC_FS_FIEMAP ioctl. This fixes a compilation failure on Linux > systems which don't have that header file. Looks OK.

[Qemu-devel] [PATCH] slirp/tftp.c: fix mode field

2011-01-10 Thread Sergei Gavrikov
Hi, According to RFC 1350 http://www.ietf.org/rfc/rfc1350.txt [Page 5]: The mode field contains the string "netascii", "octet", or "mail" (or any combination of upper and lower case, such as "NETASCII", NetAscii", etc.) Unfortunately, current implementation of internal TFTP server br

Re: [Qemu-devel] [PATCH 6/7] lan9118: fix a buffer overflow

2011-01-10 Thread Blue Swirl
On Mon, Jan 10, 2011 at 12:45 PM, Markus Armbruster wrote: > Blue Swirl writes: > >> Fix a buffer overflow, reported by cppcheck: >> [/src/qemu/hw/lan9118.c:849]: (error) Buffer access out-of-bounds: s.eeprom >> >> All eeprom handling code assumes that the size of eeprom is 128. >> >> Signed-off-

[Qemu-devel] Re: [PATCH] cris: remove a write-only variable

2011-01-10 Thread Blue Swirl
On Mon, Jan 10, 2011 at 9:06 AM, Edgar E. Iglesias wrote: > On Sun, Jan 09, 2011 at 04:56:59PM +, Blue Swirl wrote: >> Avoid a warning with GCC 4.6.0: >> /src/qemu/target-cris/translate.c: In function >> 'gen_intermediate_code_internal': >> /src/qemu/target-cris/translate.c:3185:25: error: va

Re: [Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-10 Thread Peter Maydell
On 10 January 2011 07:45, Stefan Hajnoczi wrote: > On Mon, Jan 10, 2011 at 1:05 PM, Jes Sorensen wrote: >> Just to add a bit more background. Last year we discussed the issue of >> whether to aim for a KVM Forum in the same style as we had in 2010, or >> whether to try to aim for a broader multi-

Re: [Qemu-devel] Re: phys_page_find bug?

2011-01-10 Thread Blue Swirl
On Mon, Jan 10, 2011 at 3:57 AM, Bob Breuer wrote: > Blue Swirl wrote: >> On Mon, Nov 8, 2010 at 6:55 PM, Artyom Tarasenko wrote: >> >>> On Fri, May 7, 2010 at 6:26 PM, Artyom Tarasenko >>> wrote: >>> phys_page_find (exec.c) returns sometimes a page for addresses where nothing is conne

[Qemu-devel] Re: [patch 2/2] acpi_piix4: expose no_hotplug attribute via i/o port

2011-01-10 Thread Michael S. Tsirkin
On Mon, Jan 10, 2011 at 04:55:03PM -0200, Marcelo Tosatti wrote: > Expose no_hotplug attribute via I/O port, so ACPI BIOS can indicate > removability status to guest OS. > > An updated seabios is required to make use of this feature (seabios.git > commit ID 3c241edf3d7ef29c21). > > Signed-off-by:

[Qemu-devel] Re: [PATCH v4] savevm: Fix no_migrate

2011-01-10 Thread Michael S. Tsirkin
On Mon, Jan 10, 2011 at 10:47:58AM -0700, Alex Williamson wrote: > On Sun, 2011-01-09 at 12:47 +0200, Michael S. Tsirkin wrote: > > On Fri, Jan 07, 2011 at 03:13:25PM -0700, Alex Williamson wrote: > > > The no_migrate save state flag is currently only checked in the > > > last phase of migration.

Re: [Qemu-devel] [PATCH] linux-user: fix for loopmount ioctl

2011-01-10 Thread Riku Voipio
On Mon, Jan 10, 2011 at 05:18:43PM +0100, Martin Mohring wrote: > On 01/09/2011 12:25 AM, Martin Mohring wrote: > > Hi, > > > > I had fixed the loopmount ioctl for linux-user, working correctly for arm, > > mips, ppc32 and sh4. > ping > Aurelien, Riku, is that patch ok? Its only 2 lines of change

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Jan Kiszka
Am 10.01.2011 21:31, Anthony Liguori wrote: > On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: >> From: Jan Kiszka >> >> If kvmclock is used, which implies the kernel supports it, register a >> kvmclock device with the sysbus. Its main purpose is to save and restore >> the kernel state on migration,

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-10 Thread Artyom Tarasenko
On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskot wrote: >> I suggest using QEMU git master. You could try the binaries >> from my website: http://www.weilnetz.de/qemu/ > > Stefan, > > Thank you very much! > So far, I have tried to use versions of QEMU from Qemu Manager 0.7 > as well as QEMU 0.13 fr

[Qemu-devel] Re: [PATCH] audio: split sample conversion and volume mixing

2011-01-10 Thread Jan Kiszka
Am 10.01.2011 21:52, malc wrote: > On Mon, 10 Jan 2011, Jan Kiszka wrote: > >> Am 05.01.2011 01:05, Michael Walle wrote: >>> Refactor the volume mixing, so it can be reused for capturing devices. >>> Additionally, it removes superfluous multiplications with the nominal >>> volume within the hardwa

[Qemu-devel] Re: [PATCH] audio: split sample conversion and volume mixing

2011-01-10 Thread malc
On Mon, 10 Jan 2011, Jan Kiszka wrote: > Am 05.01.2011 01:05, Michael Walle wrote: > > Refactor the volume mixing, so it can be reused for capturing devices. > > Additionally, it removes superfluous multiplications with the nominal > > volume within the hardware voice code path. > > At least base

[Qemu-devel] Re: [PATCH] audio: split sample conversion and volume mixing

2011-01-10 Thread Jan Kiszka
Am 05.01.2011 01:05, Michael Walle wrote: > Refactor the volume mixing, so it can be reused for capturing devices. > Additionally, it removes superfluous multiplications with the nominal > volume within the hardware voice code path. At least based on tests done with the Musicpal, I see problems wi

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-10 Thread Jan Kiszka
Am 10.01.2011 21:23, Anthony Liguori wrote: > On 01/10/2011 02:12 PM, Jan Kiszka wrote: >> Am 10.01.2011 20:59, Anthony Liguori wrote: >> >>> On 01/08/2011 02:47 AM, Jan Kiszka wrote: >>> Am 08.01.2011 00:27, Anthony Liguori wrote: > On 01/07/2011 03:03 AM, Jan Kis

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-10 Thread Anthony Liguori
On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: From: Jan Kiszka If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel state on migration, but this will also allow to visualize it one day. Signed-

Re: [Qemu-devel] Re: [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-10 Thread Richard Henderson
On 01/10/2011 10:37 AM, Aurelien Jarno wrote: >> mov y,x >> deposit y,y,x,8,8 >> >> So I could simply put a tcg_abort there. It would be up to whoever >> improves the register allocator to provide some mechanism for a >> backend to allocate a scratch. What do you think? >> > > Do y

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-10 Thread Anthony Liguori
On 01/10/2011 02:12 PM, Jan Kiszka wrote: Am 10.01.2011 20:59, Anthony Liguori wrote: On 01/08/2011 02:47 AM, Jan Kiszka wrote: Am 08.01.2011 00:27, Anthony Liguori wrote: On 01/07/2011 03:03 AM, Jan Kiszka wrote: Am 06.01.2011 20:24, Anthony Liguori wrote:

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-10 Thread Jan Kiszka
Am 10.01.2011 21:11, Anthony Liguori wrote: > On 01/08/2011 02:47 AM, Jan Kiszka wrote: >> OK, but I don't want to argue about the ioeventfd API. So let's put this >> case aside. :) >> > > I often reply too quickly without explaining myself. Let me use > ioeventfd as an example to highlight w

[Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-10 Thread Jan Kiszka
Am 10.01.2011 20:59, Anthony Liguori wrote: > On 01/08/2011 02:47 AM, Jan Kiszka wrote: >> Am 08.01.2011 00:27, Anthony Liguori wrote: >> >>> On 01/07/2011 03:03 AM, Jan Kiszka wrote: >>> Am 06.01.2011 20:24, Anthony Liguori wrote: > On 01/06/2011 11:56 AM, Marcelo

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-10 Thread Anthony Liguori
On 01/08/2011 02:47 AM, Jan Kiszka wrote: OK, but I don't want to argue about the ioeventfd API. So let's put this case aside. :) I often reply too quickly without explaining myself. Let me use ioeventfd as an example to highlight why KVMState is a good thing. In real life, PIO and MMIO

[Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-10 Thread Anthony Liguori
On 01/08/2011 02:47 AM, Jan Kiszka wrote: Am 08.01.2011 00:27, Anthony Liguori wrote: On 01/07/2011 03:03 AM, Jan Kiszka wrote: Am 06.01.2011 20:24, Anthony Liguori wrote: On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: From: Jan Kiszka QEMU supports only one VM,

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread Richard Henderson
On 01/10/2011 09:34 AM, Aurelien Jarno wrote: > +HPPA target > +M: qemu-devel@nongnu.org > +S: Orphan > +F: tcg/hppa/ I'm willing to maintain this target, since I re-wrote most of it. Otherwise, Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-10 Thread Daniel P. Berrange
On Mon, Jan 10, 2011 at 09:26:12PM +0200, Alon Levy wrote: > On Mon, Jan 10, 2011 at 05:37:18PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > >>I like client_migrate_info and it fits both spice+vnc naming too. > > >> > > >>Given that vnc just needs hostname and port (which are present > > >>alread

[Qemu-devel] Re: [PATCH 3/3] target-ppc: fix sNaN propagation

2011-01-10 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 06:20:07PM +0100, Alexander Graf wrote: > > On 02.01.2011, at 15:39, Aurelien Jarno wrote: > > > The current FPU code returns 0.0 if one of the operand is a > > signaling NaN and the VXSNAN exception is disabled. > > > > fload_invalid_op_excp() doesn't return a qNaN in ca

[Qemu-devel] Re: [PATCH] tcg arm/mips/ia64: add a comment about retranslation and caches

2011-01-10 Thread Edgar E. Iglesias
On Mon, Jan 10, 2011 at 06:34:42PM +0100, Aurelien Jarno wrote: > Add a comment about cache coherency and retranslation, so that people > developping new targets based on existing ones are warned of the issue. > > Cc: Alexander Graf > Cc: Edgar E. Iglesias > Signed-off-by: Aurelien Jarno Looks

Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-10 Thread Alon Levy
On Mon, Jan 10, 2011 at 05:37:18PM +0100, Gerd Hoffmann wrote: > Hi, > > >>I like client_migrate_info and it fits both spice+vnc naming too. > >> > >>Given that vnc just needs hostname and port (which are present > >>already) and the arguments not used by vnc are optional all we need > >>to do i

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:21:15AM -0800, Richard Henderson wrote: > On 01/10/2011 09:34 AM, Aurelien Jarno wrote: > > +HPPA target > > +M: qemu-devel@nongnu.org > > +S: Orphan > > +F: tcg/hppa/ > > I'm willing to maintain this target, since I re-wrote most of it. > Otherwise, > Ok, that will be

Re: [Qemu-devel] [PATCH 4/4] target-arm: Use the standard FPSCR value for VRSQRTS

2011-01-10 Thread Aurelien Jarno
On Fri, Jan 07, 2011 at 09:26:27AM +, Peter Maydell wrote: > VSQRTS always uses the standard FPSCR value as it is a Neon instruction. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Aurelien Jarno > d

Re: [Qemu-devel] [PATCH 3/4] target-arm: Add support for 'Standard FPSCR Value' as used by Neon

2011-01-10 Thread Aurelien Jarno
On Fri, Jan 07, 2011 at 09:26:26AM +, Peter Maydell wrote: > Add support to the ARM helper routines for a second fp_status value > which should be used for operations which the ARM ARM indicates use > "ARM standard floating-point arithmetic" rather than being controlled > by the rounding/flush/

[Qemu-devel] [patch 2/2] acpi_piix4: expose no_hotplug attribute via i/o port

2011-01-10 Thread Marcelo Tosatti
Expose no_hotplug attribute via I/O port, so ACPI BIOS can indicate removability status to guest OS. An updated seabios is required to make use of this feature (seabios.git commit ID 3c241edf3d7ef29c21). Signed-off-by: Marcelo Tosatti Tested-by: Gleb Natapov Index: qemu/hw/acpi_piix4.c ===

[Qemu-devel] [patch 1/2] document QEMU<->ACPIBIOS PCI hotplug interface

2011-01-10 Thread Marcelo Tosatti
Document how QEMU communicates with ACPI BIOS for PCI hotplug. Signed-off-by: Marcelo Tosatti Index: qemu/docs/specs/acpi_pci_hotplug.txt === --- /dev/null +++ qemu/docs/specs/acpi_pci_hotplug.txt @@ -0,0 +1,39 @@ +QEMU<->ACPI BIOS

[Qemu-devel] [patch 0/2] [pci branch] configure pci slot removability through ACPI

2011-01-10 Thread Marcelo Tosatti
Indicate PCI removability through ACPI _RMV method, so that Windows guests does not expose non-hotpluggable PCI devices as "hot removable". Michael, please apply the newest no hotplug attribute patchset from Gerd before applying this.

Re: [Qemu-devel] [Bug 544527] Re: usbfs is bugged with >2.6.32.9 and <=2.6.33 (breaks VMWare, Qemu, sane scanners, ...)

2011-01-10 Thread Aurelien Jarno
Can we configure launchpad to not receive such an email? We don't really care about kernel bugs in Ubuntu, even if they affect QEMU. On Mon, Jan 10, 2011 at 06:17:13PM -, Jeremy Foshee wrote: > ** Changed in: linux (Ubuntu) >Status: Fix Committed => Fix Released > > -- > You received

Re: [Qemu-devel] Re: [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-10 Thread Aurelien Jarno
On Sun, Jan 09, 2011 at 02:55:13PM -0800, Richard Henderson wrote: > On 01/09/2011 01:53 PM, Aurelien Jarno wrote: > >> +if (inout == val) { > >> +TCGType type = rexw ? TCG_TYPE_I64 : TCG_TYPE_I32; > >> +TCGRegSet inuse = s->reserved_regs; > >> + > >> +tcg_regset_set_reg

[Qemu-devel] [Bug 544527] Re: usbfs is bugged with >2.6.32.9 and <=2.6.33 (breaks VMWare, Qemu, sane scanners, ...)

2011-01-10 Thread Jeremy Foshee
** Changed in: linux (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/544527 Title: usbfs is bugged with >2.6.32.9 and <=2.6.33 (breaks VMWare, Qe

Re: [Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 07:01:47PM +0100, andrzej zaborowski wrote: > On 10 January 2011 18:46, Alexander Graf wrote: > > > > On 10.01.2011, at 18:34, Aurelien Jarno wrote: > > > >> Cc: Andrzej Zaborowski > > > > ^- That email address always bounces for me. Are you sure it's still valid? > > It

Re: [Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread andrzej zaborowski
On 10 January 2011 18:46, Alexander Graf wrote: > > On 10.01.2011, at 18:34, Aurelien Jarno wrote: > >> Cc: Andrzej Zaborowski > > ^- That email address always bounces for me. Are you sure it's still valid? It is outdated, please use or alternatively just the mailling list. Cheers

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-10 Thread Mateusz Loskot
On 10/01/11 17:08, Stefan Weil wrote: Am 10.01.2011 12:19, schrieb Mateusz Loskot: On 07/01/11 18:15, Stefan Weil wrote: There are no precompiled windows binaries of current qemu, so you will have to compile them yourself (which is not difficult once you have the correct mingw environment). G

[Qemu-devel] Re: [PATCH] tcg arm/mips/ia64: add a comment about retranslation and caches

2011-01-10 Thread Alexander Graf
On 10.01.2011, at 18:34, Aurelien Jarno wrote: > Add a comment about cache coherency and retranslation, so that people > developping new targets based on existing ones are warned of the issue. > > Cc: Alexander Graf > Cc: Edgar E. Iglesias > Signed-off-by: Aurelien Jarno Thanks :) Acked-by

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread Alexander Graf
On 10.01.2011, at 18:34, Aurelien Jarno wrote: > Cc: Andrzej Zaborowski ^- That email address always bounces for me. Are you sure it's still valid? Alex

[Qemu-devel] Re: [PATCH v4] savevm: Fix no_migrate

2011-01-10 Thread Alex Williamson
On Sun, 2011-01-09 at 12:47 +0200, Michael S. Tsirkin wrote: > On Fri, Jan 07, 2011 at 03:13:25PM -0700, Alex Williamson wrote: > > The no_migrate save state flag is currently only checked in the > > last phase of migration. This means that we potentially waste > > a lot of time and bandwidth with

[Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread Alexander Graf
On 10.01.2011, at 18:34, Aurelien Jarno wrote: > The MAINTAINERS file was lacking entries concerning the TCG code, add > them based on the git history. > > For the common TCG code, is probably better to keep qemu-de...@non-gnu.org > as this code can break easily, so it's better to get it reviewe

[Qemu-devel] [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread Aurelien Jarno
The MAINTAINERS file was lacking entries concerning the TCG code, add them based on the git history. For the common TCG code, is probably better to keep qemu-de...@non-gnu.org as this code can break easily, so it's better to get it reviewed by a few persons. v1 -> v2: - Changed i386 as maintained

[Qemu-devel] [PATCH] tcg arm/mips/ia64: add a comment about retranslation and caches

2011-01-10 Thread Aurelien Jarno
Add a comment about cache coherency and retranslation, so that people developping new targets based on existing ones are warned of the issue. Cc: Alexander Graf Cc: Edgar E. Iglesias Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |3 +++ tcg/ia64/tcg-target.c |3 +++ tcg/mips/

[Qemu-devel] [PATCH 2/3] MAINTAINERS: Change MIPS and SH4 maintainers

2011-01-10 Thread Aurelien Jarno
Since nobody else seems interested in maintaining MIPS and SH4 targets, and as I have done most of the recent code changes, let officialize that. Signed-off-by: Aurelien Jarno --- MAINTAINERS |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINER

[Qemu-devel] [PATCH 1/3] MAINTAINERS: fix typos

2011-01-10 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- MAINTAINERS |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 59effc7..98af4ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -202,7 +202,7 @@ M: Edgar E. Iglesias S: Maintained F: hw/etraxfs.c -M86K M

Re: [Qemu-devel] [PATCH] arm-dis: Include opcode hex when doing disassembly

2011-01-10 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:09:28AM -0600, Peter Maydell wrote: > On 10 January 2011 10:49, Aurelien Jarno wrote: > > Strangely on arm host, the opcode hex is already included, as shown > > below: > > > > | OUT: [size=308] > > | 0x01001ec0:  e5974004  ldr      r4, [r7, #4] > > | 0x01001ec4:  e1a048

Re: [Qemu-devel] [PATCH] arm-dis: Include opcode hex when doing disassembly

2011-01-10 Thread Peter Maydell
On 10 January 2011 10:49, Aurelien Jarno wrote: > Strangely on arm host, the opcode hex is already included, as shown > below: > > | OUT: [size=308] > | 0x01001ec0:  e5974004  ldr      r4, [r7, #4] > | 0x01001ec4:  e1a04804  lsl      r4, r4, #16 > | 0x01001ec8:  e1a04824  lsr      r4, r4, #16 > |

[Qemu-devel] [RFC][PATCH 1/2] qcow2: Add QcowCache

2011-01-10 Thread Kevin Wolf
This adds some new cache functions to qcow2 which can be used for caching refcount blocks and L2 tables. When used with cache=writethrough they work like the old caching code which is spread all over qcow2, so for this case we have merely a cleanup. The interesting case is with writeback caching (

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-10 Thread Stefan Weil
Am 10.01.2011 12:19, schrieb Mateusz Loskot: On 07/01/11 18:15, Stefan Weil wrote: Am 07.01.2011 18:28, schrieb Mateusz Loskot: Hi, First, I'm sorry if my question does not belong here. The qemu-devel says it's "devel", but I can't find any qemu-users mailing list. I have no experience with Q

Re: [Qemu-devel] [PULL] piix, pci, qdev

2011-01-10 Thread Anthony Liguori
On 12/27/2010 11:21 AM, Michael S. Tsirkin wrote: The sysbus change is already in master, but I didn't want to rebase the tree. I verified there's no conflict when merging. The only thing that might be controversial here is the bridge migration path, but the patch was out for pretty long without

[Qemu-devel] [PATCH] qemu-img snapshot: Use writeback caching

2011-01-10 Thread Kevin Wolf
None of the other qemu-img subcommands uses writethrough, and there's no reason why snapshot should be special. Signed-off-by: Kevin Wolf --- qemu-img.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index afd9ed2..1e65ea8 100644 --- a/qemu-img.

[Qemu-devel] [RFC][PATCH 0/2] qcow2 metadata cache

2011-01-10 Thread Kevin Wolf
block-queue turned out to be too big effort to be useful for quickly fixing the performance problems that qcow2 got since we introduced the metadata flushes. While I still think the idea is right, it needs more time and qcow2 doesn't have more time. Let's come back to block-queue later when the mos

[Qemu-devel] [RFC][PATCH 2/2] qcow2: Use QcowCache

2011-01-10 Thread Kevin Wolf
Use the new functions of qcow2-cache.c for everything that works on refcount block and L2 tables. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 206 ++-- block/qcow2-refcount.c | 249 +++- block/qcow2.c

Re: [Qemu-devel] Re: [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-10 Thread Aurelien Jarno
On Sun, Jan 09, 2011 at 04:43:22PM -0800, Richard Henderson wrote: > On 01/09/2011 04:16 PM, Aurelien Jarno wrote: > > The code being written now or latter doesn't change the question to know > > if it is always possible to allocate one scratch register here on i386. > > Yes. > > Here there's onl

Re: [Qemu-devel] [PATCH] arm-dis: Include opcode hex when doing disassembly

2011-01-10 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 04:16:26PM +, Peter Maydell wrote: > Enhance the ARM disassembler used for debugging so that it includes > the hex dump of the opcode as well as the symbolic disassembly. > > Signed-off-by: Peter Maydell > --- > This is based on meego-qemu commit e548a60c with a change

[Qemu-devel] [PATCH applied] virtio: move vmstate change tracking to core

2011-01-10 Thread Michael S. Tsirkin
Move tracking vmstate change from virtio-net to virtio.c as it is going to be used by virito-blk and virtio-pci for the ioeventfd support. Signed-off-by: Michael S. Tsirkin --- Just wanted to call attention to this patch which is part of the ioeventfd series (was part of a larger patch but I spl

Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-10 Thread Gerd Hoffmann
Hi, I like client_migrate_info and it fits both spice+vnc naming too. Given that vnc just needs hostname and port (which are present already) and the arguments not used by vnc are optional all we need to do is rename the command and add a "protocol" argument similar to "set_password", correct

[Qemu-devel] [PATCH] arm-dis: Include opcode hex when doing disassembly

2011-01-10 Thread Peter Maydell
Enhance the ARM disassembler used for debugging so that it includes the hex dump of the opcode as well as the symbolic disassembly. Signed-off-by: Peter Maydell --- This is based on meego-qemu commit e548a60c with a change suggested last time that patch was sent to qemu-devel: http://www.mail-arc

Re: [Qemu-devel] [PATCH] linux-user: fix for loopmount ioctl

2011-01-10 Thread Martin Mohring
On 01/09/2011 12:25 AM, Martin Mohring wrote: > Hi, > > I had fixed the loopmount ioctl for linux-user, working correctly for arm, > mips, ppc32 and sh4. > > Martin > > ping Aurelien, Riku, is that patch ok? Its only 2 lines of change to activate an ioctl.

Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-10 Thread Daniel P. Berrange
On Mon, Jan 10, 2011 at 05:08:40PM +0100, Gerd Hoffmann wrote: > On 01/10/11 16:57, Alon Levy wrote: > >>>+spice_migrate_info > >>>+-- > >>>+ > >>>+Set the spice connection info for the migration target. The spice > >>>+server will ask the spice client to automatically reconnect us

Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-10 Thread Gerd Hoffmann
On 01/10/11 16:57, Alon Levy wrote: +spice_migrate_info +-- + +Set the spice connection info for the migration target. The spice +server will ask the spice client to automatically reconnect using the +new parameters (if specified) once the vm migration finished +successfully. + +

Re: [Qemu-devel] KVM call agenda for Jan 11

2011-01-10 Thread Anthony Liguori
On 01/10/2011 04:17 AM, Juan Quintela wrote: Please send any agenda items you are interested in covering. - KVM Forum 2011 (Jes). - Spice guest agent (Alon) Regards, Anthony Liguori thanks, Juan.

Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-10 Thread Alon Levy
On Mon, Jan 10, 2011 at 03:49:34PM +, Daniel P. Berrange wrote: > On Mon, Jan 10, 2011 at 02:31:47PM +0100, Gerd Hoffmann wrote: > > Handle spice client migration, i.e. inform a spice client connected > > about the new host and connection parameters, so it can move over the > > connection autom

Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-10 Thread Daniel P. Berrange
On Mon, Jan 10, 2011 at 02:31:47PM +0100, Gerd Hoffmann wrote: > Handle spice client migration, i.e. inform a spice client connected > about the new host and connection parameters, so it can move over the > connection automatically. > > Signed-off-by: Gerd Hoffmann > --- > hmp-commands.hx | 20

Re: [Qemu-devel] Re: tcg/{ppc, s390, sparc}: branch target and code retranslation

2011-01-10 Thread Alexander Graf
On 10.01.2011, at 15:51, Edgar E. Iglesias wrote: > On Mon, Jan 10, 2011 at 03:20:40PM +0100, Alexander Graf wrote: >> >> On 10.01.2011, at 15:15, Aurelien Jarno wrote: >> >>> On Mon, Jan 10, 2011 at 03:07:52PM +0100, Alexander Graf wrote: On 10.01.2011, at 15:00, Aurelien Jarno wrot

  1   2   >