[Qemu-devel] RE: [PATCH] audio: split sample conversion and volumemixing

2011-01-12 Thread Schildbach, Wolfgang
Ah, I assumed that the volume would be stored in a 32 bit integer, and be represented as a signed Q31 fixed point. Sorry for the noise. - Wolfgang -Original Message- From: malc [mailto:av1...@comtv.ru] Sent: Wednesday, January 12, 2011 12:15 AM To: Michael Walle Cc: Schildbach,

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-12 Thread Gerd Hoffmann
Hi, Moving the handlers to a separate struct is clearly a incremental cleanup which can follow later. Using enable/disable flags will probably simplify the interfaces for the non-blocking mode and thus simplify the whole patch series so I think this should be done now. Agree -- but it

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Stefan Hajnoczi
On Wed, Jan 12, 2011 at 7:22 AM, Sergei Gavrikov sergei.gavri...@gmail.com wrote: diff --git a/slirp/tftp.c b/slirp/tftp.c index 55e4692..a455ad1 100644 --- a/slirp/tftp.c +++ b/slirp/tftp.c @@ -311,7 +311,7 @@ static void tftp_handle_rrq(Slirp *slirp, struct tftp_t *tp, int pktlen)    

[Qemu-devel] Re: [PATCH 2/2] xen: Introduce VGA sync dirty bitmap support

2011-01-12 Thread Jan Kiszka
Am 11.01.2011 16:37, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This patch introduces phys memory client for Xen. Only sync dirty_bitmap and set_memory are actually implemented. migration_log will stay empty for the moment. Xen can only log one range

[Qemu-devel] Re: [PULL v2 0/6] spice patch queue

2011-01-12 Thread Gerd Hoffmann
On 01/11/11 13:08, Gerd Hoffmann wrote: Hi, Here is a bunch of spice patches accumuled this year, they all have been on the list for review. [ v2: rewrite the spice client migration in a way that allows vnc to easily join the party later on ] please pull, Gerd Looks like

[Qemu-devel] forking with x86_64

2011-01-12 Thread maheen butt
hiwhy qemu does not provide NPTL support for x86 in user mode? is there any big hindrance behind it? I did a small experimentI make a program with fork system call and give its executable to qemu-x86_64 out put shows it does not create child. the I commented out this if block of

Re: [Qemu-devel] [PATCH 1/8] target-arm: Don't generate code specific to current CPU mode for SRS

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:11PM +, Peter Maydell wrote: When translating the SRS instruction, handle the store registers to stack of current mode case in the helper function rather than inline. This means the generated code does not make assumptions about the current CPU mode which

Re: [Qemu-devel] [PATCH 3/8] target-arm: Translate with VFP-enabled from TB flags, not CPUState

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:13PM +, Peter Maydell wrote: When translating code, whether the VFP unit is enabled for this TB is stored in a bit in the TB flags. Use this rather than incorrectly reading the FPEXC from the CPUState passed to translation. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 5/8] target-arm: Translate with Thumb state from TB flags, not CPUState

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:15PM +, Peter Maydell wrote: The Thumb/ARM state for the TB being translated should come from the TB flags, not the CPUState. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c |6 +++--- 1 files changed, 3 insertions(+),

Re: [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride from TB flags, not CPUState

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:14PM +, Peter Maydell wrote: When translating, the VFP vector length and stride for this TB are encoded in the TB flags; the CPUState copies may be different and must not be used. Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

Re: [Qemu-devel] [PATCH 2/8] target-arm: Add symbolic constants for bitfields in TB flags

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:12PM +, Peter Maydell wrote: Add symbolic constants for the bitfields we use in the TB flags. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu.h | 45 +++-- 1 files changed, 39

Re: [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:17PM +, Peter Maydell wrote: M profile ARM cores don't have a CPSR mode field. Set the bit in the TB flags that indicates non-user mode correctly for these cores. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu.h |8 +++-

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Sergei Gavrikov
On Wed, 12 Jan 2011, Stefan Hajnoczi wrote: On Wed, Jan 12, 2011 at 7:22 AM, Sergei Gavrikov sergei.gavri...@gmail.com wrote: diff --git a/slirp/tftp.c b/slirp/tftp.c index 55e4692..a455ad1 100644 --- a/slirp/tftp.c +++ b/slirp/tftp.c @@ -311,7 +311,7 @@ static void

Re: [Qemu-devel] [PATCH 6/8] target-arm: Translate with condexec bits from TB flags, not CPUState

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:16PM +, Peter Maydell wrote: When translating, the condexec bits for the TB are in the TB flags; the CPUState condexec bits may be different. This patch fixes https://bugs.launchpad.net/bugs/604872 where we might segfault if we took an exception in the

Re: [Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from TB flags, not CPUState

2011-01-12 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 10:12:18PM +, Peter Maydell wrote: When translating, get the user/priv state from the TB flags, not the CPUState. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-12 Thread Avi Kivity
On 01/11/2011 03:54 PM, Anthony Liguori wrote: Right, we should introduce a KVMBus that KVM devices are created on. The devices can get at KVMState through the BusState. There is no kvm bus in a PC (I looked). We're bending the device model here because a device is implemented in the

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-12 Thread Jan Kiszka
Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote: Right, we should introduce a KVMBus that KVM devices are created on. The devices can get at KVMState through the BusState. There is no kvm bus in a PC (I looked). We're bending the device model here

[Qemu-devel] [PATCH 0/3] unify protocol: and drive-letter: handling in filenames

2011-01-12 Thread Michael Tokarev
Currently recognision of protocol: and d: (drive letter on windows) are spread over in block.c in adhoc manner, disallows usage of filenames with colons in them, intermixes URLs (which should be treated as protocol-specific) and pathnames. The following patch series tries to address these

[Qemu-devel] [PATCH 2/3] use new path_has_protocol() in bdrv_find_protocol()

2011-01-12 Thread Michael Tokarev
Signed-off-by: Michael Tokarev m...@tls.msk.ru --- block.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index e5a6f60..42d6ff1 100644 --- a/block.c +++ b/block.c @@ -314,7 +314,7 @@ static BlockDriver *find_hdev_driver(const char *filename)

Re: [Qemu-devel] [PATCH 1/7] tcg: Define deposit as an optional operation.

2011-01-12 Thread Edgar E. Iglesias
On Mon, Jan 10, 2011 at 07:23:42PM -0800, Richard Henderson wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/README| 14 tcg/tcg-op.h | 64 + tcg/tcg-opc.h |6 + 3 files changed, 84

Re: [Qemu-devel] [PATCH] Avoid divide by zero when there is no block device to migrate

2011-01-12 Thread Pierre Riteau
On 11 janv. 2011, at 12:54, Kevin Wolf wrote: Am 25.12.2010 21:52, schrieb Pierre Riteau: When block migration is requested and no read-write block device is present, a divide by zero exception is triggered because total_sector_sum equals zero. Signed-off-by: Pierre Riteau

[Qemu-devel] [PATCH v2 1/9] target-sh4: switch sh4 to softfloat

2011-01-12 Thread Aurelien Jarno
We need to be able to catch exceptions correctly and thus enable softfloat on SH4. As all machines except i386 and x86_64 are using softfloat, make it the default and change the case to detect i386 and x86_64. Note that CRIS doesn't have an FPU, so it can be configured with both softfloat-native

Re: [Qemu-devel] [PATCH 6/7] target-i386: Use deposit operation.

2011-01-12 Thread Edgar E. Iglesias
On Mon, Jan 10, 2011 at 07:23:47PM -0800, Richard Henderson wrote: Use this for assignment to the low byte or low word of a register. Looks good. Acked-by: Edgar E. Iglesias edgar.igles...@gmail.com Signed-off-by: Richard Henderson r...@twiddle.net --- target-i386/translate.c | 34

[Qemu-devel] [PATCH 3/3] make path_combine() especially for filenames, not URLs

2011-01-12 Thread Michael Tokarev
Currently the two routines tries to understand and skip protocol: prefix in path arguments are path_combine() and path_is_absolute() (the latter isn't used anywhere but in the former). This is wrong, since notion of absolute path is, at least, protocol-specific. The implementation is more wrong

[Qemu-devel] [PATCH 1/3] make path_has_protocol() to return pointer instead of bool

2011-01-12 Thread Michael Tokarev
Currently protocol: parsing in filenames is ad-hoc and scattered all around block.c. This is a first step to prepare for common parsing. Signed-off-by: Michael Tokarev m...@tls.msk.ru --- block.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/block.c

[Qemu-devel] Re: [Xen-devel] [PATCH 2/2] xen: Introduce VGA sync dirty bitmap support

2011-01-12 Thread Stefano Stabellini
On Tue, 11 Jan 2011, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This patch introduces phys memory client for Xen. Only sync dirty_bitmap and set_memory are actually implemented. migration_log will stay empty for the moment. Xen can only log one range

[Qemu-devel] [PATCH v4 01/32] usb: update MAINTAINERS

2011-01-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- MAINTAINERS |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 59effc7..4b07192 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -329,8 +329,8 @@ F: hw/lsi53c895a.c F: hw/scsi* USB -M:

[Qemu-devel] [PATCH v4 00/32] usb descriptor overhaul + more

2011-01-12 Thread Gerd Hoffmann
Hi, Here is a update of the usb descriptor patches and a bunch of improvements on top of that. This patch series features: * Update USB section in MAINTAINERS * A major overhaul for the usb descriptor handling for emulated devices. This is in preparation for USB 2.0 support

[Qemu-devel] [PATCH v4 04/32] usb serial: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb serial drivers (serial, braille) over to the new descriptor infrastructure. Note that this removes the freely configurable vendor and product id properties. I think the only reason this was configurable is that the only difference between the serial and the braille device is the

[Qemu-devel] [PATCH v4 06/32] usb wacom: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb wavom driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-wacom.c | 178 +++- 1 files changed, 73 insertions(+), 105 deletions(-) diff --git a/hw/usb-wacom.c

[Qemu-devel] [PATCH v4 05/32] usb storage: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb storage driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-msd.c | 167 ++ 1 files changed, 63 insertions(+), 104 deletions(-) diff --git a/hw/usb-msd.c

[Qemu-devel] [PATCH v4 14/32] usb: move remote wakeup handling to common code

2011-01-12 Thread Gerd Hoffmann
This patch moves setting and clearing the remote_wakeup feature bit (via USB_REQ_{SET,CLEAR}_FEATURE) to common code. Also USB_REQ_GET_STATUS handling is moved to common code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bt.c | 21 +++-- hw/usb-desc.c | 26

[Qemu-devel] [PATCH v4 02/32] usb: data structs and helpers for usb descriptors.

2011-01-12 Thread Gerd Hoffmann
This patch adds hw/usb-desc.[ch] files. They carry data structures for various usb descriptors and helper functions to generate usb packets from the structures. The intention is to have a internal representation of the device desription which is more usable than the current char array blobs, so

[Qemu-devel] [PATCH v4 12/32] usb: move USB_REQ_SET_ADDRESS handling to common code

2011-01-12 Thread Gerd Hoffmann
USB_REQ_SET_ADDRESS handling is identical in *all* emulated devices. Move it to common code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bt.c |4 hw/usb-desc.c |6 ++ hw/usb-hid.c|4 hw/usb-hub.c|4 hw/usb-msd.c|4

[Qemu-devel] [PATCH v4 18/32] usb: uhci: remote wakeup support.

2011-01-12 Thread Gerd Hoffmann
Add support for remote wakeup to the UHCI adapter. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-uhci.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 5e2e34a..2d2a9e7 100644 --- a/hw/usb-uhci.c +++

[Qemu-devel] [PATCH v4 09/32] usb descriptors: add settable strings.

2011-01-12 Thread Gerd Hoffmann
This patch allows to set usb descriptor strings per device instance. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |1 + hw/usb-desc.c | 52 hw/usb-desc.h |4 +++- hw/usb.h |9 + 4 files changed,

[Qemu-devel] [PATCH v4 26/32] usb storage: high speed support

2011-01-12 Thread Gerd Hoffmann
Add high speed support to the usb mass storage device. With this patch applied the linux kernel recognises the usb storage device as highspeed capable device and suggests to connect it to a highspeed port instead of the uhci. Tested with both uhci and (not-yet submitted) ehci. Signed-off-by:

[Qemu-devel] [PATCH v4 10/32] usb storage: serial number support

2011-01-12 Thread Gerd Hoffmann
If a serial number is present for the drive fill it into the usb serialnumber string descriptor. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-msd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index 20ab886..9aa 100644

[Qemu-devel] [PATCH v4 17/32] usb: add usb_wakeup() + wakeup callback to port ops

2011-01-12 Thread Gerd Hoffmann
Add wakeup callback to port ops for remote wakeup handling. Also add a usb_wakeup() function for devices which want trigger a remote wakeup. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.c |7 +++ hw/usb.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH v4 07/32] usb bluetooth: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb bluetooth driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bt.c | 473 +-- 1 files changed, 202 insertions(+), 271 deletions(-) diff --git a/hw/usb-bt.c

[Qemu-devel] [PATCH v4 03/32] usb hid: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb hid drivers (keyboard, mouse, tablet) over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hid.c | 448 +++--- 1 files changed, 205 insertions(+), 243 deletions(-) diff --git

[Qemu-devel] [PATCH v4 08/32] usb hub: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb hub driver over to the new descriptor infrastructure. It also removes the nr_ports variable and MAX_PORTS define and introduces a NUM_PORTS define instead. The numver of ports was (and still is) fixed at 8 anyway. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hub.c |

[Qemu-devel] [PATCH v4 15/32] usb: create USBPortOps, move attach there.

2011-01-12 Thread Gerd Hoffmann
Create USBPortOps struct, move the attach function to that struct. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |6 -- hw/usb-hub.c |6 +- hw/usb-musb.c |6 +- hw/usb-ohci.c |6 +- hw/usb-uhci.c |6 +- hw/usb.c |2 +- hw/usb.h

[Qemu-devel] [PATCH v4 27/32] usb storage: fix status reporting

2011-01-12 Thread Gerd Hoffmann
Change usb_msd_send_status() to take a pointer to the status packet instead of writing the status to s-usb_buf which might not point to the correct location. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-msd.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v4 31/32] usb: rewrite fw path, fix numbering

2011-01-12 Thread Gerd Hoffmann
This patch rewrites the firmware path code to use the physical port location tracking just added to the qemu usb core. It also fixes the port numbering to start with 1 in the firmware path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c | 68

[Qemu-devel] [PATCH v4 23/32] usb: add attach callback

2011-01-12 Thread Gerd Hoffmann
Add handle_attach() callback to USBDeviceInfo which is called by the generic package handler when the device is attached to the usb bus (i.e. plugged into a port). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.c |7 ++- hw/usb.h |5 + 2 files changed, 11

[Qemu-devel] [PATCH v4 20/32] usb: hid: remote wakeup support.

2011-01-12 Thread Gerd Hoffmann
Add usb_wakeup() call to the hid driver so remote wakeup actually works. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hid.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 1c35960..60fa57f 100644 --- a/hw/usb-hid.c +++

[Qemu-devel] [PATCH v4 29/32] usb: keep track of physical port address.

2011-01-12 Thread Gerd Hoffmann
Add a path string to USBPort. Add usb_port_location() function to set the physical location of the usb port. Update all drivers implementing usb ports to call it. Update the monitor commands to print it. Wind it up in qdev. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |

[Qemu-devel] [PATCH v4 25/32] usb: add device qualifier support

2011-01-12 Thread Gerd Hoffmann
Add support for device_qualifier and other_speed_config descriptors. These are used to query the other speed configuration of usb 2.0 devices, i.e. in high-speed mode they return the full-speed configuration and visa versa. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-desc.c | 46

[Qemu-devel] [PATCH v4 24/32] usb: add usb_desc_attach

2011-01-12 Thread Gerd Hoffmann
Add usb_desc_attach() which sets up the device according to the speed the usb port is able to handle. This function can be hooked into the handle_attach callback. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-desc.c | 36 +--- hw/usb-desc.h |1 +

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Stefan Hajnoczi
On Wed, Jan 12, 2011 at 10:22 AM, Sergei Gavrikov sergei.gavri...@gmail.com wrote: It was good to know. If you mean the below I merge that in one. Thank you for review. Sergei Signed-off-by: Sergei Gavrikov sergei.gavri...@gmail.com Acked-by: Stefan Hajnoczi stefa...@gmail.com Your new

Re: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-12 Thread Jan Kiszka
Am 23.12.2010 21:45, Zachary Amsden wrote: On 12/17/2010 04:58 AM, Jan Kiszka wrote: By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). This works fine if only the frequency of the host clock is tuned (e.g. by NTP) or if it is set to a future time. However, if the host is

[Qemu-devel] [PATCH v4 28/32] usb storage: handle long responses

2011-01-12 Thread Gerd Hoffmann
The scsi layer may return us more data than the guests wants to have. Handle this by just ignoring the extra bytes and calling the {read,write}_data callback to finish the request. Seen happening in real life with some extended inquiry command. With this patch applied the linux kernel stops

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskotmate...@loskot.net wrote: I suggest using QEMU git master. You could try the binaries from my website: http://www.weilnetz.de/qemu/ Stefan, Thank you very much! So far, I have tried to use versions of

Re: [Qemu-devel] [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable.

2011-01-12 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: This patch adds a field to PCIDeviceInfo to tag devices as being not hotpluggable. Any attempt to plug-in or -out such a device will throw an error. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pci.c | 10 ++ hw/pci.h |3 +++

[Qemu-devel] [PATCH v4 30/32] usb: add port property.

2011-01-12 Thread Gerd Hoffmann
This allows to explictily set the physical port where you want to plug the usb device. Example: -device usb-tablet,bus=usb.0,port=2 With explicit port addressing qemu can and will not automagically add USB Hubs. This means that: (a) You can plug two devices of your choice into the two

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-12 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 01/11/2011 03:54 PM, Anthony Liguori wrote: Right, we should introduce a KVMBus that KVM devices are created on. The devices can get at KVMState through the BusState. There is no kvm bus in a PC (I looked). We're bending the device model here because

Re: [Qemu-devel] [PATCH v2 2/4] piix: tag as not hotpluggable.

2011-01-12 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: This patch tags all pci devices which belong to the piix3/4 chipsets as not hotpluggable (Host bridge, ISA bridge, IDE controller, ACPI bridge). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c |2 ++ hw/ide/piix.c |2 ++

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Ian Jackson
Paolo Bonzini writes ([PATCH v2] add event queueing to USB HID): For v2 I changed the head/tail implementation of the FIFO buffer (which was buggy when the queue became full) to head/count. I then removed have_data, which is the same as count0 for pointer

[Qemu-devel] [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Paolo Bonzini
The polling nature of the USB HID device makes it very hard to double click or drag while on a high-latency VNC connection. This patch, based on work done in the Xen qemu-dm tree by Ian Jackson, fixes this bug by adding an event queue to the device. The event queue associates each movement with

Re: [Qemu-devel] [PATCH 0/8] Add save/restore support to ARM versatilepb devices

2011-01-12 Thread Peter Maydell
On 23 December 2010 11:19, Peter Maydell peter.mayd...@linaro.org wrote: This patchset adds save/restore support to the devices used by the ARM versatilepb board which didn't already support it. I did this in line with docs/migration.txt, and it seems to work OK. I'd appreciate some review

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Sergei Gavrikov
On Wed, 12 Jan 2011, Stefan Hajnoczi wrote: On Wed, Jan 12, 2011 at 10:22 AM, Sergei Gavrikov sergei.gavri...@gmail.com wrote: It was good to know. If you mean the below I merge that in one. Thank you for review. Sergei Signed-off-by: Sergei Gavrikov sergei.gavri...@gmail.com

Re: [Qemu-devel] [PATCH v4 18/32] usb: uhci: remote wakeup support.

2011-01-12 Thread Stefan Hajnoczi
On Wed, Jan 12, 2011 at 11:20 AM, Gerd Hoffmann kra...@redhat.com wrote: Add support for remote wakeup to the UHCI adapter. It would be nice to document the guest configuration steps for users so they can take advantage of this. Perhaps on the qemu.org wiki? Or

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskotmate...@loskot.net wrote: On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskotmate...@loskot.net wrote: I suggest using QEMU git master. You could try the

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Paolo Bonzini
On 01/12/2011 01:34 PM, Ian Jackson wrote: Paolo Bonzini writes ([PATCH v2] add event queueing to USB HID): For v2 I changed the head/tail implementation of the FIFO buffer (which was buggy when the queue became full) to head/count. I then removed have_data, which is

Re: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-12 Thread Jan Kiszka
Am 12.01.2011 13:27, Gleb Natapov wrote: On Wed, Jan 12, 2011 at 12:26:25PM +0100, Jan Kiszka wrote: Am 23.12.2010 21:45, Zachary Amsden wrote: On 12/17/2010 04:58 AM, Jan Kiszka wrote: By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). This works fine if only the

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Ian Jackson
Paolo Bonzini writes (Re: [PATCH v2] add event queueing to USB HID): It's all pretty academic as in practice it worked well. The queue-full code would never trigger in usb_pointer_event, and instead the queue would be instantly emptied when a 17th event arrived. This is lucky actually,

[Qemu-devel] [PATCH v4 16/32] usb: rework attach/detach workflow

2011-01-12 Thread Gerd Hoffmann
Add separate detach callback to USBPortOps, split uhci/ohci/musb/usbhub attach functions into two. Move common code to the usb_attach() function, only the hardware-specific bits remain in the attach/detach callbacks. Keep track of the port it is attached to for each usb device. [ v3: fix tyops

[Qemu-devel] [PATCH v4 21/32] usb: hid: change serial number to 42.

2011-01-12 Thread Gerd Hoffmann
It would be nice to have some way to signal our hid devices support remote wakeup. There is a descriptor bit for that of course. Problem with using is one is that older qemu versions used to set the bit even though they did *not* support remote wakeup. Bummer. This patch changes the serial

[Qemu-devel] [PATCH v4 11/32] usb network: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb network driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-net.c | 453 +++--- 1 files changed, 209 insertions(+), 244 deletions(-) diff --git a/hw/usb-net.c

[Qemu-devel] [PATCH v4 19/32] usb: hub: remote wakeup support.

2011-01-12 Thread Gerd Hoffmann
This patch makes the usb hub handle remote wakeup requests from devices properly by updating the port status register and forwarding the wakeup to the upstream port. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hub.c | 12 1 files changed, 12 insertions(+), 0

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 10/01/11 22:18, Stefan Weil wrote: Am 10.01.2011 18:59, schrieb Mateusz Loskot: On 10/01/11 17:08, Stefan Weil wrote: Am 10.01.2011 12:19, schrieb Mateusz Loskot: On 07/01/11 18:15, Stefan Weil wrote: There are no precompiled windows binaries of current qemu, so you will have to compile

Re: [Qemu-devel] [RESEND PATCH 1/2] qdev: Track runtime machine modifications

2011-01-12 Thread Markus Armbruster
Alex Williamson alex.william...@redhat.com writes: Create a trivial interface to track whether the machine has been modified since boot. Adding or removing devices will trigger this to return true. An example usage scenario for such an interface is the rtl8139 driver which includes a

[Qemu-devel] [PATCH v4 22/32] usb: add speed mask to ports

2011-01-12 Thread Gerd Hoffmann
Add a field to usb ports indicating the speed(s) they are able to handle. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |3 ++- hw/usb-hub.c |3 ++- hw/usb-musb.c |3 ++- hw/usb-ohci.c |3 ++- hw/usb-uhci.c |3 ++- hw/usb.h |9 - 6 files

Re: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-12 Thread Gleb Natapov
On Wed, Jan 12, 2011 at 12:26:25PM +0100, Jan Kiszka wrote: Am 23.12.2010 21:45, Zachary Amsden wrote: On 12/17/2010 04:58 AM, Jan Kiszka wrote: By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). This works fine if only the frequency of the host clock is tuned (e.g.

[Qemu-devel] [PATCH v2] Avoid divide by zero when there is no block device to migrate

2011-01-12 Thread Pierre Riteau
When block migration is requested and no read-write block device is present, a divide by zero exception is triggered because total_sector_sum equals zero. Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr --- This v2 fixes a line that was going beyond 80 characters. block-migration.c |7

Re: [Qemu-devel] [PATCH] Avoid divide by zero when there is no block device to migrate

2011-01-12 Thread Kevin Wolf
Am 12.01.2011 12:01, schrieb Pierre Riteau: On 11 janv. 2011, at 12:54, Kevin Wolf wrote: Am 25.12.2010 21:52, schrieb Pierre Riteau: When block migration is requested and no read-write block device is present, a divide by zero exception is triggered because total_sector_sum equals zero.

[Qemu-devel] [PATCH v4 32/32] usb: zap pdev from usbport

2011-01-12 Thread Gerd Hoffmann
It isn't needed any more. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |3 +-- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +- hw/usb.h |3 +-- 6 files changed, 6 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] [RESEND PATCH 1/2] qdev: Track runtime machine modifications

2011-01-12 Thread Alex Williamson
On Wed, 2011-01-12 at 13:09 +0100, Markus Armbruster wrote: Alex Williamson alex.william...@redhat.com writes: Create a trivial interface to track whether the machine has been modified since boot. Adding or removing devices will trigger this to return true. An example usage scenario for

[Qemu-devel] [PATCHv1] slirp: Use strcasecmp() to check tftp mode, tsize

2011-01-12 Thread Sergei Gavrikov
From: Sergei Gavrikov sergei.gavri...@gmail.com According to RFC 1350 (TFTP Revision 2) the mode field can contain any combination of upper and lower case; also RFC 2349 propagates that the transfer size option (tsize) is case in-sensitive too. Current implementation of embedded TFTP server

Re: [Qemu-devel] [PATCH] arm-dis: Include opcode hex when doing disassembly

2011-01-12 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:09:28AM -0600, Peter Maydell wrote: On 10 January 2011 10:49, Aurelien Jarno aurel...@aurel32.net wrote: Strangely on arm host, the opcode hex is already included, as shown below: | OUT: [size=308] | 0x01001ec0:  e5974004  ldr      r4, [r7, #4] | 0x01001ec4:

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 12:32, Mateusz Loskot wrote: On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskotmate...@loskot.net wrote: On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskotmate...@loskot.net wrote: I suggest using

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Artyom Tarasenko
On Wed, Jan 12, 2011 at 3:28 PM, Mateusz Loskot mate...@loskot.net wrote: On 12/01/11 12:32, Mateusz Loskot wrote: On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskotmate...@loskot.net wrote: On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon, Jan

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 14:40, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 3:28 PM, Mateusz Loskotmate...@loskot.net wrote: On 12/01/11 12:32, Mateusz Loskot wrote: On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskotmate...@loskot.net wrote: On 10/01/11

[Qemu-devel] Re: [PATCH][RESEND] virtio-serial-bus: Bump up control vq descriptors to min. required

2011-01-12 Thread Michael S. Tsirkin
On Tue, Jan 11, 2011 at 09:47:44PM +0530, Amit Shah wrote: The current default of 16 buffers for the control vq is too small for the default max_nr_ports of 32. We can get more entries in there, example when asking the guest to add max. allowed ports. Default to using the minimum required

[Qemu-devel] Re: [PATCH] audio: split sample conversion and volume mixing

2011-01-12 Thread malc
On Wed, 5 Jan 2011, Michael Walle wrote: Refactor the volume mixing, so it can be reused for capturing devices. Additionally, it removes superfluous multiplications with the nominal volume within the hardware voice code path. Thanks, applied. [..snip..] -- mailto:av1...@comtv.ru

[Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Gerd Hoffmann
Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent issue itself ... The spicevmc chardev just pipes data from a chardev user within qemu to libspice and adds a type tag to it so libspice knows

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Gerd Hoffmann
Hi, I left the changed member in USBHIDState, rather than moving it to the keyboard, because it is useful to handle the idle period (in USB_TOKEN_IN) in a device-independent way. Without it the code became more messy. This leaves the same information recorded in the driver in two places and

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Michal Suchanek
On 12 January 2011 16:21, Mateusz Loskot mate...@loskot.net wrote: On 12/01/11 14:40, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 3:28 PM, Mateusz Loskotmate...@loskot.net  wrote: On 12/01/11 12:32, Mateusz Loskot wrote: On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011

[Qemu-devel] Re: [PATCH 2/2] xen: Introduce VGA sync dirty bitmap support

2011-01-12 Thread Anthony PERARD
On Wed, 12 Jan 2011, Jan Kiszka wrote: Am 11.01.2011 16:37, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This patch introduces phys memory client for Xen. Only sync dirty_bitmap and set_memory are actually implemented. migration_log will stay empty

Re: [Qemu-devel] forking with x86_64

2011-01-12 Thread Mulyadi Santosa
On Wed, Jan 12, 2011 at 17:17, maheen butt maheen_but...@yahoo.com wrote: hi why qemu does not provide NPTL support for x86 in user mode? is there any big hindrance behind it? IMHO, your experiment works since it simply fork(). What qemu wanna do here is complete NPTL handling...and afaik

[Qemu-devel] Re: [Xen-devel] [PATCH 2/2] xen: Introduce VGA sync dirty bitmap support

2011-01-12 Thread Anthony PERARD
On Wed, 12 Jan 2011, Stefano Stabellini wrote: On Tue, 11 Jan 2011, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This patch introduces phys memory client for Xen. Only sync dirty_bitmap and set_memory are actually implemented. migration_log will

[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Dragos Tatulea
Hi, Trying to stir up a year old conversation [1] about mac filtering. The patch below is Alex Williamson's work updated for the current qemu taking into account some comments. An extra check for multiple nics on the same vlan has been added as well. Now, I know it's not ideal but I'm looking

[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Michael S. Tsirkin
On Wed, Jan 12, 2011 at 06:26:55PM +0100, Dragos Tatulea wrote: Hi, Trying to stir up a year old conversation [1] about mac filtering. The patch below is Alex Williamson's work updated for the current qemu taking into account some comments. An extra check for multiple nics on the same vlan

Re: [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Anthony Liguori
On 01/12/2011 10:12 AM, Gerd Hoffmann wrote: Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent issue itself ... The spicevmc chardev just pipes data from a chardev user within qemu to libspice

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 16:48, Michal Suchanek wrote: On 12 January 2011 16:21, Mateusz Loskotmate...@loskot.net wrote: Thinking of future, could anyone estimate when it will be possible to boot Solaris 10 installation from ISO disks, if at all? To summary, what OS alternative for SPARC we have got apart

[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Michael S. Tsirkin
On Wed, Jan 12, 2011 at 06:26:55PM +0100, Dragos Tatulea wrote: Hi, Trying to stir up a year old conversation [1] about mac filtering. The patch below is Alex Williamson's work updated for the current qemu taking into account some comments. An extra check for multiple nics on the same vlan

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2011-01-12 Thread Serge Hallyn
Patch is said to be in maverick-next. I'd like to hear confirmation (or denial) from original bug reporter as to whether the patch fixed the problem. (I'm unconvinced that this is actually a dup of the Meego bug) ** Changed in: linux (Ubuntu) Status: In Progress = Fix Committed **

[Qemu-devel] [PATCH 2/3] QMP: Documentation for the BLOCK_MEDIA_EJECT event

2011-01-12 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 0ce5d4e..d13b17a 100644 --- a/QMP/qmp-events.txt +++ b/QMP/qmp-events.txt @@ -1,6

[Qemu-devel] [RFC 0/3]: QMP: Introduce BLOCK_MEDIA_EJECT event

2011-01-12 Thread Luiz Capitulino
Not very well tested, but I'm sending for early review. Please, check individual patches for details. The event spec can be found in patch 0/2. QMP/qmp-events.txt | 15 +++ block.c| 16 ++-- block.h|5 +++-- blockdev.c |5 +

  1   2   >