Re: [Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-20 Thread Venkateswararao Jujjuri (JV)
On 1/20/2011 1:45 PM, Stefan Hajnoczi wrote: > On Thu, Jan 20, 2011 at 9:15 PM, Venkateswararao Jujjuri (JV) > wrote: >> On 1/20/2011 12:59 AM, Stefan Hajnoczi wrote: >>> On Tue, Jan 18, 2011 at 01:54:16PM +0530, M. Mohan Kumar wrote: After creating a file object, its permission and ownership

[Qemu-devel] Qemu signal handling

2011-01-20 Thread maheen butt
 hi In QEMU code almost every signal is handled then why this warning is generated from syscall.c #elif defined(TARGET_ABI_MIPSN64) # warning signal handling not implemented

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Alex Williamson
On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote: > On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: > > On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: > > > >> On 01/20/2011 09:35 AM, Michael S. Tsirkin wrote: > >> > >>> When MSI is off, each interrupt needs to

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Anthony Liguori
On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: On 01/20/2011 09:35 AM, Michael S. Tsirkin wrote: When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes mor

[Qemu-devel] Re: [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Sridhar Samudrala
On Thu, 2011-01-20 at 19:47 +0200, Michael S. Tsirkin wrote: > On Thu, Jan 20, 2011 at 08:31:53AM -0800, Sridhar Samudrala wrote: > > On Thu, 2011-01-20 at 17:35 +0200, Michael S. Tsirkin wrote: > > > When MSI is off, each interrupt needs to be bounced through the io > > > thread when it's set/clea

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Jan Kiszka
On 2011-01-20 22:40, Blue Swirl wrote: > On Thu, Jan 20, 2011 at 9:22 PM, Jan Kiszka wrote: >> On 2011-01-20 20:27, Blue Swirl wrote: >>> On Thu, Jan 20, 2011 at 9:33 AM, Jan Kiszka wrote: On 2011-01-19 20:32, Blue Swirl wrote: > On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori > wr

Re: [Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-20 Thread Stefan Hajnoczi
On Thu, Jan 20, 2011 at 9:15 PM, Venkateswararao Jujjuri (JV) wrote: > On 1/20/2011 12:59 AM, Stefan Hajnoczi wrote: >> On Tue, Jan 18, 2011 at 01:54:16PM +0530, M. Mohan Kumar wrote: >>> After creating a file object, its permission and ownership details are >>> updated >>> as per client's reques

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Jan Kiszka
On 2011-01-20 21:02, Blue Swirl wrote: > I think KVMState was designed to match KVM ioctl interface: all stuff > that is needed for talking to KVM or received from KVM are there. But > I think this shouldn't be a design driver. Agreed. The nice cleanup would probably be the complete assimilation o

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Blue Swirl
On Thu, Jan 20, 2011 at 9:22 PM, Jan Kiszka wrote: > On 2011-01-20 20:27, Blue Swirl wrote: >> On Thu, Jan 20, 2011 at 9:33 AM, Jan Kiszka wrote: >>> On 2011-01-19 20:32, Blue Swirl wrote: On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori wrote: > On 01/19/2011 07:15 AM, Markus Armb

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Jan Kiszka
On 2011-01-20 20:37, Anthony Liguori wrote: > On 01/20/2011 03:33 AM, Jan Kiszka wrote: >> On 2011-01-19 20:32, Blue Swirl wrote: >> >>> On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori >>> wrote: >>> On 01/19/2011 07:15 AM, Markus Armbruster wrote: > So they interact

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Jan Kiszka
On 2011-01-20 20:27, Blue Swirl wrote: > On Thu, Jan 20, 2011 at 9:33 AM, Jan Kiszka wrote: >> On 2011-01-19 20:32, Blue Swirl wrote: >>> On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori >>> wrote: On 01/19/2011 07:15 AM, Markus Armbruster wrote: > > So they interact with KVM (need k

Re: [Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-20 Thread Stefan Hajnoczi
On Thu, Jan 20, 2011 at 2:48 PM, Daniel P. Berrange wrote: > On Thu, Jan 20, 2011 at 08:11:27PM +0530, M. Mohan Kumar wrote: >> On Thursday 20 January 2011 2:29:54 pm Stefan Hajnoczi wrote: >> > On Tue, Jan 18, 2011 at 01:54:16PM +0530, M. Mohan Kumar wrote: >> >> > > -    if (lchown(rpath(fs_ctx,

Re: [Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-20 Thread Venkateswararao Jujjuri (JV)
On 1/20/2011 12:59 AM, Stefan Hajnoczi wrote: > On Tue, Jan 18, 2011 at 01:54:16PM +0530, M. Mohan Kumar wrote: >> After creating a file object, its permission and ownership details are >> updated >> as per client's request for both passthrough and none security model. But >> with >> chrooted env

Re: [Spice-devel] [Qemu-devel] usb redirection status report

2011-01-20 Thread David Mansfield
> H > i, > > On 01/20/2011 12:27 PM, Christoph Hellwig wrote: > > On Wed, Jan 19, 2011 at 07:15:47PM +0100, Hans de Goede wrote: > >> Hi All, > >> > >> As most of you know I'm working on usb redirection (making client usb > >> devices > >> accessible in guests over the network). > >> > >> I though

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Blue Swirl
On Thu, Jan 20, 2011 at 7:37 PM, Anthony Liguori wrote: > On 01/20/2011 03:33 AM, Jan Kiszka wrote: >> >> On 2011-01-19 20:32, Blue Swirl wrote: >> >>> >>> On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori >>>  wrote: >>> On 01/19/2011 07:15 AM, Markus Armbruster wrote: > >

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-20 Thread Anthony Liguori
On 01/20/2011 11:12 AM, Markus Armbruster wrote: Anthony Liguori writes: On 01/18/2011 02:16 PM, Markus Armbruster wrote: The problem: you want to do serious scalability testing (1000s of VMs) of your management stack. If each guest eats up a few 100MiB and competes for CPU, that r

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Anthony Liguori
On 01/20/2011 04:33 AM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 09:44:05AM +0100, Gerd Hoffmann wrote: Hi, For (2), you cannot use bus=X,addr=Y because it makes assumptions about the PCI topology which may change in newer -M pc's. Why should the PCI topology for

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Anthony Liguori
On 01/20/2011 02:44 AM, Gerd Hoffmann wrote: Hi, For (2), you cannot use bus=X,addr=Y because it makes assumptions about the PCI topology which may change in newer -M pc's. Why should the PCI topology for 'pc' ever change? We'll probably get q35 support some day, but when this lands I expe

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Anthony Liguori
On 01/20/2011 03:33 AM, Jan Kiszka wrote: On 2011-01-19 20:32, Blue Swirl wrote: On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori wrote: On 01/19/2011 07:15 AM, Markus Armbruster wrote: So they interact with KVM (need kvm_state), and they interact with the emulated PCI bus.

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Blue Swirl
On Thu, Jan 20, 2011 at 9:33 AM, Jan Kiszka wrote: > On 2011-01-19 20:32, Blue Swirl wrote: >> On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori >> wrote: >>> On 01/19/2011 07:15 AM, Markus Armbruster wrote: So they interact with KVM (need kvm_state), and they interact with the emul

Re: [Qemu-devel] usb redirection status report

2011-01-20 Thread Hans de Goede
Hi, On 01/20/2011 12:27 PM, Christoph Hellwig wrote: On Wed, Jan 19, 2011 at 07:15:47PM +0100, Hans de Goede wrote: Hi All, As most of you know I'm working on usb redirection (making client usb devices accessible in guests over the network). I thought it would be a good idea to write a short

[Qemu-devel] Re: [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Alex Williamson
On Thu, 2011-01-20 at 17:35 +0200, Michael S. Tsirkin wrote: > When MSI is off, each interrupt needs to be bounced through the io > thread when it's set/cleared, so vhost-net causes more context switches and > higher CPU utilization than userspace virtio which handles networking in > the same threa

Re: [Qemu-devel] [PATCH] target-arm: Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-01-20 Thread Peter Maydell
On 20 January 2011 17:16, Christophe Lyon wrote: > Set the right overflow bit for neon 32 and 64 bit saturating add/sub. > > Also move the neon 64 bit saturating add/sub helpers to neon_helper.c > for consistency with the 32 bits versions. > > There is probably still room for code commonalization

[Qemu-devel] Re: [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 08:31:53AM -0800, Sridhar Samudrala wrote: > On Thu, 2011-01-20 at 17:35 +0200, Michael S. Tsirkin wrote: > > When MSI is off, each interrupt needs to be bounced through the io > > thread when it's set/cleared, so vhost-net causes more context switches and > > higher CPU uti

[Qemu-devel] [PATCH] target-arm: Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-01-20 Thread Christophe Lyon
Set the right overflow bit for neon 32 and 64 bit saturating add/sub. Also move the neon 64 bit saturating add/sub helpers to neon_helper.c for consistency with the 32 bits versions. There is probably still room for code commonalization though. Peter, this patch is based upon your patch 6f83e7d

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-20 Thread Markus Armbruster
Anthony Liguori writes: > On 01/18/2011 02:16 PM, Markus Armbruster wrote: >> The problem: you want to do serious scalability testing (1000s of VMs) >> of your management stack. If each guest eats up a few 100MiB and >> competes for CPU, that requires a serious host machine. Which you don't >>

Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

2011-01-20 Thread Stefan Weil
Am 20.01.2011 15:49, schrieb Chunqiang Tang: Please try to split the patches into logical parts, and use descriptive subject lines for each patch. E.g. adding the new sim command to qemu-io could be one patch, adding the img_update (why not just update?) command to qemu-img another, moving code i

[Qemu-devel] [PATCH v4 3/3] qcow2: Batch flushes for COW

2011-01-20 Thread Kevin Wolf
qcow2 calls bdrv_flush() after performing COW in order to ensure that the L2 table change is never written before the copy is safe on disk. Now that the L2 table is cached, we can wait with flushing until we write out the next L2 table. Signed-off-by: Kevin Wolf --- block/qcow2-cache.c | 20

[Qemu-devel] [PATCH v4 2/3] qcow2: Use QcowCache

2011-01-20 Thread Kevin Wolf
Use the new functions of qcow2-cache.c for everything that works on refcount block and L2 tables. Signed-off-by: Kevin Wolf --- block/qcow2-cache.c| 10 ++ block/qcow2-cluster.c | 207 +- block/qcow2-refcount.c | 258 --

[Qemu-devel] [PATCH v4 1/3] qcow2: Add QcowCache

2011-01-20 Thread Kevin Wolf
This adds some new cache functions to qcow2 which can be used for caching refcount blocks and L2 tables. When used with cache=writethrough they work like the old caching code which is spread all over qcow2, so for this case we have merely a cleanup. The interesting case is with writeback caching (

[Qemu-devel] [PATCH v4 0/3] qcow2 metadata cache

2011-01-20 Thread Kevin Wolf
block-queue turned out to be too big effort to be useful for quickly fixing the performance problems that qcow2 got since we introduced the metadata flushes. While I still think the idea is right, it needs more time and qcow2 doesn't have more time. Let's come back to block-queue later when the mos

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-20 Thread Christophe Lyon
> I would personally prefer slightly less terse commit messages > (for instance it might be nice to list the affected instructions in > this case). The convention is also to preface the summary line > with the file or directory affected, ie "target-arm: Fix garbage > collection of temporaries in N

[Qemu-devel] Re: [Xen-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect

2011-01-20 Thread Ian Jackson
Stefano Stabellini writes ("[Xen-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect"): > The test on xendev->gnttabdev in con_disconnect is wrong: what > differentiates the consoles is the dev number. Thanks, I have applied this patch to qemu-xen-unstable.git. Ian.

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-20 Thread Anthony Liguori
On 01/18/2011 02:16 PM, Markus Armbruster wrote: The problem: you want to do serious scalability testing (1000s of VMs) of your management stack. If each guest eats up a few 100MiB and competes for CPU, that requires a serious host machine. Which you don't have. You also don't want to modify t

[Qemu-devel] Re: [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Sridhar Samudrala
On Thu, 2011-01-20 at 17:35 +0200, Michael S. Tsirkin wrote: > When MSI is off, each interrupt needs to be bounced through the io > thread when it's set/cleared, so vhost-net causes more context switches and > higher CPU utilization than userspace virtio which handles networking in > the same threa

[Qemu-devel] Re: [PATCH] hw/pl190.c: Fix writing of default vector address

2011-01-20 Thread Aurelien Jarno
On Thu, Jan 20, 2011 at 04:04:52PM +, Peter Maydell wrote: > The PL190 implementation keeps the default vector address > in vect_addr[16], but we weren't using this for writes to > the DEFVECTADDR register. As a result of this fix the > default_addr structure member is unused and we can delete

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-20 Thread Yoshiaki Tamura
2011/1/20 Pierre Riteau : > On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: > >> 2011/1/19 Pierre Riteau : >>> b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return >>> value of bdrv_write and aborts migration when it fails. However, if the >>> size of the block device to migrate

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: > On 01/20/2011 09:35 AM, Michael S. Tsirkin wrote: > >When MSI is off, each interrupt needs to be bounced through the io > >thread when it's set/cleared, so vhost-net causes more context switches and > >higher CPU utilization than us

[Qemu-devel] [PATCH] hw/pl190.c: Fix writing of default vector address

2011-01-20 Thread Peter Maydell
The PL190 implementation keeps the default vector address in vect_addr[16], but we weren't using this for writes to the DEFVECTADDR register. As a result of this fix the default_addr structure member is unused and we can delete it. Reported-by: Himanshu Chauhan Signed-off-by: Peter Maydell --- (

[Qemu-devel] [PATCH 2/5] Use vmstate to save/load spitz-lcdtg and corgi-ssp state

2011-01-20 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/spitz.c | 74 ++- 1 files changed, 28 insertions(+), 46 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index 3667618..87731d3 100644 --- a/hw/spitz.c +++ b/hw/spitz.c @@ -527,8 +527,8 @@ st

[Qemu-devel] [PATCH 1/5] SharpSL scoop device - convert to qdev

2011-01-20 Thread Dmitry Eremin-Solenikov
Convert SharpSL scoop device to qdev, remove lots of supporting code, as lot of init and gpio related things can now be done automagically. Signed-off-by: Dmitry Eremin-Solenikov --- hw/sharpsl.h |7 hw/spitz.c | 23 ++-- hw/tosa.c| 23 ++-- hw/zaurus.c | 111

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Yoshiaki Tamura
2011/1/20 Kevin Wolf : > Am 20.01.2011 14:50, schrieb Yoshiaki Tamura: >> 2011/1/20 Kevin Wolf : >>> Am 20.01.2011 11:39, schrieb Yoshiaki Tamura: 2011/1/20 Kevin Wolf : > Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: >> +        return; >> +    } >> + >> +

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Anthony Liguori
On 01/20/2011 09:35 AM, Michael S. Tsirkin wrote: When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes more context switches and higher CPU utilization than userspace virtio which handles networking in the same thread. We'll need to

Re: [Qemu-devel] [PULL] virtio, pci, migration, hotplug

2011-01-20 Thread Anthony Liguori
On 01/20/2011 08:54 AM, Michael S. Tsirkin wrote: This has a fix for a crash with multiple block devices. Probably makes sense to pull ASAP. The following changes since commit d788b57051ee91aa39de67cff8d8e15953bc100c: target-ppc: fix wrong NaN tests (2011-01-20 15:11:14 +0100) Pulled.

[Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-20 Thread Michael S. Tsirkin
When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes more context switches and higher CPU utilization than userspace virtio which handles networking in the same thread. We'll need to fix this by adding level irq support in kvm irqfd,

[Qemu-devel] [PULL] virtio, pci, migration, hotplug

2011-01-20 Thread Michael S. Tsirkin
This has a fix for a crash with multiple block devices. Probably makes sense to pull ASAP. The following changes since commit d788b57051ee91aa39de67cff8d8e15953bc100c: target-ppc: fix wrong NaN tests (2011-01-20 15:11:14 +0100) are available in the git repository at: git://git.kernel.org/pub

Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

2011-01-20 Thread Chunqiang Tang
> Please try to split the patches into logical parts, and use descriptive > subject lines for each patch. > E.g. adding the new sim command to qemu-io could be one patch, adding > the img_update (why not just update?) command to qemu-img another, > moving code into qemu-tool-time.c one more, etc.

Re: [Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-20 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 08:11:27PM +0530, M. Mohan Kumar wrote: > On Thursday 20 January 2011 2:29:54 pm Stefan Hajnoczi wrote: > > On Tue, Jan 18, 2011 at 01:54:16PM +0530, M. Mohan Kumar wrote: > > > > -if (lchown(rpath(fs_ctx, path), credp->fc_uid, credp->fc_gid) < 0) { > > > -/* >

Re: [Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-20 Thread M. Mohan Kumar
On Thursday 20 January 2011 2:29:54 pm Stefan Hajnoczi wrote: > On Tue, Jan 18, 2011 at 01:54:16PM +0530, M. Mohan Kumar wrote: > > -if (lchown(rpath(fs_ctx, path), credp->fc_uid, credp->fc_gid) < 0) { > > -/* > > - * If we fail to change ownership and if we are > > - *

[Qemu-devel] Re: [PATCH] pci: fix pcibus_get_dev_path()

2011-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 06:31:59PM +0800, TeLeMan wrote: > The commit 6a7005d14b3c32d4864a718fb1cb19c789f58a5 used snprintf() > incorrectly. > > Signed-off-by: TeLeMan This won't work for nested bridges as \n by the first sprintf overwrites the rest of the string. I sent a fix titled [PATCH] pc

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Kevin Wolf
Am 20.01.2011 14:50, schrieb Yoshiaki Tamura: > 2011/1/20 Kevin Wolf : >> Am 20.01.2011 11:39, schrieb Yoshiaki Tamura: >>> 2011/1/20 Kevin Wolf : Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: > +return; > +} > + > +bdrv_aio_writev(bs, blk_req->r

[Qemu-devel] Re: [PATCH] pci/pcie: make pci_find_device() ARI aware.

2011-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 03:57:39PM +0900, Isaku Yamahata wrote: > make pci_find_device() ARI aware. > > Signed-off-by: Isaku Yamahata > --- > hw/pci.c |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 8d0e3df..851f350 100644 > --- a/

Re: [Qemu-devel] Missing roms/seabios/Makefile and roms/vgabios/Makefile

2011-01-20 Thread Mateusz Loskot
On 20/01/11 10:58, Stefan Hajnoczi wrote: On Thu, Jan 20, 2011 at 10:51:17AM +, Mateusz Loskot wrote: On 19/01/11 18:07, Blue Swirl wrote: On Wed, Jan 19, 2011 at 12:44 PM, Mateusz Loskot wrote: Hi, Running ./configure (under MinGW/MSYS) and symlink gives up trying to create links to no

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Yoshiaki Tamura
2011/1/20 Kevin Wolf : > Am 20.01.2011 11:39, schrieb Yoshiaki Tamura: >> 2011/1/20 Kevin Wolf : >>> Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: +        return; +    } + +    bdrv_aio_writev(bs, blk_req->reqs[0].sector, blk_req->reqs[0].qiov, >>>

[Qemu-devel] Re: [PATCH] pci: use qemu_malloc() in pcibus_get_dev_path()

2011-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 03:57:49PM +0900, Isaku Yamahata wrote: > use qemu_malloc() instead of direct use of malloc(). > > Signed-off-by: Isaku Yamahata > --- > hw/pci.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied. > diff --git a/hw/pci.c b/hw/pci.c > index 85

[Qemu-devel] Re: [PATCH] pci: make pci_bus_new() aware of pci domain

2011-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 03:57:56PM +0900, Isaku Yamahata wrote: > This patch makes pci bus creation aware of pci domain. > > Signed-off-by: Isaku Yamahata IMO domain support needs some thought, before we jump into it. Specifically: I am not sure a simple number is enough to address a domain. In

Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

2011-01-20 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 05:04:44PM -0500, Chunqiang Tang wrote: > Part 1 of the block device driver for the proposed FVD image format. > Multiple patches are used in order to manage the size of each patch. > This patch includes existing files that are modified by FVD. Please try to split the patch

[Qemu-devel] [PATCH 12/12] Threadlets: Add documentation

2011-01-20 Thread Arun R Bharadwaj
Signed-off-by: Arun R Bharadwaj Signed-off-by: Gautham R Shenoy Reviewed-by: Stefan Hajnoczi --- docs/async-support.txt | 141 1 files changed, 141 insertions(+), 0 deletions(-) create mode 100644 docs/async-support.txt diff --git a/docs/async

[Qemu-devel] [PATCH 10/12] Move threadlet code to qemu-threadlets.c

2011-01-20 Thread Arun R Bharadwaj
This patch moves the threadlet queue API code to qemu-threadlets.c where these APIs can be used by other subsystems. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- posix-aio-compat.c | 137 qemu-threadlet.c | 115 +++

[Qemu-devel] [PATCH 02/12] Introduce work concept in posix-aio-compat.c

2011-01-20 Thread Arun R Bharadwaj
This patch introduces work concept by introducing the ThreadletWork structure. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- posix-aio-compat.c | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c

[Qemu-devel] [PATCH 06/12] Threadlet: Add dequeue_work threadlet API and remove active field.

2011-01-20 Thread Arun R Bharadwaj
This patch adds dequeue_work threadlet API and shows how the paio_cancel changes to dequeue_work. The active field in the qemu_aiocb structure is now useless. Remove it. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- posix-aio-compat.c | 48 ++---

[Qemu-devel] [PATCH 09/12] Remove all instances of CONFIG_THREAD

2011-01-20 Thread Arun R Bharadwaj
Remove all instances of CONFIG_THREAD, which is not used anymore. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- configure |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure b/configure index a079a49..addf733 100755 --- a/configure +++ b/config

[Qemu-devel] [PATCH 11/12] Threadlets: Add functionality to create private queues.

2011-01-20 Thread Arun R Bharadwaj
This patch allows subsystems to create their own private queues with associated pools of threads. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- qemu-threadlet.c | 85 +- qemu-threadlet.h |4 +++ 2 files changed, 63 ins

[Qemu-devel] [PATCH 05/12] Threadlet: Add submit_work threadlet API.

2011-01-20 Thread Arun R Bharadwaj
This patch adds submit work threadlet API and shows how the qemu_paio_submit changes to submit_work. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- posix-aio-compat.c | 33 ++--- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/pos

[Qemu-devel] [PATCH 04/12] Add ThreadletQueue.

2011-01-20 Thread Arun R Bharadwaj
This patch adds a global queue of type ThreadletQueue and removes the earlier usage of request_list queue. We want to create the thread on the first submit. Hence we need to track whether the globalqueue is initialized or not. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- po

[Qemu-devel] [PATCH 07/12] Remove thread_create routine.

2011-01-20 Thread Arun R Bharadwaj
Remove thread_create and use qemu_thread_create instead. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- posix-aio-compat.c | 29 ++--- 1 files changed, 2 insertions(+), 27 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index 95ba80

[Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API

2011-01-20 Thread Arun R Bharadwaj
This patch adds aio_signal_handler threadlet API. Earler posix-aio-compat.c had its own signal handler code. Now abstract this, in the later patch it is moved to a generic code so that it can be used by other subsystems. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- Makefile.

[Qemu-devel] [PATCH 03/12] Add callback function to ThreadletWork structure.

2011-01-20 Thread Arun R Bharadwaj
This patch adds the callback function to the ThreadletWork structure and moves aio handler as a callback function. Signed-off-by: Arun R Bharadwaj Reviewed-by: Stefan Hajnoczi --- posix-aio-compat.c | 89 +--- 1 files changed, 50 insertions(+),

[Qemu-devel] [PATCH 01/12] Add aiocb_mutex and aiocb_completion.

2011-01-20 Thread Arun R Bharadwaj
This patch adds the aiocb_mutex to protect aiocb. This patch also removes the infinite loop present in paio_cancel. Since there can only be one cancellation at a time, we need to introduce a condition variable. For this, we need a global aiocb_completion condition variable. This patch also adds t

[Qemu-devel] [PATCH 00/12] Threadlet Infrastructure

2011-01-20 Thread Arun R Bharadwaj
Hi, This patch series introduces threadlet framework in qemu. Changelog: * Modified the dequeue_work function logic which was earlier wrong. It now returns 0 on success and 1 on failure. * removed the locking for container_of which is not needed in handle_work() * changed qemu-threadlet

[Qemu-devel] Re: [PATCH] target-arm: Fix loading of scalar value for Neon multiply-by-scalar

2011-01-20 Thread Christophe Lyon
On 19.01.2011 20:29, Peter Maydell wrote: > Fix the register and part of register we get the scalar from in > the various "multiply vector by scalar" ops (VMUL by scalar > and friends). > I do confirm that with this patch, I can see many improvements in my tests. Thanks.

Re: [Qemu-devel] [PATCH] Support saturation with shift=0.

2011-01-20 Thread Peter Maydell
On 20 January 2011 12:06, Christophe Lyon wrote: > On 19.01.2011 17:51, Peter Maydell wrote: >> On 19 January 2011 16:10, Christophe Lyon wrote: >>> >>> This patch fixes corner-case saturations, when the target range is >>> zero. It merely removes the guard against (sh == 0), and makes: >>> __ssa

Re: [Qemu-devel] [PATCH] Support saturation with shift=0.

2011-01-20 Thread Christophe Lyon
On 19.01.2011 17:51, Peter Maydell wrote: > On 19 January 2011 16:10, Christophe Lyon wrote: >> >> This patch fixes corner-case saturations, when the target range is >> zero. It merely removes the guard against (sh == 0), and makes: >> __ssat(0x87654321, 1) return 0x and set the saturation

Re: [Qemu-devel] [PATCH] pxa2xx_lcd: restore updating of display

2011-01-20 Thread Aurelien Jarno
On Tue, Jan 18, 2011 at 07:11:33PM +0300, Dmitry Eremin-Solenikov wrote: > Recently PXA2xx lcd have stopped to be updated incrementally (picture > frozen). This patch fixes that by passing non min/max x/y, but rather > (correctly) x/y and w/h. > > Signed-off-by: Dmitry Eremin-Solenikov > --- > h

Re: [Qemu-devel] [PATCH] ioport: Improve error output

2011-01-20 Thread Aurelien Jarno
On Mon, Dec 27, 2010 at 01:00:56AM +0100, Andreas Färber wrote: > When failing due to conflicting I/O port registrations, > include the offending I/O port address in the message. > > Signed-off-by: Andreas Färber > --- > ioport.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH] add bepo (french dvorak) keyboard layout

2011-01-20 Thread Aurelien Jarno
On Sun, Jan 09, 2011 at 02:24:59PM +0100, Fred Boiteux wrote: > Hello, > > It's my first message here, and I'm not a git user, so I hope the > patch format will be good (I've done a "git diff -cached" in the qemu > tree). > I'm using the Qemu program with VNC I/O, and I had some problems

Re: [Qemu-devel] [PATCH 1/3] mainstone: fix name of the allocated memory for roms

2011-01-20 Thread Aurelien Jarno
On Thu, Jan 13, 2011 at 06:37:10PM +0300, Dmitry Eremin-Solenikov wrote: > Mainstone board has two flash chips (emulated by two ram regions), however > currently code tries to allocate them with the same name, which fails. > Fix that to make mainstone emulation work again. > > Signed-off-by: Dmitr

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Kevin Wolf
Am 20.01.2011 11:39, schrieb Yoshiaki Tamura: > 2011/1/20 Kevin Wolf : >> Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: >>> +return; >>> +} >>> + >>> +bdrv_aio_writev(bs, blk_req->reqs[0].sector, blk_req->reqs[0].qiov, >>> +blk_req->reqs[0].nb

Re: [Qemu-devel] [PATCH 0/8] Add save/restore support to ARM versatilepb devices

2011-01-20 Thread Aurelien Jarno
On Thu, Dec 23, 2010 at 05:19:50PM +, Peter Maydell wrote: > This patchset adds save/restore support to the devices used by the ARM > versatilepb board which didn't already support it. > > I did this in line with docs/migration.txt, and it seems to work OK. I'd > appreciate some review from so

Re: [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2

2011-01-20 Thread Edgar E. Iglesias
On Mon, Jan 10, 2011 at 07:23:41PM -0800, Richard Henderson wrote: > Changes since v1: > * No attempt to pack pos+len into one operand. Updated backends > to match this change. > > * Example in the README is a bit more complex. > > * Define an official tcg_scratch_alloc routine, used b

Re: [Qemu-devel] usb redirection status report

2011-01-20 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 07:15:47PM +0100, Hans de Goede wrote: > Hi All, > > As most of you know I'm working on usb redirection (making client usb > devices > accessible in guests over the network). > > I thought it would be a good idea to write a short status report. > > So fat the following h

Re: [Qemu-devel] [PATCH 6/7] target-i386: Use deposit operation.

2011-01-20 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 07:23:47PM -0800, Richard Henderson wrote: > Use this for assignment to the low byte or low word of a register. > > Signed-off-by: Richard Henderson > --- > target-i386/translate.c | 34 ++ > 1 files changed, 6 insertions(+), 28 deletions

Re: [Qemu-devel] Missing roms/seabios/Makefile and roms/vgabios/Makefile

2011-01-20 Thread Stefan Hajnoczi
On Thu, Jan 20, 2011 at 10:51:17AM +, Mateusz Loskot wrote: > On 19/01/11 18:07, Blue Swirl wrote: > >On Wed, Jan 19, 2011 at 12:44 PM, Mateusz Loskot wrote: > >>Hi, > >> > >>Running ./configure (under MinGW/MSYS) and symlink gives up trying to > >>create links to non-existing Makefiles in > >

Re: [Qemu-devel] Missing roms/seabios/Makefile and roms/vgabios/Makefile

2011-01-20 Thread Mateusz Loskot
On 19/01/11 18:07, Blue Swirl wrote: On Wed, Jan 19, 2011 at 12:44 PM, Mateusz Loskot wrote: Hi, Running ./configure (under MinGW/MSYS) and symlink gives up trying to create links to non-existing Makefiles in roms/seabios/Makefile roms/vgabios/Makefile Those directiories are actually git sub

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Yoshiaki Tamura
2011/1/20 Kevin Wolf : > Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: >> +        return; >> +    } >> + >> +    bdrv_aio_writev(bs, blk_req->reqs[0].sector, blk_req->reqs[0].qiov, >> +                    blk_req->reqs[0].nb_sectors, blk_req->reqs[0].cb, >> +              

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 09:44:05AM +0100, Gerd Hoffmann wrote: > Hi, > > >For (2), you cannot use bus=X,addr=Y because it makes assumptions about > >the PCI topology which may change in newer -M pc's. > > Why should the PCI topology for 'pc' ever change? > > We'll probably get q35 support some

[Qemu-devel] [PATCH] pci: fix pcibus_get_dev_path()

2011-01-20 Thread TeLeMan
The commit 6a7005d14b3c32d4864a718fb1cb19c789f58a5 used snprintf() incorrectly. Signed-off-by: TeLeMan --- hw/pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8d0e3df..9f8800d 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -2050,14 +2050,14 @@

Re: [Qemu-devel] Re: [PATCH] savevm: fix corruption in vmstate_subsection_load().

2011-01-20 Thread Yoshiaki Tamura
2011/1/20 Paolo Bonzini : > On 01/20/2011 09:57 AM, Yoshiaki Tamura wrote: >> >> 2011/1/20 Paolo Bonzini: >>> >>> On 12/14/2010 10:07 AM, Yoshiaki Tamura wrote: Although it's rare to happen in live migration, when the head of a byte stream contains 0x05 >>> >>> IIUC, this happens if

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-20 Thread Christoph Hellwig
On Thu, Jan 20, 2011 at 09:14:17AM +, Stefan Hajnoczi wrote: > Cool, this is much nicer than stashing away state like > bs->media_changed = 1. I just took a peek to see if we can remove > that field completely but IDE seems to use it internally. I think we could get rid of it in generic code,

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-20 Thread Christoph Hellwig
On Thu, Jan 20, 2011 at 08:56:07AM +, Stefan Hajnoczi wrote: > eject, change, block_passwd, and others call the device name argument > "device" instead of "id". In the interest of a consistent external API > it would be nice to use "device" for the block_resize command too. Sure, I can do tha

[Qemu-devel] Re: [PATCH 0/3 v2] allow online resizing of block devices

2011-01-20 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 06:26:49PM +0100, Juan Quintela wrote: > Does this handle the change of the rtc data? I can't see how/where. > (Not that I know if it is important at all until reboot). It doesn't. > cmos_init_hb() uses the size to guess the right geometry of the drives, > if we change th

[Qemu-devel] Re: [PATCH] pci: fix device paths

2011-01-20 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 09:24:10PM +0200, Michael S. Tsirkin wrote: > Patch a6a7005d14b3c32d4864a718fb1cb19c789f58a5 generated > broken device paths. We snprintf with a length shorter > than the output, so the last character is discarded and replaced > by the null byte. Fix it up by snprintf to a b

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Jan Kiszka
On 2011-01-19 20:32, Blue Swirl wrote: > On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori > wrote: >> On 01/19/2011 07:15 AM, Markus Armbruster wrote: >>> >>> So they interact with KVM (need kvm_state), and they interact with the >>> emulated PCI bus. Could you elaborate on the fundamental differ

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Kevin Wolf
Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: > +return; > +} > + > +bdrv_aio_writev(bs, blk_req->reqs[0].sector, blk_req->reqs[0].qiov, > +blk_req->reqs[0].nb_sectors, blk_req->reqs[0].cb, > +blk_req->reqs[0].opaque);

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-20 Thread Stefan Hajnoczi
On Wed, Jan 19, 2011 at 5:02 PM, Christoph Hellwig wrote: > Extend the change_cb callback with a reason argument, and use it > to tell drivers about size changes. > > Signed-off-by: Christoph Hellwig > > Index: qemu/block.c > === > -

[Qemu-devel] Re: [PATCH 0/3] pci: disable intx on flr/bus reset

2011-01-20 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 04:21:37PM +0900, Isaku Yamahata wrote: > So far pci_device_reset() is used for system reset. > In that case, interrupt controller is also reset so that > all irq is are deasserted. > But now pci bus reset/flr is supported, and in that case irq needs to be > disabled explici

Re: [Qemu-devel] Re: [PATCH] savevm: fix corruption in vmstate_subsection_load().

2011-01-20 Thread Paolo Bonzini
On 01/20/2011 09:57 AM, Yoshiaki Tamura wrote: 2011/1/20 Paolo Bonzini: On 12/14/2010 10:07 AM, Yoshiaki Tamura wrote: Although it's rare to happen in live migration, when the head of a byte stream contains 0x05 IIUC, this happens if you have VMS_STRUCT and the field after the VMS_STRUCT sta

Re: [Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-20 Thread Stefan Hajnoczi
On Tue, Jan 18, 2011 at 01:54:16PM +0530, M. Mohan Kumar wrote: > After creating a file object, its permission and ownership details are updated > as per client's request for both passthrough and none security model. But with > chrooted environment its not required for passthrough security model. M

Re: [Qemu-devel] Re: [PATCH] savevm: fix corruption in vmstate_subsection_load().

2011-01-20 Thread Yoshiaki Tamura
2011/1/20 Paolo Bonzini : > On 12/14/2010 10:07 AM, Yoshiaki Tamura wrote: >> >> Although it's rare to happen in live migration, when the head of a >> byte stream contains 0x05 > > IIUC, this happens if you have VMS_STRUCT and the field after the VMS_STRUCT > starts with 0x5. > > I think you should

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-20 Thread Stefan Hajnoczi
On Wed, Jan 19, 2011 at 06:02:48PM +0100, Christoph Hellwig wrote: > Index: qemu/hmp-commands.hx > === > --- qemu.orig/hmp-commands.hx 2011-01-19 17:47:10.444004409 +0100 > +++ qemu/hmp-commands.hx 2011-01-19 17:49:51.673254095 +0

  1   2   >