Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

2011-02-07 Thread Amit Shah
On (Tue) 08 Feb 2011 [01:40:09], Anthony Liguori wrote: > > > >However, virtio doesn't have vmstate yet. Are we willing to put vmstate > >in 0.14 to introduce subsections? I doubt that. > > Not, that's why I suggested reverting this change and pushing it to > 0.15. We're not going to fix it pro

Re: [Qemu-devel] Re: new->old version migration

2011-02-07 Thread Amit Shah
On (Tue) 08 Feb 2011 [01:44:32], Anthony Liguori wrote: > On 02/08/2011 01:07 AM, Amit Shah wrote: > >On (Tue) 08 Feb 2011 [08:42:14], Michael S. Tsirkin wrote: > >>I see. I'm unhappy with the facts that > >>1. if (feature) is spread all over the code instead > >>of just in migration > >>2. it

Re: [Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/08/2011 12:42 AM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2011 at 08:23:08PM -0600, Anthony Liguori wrote: On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: How does it? We need to know we are saving in 0.13 format and skip the new subsection, otherwise 0.13 will see a subsect

Re: [Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/08/2011 01:07 AM, Amit Shah wrote: On (Tue) 08 Feb 2011 [08:42:14], Michael S. Tsirkin wrote: I see. I'm unhappy with the facts that 1. if (feature) is spread all over the code instead of just in migration 2. it is also obfuscated with if (flow_control) instead of plain if (mig

[Qemu-devel] virtio-net crashes vs. old napi patch

2011-02-07 Thread Peter Lieven
Hi, as reported several times guests with virtio-net crash under heavy network load. There have been several patches submitted to the upstream kernel e.g: virtio_net: do not reschedule rx refill forever virtio_net: fix oom handling on tx udp/tcp/..: use limited socket backlog but that did not fi

Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:55 PM, Amit Shah wrote: On (Mon) 07 Feb 2011 [20:25:59], Anthony Liguori wrote: On 02/07/2011 08:14 PM, Amit Shah wrote: On (Sun) 06 Feb 2011 [11:50:46], Amit Shah wrote: On (Fri) 04 Feb 2011 [06:52:04], Anthony Liguori wrote: On 02/04/2011 02:54 A

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Aurelien Jarno
On Mon, Feb 07, 2011 at 08:09:52PM -0600, Anthony Liguori wrote: > On 02/07/2011 03:45 PM, Aurelien Jarno wrote: >> On Mon, Feb 07, 2011 at 03:02:03PM -0600, Anthony Liguori wrote: >> >>> As far as I'm concerned, Windows support is already deprecated as noone >>> has stepped up to enhance it or

Re: [Qemu-devel] AHCI in SeaBIOS

2011-02-07 Thread Gleb Natapov
On Mon, Feb 07, 2011 at 08:27:43PM -0600, Anthony Liguori wrote: > On 02/07/2011 05:57 PM, Alexander Graf wrote: > >Hi Kevin, > > > >Do you remember why you put AHCI in with default=n? I'd like to see it > >enabled in Qemu 0.14 and IIUC we use the default configuration for that. > > > >Speaking of

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Amit Shah
On (Tue) 08 Feb 2011 [08:42:14], Michael S. Tsirkin wrote: > I see. I'm unhappy with the facts that > 1. if (feature) is spread all over the code instead >of just in migration > 2. it is also obfuscated with if (flow_control) >instead of plain if (migrate to qemu < 0.14) >so removing it

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 08:23:08PM -0600, Anthony Liguori wrote: > On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: > >How does it? We need to know we are saving in 0.13 > >format and skip the new subsection, otherwise > >0.13 will see a subsection it does not recognize > >and exit. > > If you us

Re: [Qemu-devel] AHCI in SeaBIOS

2011-02-07 Thread Jonathan A. Kollasch
On Tue, Feb 08, 2011 at 12:57:41AM +0100, Alexander Graf wrote: > Hi Kevin, > > Do you remember why you put AHCI in with default=n? I'd like to see it > enabled in Qemu 0.14 and IIUC we use the default configuration for that. IIRC we haven't had conclusively successful tests of it on real hardwa

Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

2011-02-07 Thread Amit Shah
On (Mon) 07 Feb 2011 [20:25:59], Anthony Liguori wrote: > On 02/07/2011 08:14 PM, Amit Shah wrote: > >On (Sun) 06 Feb 2011 [11:50:46], Amit Shah wrote: > >>On (Fri) 04 Feb 2011 [06:52:04], Anthony Liguori wrote: > >>>On 02/04/2011 02:54 AM, Amit Shah wrote: > This can happen if a port gets unpl

Re: [Qemu-devel] Buildbot for qemu.git/master

2011-02-07 Thread Lucas Meneghel Rodrigues
On Mon, 2011-02-07 at 15:15 +, Stefan Hajnoczi wrote: > On Mon, Feb 7, 2011 at 3:02 PM, Richard W.M. Jones wrote: > > > > On Sat, Feb 05, 2011 at 04:36:11PM +, Stefan Hajnoczi wrote: > >> Occassionally a commit that breaks the build gets merged into > >> qemu.git/master. Build testing man

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Lucas Meneghel Rodrigues
On Mon, 2011-02-07 at 14:36 +, Stefan Hajnoczi wrote: > On Mon, Feb 7, 2011 at 1:00 PM, Alexander Graf wrote: > > > > On 05.02.2011, at 21:32, Stefan Hajnoczi wrote: > > > >> Here is the buildbot. It currently has a debian-x86_64 slave building > >> qemu.git/master every 24 hours: > >> http:/

Re: [Qemu-devel] AHCI in SeaBIOS

2011-02-07 Thread Anthony Liguori
On 02/07/2011 05:57 PM, Alexander Graf wrote: Hi Kevin, Do you remember why you put AHCI in with default=n? I'd like to see it enabled in Qemu 0.14 and IIUC we use the default configuration for that. Speaking of which - it would be awesome of we had a companion SeaBIOS release with Qemu 0.14,

Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:14 PM, Amit Shah wrote: On (Sun) 06 Feb 2011 [11:50:46], Amit Shah wrote: On (Fri) 04 Feb 2011 [06:52:04], Anthony Liguori wrote: On 02/04/2011 02:54 AM, Amit Shah wrote: This can happen if a port gets unplugged before guest has chance to initialise vqs. Rep

Re: [Qemu-devel] KVM call agenda for Feb 8

2011-02-07 Thread Anthony Liguori
On 02/07/2011 04:40 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. FYI, I won't be attending as I'm on holiday this week. Regards, Anthony Liguori thanks, -chris

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: How does it? We need to know we are saving in 0.13 format and skip the new subsection, otherwise 0.13 will see a subsection it does not recognize and exit. If you used subsections for flow control, presumably you would only send the new sav

Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

2011-02-07 Thread Amit Shah
On (Sun) 06 Feb 2011 [11:50:46], Amit Shah wrote: > On (Fri) 04 Feb 2011 [06:52:04], Anthony Liguori wrote: > > On 02/04/2011 02:54 AM, Amit Shah wrote: > > >This can happen if a port gets unplugged before guest has chance to > > >initialise vqs. > > > > > >Reported-by: Juan Quintela > > >Signed-of

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Anthony Liguori
On 02/07/2011 03:45 PM, Aurelien Jarno wrote: On Mon, Feb 07, 2011 at 03:02:03PM -0600, Anthony Liguori wrote: As far as I'm concerned, Windows support is already deprecated as noone has stepped up to enhance it or support for a number of years now. We shouldn't remove existing code that su

[Qemu-devel] [PATCH] Documentation: add Sheepdog disk images

2011-02-07 Thread MORITA Kazutaka
Signed-off-by: MORITA Kazutaka --- qemu-doc.texi | 52 1 files changed, 52 insertions(+), 0 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 22a8663..86e017c 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -407,6 +407,7 @@ sna

[Qemu-devel] [PATCH 14/15] kvm: Make kvm_state globally available

2011-02-07 Thread Jan Kiszka
KVM-assisted devices need access to it but we have no clean channel to distribute a reference. As a workaround until there is a better solution, export kvm_state for global use, though use should remain restricted to the mentioned scenario. Signed-off-by: Jan Kiszka --- kvm-all.c |2 +- kvm.

Re: [Qemu-devel] Support for BMIPS4380 CPU?

2011-02-07 Thread xeros
On Fri, 4 Feb 2011, Aurelien Jarno wrote: On Thu, Feb 03, 2011 at 10:05:36AM +0100, xeros wrote: Hi, Hi, I'd like to ask about support for newer CPUs in QEMU, like this one: system type : BCM3556C0 DTV platform processor : 0 cpu model : Broadcom BMIPS

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Avi Kivity
On 02/07/2011 02:27 PM, Glauber Costa wrote: > What exactly is your motivation to that ? I think mid/long-term we should be making machine initialization more common among architectures, not introducing more arch specific, or even worse, kvm specific parameters here. A general note: there are

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 09:08 AM, Avi Kivity wrote: On 02/07/2011 05:01 PM, Jan Kiszka wrote: > > On the other hand, we need a way to inject lost ticks into a > PeriodicTimer. If interrupt injection detects that an interrupt was > coalesced, we want the timer to schedule a new tick for us. Isn't abse

[Qemu-devel] RE: RFC: New API for PPC for vcpu mmu access

2011-02-07 Thread Yoder Stuart-B08248
> > A fixed array does mean you wouldn't have to worry about whether qemu > > supports the more advanced struct format if fields are added -- you > > can just unconditionally write it, as long as it's backwards > > compatible. Unless you hit the limit of the pre-determined array > > size, that is

[Qemu-devel] AHCI in SeaBIOS

2011-02-07 Thread Alexander Graf
Hi Kevin, Do you remember why you put AHCI in with default=n? I'd like to see it enabled in Qemu 0.14 and IIUC we use the default configuration for that. Speaking of which - it would be awesome of we had a companion SeaBIOS release with Qemu 0.14, so we don't have to fetch a random git snapshot

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Avi Kivity
On 02/07/2011 05:14 PM, Jan Kiszka wrote: On 2011-02-07 16:08, Avi Kivity wrote: > On 02/07/2011 05:01 PM, Jan Kiszka wrote: >>> >>> On the other hand, we need a way to inject lost ticks into a >>> PeriodicTimer. If interrupt injection detects that an interrupt was >>> coalesced, we want

Re: [Qemu-devel] Support for BMIPS4380 CPU?

2011-02-07 Thread Aurelien Jarno
On Sun, Feb 06, 2011 at 05:20:54PM +0100, xeros wrote: > On Fri, 4 Feb 2011, Aurelien Jarno wrote: > >> On Thu, Feb 03, 2011 at 10:05:36AM +0100, xeros wrote: >>> Hi, >> >> Hi, >> >>> I'd like to ask about support for newer CPUs in QEMU, like this one: >>> system type : BCM3556C0 DTV pl

Re: [Qemu-devel] Re: Porting QEMU to new hosts with unusual ABI (sizeof(long) != sizeof(void *))

2011-02-07 Thread Markus Armbruster
Stefan Weil writes: > Am 05.02.2011 16:35, schrieb Blue Swirl: [...] >> The patch changes also signed longs to uintptr_t. That could introduce >> regressions, so please use signed/unsigned as original. > > I changed the code manually, and there was only one location where > signed/unsigned made a

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Jan Kiszka
On 2011-02-07 13:27, Glauber Costa wrote: > On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka wrote: >> If kvmclock is used, which implies the kernel supports it, register a >> kvmclock device with the sysbus. Its main purpose is to save and restore >> the kernel state on migration, but this will also

[Qemu-devel] [PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp

2011-02-07 Thread Kevin Wolf
From: Stefan Weil Error report from cppcheck: block/vdi.c:122: error: Using sizeof for array given as function argument returns the size of pointer. block/vdi.c:128: error: Using sizeof for array given as function argument returns the size of pointer. Fix both by setting the correct size. The

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Edgar E. Iglesias
On Mon, Feb 07, 2011 at 02:03:50PM -0200, Marcelo Tosatti wrote: > On Mon, Feb 07, 2011 at 08:12:55AM -0200, Marcelo Tosatti wrote: > > > > One more thing I didn't mention on the email-thread or on IRC is > > > > that last time I checked, qemu with io-thread was performing > > > > significantly slo

[Qemu-devel] Re: [PATCH 0/7] Some more AHCI work v2

2011-02-07 Thread Kevin Wolf
Am 01.02.2011 15:51, schrieb Alexander Graf: > Clearly, AHCI as is is not perfect yet (intentionally, release early, > release often, remember?). This patch set makes it work with SeaBIOS > so booting Windows 7 works flawlessly for me. it also adds some speedups > and fixes a level based interrupts

Re: [Qemu-devel] [PATCH v2] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-07 Thread Peter Maydell
On 7 February 2011 15:30, Christophe Lyon wrote: > Note that I am unsure whether it's useful to have a default (ie non-ARM) > value for float16_default_nan and if the value I've used is right. We should set the default consistent with how we do it for the other types: special cases for various a

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Glauber Costa
On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka wrote: > If kvmclock is used, which implies the kernel supports it, register a > kvmclock device with the sysbus. Its main purpose is to save and restore > the kernel state on migration, but this will also allow to visualize it > one day. > > Signed-of

Re: [Qemu-devel] Buildbot for qemu.git/master

2011-02-07 Thread Richard W.M. Jones
On Sat, Feb 05, 2011 at 04:36:11PM +, Stefan Hajnoczi wrote: > Occassionally a commit that breaks the build gets merged into > qemu.git/master. Build testing manually across all host platforms is > not feasible for most developers. Remember we cover 32- and 64-bit > x86 Linux, Windows, and o

[Qemu-devel] [PATCH 00/15] [uq/master] Patch queue, part III

2011-02-07 Thread Jan Kiszka
This round is kind of an assorted collection: - make kvm_cpu_exec ready for qemu-kvm reuse - reworked vm_stop handling (as preparation for kvm_cpu_exec reuse) - the return of kvmclock - cleanups around KVM's dirty logging/slot management - style cleanups of cpus.c The patches related to the f

[Qemu-devel] Re: [SeaBIOS] IO APIC emulation failure with qemu-kvm

2011-02-07 Thread Ravi Kumar Kulkarni
On Sun, Feb 6, 2011 at 10:50 PM, Avi Kivity wrote: > On 02/04/2011 03:58 PM, Jan Kiszka wrote: >> >> >   when i run my kernel image with qemu-kvm it gives emulation error >> > failure >> >  trying to execute the code outside ROM or RAM at fec0(IO APIC base >> > address) >> >  but the same code

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-02-07 Thread Peter Maydell
On 31 January 2011 18:06, wrote: > For variants with rounding, fix cases where adding the rounding > constant could overflow. > > For VSHLL, fix bit mask. These two things are completely distinct -- please put them in separate patches. -- PMM

Re: [Qemu-devel] [PATCH] linux-user: Add support for -version option

2011-02-07 Thread Peter Maydell
Ping? On 20 January 2011 03:28, Peter Maydell wrote: > Add support to the linux-user qemu for the -version command line > option, bringing it into line with the system emulation qemu. > > Signed-off-by: Peter Maydell > --- >  linux-user/main.c |   17 + >  1 files changed, 13 inse

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Glauber Costa
On Mon, 2011-02-07 at 19:12 +0100, Jan Kiszka wrote: > On 2011-02-07 19:04, Glauber Costa wrote: > > On Mon, 2011-02-07 at 15:03 +0100, Jan Kiszka wrote: > >> On 2011-02-07 14:40, Glauber Costa wrote: > >>> On Mon, 2011-02-07 at 13:36 +0100, Jan Kiszka wrote: > On 2011-02-07 13:27, Glauber Cos

[Qemu-devel] [STABLE 0.14][PATCH 07/14] ahci: send init d2h fis on fis enable

2011-02-07 Thread Kevin Wolf
From: Alexander Graf The drive sends a d2h init fis on initialization. Usually, the guest doesn't receive fises yet at that point though, so the delivery is deferred. Let's reflect that by sending the init fis on fis receive enablement. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:58 AM, Avi Kivity wrote: On 02/07/2011 04:54 PM, Anthony Liguori wrote: Why the accumulated_ticks argument? Then the missing ticks is stored in the PeriodicTimer instead of storing it in the device state. That means we won't forget to save it in vmstate. It's convenie

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Jan Kiszka
On 2011-02-07 17:23, Paolo Bonzini wrote: > On 02/07/2011 05:03 PM, Marcelo Tosatti wrote: >> Is there any other issue that prevents turning CONFIG_IOTHREAD on by >> default? > > I think Windows support. > > Signal support is actually easy because we can "hack" the IPI as > "suspend the VCPU thre

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Stefan Hajnoczi
On Mon, Feb 7, 2011 at 2:44 PM, Alexander Graf wrote: > On 07.02.2011, at 15:36, Stefan Hajnoczi wrote: >> On Mon, Feb 7, 2011 at 1:00 PM, Alexander Graf wrote: >>> This is great - thank you! I'll try to get some ppc and s390x VMs set up to >>> run this. Do you have any plans to also integrate a

[Qemu-devel] Re: [PATCH] e1000: clear EOP for multi-buffer descriptors

2011-02-07 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > The e1000 spec says: if software statically allocates > buffers, and uses memory read to check for completed descriptors, it > simply has to zero the status byte in the descriptor to make it ready > for reuse by hardware. This is not a hardware requirement (moving the

Re: [Qemu-devel] [PATCH] correctly check ppr priority during interrupt injection

2011-02-07 Thread Yoshiaki Tamura
2011/2/6 Gleb Natapov : > > TPR blocks all interrupts in a priority class, so simple "less or > equal" check is not enough. > > Signed-off-by: Gleb Natapov > diff --git a/hw/apic.c b/hw/apic.c > index 2f8376a..cbac75d 100644 > --- a/hw/apic.c > +++ b/hw/apic.c > @@ -372,19 +372,33 @@ static int ap

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Paolo Bonzini
On 02/07/2011 05:03 PM, Marcelo Tosatti wrote: Is there any other issue that prevents turning CONFIG_IOTHREAD on by default? I think Windows support. Signal support is actually easy because we can "hack" the IPI as "suspend the VCPU thread+do work in the iothread context+resume the VCPU thre

[Qemu-devel] [PATCH 12/15] Introduce log_start/log_stop in CPUPhysMemoryClient

2011-02-07 Thread Jan Kiszka
From: Anthony PERARD In order to use log_start/log_stop with Xen as well in the vga code, this two operations have been put in CPUPhysMemoryClient. The two new functions cpu_physical_log_start,cpu_physical_log_stop are used in hw/vga.c and replace the kvm_log_start/stop. With this, vga does no l

Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18)

2011-02-07 Thread Eric Blake
[adding libvir-list as well] On 02/07/2011 08:44 AM, Alon Levy wrote: >>> I guess I'll wait a little longer for more feedback? Should I split >>> the enum property separately? it's only used by ccid-card-emualted atm. >> >> The only non-cosmetic concern I have about your series is the enum >> pro

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Jan Kiszka
On 2011-02-07 16:13, Avi Kivity wrote: >> >> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque); >> > > void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb); > > It is better to embed than to reference. And embedding means making the layout (at least the size

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-07 Thread Markus Armbruster
I haven't been able to follow the evolution of this series, my apologies if I'm missing things already discussed. Alon Levy writes: > Example usage: > > EnumTable foo_enum_table[] = { > {"bar", 1}, > {"buz", 2}, > {NULL, 0}, > }; > > DEFINE_PROP_ENUM("foo", State, foo, 1, foo_enum_ta

Re: [Qemu-devel] New stable branch information

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:09 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/05/2011 03:11 AM, Michael Tokarev wrote: 04.02.2011 15:25, Anthony Liguori wrote: To help make the stable branch more active than it has been in the past, I'd like to split the stable branch int

[Qemu-devel] [PATCH 5/9] linux-user/FLAT: fix auto-stack sizing

2011-02-07 Thread Mike Frysinger
The current auto-stack sizing works like it does on a NOMMU system; the problem is that this only works if the envp/argv arrays are fairly slim. On a desktop system, this is rarely the case, and can easily blow past the stack and into data/text regions as the default stack for FLAT progs is a mere

[Qemu-devel] RE: RFC: New API for PPC for vcpu mmu access

2011-02-07 Thread Yoder Stuart-B08248
> -Original Message- > From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow...@vger.kernel.org] > On Behalf Of Avi Kivity > Sent: Monday, February 07, 2011 11:14 AM > To: Alexander Graf > Cc: Wood Scott-B07421; Yoder Stuart-B08248; kvm-...@vger.kernel.org; > k...@vger.kernel.org; qemu-d

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Daniel Gollub
On Saturday, February 05, 2011 05:36:11 pm Stefan Hajnoczi wrote: > Daniel: I believe you run a buildbot for KVM. Thats correct. > Are you willing to > extend that setup to qemu.git/master? I wanted to ask in case it > makes sense to combine the two. Sure. I also planned to provide this ser

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:14 AM, Alon Levy wrote: Fair enough, so a patch that added enumeration through QMP would be acceptable? I'm not even sure that makes sense, would you mind outlining how you see this implemented? Before we write any code, we need to figure out what an enum is, how we want t

[Qemu-devel] [STABLE 0.14][PATCH 13/14] Add flag to indicate external users to block device

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti Certain operations such as drive_del or resize cannot be performed while external users (eg. block migration) reference the block device. Add a flag to indicate that. Signed-off-by: Marcelo Tosatti Signed-off-by: Kevin Wolf (cherry picked from commit db593f2565dc12442d6b

[Qemu-devel] Re: [PATCH 11/15] kvm: Remove unneeded memory slot reservation

2011-02-07 Thread Alex Williamson
On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka wrote: > The number of slots and the location of private ones changed several > times in KVM's early days. However, it's stable since 2.6.29 (our > required baseline), and slots 8..11 are no longer reserved since then. > So remove this unneeded restrict

Re: [Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Luiz Capitulino
On Sat, 5 Feb 2011 20:32:06 + Stefan Hajnoczi wrote: > Here is the buildbot. It currently has a debian-x86_64 slave building > qemu.git/master every 24 hours: > http://buildbot.vmsplice.net/ Nice, what about also building maintainers' branches, such as the block one?

[Qemu-devel] [PATCHv2] correctly check ppr priority during interrupt injection

2011-02-07 Thread Gleb Natapov
TPR blocks all interrupts in a priority class, so simple "less or equal" check is not enough. Signed-off-by: Gleb Natapov Reviewed-by: Jan Kiszka --- v1->v2: - much more braces diff --git a/hw/apic.c b/hw/apic.c index 2f8376a..218d1bb 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -372,19 +372,36

[Qemu-devel] Re: [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/post_run

2011-02-07 Thread Alexander Graf
On 07.02.2011, at 12:19, Jan Kiszka wrote: > We do not check them, and the only arch with non-empty implementations > always returns 0 (this is also true for qemu-kvm). > > Signed-off-by: Jan Kiszka > CC: Alexander Graf Yeah, if there's anything going wrong we should do cpu_abort anyways. Ac

[Qemu-devel] Re: [SeaBIOS] IO APIC emulation failure with qemu-kvm

2011-02-07 Thread Ravi Kumar Kulkarni
On Mon, Feb 7, 2011 at 2:19 PM, Avi Kivity wrote: > On 02/07/2011 10:33 AM, Ravi Kumar Kulkarni wrote: >> >> On Sun, Feb 6, 2011 at 10:50 PM, Avi Kivity  wrote: >>> >>> >  On 02/04/2011 03:58 PM, Jan Kiszka wrote: >> > > >>  >     when i run my kernel image with qemu-kvm it gives

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Glauber Costa
On Mon, 2011-02-07 at 15:03 +0100, Jan Kiszka wrote: > On 2011-02-07 14:40, Glauber Costa wrote: > > On Mon, 2011-02-07 at 13:36 +0100, Jan Kiszka wrote: > >> On 2011-02-07 13:27, Glauber Costa wrote: > >>> On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka wrote: > If kvmclock is used, which impli

[Qemu-devel] [RFC] prep: enable irq sharing on ide again

2011-02-07 Thread Alexander Graf
The new ISA infrastructure checks for potential irq sharing bugs on interrupt lines, because usually irq lines on isa can't be shared. The PREP spec however mandates that the irq lines for both IDE ports are shared and according to Aurelien this also used to work just fine. So let's add a way to

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Jan Kiszka
On 2011-02-07 19:04, Glauber Costa wrote: > On Mon, 2011-02-07 at 15:03 +0100, Jan Kiszka wrote: >> On 2011-02-07 14:40, Glauber Costa wrote: >>> On Mon, 2011-02-07 at 13:36 +0100, Jan Kiszka wrote: On 2011-02-07 13:27, Glauber Costa wrote: > On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka w

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-07 Thread Scott Wood
On Mon, 7 Feb 2011 17:49:51 +0100 Alexander Graf wrote: > > On 07.02.2011, at 17:40, Yoder Stuart-B08248 wrote: > > > Suggested change to this would be to have Qemu set tlb_type as > > an _input_ argument. If KVM supports it, that type gets used, > > else an error is returned.This would

[Qemu-devel] [PATCH 6/9] linux-user/FLAT: allow targets to override FLAT processing

2011-02-07 Thread Mike Frysinger
This brings flatload.c more in line with the current Linux FLAT loader which allows targets to handle various FLAT aspects in their own way. For the common behavior, the new functions get stubbed out. Signed-off-by: Mike Frysinger --- Makefile.target |2 +- linux-user/flatload.c

Re: [Qemu-devel] [PATCH] correctly check ppr priority during interrupt injection

2011-02-07 Thread Jan Kiszka
On 2011-02-07 00:45, Yoshiaki Tamura wrote: > 2011/2/6 Gleb Natapov : >> >> TPR blocks all interrupts in a priority class, so simple "less or >> equal" check is not enough. >> >> Signed-off-by: Gleb Natapov >> diff --git a/hw/apic.c b/hw/apic.c >> index 2f8376a..cbac75d 100644 >> --- a/hw/apic.c >

[Qemu-devel] Re: [PATCH 0/7] Some more AHCI work v2

2011-02-07 Thread Jan Kiszka
On 2011-02-07 11:56, Kevin Wolf wrote: > Am 01.02.2011 15:51, schrieb Alexander Graf: >> Clearly, AHCI as is is not perfect yet (intentionally, release early, >> release often, remember?). This patch set makes it work with SeaBIOS >> so booting Windows 7 works flawlessly for me. it also adds some s

Re: [Qemu-devel] New stable branch information

2011-02-07 Thread Markus Armbruster
Anthony Liguori writes: > On 02/05/2011 03:11 AM, Michael Tokarev wrote: >> 04.02.2011 15:25, Anthony Liguori wrote: >> >>> To help make the stable branch more active than it has been in the past, >>> I'd like to split the stable branch into a separate tree to allow the >>> tree to develop a

[Qemu-devel] [KVM] guest remote migration fails

2011-02-07 Thread pradeep
Migration of guest(both local and remote) fails with 2.6.37-rc8 host Test Procedure: --- A is the source host, B is the destination host: 1. Start the VM on B with the exact same parameters as the VM on A, in migration-listen mode: B: -incoming tcp:0: (or other PORT)) 2. S

[Qemu-devel] [PATCH 10/15] kvm: x86: Catch and report failing IRQ and NMI injections

2011-02-07 Thread Jan Kiszka
We do not need to abort, but the user should be notified that weird things go on. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 8668cb3..0aa0a41 100644 --- a/tar

[Qemu-devel] [PATCH 14/14] block: enable in_use flag

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti Set block device in use during block migration, disallow drive_del and bdrv_truncate for in use devices. Signed-off-by: Marcelo Tosatti Signed-off-by: Kevin Wolf --- block-migration.c |2 ++ block.c |2 ++ blockdev.c|4 3 files changed,

[Qemu-devel] [PATCH 07/15] kvm: Separate TCG from KVM cpu execution

2011-02-07 Thread Jan Kiszka
Mixing up TCG bits with KVM already led to problems around eflags emulation on x86. Moreover, quite some code that TCG requires on cpu enty/exit is useless for KVM. So dispatch between tcg_cpu_exec and kvm_cpu_exec as early as possible. The core logic of cpu_halted from cpu_exec is added to kvm_ar

[Qemu-devel] [PATCH 08/14] ahci: Implement HBA reset

2011-02-07 Thread Kevin Wolf
From: Alexander Graf The ahci code was missing its soft reset functionality. This wasn't really an issue for Linux guests, but Windows gets confused when the controller doesn't reset when it tells it so. Using this patch I can now successfully boot Windows 7 from AHCI using AHCI enabled SeaBIOS.

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Avi Kivity
On 02/07/2011 03:23 PM, Anthony Liguori wrote: If it doesn't solve the majority of the problems it isn't very useful IMO. It's a good first step, but not sufficient for real world use with overcommit. Even if we have a way to detect coalescing, we still need to make sure we don't lose ticks

[Qemu-devel] [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/post_run

2011-02-07 Thread Jan Kiszka
We do not check them, and the only arch with non-empty implementations always returns 0 (this is also true for qemu-kvm). Signed-off-by: Jan Kiszka CC: Alexander Graf --- kvm.h |5 ++--- target-i386/kvm.c |8 ++-- target-ppc/kvm.c |6 ++ target-s390x/kvm.c |

Re: [Qemu-devel] Re: Porting QEMU to new hosts with unusual ABI (sizeof(long) != sizeof(void *))

2011-02-07 Thread Stefan Weil
Am 07.02.2011 08:23, schrieb Markus Armbruster: Stefan Weil writes: Am 05.02.2011 16:35, schrieb Blue Swirl: [...] The patch changes also signed longs to uintptr_t. That could introduce regressions, so please use signed/unsigned as original. I changed the code manually, and there was only o

[Qemu-devel] Re: [PATCH 02/17] lm32: translation routines

2011-02-07 Thread Edgar E. Iglesias
On Mon, Feb 07, 2011 at 11:00:38PM +0100, Michael Walle wrote: > Hi Edgar. > > first of all let me thank you for the review. > > On Mon, Feb 07 2011, 19:41:25, Edgar E. Iglesias wrote: > > > +#define JMP_NOJMP0 > > > +#define JMP_DIRECT 1 > > > +#define JMP_INDIRECT 2 > > > > These don't s

[Qemu-devel] [PATCH 6/7] ccid: add docs

2011-02-07 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. Signed-off-by: Alon Levy --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100

[Qemu-devel] Re: [PATCH 02/17] lm32: translation routines

2011-02-07 Thread Edgar E. Iglesias
On Mon, Jan 31, 2011 at 01:30:31AM +0100, Michael Walle wrote: > This patch adds the main translation routine. All opcodes of the > LatticeMico32 processor are supported and translated to TCG ops. > > Signed-off-by: Michael Walle Hi Michael, Your port looks very nice. I've only got a couple of

[Qemu-devel] [PATCH 11/14] blockdev: add refcount to DriveInfo

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti The host part of a block device can be deleted with in progress block migration. To fix this, add a reference count to DriveInfo, freeing resources on last reference. Signed-off-by: Marcelo Tosatti CC: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c |

Re: [Qemu-devel] Re: Porting QEMU to new hosts with unusual ABI (sizeof(long) != sizeof(void *))

2011-02-07 Thread Markus Armbruster
Stefan Weil writes: > Am 07.02.2011 08:23, schrieb Markus Armbruster: >> Stefan Weil writes: >>> Am 05.02.2011 16:35, schrieb Blue Swirl: >> [...] The patch changes also signed longs to uintptr_t. That could introduce regressions, so please use signed/unsigned as original. >>> >>> I ch

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Alexander Graf
On 05.02.2011, at 21:32, Stefan Hajnoczi wrote: > Here is the buildbot. It currently has a debian-x86_64 slave building > qemu.git/master every 24 hours: > http://buildbot.vmsplice.net/ This is great - thank you! I'll try to get some ppc and s390x VMs set up to run this. Do you have any plans

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Marcelo Tosatti
On Mon, Feb 07, 2011 at 08:12:55AM -0200, Marcelo Tosatti wrote: > > > One more thing I didn't mention on the email-thread or on IRC is > > > that last time I checked, qemu with io-thread was performing > > > significantly slower than non io-thread builds. That was with > > > TCG emulation (not kvm

Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18)

2011-02-07 Thread Alon Levy
On Mon, Feb 07, 2011 at 07:12:52AM -0600, Anthony Liguori wrote: > On 02/07/2011 05:03 AM, Alon Levy wrote: > >Hi, > > > > I have a v19 waiting to be sent, but it's basically the same just > >with patches folded were appropriate, and the fixes Markus pointed > >out for the Enumeration property typ

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Avi Kivity
On 02/07/2011 03:11 PM, Anthony Liguori wrote: On 02/07/2011 06:34 AM, Avi Kivity wrote: On 02/04/2011 10:56 AM, Jan Kiszka wrote: > > This should be a rare event. If you are missing 50% of your > notifications, not amount of gradual catchup is going to help you out. But that's the only t

[Qemu-devel] Re: [PATCH 02/17] lm32: translation routines

2011-02-07 Thread Alexander Graf
On 07.02.2011, at 23:55, Michael Walle wrote: > On Mon, Feb 07 2011, 23:20:33, Edgar E. Iglesias wrote: >> Yes, I found the nop tracking handy too but It exposes a way for guests >> to completely abort the vm with valid code. On microblaze, even guest >> userspace can trig the cpu_abort. Your por

[Qemu-devel] [PATCH 04/15] Improve vm_stop reason declarations

2011-02-07 Thread Jan Kiszka
Define and use dedicated constants for vm_stop reasons, they actually have nothing to do with the EXCP_* defines used so far. At this chance, specify more detailed reasons so that VM state change handlers can evaluate them. Signed-off-by: Jan Kiszka --- cpus.c |4 ++-- gdbstub.c

[Qemu-devel] [PATCH 07/14] ahci: send init d2h fis on fis enable

2011-02-07 Thread Kevin Wolf
From: Alexander Graf The drive sends a d2h init fis on initialization. Usually, the guest doesn't receive fises yet at that point though, so the delivery is deferred. Let's reflect that by sending the init fis on fis receive enablement. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 7/9] linux-user: implement sched_{g, s}etaffinity

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index bb6ef43..4412a9b 100644 --- a/linux-user/syscall.c +++ b/linux-user/s

[Qemu-devel] [PATCH 8/9] user: speed up init_paths a bit

2011-02-07 Thread Mike Frysinger
The current init_paths code will attempt to opendir() every single file it finds. This can obviously generated a huge number of syscalls with even a moderately small sysroot that will fail. Since the readdir() call provides the file type in the struct itself, use it. On my system, this prevents

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:57 AM, Jan Kiszka wrote: There should rather be a special vmstate struct for PeriodicTimer, just like we already have for normal timers. Agreed. It's convenient because then if we lose ticks in the PeriodicTimer layer, the devices have instance access to that info. When

Re: [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions.

2011-02-07 Thread Christophe Lyon
On 07.02.2011 17:08, Peter Maydell wrote: > On 31 January 2011 18:06, wrote: >> From: Christophe Lyon >> >> Handle unsigned variant of VQ(R)SHRN instructions. > > This patch appears to be modifying a section of code > that was already patched by 2/8 in this series. That's > too confusing to rev

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 02:56:50PM -0600, Anthony Liguori wrote: > On 02/07/2011 01:53 PM, Michael S. Tsirkin wrote: > >On Mon, Feb 07, 2011 at 01:33:57PM -0600, Anthony Liguori wrote: > >>On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: > >>>New thread stated intentionally, the original patch is

[Qemu-devel] [STABLE 0.14][PATCH 10/14] block-migration: actually disable dirty tracking on cleanup

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti Call to set_dirty_tracking() is misplaced. Signed-off-by: Marcelo Tosatti Signed-off-by: Kevin Wolf (cherry picked from commit 8f794c557c4b51c7a957d47ef6a2230114bb9e79) --- block-migration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bloc

[Qemu-devel] [PATCH 10/14] block-migration: actually disable dirty tracking on cleanup

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti Call to set_dirty_tracking() is misplaced. Signed-off-by: Marcelo Tosatti Signed-off-by: Kevin Wolf --- block-migration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block-migration.c b/block-migration.c index c9d3e81..483ca7b 100644 --- a

[Qemu-devel] Re: [PATCH 02/17] lm32: translation routines

2011-02-07 Thread Michael Walle
On Mon, Feb 07 2011, 23:20:33, Edgar E. Iglesias wrote: > Yes, I found the nop tracking handy too but It exposes a way for guests > to completely abort the vm with valid code. On microblaze, even guest > userspace can trig the cpu_abort. Your port doesn't have an MMU so guest > userland can probabl

  1   2   3   >