[Qemu-devel] Re: [PATCH 07/15] kvm: Separate TCG from KVM cpu execution

2011-02-08 Thread Jan Kiszka
On 2011-02-09 00:39, Marcelo Tosatti wrote: > On Mon, Feb 07, 2011 at 12:19:18PM +0100, Jan Kiszka wrote: >> Mixing up TCG bits with KVM already led to problems around eflags >> emulation on x86. Moreover, quite some code that TCG requires on cpu >> enty/exit is useless for KVM. So dispatch between

[Qemu-devel] Re: [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 07:05 PM, Richard Henderson wrote: (Which is probably a mistake from a translator point of view -- there's no reason we can't emulate 16-bit operations with 32-bit operations given that the high bits are ignorable.) Not really, you never know if the guest is going to use a 66 pref

[Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 09:24 PM, Jan Kiszka wrote: Hmm, does this path actually trigger? If yes, does it happen to obsolete the global exit_request hack? No idea, I wanted to make the initial work as mechanical as possible. By inspection, cpu_stop_current is doing cpu_single_env->stopped = 1

[Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 09:24 PM, Jan Kiszka wrote: Hmm, does this path actually trigger? If yes, does it happen to obsolete the global exit_request hack? No idea, I wanted to make the initial work as mechanical as possible. By inspection, cpu_stop_current is doing cpu_single_env->stopped = 1

[Qemu-devel] /dev/mtd emulation

2011-02-08 Thread Anton L. Vinokurov
Dear Developers, I am struggling to run some exotic box firmware inside of QEMU. Originally it is i386 processor, MontaVista-Linux based appliance. I was able to boot and run it, but main guest application fails while reading from /dev/mtd1 (generic open()). To my understanding, it is a some fo

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-08 Thread Riku Voipio
On Sat, Feb 05, 2011 at 10:49:51PM +0100, Laurent Vivier wrote: > >On 02/03/2011 12:16 PM, Laurent Vivier wrote: > >> And this one ? > >> > >> linux-user: correct core dump format > >> > >> http://patchwork.ozlabs.org/patch/78464/ Actually that patch is not ok. The issues you fix on m68k appear on

[Qemu-devel] Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index

2011-02-08 Thread Lai Jiangshan
On 02/01/2011 09:29 PM, Luiz Capitulino wrote: > On Thu, 27 Jan 2011 16:20:27 +0800 > Lai Jiangshan wrote: > >> "cpu-index" which uses hyphen is better name. >> >> Signed-off-by: Lai Jiangshan > > It looks ok from a quick pass, but I can't apply it on current master, what > commit HEAD did you

[Qemu-devel] [PATCH] [MIPS] Clear softfpu exception state for round, trunc, ceil and floor

2011-02-08 Thread Chris Dearman
Signed-off-by: Chris Dearman --- target-mips/op_helper.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 41abd57..e044db4 100644 --- a/target-mips/op_helper.c +++ b/target-mips/op_helper.c @@ -2294,6

[Qemu-devel] [MIPS] Clear softfpu exception state for round, trunc, ceil and floor

2011-02-08 Thread Chris Dearman
MIPS FPU instructions should start with a clean softfpu status. This is done for the arithmetic operations and cvt instructions, but not for round, trunc, ceil and floor. Chris -- Chris Dearman Desk: +1 408 530 5092 Cell: +1 408 398 5531 MIPS Technologies Inc955 East A

[Qemu-devel] [PATCH uq/master -v2 2/2] KVM, MCE, unpoison memory address across reboot

2011-02-08 Thread Huang Ying
In Linux kernel HWPoison processing implementation, the virtual address in processes mapping the error physical memory page is marked as HWPoison. So that, the further accessing to the virtual address will kill corresponding processes with SIGBUS. If the error physical memory page is used by a KV

[Qemu-devel] [PATCH uq/master -v2 1/2] Add qemu_ram_remap

2011-02-08 Thread Huang Ying
qemu_ram_remap() unmaps the specified RAM pages, then re-maps these pages again. This is used by KVM HWPoison support to clear HWPoisoned page tables across guest rebooting, so that a new page may be allocated later to recover the memory error. Signed-off-by: Huang Ying --- cpu-all.h|4

[Qemu-devel] Re: [PATCH 04/15] Improve vm_stop reason declarations

2011-02-08 Thread Marcelo Tosatti
On Mon, Feb 07, 2011 at 12:19:15PM +0100, Jan Kiszka wrote: > index d6556c9..3397566 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -2194,14 +2194,14 @@ static void gdb_vm_state_change(void *opaque, int > running, int reason) > const char *type; > int ret; > > -if (running || (rea

Re: [Qemu-devel] Guest bootup time varies with simulated memory size

2011-02-08 Thread Mulyadi Santosa
Hi Adnan... On Wed, Feb 9, 2011 at 05:45, Adnan Khaleel wrote: > In trying out various simulated memory sized in Qemu, there is a noticeable > increase in guest bootup times with more memory. My metric of measuring how > long linux takes to boot is probably not the most consistent but here is > w

[Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c

2011-02-08 Thread Marcelo Tosatti
On Mon, Feb 07, 2011 at 12:19:13PM +0100, Jan Kiszka wrote: > Avoid duplicate use of the function name cpu_has_work, it's confusing. > Refactor cpu_has_work to cpu_is_idle and do the same with > any_cpu_has_work. > > Signed-off-by: Jan Kiszka > --- > cpus.c | 43 +++

[Qemu-devel] Re: [PATCH 07/15] kvm: Separate TCG from KVM cpu execution

2011-02-08 Thread Marcelo Tosatti
On Mon, Feb 07, 2011 at 12:19:18PM +0100, Jan Kiszka wrote: > Mixing up TCG bits with KVM already led to problems around eflags > emulation on x86. Moreover, quite some code that TCG requires on cpu > enty/exit is useless for KVM. So dispatch between tcg_cpu_exec and > kvm_cpu_exec as early as poss

[Qemu-devel] Guest bootup time varies with simulated memory size

2011-02-08 Thread Adnan Khaleel
In trying out various simulated memory sized in Qemu, there is a noticeable increase in guest bootup times with more memory. My metric of measuring how long linux takes to boot is probably not the most consistent but here is what I've observed. In Qemu 0.12.5 512m ~ 4 mins 2048m ~ 7 mins I

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-02-08 Thread Michael Walle
Am Dienstag 08 Februar 2011, 18:32:57 schrieb Richard Henderson: > On 01/30/2011 04:30 PM, Michael Walle wrote: > > +if (dc->format == OP_FMT_RI) { > > +tcg_gen_brcondi_tl(cond, cpu_R[rY], sign_extend(dc->imm16, 16), > > l1); +} else { > > +tcg_gen_brcond_tl(cond, cpu_R[rY],

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Anthony Liguori
On 02/08/2011 11:13 AM, Markus Armbruster wrote: Chris Wright writes: [...] - qdev/vmstate both examples of partially completed work that need more attention As far as qdev's concerned, I can see two kinds of to-dos: * Further develop qdev so that more of the machine init code c

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Anthony Liguori
On 02/08/2011 01:02 PM, Peter Maydell wrote: On 8 February 2011 17:13, Markus Armbruster wrote: As far as qdev's concerned, I can see two kinds of to-dos: * Further develop qdev so that more of the machine init code can becomes qdev declarations. Specific ideas welcome. Patches even mo

[Qemu-devel] Re: [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff

2011-02-08 Thread Jan Kiszka
On 2011-02-08 18:18, Paolo Bonzini wrote: > Ok, so let's start the dance... > > These are the generic parts of the iothread-for-win32 work I made > last year, rebased to today's qemu (qemu-kvm.git/uq/master merged > with qemu.git/master, because it conflicts with some patches from Jan). More brea

[Qemu-devel] Re: [CFT PATCH 05/12] always qemu_cpu_kick after unhalting a cpu

2011-02-08 Thread Jan Kiszka
On 2011-02-08 18:18, Paolo Bonzini wrote: > This ensures env->halt_cond is broadcast, and the loop in > qemu_tcg_wait_io_event and qemu_kvm_wait_io_event is exited > naturally rather than through a timeout. > > Signed-off-by: Paolo Bonzini > --- > hw/apic.c |1 + > hw/pc.c

[Qemu-devel] Re: [CFT PATCH 04/12] change qemu_thread_equal API to always compare with current thread

2011-02-08 Thread Jan Kiszka
On 2011-02-08 18:18, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > cpus.c| 10 ++ > qemu-thread.c |4 ++-- > qemu-thread.h |2 +- > 3 files changed, 5 insertions(+), 11 deletions(-) > > diff --git a/cpus.c b/cpus.c > index 474be16..c1d0ceb 100644 > --- a/c

[Qemu-devel] Re: [CFT PATCH 03/12] inline cpu_halted into sole caller

2011-02-08 Thread Jan Kiszka
On 2011-02-08 18:18, Paolo Bonzini wrote: > All implementations are now the same except SH, which can fit in > the default implementation easily. The newly added flag will not make > much sense on non-SH platforms, but I left it anyway. Alternatively you > could #ifdef it out on non-SH. I think

[Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true

2011-02-08 Thread Jan Kiszka
On 2011-02-08 18:18, Paolo Bonzini wrote: > Sometimes vcpus are stopped directly without going through ->stop = 1. > Exit the VCPU execution loop in this case as well. > > Signed-off-by: Paolo Bonzini > --- > cpus.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-08 Thread Peter Maydell
On 8 February 2011 18:53, Peter Maydell wrote: > On 8 February 2011 17:51, Christophe Lyon wrote: >> - this means implementing float16ToCommonNaN, thus float16_is_signaling_nan() > > ...like that, yes. I have a slightly-tested implementation of these functions on my hard disk now; I'll try to fi

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-02-08 Thread Edgar E. Iglesias
On Tue, Feb 08, 2011 at 09:32:57AM -0800, Richard Henderson wrote: > On 01/30/2011 04:30 PM, Michael Walle wrote: > > +if (dc->format == OP_FMT_RI) { > > +tcg_gen_brcondi_tl(cond, cpu_R[rY], sign_extend(dc->imm16, 16), > > l1); > > +} else { > > +tcg_gen_brcond_tl(cond, cpu

[Qemu-devel] [CFT PATCH 05/12] always qemu_cpu_kick after unhalting a cpu

2011-02-08 Thread Paolo Bonzini
This ensures env->halt_cond is broadcast, and the loop in qemu_tcg_wait_io_event and qemu_kvm_wait_io_event is exited naturally rather than through a timeout. Signed-off-by: Paolo Bonzini --- hw/apic.c |1 + hw/pc.c|1 + hw/ppc.c |2 ++ hw/sun4m.c

[Qemu-devel] [CFT PATCH 04/12] change qemu_thread_equal API to always compare with current thread

2011-02-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpus.c| 10 ++ qemu-thread.c |4 ++-- qemu-thread.h |2 +- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/cpus.c b/cpus.c index 474be16..c1d0ceb 100644 --- a/cpus.c +++ b/cpus.c @@ -857,11 +857,8 @@ void qemu_cpu_kick_sel

Re: [Qemu-devel] [CFT PATCH 02/12] cris, microblaze: use cpu_has_work

2011-02-08 Thread Edgar E. Iglesias
On Tue, Feb 08, 2011 at 06:18:19PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Thanks, I've applied this one. Cheers > --- > target-cris/exec.h |4 +--- > target-microblaze/exec.h |4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/targe

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Alexander Graf
On 08.02.2011, at 18:13, Markus Armbruster wrote: > Chris Wright writes: > > [...] >> - qdev/vmstate both examples of partially completed work that need more >> attention > > As far as qdev's concerned, I can see two kinds of to-dos: > > * Further develop qdev so that more of the machine i

[Qemu-devel] [CFT PATCH 10/12] do not use timedwait on qemu_pause_cond

2011-02-08 Thread Paolo Bonzini
all_vcpus_paused can start returning true after penv->stopped changes from 0 to 1. When this is done, qemu_pause_cond is always signaled. Signed-off-by: Paolo Bonzini --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 3d12c50..97ba166 1006

Re: [Qemu-devel] [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff

2011-02-08 Thread Aurelien Jarno
On Tue, Feb 08, 2011 at 06:18:17PM +0100, Paolo Bonzini wrote: > Ok, so let's start the dance... > > These are the generic parts of the iothread-for-win32 work I made > last year, rebased to today's qemu (qemu-kvm.git/uq/master merged > with qemu.git/master, because it conflicts with some patches

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Aurelien Jarno
On Tue, Feb 08, 2011 at 06:13:53PM +0100, Markus Armbruster wrote: > Chris Wright writes: > > [...] > > - qdev/vmstate both examples of partially completed work that need more > > attention > > As far as qdev's concerned, I can see two kinds of to-dos: > > * Further develop qdev so that more

[Qemu-devel] [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true

2011-02-08 Thread Paolo Bonzini
Sometimes vcpus are stopped directly without going through ->stop = 1. Exit the VCPU execution loop in this case as well. Signed-off-by: Paolo Bonzini --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index c1d0ceb..5b13961 100644 --- a/cpus.c +

[Qemu-devel] [CFT PATCH 02/12] cris, microblaze: use cpu_has_work

2011-02-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-cris/exec.h |4 +--- target-microblaze/exec.h |4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/target-cris/exec.h b/target-cris/exec.h index 93ce768..34c0132 100644 --- a/target-cris/exec.h +++ b/target-cris/exec.h @@ -3

[Qemu-devel] [CFT PATCH 12/12] iothread stops the vcpu thread via IPI

2011-02-08 Thread Paolo Bonzini
This "if" has no reason to exist in the iothread world, and it breaks Wine because of the slowness of the thread primitives there. Signed-off-by: Paolo Bonzini --- cpus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 67fd672..3d74ad7 100644 --- a

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Peter Maydell
On 8 February 2011 17:13, Markus Armbruster wrote: > As far as qdev's concerned, I can see two kinds of to-dos: > > * Further develop qdev so that more of the machine init code can becomes >  qdev declarations.  Specific ideas welcome.  Patches even more, as >  always. > > * Convert the remaining

[Qemu-devel] [CFT PATCH 09/12] do not use timedwait on qemu_system_cond

2011-02-08 Thread Paolo Bonzini
qemu_main_loop_start is the only place where qemu_system_ready is set to 1, and it signals qemu_system_cond. Signed-off-by: Paolo Bonzini --- cpus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index be3d82d..3d12c50 100644 --- a/cpus.c +++ b/cpus.c

[Qemu-devel] [CFT PATCH 03/12] inline cpu_halted into sole caller

2011-02-08 Thread Paolo Bonzini
All implementations are now the same except SH, which can fit in the default implementation easily. The newly added flag will not make much sense on non-SH platforms, but I left it anyway. Alternatively you could #ifdef it out on non-SH. This reduces the number of places that have to be audited

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-08 Thread Peter Maydell
On 8 February 2011 17:51, Christophe Lyon wrote: > On 08.02.2011 16:59, Peter Maydell wrote: >> This is float32_to_float16() but it looks like you've missed >> float16_to_float32() ? > > Well, actually I somewhat managed to persuade myself that it was not > necessary to patch float16_to_float32()

[Qemu-devel] [CFT PATCH 01/12] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond

2011-02-08 Thread Paolo Bonzini
From: Anthony Liguori Signed-off-by: Anthony Liguori --- cpus.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 6a85dc8..474be16 100644 --- a/cpus.c +++ b/cpus.c @@ -667,8 +667,10 @@ int qemu_init_main_loop(void) if (ret) return re

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Markus Armbruster
Chris Wright writes: [...] > - qdev/vmstate both examples of partially completed work that need more > attention As far as qdev's concerned, I can see two kinds of to-dos: * Further develop qdev so that more of the machine init code can becomes qdev declarations. Specific ideas welcome.

[Qemu-devel] [CFT PATCH 07/12] always signal pause_cond after stopping a VCPU

2011-02-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 5b13961..ee2a6cc 100644 --- a/cpus.c +++ b/cpus.c @@ -980,8 +980,10 @@ static void qemu_system_vmstop_request(int reason) void cpu_stop_current(void) { if

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-02-08 Thread Richard Henderson
On 01/31/2011 12:33 AM, Aurelien Jarno wrote: > This week-end I have tested it emulating an x86-64 machine on x86-64, > with all the patch series applied. I have measured the boot time from > the bootloader up to the graphical environment of a Debian installation > I used -snapshot to make sure the

[Qemu-devel] [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff

2011-02-08 Thread Paolo Bonzini
Ok, so let's start the dance... These are the generic parts of the iothread-for-win32 work I made last year, rebased to today's qemu (qemu-kvm.git/uq/master merged with qemu.git/master, because it conflicts with some patches from Jan). I never tested them too much, and that's one of the reasons wh

[Qemu-devel] [CFT PATCH 11/12] do not use timedwait on qemu_cpu_cond

2011-02-08 Thread Paolo Bonzini
Whenever env->created becomes true, qemu_cpu_cond is signaled by {kvm,tcg}_cpu_thread_fn. I change qemu_cond_signal to qemu_cond_broadcast because right now there is only one listened but, if there were more, there would be no reason to wake up only one. Signed-off-by: Paolo Bonzini --- cpus.c

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-08 Thread Christophe Lyon
On 08.02.2011 16:59, Peter Maydell wrote: > Your subject is a bit long, which can make it wrap annoyingly in git logs. > I'd suggest something like: OK. > This is float32_to_float16() but it looks like you've missed > float16_to_float32() ? Well, actually I somewhat managed to persuade myself

[Qemu-devel] [CFT PATCH 08/12] do not use timedwait on qemu_halt_cond

2011-02-08 Thread Paolo Bonzini
The following conditions can cause cpu_has_work(env) to become true: - env->queued_work_first: run_on_cpu is already kicking the VCPU - env->stop = 1: pause_all_vcpus is already kicking the VCPU - env->stopped = 0: resume_all_vcpus is already kicking the VCPU - vm_running = 1: vm_start is calli

Re: [Qemu-devel] [PATCH] qcow2: Fix error handling for immediate backing file read failure

2011-02-08 Thread Markus Armbruster
Kevin Wolf writes: > Requests could return success even though they failed when bdrv_aio_readv > returned NULL for a backing file read. > > Reported-by: Chunqiang Tang > Signed-off-by: Kevin Wolf > --- > block/qcow2.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --g

[Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64

2011-02-08 Thread Christophe Lyon
Signed-off-by: Christophe Lyon --- Submitted as a standalone patch as suggested by Peter, along with his corrections. target-arm/translate.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index e4649e6..b69

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-02-08 Thread Richard Henderson
On 01/30/2011 04:30 PM, Michael Walle wrote: > +if (dc->format == OP_FMT_RI) { > +tcg_gen_brcondi_tl(cond, cpu_R[rY], sign_extend(dc->imm16, 16), l1); > +} else { > +tcg_gen_brcond_tl(cond, cpu_R[rY], cpu_R[rZ], l1); > +} > +tcg_gen_movi_tl(cpu_R[rX], 0); > +tcg_

[Qemu-devel] [PATCH] qcow2: Fix error handling for immediate backing file read failure

2011-02-08 Thread Kevin Wolf
Requests could return success even though they failed when bdrv_aio_readv returned NULL for a backing file read. Reported-by: Chunqiang Tang Signed-off-by: Kevin Wolf --- block/qcow2.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c inde

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Anthony Liguori
On 02/08/2011 09:55 AM, Chris Wright wrote: Automated builds and testing - found broken 32-bit - luiz suggested running against maintainer trees - daniel gollub offered to take on maintenance - integration with kvm-autotest? - lucas, daniel, stefan... - testing each git commit is probably o

[Qemu-devel] [ANNOUNCE] QEMU 0.14.0-rc1 is available

2011-02-08 Thread Anthony Liguori
The QEMU team is pleased to announce the availability of the 0.14.0-rc1 release. This is the second release candidate for the 0.14.0 release. A detailed changelog is at the end of this message. Download instructions are available at http://wiki.qemu.org/Download You can help test this relea

[Qemu-devel] Re: [V4 PATCH 3/8] Add client side interfaces for chroot environment

2011-02-08 Thread M. Mohan Kumar
On Wednesday 02 February 2011 3:24:16 pm Stefan Hajnoczi wrote: > On Tue, Feb 1, 2011 at 5:26 AM, M. Mohan Kumar wrote: > > +/* Receive file descriptor and error status from chroot process */ > > +static int v9fs_receivefd(int sockfd, int *error) > > The return value and int *error overlap in fun

[Qemu-devel] [PATCHv2] vhost: disable on tap link down

2011-02-08 Thread Michael S. Tsirkin
qemu makes it possible to disable link at tap which is not communicated to the guest but causes all packets to be dropped. Handle this with vhost simply by moving to the userspace emulation. Note: it might be a good idea to make peer link status match tap in this case, so the guest gets an event

[Qemu-devel] Re: KVM call minutes for Feb 8

2011-02-08 Thread Stefan Hajnoczi
On Tue, Feb 8, 2011 at 3:55 PM, Chris Wright wrote: > Automated builds and testing > - found broken 32-bit The broken build was found (and fixed?) before automated qemu.git builds. It's a good motivator though. Stefan

Re: [Qemu-devel] [PATCHv2] e1000: multi-buffer packet support

2011-02-08 Thread Michael S. Tsirkin
On Tue, Feb 08, 2011 at 03:07:58PM +0100, Kevin Wolf wrote: > Am 03.02.2011 17:49, schrieb Michael S. Tsirkin: > > e1000 supports multi-buffer packets larger than rxbuf_size. > > > > This fixes the following (on linux): > > - in guest: ifconfig eth1 mtu 16110 > > - in host: ifconfig tap0 mtu 16110

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-08 Thread Peter Maydell
On 7 February 2011 17:00, Christophe Lyon wrote: > > Some CPUs have a status flag imposing to return floatxx_default_nan > whatever the input value, when converting from one FP format to > another. Implement this, using the already existing default_nan_mode > status flag (currently used on ARM and

[Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Chris Wright
Automated builds and testing - found broken 32-bit - luiz suggested running against maintainer trees - daniel gollub offered to take on maintenance - integration with kvm-autotest? - lucas, daniel, stefan... - testing each git commit is probably overkill and too expensive - current autotest r

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-08 Thread Markus Armbruster
Alon Levy writes: > On Mon, Feb 07, 2011 at 04:27:21PM +0200, Alon Levy wrote: >> On Mon, Feb 07, 2011 at 03:00:25PM +0100, Markus Armbruster wrote: [...] >> > Sounds like what I have in mind. Care to explore it? >> > >> > One EnumTable should do, just make its member value wide enough. >> > >

[Qemu-devel] Re: [PATCH] vhost: disable on tap link down

2011-02-08 Thread Michael S. Tsirkin
On Tue, Feb 08, 2011 at 05:40:58PM +0530, pradeep wrote: > On Mon, 7 Feb 2011 15:50:01 +0200 > "Michael S. Tsirkin" wrote: > > > qemu makes it possible to disable link at tap > > which is not communicated to the guest but > > causes all packets to be dropped. > > > > Handle this with vhost simpl

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-08 Thread Alon Levy
On Mon, Feb 07, 2011 at 04:27:21PM +0200, Alon Levy wrote: > On Mon, Feb 07, 2011 at 03:00:25PM +0100, Markus Armbruster wrote: > > Alon Levy writes: > > > > > On Mon, Feb 07, 2011 at 09:53:44AM +0100, Markus Armbruster wrote: > > >> I haven't been able to follow the evolution of this series, my

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 07:30 AM, Aurelien Jarno wrote: >> So the strategy is let's break everything and wait for the maintainer to >> fix that? This strategy doesn't work, we have seen for example that with >> the SeaBIOS switch. While it brings nice features, it has broken the >

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Aurelien Jarno a écrit : > Paolo Bonzini a écrit : >> On 02/08/2011 12:15 PM, Aurelien Jarno wrote: >>> however >>> it should not be done ignoring all the*current* drawbacks of the >>> iothread mode. We know them (at least for some of them), so let's try to >>> solve them. >> Let's also enumerate

[Qemu-devel] [PATCH master+0.14 1/2] blockdev: Plug memory leak in drive_uninit()

2011-02-08 Thread Markus Armbruster
Started leaking in commit 1dae12e6. Signed-off-by: Markus Armbruster --- blockdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ecfadc1..24d7658 100644 --- a/blockdev.c +++ b/blockdev.c @@ -182,6 +182,7 @@ static void drive_uninit(DriveI

[Qemu-devel] [PATCH master+0.14 0/2] blockdev memory leaks

2011-02-08 Thread Markus Armbruster
Markus Armbruster (2): blockdev: Plug memory leak in drive_uninit() blockdev: Plug memory leak in drive_init() error paths blockdev.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) -- 1.7.2.3

[Qemu-devel] [PATCH master+0.14 2/2] blockdev: Plug memory leak in drive_init() error paths

2011-02-08 Thread Markus Armbruster
Should have spotted this when doing commit 319ae529. Signed-off-by: Markus Armbruster --- blockdev.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 24d7658..0690cc8 100644 --- a/blockdev.c +++ b/blockdev.c @@ -526,7 +526,7 @@ Driv

Re: [Qemu-devel] [PATCHv2] e1000: multi-buffer packet support

2011-02-08 Thread Kevin Wolf
Am 03.02.2011 17:49, schrieb Michael S. Tsirkin: > e1000 supports multi-buffer packets larger than rxbuf_size. > > This fixes the following (on linux): > - in guest: ifconfig eth1 mtu 16110 > - in host: ifconfig tap0 mtu 16110 >ping -s 16082 > > Red Hat bugzilla: https://bugzilla.red

Re: [Qemu-devel] [PATCH 3/8] target-arm: VQRSHRN related changes

2011-02-08 Thread Peter Maydell
On 31 January 2011 18:06, wrote: > From: Christophe Lyon > > More fixes for VQSHRN and VQSHRUN. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell as far as the code goes, but the commit message is excessively vague. -- PMM

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 07:30 AM, Aurelien Jarno wrote: So the strategy is let's break everything and wait for the maintainer to fix that? This strategy doesn't work, we have seen for example that with the SeaBIOS switch. While it brings nice features, it has broken the isapc machine. And it's still not fi

Re: [Qemu-devel] [PATCH 4/8] target-arm: fiddle decoding of 64 bit shift by imm and narrow

2011-02-08 Thread Peter Maydell
On 31 January 2011 18:06, wrote: > From: Christophe Lyon > > Tweak decoding of the shift-by-imm and narrow 64 bit insns > (VSHRN, VRSHRN, VQSHRN, VQSHRUN, VQRSHRN, VQRSHRUN). > > Signed-off-by: Christophe Lyon > --- >  target-arm/translate.c |   28 ++-- >  1 files change

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Daniel Gollub
Hi Stefan, On Monday, February 07, 2011 10:34:03 am Stefan Hajnoczi wrote: > I have a buildmaster at buildbot.vmsplice.net. I could share my > master.cfg with you so that you can take over and merge it into your > KVM buildmaster. Then I would take my buildmaster offline. Ok. This would be ver

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Paolo Bonzini a écrit : > On 02/08/2011 12:15 PM, Aurelien Jarno wrote: >> however >> it should not be done ignoring all the*current* drawbacks of the >> iothread mode. We know them (at least for some of them), so let's try to >> solve them. > > Let's also enumerate them. > >From what I know: -

[Qemu-devel] Migration of WinXP Guest -> usb+network failure

2011-02-08 Thread Peter Lieven
Hi, is there any known issue when migrating a WinXP SP3 guest with qemu-kvm 0.13.0 or qemu-kvm-0.12.5? If I migrate such a guest with a Realtek rtl8139 Network Device and an USB Mouse Tablet after migration the USB Tablet doesn't work any more and network stalls. I have seen the mouse moving

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 05:15 AM, Aurelien Jarno wrote: >> Anthony Liguori a écrit : >> >>> On 02/08/2011 04:06 AM, Aurelien Jarno wrote: >>> Yes, it's slow. But is it a problem? You assume that people use QEMU only for emulating SMP platforms. This is a wrong

[Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-02-08 Thread Yoshiaki Tamura
2011/2/8 Paolo Bonzini : > On 02/08/2011 12:01 PM, Yoshiaki Tamura wrote: >> >> When -k option is set to migrate command, it will turn on ft_mode to >> start FT migration mode (Kemari). > > This could also use a "kemari:" prefix. Sorry, missed that comment. BTW, the help message would be like pu

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Riku Voipio
On Tue, Feb 08, 2011 at 12:05:31PM -0600, Anthony Liguori wrote: > Aurelien, > Have you actually run QEMU on Windows and tried to use it to do > something useful? I'm not Aurelian, but we do use QEMU on win32 as part of Nokia Qt SDK. While it is second class in many ways compared to Linux QEMU

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Alexander Graf
On 08.02.2011, at 12:28, Stefan Hajnoczi wrote: > On Tue, Feb 8, 2011 at 11:23 AM, Lucas Meneghel Rodrigues > wrote: >> Bottom line, the thing here is to have available hardware externally >> accessible, just like the buildbot that was setup, mentioned previously >> on this thread. > > Remembe

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 05:46 AM, Aurelien Jarno wrote: On Tue, Feb 08, 2011 at 12:07:02PM +0100, Tristan Gingold wrote: On Feb 8, 2011, at 6:58 PM, Anthony Liguori wrote: On 02/08/2011 04:06 AM, Aurelien Jarno wrote: Yes, it's slow. But is it a problem? You assume that people use QEM

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 05:15 AM, Aurelien Jarno wrote: Anthony Liguori a écrit : On 02/08/2011 04:06 AM, Aurelien Jarno wrote: Yes, it's slow. But is it a problem? You assume that people use QEMU only for emulating SMP platforms. This is a wrong assumption. Beside the x86 target, only sparc re

Re: [Qemu-devel] [V4 PATCH 2/8] Provide chroot environment server side interfaces

2011-02-08 Thread M. Mohan Kumar
Hi, Is it okay to fork the chroot process in the fsdev parameter parsing time? Can we ask other initialization routines to not create threads till chroot process is forked? Following code snippet forks the chroot process during fsdev parameter parsing to avoid the problems associated with fork

[Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 12:01 PM, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). This could also use a "kemari:" prefix. Paolo

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 12:46 PM, Aurelien Jarno wrote: Given the I/O thread is disabled by default, my guess is that nobody really see an interest in looking at that. I had started looking at it in my free time. I stopped because the thread pool series were continuously changing the QemuThread APIs.

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 12:15 PM, Aurelien Jarno wrote: however it should not be done ignoring all the*current* drawbacks of the iothread mode. We know them (at least for some of them), so let's try to solve them. Let's also enumerate them. And now, I don't buy the argument "it's been there for years"

[Qemu-devel] Re: [PATCH] vhost: disable on tap link down

2011-02-08 Thread pradeep
On Mon, 7 Feb 2011 15:50:01 +0200 "Michael S. Tsirkin" wrote: > qemu makes it possible to disable link at tap > which is not communicated to the guest but > causes all packets to be dropped. > > Handle this with vhost simply by moving to the userspace emulation. > > Note: it might be a good ide

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
On Tue, Feb 08, 2011 at 12:07:02PM +0100, Tristan Gingold wrote: > > On Feb 8, 2011, at 6:58 PM, Anthony Liguori wrote: > > > On 02/08/2011 04:06 AM, Aurelien Jarno wrote: > >> Yes, it's slow. But is it a problem? You assume that people use QEMU > >> only for emulating SMP platforms. This is a wr

Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case

2011-02-08 Thread Aurelien Jarno
On Fri, Feb 04, 2011 at 01:47:25PM -0200, Marcelo Tosatti wrote: > From: Jan Kiszka > > When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like > it is done for KVM. Use the symbolic constants at this chance. > > Signed-off-by: Jan Kiszka > Signed-off-by: Marcelo Tosatti > ---

Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case

2011-02-08 Thread Jan Kiszka
On 2011-02-08 12:39, Aurelien Jarno wrote: > On Fri, Feb 04, 2011 at 01:47:25PM -0200, Marcelo Tosatti wrote: >> From: Jan Kiszka >> >> When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like >> it is done for KVM. Use the symbolic constants at this chance. >> >> Signed-off-by: Jan

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Stefan Hajnoczi
On Tue, Feb 8, 2011 at 11:14 AM, Daniel Gollub wrote: > On Monday, February 07, 2011 10:34:03 am Stefan Hajnoczi wrote: >> I have a buildmaster at buildbot.vmsplice.net.  I could share my >> master.cfg with you so that you can take over and merge it into your >> KVM buildmaster.  Then I would take

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Stefan Hajnoczi
On Tue, Feb 8, 2011 at 11:23 AM, Lucas Meneghel Rodrigues wrote: > Bottom line, the thing here is to have available hardware externally > accessible, just like the buildbot that was setup, mentioned previously > on this thread. Remember the buildslaves don't need to have incoming TCP ports open a

[Qemu-devel] [PATCH] Make tb_alloc static.

2011-02-08 Thread Tristan Gingold
This function is only used within exec.c, so no need to make it public. Signed-off-by: Tristan Gingold --- exec-all.h |1 - exec.c |4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exec-all.h b/exec-all.h index 81497c0..c062693 100644 --- a/exec-all.h +++ b/exec

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Alexander Graf
On 08.02.2011, at 12:23, Lucas Meneghel Rodrigues wrote: > On Tue, 2011-02-08 at 09:23 +, Stefan Hajnoczi wrote: >> Public automated qemu.git autotest would be excellent. To be honest I >> haven't had much visibility of KVM-Autotest myself as a QEMU/KVM >> developer. I suspect many others h

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 04:27 AM, Aurelien Jarno wrote: >> Stefan Hajnoczi a écrit : >> >>> Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class >>> citizens. I think you'd like people to provide full support when they >>> introduce new features. >>> >>> >>

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 04:27 AM, Aurelien Jarno wrote: Stefan Hajnoczi a écrit : Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class citizens. I think you'd like people to provide full support when they introduce new features. I think you really pointed the problem here. We sho

Re: [Qemu-devel] Re: new->old version migration

2011-02-08 Thread Michael S. Tsirkin
On Tue, Feb 08, 2011 at 01:42:59AM -0600, Anthony Liguori wrote: > On 02/08/2011 12:42 AM, Michael S. Tsirkin wrote: > >On Mon, Feb 07, 2011 at 08:23:08PM -0600, Anthony Liguori wrote: > >>On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: > >>>How does it? We need to know we are saving in 0.13 > >>

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Lucas Meneghel Rodrigues
On Tue, 2011-02-08 at 09:23 +, Stefan Hajnoczi wrote: > Public automated qemu.git autotest would be excellent. To be honest I > haven't had much visibility of KVM-Autotest myself as a QEMU/KVM > developer. I suspect many others haven't either but there are big > benefits if we can change this

[Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-02-08 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |5 ++ savevm.c | 149 ++ 2 files changed, 154 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h ind

[Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler.

2011-02-08 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index ed2cdfa..00155fb 100644 ---

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 04:06 AM, Aurelien Jarno wrote: >> Yes, it's slow. But is it a problem? You assume that people use QEMU >> only for emulating SMP platforms. This is a wrong assumption. Beside the >> x86 target, only sparc really supports SMP emulation. >> > > It's *no

  1   2   >