Anthony Liguori anth...@codemonkey.ws writes:
On 02/18/2011 03:57 AM, Kevin Wolf wrote:
Am 18.02.2011 10:12, schrieb Markus Armbruster:
Kevin Wolfkw...@redhat.com writes:
Am 15.02.2011 20:45, schrieb Chunqiang Tang:
Chunqiang Tang/Watson/IBM wrote on 01/28/2011
Aurelien Jarno aurel...@aurel32.net writes:
[...]
I agree that the best would be to have a single format, and it's
probably a goal to have. That said, what is most important to my view is
having one or two formats which together have _all_ the features (and
here I consider speed as a
Tomas Bures bu...@d3s.mff.cuni.cz writes:
Dear all,
I'm preparing a class on embedded systems. I would like to make a
client that interfaces with QEMU and the application running inside
it. This client would simulate the physical environment that the
application running inside QEMU should
Am 22.02.2011 09:37, schrieb Markus Armbruster:
Anthony Liguori anth...@codemonkey.ws writes:
On 02/18/2011 03:57 AM, Kevin Wolf wrote:
Am 18.02.2011 10:12, schrieb Markus Armbruster:
Kevin Wolfkw...@redhat.com writes:
Am 15.02.2011 20:45, schrieb Chunqiang Tang:
Hi,
Iam using using qemu0.13.0..I have seen the ohci support in it.How about
EHCI support? is it already there or there are patches for it.
plz update me asap.
Thanx
AK
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
linux-aio.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..d9c0225 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -32,6 +32,7
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Current AIO code returns -EINVAL on every error, even on write. In
order to be able to report some more sensible error messages, I
suggest we change it to return -ENOSPC if we are failing on a write
request and we had a partial write. It matches
Mark the current iohandler list as 'old'. In the next commit we'll
introduce a new iohandler api that will replace the list name.
The 'old' list will eventually be completely replaced by the new
implementation.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
vl.c | 14 +++---
1
Update the udp code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 22 +++---
1 files changed,
Hello,
This is a new iohandler API implementation. It gets rid of the
multiple callbacks and switches to just one callback with an event
mask that triggered the callback.
qemu-char.c has been trivially updated to replace all usage of
qemu_set_fd_handler* functions to the new api.
Future work
Update the fd code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 24
1 files changed,
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our transition to a poll()
interface instead of the current select() that happens on the fds.
Signed-off-by: Amit Shah
Update the tcp code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 48
Update the stdio code to use the new iohandler api. The change is
mostly mechanical with a new iohandler function calling the older
functions depending on the value of the 'mask' field.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 22 +++---
1 files changed,
Update the pty code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 24
1 files changed,
Kevin Wolf kw...@redhat.com writes:
Am 22.02.2011 09:37, schrieb Markus Armbruster:
Anthony Liguori anth...@codemonkey.ws writes:
On 02/18/2011 03:57 AM, Kevin Wolf wrote:
Am 18.02.2011 10:12, schrieb Markus Armbruster:
Kevin Wolfkw...@redhat.com writes:
Am 15.02.2011 20:45,
On 02/22/2011 12:18 PM, Amit Shah wrote:
Mark the current iohandler list as 'old'. In the next commit we'll
introduce a new iohandler api that will replace the list name.
The 'old' list will eventually be completely replaced by the new
implementation.
A better way to do this is to implement
On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote:
On 02/22/2011 12:18 PM, Amit Shah wrote:
Mark the current iohandler list as 'old'. In the next commit we'll
introduce a new iohandler api that will replace the list name.
The 'old' list will eventually be completely replaced by the new
Am 22.02.2011 11:18, schrieb jes.soren...@redhat.com:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
linux-aio.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index
On 02/22/11 12:44, Kevin Wolf wrote:
@@ -62,6 +63,9 @@ static void qemu_laio_process_completion(struct
qemu_laio_state *s,
if (ret != -ECANCELED) {
if (ret == laiocb-nbytes)
ret = 0;
+else if ((laiocb-type == QEMU_AIO_WRITE) (ret = 0)
+
+ * Send I/O requests to the server.
+ *
+ * This function sends requests to the server, links the requests to
+ * the outstanding_list in BDRVNBDState, and exits without waiting for
+ * the response. The responses are received in the `aio_read_response'
+ * function which is called
On 21 February 2011 16:38, Christophe Lyon christophe.l...@st.com wrote:
These special values are needed to implement some helper functions,
which return/use these values in some cases.
Signed-off-by: Christophe Lyon christophe.l...@st.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
On 21 February 2011 16:38, Christophe Lyon christophe.l...@st.com wrote:
These two constants will be used by helper functions such as recpe_f32
and rsqrte_f32.
Signed-off-by: Christophe Lyon christophe.l...@st.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
On 21 February 2011 16:38, Christophe Lyon christophe.l...@st.com wrote:
Now use the same algorithm as described in the ARM ARM.
Signed-off-by: Christophe Lyon christophe.l...@st.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
On 21 February 2011 16:38, Christophe Lyon christophe.l...@st.com wrote:
These constants and utility function are needed to implement some
helpers. Defining constants avoids the need to re-compute them at
runtime.
Signed-off-by: Christophe Lyon christophe.l...@st.com
Reviewed-by: Peter
On 21 February 2011 16:38, Christophe Lyon christophe.l...@st.com wrote:
Now use the same algorithm as described in the ARM ARM.
Signed-off-by: Christophe Lyon christophe.l...@st.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
On Tue, Feb 22, 2011 at 03:48:31PM +0530, Amit Shah wrote:
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our transition to a poll()
interface instead of the
When emulating a 32 bit Linux user-mode program on a 64 bit target
we implement the llseek syscall in terms of lseek. Correct a bug
which meant we were silently casting the result of host lseek()
to a 32 bit integer as it passed through get_errno() and thus
throwing away the top half.
We also
On (Tue) 22 Feb 2011 [14:39:03], Alon Levy wrote:
On Tue, Feb 22, 2011 at 03:48:31PM +0530, Amit Shah wrote:
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our
On Mon, 21 Feb 2011 14:13:04 -0600
Anthony Liguori anth...@codemonkey.ws wrote:
On 02/21/2011 11:12 AM, Juan Quintela wrote:
please send in any agenda items you are interested in covering.
- 0.14.0 release is out, thanks to everyone that participated! Let's
discuss what worked
On 02/22/2011 12:18 PM, Amit Shah wrote:
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our transition to a poll()
interface instead of the current select() that
On 02/22/2011 01:17 PM, Amit Shah wrote:
On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote:
On 02/22/2011 12:18 PM, Amit Shah wrote:
Mark the current iohandler list as 'old'. In the next commit we'll
introduce a new iohandler api that will replace the list name.
The 'old' list will
On Tue, Feb 22, 2011 at 11:48 AM, Nicholas Thomas n...@bytemark.co.uk wrote:
+ * Send I/O requests to the server.
+ *
+ * This function sends requests to the server, links the requests to
+ * the outstanding_list in BDRVNBDState, and exits without waiting for
+ * the response. The
On 02/22/2011 01:45 PM, Jes Sorensen wrote:
On 02/22/11 12:44, Kevin Wolf wrote:
@@ -62,6 +63,9 @@ static void qemu_laio_process_completion(struct
qemu_laio_state *s,
if (ret != -ECANCELED) {
if (ret == laiocb-nbytes)
ret = 0;
+else if ((laiocb-type
The simpletrace.py script pretty-prints a binary trace file. Most of
the code can be reused by trace file analysis scripts, so turn it into a
module.
Here is an example script that uses the new simpletrace module:
#!/usr/bin/env python
# Print virtqueue elements that were never returned to
Thank you. This is exactly what I was looking for. I've created the
device, added the compilation of it to Makefile.target . Now, I'm
wondering how to persuade QEMU to initialize it?
I've registered it using the code below. The registration executes
during QEMU launch, the the initialization
On (Tue) 22 Feb 2011 [15:28:59], Avi Kivity wrote:
On 02/22/2011 01:17 PM, Amit Shah wrote:
On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote:
On 02/22/2011 12:18 PM, Amit Shah wrote:
Mark the current iohandler list as 'old'. In the next commit we'll
introduce a new iohandler api that
On (Tue) 22 Feb 2011 [15:28:02], Avi Kivity wrote:
On 02/22/2011 12:18 PM, Amit Shah wrote:
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our transition to a
On 02/22/2011 04:37 PM, Amit Shah wrote:
On (Tue) 22 Feb 2011 [15:28:59], Avi Kivity wrote:
On 02/22/2011 01:17 PM, Amit Shah wrote:
On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote:
On 02/22/2011 12:18 PM, Amit Shah wrote:
Mark the current iohandler list as 'old'. In the next
On 02/22/2011 04:18 AM, Amit Shah wrote:
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our transition to a poll()
interface instead of the current select() that
On 02/22/2011 07:28 AM, Avi Kivity wrote:
On 02/22/2011 12:18 PM, Amit Shah wrote:
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our transition to a poll()
Hi,
During live migration, if the receiver side of qemu gets killed, the
sender side seems to be handling the error incorrectly, like it passes
the iterate phase (stage 2) and moves on to the complete state (stage
3). These patches fix the issue.
Yoshiaki Tamura (2):
savevm: avoid
When qemu on the receiver gets killed during live migration, if debug
is turned on, migrate_fd_put_ready() says,
migration: done iterating
and proceeds. The reason was qemu_savevm_state_iterate() returning 1
even when qemu file has error. This patch checks
qemu_file_has_error() before
Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed,
since migrate_fd_put_notify() isn't checking error of underlying
QEMUFile, those resources are kept open. This patch checks it and
calls migrate_fd_error() in case of error.
Signed-off-by: Yoshiaki Tamura
On Tue, Feb 22, 2011 at 10:18 AM, jes.soren...@redhat.com wrote:
+ else if ((laiocb-type == QEMU_AIO_WRITE) (ret = 0)
+ (ret laiocb-nbytes))
+ ret = -ENOSPC;
Why is write special?
Why are we even allowing requests that extend beyond the end of the
device?
Am 22.02.2011 16:02, schrieb Stefan Hajnoczi:
On Tue, Feb 22, 2011 at 10:18 AM, jes.soren...@redhat.com wrote:
+else if ((laiocb-type == QEMU_AIO_WRITE) (ret = 0)
+ (ret laiocb-nbytes))
+ret = -ENOSPC;
Why is write special?
I think we need the change
On Tue, Feb 22, 2011 at 3:11 PM, Kevin Wolf kw...@redhat.com wrote:
Am 22.02.2011 16:02, schrieb Stefan Hajnoczi:
Why are we even allowing requests that extend beyond the end of the
device? Is the LVM volume marked growable in the QEMU block layer?
Might well be a qcow2 on LVM case that Jes
On Mon, 2011-02-21 at 20:10 +, Stefan Hajnoczi wrote:
On Mon, Feb 21, 2011 at 12:37 PM, Kevin Wolf kw...@redhat.com wrote:
Am 18.02.2011 13:55, schrieb Nick Thomas:
+retry:
+if (do_read) {
+ret = recvmsg(sockfd, msg, 0);
+} else {
+ret = sendmsg(sockfd,
On 02/22/2011 02:56 AM, Kevin Wolf wrote:
*sigh*
It starts to get annoying, but if you really insist, I can repeat it
once more: These features that you don't need (this is the correct
description for what you call misfeatures) _are_ implemented in a way
that they don't impact the normal case.
On 02/07/2011 10:34 AM, Alon Levy wrote:
+static int ccid_post_load(void *opaque, int version_id)
+{
+USBCCIDState *s = opaque;
+
+// This must be done after usb_device_attach, which sets state to ATTACHED,
+// while it must be DEFAULT in order to accept packets (like it is after
+
Looks like Chris will send minutes too,
so I didn't do much to polish this,
I didn't realise he's doing it until I had this, so
here's the braindump: hope it helps.
1. 0.14 postmortem
- what went well
wiki for planning
testing
- what can be improved
rc - cycle could be
At Mon, 21 Feb 2011 17:48:49 +0100,
Kevin Wolf wrote:
Am 21.02.2011 17:31, schrieb Nicholas Thomas:
Hi again,
Thanks for looking through the patches. I'm just going through and
making the suggested changes now. I've also got qemu-nbd and block/nbd.c
working over IPv6 :) - hopefully
Am 22.02.2011 16:57, schrieb Anthony Liguori:
On 02/22/2011 02:56 AM, Kevin Wolf wrote:
*sigh*
It starts to get annoying, but if you really insist, I can repeat it
once more: These features that you don't need (this is the correct
description for what you call misfeatures) _are_ implemented
On 02/22/2011 05:00 PM, Anthony Liguori wrote:
Drop the opaque, instead put the IOHandler in there (or maybe the
CharDev?) and use container_of().
You know, I'm not there that this is automatically better.
Why not? One less unsafe cast.
+
+int assign_iohandler(int fd, IOAllHandler
0.14 recap
- keeping schedule on wiki was helpful
- changelog was helpful
- testing (could even more emphasis could be improved)
- -rc cycles
- -rc2 and final release just hours
0.15
- tentative date July 1st
- qapi
- qed features
- virtagent?
- depends on whether to terminate in qemu vs
On 02/21/2011 12:03 PM, Andreas Niederl wrote:
On 02/18/2011 09:27 PM, Stefan Berger wrote:
On 02/18/2011 12:37 PM, Andreas Niederl wrote:
[...]
So I'm guessing that this library is not publicly available right now?
Not via the fedora repository at least. So yum install does not work, yet.
On 02/22/2011 04:16 PM, Stefan Hajnoczi wrote:
Yes it is. It doesn't explain it though. The code involved here is
linux-aio.c and will be qcow2's bs-file. That ought to be a
host_device and AFAIK that is not growable. So I wanted to figure out
why we're even getting this far. I expected the
On Tue, Feb 22, 2011 at 06:06:22PM +0200, Michael S. Tsirkin wrote:
Looks like Chris will send minutes too,
so I didn't do much to polish this,
I didn't realise he's doing it until I had this, so
here's the braindump: hope it helps.
1. 0.14 postmortem
- what went well
wiki for
`qdev_free` when unplug a pci device
It resolves a bug when detaching/attaching a network device
# virsh detach-interface dom0 network --mac 52:54:00:f6:84:ba
Interface detached successfully
# virsh attach-interface dom0 network default --mac 52:54:00:f6:84:ba
error: Failed to attach
On 02/22/2011 11:32 AM, Alon Levy wrote:
On Tue, Feb 22, 2011 at 06:06:22PM +0200, Michael S. Tsirkin wrote:
Looks like Chris will send minutes too,
so I didn't do much to polish this,
I didn't realise he's doing it until I had this, so
here's the braindump: hope it helps.
1. 0.14
On 02/22/2011 10:15 AM, Kevin Wolf wrote:
Am 22.02.2011 16:57, schrieb Anthony Liguori:
On 02/22/2011 02:56 AM, Kevin Wolf wrote:
*sigh*
It starts to get annoying, but if you really insist, I can repeat it
once more: These features that you don't need (this is the correct
Newer ARM kernels try to probe for whether the CPU has hardware breakpoint
support. For this to work QEMU has to implement a minimal set of the cp14
debug registers. The architecture requires v7 cores to implement debug
and so there is no defined way to report its absence; however in practice
On 02/22/2011 10:21 AM, Avi Kivity wrote:
On 02/22/2011 05:00 PM, Anthony Liguori wrote:
Drop the opaque, instead put the IOHandler in there (or maybe the
CharDev?) and use container_of().
You know, I'm not there that this is automatically better.
Why not? One less unsafe cast.
It
On Fri, Feb 18, 2011 at 11:11:11AM +0100, Jan Kiszka wrote:
Round 2 of this part, primarily addressing review comments:
- Reworked CPU_INTERRUPT_MCE - exection translation
(now done in kvm_arch_process_async_events, indeed much cleaner)
- Add missing cpu_synchronize_state on pending MCE
To query whether migration is active.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Index: qemu/migration.c
===
--- qemu.orig/migration.c
+++ qemu/migration.c
@@ -480,3 +480,13 @@ int get_migration_state(void)
return
v2:
- use reference counting to be safe against device hotplug / bdrv_truncate
- add comment about usage of timer
Support live image copy + switch. That is, copy an image backing
a guest hard disk to a destination image (destination image must
be created separately), and switch to this copy.
Command syntax:
block_copy device filename [commit_filename] [-i] -- live block copy device to
image
On Tue, Feb 22, 2011 at 3:26 PM, Nicholas Thomas n...@bytemark.co.uk wrote:
On Mon, 2011-02-21 at 20:10 +, Stefan Hajnoczi wrote:
On Mon, Feb 21, 2011 at 12:37 PM, Kevin Wolf kw...@redhat.com wrote:
Am 18.02.2011 13:55, schrieb Nick Thomas:
+retry:
+ if (do_read) {
+ ret =
On 02/21/2011 02:43 AM, Paolo Bonzini wrote:
After gathering the comments about the two series I sent separately,
here is the full series for Win32 iothread support, ready to be
applied to uq/master.
Patches 1 to 5 are generic Win32 improvements, including the qemu-thread
implementation.
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote:
Support live image copy + switch. That is, copy an image backing
a guest hard disk to a destination image (destination image must
be created separately), and switch to this copy.
Command syntax:
block_copy device filename [commit_filename] [-i] --
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote:
This patch is large and not properly inlined. Can it be split up into
more reviewable chunks?
Regards,
Anthony Liguori
Hello,
No comments? Can someone commit?
Thnx.
Ciao,
Gerhard
--
http://www.wiesinger.com/
On Sun, 20 Feb 2011, Gerhard Wiesinger wrote:
Signed-off-by: Gerhard Wiesinger li...@wiesinger.com
---
hw/pcnet.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git
On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote:
+static int write_commit_file(BdrvCopyState *s)
+{
+char commit_msg[1400];
+const char *buf = commit_msg;
+int len, ret;
+
+sprintf(commit_msg, commit QEMU block_copy %s - %s\n,
s-src_device_name,
+
On 02/22/2011 03:07 PM, Marcelo Tosatti wrote:
On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote:
+static int write_commit_file(BdrvCopyState *s)
+{
+char commit_msg[1400];
+const char *buf = commit_msg;
+int len, ret;
+
+sprintf(commit_msg, commit QEMU
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote:
+
+static void blkcopy_switch(BdrvCopyState *s)
+{
+char src_filename[1024];
+int open_flags;
+
+strncpy(src_filename, s-src-filename, sizeof(src_filename));
+open_flags = s-src-open_flags;
strncpy doesn't leave a NULL
Hi everyone,
As some of you are aware we've been working for a few months now towards
creating a qemu-specific guest agent to implement bi-directional RPCs
between the host and the guest to support certain operations like
copy/paste, guest-initiated shutdown, and basic file transfer.
My basic understanding here is--there's no way for a virtio-serial
client (in-guest) to reliably reset a session such that if the client in
the guest crashes, the protocol needs to have some recovery mechanism.
This seems like a huge oversight in the design of virtio-serial. Are we
missing
On Tue, Feb 22, 2011 at 03:11:06PM -0600, Anthony Liguori wrote:
On 02/22/2011 03:07 PM, Marcelo Tosatti wrote:
On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote:
+static int write_commit_file(BdrvCopyState *s)
+{
+char commit_msg[1400];
+const char *buf = commit_msg;
On 02/22/2011 05:09 PM, Marcelo Tosatti wrote:
On Tue, Feb 22, 2011 at 03:11:06PM -0600, Anthony Liguori wrote:
On 02/22/2011 03:07 PM, Marcelo Tosatti wrote:
On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote:
+static int write_commit_file(BdrvCopyState *s)
+{
Public bug reported:
hi guys,
I try to install windows xp via qemu. I can only boot from usb and somehow it
is my problem.
I run a Winxp/xubuntu10.04 Dualboot-system with some virtual drives in windows
( till letter f:? ).
at qemu I created an image from 30Gigabytes and entered this command
This series:
- Fold MigrationState into FdMigrationState (and then rename)
- Factorize migration statec creation in a single place
- Make use of MIG_STATE_*, setup through helpers and make them local
- remove relase cancel callbacks (where used only one in same
file than defined)
- get_status()
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 31 ++-
migration.h | 16
2 files changed, 22 insertions(+), 25 deletions(-)
diff --git a/migration.c b/migration.c
index f9aaadc..3a371a3 100644
--- a/migration.c
+++
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration-exec.c |4 ++--
migration-fd.c |4 ++--
migration-tcp.c |4 ++--
migration-unix.c |4 ++--
migration.c |4 ++--
migration.h |8
6 files changed, 14 insertions(+), 14 deletions(-)
diff
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration-exec.c | 10 +-
migration-fd.c | 10 +-
migration-tcp.c | 10 +-
migration-unix.c | 10 +-
migration.c | 11 +--
migration.h | 23 +--
6 files
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration-exec.c | 10 +-
migration-fd.c | 10 +-
migration-tcp.c | 12 ++--
migration-unix.c | 12 ++--
migration.c | 34 +-
migration.h | 38
Use MIG_STATE_ACTIVE only when migration has really started
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c |6 +-
migration.h |3 ++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/migration.c b/migration.c
index 55f58c8..f015e02 100644
---
Once there, remove all parameters that don't need to be passed to
*start_outgoing_migration() functions
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration-exec.c | 19 +--
migration-fd.c | 22 ++
migration-tcp.c | 20 ++--
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration-exec.c | 16 +---
migration-fd.c | 16 +---
migration-tcp.c | 15 +--
migration-unix.c | 15 +--
migration.c | 29 +
migration.h | 11
I have to move two functions postions to avoid forward declarations
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 72 +-
migration.h | 12 -
2 files changed, 36 insertions(+), 48 deletions(-)
diff --git
We are also calling to migrate_fd_cleanup(), but notice that it is the
right thing to do.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/migration.c b/migration.c
index ab98664..3983257 100644
---
We are setting a pointer to a local variable in the previous line, just use
the global variable directly. We remove the -file test because it is already
done inside qemu_file_set_rate_limit() function.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c |6 ++
1 files
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 20 +---
1 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/migration.c b/migration.c
index f015e02..641df9f 100644
--- a/migration.c
+++ b/migration.c
@@ -361,28 +361,26 @@ static void
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c |6 ++
migration.h |6 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index 383ebaf..90fc2a0 100644
--- a/migration.c
+++ b/migration.c
@@ -31,6 +31,12 @@
do { }
We called it from a single place, and always with state !=
MIG_STATE_ACTIVE. Just remove the whole callback. For users of the
notifier, notice that this is exactly the case where they don't care,
we are just freeing the state from previous failed migration (it can't
be a sucessful one, otherwise
This function is a bit different of the others that change the state,
in the sense that if migrate_fd_cleanup() returns an error, it set the
status to error, not completed.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 18 --
1 files changed, 12
It is used only in one place
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c |9 -
migration.h |1 -
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index 2b873fa..92bff01 100644
--- a/migration.c
+++ b/migration.c
@@
Now that current_migration is static, there is no reason for max_throotle
variable.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 16 +++-
1 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/migration.c b/migration.c
index 7b1e679..312a029 100644
---
This means we can remove the two forward declarations.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 188 +--
1 files changed, 92 insertions(+), 96 deletions(-)
diff --git a/migration.c b/migration.c
index
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/migration.c b/migration.c
index accc6e4..4014330 100644
--- a/migration.c
+++ b/migration.c
@@ -136,9 +136,8 @@ void do_info_migrate(Monitor *mon, QObject
This cleans up a lot the code as we don't have to check anymore if
the variable is NULL or not.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 119 --
1 files changed, 49 insertions(+), 70 deletions(-)
diff --git
1 - 100 of 116 matches
Mail list logo
