[Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-23 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Note that this won't change the existing migration protocol to be bi-directional. Signed-off-by: Yoshiaki Tamura --- migration-tcp.c | 15 +++ migration.c | 1

[Qemu-devel] [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-23 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.objs

[Qemu-devel] [PATCH 05/18] vl.c: add deleted flag for deleting the handler.

2011-02-23 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura --- vl.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index b436952..0bda77d 100644

[Qemu-devel] [PATCH 04/18] qemu-char: export socket_set_nodelay().

2011-02-23 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index bd4e944..c4f1940 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2111,7 +2111,7 @@ static void tcp_chr_telnet_init(int

[Qemu-devel] [PATCH 11/18] ioport: insert event_tap_ioport() to ioport_write().

2011-02-23 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7 @@ #include "ioport.h" #include

[Qemu-devel] [PATCH 10/18] Call init handler of event-tap at main() in vl.c.

2011-02-23 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 0bda77d..0ea1fb7 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include "qemu-queue.h" #include "cpus.h" #include "arch_init.h

[Qemu-devel] [PATCH 17/18] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-02-23 Thread Yoshiaki Tamura
When ft_mode is set in the header, tcp_accept_incoming_migration() sets ft_trans_incoming() as a callback, and call qemu_file_get_notify() to receive FT transaction iteratively. We also need a hack no to close fd before moving to ft_transaction mode, so that we can reuse the fd for it. vm_change_

[Qemu-devel] [PATCH 08/18] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-02-23 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |5 ++ savevm.c | 150 ++ 2 files changed, 155 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h ind

[Qemu-devel] [PATCH 00/18] Kemari for KVM v0.2.12

2011-02-23 Thread Yoshiaki Tamura
Hi, This patch series is a revised version of Kemari for KVM, which applied comments for the previous post. The current code is based on qemu.git 9a31334f419c1d773cf4b4bfbbdace96fbf8a4f4. The changes from v0.2.11 -> v0.2.12 are: - fix vm_state_notify() to use QLIST_FOREACH_SAFE (Juan) - introdu

[Qemu-devel] [PATCH 14/18] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush().

2011-02-23 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests were sent from device emulators. Signed-off-by: Yoshiaki Tamura Acked-by: Kevin Wolf --- block.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index f7d91a2..b19729a 100644

[Qemu-devel] [PATCH 06/18] virtio: decrement last_avail_idx with inuse before saving.

2011-02-23 Thread Yoshiaki Tamura
For regular migration inuse == 0 always as requests are flushed before save. However, event-tap log when enabled introduces an extra queue for requests which is not being flushed, thus the last inuse requests are left in the event-tap queue. Move the last_avail_idx value sent to the remote back to

[Qemu-devel] [PATCH 01/18] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-02-23 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 5e24329..a168a37 100644 --- a/hw/

[Qemu-devel] [PATCH 03/18] Introduce qemu_loadvm_state_no_header() and make qemu_loadvm_state() a wrapper.

2011-02-23 Thread Yoshiaki Tamura
Introduce qemu_loadvm_state_no_header() so that it can be called iteratively without reading the header, and qemu_loadvm_state() becomes a wrapper of it. Signed-off-by: Yoshiaki Tamura --- savevm.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deleti

[Qemu-devel] [PATCH 13/18] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-02-23 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index ec4745d..724b549 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include "qemu-common.h" #include "qe

[Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-02-23 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index d611100..e192eec 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@ #include "osdep.h" #include "kvm.h

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-23 Thread Markus Armbruster
Anthony Liguori writes: > On 02/23/2011 11:18 AM, Avi Kivity wrote: >> On 02/23/2011 06:28 PM, Anthony Liguori wrote: >>> > Well specifically, it has to ask QEMU and QEMU can tell it the > current state via a nice structured data format over QMP. It's a > hell of a lot easier than th

Re: [Qemu-devel] Re: QEMU regression problems - Update FPU

2011-02-23 Thread Aurelien Jarno
On Thu, Feb 24, 2011 at 08:03:02AM +0100, Gerhard Wiesinger wrote: > On Wed, 23 Feb 2011, Peter Maydell wrote: > > >On 18 February 2011 07:12, Gerhard Wiesinger wrote: > >>Issue 1.) with FPU still present > >>I tracked down the problematic code and it is a rounding error from double > >>precision

Re: [Qemu-devel] [PATCH] Fix conversions from pointer to int and vice versa

2011-02-23 Thread Markus Armbruster
Stefan Weil writes: > Here the int values fds[0], sigfd, s, sock and fd are converted > to void pointers which are later converted back to an int value. > > These conversions should always use intptr_t instead of unsigned long. > > They are needed for environments where sizeof(long) != sizeof(voi

Re: [Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Markus Armbruster
Anthony Liguori writes: > On 02/23/2011 04:46 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 02/23/2011 03:47 PM, Juan Quintela wrote: >>> We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->

Re: [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore

2011-02-23 Thread Markus Armbruster
David Gibson writes: > Add the etags output generated by "make TAGS" and editor backup files > to .gitignore. > > This patch has previously appeared in my series of patches to add > pSeries emulation support. However, it obviously has no real > connection to that, and can be applied seperately.

Re: [Qemu-devel] Re: QEMU regression problems - Update FPU

2011-02-23 Thread Gerhard Wiesinger
On Wed, 23 Feb 2011, Peter Maydell wrote: On 18 February 2011 07:12, Gerhard Wiesinger wrote: Issue 1.) with FPU still present I tracked down the problematic code and it is a rounding error from double precision to 64bit floats: Any ideas how to fix such an issue in general? QEMU result in ST

Re: [Qemu-devel] Re: Network bridging without adding bridge with brctl, possible?

2011-02-23 Thread Gerhard Wiesinger
On Wed, 23 Feb 2011, Jan Kiszka wrote: Right, but if I set IP(eth0) == IP(macvlan0), I'm able to communicate between macvlan0 and mactapX, thus between guest and host. Just re-checked here, still works (after resolving the usual MAC address mess I caused by configuring manually). Thnx for the t

[Qemu-devel] [RESEND][REBASE] [PATCH] virtio-serial: kill VirtIOSerialDevice

2011-02-23 Thread Amit Shah
From: Gerd Hoffmann VirtIOSerialDevice is like VirtIOSerialPort with just the first two fields, which makes it pretty pointless. Using VirtIOSerialPort directly works equally well and is less confusing. [Amit: - rebase - rename 'dev' to 'port' in function params in virtio-serial.h ] Sig

[Qemu-devel] Unsubsribing

2011-02-23 Thread James Brown
Who I can do it?

[Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore

2011-02-23 Thread David Gibson
Add the etags output generated by "make TAGS" and editor backup files to .gitignore. This patch has previously appeared in my series of patches to add pSeries emulation support. However, it obviously has no real connection to that, and can be applied seperately. Please apply. Signed-off-by: Dav

Re: [Qemu-devel] Re: [PATCH 22/22] migration: Make state definitions local

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela : > Yoshiaki Tamura wrote: >> 2011/2/23 Juan Quintela : >>> >>> Signed-off-by: Juan Quintela >>> --- >>>  migration.c |    6 ++ >>>  migration.h |    6 -- >>>  2 files changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/migration.c b/migration.c >>> index

Re: [Qemu-devel] [PATCH 21/28] migration: Make state definitions local

2011-02-23 Thread Yoshiaki Tamura
2011/2/24 Juan Quintela : > > Signed-off-by: Juan Quintela > --- >  migration.c |    8 >  migration.h |    8 >  2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/migration.c b/migration.c > index 493c2d7..697c74f 100644 > --- a/migration.c > +++ b/migration.c > @@

[Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-23 Thread Yoshiaki Tamura
Juan Quintela wrote: Yoshiaki Tamura wrote: This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Could you explain what is the

Re: [Qemu-devel] Building QEMU on PS3

2011-02-23 Thread 陳韋任
Forgot to add the attachment, sorry. :) -- Wei-Ren Chen (陳韋任) Parallel Processing Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 --- qemu-0.13.0/tcg/tcg.c.orig 2010-10-16 04:56:09.0 +0800 +++ qemu-0.13.0/tcg/tcg.c 2011-02-24 09:46:28.7968

Re: [Qemu-devel] Building QEMU on PS3

2011-02-23 Thread 陳韋任
Hi, Roy What I did is apply the patch (see attachment) which comment out an assertion in tcg/tcg.c first. Then configure qemu with "--enable-debug" option. I don't know if it is safe to remove the assertion though, but it works for small program. Regards, chenwj -- Wei-Ren Chen (陳韋任) Parallel

[Qemu-devel] Re: [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state().

2011-02-23 Thread Yoshiaki Tamura
Juan Quintela wrote: Yoshiaki Tamura wrote: Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +-

[Qemu-devel] Re: [PATCH 05/18] vl.c: add deleted flag for deleting the handler.

2011-02-23 Thread Yoshiaki Tamura
Juan Quintela wrote: Yoshiaki Tamura wrote: Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --gi

[Qemu-devel] [PATCH] net: Use iov helper functions

2011-02-23 Thread Benjamin Poirier
Signed-off-by: Benjamin Poirier --- net.c | 28 ++-- 1 files changed, 6 insertions(+), 22 deletions(-) diff --git a/net.c b/net.c index ec4745d..15ed40b 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include "qemu-common.h" #include "qemu_socket.h" #include "hw/qd

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Anthony Liguori
On 02/23/2011 05:38 PM, Juan Quintela wrote: Anthony Liguori wrote: On 02/23/2011 05:00 PM, Juan Quintela wrote: Anthony Liguori wrote: The goal is to enable the monitor to run independently of whether the machine has been created such that the monitor can be used to spec

Re: [Qemu-devel] [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Anthony Liguori
On 02/23/2011 03:47 PM, Juan Quintela wrote: We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu_file_set_rate_limit() function. I think this is bad form generally speakin

[Qemu-devel] Re: [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state().

2011-02-23 Thread Juan Quintela
Yoshiaki Tamura wrote: > Introduce skip_header parameter to qemu_loadvm_state() so that it can > be called iteratively without reading the header. > > Signed-off-by: Yoshiaki Tamura > --- > migration.c |2 +- > savevm.c| 24 +--- > sysemu.h|2 +- > 3 files c

[Qemu-devel] Re: [PATCH 05/18] vl.c: add deleted flag for deleting the handler.

2011-02-23 Thread Juan Quintela
Yoshiaki Tamura wrote: > Make deleting handlers robust against deletion of any elements in a > handler by using a deleted flag like in file descriptors. > > Signed-off-by: Yoshiaki Tamura > --- > vl.c | 13 + > 1 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/vl.c

[Qemu-devel] [Bug 723460] Re: qemu on linux doesn't boot for winxp install via usb

2011-02-23 Thread dankoe
hey stefan, I didn't find any manual for installing via usb, but I tried various letters till "g". what letter would you suggest? on my usb drive I have a linux bootable xp partition. or should I try to boot from a virtual drive via .iso image? thank you -- You received this bug notification b

[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > On 02/23/2011 05:00 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> The goal is to enable the monitor to run independently of whether the >>> machine >>> has been created such that the monitor can be used to specify all of the >>> parameters for machine ini

[Qemu-devel] Re: [PATCH 18/28] migration: convert current_migration from pointer to struct

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > On 02/23/2011 03:47 PM, Juan Quintela wrote: >> This cleans up a lot the code as we don't have to check anymore if >> the variable is NULL or not. >> >> Signed-off-by: Juan Quintela >> > > Yeah, but now you have to check for MIG_STATE_NONE. I don't think > this is an

[Qemu-devel] [PATCH 11/28] migration: Introduce migrate_fd_completed() for consistenncy

2011-02-23 Thread Juan Quintela
This function is a bit different of the others that change the state, in the sense that if migrate_fd_cleanup() returns an error, it set the status to error, not completed. Signed-off-by: Juan Quintela --- migration.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-)

[Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode

2011-02-23 Thread Anthony Liguori
On 02/23/2011 03:57 PM, Stefan Weil wrote: Am 16.02.2011 21:16, schrieb Anthony Liguori: On 02/16/2011 01:48 PM, Stefan Weil wrote: Reverse mode is unusable: qemu -vnc localhost:5500,reverse crashes in vnc_refresh_server_surface because some pointers are NULL. Fix this by calling vnc_dpy

Re: [Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen

2011-02-23 Thread Anthony Liguori
On 02/04/2011 02:05 AM, Corentin Chary wrote: agraf reported that qemu_mutex_destroy(vs->output_mutex) while failing in vnc_disconnect_finish(). It's because vnc_worker_thread_loop() tries to unlock the mutex while not locked. The unlocking call doesn't fail (pthread bug ?), but the destroy call

[Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode

2011-02-23 Thread Anthony Liguori
On 02/16/2011 01:48 PM, Stefan Weil wrote: Reverse mode is unusable: qemu -vnc localhost:5500,reverse crashes in vnc_refresh_server_surface because some pointers are NULL. Fix this by calling vnc_dpy_resize (which initializes these pointers) before calling vnc_refresh. Cc: Anthony Lig

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Anthony Liguori
On 02/23/2011 05:00 PM, Juan Quintela wrote: Anthony Liguori wrote: The goal is to enable the monitor to run independently of whether the machine has been created such that the monitor can be used to specify all of the parameters for machine initialization. Signed-off-by: Anthony Liguori

[Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > On 02/23/2011 04:46 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 02/23/2011 03:47 PM, Juan Quintela wrote: >>> We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->fi

Re: [Qemu-devel] [PATCH 18/28] migration: convert current_migration from pointer to struct

2011-02-23 Thread Anthony Liguori
On 02/23/2011 03:47 PM, Juan Quintela wrote: This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. Signed-off-by: Juan Quintela Yeah, but now you have to check for MIG_STATE_NONE. I don't think this is an improvement. Regards, Anthony Liguori

[Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Anthony Liguori
On 02/23/2011 04:46 PM, Juan Quintela wrote: Anthony Liguori wrote: On 02/23/2011 03:47 PM, Juan Quintela wrote: We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu

[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > The goal is to enable the monitor to run independently of whether the machine > has been created such that the monitor can be used to specify all of the > parameters for machine initialization. > > Signed-off-by: Anthony Liguori I agree that it is one step in the right d

[Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > On 02/23/2011 03:47 PM, Juan Quintela wrote: >> We are setting a pointer to a local variable in the previous line, just use >> the global variable directly. We remove the ->file test because it is >> already >> done inside qemu_file_set_rate_limit() function. >> > >

[Qemu-devel] [PATCH 28/28] migration: make migration-{tcp, unix} consistent

2011-02-23 Thread Juan Quintela
Files are almost identical in functionality, just remove the differences that make no sense. Signed-off-by: Juan Quintela --- migration-tcp.c | 15 ++- migration-unix.c | 46 +- 2 files changed, 35 insertions(+), 26 deletions(-) diff

[Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-23 Thread Juan Quintela
Yoshiaki Tamura wrote: > This code implements VM transaction protocol. Like buffered_file, it > sits between savevm and migration layer. With this architecture, VM > transaction protocol is implemented mostly independent from other > existing code. Could you explain what is the difference with

[Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode

2011-02-23 Thread Stefan Weil
Am 16.02.2011 21:16, schrieb Anthony Liguori: On 02/16/2011 01:48 PM, Stefan Weil wrote: Reverse mode is unusable: qemu -vnc localhost:5500,reverse crashes in vnc_refresh_server_surface because some pointers are NULL. Fix this by calling vnc_dpy_resize (which initializes these pointers) b

[Qemu-devel] [PATCH 22/28] savevm: avoid qemu_savevm_state_iteate() to return 1 when qemu file has error.

2011-02-23 Thread Juan Quintela
From: Yoshiaki Tamura When qemu on the receiver gets killed during live migration, if debug is turned on, migrate_fd_put_ready() says, migration: done iterating and proceeds. The reason was qemu_savevm_state_iterate() returning 1 even when qemu file has error. This patch checks qemu_file_has_

[Qemu-devel] [PATCH 15/28] migration: Move exported functions to the end of the file

2011-02-23 Thread Juan Quintela
This means we can remove the two forward declarations. Signed-off-by: Juan Quintela --- migration.c | 189 +-- 1 files changed, 92 insertions(+), 97 deletions(-) diff --git a/migration.c b/migration.c index dba9034..caf5044 100644 --- a/m

[Qemu-devel] [PATCH 23/28] migration: add error handling to migrate_fd_put_notify().

2011-02-23 Thread Juan Quintela
From: Yoshiaki Tamura Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed, since migrate_fd_put_notify() isn't checking error of underlying QEMUFile, those resources are kept open. This patch checks it and calls migrate_fd_error() in case of error. Signed-off-by: Yoshiaki Tamura

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-23 Thread Stefan Weil
Am 04.02.2011 13:30, schrieb Anthony Liguori: On 02/02/2011 01:28 PM, Stefan Weil wrote: Hello, these are some patches which I found on my stack of open patches. All of them should go into 0.14, and at least some of them could also be applied to 0.13. This need the following Acks: [PATCH] h

[Qemu-devel] [PATCH 07/28] migration: move migrate_create_state to do_migrate

2011-02-23 Thread Juan Quintela
Once there, remove all parameters that don't need to be passed to *start_outgoing_migration() functions Signed-off-by: Juan Quintela --- migration-exec.c | 19 +-- migration-fd.c | 22 ++ migration-tcp.c | 22 +++--- migration-unix.c |

[Qemu-devel] [PATCH 24/28] migration: Don't use callback on file defining it

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-tcp.c |4 ++-- migration-unix.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index 9418abd..6acf6c6 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -59,7 +59,7 @@ static void

[Qemu-devel] [PATCH 20/28] migration: Export a function that tells if the migration has finished correctly

2011-02-23 Thread Juan Quintela
This will allows us to hide the status values. Signed-off-by: Juan Quintela --- migration.c |4 ++-- migration.h |2 +- ui/spice-core.c |4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 49cdf72..493c2d7 100644 --- a/migrat

[Qemu-devel] [PATCH 19/28] migration: Use bandwidth_limit directly

2011-02-23 Thread Juan Quintela
Now that current_migration is static, there is no reason for max_throotle variable. Signed-off-by: Juan Quintela --- migration.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/migration.c b/migration.c index f8c6d09..49cdf72 100644 --- a/migration.c +++ b/

[Qemu-devel] [PATCH 14/28] migration: Remove migration cancel() callback

2011-02-23 Thread Juan Quintela
It is used only in one place Signed-off-by: Juan Quintela --- migration.c |9 - migration.h |1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index c1732e5..dba9034 100644 --- a/migration.c +++ b/migration.c @@ -132,12 +132,12 @@ free_

[Qemu-devel] [PATCH 13/28] migration: Remove get_status() accessor

2011-02-23 Thread Juan Quintela
It is only used inside migration.c, and fields on that struct are accessed all around the place on that file. Signed-off-by: Juan Quintela --- migration.c | 16 +--- migration.h |1 - 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/migration.c b/migration.c inde

[Qemu-devel] [PATCH 25/28] migration: propagate error correctly

2011-02-23 Thread Juan Quintela
unix and tcp outgoing migration have error values, but didn't returned it. Make them return the error. Notice that EINPROGRESS & EWOULDBLOCK are not considered errors as callwill be retry later. Signed-off-by: Juan Quintela --- migration-tcp.c | 20 +++- migration-unix.c |

[Qemu-devel] [PATCH 26/28] migration: qemu_savevm_iterate has three return values

2011-02-23 Thread Juan Quintela
We were retrying when there was one error, entering a loop. Signed-off-by: Juan Quintela --- migration.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index a02100b..6082c32 100644 --- a/migration.c +++ b/migration.c @@ -269,6 +269,7 @@ s

[Qemu-devel] [PATCH 05/28] migration: Refactor MigrationState creation

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 16 +--- migration-fd.c | 16 +--- migration-tcp.c | 15 +-- migration-unix.c | 15 +-- migration.c | 29 + migration.h | 11 +++ 6 file

[Qemu-devel] [PATCH 18/28] migration: convert current_migration from pointer to struct

2011-02-23 Thread Juan Quintela
This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. Signed-off-by: Juan Quintela --- migration.c | 121 --- 1 files changed, 49 insertions(+), 72 deletions(-) diff --git a/migration.c b/migratio

[Qemu-devel] [PATCH 12/28] migration: Our release callback was just free

2011-02-23 Thread Juan Quintela
We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed migration (it can't be a sucessful one, otherwise

[Qemu-devel] [PATCH 27/28] migration: If there is one error, it makes no sense to continue

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- buffered_file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index 8435a31..3c917ff 100644 --- a/buffered_file.c +++ b/buffered_file.c @@ -195,7 +195,7 @@ static int buffered_rate_limit(void *opaque)

[Qemu-devel] [PATCH 21/28] migration: Make state definitions local

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |8 migration.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/migration.c b/migration.c index 493c2d7..697c74f 100644 --- a/migration.c +++ b/migration.c @@ -31,6 +31,14 @@ do { } while (0) #endif

[Qemu-devel] [PATCH 03/28] migration: Fold MigrationState into FdMigrationState

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 10 +- migration-unix.c | 10 +- migration.c | 12 +--- migration.h | 23 +-- 6 files changed, 30 insertions(+)

[Qemu-devel] [PATCH 08/28] migration: Check that migration is active before cancel it

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 1105757..e8e593d 100644 --- a/migration.c +++ b/migration.c @@ -139,9 +139,9 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, QObject

[Qemu-devel] [PATCH 04/28] migration: Rename FdMigrationState MigrationState

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 12 ++-- migration-unix.c | 12 ++-- migration.c | 34 +- migration.h | 38 +++-

[Qemu-devel] [PATCH 17/28] migration: another case of global variable assigned to local one

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 21f5a9a..593adee 100644 --- a/migration.c +++ b/migration.c @@ -136,9 +136,8 @@ void do_info_migrate(Monitor *mon, QObject **ret_data) QDic

[Qemu-devel] [PATCH 06/28] migration: Make all posible migration functions static

2011-02-23 Thread Juan Quintela
I have to move two functions postions to avoid forward declarations Signed-off-by: Juan Quintela --- migration.c | 73 ++- migration.h | 12 - 2 files changed, 37 insertions(+), 48 deletions(-) diff --git a/migration.c b/migrat

[Qemu-devel] [PATCH 10/28] migration: Refactor and simplify error checking in migrate_fd_put_ready

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/migration.c b/migration.c index 45cc263..ed6e626 100644 --- a/migration.c +++ b/migration.c @@ -363,28 +363,26 @@ static void migrate_fd_put_ready(void *opaqu

[Qemu-devel] [PATCH 02/28] migration: Use FdMigrationState instead of MigrationState when possible

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 32 +++- migration.h | 16 2 files changed, 23 insertions(+), 25 deletions(-) diff --git a/migration.c b/migration.c index f9aaadc..7d7a2f9 100644 --- a/migration.c +++ b/migration.c @@ -34,7 +34,7 @@

[Qemu-devel] [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Juan Quintela
We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu_file_set_rate_limit() function. Signed-off-by: Juan Quintela --- migration.c |6 ++ 1 files changed, 2 insertions(+)

[Qemu-devel] [PATCH 09/28] migration: Introduce MIG_STATE_NONE

2011-02-23 Thread Juan Quintela
Use MIG_STATE_ACTIVE only when migration has really started Signed-off-by: Juan Quintela --- migration.c |6 +- migration.h | 11 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/migration.c b/migration.c index e8e593d..45cc263 100644 --- a/migration.c +++ b/

[Qemu-devel] [PATCH 01/28] migration: Make *start_outgoing_migration return FdMigrationState

2011-02-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c |4 ++-- migration-fd.c |4 ++-- migration-tcp.c |4 ++-- migration-unix.c |4 ++-- migration.c |4 ++-- migration.h |8 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/migration-exec.

[Qemu-devel] [PATCH v2 00/28] Refactor and cleanup migration code

2011-02-23 Thread Juan Quintela
v2: - make Jan^Wcheckpatch.pl happy - Yoshiaki Tamura suggestions: - include its two patches to clean things - MAX_THROTTLE define - migration_state enum - I removed spurious differences between migration-{tcp,unix} - better error propagation, after this patch: migrate -d "tcp:name_don_exi

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-23 Thread Anthony Liguori
On 02/23/2011 02:44 PM, Marcelo Tosatti wrote: Any indirect qemu state. Block migration is an example, but other examples would be VNC server information (like current password), WCE setting (depending on whether we modelled eeprom for the drivers), and persisted device settings (lots of devic

[Qemu-devel] [PATCH] Split machine creation from the main loop

2011-02-23 Thread Anthony Liguori
The goal is to enable the monitor to run independently of whether the machine has been created such that the monitor can be used to specify all of the parameters for machine initialization. Signed-off-by: Anthony Liguori diff --git a/vl.c b/vl.c index b436952..181cc77 100644 --- a/vl.c +++ b/vl.

Re: [Qemu-devel] [PATCH V6 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-23 Thread Luiz Capitulino
On Wed, 23 Feb 2011 13:25:38 -0600 Anthony Liguori wrote: > On 01/27/2011 02:20 AM, Lai Jiangshan wrote: > > Make we can inject NMI via qemu-monitor-protocol. > > We use "inject-nmi" for the qmp command name, the meaning is clearer. > > > > Signed-off-by: Lai Jiangshan > > --- > > diff --git a/h

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-23 Thread Marcelo Tosatti
On Wed, Feb 23, 2011 at 02:18:31PM -0600, Anthony Liguori wrote: > On 02/23/2011 11:18 AM, Avi Kivity wrote: > >On 02/23/2011 06:28 PM, Anthony Liguori wrote: > >> > Well specifically, it has to ask QEMU and QEMU can tell it > the current state via a nice structured data format over > Q

[Qemu-devel] GSoC 2011 project ideas

2011-02-23 Thread Luiz Capitulino
Hi there, Google will begin accepting mentoring organizations applications next week, but we count only with three projects so far. Although there doesn't seem to exist a hard deadline associated with the ideas page, nor with the number of projects, we had more than 20 projects suggestions last y

Re: [Qemu-devel] [PATCH 2/2 V1] Fixed EPROM for AMD driver compatibility under DOS with Netware driver

2011-02-23 Thread Gerhard Wiesinger
On Wed, 23 Feb 2011, Peter Maydell wrote: On 23 February 2011 18:06, Gerhard Wiesinger wrote: I'm not a git expert. Can you explain how to merge 3 commit to one output as expected? There are a number of ways to do it. I use stgit (http://www.procode.org/stgit/) to manage my patches, but if y

[Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers

2011-02-23 Thread Gerhard Wiesinger
bugfix under DOS for AMD netware driver: AMD PCNTNW Ethernet MLID v3.10 (960115), network card not found bugfix works well under DOS with: 1.) AMD NDIS driver v2.0.1 2.) AMD PCNTNW Ethernet MLID v3.10 (960115) 3.) Knoppix 6.2 --- hw/pcnet.c | 16 1 files changed, 16 insertions

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-23 Thread Anthony Liguori
On 02/23/2011 11:18 AM, Avi Kivity wrote: On 02/23/2011 06:28 PM, Anthony Liguori wrote: Well specifically, it has to ask QEMU and QEMU can tell it the current state via a nice structured data format over QMP. It's a hell of a lot easier than the management tool trying to do this outside of

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-23 Thread Anthony Liguori
On 02/23/2011 11:26 AM, Markus Armbruster wrote: I don't think it's reasonable to have three different ways to interact with qemu, all needed: the command line, reading and writing the stateful config file, and the monitor. I'd rather push for starting qemu with a blank guest and assembling (col

[Qemu-devel] Re: [PATCH] Fix conversions from pointer to int and vice versa

2011-02-23 Thread Juan Quintela
Stefan Weil wrote: > Here the int values fds[0], sigfd, s, sock and fd are converted > to void pointers which are later converted back to an int value. > > These conversions should always use intptr_t instead of unsigned long. > > They are needed for environments where sizeof(long) != sizeof(void

Re: [Qemu-devel] [PATCH V6 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-23 Thread Anthony Liguori
On 01/27/2011 02:20 AM, Lai Jiangshan wrote: Make we can inject NMI via qemu-monitor-protocol. We use "inject-nmi" for the qmp command name, the meaning is clearer. Signed-off-by: Lai Jiangshan --- diff --git a/hmp-commands.hx b/hmp-commands.hx index ec1a4db..e763bf9 100644 --- a/hmp-commands.h

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-02-23 Thread Rick Vernam
sorry, on the guest it is virtio-serial-1.1.16, not 1.1.6. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/723871 Title: qemu-kvm-0.14.0 Aborts with -vga qxl Status in QEMU: New Bug description:

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-23 Thread Anthony Liguori
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: Index: qemu/qerror.h === --- qemu.orig/qerror.h +++ qemu/qerror.h @@ -171,4 +171,13 @@ QError *qobject_to_qerror(const QObject #define QERR_VNC_SERVER_FAILED \ "{ 'class': 'VNCSe

Re: [Qemu-devel] Re: QEMU regression problems - Update FPU

2011-02-23 Thread Aurelien Jarno
On Wed, Feb 23, 2011 at 10:45:25AM +0100, Laurent Desnogues wrote: > On Wed, Feb 23, 2011 at 9:16 AM, Peter Maydell > wrote: > > On 18 February 2011 07:12, Gerhard Wiesinger wrote: > >> Issue 1.) with FPU still present > >> I tracked down the problematic code and it is a rounding error from doub

[Qemu-devel] Re: [PATCH V6 1/4 resend] nmi: convert cpu_index to cpu-index

2011-02-23 Thread Luiz Capitulino
On Mon, 21 Feb 2011 09:37:57 +0800 Lai Jiangshan wrote: > Hi, Luiz Capitulino > > Any problem? Sorry for the delay. Looks good in general to me know, there's only one small problem and it's the error message: (qemu) nmi 100 Parameter 'cpu-index' expects a CPU number (qemu) I would expe

[Qemu-devel] [PATCH] slirp: Remove some type casts caused by bad declaration of x.tp_buf

2011-02-23 Thread Stefan Weil
x.tp_buf was declared as a uint8_t array, but always used as a char array (which needed a lot of type casts). The patch includes these changes: * Fix declaration of x.tp_buf and remove all type casts. * Use offsetof() to get the offset of x.tp_buf. Signed-off-by: Stefan Weil --- slirp/tftp.c

[Qemu-devel] [Bug 723871] [NEW] qemu-kvm-0.14.0 Aborts with -vga qxl

2011-02-23 Thread Rick Vernam
Public bug reported: Host CPU is Core i7 Q820. KVM is from 2.6.35-gentoo-r5 kernel (x86_64). Host has spice-0.7.2 and spice-protocol-0.7.0. Guest is Windows XP SP3 with qxl driver 0.6.1, virtio-serial 1.1.6 and vdagent 0.6.3. qemu-kvm is started like so: qemu-system-x86_64 -cpu host -enable-kvm

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-02-23 Thread Rick Vernam
I also intended to mention that using qemu-0.14.0 works just fine; the crash only occurs with qemu-kvm-0.14.0. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/723871 Title: qemu-kvm-0.14.0 Aborts wit

Re: [Qemu-devel] [PATCH 2/2 V1] Fixed EPROM for AMD driver compatibility under DOS with Netware driver

2011-02-23 Thread Peter Maydell
On 23 February 2011 18:06, Gerhard Wiesinger wrote: > I'm not a git expert. Can you explain how to merge 3 commit to one output as > expected? There are a number of ways to do it. I use stgit (http://www.procode.org/stgit/) to manage my patches, but if you don't want to use a new tool I guess the

  1   2   3   >